AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
27,503 Commits 1 Branch 0 Tags 544 MiB
4f783f8ada
Commit Graph

622 Commits

Author SHA1 Message Date
borenet
50537e46e4 Add Jobs to tasks.json 
BUG=skia:5723
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363443002

Review-Url: https://codereview.chromium.org/2363443002
 2016-09-22 05:09:56 -07:00
mtklein
605d952893 GN: take over CommandBuffer bot 
As you suspected, I see nothing preventing us from building our side of things unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2358173002
 2016-09-21 14:01:32 -07:00
egdaniel
e4a9bd79c6 Add define of SK_ENABLE_VK_LAYERS to gn build 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357953002

Review-Url: https://codereview.chromium.org/2357953002
 2016-09-21 07:36:14 -07:00
mtklein
768dc8f496 Blacklist serialize-8888 typefacerendering_pfaMac 
BUG=skia:5778
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356753003

TBR=halcanary@google.com
NOTREECHECKS=true
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug-GN-Trybot

Review-Url: https://codereview.chromium.org/2356753003
 2016-09-20 15:41:29 -07:00
mtklein
a627b5c3b9 GN: add skia_use_mesa for OSMesa in tools. 
I tested by running
  $ out/dm --src gm --config mesa
  $ out/nanobench --config mesa --match Xfermode
... but I ran out of patience waiting for nanobench to finish.  Probably works.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357703002

Review-Url: https://codereview.chromium.org/2357703002
 2016-09-20 13:36:47 -07:00
borenet
c549212cb3 Attempt to fix nanobench upload 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356813003

Review-Url: https://codereview.chromium.org/2356813003
 2016-09-20 13:32:38 -07:00
egdaniel
15ba6d9e96 Disable failing unit tests on adreno vulkan 
As mentioned in the attached bug, these failures all seem to be caused
by driver issues that have no workarounds at this time.

BUG=skia:5777
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355883002

Review-Url: https://codereview.chromium.org/2355883002
 2016-09-20 12:39:29 -07:00
borenet
0ecd91695f Revert of Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil (patchset #1 id:1 of https://codereview.chromium.org/2298293002/ ) 
Reason for revert:
Broke all nanobench uploads, eg. https://uberchromegw.corp.google.com/i/client.skia.android/builders/Perf-Android-Clang-Nexus6p-CPU-Snapdragon810-arm64-Release-GN_Android/builds/154/steps/Upload%20perf%20results/logs/stdio

Original issue's description:
> Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil
>
> The latter is being removed in https://codereview.chromium.org/2280023003/
> Is also pinned to 3.25, whereas the former is updated more often.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298293002
>
> Committed: https://skia.googlesource.com/skia/+/f15590f803596f51d0950994b2aeb623d2d1fc24

TBR=hinoka@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2355943002
 2016-09-20 12:34:05 -07:00
mtklein
06c35c0953 GN: add skia_enable_gpu (default true) 
This lets us replace the NoGPU bot.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356853002

NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2356853002
 2016-09-20 12:28:12 -07:00
mtklein
1905098bc4 Snazzier dump log step on Android bots. 
(The failing NexusPlayer bot is a demo.)

This should make stack traces more useful, turning this sort of thing

    09-20 11:29:39.536  2978  2978 F DEBUG   :     #00 pc 00970fd0  /data/local/tmp/dm

into something like this

    09-20 11:29:39.536  2978  2978 F DEBUG   :     #00 pc 00970fd0 adjust_bounds_to_granularity(SkIRect*, SkIRect const&, VkExtent2D const&, int, int) at /b/work/skia/out/Build-Ubuntu-Clang-x86-Debug-GN_Android_Vulkan/Debug/../../../src/gpu/vk/GrVkGpu.cpp:1803  /data/local/tmp/dm

Some bots like the S7 already have good enough stack traces, e.g.

09-20 11:35:12.567   936   936 F DEBUG   :     #00 pc 00000000000bed6c  /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN13QglManagedBuf14ConfirmEntriesEv+108)
09-20 11:35:12.567   936   936 F DEBUG   :     #01 pc 00000000000b098c  /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN9QglBltLib6FillHwEPK10QglBltFillPK15QglBltColorFillPK15QglBltDepthFillPjP12QglBltStatusSB_+588)
09-20 11:35:12.567   936   936 F DEBUG   :     #02 pc 00000000000b23bc  /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN9QglBltLib9FillImageEPK10QglBltFillPK15QglBltColorFillPK15QglBltDepthFillPjP12QglBltStatusSB_+348)
09-20 11:35:12.567   936   936 F DEBUG   :     #03 pc 000000000009bb00  /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16A5xCommandBuffer22PerformConditionalFillEiiP10QglBltFillPK15QglBltColorFillP15QglBltDepthFillP12QglBltStatusS8_+256)
09-20 11:35:12.567   936   936 F DEBUG   :     #04 pc 000000000009c0c0  /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16A5xCommandBuffer23HwWriteSubpassInitClearEP10QglBltFillPK15QglBltColorFillP15QglBltDepthFillP12QglBltStatusS8_+224)
09-20 11:35:12.567   936   936 F DEBUG   :     #05 pc 0000000000072610  /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16QglCommandBuffer18WriteSubpassClearsEv+464)
09-20 11:35:12.567   936   936 F DEBUG   :     #06 pc 0000000000073ae0  /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16QglCommandBuffer12BeginSubpassEv+32)
09-20 11:35:12.567   936   936 F DEBUG   :     #07 pc 0000000000063120  /system/vendor/lib64/hw/vulkan.msm8996.so (vkCmdBeginRenderPass+224)
09-20 11:35:12.567   936   936 F DEBUG   :     #08 pc 0000000000635f60  /data/local/tmp/nanobench (_ZN24GrVkPrimaryCommandBuffer15beginRenderPassEPK7GrVkGpuPK14GrVkRenderPassjPK12VkClearValueRK16GrVkRenderTargetRK7SkIRectb+132)

or

09-20 11:42:24.557   937   937 F DEBUG   : backtrace:
09-20 11:42:24.557   937   937 F DEBUG   :     #00 pc 0000000000069404  /system/lib64/libc.so (tgkill+8)
09-20 11:42:24.557   937   937 F DEBUG   :     #01 pc 0000000000066b94  /system/lib64/libc.so (pthread_kill+68)
09-20 11:42:24.557   937   937 F DEBUG   :     #02 pc 0000000000023a28  /system/lib64/libc.so (raise+28)
09-20 11:42:24.557   937   937 F DEBUG   :     #03 pc 000000000001e358  /system/lib64/libc.so (abort+60)
09-20 11:42:24.557   937   937 F DEBUG   :     #04 pc 000000000076430c  /data/local/tmp/dm (_Z17sk_abort_no_printv+8)

These won't be affected.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2351243002

NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2351243002
 2016-09-20 11:45:11 -07:00
borenet
f44b493cb8 Fix Win toolchain asset, fix script 
BUG=skia:5764
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2351033004

Review-Url: https://codereview.chromium.org/2351033004
 2016-09-20 07:01:23 -07:00
msarett
16b15ddd4d Blacklist incomplete pngs on CG 
BUG=skia:5774
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2351083002

Review-Url: https://codereview.chromium.org/2351083002
 2016-09-20 05:50:16 -07:00
rmistry
304e6745dc Reland of Run SVGs through nanobench on all Perf bots (patchset #1 id:1 of https://codereview.chromium.org/2348563003/ ) 
Reason for revert:
skbug/5770 has been fixed.
Trying out trybots to see if this can be relanded.

Original issue's description:
> Revert of Run SVGs through nanobench on all Perf bots (patchset #5 id:120001 of https://codereview.chromium.org/2343903002/ )
>
> Reason for revert:
> Causing failures:
> https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug-GN/builds/812
>
> Original issue's description:
> > Run SVGs through nanobench on all Perf bots.
> >
> > Tested with:
> > python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001
> >
> > Example output is here:
> > https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
> > Nanobench did run on SVGs.
> >
> > BUG=skia:5757
> > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
> >
> > Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52
>
> TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:5757
>
> Committed: https://skia.googlesource.com/skia/+/be7e3c0db3caa7a86ae233a6bd26281817b83882

TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350233002

Review-Url: https://codereview.chromium.org/2350233002
 2016-09-19 13:44:25 -07:00
mtklein
d5724b0356 Add FrameworkDefs bot to the CQ. 
Word is that this bot only exists so it can be on the CQ...
but we forgot to actually put it on the CQ until last week.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352703002

Review-Url: https://codereview.chromium.org/2352703002
 2016-09-19 12:34:14 -07:00
hinoka
f15590f803 Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil 
The latter is being removed in https://codereview.chromium.org/2280023003/
Is also pinned to 3.25, whereas the former is updated more often.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298293002

Review-Url: https://codereview.chromium.org/2298293002
 2016-09-19 12:18:55 -07:00
mtklein
9f262811b7 To prep for removing CMake bots, take them off the CQ and presubmit. 
GN is now far more capable than our CMake builds.
Time to officially end that experiment.

Reminder how this lands:
  1) this CL
  2) remove the bots from the masters
  3) remove the CMake recipe files
  4) remove the CMake files

I'm willing to wait on 4) until we can do GN -> CMake generation, but I don't want the bots to hold us back.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350073002

Review-Url: https://codereview.chromium.org/2350073002
 2016-09-19 09:08:07 -07:00
mtklein
122fac3061 GN: remove old Android recipe code. 
All the Android builders, testers, and perfers are on gn_android_flavor now.

Not as scary as it looks... all the big line count changes are deletes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002

Review-Url: https://codereview.chromium.org/2352653002
 2016-09-19 07:26:42 -07:00
mtklein
cfea18abe2 Delete unused coverage recipe code. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353483003

Review-Url: https://codereview.chromium.org/2353483003
 2016-09-19 07:04:37 -07:00
update-skps
5d1110ed46 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349953002

Review-Url: https://codereview.chromium.org/2349953002
 2016-09-18 02:34:52 -07:00
msarett
c6c81e1ff8 Fix filling of incomplete images in SkSampledCodec 
The bug occurs when filling after an incomplete sampled/subset
incremental decode.

I'm also adding many truncated test pngs.

BUG=skia:5769
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343153003

Review-Url: https://codereview.chromium.org/2343153003
 2016-09-16 14:52:07 -07:00
rmistry
be7e3c0db3 Revert of Run SVGs through nanobench on all Perf bots (patchset #5 id:120001 of https://codereview.chromium.org/2343903002/ ) 
Reason for revert:
Causing failures:
https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug-GN/builds/812

Original issue's description:
> Run SVGs through nanobench on all Perf bots.
>
> Tested with:
> python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001
>
> Example output is here:
> https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
> Nanobench did run on SVGs.
>
> BUG=skia:5757
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
>
> Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52

TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5757

Review-Url: https://codereview.chromium.org/2348563003
 2016-09-16 12:06:56 -07:00
mtklein
bfef32ff0a Build with GN on CT bots. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347203002

Review-Url: https://codereview.chromium.org/2347203002
 2016-09-16 11:39:14 -07:00
mtklein
9b6c58cf67 Promote the N5 to the CQ for real. 
The experiment was a great success.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345263002

Review-Url: https://codereview.chromium.org/2345263002
 2016-09-16 11:34:08 -07:00
rmistry
1c58dcb909 Run SVGs through nanobench on all Perf bots. 
Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001

Example output is here:
https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
Nanobench did run on SVGs.

BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002

Review-Url: https://codereview.chromium.org/2343903002
 2016-09-16 11:32:34 -07:00
rmistry
3d5541dc3d Fix Seal_of_Mississippi URL and update version of SVG asset. 
BUG=skia:5757
BUG=skia:5767

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342323002

Review-Url: https://codereview.chromium.org/2342323002
 2016-09-16 08:26:35 -07:00
mtklein
f29180e65a GN: enable Vulkan on Android when API >= 24. 
Android API >= 24 implies Vulkan support, so we can have a more useful default here than 'false'.  If for some reason you wanted to turn it off, you can still override skia_use_vulkan.

The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not have an ndk_api argument defined in their BUILDCONFIG.gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003

Review-Url: https://codereview.chromium.org/2347843003
 2016-09-16 07:01:17 -07:00
mtklein
fe6ca0f798 GN: port Valgrind bots. 
This was suspiciously easy...

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342923002

Review-Url: https://codereview.chromium.org/2342923002
 2016-09-15 13:50:43 -07:00
djsollen
615af784ab Revert of Update version of SVG asset (patchset #1 id:1 of https://codereview.chromium.org/2341043003/ ) 
Reason for revert:
breaking the build

Original issue's description:
> Update version of SVG asset
>
> BUG=skia:5757
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341043003
>
> Committed: https://skia.googlesource.com/skia/+/ab00f4222c9fff8c08873e1218e79f49845f95a1

TBR=borenet@google.com,rmistry@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5757

Review-Url: https://codereview.chromium.org/2337763007
 2016-09-15 13:04:41 -07:00
mtklein
1fbdf98d0e GN: support 32-bit x86 builds 
Take over Ubuntu -x86- bots.

Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental.
We'll want target_cpu="x86" there too.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008

Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542

CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot

Review-Url: https://codereview.chromium.org/2340463008
 2016-09-15 12:07:48 -07:00
rmistry
ab00f4222c Update version of SVG asset 
BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341043003

Review-Url: https://codereview.chromium.org/2341043003
 2016-09-15 11:31:25 -07:00
mtklein
56d5669095 Revert of GN: support 32-bit x86 builds (patchset #6 id:100001 of https://codereview.chromium.org/2340463008/ ) 
Reason for revert:
https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86-Debug-GN_Android/builds/304

Original issue's description:
> GN: support 32-bit x86 builds
>
> Take over Ubuntu -x86- bots.
>
> Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental.
> We'll want target_cpu="x86" there too.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008
>
> Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542

TBR=jcgregorio@google.com,borenet@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2338173004
 2016-09-15 11:18:56 -07:00
mtklein
1949386ae0 GN: support 32-bit x86 builds 
Take over Ubuntu -x86- bots.

Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental.
We'll want target_cpu="x86" there too.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008

Review-Url: https://codereview.chromium.org/2340463008
 2016-09-15 11:06:25 -07:00
mtklein
1bf8e6e16e Blacklist slsrgb + image decoding. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345723003

Review-Url: https://codereview.chromium.org/2345723003
 2016-09-15 11:02:05 -07:00
rmistry
5caf398cac Add ability to create and upload SVGs from a local dir 
BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346663003

Review-Url: https://codereview.chromium.org/2346663003
 2016-09-15 09:33:08 -07:00
borenet
e715d2daf7 Fix NoGPU bot, which is compiling in GPU support 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342683003

Review-Url: https://codereview.chromium.org/2342683003
 2016-09-15 09:08:48 -07:00
mtklein
0973a371ec Pass rietveld as the default patch_storage. 
Passing around empty strings as command line arguments requires
us to be really careful about command line quoting, parsing, etc.

It seems easy enough here to just supply the implied value.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323233003

Review-Url: https://codereview.chromium.org/2323233003
 2016-09-15 08:27:33 -07:00
mtklein
09b352f75f Tidy up DM blacklists. 
No need to blacklist specific instances of configs that won't be run.
There's no bug or anything here... this is entirely about keeping the
command lines as noise-free as possible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341963003

Review-Url: https://codereview.chromium.org/2341963003
 2016-09-15 06:24:03 -07:00
rmistry
90d0bfae4e Roll recipe DEPS 
BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2339443003
 2016-09-15 04:52:21 -07:00
mtklein
88e670ff6a CQ update 
- swap the N5 experiment over to the new GN N5 bot

  - cut down on the Windows build duplication: the other two bots
    cover x86, x86-64, Release, Debug, _and_ Vulkan already.

  - remove the Release-Shared tester: I added this bot to act as a proxy
    for the also Shared-build Android bots, but 1) they're fast enough
    to no longer need a proxy (see N5 above) and 2) they're no longer
    Shared builds.  I intend to completely drop support for dm and
    nanobench in Shared builds, so this bot will not just drop from the
    CQ but completely disappear.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346463002

Review-Url: https://codereview.chromium.org/2346463002
 2016-09-14 11:20:59 -07:00
mtklein
7de2d40dcc merge run and check-rc steps 
This'll make the 'dm' or 'nanobench' step go red like you'd hope.

The N5 should pass and the N10 and N7 should fail, showing us both sides.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339713003

Review-Url: https://codereview.chromium.org/2339713003
 2016-09-14 11:15:54 -07:00
mtklein
896ddb706d 565 is not this important. 
Reduce its testing and perfing to just the fast Linux bots,
and remove it from the default set of dm/nanobench configs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344553002

Review-Url: https://codereview.chromium.org/2344553002
 2016-09-14 10:33:13 -07:00
mtklein
4ff7871ed3 update derive_compile_bot_name() for GN_Android_Vulkan 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336233005

Review-Url: https://codereview.chromium.org/2336233005
 2016-09-14 05:44:31 -07:00
mtklein
53c02e0156 Android GN scripts: distingush directories for data and binaries. 
This enables data reuse, e.g. https://luci-milo.appspot.com/swarming/task/313eff129c753d10 or https://luci-milo.appspot.com/swarming/task/313f17a174c6c710

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203004

Review-Url: https://codereview.chromium.org/2335203004
 2016-09-14 05:33:11 -07:00
mtklein
357f9d2032 Update gn_android_flavor for Vulkan. 
C.f. https://codereview.chromium.org/2336343002 for basic GN support.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004

Review-Url: https://codereview.chromium.org/2333293004
 2016-09-13 13:50:10 -07:00
mtklein
ea8b2b076c Android GN: don't reboot before running 
We're already rebooting after running, so we should already be ready to go when the task starts.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334223003

Review-Url: https://codereview.chromium.org/2334223003
 2016-09-13 13:13:54 -07:00
mtklein
649985a530 Remove clear /data/local/tmp steps. 
These were intended to prevent GN and GYP Android bots from stomping on
each other.  Turns out, they don't, even without this... they're writing
most files to completely separate paths:
  - GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard
    and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher)
    in /data/local/tmp;
  - GN puts everything under /data/local/tmp, and its binaries (dm, nanobench)
    don't overlap GYP's.

So clearing /data/local/tmp was essentially just removing GN's data; GYP's
data file caching was never affected and can't conflict with GN's.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002

Review-Url: https://codereview.chromium.org/2340473002
 2016-09-13 11:17:58 -07:00
msarett
f7eb6fc71a Implement Fill() for incomplete decodes to RGBA_F16 
Before this patch, we would hit an SkASSERT(false).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203002

Review-Url: https://codereview.chromium.org/2335203002
 2016-09-13 09:04:11 -07:00
kjlubick
f06e518300 Add Nexus5 to CQ as an experiment 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332353002

Review-Url: https://codereview.chromium.org/2332353002
 2016-09-13 08:48:27 -07:00
mtklein
5718b2df4c I missed an infra_step, pushing directories. 
NOTREECHECKS=true

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2337793003

Review-Url: https://codereview.chromium.org/2337793003
 2016-09-13 07:20:47 -07:00
mtklein
41313595f9 Mark infra steps as infra_step in GN recipe flavors. 
NOTREECHECKS=true

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329943004

Review-Url: https://codereview.chromium.org/2329943004
 2016-09-13 05:49:16 -07:00
borenet
ea5de1ff1d Add back the GalaxyS3 and GalaxyS4 entries in recipes 
S3 is needed for some recipe simulation stuff and in general having
these present does not hurt us.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336513003

Review-Url: https://codereview.chromium.org/2336513003
 2016-09-12 14:02:14 -07:00
mtklein
df5df81084 GN: Android perf/tests 
Just to take inventory of which old problems still linger and which are now moot, I've gone out of my way to have this stand alone.  All of gn_android_flavor's logic is self contained, without any dependency on the platform_tools scripts.

The tricky bits turn out to be, copying directories containing symlinks---or really any copying involving more than one file---and getting the exit code back from adb shell.  Luckily the ADB I've got on my desktop and my Nexus 5x seems to handle this all without the awkward workarounds you see here, so there's hope that One Day Soon the weird parts (basically, anything with inline python) can go away.  Once we've got these bots landed green, I'll go see whether the fixes are due to ADB updates, Android updates, or perhaps something else like hardware.

The parts marked TEMPORARY are a nod to the fact that the devices are used by gn_android_flavor and android_flavor both today.  It's mostly about not stepping on each other's toes or leaving anything laying around that might confuse each other.  The marked parts can go away when bots are either gn_ or non-gn_ but not both.

I have omitted a few steps that may be important, but which are easy independent follow-ups:
  - running as root
  - locking clocks
  - waiting on battery levels
  - fancier wait-for-ready than adb wait-for-usb-device
It'd be nice to, e.g., reaffirm that locking clocks helps perf stability, and that we're locking to the best policy.  I've tried to keep this CL as trim as possible, leaving any of these vaguely optional steps for later.

As of PS 41 or so, it looks like the trybots are all behaving as expected.
We should expect no new images in Gold.  Can we see trybots in Perf yet?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2320153002

CQ_INCLUDE_TRYBOTS=master.client.skia.android:Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot

Review-Url: https://codereview.chromium.org/2320153002
 2016-09-12 12:24:38 -07:00
borenet
09524ae429 Fix device cfg for GalaxyS7 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330093002

Review-Url: https://codereview.chromium.org/2330093002
 2016-09-12 11:56:37 -07:00
borenet
f5b7a5490b Run recipes.py with --timestamps 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330123002

Review-Url: https://codereview.chromium.org/2330123002
 2016-09-12 11:51:26 -07:00
update-skps
dddbbda3f3 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334483002

Review-Url: https://codereview.chromium.org/2334483002
 2016-09-11 02:21:46 -07:00
borenet
a42405aa52 Fix issues in assets scripts 
- Delete unconditionally uses 'gsutil'
- args.gsutil not plumbed properly

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326663002

Review-Url: https://codereview.chromium.org/2326663002
 2016-09-09 05:37:29 -07:00
kjlubick
b4403ee980 Fix strange failures on Android N 
We were seeing problems where dm ended with exit code 0, but the step still failed.
It seems they changed what N returns when a thing completes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319843003
TBR=bugsbunny

Review-Url: https://codereview.chromium.org/2319843003
 2016-09-08 13:04:31 -07:00
mtklein
3b10b37a1c most is fine for *SAN bots now 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326553002

Review-Url: https://codereview.chromium.org/2326553002
 2016-09-08 09:30:20 -07:00
mtklein
e19c179281 Clean up target_os=llvm now that it does nothing. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317373004

Review-Url: https://codereview.chromium.org/2317373004
 2016-09-08 09:19:00 -07:00
mtklein
2b3c2a3ff9 GN: add sanitize arg 
Attempt to take over all *SAN builds.

MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py.
I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier
to use locally.

The compile steps should be much faster now.  We no longer build CMake
and Clang for every run, instead using the clang_linux CIPD package.  This
removes the need for all the third_party/externals/llvm/... dependencies.

Similarly, since we're using the clang_linux package, we no longer depend
on Chrome's Clang, and thus no longer need to sync chromium on these bots.

Instead of packaging up MSAN libraries and llvm-symbolizer in the compile
output, I have the test / perf bots also depend on the clang_linux package.
These do not vary from build to build.

No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja
all track changes to xsan.blacklist without our help.

This has the incidental effect of upgrading the compiler used by *SAN
bots from Clang 3.8 to Clang 3.9.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289343002

Review-Url: https://codereview.chromium.org/2289343002
 2016-09-08 08:39:34 -07:00
borenet
2172d55eb5 Asset management: Download from GS store instead of CIPD 
This avoids strange CIPD symlink/permissions issues

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321623003

Review-Url: https://codereview.chromium.org/2321623003
 2016-09-08 06:55:59 -07:00
mtklein
34ffb342f5 GN: do not set default GN args 
It's just visual noise... this should make future gn_flavor.py
changes show fewer incidental diffs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324573002

Review-Url: https://codereview.chromium.org/2324573002
 2016-09-08 06:49:05 -07:00
msarett
e99883f33b Add color xform support to SkWebpCodec 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002

Committed: https://skia.googlesource.com/skia/+/828ed1777da74692d0c8a5834017929f5aedcc6b
Review-Url: https://codereview.chromium.org/2294993002
 2016-09-08 06:05:35 -07:00
msarett
2eb00e7b77 Revert of Add color xform support to SkWebpCodec (patchset #2 id:80001 of https://codereview.chromium.org/2294993002/ ) 
Reason for revert:
Windows bots hate it when I upload new images.

Original issue's description:
> Add color xform support to SkWebpCodec
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002
>
> Committed: https://skia.googlesource.com/skia/+/828ed1777da74692d0c8a5834017929f5aedcc6b

TBR=scroggo@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2318253004
 2016-09-07 18:53:14 -07:00
msarett
828ed1777d Add color xform support to SkWebpCodec 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002

Review-Url: https://codereview.chromium.org/2294993002
 2016-09-07 18:05:24 -07:00
mtklein
1a9466799e clang_linux: also build an MSAN libc++ 
This will be used by MSAN bots: build with -stdlib=libc++,
then run with LD_LIBRARY_PATH=/path/to/clang_linux/msan.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324503002

Review-Url: https://codereview.chromium.org/2324503002
 2016-09-07 12:26:53 -07:00
borenet
e72daf6116 Run install-sysroot script before 'gn gen' on PDFium bot 
BUG=skia:5727
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317013002

Review-Url: https://codereview.chromium.org/2317013002
 2016-09-07 08:34:13 -07:00
kjlubick
eb2a27137e Add 6p to other device mapping 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319593002

Review-Url: https://codereview.chromium.org/2319593002
 2016-09-07 07:08:52 -07:00
brianosman
2c4b64e92a New gamut GM, to test gamut conversion in various code-paths 
After several different strategies, this one appears to work
well. The basic test:

1) For a variety of drawing techniques, we render fixed size
   rectangles. (Solid colors via paint color, bitmap, etc...)
2) For each method in #1, we render to both an sRGB and
   WideGamutRGB offscreen surface. (AdobeRGB isn't wide enough
   to clearly demonstrate if things are working or not).
3) Use readPixels to fetch the raw (still in wide gamut) pixel
   data, then draw that directly to the final canvas.

So, for each pair of squares, they should look clearly
different. Currently, with the GPU backend, only the bicubic
bitmap paths have that behavior. Adding more test cases (and
fixing the ones that are already incorrect) will be the long
tail of gamut transformation.

Current output (with my other patchset, which fixes all
bitmap draws): https://screenshot.googleplex.com/wsL3x7eCtWE.png

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293173002

Review-Url: https://codereview.chromium.org/2293173002
 2016-09-07 07:04:45 -07:00
mtklein
b58fe9b899 GN: turn off ccache 
I just burned 2 days debugging a confusing interaction between ccache
and the -fsanitize-blacklist argument to Clang.  Let's see if we can
live without ccache (swarming affinity + Ninja seems pretty decent).

As a point of reference, the Mac bots have been looking for ccache but
failing to find it.  They're proof this will be fine.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2310063003

Review-Url: https://codereview.chromium.org/2310063003
 2016-09-07 05:12:34 -07:00
bsalomon
b2be02bb39 Update Windows build to use VULKAN_SDK rather than VK_SDK_PATH 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318633002

Review-Url: https://codereview.chromium.org/2318633002
 2016-09-06 08:40:51 -07:00
kjlubick
f54c00e817 Add device mapping for Nexus 6p (angler) 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2311253002

Review-Url: https://codereview.chromium.org/2311253002
 2016-09-06 07:39:30 -07:00
update-skps
3b4bc7465a Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2311643002

Review-Url: https://codereview.chromium.org/2311643002
 2016-09-04 02:15:51 -07:00
jcgregorio
b55d98dda1 pdfium: Fix the pdfium builder. 
BUG=skia:5715
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300703007

Review-Url: https://codereview.chromium.org/2300703007
 2016-09-02 12:36:05 -07:00
borenet
32799a45ec [task scheduler] Fix CIPD package versions 
BUG=skia:5626
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301413003

Review-Url: https://codereview.chromium.org/2301413003
 2016-09-02 12:16:56 -07:00
borenet
443c5843aa [task scheduler] Add extra_args in tasks.json 
NOTREECHECKS=true
BUG=skia:5626
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301313002

Review-Url: https://codereview.chromium.org/2301313002
 2016-09-02 08:58:38 -07:00
mtklein
795423198b GN: Build and link with LLD when using our Clang toolchain. 
I am hoping this makes it easier to get *SAN bots going.
Today we're generating a libcompiler_rt.a that's using a
relocation type that the ld on the bots doesn't know about.
This lld is will know about anything our Clang generates.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301273002

Review-Url: https://codereview.chromium.org/2301273002
 2016-09-01 15:51:03 -07:00
mtklein
d592a4e534 The *SAN bots are now all Clang bots. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2306733002

Review-Url: https://codereview.chromium.org/2306733002
 2016-09-01 15:49:44 -07:00
mtklein
67f6636b20 Remove tsan.supp. 
The remaining suppression (libwebp) is already covered by the
compile-time blacklist, tools/xsan.blacklist.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300193002

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,Test-Ubuntu-Clang-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot

Review-Url: https://codereview.chromium.org/2300193002
 2016-09-01 14:57:35 -07:00
mtklein
ae509db481 GN: expunge all environment variables that have no effect on GN 
This should have no practical effect.  I just want to make sure no
environment variables beyond $PATH have any effect on GN builds.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300173002

Review-Url: https://codereview.chromium.org/2300173002
 2016-09-01 13:19:21 -07:00
borenet
de3184fd84 Add infra/bots/tasks.json 
This is an initial version which adds a trio of buildbot-less bots. I
expect these to be totally broken while I work out the issues.

In the future, we'll have a script to generate tasks.json.

BUG=skia:5626
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302983002

Review-Url: https://codereview.chromium.org/2302983002
 2016-09-01 12:32:23 -07:00
mtklein
2b44853c53 preserve GN_Android in compile -> test mapper 
doesn't seem anything tests this?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2306603002

Review-Url: https://codereview.chromium.org/2306603002
 2016-09-01 08:47:25 -07:00
mtklein
b987afa7cc Remove empty {lsan,ubsan}.supp files. 
We never used ubsan.supp,
and LSAN suppressions are now built into the test binaries.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803003

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot

Review-Url: https://codereview.chromium.org/2302803003
 2016-09-01 08:08:03 -07:00
mtklein
da8f6546da Add and use a clang_linux asset. 
This gives us a consistent Clang toolchain on Linux bots,
most importantly for *SAN bots.  It's ~300MB unpacked.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294353002

Review-Url: https://codereview.chromium.org/2294353002
 2016-08-31 12:35:21 -07:00
mtklein
982e7c502f switch CQ over to GN_Android compile bots 
These are going to replace the old compile bots.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294303002

Review-Url: https://codereview.chromium.org/2294303002
 2016-08-31 08:42:06 -07:00
mtklein
272b311298 GN: forgot Clang+ccache fix on Android. And sort. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298203002

No trybots for these yet...
NOTRY=true
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2298203002
 2016-08-31 05:03:31 -07:00
mtklein
82023d590c add gn_android_flavor 
This ought to support compiles for now.

Am I picking up my CIPD ndk packages right?

The main thing to note is that I'm passing the target_arch directly through
as target_cpu.  This means these bots will have a slightly different naming
convention than we've been using, but it'll agree with what you must type
yourself when using GN to build for Android:

  - Arm7 -> arm
  - Arm64 -> arm64
  - Mips -> mipsel
  - Mips64 -> mips64el
  - x86 -> x86 (unchanged)
  - x86_64 -> x64

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292663002

Review-Url: https://codereview.chromium.org/2292663002
 2016-08-29 13:14:55 -07:00
update-skps
839d3ad854 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286143002

Review-Url: https://codereview.chromium.org/2286143002
 2016-08-28 01:53:34 -07:00
mtklein
cab0bb7fc6 GN: support compiler_prefix, use it for ccache on bots. 
This makes it considerably easier to use ccache with the Android NDK.
You can now just set
  compiler_prefix = "ccache"
  ndk = "/path/to/ndk"
and we'll use the NDK clang, wrapped with ccache.

The name compiler_prefix is stolen from / compatible with Chrome.

If you have ccache, you can just always leave compiler_prefix="ccache" enabled.
This should make it an unusual thing for humans to have to change cc or cxx.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281163002

Review-Url: https://codereview.chromium.org/2281163002
 2016-08-26 13:43:19 -07:00
mtklein
f0f489062a Add Mac NDK asset, and fetch NDK on Android compile bots. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2284813002

Review-Url: https://codereview.chromium.org/2284813002
 2016-08-26 11:22:54 -07:00
mtklein
5580c69135 add an asset for the Linux Android NDK. 
I have run create_and_upload.py... cipd is uploading now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275093003

Review-Url: https://codereview.chromium.org/2275093003
 2016-08-26 10:52:19 -07:00
fmalita
30afa71dd3 Remove SVG serialization suppressions 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282883002

Review-Url: https://codereview.chromium.org/2282883002
 2016-08-26 10:23:43 -07:00
fmalita
ce2fc6a045 Add imagemasksubset GM 
(GM for non-N32 SkImage subsetting)

BUG=skia:5687
R=bsalomon@google.com,robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286733002

Review-Url: https://codereview.chromium.org/2286733002
 2016-08-26 10:13:40 -07:00
rmistry
3f1c9c0a72 Apply gerrit ref if it is a Gerrit patch. 
Also:
* Pass through a new property 'patch_storage' to DM/Nanobench/Coverage. This will be used by the different frameworks to figure out if it is Rietveld or Gerrit issue.
* Calculate issue and patchset for Gerrit patches similar to Rietveld.

BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263323002

Review-Url: https://codereview.chromium.org/2263323002
 2016-08-24 05:07:06 -07:00
mtklein
a61b6d4f9e compress_r11eac_blocks() required more alignment than dst has. 
This shouldn't change any behavior except that the stores to dst
will no longer require 8-byte alignment.

Empirically it seems like we can use 4-byte alignment here,
but u8 (i.e. 1-byte alignment) is always safe.

BUG=skia:5637
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264103002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review-Url: https://codereview.chromium.org/2264103002
 2016-08-22 09:30:54 -07:00
rmistry
88bba1618c Roll recipe DEPS 
BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2266933002

Review-Url: https://codereview.chromium.org/2266933002
 2016-08-22 08:01:28 -07:00
update-skps
ce25041865 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2261983002

Review-Url: https://codereview.chromium.org/2261983002
 2016-08-21 01:51:30 -07:00
rmistry
93f366d675 Add gerrit config lines to cq.cfg 
Needed for the CQ to see Gerrit. Eg:
https://cs.chromium.org/chromium/tools/depot_tools/infra/config/cq.cfg?q=cq.cfg&sq=package:chromium&dr=C&l=9

BUG=skia:5627
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2251643005

Review-Url: https://codereview.chromium.org/2251643005
 2016-08-17 07:51:57 -07:00
mtklein
8079ba688c GN: add extra_cflags et al. 
Adding flags to the end of cc or cxx is pretty useful, but these always end up
on the command line before the GN generated flags, thus setting defaults that
GN will override.

For full flexibility we want to be able to add flags after the flags GN has
added, so that custom flags can override _it_.

I've updated the Fast bots with an example here: if we said cc="clang -O3 ...",
that '-O3' would be overriden later by the default Release-mode '-Os'.  By
putting it in extra_cflags, we get the last word: our '-O3' overrides the
default '-Os'.

Another good use case is a hypothetical Actually-Shippable-Release mode.  Our
Release mode bundles in tons of debug symbols via '-g'.  libskia.a is about 10x
larger than it needs to be when built that way, but it helps us debug the bot
failures immensely.  To build a libskia.{a,so} that you'd really ship, you can
now set extra_cflags="-g0" to override '-g'.  You could set '-march' flags there
too, '-fomit-frame-pointer', etc.

There are lots of flags that won't matter where they end up in the command line.
To keep everything simple I've put them in extra_cflags with the rest.  This means
the only time we change 'cc' or 'cxx' in our recipes is to prefix 'ccache'.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241263003

Review-Url: https://codereview.chromium.org/2241263003
 2016-08-16 09:31:16 -07:00
fmalita
b5b6de9b94 Disable Nebraska-StateSeal.svg on Win8 bots 
Temporary suppression, pending bug fix.

BUG=skia:5636
R=robertphillips@google.com,senorblanco@chromium.org
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249763002

Review-Url: https://codereview.chromium.org/2249763002
 2016-08-16 07:08:48 -07:00
fmalita
9ea494afd0 Fix up infra bot change 
Follow up to https://codereview.chromium.org/2246943002/.

R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2247903002

Review-Url: https://codereview.chromium.org/2247903002
 2016-08-15 13:38:18 -07:00
fmalita
6fb0648c35 [SVGDom] Add opacity support 
Group opacity support.  Unlike the other presentation attributes we
support thus far, group opacity is not inherited.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246943002

Review-Url: https://codereview.chromium.org/2246943002
 2016-08-15 12:45:11 -07:00
rmistry
ea246cd5fb Increase hard and io timeouts for CT builds. 
BUG=skia:5641
TBR=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249523004

Review-Url: https://codereview.chromium.org/2249523004
 2016-08-15 09:54:56 -07:00
mtklein
d5d3287fe2 Skip CompressCheckerboard unit test on N6. 
This is at least one of the failures making the bot red.
The particular signal indicates it's probably an alignment problem.

BUG=skia:5637
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245063002

CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-GCC-Nexus6-CPU-NEON-Arm7-Debug-Trybot

TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2245063002
 2016-08-15 07:47:57 -07:00
update-skps
1e4a389dbf Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249443002

Review-Url: https://codereview.chromium.org/2249443002
 2016-08-14 01:56:40 -07:00
jcgregorio
106a9ff313 Add extracting GM comments to the housekeeper bot. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237033002

Review-Url: https://codereview.chromium.org/2237033002
 2016-08-12 08:50:29 -07:00
rmistry
70c43efb6e Turn on SVGs for all Test bots 
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240153002

Review-Url: https://codereview.chromium.org/2240153002
 2016-08-12 07:25:53 -07:00
rmistry
bcba19dd02 Use SVGs CIPD package and use SVG as a DM source. 
Currently only turned on for one bot. May turn it on for more after more conversations.

BUG=skia:5628

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231943002

Review-Url: https://codereview.chromium.org/2231943002
 2016-08-11 12:36:58 -07:00
mtklein
18655efb7a GN: take over some exisiting bots 
As an experiment, instead of replacing these with -GN twins, take
them over in-place.  This should take over:

  -FAST
  -SKFOO

CQ_INCLUDE_TRYBOTS=master.client.skia:Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229463002

Review-Url: https://codereview.chromium.org/2229463002
 2016-08-11 07:51:53 -07:00
rmistry
d71fe83ac2 Update VERSION of "svg" asset. 
Removing the SVG due to the reason in https://docs.google.com/document/d/1kYRvUxZTnm1tI_0bTU0BX9jqSSTqPUhGXJVcD3Rcg2c/edit?disco=AAAAAqQSPSc

BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2232003002

Review-Url: https://codereview.chromium.org/2232003002
 2016-08-10 16:36:15 -07:00
jcgregorio
9d155afef4 Package Go 1.6.2 in CIPD 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2230853003

Review-Url: https://codereview.chromium.org/2230853003
 2016-08-10 08:44:44 -07:00
rmistry
d1cfb5bebe Add "svg" asset 
BUG=skia:5628
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2235763002

Review-Url: https://codereview.chromium.org/2235763002
 2016-08-10 07:23:51 -07:00
rmistry
5eab99183c Move ct_skps recipe from tools repo to Skia repo. 
Also move the isolate file and script from Chromium repo to the Skia repo.

BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221413002

Review-Url: https://codereview.chromium.org/2221413002
 2016-08-09 13:46:48 -07:00
rmistry
3df72283ee Use slave_build instead of checkout in run/api.py 
BUG=skia:5620
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221423002

Review-Url: https://codereview.chromium.org/2221423002
 2016-08-09 11:15:57 -07:00
borenet
1413d52c53 Speculative fix for SKP partner-dir upload 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229433002

Review-Url: https://codereview.chromium.org/2229433002
 2016-08-08 06:26:00 -07:00
borenet
dfa55f2db4 [recipes] Smush the rest of builder_spec into appropriate places, other cleanup 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219873003

Review-Url: https://codereview.chromium.org/2219873003
 2016-08-08 04:34:01 -07:00
mtklein
03591a762c finish SkLiteDL 
- makeThreadsafe()
    - fix up some alignment problems
    - drawVertices / drawPatch
    - work around drawPicture() + default paint bugs?
    - turn on tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219343002

Review-Url: https://codereview.chromium.org/2219343002
 2016-08-07 13:35:47 -07:00
update-skps
dad1aef9a8 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2220833002

Review-Url: https://codereview.chromium.org/2220833002
 2016-08-07 01:52:47 -07:00
borenet
2c3112d517 [recipes] Increase test coverage 
Remove a bunch of "pragma: no cover" by removing unused code or adding test bots to cover.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215443003

Review-Url: https://codereview.chromium.org/2215443003
 2016-08-05 06:30:10 -07:00
borenet
e2251acbaa [recipes] Separate builder_spec into compile/test/perf recipes 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205473002

Review-Url: https://codereview.chromium.org/2205473002
 2016-08-05 05:40:59 -07:00
borenet
d460a3c256 [recipes] Remove build environment vars from default_env 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002

Review-Url: https://codereview.chromium.org/2209423002
 2016-08-05 05:18:06 -07:00
msarett
b8d1aac87a Create a separate src for colorspace tests 
This will allow me to run these tests in sRGB mode, while
leaving most of the image tests disabled.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206953006

Review-Url: https://codereview.chromium.org/2206953006
 2016-08-04 12:22:06 -07:00
borenet
3f5a47599b [recipes] Fixes for Coverage bot 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002

Review-Url: https://codereview.chromium.org/2217523002
 2016-08-04 12:16:03 -07:00
borenet
c7233ef925 [recipes] Stop pretending that buildbot_spec is a step, simplify 
Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API.  As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002

Review-Url: https://codereview.chromium.org/2209343002
 2016-08-04 11:33:02 -07:00
borenet
538d5b68e8 Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes 
- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
  - no more buildbot_spec.py step
  - "real" dm and nanobench flags, instead of --dummy-flags
  - some inconsequential stuff in visualbench, which is removed anyway.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002

Review-Url: https://codereview.chromium.org/2215803002
 2016-08-04 11:07:10 -07:00
msarett
6fc699aab7 Update skimage VERSION: attempt 3 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211973002

Review-Url: https://codereview.chromium.org/2211973002
 2016-08-04 10:39:22 -07:00
mtklein
691b78423e Slim the CQ down to the GN bots, where they exist. 
If no one objects to my "GN bot plan" email, this unblocks us from removing
a bunch of non-GN bots.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207073002

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot

Review-Url: https://codereview.chromium.org/2207073002
 2016-08-04 09:47:38 -07:00
msarett
2825bad08c Revert of Update skimage VERSION: attempt 2 (patchset #1 id:1 of https://codereview.chromium.org/2213973002/ ) 
Reason for revert:
Think this is going to break Windows again.

Original issue's description:
> Update skimage VERSION: attempt 2
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213973002
>
> Committed: https://skia.googlesource.com/skia/+/d6dec3f4a1365d34e147234acf3c4a3629146457

TBR=borenet@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2216523003
 2016-08-04 07:46:44 -07:00
msarett
d6dec3f4a1 Update skimage VERSION: attempt 2 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213973002

Review-Url: https://codereview.chromium.org/2213973002
 2016-08-04 07:29:09 -07:00
borenet
aa6a80526f Revert of Update to new skimage VERSION (patchset #1 id:1 of https://codereview.chromium.org/2211633002/ ) 
Reason for revert:
The CIPD package is broken

Original issue's description:
> Update to new skimage VERSION
> TBR=borenet@google.com
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002
>
> Committed: https://skia.googlesource.com/skia/+/52d1be5ca7b1ba8cc450be7dd6377ea5bb73386a

TBR=msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2216613002
 2016-08-04 04:47:23 -07:00
msarett
52d1be5ca7 Update to new skimage VERSION 
TBR=borenet@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002

Review-Url: https://codereview.chromium.org/2211633002
 2016-08-03 15:48:32 -07:00
borenet
bc20a701d8 [Recipes] Move test and perf steps into test and perf recipes 
This looks like another big change, but I really just moved blocks of code around.  Again, no expectations diffs because no behavior is changed.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198973002

Review-Url: https://codereview.chromium.org/2198973002
 2016-08-03 10:38:44 -07:00
borenet
9e3d3d8b36 Fix fake_specs.py, update recipe expectation 
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200763002

Review-Url: https://codereview.chromium.org/2200763002
 2016-08-03 10:10:07 -07:00
borenet
1436a09e1f Re-organize Skia recipes 
Break Skia recipe module into:
  - skia_vars: defines and stores variables (eg. paths)
  - skia_step: utilities for running Skia steps
  - skia_flavor: flavor-specific stuff
  - skia: top-level setup, checkout, test/perf steps, etc etc

This establishes a saner dependency structure for the recipes; skia_vars
is at the bottom level, skia_step depends on it, skia_flavor depends on
both of them, skia depends on all of the above, and the recipes
themselves may depend on any or all of them.

Next steps:
  - Merge buildbot_spec into skia_vars
  - Move test_steps and perf_steps from skia recipe_module into
    swarm_test and swarm_perf recipes
  - Cleaner checkout_steps process

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198173002

Review-Url: https://codereview.chromium.org/2198173002
 2016-08-03 08:23:10 -07:00
borenet
b6aafe66a0 Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN 
BUG=skia:5597
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199273002

Review-Url: https://codereview.chromium.org/2199273002
 2016-08-02 07:02:52 -07:00
borenet
ed696276fd More fixes for SwarmBucket 
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true

Review-Url: https://codereview.chromium.org/2202053005
 2016-08-02 06:50:50 -07:00
borenet
d6dd44140d Roll recipe DEPS 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205863002

Review-Url: https://codereview.chromium.org/2205863002
 2016-08-02 05:11:16 -07:00
borenet
f5b675efbe Stop running nanobench on Test.*Debug bots 
We'll need to add Perf.*Debug bots to achieve the same coverage.

BUG=skia:4768
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189393002
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2189393002
 2016-08-01 05:08:52 -07:00
jcgregorio
01f696e30f perf: Upload results to gs://skia-perf, not gs://chromium-skia-gm. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197643002

Review-Url: https://codereview.chromium.org/2197643002
 2016-07-29 10:54:30 -07:00
mtklein
f6593a68d9 Add some GN builders to the CQ. 
This parallels the set of bots we use to gate commits already.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189283003

Review-Url: https://codereview.chromium.org/2189283003
 2016-07-29 10:41:37 -07:00
mtklein
830c913625 GN: ccache+clang needs -Qunused-arguments 
An alternative is to define CCACHE_CPP2, but
I thought I'd try this more visible way first.

(CCACHE_CPP2 may turn out to be required anyway
if we start seeing warnings about tautological compares.)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193203002

TBR=jcgregorio@google.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2193203002
 2016-07-29 06:03:52 -07:00
mtklein
2a1134e3f5 GN: Always quote cc and cxx. 
To fix:
    ERROR at the command-line "--args":1:34: Unexpected token '+'
    is_debug=true cc=clang cxx=clang++

TBR=jcgregorio@google.com
NOTRY=true

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193593003

Review-Url: https://codereview.chromium.org/2193593003
 2016-07-29 05:39:35 -07:00
mtklein
9081ceb123 GN: use ccache if available and the requested compiler. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186553006

Review-Url: https://codereview.chromium.org/2186553006
 2016-07-29 05:07:39 -07:00
jcgregorio
50d1847815 Fix expectations for GN bot. 
BUG=skia:

Review-Url: https://codereview.chromium.org/2191933002
 2016-07-28 11:55:51 -07:00
borenet
f49d9d77bb Add swarmbucket_wrapper recipe 
BUG=skia:5581
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185203003

Review-Url: https://codereview.chromium.org/2185203003
 2016-07-28 10:50:54 -07:00
jcgregorio
ba59595ea3 recipes: Add a GN flavor. 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189713003

Review-Url: https://codereview.chromium.org/2189713003
 2016-07-28 09:38:59 -07:00
borenet
9c18546b78 Fixes for SwarmBucket bot 
- Print all build properties for debugging purposes.
- Use correct path root for swarmbucket.
- Write a dummy .gclient file if missing.

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190933002

Review-Url: https://codereview.chromium.org/2190933002
 2016-07-28 08:58:38 -07:00
jcgregorio
4b9ebab04d upload_bench_results - fix GS upload path. 
_UploadJSONResults does '/'.join() so the trailing / is unnecessary.

BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187903003

Review-Url: https://codereview.chromium.org/2187903003
 2016-07-27 14:34:06 -07:00
borenet
151aee4220 Fix silently-failing compile 
Ouch...

TBR=rmistry
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191663002

Review-Url: https://codereview.chromium.org/2191663002
 2016-07-27 14:05:54 -07:00
kjlubick
e772aeea08 Add Vulkan runtime dll 
This gets copied into the out/ dir on compile and allows dm.exe to run anywhere, even if the Vulkan SDK is not installed.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188543002

Review-Url: https://codereview.chromium.org/2188543002
 2016-07-27 12:59:12 -07:00
borenet
9913dfca2a Make the experimental SwarmBucket bot use the SkiaTriggers pool 
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187023002

Review-Url: https://codereview.chromium.org/2187023002
 2016-07-27 12:45:35 -07:00
borenet
b53a886924 Include "revision" tag for all Swarming tasks 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186993002

Review-Url: https://codereview.chromium.org/2186993002
 2016-07-27 09:36:17 -07:00
borenet
7b2ed4c649 Fix Perf data upload 
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187603005

Review-Url: https://codereview.chromium.org/2187603005
 2016-07-27 08:51:55 -07:00
egdaniel
735109c248 Add gyp define to enable vulkan debug layers 
On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.

With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.

TBR=djsollen@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003

Review-Url: https://codereview.chromium.org/2185953003
 2016-07-27 08:03:57 -07:00
borenet
c043324e56 Tweaks for the experimental SwarmBucket bot 
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181073005

Review-Url: https://codereview.chromium.org/2181073005
 2016-07-27 07:02:08 -07:00
borenet
39683791cc Fix Housekeeper-PerCommit 
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183023004

Review-Url: https://codereview.chromium.org/2183023004
 2016-07-27 05:21:45 -07:00
borenet
1ed2ae45f5 Move Skia recipes from build repo 
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002

Review-Url: https://codereview.chromium.org/2175373002
 2016-07-26 11:52:17 -07:00
update-skps
5fa38fa287 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2177053002

Review-Url: https://codereview.chromium.org/2177053002
 2016-07-24 01:30:17 -07:00
borenet
1543487fc6 Change SKPs to new asset management format 
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169653003
DOCS_PREVIEW= https://skia.org/?cl=2169653003

Review-Url: https://codereview.chromium.org/2169653003
 2016-07-22 08:31:07 -07:00
borenet
85f0e63ca4 Add "skp" asset 
Don't get rid of SKP_VERSION and associated stuff just yet.

BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167763002
DOCS_PREVIEW= https://skia.org/?cl=2167763002

Review-Url: https://codereview.chromium.org/2167763002
 2016-07-21 10:27:00 -07:00
egdaniel
725266a9b1 Add vulkan compile bot to CQ 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166353003

Review-Url: https://codereview.chromium.org/2166353003
 2016-07-21 09:29:01 -07:00
kjlubick
f2944815e5 Add vulkan sdk to CIPD 
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164953002

Review-Url: https://codereview.chromium.org/2164953002
 2016-07-20 10:18:49 -07:00
borenet
baaea531c2 Convert SK Images to new assets format 
Depends on https://codereview.chromium.org/2162563002/

BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155163002

Review-Url: https://codereview.chromium.org/2155163002
 2016-07-18 10:36:43 -07:00
borenet
f1120ea72c Convert Win toolchain to CIPD package 
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2111713003

Review-Url: https://codereview.chromium.org/2111713003
 2016-07-15 08:34:08 -07:00
skia.buildbots
d6e8e64530 Update Win toolchain 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2116173002
NOTREECHECKS=true
NOTRY=true
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2116173002
 2016-07-01 17:29:18 -07:00
benjaminwagner
ab2b52e286 Specify new Windows Toolchain isolated hash. 
NOTREECHECKS=true
NOTRY=true
TBR=rmistry@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2121443002

Review-Url: https://codereview.chromium.org/2121443002
 2016-07-01 15:51:41 -07:00
borenet
501ca7f538 Add Android SDK asset 
This will allow us to use CIPD to install the Android SDK on bots.

BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086003002

Review-Url: https://codereview.chromium.org/2086003002
 2016-06-30 05:20:03 -07:00
rmistry
0829e49af2 Add blacklist for the Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-CT_IMG_DECODE_100k_SKPs bot 
BUG=skia:5462
BUG=skia:5466
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2101403003

# Try bots do not run this code.
NOTRY=true

Review-Url: https://codereview.chromium.org/2101403003
 2016-06-28 10:17:03 -07:00
borenet
f9bd9da14a Add CIPD support for bot assets 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085473002

Review-Url: https://codereview.chromium.org/2085473002
 2016-06-28 04:41:49 -07:00
tandrii
23e9f7c501 Make bucket names explicit in cq.cfg. 
Don't assume bucket name to start with 'master.'.

NOTRY=True
BUG=chromium:617627
R=rmistry@google.com,sergiyb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2096733005

Review-Url: https://codereview.chromium.org/2096733005
 2016-06-24 11:27:29 -07:00
rmistry
9afccaaf8e Reland of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2087913003/ ) 
Reason for revert:
Will watch this after it is in.

Original issue's description:
> Revert of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2085333002/ )
>
> Reason for revert:
> Reverting due to purple trybots in https://codereview.chromium.org/2087343002/
>
> We will have to investigate..
>
> Original issue's description:
> > add a Chrome builder to the CQ
> >
> > This appears to be the fastest Chrome builder, averaging 8-9 minutes.
> >
> > BUG=skia:
> > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002
> >
> > Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d
>
> TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/1afb8f8965b0549525c1ad8d8baa885ccdb48f6d

TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2096613002
 2016-06-23 04:16:38 -07:00
rmistry
1afb8f8965 Revert of add a Chrome builder to the CQ (patchset #1 id:1 of https://codereview.chromium.org/2085333002/ ) 
Reason for revert:
Reverting due to purple trybots in https://codereview.chromium.org/2087343002/

We will have to investigate..

Original issue's description:
> add a Chrome builder to the CQ
>
> This appears to be the fastest Chrome builder, averaging 8-9 minutes.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002
>
> Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d

TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2087913003
 2016-06-22 10:41:02 -07:00
mtklein
cb4efa90ab add a Chrome builder to the CQ 
This appears to be the fastest Chrome builder, averaging 8-9 minutes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002

Review-Url: https://codereview.chromium.org/2085333002
 2016-06-22 10:22:55 -07:00
borenet
0f1469bcda Add asset management scripts 
These provide an easy way to create assets to be used by bots,
eg. Android SDK.

To create an asset:
$ infra/bots/assets/assets.py add android_sdk
(adds scripts in infra/bots/assets/android_sdk)

To upload a new version of an asset:
$ infra/bots/assets/android_sdk/upload.py -t $ANDROID_SDK_ROOT
(uploads Android SDK to GS, writes a version file)
$ git commit
$ git cl upload

To download the current version of the asset:
$ infra/bots/assets/android_sdk/download.py -t ../tmp

BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069543002

Review-Url: https://codereview.chromium.org/2069543002
 2016-06-15 12:07:42 -07:00
borenet
09b4224be3 Add housekeeper_skia.isolate 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054883002

Review-Url: https://codereview.chromium.org/2054883002
 2016-06-09 12:58:11 -07:00
borenet
1346c25071 isolate_android_sdk: Find or download isolate binary, fix infra path 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2016353003

Review-Url: https://codereview.chromium.org/2016353003
 2016-05-27 11:11:22 -07:00
liyuqian
62d9bcc110 Update Android SDK 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2016363002

Review-Url: https://codereview.chromium.org/2016363002
 2016-05-27 08:08:34 -07:00
borenet
4ca5539df5 Add isolate_android_sdk.py script and android_sdk_hash 
BUG=skia:5298
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1975893002

Review-Url: https://codereview.chromium.org/1975893002
 2016-05-13 08:41:04 -07:00
benjaminwagner
ae5c01d52b Add XSAN suppression files to infrabots.isolate. Only compile 'dm' and 'nanobench' for XSAN flavors. 
Needed for https://codereview.chromium.org/1920283002

BUG=skia:5157
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1859413003

Review-Url: https://codereview.chromium.org/1859413003
 2016-05-04 06:35:50 -07:00
mtklein
d1adec1870 Update Win toolchain 
I believe this now correctly updates us to VS 2015 update 2.

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Win-MSVC-x86-Debug-VS2015-Trybot

https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=3c710fd7f4df8ec24fde62681536fad21be2751c

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926813007

Review-Url: https://codereview.chromium.org/1926813007
 2016-04-28 11:02:36 -07:00
rmistry
12135f50bd Add dry_run_access_list to Skia's cq.proto 
This will give all users who have access to our trybots access to our dry run CQ as well.

BUG=591183
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926783002

Review-Url: https://codereview.chromium.org/1926783002
 2016-04-27 09:43:21 -07:00
borenet
6f4c1aa8f9 Don't isolate the Skia repo for Swarming compiles 
BUG=skia:
NOTREECHECKS=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1886343002

Review URL: https://codereview.chromium.org/1886343002
 2016-04-27 06:06:25 -07:00
rmistry
eff1920deb Add new coverage_skia.isolate 
Coverage is different from the other recipes because it needs both skia_repo and test artifacts. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined.

The isolate file will be used from the updated coverage recipe in https://codereview.chromium.org/1862713002/

BUG=skia:5159
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1893503003
 2016-04-18 04:13:48 -07:00
borenet
b0070197ff More iOS swarming bot fixes 
- Copy the packaged app into xcodebuild/...
- Isolate ios/bin directory

BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860333002

Review URL: https://codereview.chromium.org/1860333002
 2016-04-06 11:38:55 -07:00
rmistry
50cff2c5ac Add valgrind suppression file to infrabots.isolate 
BUG=skia:5149
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1859083002

Review URL: https://codereview.chromium.org/1859083002
 2016-04-05 08:31:48 -07:00
borenet
cafbfe65a0 Support for Android Swarming bots 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1819033002

Review URL: https://codereview.chromium.org/1819033002
 2016-04-01 07:18:28 -07:00
borenet
15bc5603e4 Fixes for Swarming recipes 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1827413002
NOTRY=true

Review URL: https://codereview.chromium.org/1827413002
 2016-03-30 07:41:32 -07:00
kjlubick
2e59f1f2fd Splitting up wait_for_device into two pieces 
BUG=skia:5111
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1829753004

Review URL: https://codereview.chromium.org/1829753004
 2016-03-25 05:22:40 -07:00
borenet
0f5e41461a Add experimental Swarmbucket bot 
Docs here:
https://chromium.googlesource.com/infra/infra/+/master/appengine/cr-buildbucket/doc/swarming.md

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820323002

Review URL: https://codereview.chromium.org/1820323002
 2016-03-22 09:37:57 -07:00
borenet
423ba24cac Swarming: Ensure depot_tools is in PATH when compiling 
Turns out we were "lucky" for our Linux bots which already have depot_tools in PATH. The Mac bot does have depot_tools, but it's not in PATH.  Add it in the script to ensure we can always get to it.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1823653002

Review URL: https://codereview.chromium.org/1823653002
 2016-03-21 09:02:51 -07:00
borenet
98ed14ea05 Remove --verbose from DM on Swarming bots 
TBR=mtklein
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1817563002

Review URL: https://codereview.chromium.org/1817563002
 2016-03-18 11:27:43 -07:00
borenet
57d66ddf50 Fix Linux Swarming bots 
NOTRY=true
NOTREECHECKS=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1806323003

Review URL: https://codereview.chromium.org/1806323003
 2016-03-17 09:19:09 -07:00
borenet
64e9816429 Some fixes for Swarming bots 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1813443003

Review URL: https://codereview.chromium.org/1813443003
 2016-03-17 09:01:33 -07:00
borenet
523fa2a332 Fix compile on Windows swarming bot 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1791513002

Review URL: https://codereview.chromium.org/1791513002
 2016-03-16 07:27:05 -07:00
borenet
8749cfa2ca Add CMake builder to CQ 
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810523002

Review URL: https://codereview.chromium.org/1810523002
 2016-03-16 07:07:25 -07:00
borenet
2f56b1aba2 Fixes for Win toolchain isolate 
NOTRY=true
BUG=skia:4763, skia:4553
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1782943002

Review URL: https://codereview.chromium.org/1782943002
 2016-03-11 04:54:42 -08:00
borenet
2bcfb4bec3 Add isolate_win_toolchain.py 
Intended to be run manually by a developer on Windows.
Downloads the requested Windows toolchain, uploads it
to the isolate server, records the isolated hash in
the JSON file and uploads a CL to update that file.

BUG=skia:4553, skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1775073002

Review URL: https://codereview.chromium.org/1775073002
 2016-03-10 07:01:39 -08:00
borenet
f2e2a1e290 Swarming bots: fix trybots 
Requires a recipe-side change as well.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768333002

Review URL: https://codereview.chromium.org/1768333002
 2016-03-08 05:33:03 -08:00
borenet
d8d046c81f Swarming bots: add build products whitelist 
Should reduce output isolate size (and therefore upload time) for
compile task by ~10x

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768273002

Review URL: https://codereview.chromium.org/1768273002
 2016-03-07 10:57:26 -08:00
borenet
d4f89e4e39 Swarming tasks: print start and end time 
This will help determine how long each component of the task takes.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769583002

Review URL: https://codereview.chromium.org/1769583002
 2016-03-04 10:58:21 -08:00
borenet
f1215a537f Swarming bots: setup for skipping download of build products 
Turns out it's pretty easy to pass the compile outputs to the test task by just adding the hash to the "includes" list in the .isolated file.  So the flow is:
1. Isolate skia repo
2. Run compile task, record hash of results
3. Isolate test inputs for DM. This writes a .isolated file
4. Edit the .isolated file from #3 to include the hash from #2
5. Upload the modified .isolated file to the isolate server
6. Trigger the swarming task for DM
7. Wait for DM task to finish, download results from isolate server
8. Upload results to GS as normal

I expect the swarming bots to break when this is committed due to the moved out directory.  The associated recipe change will fix them.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759553003

Review URL: https://codereview.chromium.org/1759553003
 2016-03-04 04:55:26 -08:00
stephana
7c0b9feee9 Temporarily disable ios compile bot 
BUG=skia:
TBR=rmistry
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757053002

Review URL: https://codereview.chromium.org/1757053002
 2016-03-02 12:45:04 -08:00
borenet
c803ef125d Swarming bots: Add support for perf steps 
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754843002

Review URL: https://codereview.chromium.org/1754843002
 2016-03-02 08:06:27 -08:00
borenet
c58487e088 Swarming Bots: fix resource path 
TBR=rmistry
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1749873002

Review URL: https://codereview.chromium.org/1749873002
 2016-02-29 10:48:40 -08:00
borenet
ea2dabd9c8 Swarming bots: Fix tester out dir 
TBR=rmistry
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1751463002

Review URL: https://codereview.chromium.org/1751463002
 2016-02-29 10:17:38 -08:00
borenet
1e83a2a239 Fix Swarming compile out dir 
TBR=rmistry
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1743353002

Review URL: https://codereview.chromium.org/1743353002
 2016-02-29 10:06:33 -08:00
borenet
c0cb60d453 Swarming Tests: create tmp dir if it doesn't exist 
TBR=rmistry
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1749623003

Review URL: https://codereview.chromium.org/1749623003
 2016-02-29 08:39:27 -08:00
borenet
17597fe29d Swarming tests: Fix uninteresting hash file path 
TBR=rmistry
NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1746063002

Review URL: https://codereview.chromium.org/1746063002
 2016-02-29 08:19:42 -08:00
borenet
a7a6f2e01d Add test_skia.py, isolates for test_skia, images, skps 
This enables running DM through Swarming.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1743113003

Review URL: https://codereview.chromium.org/1743113003
 2016-02-29 05:57:31 -08:00
borenet
3fe4df6d8b Add luci-go isolate.sha1 files 
NOTRY=true
BUG=skia:3775, skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711013002

Review URL: https://codereview.chromium.org/1711013002
 2016-02-18 10:13:14 -08:00
borenet
d9fa758292 Port Skia recipe to normal Python scripts, move to Skia repo 
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703663002

Review URL: https://codereview.chromium.org/1703663002
 2016-02-18 08:05:48 -08:00
mtklein
3f20f511dc update CQ with new bot names 
NOTRY=true
NOTREECHECKS=true

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1675643002

Review URL: https://codereview.chromium.org/1675643002
 2016-02-05 06:10:38 -08:00
borenet
4894565528 Add Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release to the CQ 
BUG=skia:4758
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1564743003

Review URL: https://codereview.chromium.org/1564743003
 2016-01-06 10:54:50 -08:00
borenet
258ade521b Add iOS compile bot to the CQ 
BUG=skia:4252

Review URL: https://codereview.chromium.org/1501453005
 2015-12-04 10:19:21 -08:00
sergiyb
613f20aa4b Moved committer list to chrome-infra-auth and deleted it from the repo 
R=rmistry@chromium.org
BUG=chromium:511311

Review URL: https://codereview.chromium.org/1314153006
 2015-09-02 13:37:54 -07:00
rmistry
a3710c3262 Specify try_job_retry_config for Skia try jobs 
Retry config support was added to the CQ in https://chromereviews.googleplex.com/240527013/
This CL uses the retry config in Skia's cq.cfg file.

CQ's default failure_retry_weight is 1. We set it to 2 which will immediately go beyond the try job quota and will not retry for failures. It will retry for transient errors.

BUG=chromium:522460
TBR=mtklein
NOTRY=true

Review URL: https://codereview.chromium.org/1330473002
 2015-09-02 05:23:23 -07:00
nodir
f3782fa76f Build buckets: tryjob access 
Allowed project-skia-tryjob-access group to schedule builds on public
skia build buckets

R=borenet@chromium.org, rmistry@chromium.org
BUG=495680

Review URL: https://codereview.chromium.org/1256333006
 2015-07-30 10:32:27 -07:00
nodir
db8e4382a4 Skia project metadata 
Added project.cfg metadata file for chrome-infra

R=borenet@google.com, rmistry@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=507723

Review URL: https://codereview.chromium.org/1231383004
 2015-07-13 06:23:24 -07:00
mtklein
a981e74097 Add a 64-bit ARM builder to the CQ. 
It's possible this rarely breaks, but I do write ARMv8 code frequently
enough that it'll help prevent broken trees.

BUG=skia:

Review URL: https://codereview.chromium.org/1209763003
 2015-06-24 14:52:24 -07:00
sheyang
12555d7efb Add signcla verifier to skia. 
This verifier is just informative now.

BUG=457428

Review URL: https://codereview.chromium.org/1193433003
 2015-06-17 09:15:52 -07:00
sergiyb
2baef5a1e1 Added CQ config to skia repo 
This must land in sync with https://chromereviews.googleplex.com/204307013 and
revert in sync.

R=rmistry@chromium.org, tandrii@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=chromium:471767

Review URL: https://codereview.chromium.org/1153093004
 2015-06-08 05:12:56 -07:00
nodir
038b01c081 /infra directory 
Added /infra directory, it will contain chrome-infra specific files, in
particular configs for chrome infra services.

/infra/project-config/cr-buildbucket.cfg defines buckets on
cr-buildbucket.appspot.com

R=borenet@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1164633002
 2015-06-01 09:39:11 -07:00