Commit Graph

4612 Commits

Author SHA1 Message Date
junov@chromium.org
5280548558 Stop refcounting SkDeferredCanvas::NotificationClient
User code (i.e. WebKit) is now responsible for the lifetime scope of the notification client.
With http://trac.webkit.org/changeset/125804 skia-side ref counting has become unnecessary and undesirable.
Review URL: https://codereview.appspot.com/6443146

git-svn-id: http://skia.googlecode.com/svn/trunk@5169 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 14:25:04 +00:00
bsalomon@google.com
607d08b7db Set LF property on a bunch of files.
Review URL: http://codereview.appspot.com/6461094/




git-svn-id: http://skia.googlecode.com/svn/trunk@5168 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 13:55:09 +00:00
bsalomon@google.com
7aed8639b4 Rebaseline images from r5136 and Ubuntu driver change.
The following images were deleted:
base-macmini/imagefiltersbase_msaa16.png (garbage, issue 791)
base-macmini-lion-float/imagefiltersbase_msaa16.png (garbage, issue 791)
base-shuttle_ubuntu12_ati5770/imagefiltersbase_gpu.png (hairlines became thick, due to driver change, isseu 795 filed)



git-svn-id: http://skia.googlecode.com/svn/trunk@5167 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 13:31:47 +00:00
caryclark@google.com
24bec79d6f shape ops work in progress
major milestone: 35.8M tests pass
(all rect/triangle/quadralateral)

git-svn-id: http://skia.googlecode.com/svn/trunk@5166 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 12:43:57 +00:00
bensong@google.com
8ccfa55adb adds -i flag to ignore a timer for bench plots.
git-svn-id: http://skia.googlecode.com/svn/trunk@5163 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 21:42:14 +00:00
reed@google.com
a030818936 revert 5156
git-svn-id: http://skia.googlecode.com/svn/trunk@5160 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 21:13:17 +00:00
reed@google.com
dd8dd8f77b revert 5157
git-svn-id: http://skia.googlecode.com/svn/trunk@5159 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 21:10:44 +00:00
reed@google.com
cf4335ca4a add long/unsigned-long variations to the debug SkIntToScalar, as the mac compiler
makes a distinction between int and long (it appears)



git-svn-id: http://skia.googlecode.com/svn/trunk@5157 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 20:53:48 +00:00
borenet@google.com
a448cb05f0 Fix SkIntToScalar signature for 64-bit build
Review URL: https://codereview.appspot.com/6443147

git-svn-id: http://skia.googlecode.com/svn/trunk@5156 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 20:32:29 +00:00
robertphillips@google.com
ca8af884bb Deleted 3 flaky GM baselines
gm/base-android-nexus-s/giantbitmap_mirror_bilerp_rotate_gpu.png
gm/base-android-nexus-s/giantbitmap_repeat_bilerp_rotate_gpu.png
gm/base-macmini-lion-float/drawbitmaprect_msaa16.png



git-svn-id: http://skia.googlecode.com/svn/trunk@5154 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 18:37:22 +00:00
junov@chromium.org
d433c4eb67 Cleaning up deprecated API in SkDeferredCanvas
Review URL: https://codereview.appspot.com/6461077

git-svn-id: http://skia.googlecode.com/svn/trunk@5152 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 14:50:16 +00:00
robertphillips@google.com
f9a9084782 Decrease SkClipStack memory allocations & deallocations
http://codereview.appspot.com/6443138



git-svn-id: http://skia.googlecode.com/svn/trunk@5151 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 14:25:43 +00:00
bsalomon@google.com
07ea2db026 Remove unnecessary GrContext flushes
Review URL: http://codereview.appspot.com/6446150/



git-svn-id: http://skia.googlecode.com/svn/trunk@5150 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 14:06:49 +00:00
robertphillips@google.com
63ae1cfb10 Make SkDeque::back faster & inline
http://codereview.appspot.com/6462073/



git-svn-id: http://skia.googlecode.com/svn/trunk@5149 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 13:53:05 +00:00
bsalomon@google.com
1b3ce47c7b Fix clear records in IODB
Review URL: http://codereview.appspot.com/6465061/



git-svn-id: http://skia.googlecode.com/svn/trunk@5148 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 13:43:08 +00:00
bsalomon@google.com
72f3dca451 Modify Read/WritePixelTests to print one pixel failure for each test case rather than every pixel
Review URL: http://codereview.appspot.com/6450154/



git-svn-id: http://skia.googlecode.com/svn/trunk@5147 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 13:32:06 +00:00
scroggo@google.com
85cade0a10 Move tiling up into SampleWindow.
Now the tiles do not move with the view, and tiling persists when changing slides.

Review URL: https://codereview.appspot.com/6450143

git-svn-id: http://skia.googlecode.com/svn/trunk@5146 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 13:29:50 +00:00
bsalomon@google.com
0bc38e35b1 Whitespace change to trigger linux bot with proprietary ATI driver newly installed.
git-svn-id: http://skia.googlecode.com/svn/trunk@5144 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 13:17:40 +00:00
robertphillips@google.com
01ec2eb42e Added Serialization of SkPath's bound
http://codereview.appspot.com/6458143/



git-svn-id: http://skia.googlecode.com/svn/trunk@5143 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-17 10:58:49 +00:00
bsalomon@google.com
24a93569ab More rebaselines from r5136
git-svn-id: http://skia.googlecode.com/svn/trunk@5142 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 21:56:48 +00:00
reed@google.com
3b3e895df6 remove EdgeType enum. Unimportant distinction, and removing speeds up quickReject
Review URL: https://codereview.appspot.com/6448161

git-svn-id: http://skia.googlecode.com/svn/trunk@5140 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 20:53:31 +00:00
bensong@google.com
b6204b1ec4 cleaned up algorithm codes and added 25th percentile for representation.
git-svn-id: http://skia.googlecode.com/svn/trunk@5139 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 20:49:28 +00:00
bsalomon@google.com
8a5b7bc41c Rebaseline gm due to r5136
git-svn-id: http://skia.googlecode.com/svn/trunk@5138 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 20:42:40 +00:00
scroggo
c51db02181 Fix a memory leak in SkBitmapHeap.
When I switched fLookupTable to be an array of pointers, I did not
delete those pointers when I was done with them. Do it now.

Also modify SkTDArray::deleteAll to call SkDELETE instead of delete.

Review URL: https://codereview.appspot.com/6453129

git-svn-id: http://skia.googlecode.com/svn/trunk@5137 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 20:30:18 +00:00
bsalomon@google.com
1d4edd38f6 Make all GrContext draws go through the draw buffer.
Review URL: http://codereview.appspot.com/6462069/


git-svn-id: http://skia.googlecode.com/svn/trunk@5136 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 18:36:06 +00:00
reed@google.com
da17f75844 add SK_ENABLE_CLIP_QUICKREJECT option (currently disabled)
git-svn-id: http://skia.googlecode.com/svn/trunk@5135 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 18:27:05 +00:00
scroggo@google.com
460a23e6fd Fix a parenthesis bug.
SkGPipeCanvas::needOpBytes was being called with the wrong value due to a misplaced
parens in clipRect and clipPath. This can cause a crash if clip is called at just
the right (wrong) time. Instead of writing a boolean to the stream, I have added a
flag, which helps to avoid the parens problem.

Also renamed some flags from _DrawOpsFlag to _DrawOpFlag for consistency.

Lastly, added an assert that the size provided by the SkGPipeController is a multiple
of four.

Review URL: https://codereview.appspot.com/6453126

git-svn-id: http://skia.googlecode.com/svn/trunk@5134 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 17:56:49 +00:00
bungeman@google.com
b49d989997 Remove SK_FONTHOST_WIN_DW define.
git-svn-id: http://skia.googlecode.com/svn/trunk@5132 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 17:35:58 +00:00
reed@google.com
bc4b66f42c we have no subclasses, so change protected to private.
git-svn-id: http://skia.googlecode.com/svn/trunk@5131 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 16:46:27 +00:00
bsalomon@google.com
d57d71a5b8 Fix assertion in in order draw buffer
Review URL: http://codereview.appspot.com/6460095/


git-svn-id: http://skia.googlecode.com/svn/trunk@5130 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 16:26:33 +00:00
bungeman@google.com
6ca0a5da6c Don't try to build SkFontHost_win_dw.cpp on non-Windows platforms.
git-svn-id: http://skia.googlecode.com/svn/trunk@5129 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 16:23:09 +00:00
bungeman@google.com
e8f0592ae8 DirectWrite font host for skia.
https://codereview.appspot.com/5417063/


git-svn-id: http://skia.googlecode.com/svn/trunk@5128 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 16:13:40 +00:00
reed@google.com
0557d9ea94 add SkClipStack::clipEmpty() as an optimized way to say clipDevRect(empty, intersect)
if the caller knows up-front that it wants the clipstact to become empty.
Review URL: https://codereview.appspot.com/6443132

git-svn-id: http://skia.googlecode.com/svn/trunk@5127 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 15:59:59 +00:00
bsalomon@google.com
e7249bd5ca Fix overrun in aa rect renderer
Review URL: http://codereview.appspot.com/6446146/



git-svn-id: http://skia.googlecode.com/svn/trunk@5126 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 15:28:54 +00:00
bsalomon@google.com
0d94482193 Fix uninitialized color filter data on GrPaint
Review URL: http://codereview.appspot.com/6443135/


git-svn-id: http://skia.googlecode.com/svn/trunk@5125 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 15:06:57 +00:00
robertphillips@google.com
51ee8f1fd2 Compilation fix for r5123 (disabling template inst count tracking)
git-svn-id: http://skia.googlecode.com/svn/trunk@5124 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 15:04:34 +00:00
robertphillips@google.com
a22e2117e4 Extended Inst counting to find "unknown" leaked object (SkTMaskGamma)
http://codereview.appspot.com/6453127/



git-svn-id: http://skia.googlecode.com/svn/trunk@5123 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 14:58:06 +00:00
robertphillips@google.com
1f47f4f732 Replaced TextureCacheEntry with GrTexture* and a back pointer to GrResourceEntry (in GrTexture)
http://codereview.appspot.com/6460089/



git-svn-id: http://skia.googlecode.com/svn/trunk@5122 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 14:49:16 +00:00
epoger@google.com
71329d809a skdiff: recurse over subdirectories, unless --norecurse option is given
in anticipation of https://code.google.com/p/skia/issues/detail?id=743 ('move gm baselines outside of trunk, and modify naming convention')
Review URL: https://codereview.appspot.com/6465053

git-svn-id: http://skia.googlecode.com/svn/trunk@5121 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 13:42:13 +00:00
reed@google.com
56b64a5331 change tiling to 16 tiles instead of 4
git-svn-id: http://skia.googlecode.com/svn/trunk@5120 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 20:44:36 +00:00
scroggo@google.com
e2dd973e4b Provide a key to go to the previous slide in SampleApp.
The left key now mirrors the right key, and goes to the previous slide.
It used to change the device type, which can still be done by pressing
'd' or using the menu.

Review URL: https://codereview.appspot.com/6443133

git-svn-id: http://skia.googlecode.com/svn/trunk@5119 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 20:03:06 +00:00
junov@chromium.org
a8db8fe39a Fixing a deferred canvas optimization that purges pending draws when the canvas is cleared
It appears that the recording canvas returns a save count of 1 when the save stack is empty.
In order to pass Canvas unit tests when a clear occurs, changes to SkGPipe were necessary
to allow SkDeferredCanvas to set the device bounds on the SkGPipeCanvas.  A positive
side effect of this change is that graphics primitives that fall outside of the device
bounds will now always be culled at the recording stage (as opposed playback).

BUG=http://code.google.com/p/skia/issues/detail?id=782
TEST=deferred_canvas_record bench test
Review URL: https://codereview.appspot.com/6454157

git-svn-id: http://skia.googlecode.com/svn/trunk@5117 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 19:49:22 +00:00
scroggo@google.com
837d31a0c9 Use SkCanvas::concat instead of SkCanvas::setMatrix so this GM can be tiled.
Review URL: https://codereview.appspot.com/6460091

git-svn-id: http://skia.googlecode.com/svn/trunk@5116 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 18:42:45 +00:00
bensong@google.com
8c1de76d0b added representation to xhtml title.
git-svn-id: http://skia.googlecode.com/svn/trunk@5115 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 18:27:38 +00:00
bensong@google.com
2ee780b5ff fixes elif bug.
git-svn-id: http://skia.googlecode.com/svn/trunk@5114 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 17:55:42 +00:00
bensong@google.com
8734816c3f adds flag for choosing bench representative algorithm.
git-svn-id: http://skia.googlecode.com/svn/trunk@5113 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 17:31:46 +00:00
scroggo@google.com
63258865c4 Skip tiled drawing in GM for magnifier image filter.
Merely skips the test until we get a real fix for the problem.

BUG=https://code.google.com/p/skia/issues/detail?id=781

Review URL: https://codereview.appspot.com/6459094

git-svn-id: http://skia.googlecode.com/svn/trunk@5111 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 16:32:19 +00:00
robertphillips@google.com
cb73b31bcd Added virtual destructor to SkColorSpaceLuminance
http://codereview.appspot.com/6459092/



git-svn-id: http://skia.googlecode.com/svn/trunk@5110 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 14:52:58 +00:00
reed@google.com
67b89eeeb0 add 't' to toggle tiling modes
Review URL: https://codereview.appspot.com/6446138

git-svn-id: http://skia.googlecode.com/svn/trunk@5109 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 14:41:58 +00:00
robertphillips@google.com
5d8d18651a Addressed Windows compiler complaints
http://codereview.appspot.com/6462062/

This CL will require re-baselining of the imagemagnifier GM



git-svn-id: http://skia.googlecode.com/svn/trunk@5108 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 14:36:41 +00:00