reed@google.com
eebdd966c1
add rand10 bench for sort, which makes 10% of the entries repeats
...
reorder sort tests to make comparisons easier to read
git-svn-id: http://skia.googlecode.com/svn/trunk@7338 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 14:52:12 +00:00
rmistry@google.com
c29934489f
Display a warning prompt in presubmit if the tree status is in 'Caution'.
...
Example presubmit output:
Running presubmit upload checks ...
** Presubmit Warnings **
Tree state is: caution
***************
Please use caution in checkins
http://skia-tree-status-staging.appspot.com/banner-status?format=json
***************
There were presubmit warnings. Are you sure you wish to continue? (y/N):
Review URL: https://codereview.appspot.com/7200043
git-svn-id: http://skia.googlecode.com/svn/trunk@7337 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 14:35:58 +00:00
djsollen@google.com
e782f5ee47
Ensure that streams written using SkFlattenableBuffer's can be read with readByteArray(...)
...
Review URL: https://codereview.appspot.com/7138063
git-svn-id: http://skia.googlecode.com/svn/trunk@7335 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 13:40:40 +00:00
skia.committer@gmail.com
98ded84b80
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7332 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 07:06:17 +00:00
rmistry@google.com
c9dc537293
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float'] on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7331 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 05:47:03 +00:00
mike@reedtribe.org
a3f1c8e2fe
add bench for sorting
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7330 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 02:23:40 +00:00
robertphillips@google.com
5133fc73fe
Speculative fix for cros_daisy compilation failure
...
include/core/SkDeviceProperties.h:82:51: error: narrowing conversion of '(((int)orientation) | ((int)layout))' from 'int' to 'uint8_t
unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@7329 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 01:46:26 +00:00
robertphillips@google.com
d507775a8b
Fix for oversight in r7325
...
unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@7328 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 00:36:02 +00:00
bsalomon@google.com
730138c02b
Remove declaration of unimplemented function.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7327 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 22:04:13 +00:00
bsalomon@google.com
8a252f7962
Switch GrEffect::onIsEqual signature back to GrEffect from GrEffectRef.
...
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7188046
git-svn-id: http://skia.googlecode.com/svn/trunk@7326 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 20:35:13 +00:00
robertphillips@google.com
1e3052354a
Fix bug in 1xN SkBitmapProcShader optimization
...
https://codereview.appspot.com/7187047/
git-svn-id: http://skia.googlecode.com/svn/trunk@7325 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 20:29:16 +00:00
bsalomon@google.com
962f2d4e61
Fix r7321 build errors on non-windows compilers (using forward declared but not defined class in templated function).
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7324 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 20:10:17 +00:00
bungeman@google.com
f38f93c118
Fix Android only code in SkDraw for 7317.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7322 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 20:00:01 +00:00
bsalomon@google.com
6340a41108
Let them eat GrEffectRef.
...
Changes the remaining existing code that operates on naked GrEffects to GrEffectRef.
Review URL: https://codereview.appspot.com/7124058
git-svn-id: http://skia.googlecode.com/svn/trunk@7321 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 19:55:59 +00:00
bungeman@google.com
ba3284e7bb
Fix VC++ warning and Android only code for 7317.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7319 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 19:49:33 +00:00
robertphillips@google.com
dd4b74548a
Added multi-select deletion to debugger
...
https://codereview.appspot.com/7190043/
git-svn-id: http://skia.googlecode.com/svn/trunk@7318 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 19:38:46 +00:00
bungeman@google.com
532470f34d
Expose geometry and gamma on device.
...
https://codereview.appspot.com/6499101/
git-svn-id: http://skia.googlecode.com/svn/trunk@7317 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 19:25:14 +00:00
borenet@google.com
da7cb28768
Add wrapper for "gcl try"
...
Adds some validation for --bot
Review URL: https://codereview.appspot.com/7179048
git-svn-id: http://skia.googlecode.com/svn/trunk@7315 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 18:23:56 +00:00
robertphillips@google.com
25bc2f86c2
Fix saving modified skp from debugger
...
https://codereview.appspot.com/7181048/
git-svn-id: http://skia.googlecode.com/svn/trunk@7314 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 18:03:56 +00:00
junov@chromium.org
3f5ecd6cb4
Simple Build fix. Unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7313 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 18:01:26 +00:00
junov@chromium.org
f3b1223e6d
Fixing invalid text clipping on SkPicture playback
...
The bug was caused by an invalid assumption that a flattend object's
index is related to its array index in SkFlatDictionary::fData.
The data in SkFlatDictionary is sorted by flattened data content,
not by index number. Problem was solved by passing down the SkFlatData*
through addPaint, rather than the index value. The bug was causing
SkPictureRecord::addFontMetricsTopBottom to use cached font metrics
from the wrong SkPaint instance.
BUG=https://code.google.com/p/chromium/issues/detail?id=170964
Review URL: https://codereview.appspot.com/7178045
git-svn-id: http://skia.googlecode.com/svn/trunk@7312 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 17:50:47 +00:00
robertphillips@google.com
b83b6b4f76
Added toString to SkXfermode-derived classes (for debugger)
...
https://codereview.appspot.com/7139058/
git-svn-id: http://skia.googlecode.com/svn/trunk@7308 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 14:32:09 +00:00
jvanverth@google.com
d3c208c53e
Patch for r7304. Add string in bench_pictures_main's gFilterTypes for oval filter type.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7307 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 13:54:52 +00:00
jvanverth@google.com
46d3d39e65
Add GPU support for axis-aligned ovals:
...
- Add drawOval base function to SkDevice, and override in SkGpuDevice
- Move isSimilarityMatrix to SkMatrix (renamed to isSimilarity) and fixed up unit test
- Since both SkGpuDevice::drawOval() and GrContext::drawPath() can try to draw ovals, added GrContext::canDrawOval() and GrContext::internalDrawOval() to avoid duplicate code
- Hooked in axis-aligned oval fill shader
- Enabled GPU stroked circles
- Added stroked circle bench test
Review URL: https://codereview.appspot.com/7137050
git-svn-id: http://skia.googlecode.com/svn/trunk@7304 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 13:34:01 +00:00
caryclark@google.com
9d5f99bc30
shape ops work in progress
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7303 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 12:55:54 +00:00
robertphillips@google.com
5632e76dff
Place fix in r7278 behind compile flag
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7300 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-21 21:48:58 +00:00
rmistry@google.com
fd78046e7b
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7299 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-21 21:18:14 +00:00
robertphillips@google.com
90b17c7485
Placing 1xN bitmap shader opt behind a flag to delay WebKit rebaselines
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7298 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-21 21:17:16 +00:00
rmistry@google.com
60b0e9de5b
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7297 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-21 03:43:21 +00:00
rmistry@google.com
7a7caa294a
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7296 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-20 16:22:24 +00:00
skia.committer@gmail.com
9f876ed0c8
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7295 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-20 07:05:51 +00:00
caryclark@google.com
05c4bad470
shape ops work in progress
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7294 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-19 13:22:39 +00:00
skia.committer@gmail.com
36df7ed46b
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7293 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-19 07:05:38 +00:00
epoger@google.com
666c5cf3af
Fix bugs in r7291
...
TBR=reed
Review URL: https://codereview.appspot.com/7129057
git-svn-id: http://skia.googlecode.com/svn/trunk@7292 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-19 04:56:36 +00:00
epoger@google.com
3726960733
re-land r7258 with fixes and tests
...
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=reed
Review URL: https://codereview.appspot.com/7132060
git-svn-id: http://skia.googlecode.com/svn/trunk@7291 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-19 04:21:27 +00:00
senorblanco@chromium.org
514b922236
Partial revert of r7287 to green up the bots.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7290 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 21:53:12 +00:00
epoger@google.com
9ef89ce8b7
Roll out r7258
...
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=robertphillips
Review URL: https://codereview.appspot.com/7138065
git-svn-id: http://skia.googlecode.com/svn/trunk@7289 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 21:45:42 +00:00
bungeman@google.com
8e4adb0e01
Update gyp revision.
...
Now allows out-of-source output directories.
git-svn-id: http://skia.googlecode.com/svn/trunk@7288 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 21:20:16 +00:00
senorblanco@chromium.org
3f2d45aff6
(Relanding r7275 with assert fix, plus fixes from r7276, r7280, r7283.)
...
Implement a bicubic resampling image filter, with raster and GPU backends.
In order to get this to work on the GPU side, I had to modify the width and height of the drawn texture in drawSprite() and drawDevice() to use the filtered texture's dimensions, instead of the source texture. (This wasn't a problem before since all other image filters produce results the same dimensions as their input texture.)
For now, this implementation only does axis-aligned scaling (same as the Lanczos-3 implementation in Chrome). It's also done for correctness and clarity, not speed, so there are lots of opportunities for speedups.
Committed: https://code.google.com/p/skia/source/detail?r=7275
Review URL: https://codereview.appspot.com/7033049
git-svn-id: http://skia.googlecode.com/svn/trunk@7287 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 20:48:20 +00:00
epoger@google.com
80d447893e
gm self-test: followup to r7284
...
TBR=rmistry
Review URL: https://codereview.appspot.com/7128056
git-svn-id: http://skia.googlecode.com/svn/trunk@7286 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 20:03:58 +00:00
robertphillips@google.com
c51f752554
Reverting chain of SkBicubicImageFilter changes (7275, 7276, 7280 & 7283)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7285 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 19:20:52 +00:00
epoger@google.com
407f8da4f4
make gm self-test more robust
...
BUG=http://code.google.com/p/skia/issues/detail?id=1068
Review URL: https://codereview.appspot.com/7164043
git-svn-id: http://skia.googlecode.com/svn/trunk@7284 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 19:19:47 +00:00
reed@google.com
2124446ebb
fix unused-variable warning in src/effects/SkBicubicImageFilter.cpp
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7283 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 18:31:19 +00:00
edisonn@google.com
8ba9a834c3
tools.gyp: dependencies in apfabetical order
...
Review URL: https://codereview.appspot.com/7127055
git-svn-id: http://skia.googlecode.com/svn/trunk@7281 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 18:06:22 +00:00
robertphillips@google.com
9f4965270f
Removed unused variable in SkBicubicImageFilter.cpp
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7280 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:56:31 +00:00
reed@google.com
f919b720a1
in SkPath::dump(), add \n after close() printf, so we don't run into the next verb (e.g. moveTo)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7279 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:53:36 +00:00
reed@google.com
64d6295b0f
increase iteration count from 16 to 24, when computing cubic-line intersection.
...
This fixes crbug 170666. Before the fix, were were finishing the "clip" step
with a curve that was still partly negative, and so as assert would fire.
added unittest to confirm that the assert doesn't fire.
git-svn-id: http://skia.googlecode.com/svn/trunk@7278 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:49:28 +00:00
robertphillips@google.com
7da456d52b
Fix 7273 for neon
...
https://codereview.appspot.com/7137059/
git-svn-id: http://skia.googlecode.com/svn/trunk@7277 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:41:26 +00:00
senorblanco@chromium.org
92435a4364
Fix GPU-less build. Unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7276 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:32:50 +00:00
senorblanco@chromium.org
744820e657
Implement a bicubic resampling image filter, with raster and GPU backends.
...
In order to get this to work on the GPU side, I had to modify the width and height of the drawn texture in drawSprite() and drawDevice() to use the filtered texture's dimensions, instead of the source texture. (This wasn't a problem before since all other image filters produce results the same dimensions as their input texture.)
For now, this implementation only does axis-aligned scaling (same as the Lanczos-3 implementation in Chrome). It's also done for correctness and clarity, not speed, so there are lots of opportunities for speedups.
Review URL: https://codereview.appspot.com/7033049
git-svn-id: http://skia.googlecode.com/svn/trunk@7275 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:29:15 +00:00