caryclark
d85093c28f
make emptypath portable; add 565 color utility
...
R=djsollen@google.com
Review URL: https://codereview.chromium.org/1182833004
2015-06-12 11:49:04 -07:00
mtklein
1866b571f1
Stop running SKPs in DM on the bots.
...
We're not triaging them, and we get the same coverage (both Release and Debug)
from nanobench.
BUG=skia:
Review URL: https://codereview.chromium.org/1178943006
2015-06-12 11:31:51 -07:00
djsollen
8ed08e54f4
Disable failing GPU tests on Nexus 6.
...
BUG=skia:3942
Review URL: https://codereview.chromium.org/1185753002
2015-06-12 10:29:27 -07:00
caryclark
6d0d6cbb3e
PDF expects fonts to map glyph ID 0 to the missing character.
...
Add a mapping of glyph ID 0 to the toy font to allow for this.
TBR=bungeman@google.com
Review URL: https://codereview.chromium.org/1175243004
2015-06-11 09:40:44 -07:00
fmalita
523beb7fd9
Label some unused static vars as SK_UNUSED
...
Makes my gcc 5.1.1 much happier.
R=mtklein@google.com ,scroggo@google.com
[ mtklein mischief below here ]
No public API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1170863006
2015-06-10 10:46:50 -07:00
caryclark
83ca628cb6
Today's gm include many differences caused by platform font implementations.
...
This experiment replaces the label used in the aaxfermodes gm with
aliased text generated from paths common to all platforms.
Since there is no way today to generate all dm output from trybots,
this will be checked in to confirm that this strategy provides simpler
output across devices.
This does not introduce a new public interface; instead, dm uses
a extern backdoor to install the SkTypeface::CreateFromName
handler.
Review URL: https://codereview.chromium.org/1163283002
2015-06-10 09:31:09 -07:00
djsollen
e21585eabf
Update flags passed to Android GPU bots to exclude running skps and image sources.
...
Review URL: https://codereview.chromium.org/1176923003
2015-06-10 09:05:14 -07:00
bsalomon
0bb8c1f2b6
Stop running tiles_rt-gpu on the bots
...
BUG=skia:
Review URL: https://codereview.chromium.org/1152003009
2015-06-04 15:10:45 -07:00
reed
933d9863dd
suppress chatty warning about Funkster.ttf not be supported (on mac at least)
...
BUG=skia:
Review URL: https://codereview.chromium.org/1146273003
2015-06-01 12:51:24 -07:00
joshualitt
7fe8ee4cb7
Expand VisualBench to a real benching tool
...
BUG=skia:
Review URL: https://codereview.chromium.org/1159213002
2015-06-01 10:03:55 -07:00
joshualitt
da7b843fbd
CL to add setFullscreen and setVsync to SkWindow
...
BUG=skia:
Review URL: https://codereview.chromium.org/1151333004
2015-05-27 09:19:03 -07:00
stephana
340cd84c9c
Disabling ~path_hairline in iOS nanobench
...
Temporary measure to make nanobench succeed.
TBR=borenet
BUG=skia:
Review URL: https://codereview.chromium.org/1144173004
2015-05-26 06:19:11 -07:00
bsalomon
682c269a15
Store context options on caps.
...
Committed: https://skia.googlesource.com/skia/+/f28cff71db2cbb1ff18a8fbf1e80ca761d1f69bc
Review URL: https://codereview.chromium.org/1158433006
2015-05-22 14:01:46 -07:00
bsalomon
08bf86d1b7
Revert of Store context options on caps. (patchset #3 id:40001 of https://codereview.chromium.org/1158433006/ )
...
Reason for revert:
breaking chromeos build (???)
Original issue's description:
> Store context options on caps.
>
> Committed: https://skia.googlesource.com/skia/+/f28cff71db2cbb1ff18a8fbf1e80ca761d1f69bc
TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1151603005
2015-05-22 12:41:05 -07:00
bsalomon
f28cff71db
Store context options on caps.
...
Review URL: https://codereview.chromium.org/1158433006
2015-05-22 12:25:41 -07:00
stephana
18b72db6aa
Temporarily disable nanobench to see what else is in the way of the bots going green.
...
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1147333002
2015-05-21 13:59:36 -07:00
kkinnunen
503bd77b89
Add a newline to the font load debug message
...
Add a newline to the font load debug message. Helps reading nanobench
results. Otherwise the message "Resource /fonts/Funkster.ttf not a valid
font." causes first result be hard to read or missing.
Review URL: https://codereview.chromium.org/1142183002
2015-05-19 13:50:50 -07:00
caryclark
612f70d5fa
handle large conic strokes better
...
A stroked conic computes the outset quad's control point by
computing the intersection of the quad's endpoints. If the
the denominator used to compute the scale factor for the
control point is small, check to see if the numerator is also
small so that the division stays bounded.
Also clean up error returns and internal function calls to
simplify the code.
Additionally, remove comic max curvature (unimplemented) and call
extrema functions instead to handle cases where the conic is degenerate
or is a line.
R=reed@google.com , fmalita@chromium.org
BUG=skia:3843
Review URL: https://codereview.chromium.org/1144883003
2015-05-19 11:05:37 -07:00
caryclark
4e1a4c9399
fix builder winding again
...
Record the nesting level when finding the edge winding contribution
so that inner edges can be reversed as needed.
R=fmalita@chromium.org
BUG=skia:3838
Review URL: https://codereview.chromium.org/1140383002
2015-05-18 12:56:58 -07:00
nednguyen
6bad28de52
Replace self.NavigateToPage with self.Navigate(self.url) for skia page sets
...
BUG=487800
Review URL: https://codereview.chromium.org/1131113005
2015-05-16 15:47:02 -07:00
caryclark
182b499cd7
look for deleted pts when detecting line/curve coincident edges
...
TBR=reed@google.com
BUG=skia:3651
Review URL: https://codereview.chromium.org/1129863007
2015-05-14 05:45:54 -07:00
caryclark
bca19f7747
deal more consistently with unsortable edges
...
Improve line/curve coincident detection and resolution. This fixed the remaining simple failures.
When an edge is unsortable, use the ray intersection to determine the angles' winding.
Deal with degenerate segments.
TBR=reed@google.com
BUG=skia:3588,skia:3762
Review URL: https://codereview.chromium.org/1140813002
2015-05-13 08:23:48 -07:00
reed
80ea19ca4b
Revert of Revert of stop calling SkScalarDiv (patchset #1 id:1 of https://codereview.chromium.org/1138263002/ )
...
Reason for revert:
android patched, blink has rolled
Original issue's description:
> Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/ )
>
> Reason for revert:
> need to wait for Blink roll (and patch android)
>
> Original issue's description:
> > stop calling SkScalarDiv
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a
>
> TBR=
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2629697933b5cc975e45d2a45c48f803fc6cbcec
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1135693003
2015-05-12 10:37:34 -07:00
reed
2629697933
Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/ )
...
Reason for revert:
need to wait for Blink roll (and patch android)
Original issue's description:
> stop calling SkScalarDiv
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1138263002
2015-05-12 10:28:06 -07:00
reed
67d71c8982
stop calling SkScalarDiv
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1135053002
2015-05-12 09:47:22 -07:00
caryclark
7da2e55ccb
quickie tool to exercise chrome filter fuzz files
...
This is a quick Skia transcription of the Chromium tool at
src/skia/tools/filter_fuzz_stub.cc
to read and decode filters captured as .fil files.
R=joshualitt@google.com ,mtklein@google.com,reed@google.com,robertphillips@google.com
BUG=487213
Review URL: https://codereview.chromium.org/1126423005
2015-05-12 08:36:48 -07:00
caryclark
624637cc8e
Path ops formerly found the topmost unprocessed edge and determined its angle sort order to initialize the winding. This never worked correctly with cubics and was flaky with paths consisting mostly of vertical edges.
...
This replacement shoots axis-aligned rays through all intersecting edges to find the outermost one either horizontally or vertically. The resulting code is smaller and twice as fast.
To support this, most of the horizontal / vertical intersection code was rewritten and standardized, and old code supporting the top-directed winding was deleted.
Contours were pointed to by an SkTDArray. Instead, put them in a linked list, and designate the list head with its own class to ensure that methods that take lists of contours start at the top. This change removed a large percentage of memory allocations used by path ops.
TBR=reed@google.com
BUG=skia:3588
Review URL: https://codereview.chromium.org/1111333002
2015-05-11 07:21:28 -07:00
mtklein
32618cb857
Test sp-8888 mode on a few fast bots.
...
(It's not particularly slow, but this mode doesn't really need global coverage.)
BUG=skia:
Review URL: https://codereview.chromium.org/1129903003
2015-05-07 10:26:44 -07:00
borenet
d9b6be197f
Remove upright-matrix- configs from Android bots
...
The Android bots are flaking like crazy. I'm not sure if these configs
are hurting the situation, but let's see if this helps.
TBR=mtklein,halcanary
BUG=skia:
Review URL: https://codereview.chromium.org/1131603002
2015-05-06 08:33:51 -07:00
borenet
e3aeaec7dd
Add matrix configs to DM
...
BUG=skia:832
Review URL: https://codereview.chromium.org/1125793002
2015-05-05 13:11:27 -07:00
mtklein
e4b19c4593
Add presubmit to run {dm,nanobench}_flags.py test
when changed.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1129443005
2015-05-05 10:28:44 -07:00
borenet
f4e0857fe9
Blacklist tiles_rt-gpu gm imagefilterscropped on GalaxyS4
...
BUG=skia:3802
Review URL: https://codereview.chromium.org/1115303004
2015-05-05 08:28:23 -07:00
stephana
deee2980f4
cleanup
...
BUG=skia:
Review URL: https://codereview.chromium.org/1085583006
2015-05-05 07:55:06 -07:00
mtklein
19e259b1ee
ignore_result()
...
BUG=skia:3801
Review URL: https://codereview.chromium.org/1127603003
2015-05-04 10:54:48 -07:00
bsalomon
d309e7aa0e
This replaces the texture creation/caching functions on GrContext with a GrTextureProvider interface. The goal is to pass this narrowly focused object in places that currently take a GrContext but don't need and shouldn't use its other methods. It also has an extended private interface for interacting with non-texture resource types.
...
Review URL: https://codereview.chromium.org/1107973004
2015-04-30 14:18:54 -07:00
bungeman
3ffa126066
Move resource fonts to common location.
...
Move resource fonts to resources/fonts, add a destortable font for
testing, and clean up how the tests create fonts from resources.
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/1120823002
2015-04-30 17:12:58 -04:00
mtklein
f1d6df772e
Looks like rssPages * pageSize is overflowing on 32-bit Linux...
...
... resulting in apparently negative memory usage:
(-2040/2058MB 5867) 1.81s serialize-8888 skp top25desk_google_com_calendar_.skp
Turns out long is 32-bit there, long long is 64-bit.
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/1117923002
2015-04-30 07:35:28 -07:00
mtklein
d75c466ef5
DM+nanobench: print both current and max RSS.
...
out/Debug/dm:
( 360/380 MB 2112) 396ms gpu gm xfermodes
out/Release/nanobench:
32/33 MB 1659 2.46µs 2.55µs 2.54µs 2.67µs 2% ▄▄▄▅▅▃▂▁▂█ gpu gradient_conicalZero_clamp_hicolor
out/Debug/nanobench:
42/42 MB desk_css3gradients.skp_1 8888
BUG=skia:
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1115203002
2015-04-30 07:11:22 -07:00
rmistry
23c5f51371
Handpick 16 Skia page sets to create SP enabled SKPs from
...
Context is in: https://code.google.com/p/skia/issues/detail?id=3763#c18
NOTRY=true
BUG=skia:3763
Review URL: https://codereview.chromium.org/1115003002
2015-04-29 10:15:07 -07:00
caryclark
aec2510125
minor fixes to cubics code and overall alignment of how bounds and tops are computed for all curve types
...
All but 17 extended tests work.
A helper function is privately added to SkPath.h to permit a test to modify a given point in a path.
BUG=skia:3588
Review URL: https://codereview.chromium.org/1107353004
2015-04-29 08:28:30 -07:00
rmistry
385e88cc16
Create SP enabled SKPs from only the top_25_smooth page set.
...
Context is here: https://code.google.com/p/skia/issues/detail?id=3763#c14
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1111273003
2015-04-29 07:26:33 -07:00
halcanary
5190a481f9
doc: add quickstart to linux and macos
...
also, better install_deps
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1112663002
Review URL: https://codereview.chromium.org/1112663002
2015-04-28 13:06:54 -07:00
borenet
97025e34d3
Run DM on GalaxyS* in one thread
...
Drive-by cleanup of Xoom
BUG=skia:3214
Review URL: https://codereview.chromium.org/1106173004
2015-04-28 09:54:55 -07:00
rmistry
77772f3ca3
Update RecreateSKPs bot to also generate Slimming Paint SKPs with a separate prefix.
...
Will only be committed after I get the go head in skia:3763.
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1065503007
2015-04-28 08:27:19 -07:00
joshualitt
8f94bb2b25
remove old text contexts and fontcache
...
BUG=skia:
Review URL: https://codereview.chromium.org/1104343003
2015-04-28 07:04:11 -07:00
halcanary
2752314745
dm||nanobench --help looks nice when $COLUMNS == 80.
...
Also, add to --config help message
Review URL: https://codereview.chromium.org/1105593002
2015-04-27 06:41:36 -07:00
caryclark
08bc8488fa
fix multiple intersection logic
...
When three or more curves intersect at the same point, ensure that
each curve records the intersections of the others. This fixes a
number of cubic tests.
TBR=reed@google.com
BUG=skia:3588
Review URL: https://codereview.chromium.org/1105943002
2015-04-24 09:08:57 -07:00
rmistry
aa31ee78ee
Add ability to specify extra browser args and a prefix for SKP names to webpages_playback.py
...
BUG=skia:3763
NOTRY=true
Review URL: https://codereview.chromium.org/1066933006
2015-04-23 12:47:33 -07:00
borenet
e1d7e0f0a5
Blacklist desk_unicodetable SKP on Nexus Player
...
It's getting us killed for OOM.
BUG=skia:3240
Review URL: https://codereview.chromium.org/1104693002
2015-04-23 12:44:31 -07:00
caryclark
03b03cad01
working on initial winding for cubics
...
Path ops works well for all tests except for cubics.
Isolate failures caused by cubics, and do a better job of computing
the initial winding for cubics.
TBR=reed@google.com
BUG=skia:3588
Review URL: https://codereview.chromium.org/1096923003
2015-04-23 09:13:37 -07:00