liyuqian
6f163d2943
Display JPGs in Viewer with Split Screen and ColorSpaceXform
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058753002
Review-Url: https://codereview.chromium.org/2058753002
2016-06-13 12:26:45 -07:00
egdaniel
f533f116e6
Revert of Add samples to Viewer. (patchset #4 id:60001 of https://codereview.chromium.org/2056343004/ )
...
Reason for revert:
breaking on android compile
Original issue's description:
> Add samples to Viewer.
>
> This adds support with animation, assuming the sample has
> implemented onAnimate. Event handling has not been
> implemented.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004
>
> Committed: https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658
TBR=bsalomon@google.com ,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2063883002
2016-06-13 11:30:10 -07:00
ethannicholas
2ec06c9b1c
skiaserve no longer crashes when no X server is present
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2059263002
Review-Url: https://codereview.chromium.org/2059263002
2016-06-13 10:20:52 -07:00
jvanverth
76963e7370
Add samples to Viewer.
...
This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004
Review-Url: https://codereview.chromium.org/2056343004
2016-06-13 09:31:27 -07:00
brianosman
25d57db234
Request an sRGB FBO0 on Android. Fixes sRGB GL mode.
...
Tried to comment my logic, but it's totally possible that we run on some
device where this doesn't work. From a strict reading of the relevant
specs, what I'm doing shouldn't work on the Nexus 5X, but it's necessary
to get correct results.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054223002
Review-Url: https://codereview.chromium.org/2054223002
2016-06-13 07:49:07 -07:00
kjlubick
a233620f9c
Remove shaderc cmake compiling
...
It is no longer needed as of https://skia.googlesource.com/skia/+/b7b4293524e0c1d4c1635c4710aceafaca47b313
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060503002
Review-Url: https://codereview.chromium.org/2060503002
2016-06-10 12:54:37 -07:00
djsollen
9207caebbb
Cleanup VulkanWindowContext for use on Android
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058763002
Review-Url: https://codereview.chromium.org/2058763002
2016-06-10 07:50:00 -07:00
bsalomon
ea406dde3c
Add blurcircles to blacklist for macmini4.1
...
BUG=skia:5414
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2053373002
Review-Url: https://codereview.chromium.org/2053373002
2016-06-10 06:58:16 -07:00
egdaniel
5dfe7bbcfd
Define LEAN_AND_MEAN and NOMINMAX for all windows builds
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055223002
Review-Url: https://codereview.chromium.org/2055223002
2016-06-10 06:42:45 -07:00
mtklein
c9b4ccd771
Skip verylargebitmap serialization on Android too
...
I'm trying to figure out why we've been skipping serialize-8888 for these.
They don't draw wrong. Seems like they just eat up all memory while serializing,
maybe only in Debug mode.
This should fix the red Nexus9 bot.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050423003
Review-Url: https://codereview.chromium.org/2050423003
2016-06-09 18:57:21 -07:00
djsollen
7e73108a37
Cleanup needed to use WindowContext for Android
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055693003
Review-Url: https://codereview.chromium.org/2055693003
2016-06-09 13:07:13 -07:00
liyuqian
71491dc14c
Support resize in Android Viewer App
...
Previously, we took out resize because Vulkan didn't support it in
Android. Now Android nyc-dev builds >= 2937079 and nyc-release builds >=
NRD66 supports it so we add it back.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050613003
Review-Url: https://codereview.chromium.org/2050613003
2016-06-09 12:02:34 -07:00
mtklein
96e4e1ca5a
Add raw pixel serialization fallback for SkImages that cannot be encoded.
...
This fixes serialize-8888 for 2 GMs on Mac that I'm now unblacklisting.
I think another was already fixed, and two more were Windows-only.
Seems safe to use encoded_size=1 as another sentinel here (like we already
use =0); I can't imagine any encoded image format that can encode an image
in a single byte.
I suspect this is the root of the referenced bug too,
but this is a good idea even if not.
BUG=chromium:601851
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2039813007
CQ_EXTRA_TRYBOTS=client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-Trybot,Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot;client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Release-Trybot
Review-Url: https://codereview.chromium.org/2039813007
2016-06-09 10:38:08 -07:00
bungeman
06ca8ec87c
sk_sp for Ganesh.
...
Convert use of GrFragmentProcessor, GrGeometryProcessor, and
GrXPFactory to sk_sp. This clarifies ownership and should
reduce reference count churn by moving ownership.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2041113004
Review-Url: https://codereview.chromium.org/2041113004
2016-06-09 08:01:03 -07:00
egdaniel
066df7ca91
Add GpuCommandBuffer support.
...
Currently this is not actually hooked into the system.
To give some context, in a follow up CL I'll add this to GrDrawTarget.
For this I will move the gpu onDraw command to the GpuCommandBuffer as well.
For GL this will end up just being a pass through to a non virtual draw(...)
on GrGLGpu, and for vulkan it will mostly do what it currently does but
adding commands to the secondary command buffer instead.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2038583002
Review-Url: https://codereview.chromium.org/2038583002
2016-06-08 14:02:27 -07:00
liyuqian
2a437e6459
Provide filter when there are many options
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047233003
Review-Url: https://codereview.chromium.org/2047233003
2016-06-08 11:17:09 -07:00
halcanary
4dbbd04314
SkLeanWindows.h: #include "Windows.h" fewer places
...
$ git grep -l '<windows.h>' include src
include/private/SkLeanWindows.h
$ git grep -l SkLeanWindows.h | grep '\.h$'
include/ports/SkTypeface_win.h
include/utils/win/SkHRESULT.h
include/utils/win/SkTScopedComPtr.h
include/views/SkEvent.h
src/core/SkMathPriv.h
src/ports/SkTypeface_win_dw.h
src/utils/SkThreadUtils_win.h
src/utils/win/SkWGL.h
The same for `#include <intrin.h>` that was found in SkMath.h.
Those functions that needed it are moved to SkMathPriv.h.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2041943002
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_compile_dbg_ng,win_chromium_compile_rel_ng
Review-Url: https://codereview.chromium.org/2041943002
2016-06-07 17:21:10 -07:00
liyuqian
d94ad5823b
Implement Raster Backend on Android Viewer App
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2041193004
Review-Url: https://codereview.chromium.org/2041193004
2016-06-07 14:22:38 -07:00
liyuqian
1f508fd0fe
Show FPS in UI state
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043793002
Review-Url: https://codereview.chromium.org/2043793002
2016-06-07 06:57:40 -07:00
jvanverth
814e38d5c1
Use intptr_t for onTouch argument.
...
On 64-bit platforms, casting int to void* is not valid.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047443002
Review-Url: https://codereview.chromium.org/2047443002
2016-06-06 08:48:47 -07:00
liyuqian
38d1adf1f7
Allow animation in Android viewer
...
To do that, we let ALooper_pollAll return immediately rather than wait indefinitely.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2031383002
Review-Url: https://codereview.chromium.org/2031383002
2016-06-06 07:53:24 -07:00
robertphillips
55fdcccf01
Remove GrRenderTarget from GrPipelineBuilder
...
This used to be "Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder"
but has been split into:
https://codereview.chromium.org/1993263002/ (Make GrAppliedClip friendless)
https://codereview.chromium.org/1997773002/ (Retract GrRenderTarget from GLProgramsTest)
https://codereview.chromium.org/1993403002/ (GrSWMaskHelper and GrSoftwarePathRenderer only need the textureProvider (not GrContext))
https://codereview.chromium.org/2004433002/ (Retract GrRenderTarget from GrTestTarget)
https://codereview.chromium.org/2015333002/ (Change parameters to GrPipelineBuilder's ctor)
https://codereview.chromium.org/2035823002/ (Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1988923002
Review-Url: https://codereview.chromium.org/1988923002
2016-06-06 06:16:21 -07:00
robertphillips
976f5f0dc5
Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack
...
This will be followed up with a CL to remove the GrRenderTarget from the GrPipelineBuilder.
Split out of:
https://codereview.chromium.org/1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035823002
Review-Url: https://codereview.chromium.org/2035823002
2016-06-03 10:59:20 -07:00
liyuqian
b73c24b01a
Add Softkey UIState to Viewer
...
We can use this to simulate any key/command on Android UI.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035923002
Review-Url: https://codereview.chromium.org/2035923002
2016-06-03 08:47:24 -07:00
jcgregorio
34604046cf
skiaserve: Add a flag to control hosted mode, i.e. when running on debugger.skia.org.
...
BUG=skia:
TBR=ethannicholas@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2036173002
Review-Url: https://codereview.chromium.org/2036173002
2016-06-03 07:26:22 -07:00
borenet
9d19cc6ca4
Add Android device type for NVIDIA Shield
...
BUG=skia:5185
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2036183003
Review-Url: https://codereview.chromium.org/2036183003
2016-06-03 07:01:32 -07:00
liyuqian
6cb7025182
Implement OpenGL backend in Android viewer app
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2032623002
Review-Url: https://codereview.chromium.org/2032623002
2016-06-02 12:16:25 -07:00
jvanverth
1e305ba0d6
Add offset to memory allocations
...
This is setting up for suballocations within one large
allocation
BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2018933004
TBR=bsalomon@google.com
Review-Url: https://codereview.chromium.org/2018933004
2016-06-01 09:39:15 -07:00
kulshin
c4b091543b
Implement support for rendering color emoji on Windows
...
This change adds support to the DirectWrite scaler context
for detection of color fonts. If it detects a color font and
the glyph is a color glyph, it will use DirectWrite's
TranslateColorGlyphRun API and generate an image of the
glyph that can then be rendered.
Chromium tests: https://codereview.chromium.org/2003853002
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1984943002
Review-Url: https://codereview.chromium.org/1984943002
2016-06-01 08:31:28 -07:00
jcgregorio
ce8ea4c55b
skiaserve: Add /quitquitquit handler. Will be used in the hosted debugger.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023023002
TBR=ethannicholas
Review-Url: https://codereview.chromium.org/2023023002
2016-05-31 12:51:31 -07:00
mboc
ee6a9919a3
SkTypeface::MakeFromName to take SkFontStyle.
...
SkTypeface::MakeFromName currently takes SkTypeface::Style,
which is quite limited. This starts the transition to this
function taking SkFontStyle instead.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1818043002
TBR=reed
He said it sounded like a good idea.
Review-Url: https://codereview.chromium.org/1818043002
2016-05-31 11:42:37 -07:00
jvanverth
99eb6e2d5a
Add missing files for GL unix viewer.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023943004
Review-Url: https://codereview.chromium.org/2023943004
2016-05-31 09:39:20 -07:00
msarett
97205a4b41
Add interesting features to visualize_color_gamut
...
(1) Draw triangles onto a D50 color gamut so they are
actually in the correct place.
(2) Add options to display canonical sRGB and Adobe RGB
gamuts.
(3) Label the R, G, and B points of the color gamut.
(4) Decode and reencode the input image without color
correction, so we can compare to the corrected version.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2017153002
Review-Url: https://codereview.chromium.org/2017153002
2016-05-27 14:01:02 -07:00
herb
ca1ec03c5c
Move forceSRGB to SkCommonFlags.
...
This fixes a duplicate symbol problem with the iOS build.
Add common forceSRGB flag.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2019073002
Review-Url: https://codereview.chromium.org/2019073002
2016-05-27 10:57:58 -07:00
liyuqian
e5a6cd9832
Now we can use drawer to view the state information of the native app, and set its state using the spinner.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
Committed: https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec
Review-Url: https://codereview.chromium.org/2004633002
2016-05-27 08:52:52 -07:00
jvanverth
85f758c334
Add OpenGL support to Linux viewer
...
Also adds a command line option (--vulkan) to choose between
Vulkan and OpenGL.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003
Committed: https://skia.googlesource.com/skia/+/10b3815a11c39b154ec7b74a2af43e019b50d48c
Review-Url: https://codereview.chromium.org/2011473003
2016-05-27 06:47:08 -07:00
kjlubick
9ad0949338
Revert of Add drawer with state information (patchset #8 id:140001 of https://codereview.chromium.org/2004633002/ )
...
Reason for revert:
Broke Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan. See https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan/builds/134/steps/compile_skia%20on%20Ubuntu/logs/stdio .
Original issue's description:
> Now we can use drawer to view the state information of the native app, and set its state using the spinner.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
>
> Committed: https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec
TBR=djsollen@google.com ,jvanverth@google.com,liyuqian@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2016343002
2016-05-27 06:22:01 -07:00
kjlubick
0248bfd8d2
Revert of Add OpenGL support to Linux viewer (patchset #5 id:80001 of https://codereview.chromium.org/2011473003/ )
...
Reason for revert:
Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan is broken and this patch prevents the revert of the culprit
Original issue's description:
> Add OpenGL support to Linux viewer
>
> Also adds a command line option (--vulkan) to choose between
> Vulkan and OpenGL.
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003
>
> Committed: https://skia.googlesource.com/skia/+/10b3815a11c39b154ec7b74a2af43e019b50d48c
TBR=egdaniel@google.com ,bsalomon@google.com,brianosman@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2015213002
2016-05-27 06:20:10 -07:00
jvanverth
10b3815a11
Add OpenGL support to Linux viewer
...
Also adds a command line option (--vulkan) to choose between
Vulkan and OpenGL.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003
Review-Url: https://codereview.chromium.org/2011473003
2016-05-27 05:47:00 -07:00
djsollen
4145792736
Remove VisualBench and its Android implementation.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2018603003
Review-Url: https://codereview.chromium.org/2018603003
2016-05-27 05:39:29 -07:00
liyuqian
4e4e30823f
Now we can use drawer to view the state information of the native app, and set its state using the spinner.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
Review-Url: https://codereview.chromium.org/2004633002
2016-05-26 12:43:43 -07:00
borenet
649becde3b
Temporarily change GalaxyS3 product.board
...
Swarming detects this as "m0" for some reason. Change our requested
dimension until this is fixed.
BUG=skia:5185
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=2018513004
Review-Url: https://codereview.chromium.org/2018513004
2016-05-26 11:21:02 -07:00
caryclark
2bec26a716
fix security bug
...
This fix is a tradeoff. It changes intersection to
treat a case where one coincident run is intersected at one point
and the other edge is not as continuing to be a span.
The old code tried to treat this as a single point.
The old code is probably right, but this change alone
made the data structures inconsistent. Later, extending
the coincident runs would fail by incorrectly discarding
the single point intersection.
As a result, this fixes the security test and one other, but
makes a different test fail. Isolating the failure uncovered
a reduced case that fails with and without the change, so
there are more serious problems here. Those problems are
addressed in a separate CL.
Many of the test edits below remove ill-thought out debugging
messaging that fire off global state, which isn't usable
in a multi-threaded test environment.
In the end, with this fix, all existing tests (modulo one
new failure and one new non-failure) pass in debug and
in the extended release test suites.
TBR=reed@google.com
BUG=614248
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2018513003
Review-Url: https://codereview.chromium.org/2018513003
2016-05-26 09:01:47 -07:00
scroggo
23b80c402a
Revert of Blacklist HTC.dng on 32-bit Win CPU bots (patchset #1 id:1 of https://codereview.chromium.org/1995703002/ )
...
Reason for revert:
We think we have independently fixed this problem by using a smaller image for HTC.dng
Original issue's description:
> Blacklist HTC.dng on 32-bit Win CPU bots
>
> BUG=skia:5318
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1995703002
>
> Committed: https://skia.googlesource.com/skia/+/62efdbde9987df3422f677a1a7c8f355791c1ae4
TBR=msarett@google.com ,borenet@google.com,borenet@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:5318
Review-Url: https://codereview.chromium.org/2004203002
2016-05-23 14:35:52 -07:00
jvanverth
1d15596200
Add Xlib support to viewer
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1999213002
Review-Url: https://codereview.chromium.org/1999213002
2016-05-23 13:13:36 -07:00
liyuqian
566c8e4a36
Move inval dedup to Window for wider usages.
...
It turns out that the inval dedup is not just useful for Android. Hence
we move it up to the Window level so more OSes such as Linux, Windows
can also use it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2001153002
Review-Url: https://codereview.chromium.org/2001153002
2016-05-23 10:52:34 -07:00
brianosman
a56800a05d
Add vksrgb config to dm (Vulkan sRGB). Fix help formatting of vk.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2005863002
Review-Url: https://codereview.chromium.org/2005863002
2016-05-23 10:11:07 -07:00
halcanary
f0270c32c1
fiddle: srand(0) before draw(canvas)
...
TBR=
Review-Url: https://codereview.chromium.org/2003043002
2016-05-23 09:02:38 -07:00
liyuqian
17b4a10921
Save comparisons for release.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1997003003
Review-Url: https://codereview.chromium.org/1997003003
2016-05-20 12:41:49 -07:00
liyuqian
beb1c67c9d
Use SkASSERTResult to avoid unused local variables
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2003653002
Review-Url: https://codereview.chromium.org/2003653002
2016-05-20 11:41:01 -07:00