AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
15,021 Commits 1 Branch 0 Tags 544 MiB
7ba39cb9a6
Commit Graph

15021 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
mtklein
7ba39cb9a6 Add nanobench stats scripts to Skia repo. 
These are the scripts I've been homegrowing for measuring perf impact.  I think we found them useful today as a way of sifting through the noise.

BUG=skia:

Review URL: https://codereview.chromium.org/703713002
 2014-11-24 12:39:59 -08:00
bsalomon
19cd0f1813 Revert "Use scratch keys for stencil buffers." 
This reverts commit 91175f1966.

Revert "Cleanup res cache bench and split out into a unit test."

This reverts commit 4e4303f002.

Revert "rebaselines"

This reverts commit 65ba7b5775.

TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/752233002
 2014-11-24 12:19:06 -08:00
reed
90d0ff013b add some debugging to SkNVRefCnt 
BUG=skia:

Review URL: https://codereview.chromium.org/745383003
 2014-11-24 12:02:31 -08:00
tomhudson
9891317557 Revert of More rebaselines (patchset #1 id:1 of https://codereview.chromium.org/754833003/) 
Reason for revert:
Reverted causative patchset (https://codereview.chromium.org/747043004)

Original issue's description:
> More rebaselines
>
> TBR=
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/0ef7ba2a43a41e8e1e49a5187073db6dcca345b4

TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/756633004
 2014-11-24 11:27:42 -08:00
tomhudson
2a42d15e06 Revert of more rebaselines (patchset #1 id:1 of https://codereview.chromium.org/755653003/) 
Reason for revert:
Reverted causative patch (https://codereview.chromium.org/747043004)

Original issue's description:
> more rebaselines
>
> TBR=
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/f2fdc8b746acac9daa94b21d3849f60a87064fd4

TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/754103002
 2014-11-24 11:24:46 -08:00
tomhudson
612e92680b Revert of Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #1 id:1 of https://codereview.chromium.org/750973003/) 
Reason for revert:
Original patchset seems to have been exonerated. Crash was mac-specific, but appears to be triggered by a non-mac-specific change (https://codereview.chromium.org/747043004/); suspecting driver bug?

Original issue's description:
> Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #2 id:20001 of https://codereview.chromium.org/754653002/)
>
> Reason for revert:
> Suspected in DM crashes, e.g.
>
> 2033 tasks left	 344M peak	  843ms	tabl-cuteoverload_skp
> Signal 11:
> _sigtramp (+0x1a)
> create_surface(CanvasConfig const&, GrContext*) (+0x1b2)
> test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4)
> skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21)
> skiatest::Test::run() (+0x7c)
> DM::GpuTestTask::draw(GrContextFactory*) (+0x8c)
> DM::GpuTask::run(GrContextFactory*) (+0xa6)
> DM::TaskRunner::wait() (+0x7f)
> dm_main() (+0x33f)
> main (+0x27)
>
>
> On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}):
>
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug
>
>
> Original issue's description:
> > Add gpu support for Apple specific 'Vertex Arrays' functions
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc
>
> TBR=bsalomon@google.com,paraboul@gmail.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/55fe3d7748b873e362edc4e6a43bd77914ed25fb

TBR=bsalomon@google.com,paraboul@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/734633005
 2014-11-24 11:22:37 -08:00
robertphillips
6247fa0ba0 Suppress additional multipicturedraw GM for Android 
One Android bot is failing on the rect test case.

TBR=tomhudson@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/750203003
 2014-11-24 10:56:21 -08:00
robertphillips
02758c74db Sigh - remove whitespace from end of suppressions text line 
TBR=tomhudson@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/754783003
 2014-11-24 10:23:07 -08:00
robertphillips
0bcf523f0b Add suppressions for https://codereview.chromium.org/748853002 
TBR=tomhudson@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/753103005
 2014-11-24 10:06:47 -08:00
tomhudson
55fe3d7748 Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #2 id:20001 of https://codereview.chromium.org/754653002/) 
Reason for revert:
Suspected in DM crashes, e.g.

2033 tasks left	 344M peak	  843ms	tabl-cuteoverload_skp
Signal 11:
_sigtramp (+0x1a)
create_surface(CanvasConfig const&, GrContext*) (+0x1b2)
test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4)
skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21)
skiatest::Test::run() (+0x7c)
DM::GpuTestTask::draw(GrContextFactory*) (+0x8c)
DM::GpuTask::run(GrContextFactory*) (+0xa6)
DM::TaskRunner::wait() (+0x7f)
dm_main() (+0x33f)
main (+0x27)

On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}):

http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug

Original issue's description:
> Add gpu support for Apple specific 'Vertex Arrays' functions
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc

TBR=bsalomon@google.com,paraboul@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/750973003
 2014-11-24 09:59:41 -08:00
robertphillips
30d7841f90 Add support for hoisting layers in pictures drawn with a matrix 
Although Chromium doesn't use the drawPicture matrix parameter for their tiling, our local code does. Without such drawPicture calls break layer hoisting.

BUG=skia:2315

Review URL: https://codereview.chromium.org/748853002
 2014-11-24 09:49:17 -08:00
mtklein
7ef849d45a Add Sk prefix to CreateBitmapShader. 
It's neither static nor namespaced, so we should probably prefix it.

BUG=skia:

Review URL: https://codereview.chromium.org/754083002
 2014-11-24 09:11:45 -08:00
scroggo
01c412e40a Remove android-framework-only unused parameter. 
Allows -Werror=unused-parameter to build on android framework.

Review URL: https://codereview.chromium.org/757633002
 2014-11-24 09:05:35 -08:00
bsalomon
0ef7ba2a43 More rebaselines 
TBR=
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/754833003
 2014-11-24 08:39:09 -08:00
bsalomon
4e4303f002 Cleanup res cache bench and split out into a unit test. 
BUG=skia:2889

Review URL: https://codereview.chromium.org/754833002
 2014-11-24 08:25:05 -08:00
mtklein
04c9695055 Remove Picture deletion listeners. 
Looks like we can just have ~SkPicture put the message on the bus directly.

BUG=skia:3144

Review URL: https://codereview.chromium.org/751663002
 2014-11-24 08:20:58 -08:00
bsalomon
f2fdc8b746 more rebaselines 
TBR=
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/755653003
 2014-11-24 08:13:49 -08:00
bsalomon
65ba7b5775 rebaselines 
NOTRY=true
NOTREECHECKS=true
TBR=

Review URL: https://codereview.chromium.org/753133003
 2014-11-24 08:03:24 -08:00
paraboul
af000f469e Add gpu support for Apple specific 'Vertex Arrays' functions 
BUG=skia:

Review URL: https://codereview.chromium.org/754653002
 2014-11-24 07:05:28 -08:00
bsalomon
91175f1966 Use scratch keys for stencil buffers. 
BUG=skia:2889

Review URL: https://codereview.chromium.org/747043004
 2014-11-24 07:05:15 -08:00
qiankun.miao
52e74c6d84 Cleanup of S32_D565_Opaque_SSE2() 
BUG=skia:

Review URL: https://codereview.chromium.org/725693003
 2014-11-24 06:59:44 -08:00
bsalomon
932f866987 Create GrOptDrawState directly in the cmd buffer in GrIODB. 
Review URL: https://codereview.chromium.org/746243002
 2014-11-24 06:47:48 -08:00
reed
735f548c51 use int instead of size_t to match skia convention 
BUG=skia:
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/753903002
 2014-11-23 18:37:14 -08:00
skia.buildbots
033b7b9559 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/747323005
 2014-11-22 22:47:34 -08:00
skia.buildbots
1ed35df6c0 Update SKP version 
Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/728943003
 2014-11-21 23:06:21 -08:00
mtklein
c0591ca026 Revert of Add -ftrapv to debug builds. (patchset #1 id:1 of https://codereview.chromium.org/702893003/) 
Reason for revert:
Not clean yet.

Original issue's description:
> Add -ftrapv to debug builds.
>
> This adds instrumentation to check that signed integers never under- or
> overflow, which is undefined behavior.
>
> BUG=skia:3096
>
> Committed: https://skia.googlesource.com/skia/+/ebacb6127a952910f43a59460af43427d93df46c

TBR=bungeman@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3096

Review URL: https://codereview.chromium.org/751713002
 2014-11-21 14:42:35 -08:00
bsalomon
77d77f446d Add pop_back to GrTRecorder.h 
Review URL: https://codereview.chromium.org/750613002
 2014-11-21 14:38:06 -08:00
mtklein
ebacb6127a Add -ftrapv to debug builds. 
This adds instrumentation to check that signed integers never under- or
overflow, which is undefined behavior.

BUG=skia:3096

Review URL: https://codereview.chromium.org/702893003
 2014-11-21 14:24:04 -08:00
bungeman
5ec443c506 Clean up FreeType code for 2.3.8. 
We already require FreeType 2.3.8 in order to compile and run.
Make this requirement explicit and take advantage of it.

Review URL: https://codereview.chromium.org/748063003
 2014-11-21 13:18:34 -08:00
mtklein
fc1e996bcc ack verylargebitmap diffs 
NOTRY=true

BUG=skia:

Review URL: https://codereview.chromium.org/752693002
 2014-11-21 12:52:46 -08:00
mtklein
19ac76753e SkPicture::SnapshotArray doesn't really stand to benefit from refcounting. 
BUG=skia:

Review URL: https://codereview.chromium.org/748803005
 2014-11-21 12:20:35 -08:00
mtklein
1794651509 Switch SkBitmapProcState's SkFractionalInt to 32.32. 
16 bits are not enough to hold the integral part of fx in
Clamp_S32_opaque_D32_nofilter_DX_shaderproc.

Weirdly, no GM diffs on my desktop.

BUG=skia:3096

Review URL: https://codereview.chromium.org/733163003
 2014-11-21 12:10:33 -08:00
mtklein
76b3ac9eff Simplfy DEPS: always pull all deps, remove unused barelinux platform. 
Left some notes about where we might further clean up.

BUG=skia:

Review URL: https://codereview.chromium.org/753633002
 2014-11-21 11:41:35 -08:00
mtklein
09a22e9597 Watch out for SkFixed overflow in SkMipMap.cpp. 
Tested with -fsanitize=signed-integer-overflow.
This new assert used to trigger in MipMap unit test.

Don't appear to be any GM diffs.

BUG=skia:

Review URL: https://codereview.chromium.org/729373004
 2014-11-21 11:38:53 -08:00
mtklein
04038eba9f public SkNVRefCnt<SnapshotArray> 
Should fix broken build.

NOTRY=true
TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/748143002
 2014-11-21 11:13:15 -08:00
mtklein
b7ee349f10 SkData -> SkPicture::SnapshotArray 
Restores type safety with all the same features.

(Also note, less code: 29 insertions, 50 deletions.)

BUG=skia:

Review URL: https://codereview.chromium.org/746553002
 2014-11-21 11:06:04 -08:00
reed
3f10b9dd2c clarify samplecount field in imagegpu 
BUG=skia:
TBR=bsalomon

Review URL: https://codereview.chromium.org/750023002
 2014-11-21 10:27:53 -08:00
robertphillips
ec8bb946c3 Fix error in Ganesh' tiled bitmap drawing 
When the paint filter level is high ShouldUseBicubic doesn't always return true. In this case the paint's filter level will differ from the filtering Ganesh will use. This was leading to a mismatch between the tiling computed in SkGpuDevice::drawBitmapCommon and the one in SkGpuDevice::drawTiledBitmap.

The end result of this was that the max texture restriction could be violated which is currently being seen on the Xoom & N7 bots. Both of them have a max texture size of 2048 which is invoking the tiled drawbitmap case.

Review URL: https://codereview.chromium.org/752623002
 2014-11-21 10:16:25 -08:00
joshualitt
947556f658 remove GrAllocPool 
BUG=skia:

Review URL: https://codereview.chromium.org/742253002
 2014-11-21 09:03:45 -08:00
mtklein
42ddcd4906 All the small packing tweaks mentioned in the bug. 
BUG=skia:3144

Review URL: https://codereview.chromium.org/748063002
 2014-11-21 08:48:35 -08:00
reed
4af267b119 add SkImage::newSurface 
BUG=skia:

Review URL: https://codereview.chromium.org/741763002
 2014-11-21 08:46:38 -08:00
reed
41d2c2e434 simplify uniqueID code in picture 
patch from issue 750003002 at patchset 1 (http://crrev.com/750003002#ps1)

BUG=skia:

Review URL: https://codereview.chromium.org/752573002
 2014-11-21 08:07:41 -08:00
robertphillips
8f81b69ed7 Ignore a flaky msaa4 GM and some perma-broken S4 GMs 
The Ubuntu12 msaa4 image seems to flake randomly
The S4 images are covered by skia:3116 (Galaxy S4 exhibits some saveLayer bugs (both normal and with hoisting))

TBR=humper@google.com

Review URL: https://codereview.chromium.org/748773003
 2014-11-21 07:24:01 -08:00
robertphillips
186a08ed72 Fix memory leak in nanobench 
This is cleanup for (Add MultiPictureDraw to nanobench - https://codereview.chromium.org/731973005/)

Review URL: https://codereview.chromium.org/730343003
 2014-11-21 06:53:00 -08:00
mtklein
19996eda62 Small changes to get things building and running on Linux/ARM. 
ninja -C out/Debug works, and I tested out/Debug/dm --nogpu (no X yet).

The only problems encountered were:
  - Like CrOS, I also needed to use the default float ABI (presumably hard).
  - The strings in GrBinHashKeyTest weren't necessarily 4-byte aligned.

BUG=skia:

Review URL: https://codereview.chromium.org/746043002
 2014-11-21 06:48:43 -08:00
robertphillips
5b69377507 Add MultiPictureDraw to nanobench 
I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.

TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/0ddad31012dabfc1267effc8071d37f7d606efbe

Review URL: https://codereview.chromium.org/731973005
 2014-11-21 06:19:36 -08:00
robertphillips
e77dadd91a Revert of Add MultiPictureDraw to nanobench (patchset #7 id:120001 of https://codereview.chromium.org/731973005/) 
Reason for revert:
Needs more work

Original issue's description:
> Add MultiPictureDraw to nanobench
>
> I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.
>
> TBR=bsalomon@google.com
>
> Committed: https://skia.googlesource.com/skia/+/0ddad31012dabfc1267effc8071d37f7d606efbe

TBR=mtklein@google.com,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/750583002
 2014-11-21 05:50:21 -08:00
robertphillips
0ddad31012 Add MultiPictureDraw to nanobench 
I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium.

TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/731973005
 2014-11-21 05:35:54 -08:00
fmalita
8ebaa71712 Revert of SkCanvas::clear() should call down to devices even when the clip is empty. (patchset #1 id:1 of https://codereview.chromium.org/735233003/) 
Reason for revert:
Chrome unit_tests failures on Mac & Win, blocking the roll: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/5613

Original issue's description:
> SkCanvas::clear() should call down to devices even when the clip is empty.
>
> SkDrawIter had a lovely, completely unused, option for this.  Oversight?
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/378e70d8e561b72a904286ea231946f5c8345b9a

TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/748733002
 2014-11-20 20:44:04 -08:00
tfarina
60b24d0df7 Cleanup: Delete webtry.gyp 
Looks like this was left over when we moved it into buildbot.

Also remove a few other, now unnecessary, references to webtry.

BUG=None
R=humper@google.com

Review URL: https://codereview.chromium.org/726833004
 2014-11-20 18:20:06 -08:00