converting from YUV to RGB on GPU.
Change-Id: I872e1e85f3efccce7bf93d2f3d5f2a841b8a5b0f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257680
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
In DDL-mode, this pulls the tessellation of the GrFillRectOp's vertices forward to record time.
Bug: skia:9601
Change-Id: I1a505845cc20f795d6f171b4c19d779475fdd240
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257685
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
In Release mode GCC 8 finds some issue I don't exactly understand when
using SkSTArray (or even SkTArray) here with MEM_COPY=true, for both
arrays, issuing one -Warray-bounds warning and one -Wstringop-overflow
warning for each array, ostensibly about the calls to resize_back().
(Oddly if you remove the initial reservations in the constructors, this
drops to just one warning each.)
My initial suspicion was some sort of aliasing issue, but I think the
SkPoint / 2x GrGLfloat pun might be legal, and even if it weren't, it
would not explain why the verbs array warns in the same manner.
Anyway I'd care more about this if the pattern of allocating an array
of a fixed runtime size weren't served better by SkAutoSTArray. No
warnings from GCC now.
Change-Id: I6959acc0500df4539e43e5d280c1e872b8c2fca3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257862
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Also fix some compile breakages from recent Skia changes.
No changes to Skia API.
Change-Id: Ifd0b1d89fb4ea3cf1f6a7170f2f74614276364ae
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257877
Commit-Queue: Stephen White <senorblanco@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Change-Id: I85477806b151773bc715f31bcdb05554107cc6b4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257700
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Previously, this was only checked for desktop GL, not for GLES. With [1], ANGLE
now exposes GL_ARB_sync for GLES, so we should extend the check. Also always
check for GL_APPLE_sync for consistency. It's technically out-of-spec for
GL_ARB_sync to exist outside of desktop GL, and for GL_APPLE_sync to exist
outside of GLES, but if the platform is listing the extensions, we should expect
them to work anyway.
Bug: chromium: 1028799
Change-Id: I411d2f106df0a2d7eb9b288053478ee79e060b81
R: reed@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257693
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Change-Id: Ib4baeec7dc7247b81c7e4a1ef7f85ef378e4be19
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257621
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
fb40d231c3..249cb20017
git log fb40d231c3e2..249cb200173f --date=short --first-parent --format='%ad %ae %s'
2019-12-03 syoussefi@chromium.org Translator: Rename TIntermInvariantDeclaration to ..GlobalQualifier..
2019-12-03 syoussefi@chromium.org glslang.l: refactor extension checks
2019-12-03 syoussefi@chromium.org Automatically call flex/bison if necessary
2019-12-03 syoussefi@chromium.org Vulkan: Fix WaW same-layout image transitions
2019-12-03 jmadill@chromium.org Revert "Add new test runner harness."
2019-12-03 geofflang@chromium.org D3D9: Log the exact error code generated by D3D9 device creation.
2019-12-03 geofflang@chromium.org Skip flaky BlendMinMaxTest.RGBA16F/ES2_Metal.
2019-12-03 geofflang@chromium.org Link to the autoroller configuration directory in the wrangling doc.
2019-12-03 thakis@chromium.org Remove an unused .gn file.
2019-12-03 flibitijibibo@gmail.com Fix UWP build
2019-12-03 geofflang@chromium.org GL: Make GL_EXT_texture_format_BGRA8888 enableable.
2019-12-03 jmadill@chromium.org Use SwiftShader-based ICD generation.
2019-12-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 83af46951202..a4af7676feb0 (1 commits)
2019-12-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 979b531e9fff..0a0625a3dca6 (1 commits)
2019-12-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 47f3eb42641b..3ed4586044f2 (1 commits)
Created with:
gclient setdep -r third_party/externals/angle2@249cb200173f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Cq-Include-Trybots: skia/skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: bsalomon@google.com
Change-Id: I627cd0c33d0b6d8b00f46eda1bfaa399ae92203d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257798
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
* Convert from fInitialX, fInitialY to an SkPoint fInitialOrigin
* Start putting params in a consistent order
* inline and remove single use functions
Change-Id: I53eecf6098b475ef05f4f5c4133510ee1104073f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257756
Auto-Submit: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
* Make a single private section
* Reorganzie private section
* Start making const things const
Change-Id: I88081d02ee6034234d35d15306bffb47ce63ac8c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257688
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Instead of always grabbing the first frame at load time, only do so for
single-frame images.
For multi-frame images, defer frame resolution until actually needed
(at seek time).
There's a slight complication in dealing with image scaling: since we
no longer know the intrinsic size of the frames upfront, we need to
set up a transform effect preemptively for multi-frame images, and
update on the fly when the frames are resolved. This is not
necessarily bad, because theoretically frames could have different
sizes.
Bug: skia:9686
Change-Id: Ib831d0e2ecad061ba52bdd8721e7598ea38c1e6e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257622
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
For clients not using JSON, the factories were inconsistent.
Change-Id: Ifd920fa1e18f5edffa12de238af8488406951e5b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257683
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This does several pure refactoring changes:
1. Adds reset() functions to each helper struct type instead of having
TessellationHelper impl. the struct's reset logic.
2. Moves computeDegenerateQuad() to EdgeEquations.
3. Separate adjustVertices() into adjust and adjustDegenerate varieties, and
have it take a signed distance. This makes it no longer branch on degeneracy
or on whether or not it's insetting or outsetting.
4. The top-level inset()/outset() functions apply the appropriate sign to the
edge distances, and use the appropriate adjust or adjustDegenerate function
based on the inset/outset degenerate flag in OutsetRequest. Essentially all
the old branching in adjustVertices() is baked into the choice of inset() or
outset().
5. Rearranged the structs and function definitions so no forward declarations
were needed, and functions in CPP matched H order.
The major functional change with this is that adjustDegenerate() now has
an optimized case for rectilinear quads, where it can continue to use
moveAlong() but with smaller inset distances.
Change-Id: Ifc7f4537a4e89e82c74e831ab1cd00ffc4daaa4f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/256777
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
This may fix a fuzzer bug that trips an
assert for empty rectangles. I could not reproduce
the fuzzer problem.
Bug: chromium:1029831
Change-Id: I88befb7c27d9ddc357e0a9e494e68125f8252f43
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257676
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
It's error-prone, and now unused.
Change-Id: Ibae848bdb121695521e66d6e8544a82678e22f7c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257660
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Change-Id: Ib9013fa9bedbbbf8a7787ef2a75d707dd6360cf8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257635
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Calls to Required() are subtly error prone without taking the alpha
types into account. Just so happens that we're doing half of that here
ourselves, and letting Required() handle the rest... best to just let
CSXformSteps handle all the logic.
This _does_ slightly_ change the values of unpremul and premul, in that
it's now possible for them both to be true when we need a color space
transform (when the source and dst are both premul). We don't think
this actually changes any of the logic that uses these bools though...
the canvas2D fast paths are unchanged because if needsColorConversion is
false, we'll still never set both at once. And the `convert` bool only
ever looks at the logical or of the two, so it won't change.
Change-Id: I051793cd84693e1a5dd367d036ab7f2e2308bbf8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257659
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
While we're asking if there are any color space xform steps to do,
let's look at all 5 of them, including whether we need to unpremul or
premul. The sprite blitter paths this logic guards can't handle
any change in color space _or_ alpha type, so this is a perfect fit.
Without this fix, we'd happily draw premul into unpremul using memcpy().
(Unpremul -> premul was already guarded by the check with my new note.)
Change-Id: Ic8d9e69f6c7bd2902ff77393de1da9cd940ea826
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257657
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This call is working perfectly fine as far as I reckon, but it's subtly
error-prone to not explicitly mention the alpha types when making this
kind of decision. It just so happens that Requires() used premul/premul
just as we do here, so this should be a no-op.
Change-Id: I96850cc4109a6ac3c46bb7bbb467a30628ee8d44
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257658
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
This isn't even used, so it definitely definitely
will have no perf impact.
Change-Id: I3e459bce440aef5e3e8fa2724dd2839b866920b6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257656
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Bug: skia:9546
Change-Id: Ib91880e09ae6373bc133d684aa7510c67681ec1e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257629
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
This reverts commit 122eda7877.
Reason for revert: breaking up into parts to help diagnose a possible performance regression.
Original change's description:
> replace SkColorSpaceXformSteps::Required()
>
> It's error-prone to ask if a color space transform is required without
> explicitly mentioning alpha types. I think the whole method can be
> replaced by a friendlier constructor and direct use of flags/mask:
>
> SkColorSpaceXformSteps::Required(src.colorSpace(), dst.colorSpace())
>
> ~~~>
>
> 0 != SkColorSpaceXformSteps(src, dst).flags.mask()
>
> This removes the unexpected gray square from the fiddle in skia:9662.
>
> Bug: skia:9662
> Change-Id: Id54cae534023ab29c94dcc149e6b67fc9c166665
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257399
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>
TBR=mtklein@google.com,brianosman@google.com
Change-Id: I4073f45c52e77f02fe3ecb75c20fc29873080c20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9662
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257652
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Drop unnecessary () in `const char* (*fText)`. Sure, whatever.
Then a couple tweaks where we use strncpy():
In one case in SkICC.cpp, GCC warns us we're passing sizeof(dst) as
the copy count, which can be error prone because you may miss a
terminating nul. I believe the existing strncpy() behavior is what
we want here, so I've stifled this and left a note. We don't really
want a terminating nul... we want a zero fill of the remaining dst.
On the other side of that if-statment in that same function, GCC
warns that we've passed exactly sizeof(src) as the copy count when
writing the calculated description prefix, which again might be
buggy due to a missed terminating nul. Seemed like memcpy() was the
way to go here for that prefix. Ultimately we check to make sure we
wrote every single destination byte.
Over in SkPDFMetadata.cpp, strncpy() is concerned once again that
we're copying strlen(src) and thus omitting the terminating nul. As
usual we don't want that terminating nul, so switch to memcpy() to
make that explicit.
I'm starting to think strncpy() is too helpful to reason about sanely.
Change-Id: I1bcd5f4e406ca388c1c236c5f3ee531bf1737705
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257408
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This was originally exposed for use with specs/web-img-decode and has
seen some actual use.
Change-Id: I6cc4fdf431b45cbbc21b91881c688c5545ca44a3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257317
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Provides functionality similar to AE property maps
Change-Id: I1705706a6b7e25fbab55465f2e20d0b145330b0b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255977
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This untangles some of the dirty state tracking and dynamic rebuilding
support (that's only needed for the GUI editor), so the core code is
more streamlined. It also paves the way for feeding the RP to bindings.
Change-Id: I208ec59622154fdb2845c3ae8f7efb070d1abfc7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257476
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
ea0dcd4bda..fb40d231c3
git log ea0dcd4bda18..fb40d231c3e2 --date=short --first-parent --format='%ad %ae %s'
2019-12-02 jmadill@chromium.org Add new test runner harness.
2019-12-02 syoussefi@chromium.org Vulkan: implement external semaphore barriers
2019-12-02 syoussefi@chromium.org Fix RenderingLimitToDefaultFBOSizeWithNoAttachments test
2019-12-02 syoussefi@chromium.org Add test for multithreaded shared-context resource
2019-12-02 geofflang@chromium.org D3D: Log why a renderer fails to initialize.
2019-12-02 timvp@google.com VULKAN: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture2d
2019-12-02 xinyi.he@arm.com Vulkan: Textures incorrect on Android maps with Vulkan Backend
2019-12-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader fb7ca1d5aca5..b64fbfec4dcd (3 commits)
2019-12-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src b334829a91d6..47f3eb42641b (1 commits)
2019-12-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 38b4db48f98c..83af46951202 (1 commits)
Created with:
gclient setdep -r third_party/externals/angle2@fb40d231c3e2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Cq-Include-Trybots: skia/skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: bsalomon@google.com
Change-Id: I7525483e0e5100dfac7f0829e5fd9d0aaf8148a1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257558
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/3f4fe7e32cfe34f02d0244ba6cb73cc5ba58c9be [resultdb] Add empty resultdb module (nodir@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5ef915676ed533f87d236835f8a7e31b9216b854
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257513
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/6d31ed5d639e0bead9080b6543f8c1e6b69b0221 cpplint: Fix Python 3 errors. (ehmaldonado@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8594a8acc84a2180f3647012571d247e8fa2a856
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257536
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Change-Id: I4733e6ea234874d78158d4509fafdef8371659f6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257499
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Another memcpy-doesn't-activate-union-fields bug for GCC, I think.
As far as I can tell this union is completely pointless, and this is so
prehistoric git blame doesn't help. (svn blame wouldn't even.) I don't
really want to know.
Change-Id: I5a67469337752986c6a5979d91cb56417955d019
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257445
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
I think GCC with optimization is getting confused about what field of
this union is active, and then triggers a crazy warning about
memcpy()'ing (size_t)-1 bytes.
Reading the rules about unions, I think it might be that really only "="
is ever able to switch which union field is active, and our memcpy()
here really doesn't technically work to change the active field.
Change-Id: Ibe33143161935d5e39b9a2f5d35560e4961056e0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257444
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Why are we testing how memset() and snprintf() work in
tests/StringTest.cpp. Nevermind, I don't want to know...
Change-Id: Ic8608fea95635ee2fbb7da34a195de73d7a1444a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257415
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Change-Id: Ieaba188e620e5c1f1d423109e628b0ca78f3afe0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257394
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/02b5af35755b90057b87f48afe9d7faa1de5d97f fix hashtags: double colons are not hashtags (apolito@google.com)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I453f1042f4fba96cf0f4ba87fa94b6a0e7d16f7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257414
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
1) It correctly handles GPs that have a local matrix
2) It applies its rectangle after the child FP's coord transform. It makes
the child's transform be a no-op and the builder will no longer insert code
or uniforms for the child transform. The domain effect adds its own coord
transform with the same settings as the child's original transform. The result
is that the generated code only has one coord transform matrix and that matrix
is applies in the vertex shader. The previous version of this effect applied
the transform in the fragment shader.
Bug: skia:9570
Change-Id: I514e959414aebe240e9f99e30f13265d8751b656
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257054
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
