reed
c695e95417
add gm to show miplevels (patchset #2 id:20001 of https://codereview.chromium.org/849173004/ )"
...
fixed memory leak
This reverts commit 04f07fcbfd
.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/854163002
2015-01-16 05:01:16 -08:00
skia.buildbots
0582f5a8f1
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/855003003
2015-01-16 04:44:24 -08:00
mtklein
05982367f5
Revert of Add temporary blacklist debugging. (patchset #1 id:1 of https://codereview.chromium.org/805643004/ )
...
Reason for revert:
fixed!
Original issue's description:
> Add temporary blacklist debugging.
>
> Not sure why blacklists don't seem to work on bots. They look right.
>
> NOTREECHECKS=true
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f77156e1925cd5d5504070fe5533a4c456732c1b
TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/851903003
2015-01-15 19:11:55 -08:00
mtklein
04f07fcbfd
Revert of add gm to show miplevels (patchset #2 id:20001 of https://codereview.chromium.org/849173004/ )
...
Reason for revert:
==31530==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 224 byte(s) in 2 object(s) allocated from:
#0 0x7febb223f65b in operator new(unsigned long) (/home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/dm+0x35865b)
#1 0x7febb3483c56 in SkMipMap::Build(SkBitmap const&, SkDiscardableMemory* (*)(unsigned long)) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkMipMap.cpp:181:9
#2 0x7febb2c37914 in ShowMipLevels::onDraw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/downsamplebitmap.cpp:228:24
#3 0x7febb2295736 in skiagm::GM::drawContent(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:32:5
#4 0x7febb2295019 in skiagm::GM::draw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:24:5
#5 0x7febb226722f in DM::GMSrc::draw(SkCanvas*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:22:5
#6 0x7febb226d929 in DM::RasterSink::draw(DM::Src const&, SkBitmap*, SkWStream*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:230:12
#7 0x7febb224e004 in Task::Run(Task*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DM.cpp:254:25
#8 0x7febb3805e4c in (anonymous namespace)::ThreadPool::Loop(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkTaskGroup.cpp:149:13
#9 0x7febb460dc7c in thread_start(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/utils/SkThreadUtils_pthread.cpp:66:9
#10 0x7febb1251f6d in start_thread /build/buildd/eglibc-2.17/nptl/pthread_create.c:311
Indirect leak of 699528 byte(s) in 2 object(s) allocated from:
#0 0x7febb22214ab in __interceptor_malloc (/home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/dm+0x33a4ab)
#1 0x7febb473e3c6 in sk_malloc_flags(unsigned long, unsigned int) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/ports/SkMemory_malloc.cpp:54:15
#2 0x7febb473e19a in sk_malloc_throw(unsigned long) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/ports/SkMemory_malloc.cpp:40:12
#3 0x7febb3483c94 in SkMipMap::Build(SkBitmap const&, SkDiscardableMemory* (*)(unsigned long)) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkMipMap.cpp:181:18
#4 0x7febb2c37914 in ShowMipLevels::onDraw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/downsamplebitmap.cpp:228:24
#5 0x7febb2295736 in skiagm::GM::drawContent(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:32:5
#6 0x7febb2295019 in skiagm::GM::draw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:24:5
#7 0x7febb226722f in DM::GMSrc::draw(SkCanvas*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:22:5
#8 0x7febb226d929 in DM::RasterSink::draw(DM::Src const&, SkBitmap*, SkWStream*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:230:12
#9 0x7febb224e004 in Task::Run(Task*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DM.cpp:254:25
#10 0x7febb3805e4c in (anonymous namespace)::ThreadPool::Loop(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkTaskGroup.cpp:149:13
#11 0x7febb460dc7c in thread_start(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/utils/SkThreadUtils_pthread.cpp:66:9
#12 0x7febb1251f6d in start_thread /build/buildd/eglibc-2.17/nptl/pthread_create.c:311
Original issue's description:
> add gm to show miplevels
>
> BUG=skia:
> TBR=
>
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/a598f4b773f066a939e0216a116c179b90550727
TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/854103004
2015-01-15 18:36:07 -08:00
mtklein
51fc019f21
force a build with fixed --blacklist
...
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/850413003
2015-01-15 18:28:53 -08:00
reed
a598f4b773
add gm to show miplevels
...
BUG=skia:
TBR=
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/849173004
2015-01-15 18:09:15 -08:00
mtklein
f77156e192
Add temporary blacklist debugging.
...
Not sure why blacklists don't seem to work on bots. They look right.
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/805643004
2015-01-15 16:21:24 -08:00
mtklein
9dc0910c2c
newlines after failures
...
NOTREECHECKS=true
BUG=skia:3255
Review URL: https://codereview.chromium.org/853123003
2015-01-15 15:47:33 -08:00
mtklein
2f64eec5df
Totally serialize gpu tests on Windows.
...
NOTREECHECKS=true
BUG=skia:3255
Review URL: https://codereview.chromium.org/845193006
2015-01-15 14:20:42 -08:00
mtklein
e1315526cd
Turn back on image and subset sources now that they're blacklisted on Android.
...
To land after https://codereview.chromium.org/850403002/
NOTREECHECKS=true
BUG=skia:3255
Review URL: https://codereview.chromium.org/857483003
2015-01-15 13:58:56 -08:00
mtklein
a2ef642b00
DM: add basic --blacklist <config> <srcType> <name> functionality.
...
NOTREECHECKS=true
BUG=skia:3255
Review URL: https://codereview.chromium.org/817573005
2015-01-15 13:44:22 -08:00
reed
319a9c25b2
remove suppressions (CL was reverted)
...
BUG=skia:
TBR=
NOTREECHECKS=True
NOTRY=True
Review URL: https://codereview.chromium.org/837633007
2015-01-15 13:02:03 -08:00
mtklein
82d2843cc5
turn back on gpu tests
...
NOTREECHECKS=true
BUG=skia:3255
Review URL: https://codereview.chromium.org/817573004
2015-01-15 12:46:02 -08:00
reed
ca8e350a8d
Revert "choose better mip level"
...
This reverts commit 09544fcf96
.
BUG=skia:
TBR=
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/849173003
2015-01-15 12:37:31 -08:00
sergiyb
a115b770f3
Remove obsolete mac_gpu
...
BUG=chromium:426897
R=kbr@google.com ,phajdan@google.com,reed@google.com
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/812963003
2015-01-15 12:33:04 -08:00
mtklein
748ca3bf2d
Sketch DM refactor.
...
BUG=skia:3255
I think this supports everything DM used to, but has completely refactored how
it works to fit the design in the bug.
Configs like "tiles-gpu" are automatically wired up.
I wouldn't suggest looking at this as a diff. There's just a bunch of deleted
files, a few new files, and one new file that shares a name with a deleted file
(DM.cpp).
NOTREECHECKS=true
Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88
Review URL: https://codereview.chromium.org/788243008
2015-01-15 10:56:12 -08:00
egdaniel
0063a9b69a
Move XferEffects class to GrCustomXfermode file
...
BUG=skia:
Review URL: https://codereview.chromium.org/844913003
2015-01-15 10:52:32 -08:00
fmalita
b0878797b4
SkPictureShader should handle negative scaling gracefully.
...
Let's not choke on inverted tiles.
BUG=chromium:447707
R=robertphillips@google.com ,reed@google.com
Review URL: https://codereview.chromium.org/852213002
2015-01-15 10:45:56 -08:00
mtklein
114c3cd054
Revert of Sketch DM refactor. (patchset #45 id:850001 of https://codereview.chromium.org/788243008/ )
...
Reason for revert:
plenty of data
Original issue's description:
> Sketch DM refactor.
>
> BUG=skia:3255
>
>
> I think this supports everything DM used to, but has completely refactored how
> it works to fit the design in the bug.
>
> Configs like "tiles-gpu" are automatically wired up.
>
> I wouldn't suggest looking at this as a diff. There's just a bunch of deleted
> files, a few new files, and one new file that shares a name with a deleted file
> (DM.cpp).
>
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88
TBR=bsalomon@google.com ,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3255
Review URL: https://codereview.chromium.org/853883004
2015-01-15 10:15:02 -08:00
Mike Klein
c563172f53
more GMs to rebase?
...
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/789933003
2015-01-15 12:17:14 -05:00
mtklein
709d2c3e50
Sketch DM refactor.
...
BUG=skia:3255
I think this supports everything DM used to, but has completely refactored how
it works to fit the design in the bug.
Configs like "tiles-gpu" are automatically wired up.
I wouldn't suggest looking at this as a diff. There's just a bunch of deleted
files, a few new files, and one new file that shares a name with a deleted file
(DM.cpp).
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/788243008
2015-01-15 08:30:25 -08:00
Mike Klein
8eadff1e8c
these GM names are ridiculous
...
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/852193003
2015-01-15 11:24:38 -05:00
mtklein
0c278972d0
Why are we afraid of saveLayer() bounds?
...
They're only hints. We can ignore them in this optimization.
My only hesitation is that this pattern doesn't seem to happen in our .skps.
BUG=skia:
Review URL: https://codereview.chromium.org/849243002
2015-01-15 08:08:10 -08:00
reed
09544fcf96
choose better mip level
...
BUG=skia:
Review URL: https://codereview.chromium.org/845793005
2015-01-15 08:01:40 -08:00
skia.buildbots
fc5ad3cd97
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/845873005
2015-01-15 07:49:25 -08:00
egdaniel
04ea6344fe
Add include before SK_SUPPORT_GPU in SkArithmeticMode_gpu.h to fix android build
...
BUG=skia:
Review URL: https://codereview.chromium.org/852193002
2015-01-15 07:05:03 -08:00
fmalita
1a178ca6dd
Use device-space stroke width for SkDraw::drawRect() quick-reject
...
The stroke width needs to be CTM-adjusted when applied to device space
rects.
BUG=skia:3313
R=reed@google.com
Review URL: https://codereview.chromium.org/801353008
2015-01-15 06:01:23 -08:00
skia.buildbots
6e87913ab9
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/852163002
2015-01-15 05:40:51 -08:00
skia.buildbots
05efbfe39d
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/855473003
2015-01-14 23:06:12 -08:00
fmalita
8703b539f1
Rebaseline 6 GMs after crrev.com/841763005
...
BUG=skia:3299
TBR=djsollen@google.com
Review URL: https://codereview.chromium.org/852053004
2015-01-14 18:11:18 -08:00
joshualitt
1ceacff65e
a few ignores for nvprmsaa4
...
TBR=
NOTRY=True
BUG=skia:
Review URL: https://codereview.chromium.org/850143003
2015-01-14 16:05:09 -08:00
Brian Salomon
b31f0fb793
update images after texture cache change
...
Review URL: https://codereview.chromium.org/852913002
2015-01-14 17:55:18 -05:00
mtklein
b54fe40b07
fMaxTexCoords is unused in Release builds
...
BUG=skia:
Review URL: https://codereview.chromium.org/853643005
2015-01-14 14:18:54 -08:00
joshualitt
89069a9bdb
possible bug fix for nvpr
...
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/850953003
2015-01-14 13:51:18 -08:00
reed
afdbedb73c
add sample for filter quality
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/788163007
2015-01-14 13:16:26 -08:00
egdaniel
f351aa3bf1
Add Arithmetic mode xp.
...
BUG=skia:
Review URL: https://codereview.chromium.org/837633005
2015-01-14 12:53:01 -08:00
reed
26feeba267
separate out the scaline-choosing to simplify chooseProcs
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/796063007
2015-01-14 12:28:22 -08:00
jcgregorio
bd2059a02a
fix link reference in docs
...
BUG=skia:
NOTRIES=1
TBR=halcanary
Review URL: https://codereview.chromium.org/853703003
2015-01-14 12:03:01 -08:00
jcgregorio
0c2dc21a58
Add reference material for the style of markdown we use.
...
Preview here: http://skiadocs.com:8000/dev/tools/markdown?cl=853493004
Note that the image won't show up, that's a known issue with the way patching in CLs works.
BUG=skia:
Review URL: https://codereview.chromium.org/853493004
2015-01-14 11:26:30 -08:00
egdaniel
16a04b8414
Move Gpu ArithmeticMode xfer effect to _gpu files.
...
BUG=skia:
Review URL: https://codereview.chromium.org/827163004
2015-01-14 10:49:18 -08:00
bsalomon
5236cf480d
Make uncached textures uncached from the get go.
...
This avoids the problem of a newly created uncached texture causing a purge of cached resources.
BUG=chromium:445885
Review URL: https://codereview.chromium.org/846303002
2015-01-14 10:42:08 -08:00
robertphillips
028b98a080
Add repro GM for GPU clipped-AA vs. non-AA drawRect discrepancy
...
In the clip stack we were manually rounding out non-AA clip rects but leaving the hardening of non-AA drawRects up to the GPU. In some border cases the GPU can truncate rather than round out resulting in visual discrepancies.
BUG=423834
Committed: https://skia.googlesource.com/skia/+/933a03fecb65c83f81cf65d5cf9870c69aa379ff
Review URL: https://codereview.chromium.org/839883003
2015-01-14 09:44:02 -08:00
mtklein
7c348a8097
DM can see into src/gpu. No need for relative include.
...
BUG=skia:
Review URL: https://codereview.chromium.org/853613004
2015-01-14 09:25:01 -08:00
mtklein
2c0e8f13a0
Remove self-assignment in a test.
...
BUG=skia:
Review URL: https://codereview.chromium.org/853723002
2015-01-14 08:49:10 -08:00
joshualitt
71c9260e6f
More changes to bring together path / geo procs
...
BUG=skia:
Review URL: https://codereview.chromium.org/820783005
2015-01-14 08:12:47 -08:00
robertphillips
95145a9d3e
Switch to a more complete method of filtering hoisted layers
...
Committed: https://skia.googlesource.com/skia/+/74668a8e818fd891a08c4966cc5973b04c1ad992
Review URL: https://codereview.chromium.org/842323003
2015-01-14 08:08:21 -08:00
egdaniel
38cd055215
Do some minor pre cleanup work before converting all xfermodes to XPs.
...
BUG=skia:
Review URL: https://codereview.chromium.org/853543003
2015-01-14 08:05:11 -08:00
mtklein
b47bba7c77
upstream hooking into google3 crash handler for better stacktraces
...
BUG=skia:
Review URL: https://codereview.chromium.org/821643006
2015-01-14 06:38:28 -08:00
skia.buildbots
8018e680a4
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/812283007
2015-01-14 05:14:15 -08:00
mtklein
3f915c0c9a
upstream google3 include paths for jsoncpp
...
BUG=skia:
No public API changes
TBR=reed@google.com
Review URL: https://codereview.chromium.org/853613002
2015-01-14 05:02:39 -08:00