Commit Graph

33983 Commits

Author SHA1 Message Date
Robert Phillips
c90b4dbec5 Reland "Prevent masked solid-color draws from being turned into clears"
This reverts commit f92bb3785f.

Reason for revert: The new unit test has been suppressed on ANGLE

Original change's description:
> Revert "Prevent masked solid-color draws from being turned into clears"
> 
> This reverts commit e9f2bbe082.
> 
> Reason for revert: ANGLE
> 
> Original change's description:
> > Prevent masked solid-color draws from being turned into clears
> > 
> > GrRenderTargetContext::drawRect was eliding a BlurMask filtered circle.
> > 
> > Bug: skia:7765
> > Change-Id: Id98c059f7d786ee5c9bca839c8e099997ff2aedb
> > Reviewed-on: https://skia-review.googlesource.com/122793
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> 
> TBR=bsalomon@google.com,robertphillips@google.com
> 
> Change-Id: I1b7752eab0fcf55ab6248eed587fd85d438efd78
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:7765
> Reviewed-on: https://skia-review.googlesource.com/122960
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=bsalomon@google.com,robertphillips@google.com

Change-Id: If432c24548ef0f6df4fd6a06aa3b1fb38ba793b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7765
Reviewed-on: https://skia-review.googlesource.com/123000
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-23 15:12:11 +00:00
Robert Phillips
a96a101071 Disable BlurMaskBiggerThanDest unit test on ANGLE
Bug: skia:7835
Change-Id: Iec9469799121f435670c5a3841707fe6199066c5
Reviewed-on: https://skia-review.googlesource.com/122954
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-23 15:07:00 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
7230861301 Roll skia/third_party/skcms c4941e8..71966da (1 commits)
https://skia.googlesource.com/skcms.git/+log/c4941e8..71966da

2018-04-23 mtklein@chromium.org fail skcms_Parse() for useless profiles


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: I8c36fb89675b9b1639a1d494641d8993d3723c93
Reviewed-on: https://skia-review.googlesource.com/122980
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-23 15:02:06 +00:00
Ben Wagner
122b38560f Add SwiftShader Test jobs.
Bug: skia:7671
Change-Id: I29134929071ba6c59de948e5f579d33e973f9baa
Reviewed-on: https://skia-review.googlesource.com/122541
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-04-23 15:01:40 +00:00
Ben Wagner
7a3c6748f3 Backspace opens slide picker (not paint) in viewer.
A recent change added the "Paint" section to the viewer tools window. The
code around forcing the slide picker open when the backspace key was
pressed was inadvertantly separated from the slide picker section, so
now the paint section is confusingly held open instead. This changes the
logic so that the slide picker is once again the target of backspace.

Change-Id: Ibfcb78bb0a1e2bdbb2ccce54b38e8206e0303753
Reviewed-on: https://skia-review.googlesource.com/122949
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-04-23 14:57:00 +00:00
Brian Osman
b7eace414d Reject XYZ profiles missing some (or all) TRC tags
The previous behavior isn't justified by the spec, and doesn't match
skcms' behavior. To ease migration and avoid discrepancy when dealing
with fuzzer-generated profiles, enforce the stricter rules here.

Bug: chromium:835666
Change-Id: Ice6452b521a737d6dc339571dcbb313567235ed6
Reviewed-on: https://skia-review.googlesource.com/122952
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-04-23 14:46:30 +00:00
recipe-roller
c4d6a001cd Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/161623779eaf8cd3dd571dfa4aa5b44b9611396f presubmit: don't attempt to verify nonexistent vpython specs. (jbudorick@chromium.org)
  https://crrev.com/98824231fc49c39ec47005c1e580684fc34d3026 [git-cl] make more informative error message. (tandrii@chromium.org)
  https://crrev.com/5c62ed59d2a3901931d01b27388d7c0037178a8e owners: Add support for comments at the end of the line. (ehmaldonado@chromium.org)
  https://crrev.com/733d4ec8e3364f9491291963475aee2a137bb2f1 [gerrit_util] learn about and use LUCI_CONTEXT when available. (tandrii@chromium.org)
  https://crrev.com/b3c4441c8176780f5f58e22c1ffb9406f9934799 [auth] cache LUCI_CONTEXT local_auth parameters. (tandrii@chromium.org)
  https://crrev.com/741afe8c930f988eb8d2b715540cfc598b12c38a [auth] cleanup old code.google.com oauth scope usage. (tandrii@chromium.org)
  https://crrev.com/067ef5d8941a59ca176f5ee63bb02d0e3df947c4 Add support for checking that OWNERS files are correctly formatted. (ehmaldonado@chromium.org)
  https://crrev.com/94580ab035eb3d05e352dc9c16b4908e9f744579 [auth] Fix typo introduced in https://crrev.com/c/1018488/13/auth.py#514 (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I98cd3d3913f1289be562add4d7170ff2b8ac7263
Reviewed-on: https://skia-review.googlesource.com/122950
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-04-23 14:38:40 +00:00
Leon Scroggins III
57e1f02011 (Mostly) respect FilterQuality in draw[stretchy]
Bug: b/77917978

For
  drawImageLattice
  drawBitmapLattice
  drawImageNine
  drawBitmapNine
, respect the SkFilterQuality on the SkPaint. Previously the GPU used
the lowest quality to avoid a bleeding effect, leading to ugly nine-
patches on Android.

For all backends, cap the filter quality at kLow_SkFilterQuality.
Update SkCanvas' documentation to specify this.

Change-Id: Id28c7753834975f039170f14bc51be4f2bd44d41
Reviewed-on: https://skia-review.googlesource.com/121891
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
2018-04-23 14:27:30 +00:00
Eric Boren
5c2ed720ec [infra] Fast-forward recipes, re-enable roller
Bug: skia:
Change-Id: I3dfda2b49917079350b89d739ba6e00fd12c20f1
Reviewed-on: https://skia-review.googlesource.com/122300
Auto-Submit: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-23 14:06:50 +00:00
Robert Phillips
f92bb3785f Revert "Prevent masked solid-color draws from being turned into clears"
This reverts commit e9f2bbe082.

Reason for revert: ANGLE

Original change's description:
> Prevent masked solid-color draws from being turned into clears
> 
> GrRenderTargetContext::drawRect was eliding a BlurMask filtered circle.
> 
> Bug: skia:7765
> Change-Id: Id98c059f7d786ee5c9bca839c8e099997ff2aedb
> Reviewed-on: https://skia-review.googlesource.com/122793
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,robertphillips@google.com

Change-Id: I1b7752eab0fcf55ab6248eed587fd85d438efd78
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7765
Reviewed-on: https://skia-review.googlesource.com/122960
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-23 13:39:30 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
4ad8a179cb Roll skia/third_party/skcms e658346..c4941e8 (1 commits)
https://skia.googlesource.com/skcms.git/+log/e658346..c4941e8

2018-04-19 mtklein@chromium.org copy BUILD.gn into skcms repo


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=stani@google.com

Change-Id: Ia87cbb4641b91d1b8d24eeef4f720273936313c4
Reviewed-on: https://skia-review.googlesource.com/122929
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-23 13:16:53 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
12606e11e9 Roll third_party/externals/angle2/ 505ea1bb5..40786bdfc (3 commits)
505ea1bb56..40786bdfc8

$ git log 505ea1bb5..40786bdfc --date=short --no-merges --format='%ad %ae %s'
2018-04-18 jiawei.shao ES31: Add validation on geometry shader interface blocks matching
2018-04-19 lucferron Vulkan: Implement Texture wrap modes and non-mipmapped filtering modes
2018-04-13 oetuaho Fix Vulkan renderer string for NVIDIA

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: Ifc39e911c45deab9756f3e7cc1866cd499ec0cde
Reviewed-on: https://skia-review.googlesource.com/122927
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-23 13:13:30 +00:00
Ravi Mistry
e033e969ca Remove Android compile bot from the CQ
NoTry: True
Bug: skia:7834
Change-Id: Ia38a800da098101effb6804118ccf4b0a0a93c72
Reviewed-on: https://skia-review.googlesource.com/122945
Commit-Queue: Ravi Mistry <rmistry@google.com>
Auto-Submit: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-23 13:00:47 +00:00
Eric Boren
7817931a5c Switch RecreateSKPs and Bookmaker bots to use service accounts
Bug: skia:
Change-Id: I59aefe7c7e7a6861b00f0e22310e7ceaff3d6d0e
Reviewed-on: https://skia-review.googlesource.com/122944
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-23 13:00:19 +00:00
Eric Boren
32f8478ae9 Remove UpdateMetaConfig bot
It's perma-failing, and it doesn't work with Kitchen due to the new
service account not being authorized.  Rather than spend the energy to
fix the service account (and move to an internal repo) I'll just delete
it since it's blocked on a low priority bug with an unknown ETA.

Bug: skia:
Change-Id: I04636fda334f8a878bde2612b3edad65d81986dc
Reviewed-on: https://skia-review.googlesource.com/122943
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-23 12:59:48 +00:00
Robert Phillips
e43ff78af3 Disable threaded SW mask generation on DDL bots
Although we will support threaded generation of SW masks in DDL mode, this more closely matches Chrome's behavior

Change-Id: I28596f66693e3daa941c3dbd974a8d33f4561c16
Reviewed-on: https://skia-review.googlesource.com/122789
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-23 12:56:05 +00:00
Robert Phillips
e9f2bbe082 Prevent masked solid-color draws from being turned into clears
GrRenderTargetContext::drawRect was eliding a BlurMask filtered circle.

Bug: skia:7765
Change-Id: Id98c059f7d786ee5c9bca839c8e099997ff2aedb
Reviewed-on: https://skia-review.googlesource.com/122793
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-04-23 12:54:28 +00:00
Mike Klein
78fb04e69e roll skcms to just before where we added BUILD.gn
The next roll should find it wants to copy in BUILD.gn, right?

Change-Id: Idf9ab7891906a0a7df9b6ba99f95b556771b5797
Reviewed-on: https://skia-review.googlesource.com/122661
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-23 12:47:33 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
af4be058fe Roll third_party/externals/angle2/ aecfa71b4..505ea1bb5 (3 commits)
aecfa71b4a..505ea1bb56

$ git log aecfa71b4..505ea1bb5 --date=short --no-merges --format='%ad %ae %s'
2018-04-18 tobine Roll (2/2) to latest LVL as of 4/18/18
2018-04-18 tobine Roll (1/2) LVL version forward and disable VANGLE
2018-04-19 ynovikov Use EGL_KHR_no_config_context in Android GLES backend, when available

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I69ded436bf137cd900ef06907055b140294e5ba6
Reviewed-on: https://skia-review.googlesource.com/122924
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-23 00:01:16 +00:00
Yong-Hwan Baek
701a3ca157 Fixed SkVertices crashing on Windows DLL builds
SkVertices::Builder uses custom new operator but not exposed to dll.
While delete operator in SkVertices.h could be inlined, it causes crash on Windows DLL builds. This patch fixes this issue.
Change-Id: I8b635ad3aa4a3f496a392ce7840417947999e4b0
Reviewed-on: https://skia-review.googlesource.com/122480
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-04-22 14:42:01 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
20f8bd7711 Roll third_party/externals/angle2/ 3ec304dba..aecfa71b4 (6 commits)
3ec304dba2..aecfa71b4a

$ git log 3ec304dba..aecfa71b4 --date=short --no-merges --format='%ad %ae %s'
2018-04-20 ynovikov Print more logs
2018-04-10 geofflang Refactor packed enum generation to support EGL enums.
2018-04-20 geofflang Use LIKELY and UNLIKELY macros to wrap error generation.
2018-04-20 jmadill Fix WebGL compat feedback loop null deref.
2018-04-19 tobine Make Mock ICD json file a data_dep of Mock ICD
2018-04-19 lucferron Refactor Texture::syncState to pass down the Context

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: I6f07498ffda7bf9b524acc723f0b1e70dea0eca8
Reviewed-on: https://skia-review.googlesource.com/122860
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-22 14:36:58 +00:00
Brian Osman
e03a8ac962 Remove assert that color spaces have valid profile data
Chrome fuzzing can trigger this code with malformed profile data
(which suggests that the older SkColorSpace::MakeICC allowed some
invalid profile data to slip through). In any case, simply returning
false to reject the profile is fine.

Bug: chromium:835540
Change-Id: Ib675b8e9e3be444ad5dbf8153d60d86284682c90
Reviewed-on: https://skia-review.googlesource.com/122940
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-04-22 14:36:56 +00:00
Brian Salomon
5209d7fce3 Fix starting location in GrRTC::drawOval when converting to GrShape
Change-Id: I3b86d15add9d463e64c97f53bdb5042f1e2a2f27
Reviewed-on: https://skia-review.googlesource.com/122880
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-20 21:17:26 +00:00
Brian Salomon
62e4f3daf7 Analytic dashing of circles with single on/off intervals and butt caps.
Change-Id: If19ac52cb78af57572a102cec0084f5b6c037680
Reviewed-on: https://skia-review.googlesource.com/121882
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-20 18:45:35 +00:00
Brian Osman
2fda63abcd Fix argument names and documentation for SkMatrix44::set3x3()
Column-major is an implementation choice, not an interface. There is
exactly one acceptable subscript notation for indexing matrix elements,
and it's row first, then column. Having these named backwards was
unnecessarily confusing.

Note that this doesn't alter behavior in any way, it just brings this
function in line with expectations from any reasonable mathematician.

Change-Id: Ie4ceb40281ef507889d25403afbf24116514c45a
Reviewed-on: https://skia-review.googlesource.com/122790
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-04-20 18:08:18 +00:00
Adrienne Walker
1df7cd8712 Reland "Add stub gpu workaround generators"
This is a reland of 94d25b970b

Original change's description:
> Add stub gpu workaround generators
> 
> Like https://chromium-review.googlesource.com/c/chromium/src/+/1005362,
> this patch adds a way for Chrome and Skia to share a set of driver
> workaround names so that they can be turned on by Chrome (or Skia) as
> needed.
> 
> To avoid weird cross-repository dependencies, the generator script is
> duplicated in Skia.
> 
> This patch just adds a few dummy workaround names to make sure the build
> process is working.  The followup to this is to add workaround init
> to GrContext/GrContextOptions and to start implementing individual
> workarounds.
> 
> Implementing these workarounds is to support Chrome's "out of process
> raster" which will use Ganesh without a command buffer, and so will not
> have the workarounds that the command buffer provides.
> 
> Bug: chromium:829614
> Change-Id: I40745a777a95805995991fedb81657ae418b52d9
> Reviewed-on: https://skia-review.googlesource.com/120608
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Adrienne Walker <enne@chromium.org>

Bug: chromium:829614
Change-Id: Idb3309ffa894f7585ee493388b56565e9d4a3101
Reviewed-on: https://skia-review.googlesource.com/122800
Auto-Submit: Adrienne Walker <enne@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-04-20 17:50:45 +00:00
Robert Phillips
2748391716 Add ability to dump opList info at flush-time
When debugging DDL it is useful to just see which ops are being drawn instead of the entire reordering history.

Change-Id: I89708fecbd53c097b00e65b0da426bfb8046b0ee
Reviewed-on: https://skia-review.googlesource.com/122780
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-20 17:47:55 +00:00
Ben Wagner
d7c97861c7 Fix Housekeeper-PerCommit-InfraTests
Failure was the result of a conflict between these two CLs:
https://skia-review.googlesource.com/122640
https://skia-review.googlesource.com/121425

Bug: skia:7671
No-Try: true
Change-Id: I143e8dc4e27b6f0720b0f9d72839a6f53bdd6c4a
Reviewed-on: https://skia-review.googlesource.com/122792
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-04-20 17:31:05 +00:00
Leon Scroggins III
37819d03fe Reduce threads used for DNG decodes on Android
Bug: b/78120086

DNG files require lots of memory to decode. We recently removed the
limit on how much SkRawCodec can allocate, allowing it to decode large
warped DNG files, so long as the device has enough memory. But in
practice, running too many threads at once with each thread allocating
a lot of memory results in crashing on Android. Reduce the number of
threads so we save memory and do not crash.

Change-Id: I464b5a21c019463d2ec31e333f25ebb0b81605bd
Reviewed-on: https://skia-review.googlesource.com/122786
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-04-20 16:55:15 +00:00
Ben Wagner
bbdee1befa Add SwiftShader Build jobs.
Bug: skia:7671
No-Try: true
Change-Id: I34015cceca538c84d87a77b6688fa1490c620d04
Reviewed-on: https://skia-review.googlesource.com/121425
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-04-20 16:45:25 +00:00
Ben Wagner
919c6a14ca Add cmake_linux asset.
Bug: skia:7671
No-Try: true
Change-Id: I4a2c5abb8480dfb7ca75a4d523f8b337a3eb9fba
Reviewed-on: https://skia-review.googlesource.com/122520
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-04-20 16:43:05 +00:00
Greg Daniel
dbdba60274 Add discard check when deciding if we should execute op list or not.
Bug: skia:7828
Change-Id: I339ba64b6312cd9444cd4faffd426d91852774e9
Reviewed-on: https://skia-review.googlesource.com/122784
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-04-20 16:30:15 +00:00
Robert Phillips
cb7b83113b Remove another writePixels instance
This converts the GrSWMaskHelper to being DDL compatible

Change-Id: Ic0c7f95a7ed6d2936118b4127c2cfce94a2ec0da
Reviewed-on: https://skia-review.googlesource.com/122788
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-20 16:25:35 +00:00
Chris Dalton
5450ab10b1 ccpr: Don't solve for cubic roots that are out of range
Most real-world cubics don't have both KLM roots inside T=0..1, and a
large amount don't have any. This CL gives a nice speedup by not
wasting time finding padding around KLM roots that we aren't going to
chop at anyway.

Bug: skia:
Change-Id: Icb7217142e29fc3f8e8ff657e9dc739caf6d6714
Reviewed-on: https://skia-review.googlesource.com/122129
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-04-20 16:20:45 +00:00
Ben Wagner
ce6e68af5c Add SwiftShader to DEPS.
Bug: skia:7671
No-Try: true
Change-Id: Ib41428b5c3ed8d6655fac38e525014663ce85817
Reviewed-on: https://skia-review.googlesource.com/121357
Commit-Queue: Hal Canary <halcanary@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2018-04-20 16:09:55 +00:00
Chris Dalton
d8bae7d501 ccpr: Fix flatness and triangle-ness detection for conics
We should detect these cases by examining the curve at max height; not
midtangent.

Bug: skia:7821
Change-Id: I3d9e3a10798f0d825916840cb99d054b2a6284c3
Reviewed-on: https://skia-review.googlesource.com/122620
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-04-20 16:06:25 +00:00
Robert Phillips
3d0e8507fa Prevent matrix stack from being corrupted if a rotated image filter is clipped out
Bug: skia:7765
Change-Id: Id76b63cebc25dcdff02d4ba3f6d6bba6f2b6b842
Reviewed-on: https://skia-review.googlesource.com/122782
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-04-20 15:13:55 +00:00
Cary Clark
1eece78318 guard against NaN in path is rect
Recent rewrite of SkPath::isRect() did not check against
sequences with NaN and infinity.

R=kjlubick@google.com

Bug: oss-fuzz:7882
Change-Id: I9315f68e4c53c37fda819adc6d57d6b3e3acc1c6
Reviewed-on: https://skia-review.googlesource.com/122783
Commit-Queue: Cary Clark <caryclark@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Cary Clark <caryclark@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-04-20 14:52:05 +00:00
Florin Malita
8f88d89796 Fix use-of-uninitialized-value in SkPictureShader::onMakeContext
SkPictureShader::refBitmapShader is expected to always initialize the
scale adjust vector when returning a non-null shader.  But the code path
returning EmptyShader does not do that.

Instead of hauling around a separate scale adjustment, we can refactor
to avoid this problem by adjusting the local matrix directly, if needed,
in refBitmapShader.  The local matrix is conveniently already stored in
a SkTCopyOnFirstWrite.

Bug: chromium:835048, oss-fuzz:7738
Change-Id: I2df3bde7d6237f01bc71857c2fe254e86b186dc0
Reviewed-on: https://skia-review.googlesource.com/122544
Auto-Submit: Florin Malita <fmalita@chromium.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-04-20 14:14:45 +00:00
Ben Wagner
adeb75d67c Disable retries for Build, CT, and Calmbench tasks.
Bug: skia:7621
Change-Id: I1f08ed816d6349abb5a2275f1cf103dc30af70ca
Reviewed-on: https://skia-review.googlesource.com/122640
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-20 14:13:05 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
0d24c50211 Roll third_party/externals/angle2/ b0f917fa6..3ec304dba (1 commit)
b0f917fa63..3ec304dba2

$ git log b0f917fa6..3ec304dba --date=short --no-merges --format='%ad %ae %s'
2018-04-18 lucferron Vulkan: Support struct initializers in shaders

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: I108f45eb711feb024519b9129bd6bd8327bd21b6
Reviewed-on: https://skia-review.googlesource.com/122760
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-20 12:18:35 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
665c4b78eb Roll third_party/externals/angle2/ e24032a2c..b0f917fa6 (3 commits)
e24032a2c4..b0f917fa63

$ git log e24032a2c..b0f917fa6 --date=short --no-merges --format='%ad %ae %s'
2017-12-05 geofflang Fix being unable to request some extensions implemented in the GL layer.
2017-10-30 geofflang Make EGL image extensions enableable.
2017-11-07 geofflang Make EXT_texture_storage enableable.

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=scroggo@google.com

Change-Id: I7ff8a0154a4ef00feded7692bde0e98d8a8c98bb
Reviewed-on: https://skia-review.googlesource.com/122720
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-04-20 02:41:14 +00:00
Chris Dalton
1804b3528c ccpr: Don't preempt the convex path renderer
It seems to perform better on RRects from web pages.

Bug: skia:7825
Change-Id: Ibecf33849c6d14e7486d9de740b1cc42f274080f
Reviewed-on: https://skia-review.googlesource.com/122626
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-04-19 21:34:54 +00:00
Ben Wagner
7464a262a2 Add more angle_gl_* configs for NVIDIA.
Bug: skia:7823
Change-Id: I9fbf0875696661ca87b37cf8949bd5f0b48b314d
Reviewed-on: https://skia-review.googlesource.com/122600
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-04-19 21:32:34 +00:00
Jim Van Verth
d75b34394b Remove ambient clamp hack for analytic shadows.
The hack was added to make analytic ambient shadows match the geometric
ones exactly. Removing it does produce a slight difference, but it's
only visible at full black values (and then, only slightly) and this
makes room to pass a blend parameter for falloff.

Also fixes an issue with filling out arcs in the shadow tesselator.

Bug: skia:7486
Change-Id: If78d0104df7e18f4320c1658af75576f6a4a8c73
Reviewed-on: https://skia-review.googlesource.com/122580
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-04-19 21:21:44 +00:00
Brian Osman
fb9f39a98a Remove duplicate predefined configs
Change-Id: I065bb1c20a6a246a2864b394f025fc12614c6a18
Reviewed-on: https://skia-review.googlesource.com/122543
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-04-19 20:47:04 +00:00
Chris Dalton
b3a6959408 ccpr: Clean up GrCCGeometry
Gets rid of the ugly template functions, rearranges a few static
methods, and adds a benchmark.

Bug: skia:
Change-Id: I442f3a581ba7faf7601ae5be0c7e07327df09496
Reviewed-on: https://skia-review.googlesource.com/122128
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-04-19 20:15:24 +00:00
Herb Derby
e68c4fbf60 Adding pinning to the strike cache
Here is a simple API for the object that pins, and
how it flows through the cache.

BUG=skia:7515

Change-Id: I1b8304dc6f9d8652282300fc1e52d52debb5b6f4
Reviewed-on: https://skia-review.googlesource.com/122500
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>
2018-04-19 20:00:04 +00:00
Brian Salomon
33c442206a Fix double counting of coverage in analytic round capped stroked circles.
Change-Id: I28d39f8620d786180b0bf0204b18ca4d1fec597b
Reviewed-on: https://skia-review.googlesource.com/122086
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-04-19 19:48:14 +00:00
Ben Wagner
86fe5adf5c Document minimum OS requirements.
In theory most of Skia can run on bare hardware, but in practice there are
some minimum OS versions which are tested. This initial list is based on
the minimum versions required by as many current users of Skia as could
be found.

Change-Id: I5a3e8b00203de7c31595fe7e66e25cc83f881c25
Reviewed-on: https://skia-review.googlesource.com/120541
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-04-19 19:38:44 +00:00