Commit Graph

13786 Commits

Author SHA1 Message Date
robertphillips
d982eb22d7 Replace SkPictureReplacementPlayback with GrRecordReplaceDraw
I think this is sufficiently specialized to keep it in Ganesh for the time being.

R=bsalomon@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/535953002
2014-09-03 11:04:31 -07:00
djsollen
74364c9774 Disable -fexpensive-optimizations on 64-bit ARM.
BUG=skia:2908
R=mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/535113004
2014-09-03 10:44:00 -07:00
mtklein
c09b2c49a3 Revert of Enable highQualityFilter_SSE2 (patchset #1 id:1 of https://codereview.chromium.org/525283002/)
Reason for revert:
Color order looks wrong on Macs:

Before: http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/filterbitmap_image_mandrill_16.png/12823183142873462143.png

After: http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/filterbitmap_image_mandrill_16.png/13683040204546320578.png

Original issue's description:
> Enable highQualityFilter_SSE2
>
> With SSE2, bitmap_BGRA_8888_A_scale_rotate_bicubic gains about 40%
> performance improvement on desktop i7-3770.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/b381fa10d8079c58928058bb8a6db32b39f05e51

R=humper@google.com, qiankun.miao@intel.com
TBR=humper@google.com, qiankun.miao@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/539523002
2014-09-03 08:57:02 -07:00
jvanverth
3f5417590a Update fontcache GM to stress the font atlas.
Pulled out of https://codereview.chromium.org/466363009/.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/534253003
2014-09-03 08:44:59 -07:00
qiankun.miao
b381fa10d8 Enable highQualityFilter_SSE2
With SSE2, bitmap_BGRA_8888_A_scale_rotate_bicubic gains about 40%
performance improvement on desktop i7-3770.

BUG=skia:
R=mtklein@google.com, humper@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/525283002
2014-09-03 08:24:12 -07:00
bsalomon
b0bd4f64a6 Remove GrDrawTarget::AutoRenderTargetRestore.
Pass GrRenderTarget in GrGpuG clear\bind methods.

BUG=skia:2889
R=egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/533883004
2014-09-03 07:19:50 -07:00
mtklein
eddb113ec6 Disable SSE4 S32A_Opaque blit.
This code sometimes generates a build warning that bothers Chrome.

BUG=399842,skia:2906
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/538463003
2014-09-03 07:02:07 -07:00
reed
1cf15b4735 remove flags that are already mirrored in chrome's SkUserConfig.h
NOTRY=True
TBR=fmalita@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/537563002
2014-09-03 06:31:06 -07:00
qiankun.miao
a695514ced Remove dead code in SkBitmapFilter_opts_SSE2.h/cpp
BUG=skia:
R=mtklein@google.com, humper@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/530673002
2014-09-03 06:27:54 -07:00
Derek Sollenberger
2e9176c348 Update failing testimagefilter GM with new baseline and bug number
Review URL: https://codereview.chromium.org/535843003
2014-09-03 09:10:20 -04:00
Derek Sollenberger
afbfc2212e Rebase NEON image procs based on C++ implementation.
BUG=skia:2845

Review URL: https://codereview.chromium.org/532193003
2014-09-03 09:01:29 -04:00
reed
2bdf1f56c3 Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/527073003/)
Reason for revert:
virtual gpu failures in layouttests

http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/23717

[6:6:0903/041147:1700960503:INFO:SkBitmap.cpp(1003)] ../../third_party/skia/src/core/SkBitmap.cpp:1003: failed assertion "fPixelRef->info() == pixelRef->info()"

[6:6:0903/041147:1700961002:FATAL:SkBitmap.cpp(1003)] SK_CRASH
#0 0x7f9867df2c1e base::debug::StackTrace::StackTrace()
#1 0x7f9867e89e05 logging::LogMessage::~LogMessage()
#2 0x7f98689c4970 SkDebugf_FileLine()
#3 0x7f986870ebc6 SkBitmap::deepCopyTo()
#4 0x7f98690a3b6d blink::deepSkBitmapCopy()
#5 0x7f98690a3abe blink::ImageBuffer::copyImage()
#6 0x7f985fd4479e blink::ImageBitmap::ImageBitmap()
#7 0x7f985fd45942 blink::ImageBitmap::create()
#8 0x7f985fd84fdc blink::ImageBitmapFactories::createImageBitmap()
#9 0x7f985fd84d11 blink::ImageBitmapFactories::createImageBitmap()
#10 0x7f985ec9a7f2 blink::LocalDOMWindowV8Internal::createImageBitmap13Method()
#11 0x7f985ec96b0c blink::LocalDOMWindowV8Internal::createImageBitmapMethod()
#12 0x7f985ec91954 blink::LocalDOMWindowV8Internal::createImageBitmapMethodCallback()
#13 0x7f9869955af0 v8::internal::FunctionCallbackArguments::Call()
#14 0x7f98699833bd v8::internal::Builtin_HandleApiCall()

Original issue's description:
> Add gamma/sRGB tag to SkImageInfo
>
> This reverts commit 1cbc68f965.
>
> requires this to land in blink https://codereview.chromium.org/531883002/
>
> Committed: https://skia.googlesource.com/skia/+/2f6abdecc5c2f21da13003c615903679abc73fc7

R=fmalita@google.com, reed@chromium.org
TBR=fmalita@google.com, reed@chromium.org
NOTREECHECKS=true
NOTRY=true

Author: reed@google.com

Review URL: https://codereview.chromium.org/535113002
2014-09-03 05:48:56 -07:00
Derek Sollenberger
c56653cdd2 Update GM baselines for Arm64 bot.
Review URL: https://codereview.chromium.org/530423003
2014-09-03 08:31:02 -04:00
reed
2f6abdecc5 Add gamma/sRGB tag to SkImageInfo
This reverts commit 1cbc68f965.

requires this to land in blink https://codereview.chromium.org/531883002/

R=fmalita@google.com, reed@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/527073003
2014-09-02 21:56:40 -07:00
mtklein
937c9c7eb4 Fix drawPosText() bounds bug.
We didn't catch this in our local tests because we tend to use default
kUTF8_TextEncoding with single-byte characters, which means N == byteLength.

BUG=409110
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/531933002
2014-09-02 15:19:48 -07:00
reed
294739b848 add legacy guard for SK_SUPPORT_LEGACY_ALLOCPIXELS_BOOL to android
NOTRY=True

BUG=skia:
R=djsollen@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/530163002
2014-09-02 13:50:39 -07:00
pkasting
280c2c6fbb Address MSVC warnings about possible value truncation. In the process removes some apparently unused code.
BUG=81439
TEST=none
R=reed@google.com

Author: pkasting@chromium.org

Review URL: https://codereview.chromium.org/517763002
2014-09-02 13:40:48 -07:00
djsollen
5ee785d9c7 Remove legacy (and also broken) SkPicture constructor.
R=robertphillips@google.com, reed@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/532703004
2014-09-02 13:34:49 -07:00
jvanverth
17a845f760 Fix matrix similarity test on arm64
Addresses precision issue by using a simpler test.
Also fixes issues with IvMatrix::preservesRightAngles, and adds unit tests.

BUG=skia:2405
R=robertphillips@google.com, egdaniel@google.com, djsollen@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/520123002
2014-09-02 13:15:41 -07:00
egdaniel
7f91c3359f Rebaseline bezier cubics
TBR=bsalomon@google.com
NOTRY=True

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/528033002
2014-09-02 12:53:12 -07:00
reed
848250415e make allocPixels throw on failure
BUG=skia:
R=mtklein@google.com, fmalita@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/510423005
2014-09-02 12:50:45 -07:00
mtklein
00f30bdc9e SkRecordPartialDraw with less code duplication
BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/527423002
2014-09-02 12:03:31 -07:00
piotaixr
aca21d6d2f Rename ScaledImageCache.cpp to SkResourceCacheTest.cpp
BUG=skia:
R=junov@chromium.org, reed@android.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/518213003
2014-09-02 11:51:00 -07:00
piotaixr
8159146699 Added Doc for GetAllocator in SkResourceCache and SkBitmapCache
BUG=skia:2896
R=junov@chromium.org, reed@google.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/533713003
2014-09-02 11:27:11 -07:00
robertphillips
98d709bc8d Reorganize Layer Hoisting code
With the new MultiPictureDraw API the GrContext will be performing the layer hoisting (instead of the SkGpuDevice). This CL being moving the layer hoisting functionality to GrLayerHoister rather then dumping it straight into GrContext.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/531733003
2014-09-02 10:20:50 -07:00
egdaniel
842b086a3c When ignoring color input don't use vertex attribs on gpu
Also rename SolidWhite_ColorInput enum to be AllOnes_ColorInput to better reflect what it's use is

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/525433002
2014-09-02 10:01:30 -07:00
djsollen
871dca8ea9 Disable NEON procs for box blur as it produces invalid results
R=reed@google.com, mtklein@google.com, senorblanco@google.com
TBR=reed@google.com
BUG=skia:2845

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/527973002
2014-09-02 08:57:39 -07:00
egdaniel
6db9128efb Add option to add precision to varyings in shader
Also use highp varying on bezier cubics to fix numerical issues for n10 and n4.

BUG=skia:2860
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/522303004
2014-09-02 08:02:38 -07:00
bsalomon
ed82c4e822 Use non-VBO vertex arrays on QC GPUs.
BUG=skia:2901
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/529993003
2014-09-02 07:54:47 -07:00
djsollen
4d6484e764 Revert of Disable NEON procs for box blur as it produces invalid results (patchset #1 id:1 of https://codereview.chromium.org/520963002/)
Reason for revert:
failing more GMs than expected.

Original issue's description:
> Disable NEON procs for box blur as it produces invalid results
>
> BUG=skia:2845
>
> Committed: https://skia.googlesource.com/skia/+/4a1764688c990fb926aaeab538497dad52768d99

R=senorblanco@google.com, mtklein@google.com
TBR=mtklein@google.com, senorblanco@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2845

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/531023002
2014-09-02 06:32:26 -07:00
djsollen
4a1764688c Disable NEON procs for box blur as it produces invalid results
BUG=skia:2845
R=senorblanco@google.com, mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/520963002
2014-09-02 05:32:23 -07:00
Mike Klein
d565a9c71b whitespace change
BUG=skia:

Review URL: https://codereview.chromium.org/529973002
2014-09-02 08:04:43 -04:00
reed
1cbc68f965 Revert of Revert of Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/532583002/)
Reason for revert:
linux_blink_rel

[ RUN      ] DeferredImageDecoderTest.drawIntoSkPicture
../../third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:172: Failure
Value of: canvasBitmap.getColor(0, 0)
Actual: 0
Expected: static_cast<SkColor>( (static_cast<U8CPU>(255) << 24) | (static_cast<U8CPU>(255) << 16) | (static_cast<U8CPU>(255) << 8) | (static_cast<U8CPU>(255) << 0))
Which is: 4294967295
[  FAILED  ] DeferredImageDecoderTest.drawIntoSkPicture (0 ms)
[1457/1458] DeferredImageDecoderTest.drawIntoSkPicture (0 ms)
[ RUN      ] DeferredImageDecoderTest.decodeOnOtherThread
../../third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:233: Failure
Value of: canvasBitmap.getColor(0, 0)
Actual: 0
Expected: static_cast<SkColor>( (static_cast<U8CPU>(255) << 24) | (static_cast<U8CPU>(255) << 16) | (static_cast<U8CPU>(255) << 8) | (static_cast<U8CPU>(255) << 0))
Which is: 4294967295
[  FAILED  ] DeferredImageDecoderTest.decodeOnOtherThread (1 ms)
[1458/1458] DeferredImageDecoderTest.decodeOnOtherThread (1 ms)
Retrying 2 tests (retry #2)

Original issue's description:
> Revert of Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/525113005/)
>
> Reason for revert:
> Experiment to see resulting failures
>
> Original issue's description:
> > Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/522813002/)
> >
> > Reason for revert:
> > seems to be breaking layout tests in roll
> >
> > Original issue's description:
> > > Add gamma/sRGB tag to SkImageInfo
> > >
> > > This reverts commit 64ba5fa1ff.
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/c89aa509d6a094bc1b18d73135343819903a9cfb
> >
> > TBR=reed@google.com
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/b44c1895afae516cb851cd1a0cea83343c354ee4
>
> TBR=reed@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4581828014eb3d015e6ed55c9a5b6932b8751818

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/524593005
2014-09-02 04:14:37 -07:00
reed
4581828014 Revert of Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/525113005/)
Reason for revert:
Experiment to see resulting failures

Original issue's description:
> Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/522813002/)
>
> Reason for revert:
> seems to be breaking layout tests in roll
>
> Original issue's description:
> > Add gamma/sRGB tag to SkImageInfo
> >
> > This reverts commit 64ba5fa1ff.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/c89aa509d6a094bc1b18d73135343819903a9cfb
>
> TBR=reed@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/b44c1895afae516cb851cd1a0cea83343c354ee4

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/532583002
2014-09-01 18:36:24 -07:00
reed
b44c1895af Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/522813002/)
Reason for revert:
seems to be breaking layout tests in roll

Original issue's description:
> Add gamma/sRGB tag to SkImageInfo
>
> This reverts commit 64ba5fa1ff.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c89aa509d6a094bc1b18d73135343819903a9cfb

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/525113005
2014-09-01 14:28:32 -07:00
reed
c89aa509d6 Add gamma/sRGB tag to SkImageInfo
This reverts commit 64ba5fa1ff.

BUG=skia:
R=reed@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/522813002
2014-09-01 12:14:29 -07:00
borenet
eb2662c08f Update SKP version to 90
Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/528673002
2014-08-31 20:37:00 -07:00
Mike Klein
700a78d72f Force a build.
BUG=skia:

Review URL: https://codereview.chromium.org/530553002
2014-08-31 11:51:21 -04:00
borenet
21e6135055 Update SKP version to 89
Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/529543002
2014-08-30 20:50:55 -07:00
mtklein
9e19ce1641 Revert of Revert of Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/524133002/)
Reason for revert:
another build

Original issue's description:
> Revert of Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519413002/)
>
> Reason for revert:
> dun dun dun dun dah dah-dah-dah DAH dah dah-dah-dah DAH dah dah-dah-dah-dah
>
> Original issue's description:
> > Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/523413002/)
> >
> > Reason for revert:
> > ws
> >
> > Original issue's description:
> > > Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/)
> > >
> > > Reason for revert:
> > > ws
> > >
> > > Original issue's description:
> > > > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
> > > >
> > > > Reason for revert:
> > > > spring break forever
> > > >
> > > > Original issue's description:
> > > > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
> > > > >
> > > > > Reason for revert:
> > > > > nah
> > > > >
> > > > > Original issue's description:
> > > > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> > > > > >
> > > > > > Reason for revert:
> > > > > > i like the old file better
> > > > > >
> > > > > > Original issue's description:
> > > > > > > moar ws
> > > > > > >
> > > > > > > BUG=skia:
> > > > > > >
> > > > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> > > > > >
> > > > > > TBR=mtklein@chromium.org
> > > > > > NOTREECHECKS=true
> > > > > > NOTRY=true
> > > > > > BUG=skia:
> > > > > >
> > > > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
> > > > >
> > > > > TBR=mtklein@chromium.org
> > > > > NOTREECHECKS=true
> > > > > NOTRY=true
> > > > > BUG=skia:
> > > > >
> > > > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
> > > >
> > > > TBR=mtklein@chromium.org
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=skia:
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde
> > >
> > > TBR=mtklein@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/c7bee661a1e2b2f3b367bdd2b4176d1921aa69d4
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/968212f837f1fbac011f4feb1e33ff27f5acc863
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7843a24ab2c2dc4fe77e82b9689cde953d6abd7c

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/525153003
2014-08-30 14:33:06 -07:00
mtklein
7843a24ab2 Revert of Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519413002/)
Reason for revert:
dun dun dun dun dah dah-dah-dah DAH dah dah-dah-dah DAH dah dah-dah-dah-dah

Original issue's description:
> Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/523413002/)
>
> Reason for revert:
> ws
>
> Original issue's description:
> > Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/)
> >
> > Reason for revert:
> > ws
> >
> > Original issue's description:
> > > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
> > >
> > > Reason for revert:
> > > spring break forever
> > >
> > > Original issue's description:
> > > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
> > > >
> > > > Reason for revert:
> > > > nah
> > > >
> > > > Original issue's description:
> > > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> > > > >
> > > > > Reason for revert:
> > > > > i like the old file better
> > > > >
> > > > > Original issue's description:
> > > > > > moar ws
> > > > > >
> > > > > > BUG=skia:
> > > > > >
> > > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> > > > >
> > > > > TBR=mtklein@chromium.org
> > > > > NOTREECHECKS=true
> > > > > NOTRY=true
> > > > > BUG=skia:
> > > > >
> > > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
> > > >
> > > > TBR=mtklein@chromium.org
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=skia:
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
> > >
> > > TBR=mtklein@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/c7bee661a1e2b2f3b367bdd2b4176d1921aa69d4
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/968212f837f1fbac011f4feb1e33ff27f5acc863

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/524133002
2014-08-30 08:47:49 -07:00
mtklein
968212f837 Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/523413002/)
Reason for revert:
ws

Original issue's description:
> Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/)
>
> Reason for revert:
> ws
>
> Original issue's description:
> > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
> >
> > Reason for revert:
> > spring break forever
> >
> > Original issue's description:
> > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
> > >
> > > Reason for revert:
> > > nah
> > >
> > > Original issue's description:
> > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> > > >
> > > > Reason for revert:
> > > > i like the old file better
> > > >
> > > > Original issue's description:
> > > > > moar ws
> > > > >
> > > > > BUG=skia:
> > > > >
> > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> > > >
> > > > TBR=mtklein@chromium.org
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=skia:
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
> > >
> > > TBR=mtklein@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c7bee661a1e2b2f3b367bdd2b4176d1921aa69d4

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/519413002
2014-08-30 08:06:37 -07:00
mtklein
c7bee661a1 Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/)
Reason for revert:
ws

Original issue's description:
> Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
>
> Reason for revert:
> spring break forever
>
> Original issue's description:
> > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
> >
> > Reason for revert:
> > nah
> >
> > Original issue's description:
> > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> > >
> > > Reason for revert:
> > > i like the old file better
> > >
> > > Original issue's description:
> > > > moar ws
> > > >
> > > > BUG=skia:
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> > >
> > > TBR=mtklein@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/523413002
2014-08-30 07:54:38 -07:00
Mike Klein
6d134201a9 Rebaseline one N4 GM we must have missed.
BUG=skia:

Review URL: https://codereview.chromium.org/524103002
2014-08-30 10:33:22 -04:00
borenet
5c49b70ae3 Update SKP version to 88
Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/520323002
2014-08-29 21:18:01 -07:00
mtklein
2fe2ce41e3 Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/)
Reason for revert:
spring break forever

Original issue's description:
> Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
>
> Reason for revert:
> nah
>
> Original issue's description:
> > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
> >
> > Reason for revert:
> > i like the old file better
> >
> > Original issue's description:
> > > moar ws
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/7a353e9
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/519303002
2014-08-29 18:40:23 -07:00
mtklein
5355536c79 Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/)
Reason for revert:
nah

Original issue's description:
> Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
>
> Reason for revert:
> i like the old file better
>
> Original issue's description:
> > moar ws
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/7a353e9
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/520023003
2014-08-29 18:33:24 -07:00
mtklein
4ee3e529e2 Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/)
Reason for revert:
i like the old file better

Original issue's description:
> moar ws
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7a353e9

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/518333002
2014-08-29 16:03:35 -07:00
Mike Klein
7a353e9454 moar ws
BUG=skia:

Review URL: https://codereview.chromium.org/518233004
2014-08-29 18:52:18 -04:00
Mike Klein
15093a9a99 another ws
BUG=skia:

Review URL: https://codereview.chromium.org/519583008
2014-08-29 18:15:59 -04:00