mtklein
cbf897802b
DM: remove unnecessary use of std::function
...
This draw_to_canvas() function doesn't need the power of std::function.
This skips a copy or two, which is nice, and seems to clear
up most of my MSAN problems. Why? I do not know.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718633002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
Review URL: https://codereview.chromium.org/1718633002
2016-02-19 14:27:14 -08:00
mtklein
09d06850fa
add back some basic configs to MSAN bot
...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1706373004
Review URL: https://codereview.chromium.org/1706373004
2016-02-19 09:08:50 -08:00
ethannicholas
85fca851e6
added /enableGPU command to skiaserve
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715503004
Review URL: https://codereview.chromium.org/1715503004
2016-02-19 08:40:59 -08:00
ethannicholas
c85d9fbc0a
GrAuditTrail can now be enabled/disabled at runtime
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1712753002
TBR=bsalomon@google.com
Doesn't actually change the public API
Review URL: https://codereview.chromium.org/1712753002
2016-02-18 13:45:40 -08:00
mtklein
517558ad19
MSAN: cut down to green
...
I have no idea what's going on with the current bot failures.
This disables lots of things to get it green.
Probably more than necessary.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707873002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
Review URL: https://codereview.chromium.org/1707873002
2016-02-18 11:42:00 -08:00
ethannicholas
3afae70a48
fixed SkDrawCommand JSON generation
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715443002
Review URL: https://codereview.chromium.org/1715443002
2016-02-18 10:50:50 -08:00
ethannicholas
3ca1e1ae4f
added server-side breakpoint support to skiaserve
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707863003
Review URL: https://codereview.chromium.org/1707863003
2016-02-18 10:22:34 -08:00
bsalomon
1526e0a5f5
Make build_command_buffer.py work on Windows
...
BUG=skia:4957
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710983002
Review URL: https://codereview.chromium.org/1710983002
2016-02-18 10:01:11 -08:00
bungeman
a7e9f05119
Move SkTDArray to private.
...
TBR=reed
Moving to private is good.
Review URL: https://codereview.chromium.org/1707213002
2016-02-18 08:53:33 -08:00
bsalomon
c969bfced3
Make build_command_buffer.py work on Mac and Windows.
...
Also specify GYP_GENERATORS and add flags to gclient sync to make it more likely to succeed.
BUG=skia:4957
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704193002
Review URL: https://codereview.chromium.org/1704193002
2016-02-18 06:40:55 -08:00
bungeman
bf521ff941
Move SkTArray to include/private.
...
TBR=reed
Agreed moving to private is good.
Review URL: https://codereview.chromium.org/1702073002
2016-02-17 13:13:44 -08:00
ethannicholas
cecbbe2fa9
converted skiaserve PNGs from RGBA to RGB
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703893003
Review URL: https://codereview.chromium.org/1703893003
2016-02-17 11:49:43 -08:00
joshualitt
6b3cf73af5
Add batch information to json
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705093002
Review URL: https://codereview.chromium.org/1705093002
2016-02-17 11:20:26 -08:00
bsalomon
c43f2af60e
Add a script to build and copy the command buffer shared library. This script will be used by the bots to test skia on the command buffer.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699273002
NOTREECHECKS=true
NOTRY=true
BUG=skia:4957
Review URL: https://codereview.chromium.org/1699273002
2016-02-17 10:42:46 -08:00
ethannicholas
272af6ecd7
Revert of further skiaserve image performance improvements (patchset #1 id:1 of https://codereview.chromium.org/1707453003/ )
...
Reason for revert:
Broke skiaserve GPU rendering
Original issue's description:
> further skiaserve image performance improvements
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707453003
>
> Committed: https://skia.googlesource.com/skia/+/68c063bf11c91b2b3b15cb93168cf2af9b2c642d
TBR=joshualitt@google.com ,jcgregorio@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1708683002
2016-02-17 10:30:27 -08:00
msarett
8715d47e24
Make SkPicture/SkImageGenerator default to SkCodec
...
Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.
Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.
Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.
Update all clients to use the default.
Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.
This is a rebased version of:
https://codereview.chromium.org/1671193002/
TBR=reed@google.com
BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699183004
Review URL: https://codereview.chromium.org/1699183004
2016-02-17 10:02:29 -08:00
ethannicholas
68c063bf11
further skiaserve image performance improvements
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707453003
Review URL: https://codereview.chromium.org/1707453003
2016-02-17 09:17:35 -08:00
mtklein
0da8537555
MSAN: build libc++ with MSAN, link to it.
...
The errors that we see should now change to the unexplainable,
rather than the explainable errors at head.
We suspect that the original reason to blacklist was this,
not building libc++ with MSAN. So unblacklist everything to start fresh.
BUG=skia:4903,skia:4900
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1694353004
Review URL: https://codereview.chromium.org/1694353004
2016-02-16 14:03:15 -08:00
ethannicholas
546d66544b
tuned skiaserve's png output for better performance
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704573002
Review URL: https://codereview.chromium.org/1704573002
2016-02-16 11:03:04 -08:00
jcgregorio
3341d428d3
skiaserve: Change alpha setting from GET to POST.
...
GET shouldn't be used for things that change the state of the server.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1706443002
Review URL: https://codereview.chromium.org/1706443002
2016-02-16 10:31:07 -08:00
mtklein
6f65957335
Setup for -Fast GCE bot.
...
I'd like a bot that has got optimization turned up to 11,
to let us test things that our Chrome-like bots normally can't.
(Not quite ready to commit this bot to -ffast-math yet.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704473002
Review URL: https://codereview.chromium.org/1704473002
2016-02-16 06:42:51 -08:00
msarett
3478f753ff
Adding a tool to get images from skps
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696763002
Review URL: https://codereview.chromium.org/1696763002
2016-02-12 14:47:09 -08:00
msarett
70e418b468
Make SkJpegCodec compatible with libjpeg
...
BUG=skia:4470
BUG=skia:4520
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1687863003
Review URL: https://codereview.chromium.org/1687863003
2016-02-12 12:35:49 -08:00
mtklein
013475a272
Put all XSAN bots on the same DEPS-sourced build of Clang.
...
This adds LLVM, Clang, and compiler-rt (*san tools) to DEPS,
then uses them from xsan_build, building them if needed.
This is similar to how the CMake bots bootstrap CMake if needed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693733003
Review URL: https://codereview.chromium.org/1693733003
2016-02-12 12:15:23 -08:00
ethannicholas
0a0520afcc
added clip visualization to skiaserve
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690023004
Review URL: https://codereview.chromium.org/1690023004
2016-02-12 12:06:53 -08:00
ethannicholas
de8e54ccfd
skiaserve now retains the graphics context rather than creating a new one each request
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693893002
Review URL: https://codereview.chromium.org/1693893002
2016-02-12 10:09:34 -08:00
ethannicholas
891ad66d14
fixed SkDebugCanvas' handling of drawPicture
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1685133008
Review URL: https://codereview.chromium.org/1685133008
2016-02-12 07:15:45 -08:00
ethannicholas
f8289d9bd1
fixed off-by-one error in skiaserve /cmd
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692683002
Review URL: https://codereview.chromium.org/1692683002
2016-02-11 13:10:37 -08:00
joshualitt
e1745a1efc
enable ThermalManager on Android
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684653002
Review URL: https://codereview.chromium.org/1684653002
2016-02-11 11:42:19 -08:00
ethannicholas
f62a8b786c
integrated SkDebugCanvas JSON support with UrlDataManager
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686143004
Review URL: https://codereview.chromium.org/1686143004
2016-02-11 10:35:21 -08:00
joshualitt
db6a254bdc
wire up new json code in skiaserve
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691773002
Review URL: https://codereview.chromium.org/1691773002
2016-02-11 07:09:51 -08:00
joshualitt
860fc696d7
fix for gpu valgrind bot
...
TBR=egdaniel@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1689823004
Review URL: https://codereview.chromium.org/1689823004
2016-02-11 06:53:36 -08:00
jcgregorio
12d47ce49e
skiaserve: Fix /cmd/N and /cmd/N[0|1], the response was never queued.
...
BUG=skia:
R=joshualitt@google.com , ethannicholas@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686553006
Review URL: https://codereview.chromium.org/1686553006
2016-02-10 14:10:37 -08:00
ethannicholas
1446a9a67a
added JSON support for various lesser-used features
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690613002
Review URL: https://codereview.chromium.org/1690613002
2016-02-10 14:05:02 -08:00
ethannicholas
402cd91f60
added SkDebugCanvas::toJSON
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684233002
Review URL: https://codereview.chromium.org/1684233002
2016-02-10 12:57:30 -08:00
ethannicholas
bd3dae8a97
added some missing static modifiers
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690683002
Review URL: https://codereview.chromium.org/1690683002
2016-02-10 12:10:01 -08:00
kjlubick
1de415f2c3
Revert of Make SkPicture/SkImageGenerator default to SkCodec (patchset #7 id:120001 of https://codereview.chromium.org/1671193002/ )
...
Reason for revert:
Breaks Ubuntu and Mac CMAKE
Original issue's description:
> Make SkPicture/SkImageGenerator default to SkCodec
>
> Remove reference to SkImageDecoder from SkPicture. Make the default
> InstallPixelRefProc passed to CreateFromStream use
> SkImageGenerator::NewFromEncoded instead.
>
> Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
> Remove the old version that used SkImageDecoder.
>
> Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
> now behaves lazily.
>
> Update all clients to use the default.
>
> Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.
>
> BUG=skia:4691
> BUG=skia:4290
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1671193002
>
> Committed: https://skia.googlesource.com/skia/+/026388a01864c74208ad57d1ba4f711602d101c6
TBR=msarett@google.com ,reed@google.com,scroggo@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4691
Review URL: https://codereview.chromium.org/1685963004
2016-02-10 11:25:07 -08:00
scroggo
026388a018
Make SkPicture/SkImageGenerator default to SkCodec
...
Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.
Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.
Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.
Update all clients to use the default.
Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.
BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1671193002
Review URL: https://codereview.chromium.org/1671193002
2016-02-10 11:15:21 -08:00
joshualitt
94edeb2d3b
Fix for mips build
...
TBR=scroggo@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1688823002
Review URL: https://codereview.chromium.org/1688823002
2016-02-10 09:47:28 -08:00
ethannicholas
50a8dd0a00
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
...
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002
Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e
Committed: https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4
Review URL: https://codereview.chromium.org/1681643002
2016-02-10 05:40:46 -08:00
caryclark
d116561ddc
Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. (patchset #3 id:40001 of https://codereview.chromium.org/1681643002/ )
...
Reason for revert:
breaks various android builds, e.g.
acb02999d4/logs/build_error.log
external/skia/bench/../tools/debugger/SkDrawCommand.cpp:602:9: error: use of undeclared identifier 'free'
free(data);
Original issue's description:
> Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
> SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
> has been updated.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002
>
> Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e
>
> Committed: https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4
TBR=jcgregorio@google.com ,joshualitt@chromium.org,ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1683093002
2016-02-10 04:34:08 -08:00
ethannicholas
46cb6d6b82
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
...
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002
Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e
Review URL: https://codereview.chromium.org/1681643002
2016-02-09 14:37:55 -08:00
ethannicholas
3cb954245c
moved debugger support files from src/utils/debugger to tools/debugger
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1678893003
Review URL: https://codereview.chromium.org/1678893003
2016-02-09 12:44:06 -08:00
caryclark
f1d415188f
Add unit test to feed valid SVG sequences to make sure that
...
path strings can be parsed without returning an error.
Draw the output through Skia and SVG to make sure they are
parsed correctly.
R=fmalita@chromium.org
BUG=skia:4549
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1675053002
Review URL: https://codereview.chromium.org/1675053002
2016-02-09 10:30:22 -08:00
joshualitt
3ebd050be5
Create a thermal manager class and wire it in to nanobench behind a flag
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1671573002
Review URL: https://codereview.chromium.org/1671573002
2016-02-09 07:18:08 -08:00
scroggo
3ac66e98f8
Optionally run RAW images serially
...
RAW images use a lot of memory. Add a new FLAG to run one at a time so
we have less risk of running out of memory.
Isolate RAW images to their own thread on particular devices where our
images cause OOM errors.
Locally, this drops the max memory use from 3945 MB to 1664 MB (running only --image --images <RAW images we test>)
BUG=skia:4912
BUG=skia:4878
BUG=b/27035849
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681553003
Review URL: https://codereview.chromium.org/1681553003
2016-02-08 15:09:48 -08:00
joshualitt
873d624b80
Skia serve now supports favicon correctly
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676403002
Review URL: https://codereview.chromium.org/1676403002
2016-02-08 13:57:44 -08:00
msarett
772cc404e6
Blacklist RAW images on GPU tests
...
BUG=skia:4888
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1677133002
Review URL: https://codereview.chromium.org/1677133002
2016-02-08 11:43:50 -08:00
msarett
13a036b7eb
Test CodecImageGenerator on GPU bots
...
In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.
This is adapted from:
https://codereview.chromium.org/1663453002/
This will cause many untriaged images on Gold.
The GPU converts YUV->RGBA differently than we
do in software.
BUG=skia:4888
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676663002
Review URL: https://codereview.chromium.org/1676663002
2016-02-08 09:10:47 -08:00
joshualitt
cdad12f3b1
Create image cache for use by json canvas
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1670153005
Review URL: https://codereview.chromium.org/1670153005
2016-02-08 07:08:21 -08:00