Commit Graph

6016 Commits

Author SHA1 Message Date
borenet@google.com
da7cb28768 Add wrapper for "gcl try"
Adds some validation for --bot
Review URL: https://codereview.appspot.com/7179048

git-svn-id: http://skia.googlecode.com/svn/trunk@7315 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 18:23:56 +00:00
robertphillips@google.com
25bc2f86c2 Fix saving modified skp from debugger
https://codereview.appspot.com/7181048/



git-svn-id: http://skia.googlecode.com/svn/trunk@7314 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 18:03:56 +00:00
junov@chromium.org
3f5ecd6cb4 Simple Build fix. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@7313 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 18:01:26 +00:00
junov@chromium.org
f3b1223e6d Fixing invalid text clipping on SkPicture playback
The bug was caused by an invalid assumption that a flattend object's
index is related to its array index in SkFlatDictionary::fData.  
The data in SkFlatDictionary is sorted by flattened data content,
not by index number. Problem was solved by passing down the SkFlatData*
through addPaint, rather than the index value. The bug was causing
SkPictureRecord::addFontMetricsTopBottom to use cached font metrics
from the wrong SkPaint instance.

BUG=https://code.google.com/p/chromium/issues/detail?id=170964
Review URL: https://codereview.appspot.com/7178045

git-svn-id: http://skia.googlecode.com/svn/trunk@7312 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 17:50:47 +00:00
robertphillips@google.com
b83b6b4f76 Added toString to SkXfermode-derived classes (for debugger)
https://codereview.appspot.com/7139058/



git-svn-id: http://skia.googlecode.com/svn/trunk@7308 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 14:32:09 +00:00
jvanverth@google.com
d3c208c53e Patch for r7304. Add string in bench_pictures_main's gFilterTypes for oval filter type.
git-svn-id: http://skia.googlecode.com/svn/trunk@7307 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 13:54:52 +00:00
jvanverth@google.com
46d3d39e65 Add GPU support for axis-aligned ovals:
- Add drawOval base function to SkDevice, and override in SkGpuDevice
- Move isSimilarityMatrix to SkMatrix (renamed to isSimilarity) and fixed up unit test
- Since both SkGpuDevice::drawOval() and GrContext::drawPath() can try to draw ovals, added GrContext::canDrawOval() and GrContext::internalDrawOval() to avoid duplicate code
- Hooked in axis-aligned oval fill shader
- Enabled GPU stroked circles
- Added stroked circle bench test

Review URL: https://codereview.appspot.com/7137050



git-svn-id: http://skia.googlecode.com/svn/trunk@7304 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 13:34:01 +00:00
caryclark@google.com
9d5f99bc30 shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7303 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 12:55:54 +00:00
robertphillips@google.com
5632e76dff Place fix in r7278 behind compile flag
git-svn-id: http://skia.googlecode.com/svn/trunk@7300 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-21 21:48:58 +00:00
rmistry@google.com
fd78046e7b Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7299 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-21 21:18:14 +00:00
robertphillips@google.com
90b17c7485 Placing 1xN bitmap shader opt behind a flag to delay WebKit rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@7298 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-21 21:17:16 +00:00
rmistry@google.com
60b0e9de5b Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7297 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-21 03:43:21 +00:00
rmistry@google.com
7a7caa294a Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7296 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-20 16:22:24 +00:00
skia.committer@gmail.com
9f876ed0c8 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7295 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-20 07:05:51 +00:00
caryclark@google.com
05c4bad470 shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7294 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-19 13:22:39 +00:00
skia.committer@gmail.com
36df7ed46b Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7293 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-19 07:05:38 +00:00
epoger@google.com
666c5cf3af Fix bugs in r7291
TBR=reed
Review URL: https://codereview.appspot.com/7129057

git-svn-id: http://skia.googlecode.com/svn/trunk@7292 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-19 04:56:36 +00:00
epoger@google.com
3726960733 re-land r7258 with fixes and tests
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=reed
Review URL: https://codereview.appspot.com/7132060

git-svn-id: http://skia.googlecode.com/svn/trunk@7291 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-19 04:21:27 +00:00
senorblanco@chromium.org
514b922236 Partial revert of r7287 to green up the bots.
git-svn-id: http://skia.googlecode.com/svn/trunk@7290 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 21:53:12 +00:00
epoger@google.com
9ef89ce8b7 Roll out r7258
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=robertphillips
Review URL: https://codereview.appspot.com/7138065

git-svn-id: http://skia.googlecode.com/svn/trunk@7289 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 21:45:42 +00:00
bungeman@google.com
8e4adb0e01 Update gyp revision.
Now allows out-of-source output directories.


git-svn-id: http://skia.googlecode.com/svn/trunk@7288 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 21:20:16 +00:00
senorblanco@chromium.org
3f2d45aff6 (Relanding r7275 with assert fix, plus fixes from r7276, r7280, r7283.)
Implement a bicubic resampling image filter, with raster and GPU backends.
In order to get this to work on the GPU side, I had to modify the width and height of the drawn texture in drawSprite() and drawDevice() to use the filtered texture's dimensions, instead of the source texture.  (This wasn't a problem before since all other image filters produce results the same dimensions as their input texture.)
For now, this implementation only does axis-aligned scaling (same as the Lanczos-3 implementation in Chrome).  It's also done for correctness and clarity, not speed, so there are lots of opportunities for speedups.

Committed: https://code.google.com/p/skia/source/detail?r=7275

Review URL: https://codereview.appspot.com/7033049

git-svn-id: http://skia.googlecode.com/svn/trunk@7287 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 20:48:20 +00:00
epoger@google.com
80d447893e gm self-test: followup to r7284
TBR=rmistry
Review URL: https://codereview.appspot.com/7128056

git-svn-id: http://skia.googlecode.com/svn/trunk@7286 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 20:03:58 +00:00
robertphillips@google.com
c51f752554 Reverting chain of SkBicubicImageFilter changes (7275, 7276, 7280 & 7283)
git-svn-id: http://skia.googlecode.com/svn/trunk@7285 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 19:20:52 +00:00
epoger@google.com
407f8da4f4 make gm self-test more robust
BUG=http://code.google.com/p/skia/issues/detail?id=1068
Review URL: https://codereview.appspot.com/7164043

git-svn-id: http://skia.googlecode.com/svn/trunk@7284 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 19:19:47 +00:00
reed@google.com
2124446ebb fix unused-variable warning in src/effects/SkBicubicImageFilter.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@7283 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 18:31:19 +00:00
edisonn@google.com
8ba9a834c3 tools.gyp: dependencies in apfabetical order
Review URL: https://codereview.appspot.com/7127055

git-svn-id: http://skia.googlecode.com/svn/trunk@7281 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 18:06:22 +00:00
robertphillips@google.com
9f4965270f Removed unused variable in SkBicubicImageFilter.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@7280 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:56:31 +00:00
reed@google.com
f919b720a1 in SkPath::dump(), add \n after close() printf, so we don't run into the next verb (e.g. moveTo)
git-svn-id: http://skia.googlecode.com/svn/trunk@7279 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:53:36 +00:00
reed@google.com
64d6295b0f increase iteration count from 16 to 24, when computing cubic-line intersection.
This fixes crbug 170666. Before the fix, were were finishing the "clip" step
with a curve that was still partly negative, and so as assert would fire.

added unittest to confirm that the assert doesn't fire.



git-svn-id: http://skia.googlecode.com/svn/trunk@7278 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:49:28 +00:00
robertphillips@google.com
7da456d52b Fix 7273 for neon
https://codereview.appspot.com/7137059/



git-svn-id: http://skia.googlecode.com/svn/trunk@7277 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:41:26 +00:00
senorblanco@chromium.org
92435a4364 Fix GPU-less build. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@7276 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:32:50 +00:00
senorblanco@chromium.org
744820e657 Implement a bicubic resampling image filter, with raster and GPU backends.
In order to get this to work on the GPU side, I had to modify the width and height of the drawn texture in drawSprite() and drawDevice() to use the filtered texture's dimensions, instead of the source texture.  (This wasn't a problem before since all other image filters produce results the same dimensions as their input texture.)
For now, this implementation only does axis-aligned scaling (same as the Lanczos-3 implementation in Chrome).  It's also done for correctness and clarity, not speed, so there are lots of opportunities for speedups.

Review URL: https://codereview.appspot.com/7033049

git-svn-id: http://skia.googlecode.com/svn/trunk@7275 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:29:15 +00:00
edisonn@google.com
ca98b3106f Build render_pdfs on buildbot.
Review URL: https://codereview.appspot.com/7134055

git-svn-id: http://skia.googlecode.com/svn/trunk@7274 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 17:24:33 +00:00
robertphillips@google.com
8b8bf4d12e Added shaderproc for 1xN repeatX/repeatY BitmapProcShader
https://codereview.appspot.com/7063054/



git-svn-id: http://skia.googlecode.com/svn/trunk@7273 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 16:38:40 +00:00
djsollen@google.com
98d97fc0bb Fix gyp files when building Android for x86
BUG=606

Review URL: https://codereview.appspot.com/7086053

git-svn-id: http://skia.googlecode.com/svn/trunk@7271 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 15:21:54 +00:00
rmistry@google.com
b7a00ba537 Whitespace commit to test annotations (AddDashboardAnnotation)
git-svn-id: http://skia.googlecode.com/svn/trunk@7270 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 12:13:40 +00:00
skia.committer@gmail.com
15dd300ac6 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7268 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-18 07:07:28 +00:00
reed@google.com
51bbe75875 change SkPath::dump() to output compilable code snippet, to aid in debugging.
git-svn-id: http://skia.googlecode.com/svn/trunk@7267 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 22:07:50 +00:00
caryclark@google.com
73ca6243b3 shape ops work in progress
mostly working on cubic/cubic intersect

git-svn-id: http://skia.googlecode.com/svn/trunk@7266 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 21:02:47 +00:00
bungeman@google.com
148a3961b1 Don't die when there are no fonts available.
https://codereview.appspot.com/7147044/


git-svn-id: http://skia.googlecode.com/svn/trunk@7265 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 20:19:13 +00:00
robertphillips@google.com
8e679fe023 Added new bench to test out 1xN BitmapProcShaders
https://codereview.appspot.com/7160043/



git-svn-id: http://skia.googlecode.com/svn/trunk@7264 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 19:51:41 +00:00
rmistry@google.com
b30bfb7a7c All skp files in Google Storage have been updated
git-svn-id: http://skia.googlecode.com/svn/trunk@7261 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 18:43:29 +00:00
bsalomon@google.com
70db51fc09 Fix call to INHERITED::isEqual in GrRadial2Gradient. Should be INHERITED::onIsEqual.
git-svn-id: http://skia.googlecode.com/svn/trunk@7260 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 18:39:59 +00:00
epoger@google.com
a243b22422 Reapply r7198 with Mac/Windows fixes
BUG=https://code.google.com/p/skia/issues/detail?id=1067
Review URL: https://codereview.appspot.com/7138056

git-svn-id: http://skia.googlecode.com/svn/trunk@7258 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 17:54:28 +00:00
bsalomon@google.com
68b58c9538 Remove default implementation of GrEffect::isEqual. Make GrSingleTextureEffect abstract.
Review URL: https://codereview.appspot.com/7142049

git-svn-id: http://skia.googlecode.com/svn/trunk@7254 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 16:50:08 +00:00
bungeman@google.com
e8cc6e8071 Make navigating the picture view in debugger more functional.
https://codereview.appspot.com/7134049/


git-svn-id: http://skia.googlecode.com/svn/trunk@7253 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 16:30:56 +00:00
robertphillips@google.com
2da95b2ac5 Fix debugger handling of clip rrects
https://codereview.appspot.com/7135053/



git-svn-id: http://skia.googlecode.com/svn/trunk@7252 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 16:07:04 +00:00
reed@google.com
2b16570bda cherry-pick from 7241: speed-up matrix44::setconcat when both inputs are
scale+translate by inlining the zero-assignments, rather than calling sk_bzero.

bench: matrix44_setconcat 2x faster



git-svn-id: http://skia.googlecode.com/svn/trunk@7251 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 16:01:19 +00:00
rmistry@google.com
6be0b4c63d Adding CheckChangeHasOnlyOneEol to upload and commit presubmit checks
Review URL: https://codereview.appspot.com/7151043

git-svn-id: http://skia.googlecode.com/svn/trunk@7247 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 14:50:59 +00:00