fmalita
79ca081b90
Minimize SkTHash object copying
...
AKA ref-constify the world.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/919193002
2015-02-12 17:32:49 -08:00
mtklein
0a62ad734c
Revert of I cannot remember what the race here actually was. (patchset #1 id:1 of https://codereview.chromium.org/922873002/ )
...
Reason for revert:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN/builds/1557/steps/dm/logs/stdio
Original issue's description:
> I cannot remember what the race here actually was.
>
> Removing SkTRacy will show us, or perhaps show us we already fixed the race.
>
> BUG=chromium:437511
>
> No public API changes.
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/71409c83e69b387b3c5d567197d0421c36baf68d
TBR=bungeman@google.com ,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:437511
Review URL: https://codereview.chromium.org/923543003
2015-02-12 15:32:07 -08:00
mtklein
71409c83e6
I cannot remember what the race here actually was.
...
Removing SkTRacy will show us, or perhaps show us we already fixed the race.
BUG=chromium:437511
No public API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/922873002
2015-02-12 15:24:51 -08:00
joshualitt
84b13dfde1
Revert of AA stroke rects batch (patchset #6 id:100001 of https://codereview.chromium.org/912483004/ )
...
Reason for revert:
breaks in debug nanobench
Original issue's description:
> AA stroke rects batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/68c7b6aa98816badbbb69ef65a84a932b8dd58f3
>
> Committed: https://skia.googlesource.com/skia/+/b0fb935bd544b0c6f68c692c7e1ee40876184a1a
TBR=bsalomon@google.com ,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/924533004
2015-02-12 15:03:49 -08:00
joshualitt
dd2198701b
fix for uniform view matrix being uploaded but not used
...
As discussed, I'll follow this up by removing localmatrix/uniform view matrix from the base classe
BUG=skia:
Review URL: https://codereview.chromium.org/920933002
2015-02-12 14:48:42 -08:00
joshualitt
8072caa803
A simple change to move a bunch of stuff out of Gr*Geometry.h
...
BUG=skia:
Review URL: https://codereview.chromium.org/920863002
2015-02-12 14:20:52 -08:00
joshualitt
b0fb935bd5
AA stroke rects batch
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/68c7b6aa98816badbbb69ef65a84a932b8dd58f3
Review URL: https://codereview.chromium.org/912483004
2015-02-12 14:18:47 -08:00
fmalita
7b4d4c7a46
[PDF] Fix shader fallback mapping when clipped
...
The bounding box used for our pattern sizing is in device coordinates,
but SkPDFImageShader::Create() runs it through the inverse CTM to map
into shader space (with a notable effect of vertical flipping).
In order not to implode, the fallback shader path needs to compute its
adjustments in a consistent space.
BUG=skia:3398, chromium:454591, chromium:455052
R=halcanary@google.com
Review URL: https://codereview.chromium.org/901303003
2015-02-12 13:56:51 -08:00
Mike Klein
201c98d08d
fix windows build
...
BUG=skia:
Review URL: https://codereview.chromium.org/917363002
2015-02-12 16:41:57 -05:00
reed
05d9044de4
optional res-scale parameter to getFillPath
...
BUG=skia:
NOTREECHECKS=True
TBR=
Review URL: https://codereview.chromium.org/911053005
2015-02-12 13:35:52 -08:00
robertphillips
3a092042bc
Revert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #3 id:40001 of https://codereview.chromium.org/912403004/ )
...
Reason for revert:
Erm - Chrome.
Original issue's description:
> Remove SkPictureFlat.h include from SkDrawCommands.h
>
> This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium
>
> Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976
>
> Committed: https://skia.googlesource.com/skia/+/fa3a83d0fe53907e618346d3f1c17a95da1a9d22
TBR=reed@google.com ,fmalita@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/923753002
2015-02-12 13:29:15 -08:00
scroggo
7cd3f64385
Stop adding mssse3 & m32/m64 for Android framework.
...
BUG=skia:3423
Review URL: https://codereview.chromium.org/920703005
2015-02-12 13:27:40 -08:00
mtklein
979e0eacbd
Spin off SkTHashTable, SkTHashMap, SkTHashSet
...
SkTHashTable is very similar to SkTDynamicHash, except it's generalized to support non-pointer value types.
It doesn't support remove(), just to keep things simple (it's not hard to add).
Instead of an iterator, it has foreach(), again, to keep things simple.
SkTHashMap<K,V> and SkTHashSet<T> build a friendlier experience on top of SkTHashTable.
BUG=skia:
Review URL: https://codereview.chromium.org/925613002
2015-02-12 13:20:08 -08:00
joshualitt
cd96366600
Revert of AA stroke rects batch (patchset #5 id:80001 of https://codereview.chromium.org/912483004/ )
...
Reason for revert:
breaks windows
Original issue's description:
> AA stroke rects batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/68c7b6aa98816badbbb69ef65a84a932b8dd58f3
TBR=bsalomon@google.com ,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/921923002
2015-02-12 13:02:57 -08:00
joshualitt
c63de323e1
Revert of fix for windows bot (patchset #1 id:1 of https://codereview.chromium.org/917933005/ )
...
Reason for revert:
breaks windows
Original issue's description:
> fix for windows bot
>
> TBR=
> NOTREECHECKS=True
> NOTRY=True
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c43a4d868ad93666daf35641e63c70534013a488
TBR=joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/918303003
2015-02-12 13:01:52 -08:00
joshualitt
c43a4d868a
fix for windows bot
...
TBR=
NOTREECHECKS=True
NOTRY=True
BUG=skia:
Review URL: https://codereview.chromium.org/917933005
2015-02-12 12:57:53 -08:00
joshualitt
68c7b6aa98
AA stroke rects batch
...
BUG=skia:
Review URL: https://codereview.chromium.org/912483004
2015-02-12 12:32:26 -08:00
robertphillips
fa3a83d0fe
Remove SkPictureFlat.h include from SkDrawCommands.h
...
This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium
Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976
Review URL: https://codereview.chromium.org/912403004
2015-02-12 12:30:42 -08:00
djsollen
90b5c0ced0
Expose SkPathRef::unique through SkPath.
...
This allows for the removal of SkPath::mSourcePath on Android
as they now have a better indicator of whether or not the path
can be used again via the Java API.
Review URL: https://codereview.chromium.org/913413004
2015-02-12 12:08:40 -08:00
mtklein
8bce2449e7
set skia_arch_type in nacl_make
...
BUG=skia:
Review URL: https://codereview.chromium.org/914413003
2015-02-12 11:34:09 -08:00
scroggo
df1c3373fc
Don't use m32 cflag for x86_64.
...
When checking the skia_arch_type for "x86", instead of doing an
== compare, check if "x86" in skia_arch_type, so it will cover
both x86 and x86_64.
Except when we specifically want x86.
Set skia_arch_width based on "64" in skia_arch_type. No need to specify
in scripts.
In gyp_to_android.py, create a separate var_dict for x86_64.
BUG=skia:3419
Review URL: https://codereview.chromium.org/916113002
2015-02-12 10:48:25 -08:00
scroggo
9d7ceca350
Generated makefile now includes people to contact.
...
Review URL: https://codereview.chromium.org/917913004
2015-02-12 08:20:40 -08:00
mtklein
a2c1171193
DM: document -r
...
https://skia.org/dev/contrib/testing?cl=923543002
BUG=skia:
Review URL: https://codereview.chromium.org/923543002
2015-02-12 07:34:27 -08:00
bungeman
e998b7ff3a
Move SkOSFile::Iter impls into ports.
...
This was one large ifdef in SkOSFile.cpp in utils.
This moves the code to existing ports files.
Review URL: https://codereview.chromium.org/920593002
2015-02-12 07:18:27 -08:00
robertphillips
72942b8eb5
Add staging for Chromium
...
This staging is needed to land https://codereview.chromium.org/912403004/ (Remove SkPictureFlat.h include from SkDrawCommands.h)
Review URL: https://codereview.chromium.org/916983002
2015-02-12 06:37:12 -08:00
joshualitt
19e0058a65
fix for xoom
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/918833003
2015-02-11 17:36:30 -08:00
bsalomon
3740972d02
Make null GL context use callback to make current
...
Review URL: https://codereview.chromium.org/919783002
2015-02-11 14:19:18 -08:00
joshualitt
95964c670b
GMs now use batch
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/3f284d7758d7f35b59d93a22d126f7cd8423be44
Review URL: https://codereview.chromium.org/865313004
2015-02-11 13:45:51 -08:00
robertphillips
2de5939115
Revert of Fix Chromium build (patchset #2 id:20001 of https://codereview.chromium.org/916763003/ )
...
Reason for revert:
Chrome
Original issue's description:
> Fix Chromium build
>
> TBR=jvanverth@google.com
>
> Committed: https://skia.googlesource.com/skia/+/f5e89c8f685ac8a5c4d117e087b4111d613106db
TBR=jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/916963002
2015-02-11 13:18:14 -08:00
robertphillips
25e929955f
Revert of Fix Chromium build (again) (patchset #2 id:20001 of https://codereview.chromium.org/916193002/ )
...
Reason for revert:
Chrome
Original issue's description:
> Fix Chromium build (again)
>
> TBR=jvanverth@google.com
>
> Committed: https://skia.googlesource.com/skia/+/b48e08e03a7573c6917d9932a60af5822c009abd
TBR=jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/920573002
2015-02-11 13:15:12 -08:00
robertphillips
2e6024248f
Revert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #2 id:20001 of https://codereview.chromium.org/912403004/ )
...
Reason for revert:
Chrome
Original issue's description:
> Remove SkPictureFlat.h include from SkDrawCommands.h
>
> Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976
TBR=reed@google.com ,fmalita@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/917933002
2015-02-11 13:07:13 -08:00
joshualitt
94dff15404
Revert of GMs now use batch (patchset #3 id:40001 of https://codereview.chromium.org/865313004/ )
...
Reason for revert:
missing hairlines on gms
Original issue's description:
> GMs now use batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3f284d7758d7f35b59d93a22d126f7cd8423be44
TBR=bsalomon@google.com ,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/913153003
2015-02-11 13:03:16 -08:00
robertphillips
b48e08e03a
Fix Chromium build (again)
...
TBR=jvanverth@google.com
Review URL: https://codereview.chromium.org/916193002
2015-02-11 12:52:08 -08:00
bsalomon
7e34007e1e
Add GrGLCreateNullInterface.cpp back to gyp, and put contents in namespace.
...
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/899803004
2015-02-11 12:07:31 -08:00
robertphillips
f5e89c8f68
Fix Chromium build
...
TBR=jvanverth@google.com
Review URL: https://codereview.chromium.org/916763003
2015-02-11 11:38:44 -08:00
joshualitt
3f284d7758
GMs now use batch
...
BUG=skia:
Review URL: https://codereview.chromium.org/865313004
2015-02-11 11:34:58 -08:00
joshualitt
9491f7ff31
remove goto in Distance field path renderer
...
BUG=skia:
Review URL: https://codereview.chromium.org/919693003
2015-02-11 11:33:38 -08:00
bsalomon
bb0502eec5
Support multiple null GL contexts on a thread.
...
This has the side effect of requiring SkNullGLContext to use the null GL interface.
It exposes SkNullGLContext and also removes null context support from SampleApp.
Review URL: https://codereview.chromium.org/916733002
2015-02-11 11:11:11 -08:00
bsalomon
0ea80f43a1
Rename GrResourceCache2->GrResourceCache
...
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/921453002
2015-02-11 10:49:59 -08:00
robertphillips
5a4c233a36
Remove SkPictureFlat.h include from SkDrawCommands.h
...
Review URL: https://codereview.chromium.org/912403004
2015-02-11 10:27:30 -08:00
mtklein
ac83d62f6c
Fix up a couple includes that are using <> instead of "".
...
BUG=skia:
Review URL: https://codereview.chromium.org/916713003
2015-02-11 09:24:20 -08:00
joshualitt
76e7fb6cba
Ovals batch
...
BUG=skia:
Review URL: https://codereview.chromium.org/904753002
2015-02-11 08:52:27 -08:00
bungeman
c3c694342a
Fix append_fallback_font_families_for_locale.
...
The language was being set to garbage, now set to part of the file name.
Add a test to ensure we continue to parse fallback directories correctly.
BUG=chromium:422180
Review URL: https://codereview.chromium.org/912053003
2015-02-11 07:18:51 -08:00
joshualitt
02b05015b5
Small change to use a GrGeometryProcessor for all BitmapText draw calls
...
BUG=skia:
Review URL: https://codereview.chromium.org/914723002
2015-02-11 06:56:30 -08:00
kkinnunen
9e33d1dbcc
debugger: Abandon context when Qt changes it without notice
...
Qt changes the context on many conditions. Abandon GrContext
in these cases.
Also call GrContext::resetContext during Qt GL paint callback,
the GL state may be touched by Qt.
Fixes the bug where changing between gpu and msaa would start
erroring in framebuffer binds, if the .skp had many layers.
Review URL: https://codereview.chromium.org/915573002
2015-02-10 22:27:48 -08:00
bsalomon
3632f8473a
Add tests for STArray swap
...
Review URL: https://codereview.chromium.org/909583003
2015-02-10 19:46:58 -08:00
mtklein
d160192fd9
Revert of GYP groudwork for half-float opts support. (patchset #1 id:1 of https://codereview.chromium.org/915693002/ )
...
Reason for revert:
Going to punt on 16-bit float support for now. Can't figure out ARM 64.
Original issue's description:
> GYP groudwork for half-float opts support.
>
> This sets us up two new opts targets with the immediate goal of adding half-float (SkHalf.h) opts:
> - opts_neon_fp16: uses hardware support on most ARM chips with NEON to do 4 conversions at a time;
> - opts_avx: uses hardware support on Intel chips with AVX to do 8 conversions at a time.
>
> opts_avx will be a handy thing to have around later too, especially if we want to work with floats.
>
> This doesn't actually add any new source files to these libraries yet, so they're no-ops for now.
> I'll need to write a parallel change to Chrome's GN and GYPs before we can start adding sources.
>
> This also rolls GYP up to head, to get suppport for EnableEnhancedInstructionSet: '3' on Windows,
> which is how we turn on AVX there. There's no Mac-specific flag, so we use OTHER_CPLUSPLUSFLAGS.
>
> BUG=skia:
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/46b80833394d7919cadf2abf2b93802141dd21c5
TBR=reed@google.com ,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/912223002
2015-02-10 18:18:18 -08:00
mtklein
94aca69d1e
Revert of add dummy avx file so xcode will build (patchset #1 id:1 of https://codereview.chromium.org/916563002/ )
...
Reason for revert:
Going to punt on 16-bit float support for now. Can't figure out ARM 64.
Original issue's description:
> add dummy avx file so xcode will build
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/a0921f2563701d54e4e022de99f2705f4ada8a6e
TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/912213002
2015-02-10 18:17:17 -08:00
reed
8ed666d230
add gm for stroked circles that are zoomed
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/912203002
2015-02-10 17:44:26 -08:00
reed
8432808ad8
check for inverted rects before we quick-reject
...
BUG=skia:
Review URL: https://codereview.chromium.org/908353002
2015-02-10 14:18:09 -08:00