Commit Graph

39805 Commits

Author SHA1 Message Date
skia-autoroll
ece8b3df7d Roll third_party/externals/angle2 fe59f6b5ed2b..ad194995ed72 (8 commits)
fe59f6b5ed..ad194995ed


git log fe59f6b5ed2b..ad194995ed72 --date=short --no-merges --format='%ad %ae %s'
2019-02-12 spang@chromium.org Disable broken tests on Fuchsia
2019-02-11 spang@chromium.org Vulkan: Port renderer to Fuchsia
2019-02-11 jmadill@chromium.org Vulkan: Enable WebGLCompatiblityTest.
2019-02-11 jmadill@chromium.org Vulkan: Suppress layer warnings about unbound outputs.
2019-02-11 jmadill@chromium.org Vulkan: Fix UtilsVk invalidating Context descriptors.
2019-02-11 tobine@google.com Vulkan:Adding Cmd Buffer Reset tests
2019-02-11 fjhenigman@chromium.org Vulkan: make GenerateCaps a member of RendererVk.
2019-02-11 spang@chromium.org Vulkan: Respect EGL_HEIGHT & EGL_WIDTH in SurfaceVk


Created with:
  gclient setdep -r third_party/externals/angle2@ad194995ed72

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stephana@google.com

Change-Id: Ic98a5f3124f64d72e2b61e931135d79039ba6716
Reviewed-on: https://skia-review.googlesource.com/c/191317
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-12 03:48:12 +00:00
Nigel Tao
b7a1b5189d SkWuffsCodec: zero dst buffer before decodeFrame
https://skia-review.googlesource.com/c/189866 "SkWuffsCodec: Initialize
memory when incomplete" made some buffer zero'ing conditional on a
frame's dirty rectangle, which required moving the this->decodeFrame
call earlier in onIncrementalDecode, since we can't know the dirty
rectangle until after decodeFrame is called.

However, moving that earlier meant that it was now earlier than the
"sk_bzero(pixels.ptr + etc, etc)" call that zero-initialized the
destination buffer that decodeFrame writes to. The actual pixel indexes
that decodeFrame decodes are now overwritten by zeroes.

That prior commit fixed the fuzzer-discovered bug, in that it no longer
swizzles from uninitialized memory. Unfortunately, it's now often
swizzling from all-zeroed memory, so that the decoding is incorrect.

This commit moves the zero-ing to onStartIncrementalDecode, even
earlier. The "dm --match Gif" tests are happy again.

Bug: skia:8235
Change-Id: Iae993b7d9f45e1b375ed99f6cc86536091a92eba
Reviewed-on: https://skia-review.googlesource.com/c/190941
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-02-12 03:48:10 +00:00
Ben Wagner
454e5fb745 Fix cluster reporting from shaper.
Bug: skia:8420
Change-Id: I7eea8c6b3af2153a1ac1189782fc6cbaaf9ee5c6
Reviewed-on: https://skia-review.googlesource.com/c/190821
Reviewed-by: Hal Canary <halcanary@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-11 21:59:33 +00:00
skia-autoroll
5456f0979a Roll third_party/externals/swiftshader 64c44b0c53c4..f96948857780 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/64c44b0c53c4..f96948857780


git log 64c44b0c53c4..f96948857780 --date=short --no-merges --format='%ad %ae %s'
2019-02-11 capn@google.com Fix shader call stack size mismatch
2019-02-11 chrisforbes@google.com Use spirv-tools optimizer in GraphicsPipeline
2019-02-11 chrisforbes@google.com Replace Shader,VertexShader,PixelShader with SpirvShader


Created with:
  gclient setdep -r third_party/externals/swiftshader@f96948857780

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stephana@google.com

Change-Id: Icf7a4b514f0b0e8b0a730aa88ba325fbd9bb79d8
Reviewed-on: https://skia-review.googlesource.com/c/191308
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-11 21:57:54 +00:00
Herb Derby
0404afd5d5 Common code calculates strike for mask case.
Instead of the Renderer and the GPU calculating the strike,
the common code now calculates the strike.

Bug: skia:7515

Change-Id: I4bc65f83347e57f5b242380b0cadb74c43b8a152
Reviewed-on: https://skia-review.googlesource.com/c/191382
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-02-11 21:45:14 +00:00
Mike Klein
640654d145 run all available OpenCL devices
Change-Id: I6d18be3f6178003eb5153d32d4b618101ddcb3d9
Reviewed-on: https://skia-review.googlesource.com/c/191297
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-02-11 21:29:33 +00:00
recipe-roller
603f190a7d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/e893454f797fd9d52438c6a64fd6123073825b64 Fix a typo (thomasanderson@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I626fc312dc521bdb45c4d780bca6c3a3fabfc0c1
Reviewed-on: https://skia-review.googlesource.com/c/191380
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-11 21:19:53 +00:00
Herb Derby
49253648d4 Introduce SkScopedStrike
A SkScopedStrike allows drawGlyphRunAsBMPWithPathFallback
to control the scope of SkStrikeInterface objects generated
by both RemoteGlyphCache and SkStrikeCache.

* introduce onAboutToExitScope() into the SkStrikeInterface

Change-Id: I87a1e623ee9a8375f4e063290d74a466f96c9933
Reviewed-on: https://skia-review.googlesource.com/c/191293
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-02-11 21:14:07 +00:00
Mike Klein
17593ae5aa add a -Wuffs bot
Change-Id: Idec98e922e81e062b78403bb83473e20a49dd13e
Reviewed-on: https://skia-review.googlesource.com/c/191292
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2019-02-11 21:02:33 +00:00
Robert Phillips
b6e9d3c788 Outline GrDrawAtlasOp and GrDrawVerticesOp
This makes it easier to switch all the ops over to using a GrRecordingContext (and better matches what we do with all the other ops)

Change-Id: Ie690975c31b8c9f4c7acebdc0185a145a0a263a5
Reviewed-on: https://skia-review.googlesource.com/c/191280
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-02-11 20:38:35 +00:00
Brian Osman
7f3618a2c9 Use clang versions of SK_RESTRICT and SK_WARN_UNUSED_RESULT on Windows
Bug: skia:
Change-Id: I63bc32c7bba294d8698d17e1f178ca0eb0a84ddf
Reviewed-on: https://skia-review.googlesource.com/c/191295
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-02-11 20:38:33 +00:00
Robert Phillips
a9162dfb9c Plumb abandonment throughout GrContext hierarchy
When the GrImageContext & GrRecordingContext are actually GrDirectContexts it is useful for them to report the abandonment state of the GrDirectContext.

When the GrImageContext & GrRecordingContext are actually GrImageCreationContext or GrDDLContexts then they will just never be abandoned.

This CL also strips the GrProxyProvider and GrDrawingManager of their tracking on abandonment and centralizes it in the GrImageContext.

ImageContext
  can't abandon
  can only check abandonment privately

RecordingContext
  can't abandon
  can only check abandonment privately

DirectContext (aka GrContext)
  can abandon publicly
  can check abandonment publicly

Note that abandoning the DirectContext won't alter the abandonment status of any of
the other contexts in its group (e.g., DDL contexts that may be being used to record).

Change-Id: Ib790f74d90ab18da58a127fed2aad20e2477bd21
Reviewed-on: https://skia-review.googlesource.com/c/190669
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-02-11 20:26:22 +00:00
skia-autoroll
cd2c3db480 Roll third_party/externals/swiftshader d9ce258c174b..64c44b0c53c4 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d9ce258c174b..64c44b0c53c4


git log d9ce258c174b..64c44b0c53c4 --date=short --no-merges --format='%ad %ae %s'
2019-02-11 chrisforbes@google.com Add assert for broken locations


Created with:
  gclient setdep -r third_party/externals/swiftshader@64c44b0c53c4

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stephana@google.com

Change-Id: I975a8a4f8d9ba64ede5551b644859d059509fde2
Reviewed-on: https://skia-review.googlesource.com/c/191304
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-11 20:25:12 +00:00
Mike Klein
103288b50f add Mac OpenCL bots
Change-Id: Ib078676bfe4de033c878f3007b4581d37e7b759b
Reviewed-on: https://skia-review.googlesource.com/c/191288
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-02-11 19:40:52 +00:00
recipe-roller
fd823e9228 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/afae9252c8e14169fec7c7b62ba8b763de9df22e [step_runner] Reland: Specify close_fds to avoid leaking non-std handles to steps. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I382e3bc78114c367b7d6fd950c6b6d83ea3e55a9
Reviewed-on: https://skia-review.googlesource.com/c/191289
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-11 19:38:52 +00:00
Herb Derby
9685057889 Plumb strike through the common code.
Plump the strike calculated in the calling code through
drawGlyphRunAsBMPWithPathFallback. This is in anticipation
of calculating the cache in drawGlyphRunAsBMPWithPathFallback.

* Add getDescriptor to SkStrikeInterface.

Change-Id: I904cdb51f60443cabc9dc41ac246b1fe0c725c85
Reviewed-on: https://skia-review.googlesource.com/c/191285
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-02-11 19:01:54 +00:00
Mike Klein
740e5db7ab remove pointer tagging hack in SkRecord
This interferes with other uses of pointer tagging,
like ARM pointer authentication or HSWASAN.

Bug: b/124135723
Change-Id: I1a78dd4e1b9b18dd02738bb1dfbbb968f29675bc
Reviewed-on: https://skia-review.googlesource.com/c/191286
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2019-02-11 18:52:37 +00:00
Greg Kaiser
73bfb896a4 GrGLGpu: Avoid potential nullptr dereference
We were checking if 'mipMapsStatus' was nullptr, and if it was,
our 'else' clause would have us always dereference this nullptr.
We change the logic to avoid a dereference in this case.

Change-Id: I2bc091c4de0c9b62ae733026cea3be37442820eb
Reviewed-on: https://skia-review.googlesource.com/c/191323
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-11 18:47:36 +00:00
Mike Klein
8a1f15df81 update hello-opencl
- break dependency on code from src/compute
  - port away from C APIs to friendlier C++ wrapper APIs
  - add DEPS for OpenCL C++ wrapper headers so we can build on Mac
  - factor out a //third_party/opencl GN target

Change-Id: I9e37c6677cfb779021e66f2bd10f97570c450746
Reviewed-on: https://skia-review.googlesource.com/c/191281
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-11 18:47:32 +00:00
Nigel Tao
91f96f8005 Update Wuffs version
Bug: oss-fuzz:11823

This pulls in the Wuffs bug fix:
0842bc7115
"Make the GIF dirty_rect be in the frame_rect".

Change-Id: Ib4928eb3cbf4bc862c3ae709fdfe6f179412f95f
Reviewed-on: https://skia-review.googlesource.com/c/190940
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-02-11 18:39:32 +00:00
Mike Klein
10af5ecfaa use /imsvc with clang-cl where we use -isystem
This should disable warnings from third-party headers
on Clang/Win builds.  So far we've just gotten lucky.

Change-Id: Ieaf459e200925d46d8c65ba8d489db111705b125
Reviewed-on: https://skia-review.googlesource.com/c/191283
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-02-11 18:34:32 +00:00
Greg Kaiser
27f830257b sksl: Use va_end() after va_copy()
We invoke va_end() as required when we're done with our va_copy().

Change-Id: Ibc55279c3bc01a63da2ef5f1942d46367eac8a67
Reviewed-on: https://skia-review.googlesource.com/c/191322
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-11 18:34:22 +00:00
skia-autoroll
58d6c68bff Roll third_party/externals/angle2 abf6dbbb107b..fe59f6b5ed2b (1 commits)
abf6dbbb10..fe59f6b5ed


git log abf6dbbb107b..fe59f6b5ed2b --date=short --no-merges --format='%ad %ae %s'
2019-02-11 geofflang@chromium.org Vulkan: Implement EGL Images for 2D and Renderbuffer sources.


Created with:
  gclient setdep -r third_party/externals/angle2@fe59f6b5ed2b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stephana@google.com

Change-Id: I5f3c6e024609ba6e35e8a52d3f9f3107c5af43fe
Reviewed-on: https://skia-review.googlesource.com/c/191183
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-11 18:27:25 +00:00
Greg Kaiser
4dbaafa75b bookmaker: Remove fflush() on closed file
fflush() requires an open file handle, so it shouldn't be called
right after fclose().  And fclose() performs an fflush(), by
definition (see http://man7.org/linux/man-pages/man3/fclose.3.html ),
so we can remove this fflush() call altogether.

Change-Id: I8fbdd5a85b3cdb5edfdabbd5dca449ea1d4fce2d
Reviewed-on: https://skia-review.googlesource.com/c/191321
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-11 18:00:22 +00:00
Greg Kaiser
837178206e skc: Avoid undefined variable modification
Our code had two modifications of 'from' without a sequence point
between them.  This leaves the behavior undefined.  We change
the code to only modify 'from' once, and have this behavior
well defined.

Change-Id: Ifa4fb191ecc071fdb4793901eaef777294709467
Reviewed-on: https://skia-review.googlesource.com/c/191320
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-11 17:53:02 +00:00
Herb Derby
30595ea7c7 Use descriptor instead of cache for GrStrikeCache lookup
Change-Id: Ia8e82344d3d8b394a6d9cc14d56dcf0addeff96c
Reviewed-on: https://skia-review.googlesource.com/c/191220
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-02-11 17:06:19 +00:00
Michael Ludwig
b7d64b989e Implement drawImage in terms of drawImageRect
This will cause the raster backend to draw shadermask_image incorrectly since
drawImageRect implementation has the wrong semantics. bitmapshader's expected
behavior has changed: GPU will draw the new version correctly, but raster's
will not change from the old, incorrect behavior.

Bug: skia:8752
Change-Id: Iee89082e2fdf95c2ee42ca3b052e65556f327eff
Reviewed-on: https://skia-review.googlesource.com/c/190675
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-02-11 17:02:00 +00:00
Mike Klein
0e83da8646 turn on -Wextra-semi-stmt on Windows
Just a few strays.

Change-Id: Ib209bc8dd228850b837b850dce14967a2112593e
Reviewed-on: https://skia-review.googlesource.com/c/191161
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-02-11 16:50:09 +00:00
Brian Osman
535c5e34ee Add ImGui::DragCanvas, to simplify several custom widgets
Bug: skia:
Change-Id: Ic44ab00af1117a6bbc17df7f5005f4db707cb5c1
Reviewed-on: https://skia-review.googlesource.com/c/191002
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-02-11 16:31:59 +00:00
Hal Canary
77a1a7e618 find_commit_with_best_gold_results takes arguments
No-Try: true
Change-Id: Iafb9453f40fd16c139996bf8f37b8c5255982486
Reviewed-on: https://skia-review.googlesource.com/c/191160
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-11 15:00:27 +00:00
Nico Weber
5257816bd3 Remove a few semicolons.
Bug: chromium:926235
Change-Id: I338323847c34dabdbd963efe631f7dc1351ed8cc
Reviewed-on: https://skia-review.googlesource.com/c/191143
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-11 14:40:37 +00:00
skia-autoroll
3d7931546d Roll third_party/externals/swiftshader 9388dded242f..d9ce258c174b (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/9388dded242f..d9ce258c174b


git log 9388dded242f..d9ce258c174b --date=short --no-merges --format='%ad %ae %s'
2019-02-11 bclayton@google.com CMake: Generate the ICD json file into the output directory


Created with:
  gclient setdep -r third_party/externals/swiftshader@d9ce258c174b

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stephana@google.com

Change-Id: I8035b83c60edc695e2661e0ce4e277cdc1e67c1b
Reviewed-on: https://skia-review.googlesource.com/c/191101
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-11 14:31:17 +00:00
skia-autoroll
401ec83efd Roll ../src 1fcc8416fd35..35663ddf4997 (90 commits)
1fcc8416fd..35663ddf49


git log 1fcc8416fd35..35663ddf4997 --date=short --no-merges --format='%ad %ae %s'
2019-02-11 wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com Import wpt@ee563ea4a1f935bd1cac734dbe786f53c38dbeae
2019-02-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/swiftshader 9686153413f3..9388dded242f (1 commits)
2019-02-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll AFDO from 74.0.3701.0_rc-r1 to 74.0.3702.0_rc-r1
2019-02-11 jfernandez@igalia.com [css-grid] Overflow should be computed with the actual logical bottom
2019-02-11 jdoerrie@chromium.org [Sheriff] Disable SiteSettingsHandlerTest.GetAllSites on CrOS and Linux
2019-02-11 markusheintz@chromium.org [Security Events] Add SECURITY_EVENTS datatype without enabling it yet.
2019-02-11 msisov@igalia.com [ozone] Implement Clipboard for Ozone platforms.
2019-02-11 bcwhite@chromium.org Move aggregation documentation from internal.
2019-02-11 jdoerrie@chromium.org Conditionally Disable HostResolverImplTest.DeleteWithinAbortedCallback_ResolveHost
2019-02-11 jdoerrie@chromium.org [Sheriff] Disable SingleClientPreferencesSyncTest.ShouldRemoveBadDataWhenRegistering on Windows
2019-02-11 svillar@igalia.com Remove duplicate error checking in FakeOAuth2TokenServiceDelegate
2019-02-11 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 to version 7.4.131.
2019-02-11 raul@tambre.ee //components/spellcheck: Fix 64-bit truncation issues
2019-02-11 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 54496f14f521..171caf9508b1 (1 commits)
2019-02-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia 9a2169e84f25..d336ebdea812 (3 commits)
2019-02-11 futhark@chromium.org Introduce dark color scheme with UA style.
2019-02-11 raul@tambre.ee //ios: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-11 mastiz@chromium.org Trivial: remove unused includes
2019-02-11 jdoerrie@chromium.org [Sheriff] Disable Failing RTCIceTransport-extension.https.html Test on Linux
2019-02-11 lizeb@chromium.org blink/dom: Make CharacterData use ParkableStrings for large strings.
2019-02-11 ioanap@chromium.org Add field trial testing config for the GooglePasswordManager UI on Android
2019-02-11 gyuyoung@igalia.com s13n: Convert IdentityManager::Observer::OnErrorStateOfRefreshTokenUpdatedForAccount to use CoreAccountInfo
2019-02-11 arbesser@google.com [Autofill Assistant] Added DVLOGs to web_controller.
2019-02-11 perezju@chromium.org [tools/perf] Remove unused bootstrap.DownloadDeps
2019-02-11 treib@chromium.org PersonalDataManager: Small cleanups
2019-02-11 dullweber@chromium.org Sync history deletions from chrome.history api
2019-02-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia 136cd7018a99..9a2169e84f25 (1 commits)
2019-02-11 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 3c7ef7a3b16e..54496f14f521 (1 commits)
2019-02-11 mastiz@chromium.org Move datatype dependencies away from SyncClient
2019-02-11 arthursonzogni@chromium.org Ignore same-document navigation commit in pending deletion frame.
2019-02-11 vabr@chromium.org CSVTable should only understand CRLF and LF as EOL
2019-02-11 raul@tambre.ee //components/supervised_user_error_page: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-11 fhorschig@chromium.org [Mfill Android] Display title of open sheet in accessory bar
2019-02-11 treib@chromium.org sync_ui_util: Only take a Profile* param, not other KeyedService*s
2019-02-11 fhorschig@chromium.org [Android Mfill] Reenable integration tests
2019-02-11 pwnall@chromium.org blink: Fix member names in comments.
2019-02-11 arthursonzogni@chromium.org Add comment to NavigationBodyLoader::OnReceiveCachedMetadata()
2019-02-11 michaelpg@chromium.org Fix mojo mailing list
2019-02-11 jochen@chromium.org Renable BrowserTest.WindowOpenClose1 and disable DCHECK instead
2019-02-11 ceciliani@google.com [App Management] Integrate search view with dom-switch
2019-02-11 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 4d85a1763c27..3c7ef7a3b16e (1 commits)
2019-02-11 joelhockey@chromium.org Roll src/third_party/cros_system_api/ 13b2686c5..dbbd7b449 (6 commits)
2019-02-11 alliemurray@google.com Render file system type in the Type column of the detail table for
2019-02-11 googleo@chromium.org Fix the response check.
2019-02-11 staphany@chromium.org AppCache: Remove AppCacheBackendImpl::RegisterHostForTesting.
2019-02-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia ef26fcb13fc6..136cd7018a99 (1 commits)
2019-02-11 akahuang@google.com media: Add SimpleSyncTokenClient class.
2019-02-11 staphany@chromium.org AppCache: Simplify AppCacheBackendImpl::RegisterHost checks.
2019-02-11 ceciliani@google.com [App Management] Add PWA Permission View Test
2019-02-11 joelhockey@chromium.org Create crostini::ContainerId type as pair of strings
2019-02-11 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal ee1cb5959d7a..4d85a1763c27 (1 commits)
2019-02-11 findit-for-me@appspot.gserviceaccount.com Revert "[Dolphin] Refactor in preparation for query-based predictions."
2019-02-11 melzhang@google.com Implement ArcApps::Uninstall.
2019-02-11 loyso@chromium.org WebApp: Add UI install dialog callback into WebAppInstallManager flow.
2019-02-11 adunaev@igalia.com [ozone/wayland] Improved the wayland buffer fuzzer.
2019-02-11 chrome-release-bot@chromium.org Updating trunk VERSION from 3702.0 to 3703.0
2019-02-11 tby@chromium.org [Dolphin] Refactor in preparation for query-based predictions.
2019-02-11 thakis@chromium.org Remove some unnecessary semicolons.
2019-02-11 thakis@chromium.org Remove semicolons after DECLARE_EXTENSION_FUNCTION().
2019-02-11 nickdiego@igalia.com ozone/wayland: Handle preedit string in WaylandInputMethodContext
2019-02-11 loyso@chromium.org WebApp: Start all subsystems only after web app registry is ready.
2019-02-11 alancutter@chromium.org Add flag for omnibox installation button for PWA sites
2019-02-11 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal e971cc3474b7..ee1cb5959d7a (1 commits)
2019-02-11 rekanorman@google.com [App Management] Add ARC permission view and fix notifications view.
2019-02-11 jinsukkim@chromium.org Android: Merge flags for overscroll history navigation
2019-02-11 jopra@chromium.org Adds a USB detector class for ChromeOS
2019-02-11 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal aa5c2279db31..e971cc3474b7 (1 commits)
2019-02-11 lucmult@chromium.org Fix -webkit prefix lint for file_manager.css
2019-02-11 lucmult@chromium.org [Files app] Re-format file_table_list.js
2019-02-11 dstockwell@google.com Roll third_party/ink to 233314166
2019-02-11 amoylan@chromium.org Extend ML Service histograms 2 months past M74
2019-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia 5fc138c04690..ef26fcb13fc6 (1 commits)
2019-02-10 amistry@chromium.org Run smb_client::MDnsHostLocator core on the IO thread.
2019-02-10 mmenke@chromium.org Socket Pools Refactor 24: Remove HttpProxyClientSocketPool class.
2019-02-10 jperaza@chromium.org android: search arm and arm64 directories for native code
2019-02-10 junyer@chromium.org Roll src/third_party/re2/src/ 30cad2671..59f03f306 (1 commit)
2019-02-10 treib@chromium.org Prefer SyncService over ProfileSyncService in foreign_session_helper
2019-02-10 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 671e5a52238a..aa5c2279db31 (1 commits)
2019-02-10 pkotwicz@chromium.org [Android WebAPK] Split out network error dialog logic into its own class 8/9
2019-02-10 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 to version 7.4.130.
2019-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia fbe2e937c798..5fc138c04690 (1 commits)
2019-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/depot_tools 610a4c6ce76c..aec259ea6232 (1 commits)
2019-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/catapult 8bfeef929cbe..183d99e38bfe (1 commits)
2019-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia 706a7cd1e826..fbe2e937c798 (13 commits)
2019-02-10 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 4b2bf5b221a6..671e5a52238a (17 commits)
2019-02-10 junyer@chromium.org Roll src/third_party/re2/src/ a8176127e..30cad2671 (6 commits)
2019-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/webrtc e556768453ee..1a1c52baf952 (1 commits)
2019-02-10 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 to version 7.4.121.
2019-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/chromite 6b5dce060865..3ef549770d8f (13 commits)
2019-02-10 thakis@chromium.org Revert "Android: Fix colorama-related pydeps"


Created with:
  gclient setdep -r ../src@35663ddf49

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=stephana@google.com

Change-Id: I8e5101631efeaae668c60cfb08533ab2f72e4ed4
Reviewed-on: https://skia-review.googlesource.com/c/191102
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-11 14:14:07 +00:00
skia-autoroll
116d4065d0 Roll third_party/externals/swiftshader 9686153413f3..9388dded242f (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/9686153413f3..9388dded242f


git log 9686153413f3..9388dded242f --date=short --no-merges --format='%ad %ae %s'
2019-02-11 bclayton@google.com vscode: Rewrite tasks.json


Created with:
  gclient setdep -r third_party/externals/swiftshader@9388dded242f

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stephana@google.com

Change-Id: I869f51abe5655d9939864df7bc939b188669193f
Reviewed-on: https://skia-review.googlesource.com/c/191083
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-11 13:05:57 +00:00
Greg Kaiser
d336ebdea8 SkDeque: Move asserts prior to pointer dereference
If we popped too far, we want the assert mechanism to catch this
bug prior to us dereferencing a nullptr.

Change-Id: I681e530e8bcc15897bc52b3688d83f85a59d7449
Reviewed-on: https://skia-review.googlesource.com/c/191065
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-11 10:01:27 +00:00
Greg Kaiser
9be246ed74 GrGLGpu: Remove unused 'return'
We remove the last 'return' statement, which is never reached.
This makes it more clear at a glance what value is being
returned from the function.

Change-Id: Iedeb3f6783a45cb60cd4d1413e294fa025fd9651
Reviewed-on: https://skia-review.googlesource.com/c/191063
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-11 09:55:27 +00:00
Greg Kaiser
b77b1ae65c SkPath: Cleanup code to make array size match
This has no functional change.

We change the declaration of our function argument to have an array
size which matches the incoming argument.  Since C++ treats this
argument as just a function pointer regardless of the declared size,
there's no functional change.  But it makes the code clearer and
prevents static analysis tools from flagging a possible out-of-bound
access.

Change-Id: I896a74d90e56d993887ef38e389b6e9535b47925
Reviewed-on: https://skia-review.googlesource.com/c/191062
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-11 09:48:27 +00:00
Greg Kaiser
9a2169e84f SkImage_GpuYUVA: Also sanity check height
We were sanity checking the width twice; we switch to checking
the width and height.

Change-Id: I0841eaeeb9c42af2e309e0dafa5ec0b1843a71a8
Reviewed-on: https://skia-review.googlesource.com/c/191061
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-11 09:35:22 +00:00
skia-recreate-skps
136cd7018a Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: If3e4fad8335d275cfa6f8abfff8ddfe3cefd4d32
Reviewed-on: https://skia-review.googlesource.com/c/191066
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-02-11 05:37:21 +00:00
Florin Malita
ef26fcb13f [sksg] Fix image filter content inval rect tracking
Image filters cannot let descendent damage pass through, as they may
transform their inputs arbitrarily.

Introduce the notion of "damage override" SG nodes (nodes which block
descendent damage and replace it with their own), and update
ImageFilterEffect to opt in for this behavior.

Also make InvalidationController damage dispatch optional (such that we
don't accumulate inval rects unnecessarily).

TBR=
Change-Id: Ie9f7d32ecdcc77dbe6ea009aed9ce269b3649a04
Reviewed-on: https://skia-review.googlesource.com/c/191005
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-10 21:43:20 +00:00
recipe-roller
5fc138c046 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8aecb83af4db724bf6673cbcbc7a1c40083bc1a7 [buildbucket] Update vendored protos (nodir@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia39bcfba0ebbb5da20344336cf7b4e2b7e22321a
Reviewed-on: https://skia-review.googlesource.com/c/191004
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-10 16:55:50 +00:00
skia-autoroll
fbe2e937c7 Roll ../src 99d98c846f9b..1fcc8416fd35 (15 commits)
99d98c846f..1fcc8416fd


git log 99d98c846f9b..1fcc8416fd35 --date=short --no-merges --format='%ad %ae %s'
2019-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll AFDO from 74.0.3700.0_rc-r1 to 74.0.3701.0_rc-r1
2019-02-10 chrome-release-bot@chromium.org Updating trunk VERSION from 3701.0 to 3702.0
2019-02-10 bbudge@chromium.org [WebAssembly] Add "WebAssemblyCodeCache" to about_flags
2019-02-09 oshima@chromium.org Disable shadow and mask while rotating in tablet mode
2019-02-09 rockot@google.com Remove build support for JSON manifests
2019-02-09 acomminos@fb.com Add performance tests for isInputPending
2019-02-09 vtsyrklevich@chromium.org Add missing rename to chrome_crashpad_handler for code signing
2019-02-09 mtklein@chromium.org remove SK_LEGACY_SRGB_STAGE_CHOICE
2019-02-09 rockot@google.com Convert remaining JSON service manifests [part 7]
2019-02-09 thakis@chromium.org Fix -Wextra-semi warnings after USING_GARBAGE_COLLECTED_MIXIN(...).
2019-02-09 thakis@chromium.org Remove a few more semicolons.
2019-02-09 alancutter@chromium.org Make F6 focus location bar before tab strip
2019-02-09 raul@tambre.ee //mojo: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-09 edin@google.com Add ability to automatically refresh a menu created using MenuRunner's MenuModel-based constructor.
2019-02-09 fs@opera.com Optimize SVGSMILElement::AddInstanceTime


Created with:
  gclient setdep -r ../src@1fcc8416fd

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=stephana@google.com

Change-Id: I77393120e3a41131930c2badeab7838db5cdd6dd
Reviewed-on: https://skia-review.googlesource.com/c/190973
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-10 13:49:50 +00:00
skia-recreate-skps
475134f2de Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I1d4d30d055b801255f7ec6fae29eda1ccfc2ebb0
Reviewed-on: https://skia-review.googlesource.com/c/190992
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-02-10 08:45:29 +00:00
skia-recreate-skps
1e1bc8de56 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I29eefb089937c595c02232db5562a1d78ebb4878
Reviewed-on: https://skia-review.googlesource.com/c/190988
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-02-10 05:41:52 +00:00
Florin Malita
dafd65217b Reland "[skottie] Add drop shadow support"
This reverts commit 0b36acdad9.

Reason for revert: Cannot repro build failure - maybe flake?  Trying again.

Original change's description:
> Revert "[skottie] Add drop shadow support"
> 
> This reverts commit 1f43a4359d.
> 
> Reason for revert: Android build failures.
> 
> Original change's description:
> > [skottie] Add drop shadow support
> > 
> > Introduce the machinery required for general image filters in SkSG +
> > a concrete drop shadow image filter effect.
> > 
> > Wire it all up with Skottie to support drop-shadow layer effects.
> > 
> > Change-Id: I98e9669852f58ba6481439a7fda4a56ec6c59b8a
> > Reviewed-on: https://skia-review.googlesource.com/c/190426
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Florin Malita <fmalita@chromium.org>
> 
> TBR=fmalita@chromium.org,reed@google.com
> 
> Change-Id: I31d38ed4d4a15b77d1d1218b2677a891978332cb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/190981
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Florin Malita <fmalita@chromium.org>

TBR=fmalita@chromium.org,reed@google.com

Change-Id: Ic3f949f40ed4651715b6de906882f5f4522f91b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/191040
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-10 01:49:55 +00:00
Mike Klein
cd9ef731fe Mask -> M
Just trying to get things mostly under 100 cols.

Change-Id: Ifc8f4f0b78a89dfc5ba6ca2e310e969f1880e194
Reviewed-on: https://skia-review.googlesource.com/c/191001
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-09 19:11:18 +00:00
Florin Malita
0b36acdad9 Revert "[skottie] Add drop shadow support"
This reverts commit 1f43a4359d.

Reason for revert: Android build failures.

Original change's description:
> [skottie] Add drop shadow support
> 
> Introduce the machinery required for general image filters in SkSG +
> a concrete drop shadow image filter effect.
> 
> Wire it all up with Skottie to support drop-shadow layer effects.
> 
> Change-Id: I98e9669852f58ba6481439a7fda4a56ec6c59b8a
> Reviewed-on: https://skia-review.googlesource.com/c/190426
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Florin Malita <fmalita@chromium.org>

TBR=fmalita@chromium.org,reed@google.com

Change-Id: I31d38ed4d4a15b77d1d1218b2677a891978332cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/190981
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-09 14:41:40 +00:00
Florin Malita
1f43a4359d [skottie] Add drop shadow support
Introduce the machinery required for general image filters in SkSG +
a concrete drop shadow image filter effect.

Wire it all up with Skottie to support drop-shadow layer effects.

Change-Id: I98e9669852f58ba6481439a7fda4a56ec6c59b8a
Reviewed-on: https://skia-review.googlesource.com/c/190426
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-09 13:35:57 +00:00
skia-autoroll
89c7b4138d Roll ../src 3e6732ee4ac8..99d98c846f9b (360 commits)
3e6732ee4a..99d98c846f


git log 3e6732ee4ac8..99d98c846f9b --date=short --no-merges --format='%ad %ae %s'
2019-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll AFDO from 74.0.3699.0_rc-r1 to 74.0.3700.0_rc-r1
2019-02-09 huangdarwin@chromium.org Refactor: unsigned long long -> uint64_t in third_party/blink/renderer/modules/indexeddb
2019-02-09 michaelbai@chromium.org Revert "Add WebView UMA log package name to field trial testing config."
2019-02-09 raul@tambre.ee //url: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/webrtc 59ab1cf08196..e556768453ee (37 commits)
2019-02-09 abhijeet@igalia.com Remove unused header from save_card_bubble_views_browsertest.cc
2019-02-09 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal fafae1e432d9..4b2bf5b221a6 (2 commits)
2019-02-09 tinazwang@chromium.org [SendTabToSelf] Add additional requirements for displaying SendTab option on Desktop
2019-02-09 mbarowsky@chromium.org Add YUV constructor and implementations for FakePaintImageGenerator.
2019-02-09 agrieve@chromium.org Android: Fix colorama-related pydeps
2019-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/angle 75d577fbf801..abf6dbbb107b (1 commits)
2019-02-09 aee@chromium.org Settings WebUI: avoid updating knob position when page is not visible
2019-02-09 chrome-release-bot@chromium.org Updating trunk VERSION from 3700.0 to 3701.0
2019-02-09 vasilvv@chromium.org Factor out default proof verifier into QUIC platform.
2019-02-09 tbarzic@chromium.org Remove lock screen note code from login web UI
2019-02-09 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 7ecf0be48e58..fafae1e432d9 (8 commits)
2019-02-09 sunnyps@chromium.org Do not use decode swap chain for rotated videos
2019-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/pdfium 471510ee209e..27a3c7755b4d (1 commits)
2019-02-09 alemate@chromium.org Chrome OS: Remove unused login.js file.
2019-02-09 aee@chromium.org WebUI: FocusRowBehavior, remove the first control logic from
2019-02-09 karandeepb@chromium.org Mark activation-behavior.window.html layout test as flaky on Mac
2019-02-09 kainino@chromium.org Tighten suppressions of integer-cubemap-specification-order-bug.html
2019-02-09 ender@google.com Fix glitch with jumping status icon / url text on tablets.
2019-02-09 smcgruer@chromium.org Add target-sdk quirk for encoding '#'s in loadData
2019-02-09 hcarmona@chromium.org History: Delete unused icon set.
2019-02-09 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 295aca65583b..7ecf0be48e58 (6 commits)
2019-02-09 mrsuyi@google.com Add hit test for TabGridBottomToolbar in transparent layout.
2019-02-09 bsheedy@chromium.org Disable VR overflow menu pixel test
2019-02-09 wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com Import wpt@7179024d5dfb231073c7319948499d7e30f671cb
2019-02-09 chcunningham@chromium.org Roll src/third_party/ffmpeg/ 4b75b8bab..41268576a (2 commits)
2019-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/angle 2b0553ce59c3..75d577fbf801 (4 commits)
2019-02-09 jimmyxgong@google.com Add TryResolveUrl to SmbShareFinder
2019-02-09 nohle@google.com Add class to compute key proofs for CryptAuth v2 Enrollment
2019-02-09 mmenke@chromium.org Socket Pools Refactor 20: Make HttpProxyConnectJob use common parameters
2019-02-09 huayinz@chromium.org Add dummy theme to avoid breaking the bot
2019-02-09 kristipark@chromium.org [NTP] Dark mode browser tests
2019-02-09 javierrobles@chromium.org [iOS][MF] Return when the keyboard is not found
2019-02-09 ssid@chromium.org Remove thread check at UniqueProtoDatabase destructor
2019-02-09 jamescook@chromium.org Don't allow text selection in settings/changePicture image container
2019-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/pdfium 1ec1b5c17001..471510ee209e (1 commits)
2019-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia be39f713e530..706a7cd1e826 (4 commits)
2019-02-09 meacer@chromium.org Add proto pusher for the SSL error assistant component
2019-02-09 agl@chromium.org Fix |AuthenticatorSupportedOptions.user_presence_required|.
2019-02-09 nhiroki@chromium.org PlzWorker: Rename DedicatedWorkerFactory(Client) to DedicatedWorkerHostFactory(Client)
2019-02-09 martiniss@chromium.org Add headless tests to main trybots
2019-02-09 xingliu@chromium.org Android notification: Use ChromeNotification in NotificationManagerProxy.
2019-02-09 justincohen@google.com [ios] Revert slimnav back to disabled.
2019-02-09 martinkr@chromium.org fido: make register requests resolve on timeout when using the Win WebAuthn API
2019-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Fuchsia SDK from b28036ae4fcd to e9b630cce9b6
2019-02-09 vtsyrklevich@chromium.org Reland "Add GWP-ASan hook to macOS crashpad handler"
2019-02-09 donnd@chromium.org [TTS] Flags ownership and cleanup.
2019-02-09 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 to version 7.4.119.
2019-02-09 sebmarchand@chromium.org Don't report Optionals in the SystemObserver::SystemObserver callbacks
2019-02-09 vtsyrklevich@chromium.org Fix GWP-ASan include lints
2019-02-09 kdlee@chromium.org Correct variable name in GRIT's newgrd command.
2019-02-09 danyao@chromium.org [Payment Request] Add Web Platform Tests for hasEnrolledInstrument().
2019-02-09 aee@chromium.org WebUI: create cr-icon-button as paper-icon-button-light replacement
2019-02-09 mmenke@chromium.org Socket Pools Refactor 19: Move HttpProxyConnectJob to its own file.
2019-02-09 nektar@chromium.org Exposes get_SelectionRanges and SetSelectionRanges methods on Windows for working with arbitrary selection endpoints
2019-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/swiftshader 7fb0b73b1aa7..9686153413f3 (1 commits)
2019-02-09 vtsyrklevich@chromium.org Fix misc lints found by git cl lint
2019-02-09 mstensho@chromium.org Rename OverrideBlockPercentageResolutionSize.
2019-02-09 tommycli@chromium.org Omnibox: Add Remove Suggestion confirmation bubble
2019-02-09 sky@chromium.org chromeos: wires up WindowTree::SetTransform()
2019-02-09 rkjnsn@chromium.org Fix building with gcc_target_rpath.
2019-02-09 shaseley@chromium.org RC: Allow renderer-initiated freezing, as triggered by ChromeDriver
2019-02-09 rego@igalia.com [css-contain] Add perftest for Update Layer Tree issue
2019-02-09 mmenke@chromium.org Socket Pools Refactor 16 (4): Merge SSL pool with the SOCKS pools below it.
2019-02-09 penghuang@chromium.org Fix trace event problems with webview
2019-02-09 mukai@chromium.org hide dragged window when attaching
2019-02-09 raul@tambre.ee //cc: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-09 karandeepb@chromium.org Revert "Reenable NetworkContextConfigurationBrowserTests on ChromeOS."
2019-02-09 bingler@chromium.org Adding new unit tests for HttpCache's OpenEntry, CreateEntry, and DoomEntry.
2019-02-09 tommycli@chromium.org Omnibox: Add a context menu for suggestions (disabled by default)
2019-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia e59d40e0bcab..be39f713e530 (5 commits)
2019-02-09 mamir@chromium.org [Sync::USS] Add fieldtrial testing config for SyncUSSBookmarks
2019-02-09 johannes@chromium.org Roll inspector_protocol to e1991e6a66f0519e48e9e2c93efff15d62c3b2ca.
2019-02-09 alemate@chromium.org Chrome OS: Remove login_non_lock_shared / md_login_shared.
2019-02-09 yuweih@chromium.org Revert "Reland "Add remoting FTL API key""
2019-02-09 jortaylo@microsoft.com [Animation Worklet] Upstream web tests (related to setting values) to WPT
2019-02-09 karandeepb@chromium.org Disable flaky AutoLaunchedKioskTest.CrashRestore.
2019-02-08 collinbaker@chromium.org Animate in-product help app menu button highlight
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/angle f256339a1959..2b0553ce59c3 (2 commits)
2019-02-08 karandeepb@chromium.org Revert "Picture-in-Picture: move key methods into a service."
2019-02-08 xingliu@chromium.org Enable NotificationIntentInterceptorTest on certain version of Android.
2019-02-08 majidvp@chromium.org [animation-worklet] Basic pause implementation (reland)
2019-02-08 danan@chromium.org Record DemoMode.ActiveApp when ARC package name is delayed.
2019-02-08 jeffish@microsoft.com DevTools: Add DOMDebugger test
2019-02-08 tiborg@chromium.org Fix detection of UI language, measure Chrome resumes in wrong language
2019-02-08 khushalsagar@chromium.org cc: Fix unnecessary additional damage to layer from pending tiles.
2019-02-08 vtsyrklevich@chromium.org GWP-ASan: Silence unnecessary warnings
2019-02-08 raul@tambre.ee //testing: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-08 harringtond@chromium.org Fix crash in reportCompleteNotificationAction
2019-02-08 mdjones@chromium.org Add extra Y offset to toasts for duet
2019-02-08 raul@tambre.ee //storage: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-08 einbinder@chromium.org Devtools: Detach the old DevTools frontend when reloading
2019-02-08 cblume@chromium.org Move GL texture generation to representation
2019-02-08 einbinder@chromium.org DevTools: Make the dock side controller keyboard navigable
2019-02-08 agl@chromium.org Replicate |VirtualCtap2Device|'s UV behaviour to getAssertion.
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/pdfium 762247be1246..1ec1b5c17001 (32 commits)
2019-02-08 einbinder@chromium.org DevTools: Don't label top level completions as from the first prototype
2019-02-08 amaralp@chromium.org Tablet tabs should not have website themes
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/catapult d77957d206cc..8bfeef929cbe (3 commits)
2019-02-08 avi@chromium.org Add a description for --show-taps.
2019-02-08 amaralp@chromium.org Encapsulating MenuButton update badge visibility state
2019-02-08 npm@chromium.org Revert "[EventTiming] Ship First Input Timing on main frames"
2019-02-08 raul@tambre.ee //third_party/cacheinvalidation: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-08 raul@tambre.ee //chrome/browser/sessions: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-08 raul@tambre.ee //apps: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-08 jimmyxgong@google.com Add TickClock to SmbService
2019-02-08 kpaulhamus@chromium.org Disable caBLE on Linux by default, but keep enabled elsewhere.
2019-02-08 cblume@chromium.org Fix typo in string literal
2019-02-08 kenrb@chromium.org [RELAND] Add metrics for Bluetooth adapter availability
2019-02-08 xiaochengh@chromium.org Add test cases regarding caret movement and empty inline blocks
2019-02-08 yusufo@google.com Split TabGrid to components and start showing the toolbar
2019-02-08 danan@chromium.org Add enum ash::ShelfLaunchSource::LAUNCH_FROM_SHELF
2019-02-08 fdoray@chromium.org TaskScheduler: Entering WILL_BLOCK ScopedBlockingCall doesn't require AdjustMaxTasks().
2019-02-08 altimin@chromium.org [scheduler] Rename blink::background_scheduler to worker_pool
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/chromite 43ecc6793a5c..6b5dce060865 (1 commits)
2019-02-08 wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com Import wpt@7d5d8b89aba590b018d7ac402c233df89b42dcbd
2019-02-08 raul@tambre.ee //ppapi: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-08 raul@tambre.ee //ipc: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-08 ender@google.com Fix weather answer rendering on high density screens
2019-02-08 mcnee@chromium.org Use common enum definitions for GestureSourceType in web_tests
2019-02-08 kristipark@chromium.org [NTP] Fix console error on theme change for non-Google NTPs
2019-02-08 msarda@chromium.org [unified-consent] Remove AllGoogleServices pref.
2019-02-08 xiaochengh@chromium.org [BidiCaretAffinity] Skip certain contents in caret navigation
2019-02-08 jdonnelly@chromium.org [omnibox] Prefer entity suggestions, even if not allowed to be default.
2019-02-08 javierrobles@chromium.org [iOS][MF] Fix incognito mode
2019-02-08 yuweih@chromium.org Reland "Add remoting FTL API key"
2019-02-08 wutao@chromium.org Remove enable-settings-shortcut-search flag
2019-02-08 raul@tambre.ee //chrome/third_party/mozilla_security_manager: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-08 wez@chromium.org Roll Fuchsia SDK from 7f1a00721378 to b28036ae4fcd
2019-02-08 yigu@chromium.org [Animation Worklet] Fix unit test SelectGlobalScope
2019-02-08 seantopping@chromium.org Add CastContentWindow Set*Context methods
2019-02-08 wzang@chromium.org cros: Whitelist autotest_private_ext in public sessions
2019-02-08 karandeepb@chromium.org Mark some resolving-urls/query-encoding layout tests as failing.
2019-02-08 raul@tambre.ee //sql: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-08 mcnee@chromium.org Use gpuBenchmarking enum value definitions in web_tests
2019-02-08 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal de578cdd6b58..295aca65583b (2 commits)
2019-02-08 hcarmona@chromium.org Settings: Fall back to language only when locale is not found.
2019-02-08 mlamouri@chromium.org MediaLog: fold SeekEvent into TimeEvent.
2019-02-08 lukasza@chromium.org Drag-n-drop should use unique origin as initiator for navigations.
2019-02-08 sdefresne@chromium.org Remove deprecated override of RegisterListPref
2019-02-08 sdefresne@chromium.org Remove deprecated override of RegisterDictionaryPref
2019-02-08 huangs@chromium.org [Zucchini] ARM code: Add templated helpers to process ARM references.
2019-02-08 sreerenj.balachandran@intel.com media/gpu/vaapi: Add VP9 Encoder
2019-02-08 battre@chromium.org Remove initialization status checks
2019-02-08 iby@chromium.org Unit test for CrostiniPackageService
2019-02-08 rkgibson@google.com [iOS] Add search text vs url to search action widget
2019-02-08 davidben@chromium.org Remove timestamp check in NetInternalsTest.
2019-02-08 drubery@chromium.org Add metric tracking visual feature extraction time
2019-02-08 chfremer@chromium.org [Video Capture] Emit events when dropping frames in renderer-side stack
2019-02-08 rockot@google.com Fix missing dependency in noop manifest
2019-02-08 minch@google.com Add UMA for window drag in tablet mode.
2019-02-08 rkjnsn@chromium.org Apply Mac chooser takeaways to Linux chooser.
2019-02-08 wez@chromium.org [Fuchsia] Provide a base for fuchsia.modular.Agent implementations.
2019-02-08 grt@chromium.org Add "Google LLC" to the company whitelist.
2019-02-08 wangxianzhu@chromium.org [BlinkGenPropertyTrees] Don't crash on rare clip-escaping case
2019-02-08 bsheedy@chromium.org Ignore all RenderTest golden images
2019-02-08 lazyboy@chromium.org Extensions: Clean up some < operator definitions to use std::tie.
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia d6841487eb8e..e59d40e0bcab (4 commits)
2019-02-08 johntlee@chromium.org Extensions WebUI: Fix touch target of Extensions toggle row
2019-02-08 awolter@chromium.org Construct WebContentsObserver in browser main
2019-02-08 johntlee@chromium.org History WebUI: Fix focus outline on History item link
2019-02-08 klausw@chromium.org webxr-tests: add helper script to update tests in cloud bucket
2019-02-08 vtsyrklevich@chromium.org Add crashpad handler headless_browsertests rpath
2019-02-08 huayinz@chromium.org Add common colors in night- and some initial clean up on themes
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/SPIRV-Tools/src a0ff7c51200a..12b3d7e9d661 (1 commits)
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/angle 4103ceacac3e..f256339a1959 (2 commits)
2019-02-08 oksamyt@chromium.org [mojo][doc] Add blink-specific info
2019-02-08 zhongyi@chromium.org Make QuicStreamFactoryTest configurable via HttpNetworkSession::Params.
2019-02-08 nickdiego@igalia.com ozone/wayland: Fix wl_pointer::enter event handling
2019-02-08 msarda@chromium.org [unified-consent] Remove UnifiedConsentServiceClient.
2019-02-08 karandeepb@chromium.org Disable flaky SitePerProcessBrowserTest.PageScaleFactorPropagatesToOOPIFs.
2019-02-08 gab@chromium.org [base] Replace Interlock operations by std::atomic_bool in the Windows MessagePump.
2019-02-08 sky@chromium.org chromeos: fixes visibility of embed-roots
2019-02-08 lucmult@chromium.org [Files app] Convert to ES6 classes file file_table_list.js
2019-02-08 anastasi@google.com Add additional actions to Switch Access menu
2019-02-08 hansberry@chromium.org [MultiDevice] Do not treat connection latency timeout as failure.
2019-02-08 chouinard@chromium.org [Chromeshine] WebsiteEvents JNI bridge setup.
2019-02-08 bialpio@chromium.org Add InstallActivity to manifest, fix bug in ArCoreJavaUtils
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/catapult 22b1689dde6c..d77957d206cc (1 commits)
2019-02-08 awolter@chromium.org Replace WeakPtr with Unretained(this)
2019-02-08 lazyboy@chromium.org Make ProcessMap::Item non-copyable.
2019-02-08 martinkr@chromium.org fido: cancel pending authenticators while error UI is showing
2019-02-08 jennyz@chromium.org Fix the ChromeVox verbalization for zero state buttons.
2019-02-08 inglorion@chromium.org mark fakes used in gcp_unittests lto_visibility_public
2019-02-08 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 to version 7.4.118.
2019-02-08 baileyberro@chromium.org Catch preconfigured shares that do not match a presently known policy mode
2019-02-08 ayui@chromium.org Update PepperNetworkMonitorHost to use mojo GetNetworkList()
2019-02-08 dmblack@google.com Wires up mojom::AssistantNotification to AssistantNotificationView.
2019-02-08 npm@chromium.org Remove OriginalTimingAllowOrigin from ResourceTimingInfo
2019-02-08 wez@chromium.org [Chromoting] Cancel descriptor watch before closing X11 display.
2019-02-08 mastiz@chromium.org Dedup active DeviceInfo instances based on time
2019-02-08 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 78f6491898f6..de578cdd6b58 (3 commits)
2019-02-08 karandeepb@chromium.org Revert "android: Experiment setup for the reached code profiler."
2019-02-08 ellyjones@chromium.org flags: assign offline pages flags
2019-02-08 rogerta@chromium.org Revert "Add remoting FTL API key"
2019-02-08 ender@google.com Update font size and colors for new layout cards
2019-02-08 xiaochengh@chromium.org Remove duplicate lines from NeverFixTests
2019-02-08 malaykeshav@chromium.org Set SK_ColorTRANSPARENT on stale content layer to avoid flashing screen
2019-02-08 agl@chromium.org Flesh out |VirtualCtap2Device|'s makeCredential UV behaviour.
2019-02-08 beccahughes@chromium.org Update media session API documentation
2019-02-08 dfried@chromium.org Menus set AX indices based on traversal rules.
2019-02-08 mahmadi@chromium.org [iOS][Translate] HighlightButton for translate infobar language tab
2019-02-08 jimmyxgong@google.com Add UpdateSharePath to SmbService
2019-02-08 xhwang@chromium.org media: Use logging_override_if_enabled.h where applicable
2019-02-08 dtseng@chromium.org Fix ARC++ accessibility initial focus
2019-02-08 mamir@chromium.org [Sync::USS] Fix outgoing bookmarks names on modern clients
2019-02-08 tikuta@chromium.org update gitignore for /components/test/data/vr_browser_ui/render_tests
2019-02-08 kaznacheev@google.com Fix Chrome app re-install in app list
2019-02-08 akihiroota@chromium.org Add ChromeVox language switching test.
2019-02-08 agl@chromium.org device/fido: try again to fix OWNERS.
2019-02-08 mlamouri@chromium.org Screen Orientation: remove all JB code.
2019-02-08 crouleau@chromium.org Cleanup run_performance_tests.py's output files handling
2019-02-08 yoavweiss@chromium.org Add UMA to measure AppCache delay only on main frames
2019-02-08 thestig@chromium.org Use more URL constants in chrome/.
2019-02-08 rmcelrath@chromium.org Reenable NetworkContextConfigurationBrowserTests on ChromeOS.
2019-02-08 danakj@chromium.org Move WebLayerTreeView::SetRootLayer to WebWidgetClient. (1/n)
2019-02-08 harringtond@chromium.org Additional cleanup after removing MHTML cache control options
2019-02-08 rkaplow@chromium.org Renable UKM Incognito test.
2019-02-08 stevenjb@chromium.org Remove NetworkHandler dependencies from network_icon
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia a41c6858da8a..d6841487eb8e (4 commits)
2019-02-08 fdegans@chromium.org [Fuchsia] Add a //fuchsia/engine directory for the WebEngine.
2019-02-08 kdlee@chromium.org Localize media names in print preview.
2019-02-08 avi@chromium.org Ensure that all -1 flags have comments.
2019-02-08 raphael.kubo.da.costa@intel.com streams: IWYU for isfinite()
2019-02-08 sahel@chromium.org Update scroll expectations in wheel-and-touch-scroll-use-count.html
2019-02-08 stevenjb@chromium.org Update internet_detail_page.js for Polymer2
2019-02-08 alexclarke@chromium.org Simplify SequenceManager construction
2019-02-08 danakj@chromium.org Add a test that runs unload handlers without doing fast-shutdown.
2019-02-08 etiennep@chromium.org Reland "[Task Scheduler]: Merge blocking and non-blocking pools."
2019-02-08 twellington@chromium.org Enable multi-resume on Android
2019-02-08 corising@chromium.org Fix hover card bug for tabs with width less than pinned width.
2019-02-08 manukh@chromium.org [omnibox chrome:omnibox]: Use header tooltip when searching boolean properties.
2019-02-08 jdoerrie@chromium.org [base] Add const char* overloads for as_*cstr methods
2019-02-08 cliffsmo@microsoft.com The TabRestoreService doesn't get properly initialized on launch
2019-02-08 rouslan@chromium.org [Payment Request][WPT] Fix show() tests.
2019-02-08 rouslan@chromium.org [Payment Request][WPT] Fix abort() tests.
2019-02-08 sunnyps@chromium.org Do not use decode swap chain for downscaled video
2019-02-08 jianli@chromium.org Remove feature flag for offline-bookmarks
2019-02-08 smcgruer@chromium.org Revert "Roll src/third_party/perfetto 56445ec1e273..65ae74030114 (2 commits)"
2019-02-08 bbudge@chromium.org [code cache] Detect entry write error and remove entry.
2019-02-08 dmblack@google.com Reland "Adds AssistantNotificationView."
2019-02-08 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 to version 7.4.113.
2019-02-08 katie@chromium.org Adds existing Text-to-Speech owners to content/ TTS files after refactor.
2019-02-08 wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com Import wpt@4ec94cca5a27b65c5eb7ef3910a6a94c3b610597
2019-02-08 agl@chromium.org device/fido: workaround OWNERS parser issue.
2019-02-08 skym@chromium.org [Feed] Add pagination and ui config params.
2019-02-08 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal b1dbb0c6184f..78f6491898f6 (1 commits)
2019-02-08 danakj@chromium.org Move unload-related tests out of site_per_process_browsertest.cc
2019-02-08 fs@opera.com Use range-for loops in SVGSMILElement::ParseBeginOrEnd
2019-02-08 drubery@chromium.org Proto changes for sending the number of archived files to SB
2019-02-08 beccahughes@chromium.org Forward declare hash functions in Blink mojo
2019-02-08 ahemery@chromium.org Navigation: Adding StartWithParams to NavigationSimulatorImpl - 2/2
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/angle e03498f2d25a..4103ceacac3e (2 commits)
2019-02-08 mef@chromium.org [Cronet] Improve native url request code coverage.
2019-02-08 zmin@chromium.org Init MachineLevelUserCloudPolicyStore after enrollment failure.
2019-02-08 ldaguilar@chromium.org Implement UsageTimeStateNotifier::Observer in ScreenTimeController.
2019-02-08 beccahughes@chromium.org [Media Notification] Handle null session info
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/perfetto 56445ec1e273..65ae74030114 (2 commits)
2019-02-08 ntfschr@chromium.org AW: test for basic cookie functionality
2019-02-08 thestig@chromium.org Fix an incorrect variable name in pdf_viewer.js.
2019-02-08 nohle@google.com Add key creator class for CryptAuth v2 Enrollment
2019-02-08 buldina@chromium.org [ChromeDriver] Add logs to debug flaky test failure
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/SPIRV-Tools/src 10a7def6c03e..a0ff7c51200a (2 commits)
2019-02-08 jorgelo@google.com Fix broker process type.
2019-02-08 vasilvv@chromium.org Fix memory handling in QUIC server-side SNI processing.
2019-02-08 smaier@chromium.org Blocking on onDestroy to happen after ChromeActivityTestRule tests
2019-02-08 sammiequon@google.com overview: Moves all animations to ScopedOverviewAnimationSettings.
2019-02-08 ellyjones@chromium.org flags: add owner for enable-android-spellchecker
2019-02-08 mlamouri@chromium.org Picture-in-Picture: move key methods into a service.
2019-02-08 dtseng@chromium.org Announce auto complete changes
2019-02-08 manukh@chromium.org [omnibox]: Skip clipboard text classification for large text.
2019-02-08 rouslan@chromium.org [Payment Request][WPT] Fix canMakePayment() tests.
2019-02-08 cduvall@chromium.org Reland "Fix webRequest issues with redirects and extraHeaders listeners"
2019-02-08 etienneb@chromium.org Add detection of remote session to trace metadata
2019-02-08 raphael.kubo.da.costa@intel.com media::learning: Make LabelledExample's move assignment operator noexcept
2019-02-08 shivanisha@chromium.org New session command for removing a navigation entry from middle.
2019-02-08 thomasanderson@chromium.org Add sanity checks when setting work area for X11 displays
2019-02-08 yuweih@chromium.org Add remoting FTL API key
2019-02-08 vtsyrklevich@chromium.org Rename crashpad_handler to chrome_crashpad_handler for code signing
2019-02-08 vasilvv@chromium.org Use POSIX APIs directly in quic_client_test
2019-02-08 dtapuska@chromium.org Set owner and expiration for experimental web platform features
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia f2a3f5943e4c..a41c6858da8a (5 commits)
2019-02-08 ossu@chromium.org Log audio processing settings to WebRTC log
2019-02-08 rtoy@chromium.org Round up to the next render quantum for suspend
2019-02-08 amusbach@chromium.org split view: Set the tween type of the white bar animation to EASE_IN.
2019-02-08 ekaramad@chromium.org [ MimeHandlerView ] Clean-up unused declarations
2019-02-08 sahel@chromium.org Reland "Add AUTOSCROLL scroll input source."
2019-02-08 agrieve@chromium.org apk_operations.py: Add --sdk-version to build-bundle-apks
2019-02-08 vtsyrklevich@chromium.org Rename crashpad_handler to chrome_crashpad_handler
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/perfetto fc5de6a89d4e..56445ec1e273 (1 commits)
2019-02-08 lizeb@chromium.org blink/bindings: Enable background ParkableString compression by default.
2019-02-08 dougarnett@chromium.org Enables ResourceLoading preview by default on Android
2019-02-08 mario@igalia.com Implement a new AccountsCookieMutator, accessible from IdentityManager
2019-02-08 siggi@chromium.org RC: Move content browser client to performance_manager.
2019-02-08 danakj@chromium.org Disable flaky ProcessMemoryMetricsEmitterTest.FetchThreeTimes
2019-02-08 dtapuska@chromium.org Add use counter for querying the User Activation counts
2019-02-08 mlippautz@chromium.org Revert "DragController: Clear DragState in DragEnd"
2019-02-08 tienmai@chromium.org [GCPW] Fix some UI and password change bugs.
2019-02-08 fayang@chromium.org In QUIC, fix the places where assuming first received packet number is 1. Protected by gfe2_restart_flag_quic_enable_accept_random_ipn.
2019-02-08 szermatt@chromium.org [Autofill Assistant] Run Autofill Assistant in a normal tab.
2019-02-08 szermatt@chromium.org [Autofill Assistant] Shutdown Controller without help from UI.
2019-02-08 yukishiino@chromium.org v8binding: Fix CSSStyleDeclaration's indexed setter not to fallback
2019-02-08 seblalancette@chromium.org [AF] Fix Mexican immigration form detection.
2019-02-08 tienmai@chromium.org [GCPW] Minor code fixes based on Code review comments from Tricium and reviewer.
2019-02-08 xidachen@chromium.org Create a DispatchingImageProvider
2019-02-08 jinho.bang@samsung.com PaymentRequest: Make total member optional
2019-02-08 sdefresne@chromium.org Remove uses of deprecated RegisterListPref
2019-02-08 dpapad@chromium.org Settings: Fix race condition in MainPageBehavior.
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia e0c94a27a320..f2a3f5943e4c (2 commits)
2019-02-08 szermatt@chromium.org [Autofill Assistant] Make payment request a state in Controller.
2019-02-08 szermatt@chromium.org [Autofill Assistant] Fix bug in ShowProgressBarAction.
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/depot_tools 545f0d025ef1..610a4c6ce76c (1 commits)
2019-02-08 raul@tambre.ee //sandbox: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
2019-02-08 rayankans@chromium.org [Background Fetch] Fix flaky WP test that's timing out.
2019-02-08 mamir@chromium.org [Sync::USS] Fix bookmark duplication upon enabling sync
2019-02-08 agrieve@chromium.org Android: Fix library compression for chrome_modern_public_bundle
2019-02-08 tienmai@chromium.org [GCPW] Create base common gls runner unit test and added test utility functions
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/angle cd4f1fbaabce..e03498f2d25a (1 commits)
2019-02-08 battre@chromium.org Replace has_username_correction_vote_ with base::Optional
2019-02-08 dullweber@chromium.org Exclude Chrome app from hosted apps counter
2019-02-08 mastiz@chromium.org Remove test-only logic to filter out sync types
2019-02-08 brunoad@chromium.org Add initial Contained Home bridge implementation.
2019-02-08 hferreiro@igalia.com Port signin_browser_state_info_updater_unittest.mm to IdentityTestEnvironment
2019-02-08 hferreiro@igalia.com Remove SigninManagerFactory/PO2TSFactory deps from CustodianProfileDownloaderServiceFactory
2019-02-08 alessiob@chromium.org Reland "Reland "Reland "Add build file for PFFFT""" [reland^3]
2019-02-08 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 7b4aa52e2435..b1dbb0c6184f (5 commits)
2019-02-08 horo@chromium.org Introduce SignedExchangeReportingForDistributors feature flag
2019-02-08 battre@chromium.org Whitelist chrome://resources links in feedback reports
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll src/third_party/skia 44bffbfc1c3e..e0c94a27a320 (1 commits)
2019-02-08 noel@chromium.org Reland [image_decode_bench] Use //base CommandLine to process arguments
2019-02-08 fs@opera.com Fix typo in Document::RunPostLayoutTasks enumeration
2019-02-08 alexilin@chromium.org android: Experiment setup for the reached code profiler.
2019-02-08 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 to version 7.4.111.
2019-02-08 yangguo@chromium.org Remove -rpath-link ldflags
2019-02-08 sky@chromium.org chromeos: fix setting LocalSurfaceIdAllocations in the embedder
2019-02-08 sinhak@chromium.org Fix DCHECK failure in AccountReconcilor
2019-02-08 myid.shin@igalia.com [s13n] Move OAuth2TokenServiceDelegateAndroid into 'internals' target
2019-02-08 tonikitoo@igalia.com Implement IdentityManager::StartObservingCookieChanges API
2019-02-08 thomasanderson@chromium.org Fix gn build on 'Build From Tarball' bot
2019-02-08 chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Roll src-internal 7c539fa95b0a..7b4aa52e2435 (1 commits)
2019-02-08 jdoerrie@chromium.org [Passwords] Remove LoginPair from passwords_private.idl
2019-02-08 keishi@chromium.org Oilpan: Disable heap compaction for incremental marking
2019-02-08 dpapad@chromium.org Settings WebUI: Tweak logic that shows sync cancel dialog.
2019-02-08 andruud@chromium.org CSS Variables: Store a String representation of the base URL.
2019-02-08 nator@chromium.org [BackgroundSync] Use BackgroundTaskScheduler.
2019-02-08 toyoshim@chromium.org OOR-CORS: head.headers should be checked before calling response_code()
2019-02-08 thakis@chromium.org Reland "win: Always set strip_absolute_paths_from_debug_symbols, independent of goma."
2019-02-08 alessiob@chromium.org Revert "Reland "Reland "Add build file for PFFFT"""
2019-02-08 hferreiro@igalia.com Preserve the orginal behaviour of IdentityGetAccountsFunction::Run
2019-02-08 futhark@chromium.org Do not use LazyReattachIfAttached for NG bfc reattach.
2019-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll AFDO from 74.0.3698.0_rc-r1 to 74.0.3699.0_rc-r1
2019-02-08 alessiob@chromium.org Reland "Reland "Add build file for PFFFT""
2019-02-08 toyoshim@chromium.org OOR-CORS: Factory bound OriginAccessList interface for URLLoaderFactory
2019-02-08 hferreiro@igalia.com Make the PO2TSIOSDelegate optional in IdentityTestEnvironmentChromeBrowserStateAdaptor
2019-02-08 svillar@igalia.com Use PAATF in kWaitUntilAvailable mode in FamilyInfoFetcher
2019-02-08 skyostil@chromium.org content_browsertests: Ensure crash stack trace gets logged on Android


Created with:
  gclient setdep -r ../src@99d98c846f

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=fmalita@google.com

Change-Id: I1019e323b62f68f6a2003f668d5a1b52ac488629
Reviewed-on: https://skia-review.googlesource.com/c/190963
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-09 13:22:27 +00:00
Greg Kaiser
fe046de36b SkPathOpsTSect: Avoid null dereference in asserts
We just move the asserts to after our null checks.

Change-Id: I96c02ff9cb60ca3a052198b30f205dc78899acc6
Reviewed-on: https://skia-review.googlesource.com/c/190564
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-02-09 12:39:57 +00:00