reed
f46d8a6fff
increase inner-loop for xfer4 benches to reduce variance
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1653143004
TBR=
Review URL: https://codereview.chromium.org/1653143004
2016-02-02 09:27:35 -08:00
ethannicholas
30c5dde90d
support for more features when rendering to/from JSON
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662503003
Review URL: https://codereview.chromium.org/1662503003
2016-02-02 08:36:58 -08:00
Brian Salomon
2ea6ff7f0d
Fix printfs for Windows and undo speculative test disable
...
TBR=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662533002
Review URL: https://codereview.chromium.org/1662533002 .
2016-02-02 11:34:46 -05:00
yujieqin
22000d1f8e
Avoid too small reads to bufferMoreData()
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1644893003
Committed: https://skia.googlesource.com/skia/+/fd918e8c739065fa467cf6614181d3a2c5dcadcb
Review URL: https://codereview.chromium.org/1644893003
2016-02-02 08:09:07 -08:00
joshualitt
a341b90c7f
fix skiaserve crash
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1659703004
Review URL: https://codereview.chromium.org/1659703004
2016-02-02 07:37:21 -08:00
joshualitt
483b90140a
cleanup of skia serve url handling
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1653203002
Review URL: https://codereview.chromium.org/1653203002
2016-02-02 07:16:24 -08:00
ajuma
0735de67c8
Fix fuzzer-found deserialization bug in SkPathRef
...
This fixes a bug in SkPathRef::CreateFromBuffer found by
fuzzing SkPaintImageFilter.
BUG=582705
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1653003004
Review URL: https://codereview.chromium.org/1653003004
2016-02-02 06:14:47 -08:00
jcgregorio
2ac722f1f8
Revert of Avoid too small reads to bufferMoreData() (patchset #4 id:60001 of https://codereview.chromium.org/1644893003/ )
...
Reason for revert:
Crashed both Nexus 5s:
https://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release/builds/3355
https://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release/builds/3354
Original issue's description:
> Avoid too small reads to bufferMoreData()
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1644893003
>
> Committed: https://skia.googlesource.com/skia/+/fd918e8c739065fa467cf6614181d3a2c5dcadcb
TBR=msarett@google.com ,scroggo@google.com,yujieqin@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1656303002
2016-02-02 05:36:34 -08:00
yujieqin
fd918e8c73
Avoid too small reads to bufferMoreData()
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1644893003
Review URL: https://codereview.chromium.org/1644893003
2016-02-02 01:21:35 -08:00
Brian Salomon
be0fcb10f1
Speculative fix for windows builders
...
TBR=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1651303002
Review URL: https://codereview.chromium.org/1651303002 .
2016-02-01 18:41:58 -05:00
Brian Salomon
a64afd6680
Disable test that is breaking Android and Windows bots.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1654283002
BUG=skia:
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/1654283002 .
2016-02-01 16:44:22 -05:00
bsalomon
f267c1efe7
Add ability to extract YUV planes from SkImage
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1513393002
Review URL: https://codereview.chromium.org/1513393002
2016-02-01 13:16:14 -08:00
bsalomon
9d02b264b7
Fix GL readback code to handle rowbytes correctly for non-32bit formats
...
Update tests to exercise more rowbytes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1645043006
Review URL: https://codereview.chromium.org/1645043006
2016-02-01 12:49:30 -08:00
mtklein
b21c752eb3
Look beyond SSE2 for Paeth
...
You can break this CL down into three steps. Steps 2 and 3 depend on 1.
Step 1: go to a 16-bit impl. Speed ~unaffected.
Step 2: use SSSE3 16-bit abs. ~20% speedup to Paeth.
Step 3: use SSE4.1 blendv, total ~25% speedup to Paeth.
Overall this can improve PNG decoding by around 8% end-to-end.
I would feel most comfortable landing this only after we have a bot exercising the SSE4.1 code, either by moving this stuff behind a function pointer (simulating Chrome/Clank) or by adding a builder with at least SSE4.1 at compile time (simulating an Android system build). We've got plenty of bots building with SSSE3 at compile time to test that path.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dimage&master=false&issue=1657503002
Review URL: https://codereview.chromium.org/1657503002
2016-02-01 12:20:33 -08:00
bsalomon
8610002ff8
Move SkColorMatrixFilter implementation to core.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1648933002
Review URL: https://codereview.chromium.org/1648933002
2016-02-01 12:09:07 -08:00
ethannicholas
3b7af78e81
added a default constructor for GrBatchToXPOverrides
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657803002
Review URL: https://codereview.chromium.org/1657803002
2016-02-01 11:45:45 -08:00
senorblanco
6404981b0c
Fix zero-sized blur with crop rect.
...
Neither the GPU nor CPU paths were correctly handling the crop rect
in this case.
NOTE: this change adds a new test case to the imageblurcropped GM, so
it will have to be rebaselined.
BUG=skia:4876
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657773002
Review URL: https://codereview.chromium.org/1657773002
2016-02-01 10:32:42 -08:00
rmistry
0575c495bc
Upload SKPs to chrome-partner-telemetry
...
Context:
https://bugs.chromium.org/p/skia/issues/detail?id=3751#c4
and
https://bugs.chromium.org/p/skia/issues/detail?id=3751#c6
BUG=skia:3751
# Trybots do not run this code.
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1658653002
Review URL: https://codereview.chromium.org/1658653002
2016-02-01 10:27:05 -08:00
fmalita
40bed64ff0
SkPictureShader cleanup
...
Minor cleanup following http://crrev.com/1405103003 .
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1652943002
Review URL: https://codereview.chromium.org/1652943002
2016-02-01 09:19:49 -08:00
benjaminwagner
b1fe8f6f6f
Add dm to DM_INCLUDES to fix Google3 build.
...
It seems that #including a file in the same directory works without the directory being in INCLUDES, but https://codereview.chromium.org/1631053003 #included DMGpuSupport.h from a test.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657703002
Review URL: https://codereview.chromium.org/1657703002
2016-02-01 09:05:08 -08:00
kjlubick
47d158eb3c
Make fuzz broadcast when it terminates via return.
...
This helps analysis figure out things like timeouts and unexpected, uncaught
exits.
TBR=mtkelin@google.com
BUG=skia:4438
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657743002
Review URL: https://codereview.chromium.org/1657743002
2016-02-01 08:23:50 -08:00
ethannicholas
975765c60a
fix for GrPorterDuffTest valgrind error
...
BUG=skia:4875
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1656873002
Review URL: https://codereview.chromium.org/1656873002
2016-02-01 08:07:39 -08:00
msarett
13a9123548
A variety of SkPngCodec clean-ups
...
(1) Remove #ifdefs that extend support to > 1.2.
Using nullptr everywhere should work on all versions.
(2) Use png_get_valid(tRNS) to check for transparency
It does the same thing we were doing previously in less
work.
(3) Remove image size check
Clients allocate their own memory, and they have the option
to perform scaled and partial decodes. So we don't need
to arbitrarily fail on large images.
(4) Remove FIXME for subsitute trans color
libpng is already doing this for us.
(5) Remove #ifdef PNG_READ_PACK_SUPPORTED
We don't have a fallback, so we'll fail to compile if this
isn't supported.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643623004
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1643623004
2016-02-01 08:03:29 -08:00
xidachen
2352696313
Replace the id<-->key hashmap in SkImageFilter by a SkTArray
...
In the current implementation, SkImageFilter::Cache maintains a hash map
that maps SkImageFilter's uniqueID to an array of keys, and its purpose
is to remove the values in Cache that are associated with this array of
keys that are indexed by uniqueID. However, maintaining this hash map
causes perf regression to smoothness.tough_filters_cases.
This CL removes the id<-->key hashmap. Instead, we maintain an array of
keys in SkImageFilter. Whenever there is a new key, we push it into the
array. In ~SkImageFilter(), we call Cache::purgeByKeys to remove all the
values that are associated with the keys that are maintained by SkImageFilter.
BUG=571655
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1651433002
Review URL: https://codereview.chromium.org/1651433002
2016-02-01 05:27:16 -08:00
robertphillips
188d44c549
Move SkPixelXorXfermode.h to include/client/android
...
This intended to make clients aware that the SkPixelXorXfermode is Android-specific
This needs to land after the Chromium CL https://codereview.chromium.org/1647953006/ (Add include/client/android to skia .gn & .gypi files)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1645093002
Committed: https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614
Review URL: https://codereview.chromium.org/1645093002
2016-02-01 04:54:15 -08:00
fmalita
d2a4271c75
Fix S32_D32_constX_shaderproc assert
...
After https://crrev.com/1642273002 , fFilterOneY includes a rounding bias
which is not accounted for in the debug-mode S32_D32_constX_shaderproc
check.
Update the S32_D32_constX_shaderproc assert to use the (biased)
SkBitmapProcStateAutoMapper utility.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1655823002
R=reed@google.com
BUG=skia:4874
Review URL: https://codereview.chromium.org/1655823002
2016-02-01 04:48:39 -08:00
caryclark
2baa84b7ba
batch merge new edges
...
Find where newly introduced edges go in the edge list once,
then stitch all of them into the edge list.
R=reed@google.com
BUG=573166
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1647223002
Committed: https://skia.googlesource.com/skia/+/ae658e15477df86d1a864feb48d0274af2784f40
Review URL: https://codereview.chromium.org/1647223002
2016-02-01 04:34:58 -08:00
fmalita
bef1adfb56
Suppress SkBitmapProcState assert temporarily
...
TBR=jcgregorio@google.com ,reed@google.com
BUG=skia:4874
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1658573002
Review URL: https://codereview.chromium.org/1658573002
2016-02-01 03:20:27 -08:00
yujieqin
86e6b55b7c
Only define NO_POSIX_MEMALIGN for arm
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1647893003
Review URL: https://codereview.chromium.org/1647893003
2016-02-01 02:56:40 -08:00
fmalita
1b46a57365
Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShader
...
Use an SkImage generator/shader instead.
R=reed@google.com
Committed: https://skia.googlesource.com/skia/+/fa694ad067976a5b713eec0b6f92ba5efeb0aa9d
Review URL: https://codereview.chromium.org/1405103003
2016-02-01 02:34:03 -08:00
mtklein
507ef6d681
SkNx Load/store: take any pointer.
...
This means we can remove a lot of explicit casts in code that uses SkNx.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1650653002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1650653002
2016-01-31 08:02:47 -08:00
update-skps
b1c32b7bde
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1651803002
Review URL: https://codereview.chromium.org/1651803002
2016-01-31 00:30:55 -08:00
fmalita
8a8eb5242b
Remove SkBitmapProcStateAutoMapper's overflow check
...
(follow-up to https://codereview.chromium.org/1642273002 )
Add an optional SkPoint outparam, and relocate the overflow check to
the only client which needs it.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1650403002
Review URL: https://codereview.chromium.org/1650403002
2016-01-30 18:56:34 -08:00
reed
395eabeb0e
float components in xfermodes
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1623483002
TBR=mtklein
Review URL: https://codereview.chromium.org/1634273002
2016-01-30 18:52:31 -08:00
caryclark
afd25f703d
combine vertical overlapping edges
...
Paths outside clips, and sometimes paths inside clips, devolve
to multiple adjacent or overlapping vertical edges. Combine
these edges when possible to reduce the overall edge count.
R=reed@google.com
BUG=573166
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1654433002
Review URL: https://codereview.chromium.org/1654433002
2016-01-30 14:07:20 -08:00
msarett
02a6bfaaaa
Revert of batch merge new edges (patchset #1 id:1 of https://codereview.chromium.org/1647223002/ )
...
Reason for revert:
Breaks the roll.
Original issue's description:
> batch merge new edges
>
> Find where newly introduced edges go in the edge list once,
> then stitch all of them into the edge list.
>
> R=reed@google.com
> BUG=573166
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1647223002
>
> Committed: https://skia.googlesource.com/skia/+/ae658e15477df86d1a864feb48d0274af2784f40
TBR=reed@google.com ,caryclark@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=573166
Review URL: https://codereview.chromium.org/1654593002
2016-01-30 10:16:31 -08:00
caryclark
70e6d6074a
add new tests
...
These tests are for upcoming changes to optimize
the path edge list.
TBR=reed@google.com
BUG=573166
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1651573002
Review URL: https://codereview.chromium.org/1651573002
2016-01-30 10:11:21 -08:00
fmalita
653c12d773
Add sampler bias for the nofilter/translate specializations
...
Convert SkBitmapProcState::setupForTranslate() to use
SkBitmapProcStateAutoMapper. This adds bias for the translate procs:
Clamp_S32_D32_nofilter_trans_shaderproc,
Repeat_S32_D32_nofilter_trans_shaderproc
Since the original impl checks for int overflow, extend
SkBitmapProcStateAutoMapper to detect this condition.
BUG=chromium:581870
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1642273002
Review URL: https://codereview.chromium.org/1642273002
2016-01-30 10:06:46 -08:00
scroggo
e645965a7c
Use proper row step in SkRawCodec
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643373002
Review URL: https://codereview.chromium.org/1643373002
2016-01-30 10:06:11 -08:00
bsalomon
8e74f80ca1
Add SkImage factory method that forces image to be resolved to a texture.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1631053003
Review URL: https://codereview.chromium.org/1631053003
2016-01-30 10:01:40 -08:00
reed
9cd016e9b6
allow the caller to specified raster-surface rowbytes.
...
along the way, simplify how we copy the surface's bitmap
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643873002
Review URL: https://codereview.chromium.org/1643873002
2016-01-30 10:01:06 -08:00
caryclark
ae658e1547
batch merge new edges
...
Find where newly introduced edges go in the edge list once,
then stitch all of them into the edge list.
R=reed@google.com
BUG=573166
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1647223002
Review URL: https://codereview.chromium.org/1647223002
2016-01-30 09:59:18 -08:00
ethannicholas
2279325d53
added support for PLS path rendering
...
BUG=skia:3555
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1541903002
Committed: https://skia.googlesource.com/skia/+/7df3f5e127f8016d17b637cc48a6a4718f1a6822
Review URL: https://codereview.chromium.org/1541903002
2016-01-30 09:59:10 -08:00
scroggo
ad38ed6003
Revert of Treat bad values passed to --images as a fatal error (patchset #17 id:320001 of https://codereview.chromium.org/1611323004/ )
...
Reason for revert:
Speculative to fix windows bots
Original issue's description:
> Treat bad values passed to --images as a fatal error
>
> If an option is passed to --images that is either a non-existent path or
> a folder with no images matching the supported types, assume this is
> an error and exit, so they can supply a valid path instead.
>
> Share code between DM and nanobench in SkCommonFlags.
>
> nanobench now behaves more like DM - it will check a directory for
> images that match the supported extensions.
>
> Only consider image paths ending in RAW suffixes as images if
> SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure
> to decode errors on platforms that cannot decode it.
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004
>
> Committed: https://skia.googlesource.com/skia/+/7579786f3bd5a8fda84a1abc45b16213c3371f93
TBR=mtklein@google.com ,borenet@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/1653543002
2016-01-29 14:41:55 -08:00
scroggo
e82a6c7e71
Revert of Update SK_IMAGE_VERSION to test RAW (patchset #1 id:1 of https://codereview.chromium.org/1612113002/ )
...
Reason for revert:
https://skia.googlesource.com/skia/+/7579786f3bd5a8fda84a1abc45b16213c3371f93 seems to have caused problems, but it allows us to test RAW. In order to reland this, we'll need to reland that one, or have a simpler fix to disable RAW on platforms where it's not supported (e.g. ChromeOS)
Original issue's description:
> Update SK_IMAGE_VERSION to test RAW
>
> Once https://codereview.chromium.org/1520403003/ lands, we can start
> testing RAW images. I have already added RAW images to a folder named
> v2/; this updates the version so the script (once written) will check
> the new version.
>
> Depends on skbug.com/4558
>
> BUG=skia:4829
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612113002
>
> Committed: https://skia.googlesource.com/skia/+/317a45e879889f9ed876549a10bbfd51aab41b45
TBR=borenet@google.com ,msarett@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4829
Review URL: https://codereview.chromium.org/1651603004
2016-01-29 14:32:32 -08:00
caryclark
703348f5fa
fix teeny dashed path bug
...
If the path dashed is sufficiently small, there may be no
segments generated to dash. Check for an empty segment list.
R=reed@google.com
BUG=skia:4871
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1645613006
Review URL: https://codereview.chromium.org/1645613006
2016-01-29 09:54:20 -08:00
djsollen
f2b340fc88
Consolidate SK_CRASH and sk_throw into SK_ABORT
...
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1648343003
Review URL: https://codereview.chromium.org/1648343003
2016-01-29 08:51:04 -08:00
robertphillips
2a1d401bf2
Move SkAvoidXfermode over from Android
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1649503002
Review URL: https://codereview.chromium.org/1649503002
2016-01-29 08:44:17 -08:00
ethannicholas
c05f7c3d57
fix for skiaserve build error
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1651443002
TBR=jcgregorio@google.com
Review URL: https://codereview.chromium.org/1651443002
2016-01-29 08:02:34 -08:00
scroggo
4d9eaea174
Print a message when DM finishes
...
When running from the command line, it is obvious when DM finishes,
since it brings the prompt back up. But in XCode, it just sits
there, so my glance doesn't let me know that it's finished. Make
it more obvious that DM is done.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1650113002
Review URL: https://codereview.chromium.org/1650113002
2016-01-29 07:48:33 -08:00