Commit Graph

48290 Commits

Author SHA1 Message Date
Chris Dalton
f6bf516926 Reland "Add an implementation and log2 variants for Wang's formula"
This is a reland of e278e1c1c7

Original change's description:
> Add an implementation and log2 variants for Wang's formula
>
> Wang's formulas for cubics and quadratics (1985) tell us how many line
> segments a curve must be chopped into when tessellating. This CL adds
> an implementation along with optimized log2 variants, as well as tests
> and a benchmark.
>
> Change-Id: I3f777b8d0312c57c3a1cc24307de5945c70be287
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288321
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>

TBR=bsalomon@google.com

Change-Id: Ie3822c62439fc579a59ea8adb49583224de41aa5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289680
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-05-14 02:57:59 +00:00
Mike Klein
e253a7c183 not all bots have env
That's okay, that's really just me being pedantic anyway.

Change-Id: I45a0f6b4866daff752169304da171c223016cac8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289685
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-05-14 02:02:18 +00:00
Chris Dalton
7156db2602 Revert "Update GrTriangulator to use SkPathPriv::Iterate"
This reverts commit 64964bb115.

Reason for revert: Iter does not behave the same as RawIter

Original change's description:
> Update GrTriangulator to use SkPathPriv::Iterate
> 
> Change-Id: I0998f22e3ce958fd651c359c930a2e48af27ce73
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285985
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,csmartdalton@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I3387f95a966d18d2262c1a6b534c61c46e4a8b4c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288662
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-05-14 01:12:08 +00:00
Chris Dalton
2f2d81c434 Fix tessellation benchmarks to not allocate new data every iteration
Change-Id: I86bb6f2690ad349e640ea997e0b71387613ebffb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289460
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2020-05-14 00:28:43 +00:00
Greg Daniel
dbe7770afc Blacklist failing vulkan test on s20.
Bug: skia:10247
Change-Id: I127509e8370f84e4fc40003232a93bb079e85576
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289630
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-05-13 23:11:53 +00:00
Mike Klein
be72c44ec3 S20 vk?
- add back recently removed jobs
 - cp /vendor/lib64/egl/libGLES_mali.so to /data/local/tmp/libvulkan.so
 - use LD_LIBRARY_PATH to prefer libs in /data/local/tmp

Bug: skia:10184
Change-Id: I52524819c60abab1334c04530a7b13f0519db463
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289636
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-05-13 22:23:43 +00:00
Mike Klein
6c3db04c8b Revert "Add an implementation and log2 variants for Wang's formula"
This reverts commit e278e1c1c7.

Reason for revert: i think we need to do that add with an unsigned, or test instead of always += (1<<23)-1.

Original change's description:
> Add an implementation and log2 variants for Wang's formula
> 
> Wang's formulas for cubics and quadratics (1985) tell us how many line
> segments a curve must be chopped into when tessellating. This CL adds
> an implementation along with optimized log2 variants, as well as tests
> and a benchmark.
> 
> Change-Id: I3f777b8d0312c57c3a1cc24307de5945c70be287
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288321
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Chris Dalton <csmartdalton@google.com>

TBR=bsalomon@google.com,brianosman@google.com,csmartdalton@google.com

Change-Id: I24dfd8549054b632f38f7b05b4d857b640cf5cd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289658
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-05-13 22:10:47 +00:00
Greg Daniel
b2365d81d0 Reland "Reland "Add api on GrContext to update the data of GrBackendTextures.""
This reverts commit ed219fe171.

Reason for revert: relanding with fix

Original change's description:
> Revert "Reland "Add api on GrContext to update the data of GrBackendTextures.""
> 
> This reverts commit 83c6626946.
> 
> Reason for revert: technospark is failing to upload pixmaps to non base mip levels
> 
> Original change's description:
> > Reland "Add api on GrContext to update the data of GrBackendTextures."
> > 
> > This reverts commit 93ca54e0ac.
> > 
> > Reason for revert: relanding with fix
> > 
> > Original change's description:
> > > Revert "Add api on GrContext to update the data of GrBackendTextures."
> > > 
> > > This reverts commit ac09f7cd7a.
> > > 
> > > Reason for revert: breaking bots, may need to use swizzled color for
> > > correctness test
> > > 
> > > Original change's description:
> > > > Add api on GrContext to update the data of GrBackendTextures.
> > > > 
> > > > Change-Id: I680f12bf58fc7b66a6b2f3fa4c4723ae84d3f949
> > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288555
> > > > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > > > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > > 
> > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com
> > > 
> > > Change-Id: I47f41f536619ac13ca3ceeb216e7eaed9a9af255
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288630
> > > Reviewed-by: Greg Daniel <egdaniel@google.com>
> > > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > 
> > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com
> > 
> > # Not skipping CQ checks because this is a reland.
> > 
> > Change-Id: I82283b2437e523b80acead71c5f7c651180620db
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288631
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> 
> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com
> 
> Change-Id: I5d6614db8db59a69ded511726507a186596cfbd4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288907
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com

# Not skipping CQ checks because this is a reland.

Change-Id: I35fa1ae7dc47a697bbc358655f5c821942033234
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288909
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-05-13 21:49:25 +00:00
Stephen White
7a02614cba Make staging manager lists private to GrGpu.
Use const accessors for iterating.
Move platform-indepenent work to GrGpu::disconnect().

Change-Id: I0acabb5b5fd27ddb47f4051f956ce8130174a8d0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/282267
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-05-13 21:47:19 +00:00
Greg Daniel
7bd13c2bd1 Pass externally synchronizaed flag to vulkan memory allocator.
Change-Id: Iea561e5105ff46eda8fafe89b068bca6e7d1a523
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289621
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-05-13 21:44:43 +00:00
Chris Dalton
e278e1c1c7 Add an implementation and log2 variants for Wang's formula
Wang's formulas for cubics and quadratics (1985) tell us how many line
segments a curve must be chopped into when tessellating. This CL adds
an implementation along with optimized log2 variants, as well as tests
and a benchmark.

Change-Id: I3f777b8d0312c57c3a1cc24307de5945c70be287
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288321
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-05-13 21:39:24 +00:00
Adlai Holler
dcfb233858 Enable kernel caching in GrMatrixConvolutionEffect
Bug: skia:10233
Change-Id: I7a68cbb44c786a113c0f324e21ed963e8f47f382
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289492
Auto-Submit: Adlai Holler <adlai@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-05-13 19:51:13 +00:00
Brian Salomon
1908bb8e3a Add workaround for TecnoSpark 3 Pro MIP mapping
Change-Id: Ic882fce33fcb005c26c9746c6affdd7b92bcd559
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289482
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-05-13 19:20:33 +00:00
Greg Daniel
5ab94e1ae6 Add GrContext getter to SkSurface.
Currently this is possible by getting the canvas off of surface and then
getting the context off of the canvas. However, if in the future we wanted
a surface that didn't have a canvas (maybe something that looked like a
mutible image that only had a writePixels call), this would allow us to
still get the GrContext.

Bug: skia:10118
Change-Id: Ie8504bb708c1e4532edc8c7832ead86ae711e237
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289479
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-05-13 19:09:05 +00:00
Michael Ludwig
c002d5619e Simplify GrClip::getConservativeBounds() signature
It turns out no one was using the intersection of rect functionality on
GrClip, and this helps simplify what the new clip stack needs to define.

Bug: skia:10205
Change-Id: If85a0c744dd68a8ad2f380b54a539ac74850e4ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289440
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-05-13 18:59:13 +00:00
Brian Osman
7190399725 SkRuntimeEffect: Support late bound uniforms in raster
Supports marked matrices and srgb_unpremul colors

Change-Id: Icabd329758ac0a12ee323d73724d68c7927106c3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289242
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-05-13 18:52:23 +00:00
Greg Daniel
da50cb84a4 A flush and submit apis to public headers.
We add a new flushAndSubmit() to replace the current flush() call. In
the future all other flush(GrFlushInfo) type calls will not do a
submission of work to the GPU. Instead an explicit submit call will have
to be made. flushAndSubmit will do a flush and submit.

Also adds a no-op submit call. This allows us to stage the flush submit
changes by updating all clients that use non simple flushes to add
a submit call immediately after each flush. Then we can change the logic
of where the submission happens from flush to submit without breaking
folks.

Bug: skia:10118
Change-Id: I4f02189a21912d52b888597c7734b4ca0baee792
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289478
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-05-13 18:43:54 +00:00
Eric Boren
3101370f0b [infra] chrome_release_branch: maintain the last 3 branches
Change-Id: I2402394fa02d2e2e0957fe55e7c9088ddfeffcc2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289483
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2020-05-13 18:13:13 +00:00
Brian Osman
9aaec36e45 Plumbing SkMatrixProvider into the raster backend
Change-Id: Ic5786b995fdb439871f2e3ab94cd07a945de19af
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288776
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2020-05-13 18:05:32 +00:00
Chris Dalton
b8d7e00098 Move makeDraw(Indexed)IndirectSpace into GrMeshDrawOp::Target
Change-Id: I9e7e483d2baf24c8c87f22b9658969b9dbed72f9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289458
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-05-13 17:52:51 +00:00
Herb Derby
537dc05d41 Fix SkSpan supspan() add test
Change-Id: Ida683aa054fef977b91b3232b063f74344ffc2c9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289448
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2020-05-13 16:51:31 +00:00
Ben Wagner
0c228e3f64 Add ahem.ttf.
This font comes up fairly often due to being included as a primary font
in css testing. There are several Paragraph samples which already assume
it is present at this location. It is fairly small and very liberally
licensed.

This font file is ahem.ttf from
https://www.w3.org/Style/CSS/Test/Fonts/Ahem/ .

Change-Id: I6fdcb036cecca66e725ecb30e0a07fef1dfb1cdf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289445
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2020-05-13 16:32:52 +00:00
Ben Wagner
056d543c91 Put Paragraph SkDebugf behind runtime flag.
Adds the verboseParagraph command line flag to Paragraph samples so that
the informative SkDebugf calls are not made during normal execution.

Also put everything possible into the anonymous namespace.

Change-Id: Idaeb6845e2d8f322fdd0b988441f092d276ffbf1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289441
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Julia Lavrova <jlavrova@google.com>
2020-05-13 15:38:21 +00:00
Julia Lavrova
68d1433145 Fixing minor bugs: ellipsis on justified text
Change-Id: Ic0ebf53b221defa5d07ba2832666b322a2629547
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289020
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Julia Lavrova <jlavrova@google.com>
2020-05-13 14:59:21 +00:00
Adlai Holler
25dc7ca1f3 In SkTaskGroup, move the function in case it has heap-allocated storage
Change-Id: Iba79ed5d5116e2e3966e55f674249fa84636fe45
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289436
Auto-Submit: Adlai Holler <adlai@google.com>
Commit-Queue: Adlai Holler <adlai@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2020-05-13 13:43:51 +00:00
Greg Daniel
2f62abdbe9 Update AMD vulkan memory allocator.
Change-Id: I2ed449cdbb8beac24fbd9d9664ab5fc42a0b3e00
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289236
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-05-13 13:03:39 +00:00
skia-recreate-skps
b342415570 Update Go Deps
Change-Id: I0b8f7f191949e9cfd05f0f85b85e12fc420cf6da
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289359
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-05-13 05:29:46 +00:00
skia-autoroll
d76d01a5b2 Roll third_party/externals/angle2 9823d86a5a40..3b82fdcf1c83 (14 commits)
9823d86a5a..3b82fdcf1c

git log 9823d86a5a40..3b82fdcf1c83 --date=short --first-parent --format='%ad %ae %s'
2020-05-13 timvp@google.com Revert "Add support for GL_CHROMIUM_texture_filtering"
2020-05-13 ianelliott@google.com Vulkan: Rename SurfaceRotationType to SurfaceRotation
2020-05-12 spang@chromium.org Revert "Vulkan: Add semaphores test to VulkanExternalImageTest"
2020-05-12 jmadill@chromium.org Vulkan: Add immediate scissored clears.
2020-05-12 spang@chromium.org Vulkan: Add semaphores test to VulkanExternalImageTest
2020-05-12 spang@chromium.org Enable validation layers in VulkanExternalHelper
2020-05-12 shrekshao@google.com Fix GetBooleani_v validation and params length for WebGL OES_draw_buffers_indexed
2020-05-12 geofflang@google.com GL: Use a valid internal format for CopyTexImage in BlitGL::blitColorBufferWithShader
2020-05-12 ianelliott@google.com Vulkan: Enhance ReadPixels to deal with pre-rotation
2020-05-12 lexa.knyazev@gmail.com Skip indexed clears on disabled draw buffers
2020-05-12 xinyi.he@arm.com Vulkan: Set maxShaderImageUniforms zero on some Mali GPUs
2020-05-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src bb279b9f0bda..fe0b6a61d732 (5 commits)
2020-05-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src b5f003d7a3ec..55f9d97f3b1e (2 commits)
2020-05-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 7b87548e5a63..d9ba4b7dd30b (1 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@3b82fdcf1c83

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: jlavrova@google.com
Change-Id: I8e2e6db4c5c6b32ed6cd58ae10f166484467b265
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289338
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-13 05:24:51 +00:00
skia-autoroll
d127e02fb6 Roll third_party/externals/swiftshader d9ba4b7dd30b..64da65bd1bd5 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d9ba4b7dd30b..64da65bd1bd5

git log d9ba4b7dd30b..64da65bd1bd5 --date=short --first-parent --format='%ad %ae %s'
2020-05-13 sugoi@google.com Fix sRGB color clear

Created with:
  gclient setdep -r third_party/externals/swiftshader@64da65bd1bd5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: jlavrova@google.com
Change-Id: Ia24b5f486536c4c2914726a65772e7ae7e586c86
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289339
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-13 05:24:41 +00:00
skia-autoroll
106f7c1e25 Roll ../src 63c884f8e9c5..e334ec41436b (468 commits)
63c884f8e9..e334ec4143


Created with:
  gclient setdep -r ../src@e334ec4143

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: jlavrova@google.com
Change-Id: Iaf786e5d9ee3936d98dea20c177149d352e038cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289336
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-13 05:03:21 +00:00
skia-autoroll
3ebadcc98e Roll third_party/externals/dawn 02beecaec5cd..f4df7916cacb (4 commits)
https://dawn.googlesource.com/dawn.git/+log/02beecaec5cd..f4df7916cacb

git log 02beecaec5cd..f4df7916cacb --date=short --first-parent --format='%ad %ae %s'
2020-05-13 jiawei.shao@intel.com Add validation on the buffer-to-buffer copies within same buffer
2020-05-12 enga@chromium.org Sort same-type bindings in the BGL by binding number
2020-05-12 cwallez@chromium.org Vulkan: Fix ResourceHeap leak for direct-allocated resources.
2020-05-12 rharrison@chromium.org Rolling 5 dependencies and fix test slow down

Also rolling transitive DEPS:
  https://chromium.googlesource.com/chromium/src/third_party/jinja2 b41863e42637..b41863e42637
  https://chromium.googlesource.com/chromium/src/third_party/markupsafe 8f45f5cfa000..8f45f5cfa000
  https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang b5f003d7a3ec..4fa68edd6819
  https://chromium.googlesource.com/external/github.com/google/shaderc 15a66d72f33a..00ac5d82178c

Created with:
  gclient setdep -r third_party/externals/dawn@f4df7916cacb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I7a54d7a8174d983fed00f027e2d9d7700f3d860b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289337
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-13 04:59:21 +00:00
Greg Daniel
dd68b78917 Fix VkProtectedContextTest to correctly make SkSurfaces.
Change-Id: I7815e8967ae180c8a45d82c610b77fab4c36323d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289246
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-05-12 19:15:55 +00:00
Robert Phillips
8bd071998e Add GrVkResourceProvider::findCompatibleRenderPass variant that takes an AttachmentsDescriptor
The plan is to create an AttachmentsDescriptor and AttachmentFlags from the GrProgramInfo in order to get a GrVkRenderPass which can be used to findOrCreate a PipelineState.

This is pulled out of:
https://skia-review.googlesource.com/c/skia/+/288462 ([Omnibus] Add program pre-compilation to Vulkan backend)

Bug: skia:9455
Change-Id: I5bc3f65f92cee50567b7bd2d5f2414628869c9b7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289222
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-05-12 18:01:13 +00:00
Mike Reed
48fcdacf9e only pass a real paint to drawPicture if we need to
drawPicture(..., paint)

If paint is non-null, drawPicture will always draw the picture into a
temp layer. Thus we should not blindly pass in a "filtered" paint unless
it will actually draw differently (other than the layer itself).

Side-effect: drawing into a layer is also much slower, so a 2nd reason
to not blindly pass in a non-null paint.

Change-Id: I766c0a129d3bb2882cab976fb2780ef9a09278ee
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289241
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
2020-05-12 17:55:43 +00:00
Michael Ludwig
828d341199 Reland "Refactor stencil clip mask generation into helper"
This reverts commit de228e53fe.

Reason for revert: GrReducedClip now assumes context isn't abandoned,
windowrectangles GM abuses GrReducedClip and has to be abandon-aware.

Original change's description:
> Revert "Refactor stencil clip mask generation into helper"
>
> This reverts commit 8b3a8a5238.
>
> Reason for revert: GM assert failure
>
> Original change's description:
> > Refactor stencil clip mask generation into helper
> >
> > Change-Id: If3dc80efde3b44e87ba8e7af3a258896ec5e78e6
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288977
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> > Reviewed-by: Chris Dalton <csmartdalton@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
>
> TBR=bsalomon@google.com,csmartdalton@google.com,michaelludwig@google.com
>
> Change-Id: I16559f791601145f57d147cdae345c200af313f1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289237
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

# Not skipping CQ checks because this is a reland.

Change-Id: I6a9372edecd0bdc1a38464ab85f7b7f3ca85e5ed
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289239
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-05-12 17:49:47 +00:00
Robert Phillips
f497c36625 Make GrVkResourceProvider::PipelineStateCache use GrGpu::Stats
This allows tracking of pre-compiled vs. inline-compiled pipelines.

This is pulled out of:
https://skia-review.googlesource.com/c/skia/+/288462 ([Omnibus] Add program pre-compilation to Vulkan backend)

Bug: skia:9455
Change-Id: I926b61c266c8d8b2ea4fb2b8aea35d308bac322b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289178
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-05-12 17:41:57 +00:00
Robert Phillips
3bce1f710a Non-substantive Vulkan backend changes
These changes just serve to muddy the water in the real CL.

This is pulled out of:
https://skia-review.googlesource.com/c/skia/+/288462 ([Omnibus] Add program pre-compilation to Vulkan backend)

Change-Id: I033ff7976ce0ee39e9e99b6dec1b80277f7c04ab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289221
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-05-12 17:22:07 +00:00
Adlai Holler
8e82123bef DDLTileHelper: Use SkAutoTArray instead of raw pointer
Noticed this while poking around.

Change-Id: Ibc371cc3dcf2ed4b1e029ec74b16bb41a4b8e592
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289017
Auto-Submit: Adlai Holler <adlai@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-05-12 16:26:05 +00:00
Michael Ludwig
de228e53fe Revert "Refactor stencil clip mask generation into helper"
This reverts commit 8b3a8a5238.

Reason for revert: GM assert failure

Original change's description:
> Refactor stencil clip mask generation into helper
> 
> Change-Id: If3dc80efde3b44e87ba8e7af3a258896ec5e78e6
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288977
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> Reviewed-by: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,csmartdalton@google.com,michaelludwig@google.com

Change-Id: I16559f791601145f57d147cdae345c200af313f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289237
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-05-12 16:17:35 +00:00
Michael Ludwig
8b3a8a5238 Refactor stencil clip mask generation into helper
Change-Id: If3dc80efde3b44e87ba8e7af3a258896ec5e78e6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288977
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-05-12 15:27:18 +00:00
Adlai Holler
684838f1f5 Mark SkStringPrintf as SK_PRINTF_LIKE
Change-Id: I3d2ee8dca1d2e962794ce8c3c391779bff357f0c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288762
Commit-Queue: Adlai Holler <adlai@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Auto-Submit: Adlai Holler <adlai@google.com>
2020-05-12 15:22:14 +00:00
Brian Osman
cb1c2624e7 SkMatrixProvider: Move local-to-device storage to base class
Simplifies all the helpers. Also changed "override" to "post-concat", to
reflect what it's really doing (because we're going to need post-concat
soon anyway).

Change-Id: Iff388998407441c8df418a3c8464eb8f6aad0786
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289197
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2020-05-12 15:22:13 +00:00
Xianzhu Wang
a1ed96b1cf Remove code resetting pixelGeometry for filters
The code wasn't executed because we always reset pixelGeometry to
kUnknown_SkPixelGeometry unless kPreserveLCDText_SaveLayerFlag
(which has not been actually used yet) was specified.

The client should be responsible to use
kPreserveLCDText_SaveLayerFlag only when it's appropriate.

Bug: chromium:1076019
Change-Id: Ie2a559445c11cae63db20976cbedee269fca6b24
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289129
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2020-05-12 14:20:23 +00:00
Adlai Holler
00ddb0029d Reland "Support large kernels on GPU in matrix convolution effect"
This reverts commit a117e7b75b.

Reason for revert: Fixed divide-by-0 in the unpremul logic. This was here before but never caused problems (or we ignored them.)

Original change's description:
> Revert "Reland "Support large kernels on GPU in matrix convolution effect""
>
> This reverts commit 76cb9c4d4c.
>
> Reason for revert: Tegra3 & Metal issues
>
> Original change's description:
> > Reland "Support large kernels on GPU in matrix convolution effect"
> >
> > This reverts commit 41e377d1ba.
> >
> > Reason for revert: fixed issues
> >
> > Bug: skia:8449
> > Change-Id: I0c4389f0efa92c6da69253b2304ad9a072750965
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/287817
> > Commit-Queue: Adlai Holler <adlai@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
>
> TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com,adlai@google.com
>
> Change-Id: I5c3f04d4d262550a3298b8fd677c8a1661be7ad9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:8449
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289076
> Reviewed-by: Adlai Holler <adlai@google.com>
> Commit-Queue: Adlai Holler <adlai@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com,adlai@google.com


Bug: skia:8449
Change-Id: I90b8e9e0eb52bc08308fb472eb216ed0bd4785a1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289030
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Adlai Holler <adlai@google.com>
2020-05-12 12:47:44 +00:00
Brian Salomon
3d2c41b773 Look for GL_ARB_texture_rectangle on SwiftShader contexts
Bug: skia:9832
Change-Id: Id3841a36dc94f16db4c06398944a7b0497344ccd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289136
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-05-12 12:45:53 +00:00
skia-recreate-skps
4e9cfe7691 Update Go Deps
Change-Id: I1145f6e66c9174297cf9860cbcbfd9ff4ee57b26
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289127
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2020-05-12 05:37:43 +00:00
skia-autoroll
c7f7c0b803 Roll third_party/externals/angle2 9f32304208de..9823d86a5a40 (13 commits)
9f32304208..9823d86a5a

git log 9f32304208de..9823d86a5a40 --date=short --first-parent --format='%ad %ae %s'
2020-05-11 spang@chromium.org Fix EGLSurfaceTest.ResizeWindow on Fuchsia
2020-05-11 spang@chromium.org Skip swiftshader tests based on active GPU
2020-05-11 spang@chromium.org Vulkan: Use dedicated allocations in VulkanExternalHelper
2020-05-11 jmadill@chromium.org Capture/Replay: Regenerate glue if captures change.
2020-05-11 spang@chromium.org Vulkan: Add dedicated allocation support to MemoryObjectVk
2020-05-11 jmadill@chromium.org Trace/Replay: Always use Linux-style line endings.
2020-05-11 lehoangq@gmail.com Update spirv-cross to f38cbeb814c73510b85697adbe5e894f9eac978f.
2020-05-11 cclao@google.com Vulkan: Split barriers into multiple calls to ensure no extra dependency
2020-05-11 jmadill@chromium.org Update trace capture workflow doc.
2020-05-11 amaiorano@google.com Add support for GL_CHROMIUM_texture_filtering
2020-05-11 amy.liu@arm.com Vulkan: Fix texture copy from texture3d to texture2d or cubemap
2020-05-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 2dd864470e31..7b87548e5a63 (1 commits)
2020-05-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 43ea8c0fdf49..bb279b9f0bda (14 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@9823d86a5a40

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: jlavrova@google.com
Change-Id: I07c13c7eda50883371c163fafbd03cdf2c40ef0d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289119
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-12 04:57:23 +00:00
skia-autoroll
19410e27f7 Roll ../src 75fdd71e454b..63c884f8e9c5 (486 commits)
75fdd71e45..63c884f8e9


Created with:
  gclient setdep -r ../src@63c884f8e9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
Tbr: jlavrova@google.com
Change-Id: I4e61806f5b09f65d2e2be2e3be298a24dee9faab
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289117
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-12 04:47:43 +00:00
skia-autoroll
1de3a64bac Roll third_party/externals/swiftshader 7b87548e5a63..d9ba4b7dd30b (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7b87548e5a63..d9ba4b7dd30b

git log 7b87548e5a63..d9ba4b7dd30b --date=short --first-parent --format='%ad %ae %s'
2020-05-11 amaiorano@google.com Add high precision filtering extension

Created with:
  gclient setdep -r third_party/externals/swiftshader@d9ba4b7dd30b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: jlavrova@google.com
Change-Id: I07feaf8b1d04dcb91601f5f14c27fd67754e4eeb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289120
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-12 04:45:43 +00:00
skia-autoroll
36bda05b21 Roll third_party/externals/dawn 562255a94346..02beecaec5cd (9 commits)
https://dawn.googlesource.com/dawn.git/+log/562255a94346..02beecaec5cd

git log 562255a94346..02beecaec5cd --date=short --first-parent --format='%ad %ae %s'
2020-05-11 enga@chromium.org Fuzzer: Wait for all commands to complete before destroying the wire
2020-05-11 enga@chromium.org Make fence descriptor optional
2020-05-11 cwallez@chromium.org Make error scope shutdown iterative instead of recursive.
2020-05-11 yunchao.he@intel.com Fix a bug for multi-writes in ResourceUsageTrackingTests.cpp
2020-05-11 rharrison@chromium.org Revert "Rolling 4 dependencies"
2020-05-11 cwallez@chromium.org Add a test for creating a 0-sized buffer.
2020-05-11 bryan.bernhart@intel.com D3D12: Remove ComPtr from D3D12 objects when possible.
2020-05-11 rharrison@chromium.org Rolling 4 dependencies
2020-05-11 cwallez@chromium.org Roll third_party/googletest/ e3f0319d8..a09ea700d (27 commits)

Also rolling transitive DEPS:
  https://chromium.googlesource.com/chromium/src/third_party/jinja2 b41863e42637..b41863e42637
  https://chromium.googlesource.com/chromium/src/third_party/markupsafe 8f45f5cfa000..8f45f5cfa000
  https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang b5f003d7a3ec..b5f003d7a3ec
  https://chromium.googlesource.com/external/github.com/google/shaderc 15a66d72f33a..15a66d72f33a

Created with:
  gclient setdep -r third_party/externals/dawn@02beecaec5cd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I8c3e8367e0fe59ec44914e6ead50244d856c175c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289118
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2020-05-12 04:40:23 +00:00