hendrikw
894a2e4362
skia: Initialize value passed to GetShaderiv in GLBench
...
The command buffer's GetShaderiv and GetProgramiv code checks
that the success value passed in is either -1 or 0.
Review URL: https://codereview.chromium.org/1318143004
2015-09-08 15:18:56 -07:00
mtklein
925979f733
Make SkGraphics::Term a no-op, stop calling it.
...
I'd remove it entirely but Android is calling it explicitly.
BUG=skia:4259
Review URL: https://codereview.chromium.org/1329853005
2015-09-08 15:18:21 -07:00
joshualitt
87a5c9fa0f
Add number of draws to GrGpu stats
...
BUG=skia:
Review URL: https://codereview.chromium.org/1333543002
2015-09-08 13:42:05 -07:00
benjaminwagner
00c3252bb9
Update documentation of colors on Status.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1330063002
Review URL: https://codereview.chromium.org/1330063002
2015-09-08 12:51:23 -07:00
reed
0f0af23889
Revert[2] of "switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE"
...
master-skia has been updated to use isABitmap
This reverts commit ff390c9bdd
.
BUG=skia:
Review URL: https://codereview.chromium.org/1310573008
2015-09-08 11:02:04 -07:00
bsalomon
90e8ab79be
Re-enable nvpr text rendering in DM.
...
Review URL: https://codereview.chromium.org/1306733007
2015-09-08 10:26:51 -07:00
wangyix
54a6b1a122
emitChild() used to generate a mangled outputColor based on the parent's outputColor; now it just accepts an outputColor string. It's now up to the programmer to declare outputColors if needed before emitting child code.
...
BUG=skia:4182
Review URL: https://codereview.chromium.org/1321253003
2015-09-08 08:41:51 -07:00
reed
43fe6185c5
refactor parts of SkGr.cpp for use by SkImages
...
BUG=skia:
Review URL: https://codereview.chromium.org/1315353006
2015-09-08 08:37:36 -07:00
mtklein
bbd40183ae
Port SkLazyFnPtr users to SkOncePtr.
...
First baby step on road to replacing SkLazyFnPtr, SkLazyPtr, and SkOnce.
One of those very unusual times you get to use a function type,
not a function pointer type!
BUG=skia:
Review URL: https://codereview.chromium.org/1317263007
2015-09-08 08:19:34 -07:00
halcanary
a5f46e1821
Comments: note existance of SkImage::newShader next to CreateBitmapShader
...
Review URL: https://codereview.chromium.org/1329083004
2015-09-08 07:12:25 -07:00
joshualitt
189aef7834
Create module system for VisualBench
...
The newly created VisualLightweightBenchModule is just the old VisualBench.cpp, but gutted to only include timing code.
Future CLs will harden this abstraction, but for this CL the module owns a backpointer to VisualBench.cpp for a couple of calls.
BUG=skia:
Review URL: https://codereview.chromium.org/1304083007
2015-09-08 07:08:11 -07:00
msarett
8fd97eab1d
Revert of Provides multiple implementations of Android's SkBitmapRegionDecoder (patchset #16 id:360001 of https://codereview.chromium.org/1288963002/ )
...
Reason for revert:
Breaking Android bots
Bad use of the utils folder
Original issue's description:
> Provides various implementations of Android's SkBitmapRegionDecoder.
>
> Implements testing in DM for these implementations.
>
> nanobench testing will follow after this.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/76f755e6d54a32f9887ad254ce59a3a62f28bde4
TBR=scroggo@google.com ,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1322773004
2015-09-08 06:59:48 -07:00
scroggo
ff390c9bdd
Revert of switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE (patchset #3 id:40001 of https://codereview.chromium.org/1311963007/ )
...
Reason for revert:
Broke the Android canary:
https://internal.skia.org/builders/crimson-cherry-474438/builds/124
Original issue's description:
> switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/2d126b5c45e65a67a9945afa9294038a8eb3f2c8
TBR=reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1309943004
2015-09-08 06:24:08 -07:00
hendrikw
1512029900
skia: use msaaConfigAttribList for SkOSWindow_win
...
eglChooseConfig was still being passed configAttribList, pass
msaaConfigAttribList instead
Review URL: https://codereview.chromium.org/1318663007
2015-09-08 05:53:23 -07:00
bungeman
a3434d83cf
Add skstd::unique_ptr and use it.
...
TBR=bsalomon@google.com
The one gpu include change is just to fix swap in implementation.
Review URL: https://codereview.chromium.org/1330503006
2015-09-07 12:45:52 -07:00
reed
2d126b5c45
switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1311963007
2015-09-07 11:10:30 -07:00
msarett
10522ff4cf
Scanline decoding for gifs
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/e9c10b9121887e8c300bd41357461418e061984d
Review URL: https://codereview.chromium.org/1305123002
2015-09-07 08:54:01 -07:00
rmistry
3e9a4526ed
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/1307693006
2015-09-06 00:20:11 -07:00
jcgregorio
e3330cf2cf
Revert of Scanline decoding for gifs (patchset #15 id:380001 of https://codereview.chromium.org/1305123002/ )
...
Reason for revert:
Breaks the build with SkScanlineDecoder.h not found:
http://build.chromium.org/p/client.skia/builders/Linux%20Builder/builds/3722/steps/compile/logs/stdio
../../third_party/skia/src/utils/SkBitmapRegionCanvas.h:10:10: fatal error: 'SkScanlineDecoder.h' file not found
#include "SkScanlineDecoder.h"
Original issue's description:
> Scanline decoding for gifs
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/e9c10b9121887e8c300bd41357461418e061984d
TBR=scroggo@google.com ,djsollen@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1320273004
2015-09-05 10:16:28 -07:00
herb
ef2df09997
Revert of Parallel cache - preliminary (patchset #22 id:420001 of https://codereview.chromium.org/1264103003/ )
...
Reason for revert:
Seems to freeze android devices.
Original issue's description:
> Parallel cache.
>
> TBR=reed@google.com
>
> BUG=skia:1330
>
> Committed: https://skia.googlesource.com/skia/+/6f2a486040cb25465990196c229feb47e668e87f
TBR=reed@google.com ,mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:1330
Review URL: https://codereview.chromium.org/1327703003
2015-09-04 14:19:45 -07:00
msarett
e9c10b9121
Scanline decoding for gifs
...
BUG=skia:
Review URL: https://codereview.chromium.org/1305123002
2015-09-04 13:28:26 -07:00
msarett
9260296349
Bot fix
...
https://codereview.chromium.org/1311503008
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage/builds/1083/steps/build%20dm/logs/stdio
BUG=skia:
Review URL: https://codereview.chromium.org/1331463004
2015-09-04 13:12:55 -07:00
msarett
76f755e6d5
Provides various implementations of Android's SkBitmapRegionDecoder.
...
Implements testing in DM for these implementations.
nanobench testing will follow after this.
BUG=skia:
Review URL: https://codereview.chromium.org/1288963002
2015-09-04 13:00:50 -07:00
fmalita
c3470340b6
Handle zero-length encoded images gracefully during deserialization
...
Image encoding may fail during serialization, resulting in zero-length
encoded data in the SKP.
Instead of invalidating the stream (and preventing deserialization of
the whole picture) we can instantiate placeholder images.
BUG=skia:4285
R=reed@google.com ,robertphillips@google.com
Review URL: https://codereview.chromium.org/1308273011
2015-09-04 11:36:39 -07:00
msarett
19e9b35750
Ico bug fix for opaque embedded images
...
BUG=skia:
Review URL: https://codereview.chromium.org/1327963004
2015-09-04 10:53:53 -07:00
herb
6f2a486040
Parallel cache.
...
TBR=reed@google.com
BUG=skia:1330
Review URL: https://codereview.chromium.org/1264103003
2015-09-04 10:38:58 -07:00
mtklein
714a710c42
SkOncePtr
...
New abstraction to replace all of: SkOnce, SkLazyPtr, SkLazyFnPtr.
BUG=skia:
Review URL: https://codereview.chromium.org/1301323006
2015-09-04 10:26:27 -07:00
reed
58e524c98c
draw 3 moveTos followed by various others [moves, lines, closes]
...
BUG=skia:
Review URL: https://codereview.chromium.org/1311503008
2015-09-04 10:03:26 -07:00
reed
f4a6d30044
remove duplicated sample (already have a gm)
...
BUG=skia:
Review URL: https://codereview.chromium.org/1317693011
2015-09-04 10:03:22 -07:00
ssid
85237822b3
Fix SkOneShotDiscardablePixelRef to return discardable segment.
...
The SkOneShotDiscardablePixelRef was not overriding
diagnostic_only_getDiscardable method of SkPixelRef. This caused the
memory to be acocunted under malloc instead of discardable and caused
wrong accounting.
BUG=528295
Review URL: https://codereview.chromium.org/1304083006
2015-09-04 08:29:24 -07:00
joshualitt
55143211e9
Minor tweak to visual bench timing
...
BUG=skia:
Review URL: https://codereview.chromium.org/1310153005
2015-09-04 07:48:42 -07:00
caryclark
c8b350df07
update gm test size to include new elements
...
TBR=
BUG=skia:562
Review URL: https://codereview.chromium.org/1305983006
2015-09-04 06:19:48 -07:00
caryclark
500ab7562c
change for issue 562
...
Add a current version of the patch described in issue 562.
Of interest: the reference row, which is described in the
bug as looking correct draws differently with Ganesh.
TBR=senorblanco
BUG=skia:562
Review URL: https://codereview.chromium.org/1324023006
2015-09-04 05:20:32 -07:00
caryclark
6ff734b311
remove unused fields from SkOpSegment
...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1322413002
2015-09-04 05:00:15 -07:00
halcanary
5a9a5b3e7f
CMAKE + install command
...
NOTRY=true
Review URL: https://codereview.chromium.org/1325903004
2015-09-03 14:23:18 -07:00
robertphillips
943a462fef
Minor code cleanup (left over from prior CL)
...
This was requested in https://codereview.chromium.org/1309543012/ (Add new GM to directly exercise perspective bitmap drawing)
Review URL: https://codereview.chromium.org/1320673011
2015-09-03 13:32:33 -07:00
robertphillips
44c3128bd8
Clean up some lint complaints
...
BUG=skia:4287
Review URL: https://codereview.chromium.org/1327943003
2015-09-03 12:58:49 -07:00
borenet
d34d94766d
Appurify bot: don't use flags that visualbench doesn't support
...
Depends on https://codereview.chromium.org/1320423005/
BUG=skia:4277
Review URL: https://codereview.chromium.org/1310903006
2015-09-03 12:31:26 -07:00
mdempsky
214046e8a1
Fix memory leak in build example
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1319703004
Review URL: https://codereview.chromium.org/1319703004
2015-09-03 12:19:23 -07:00
borenet
ad54ffc235
adb_wait_for_device: Skip adb wait-for-device
...
This should still wait for the device to be attached and finished
booting, but will prevent no-output timeouts due to
`adb wait-for-device` never finishing.
The effect should be that, when an Android device is disconnected, the
"wait for device" step will run forever, or until the device
reconnects. This should prevent a disconnected device from spreading
purple all over the status page.
BUG=skia:
Review URL: https://codereview.chromium.org/1315753010
2015-09-03 10:41:07 -07:00
benjaminwagner
fbf908c857
Add some useful information to trooper doc.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1308253005
Review URL: https://codereview.chromium.org/1308253005
2015-09-03 09:06:30 -07:00
wangyix
d705958375
Will try composing a linear gradient with a color bitmap as well as an alpha8 bitmap to make sure the paint's color is being used/ignored in the right places.
...
BUG=skia:4182
Review URL: https://codereview.chromium.org/1311043008
2015-09-03 08:32:22 -07:00
robertphillips
fac9ceb5de
Add new GM to directly exercise perspective bitmap drawing
...
BUG=skia:3326
Review URL: https://codereview.chromium.org/1309543012
2015-09-03 08:32:08 -07:00
fmalita
75db90c4d7
Missing EncodeData(SkImageInfo...) in SkImageEncoder_empty
...
TBR=reed@google.com ,msarett@google.com
Review URL: https://codereview.chromium.org/1304243007
2015-09-03 07:47:22 -07:00
fmalita
2be7125f32
Add a SkPixelSerializer SkImage encode variant
...
R=reed@google.com
BUG=skia:4285
Review URL: https://codereview.chromium.org/1310633006
2015-09-03 07:17:25 -07:00
reed
1a9cafff04
add interactive xfer sample
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1323223004
2015-09-02 19:05:10 -07:00
rmistry
1dec47a054
Testing CQ committer list
...
BUG=skia:
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1308163007
2015-09-02 16:25:17 -07:00
msarett
d67d08ed33
Fix bug in ico decodes
...
Some icos have been looking a bit strange in Gold.
Looks like the cause was that we were decoding to kUnpremul
accidentally.
BUG=skia:
Review URL: https://codereview.chromium.org/1321913003
2015-09-02 16:23:42 -07:00
sergiyb
613f20aa4b
Moved committer list to chrome-infra-auth and deleted it from the repo
...
R=rmistry@chromium.org
BUG=chromium:511311
Review URL: https://codereview.chromium.org/1314153006
2015-09-02 13:37:54 -07:00
msarett
36c3796fbf
Remove unwanted images in Gold
...
These extra outputs were caused by recent changes to
push_codec_srcs.
https://codereview.chromium.org/1327433003/
*** First, I would argue that we do not want to test
"native" modes (ex: codec, scanline, etc) to scales
that require sampling (ex: 0.1, 0.2, etc). Right now,
we are trying to scale jpegs to 0.1, settling for 0.125
as the closest option, and then trying to compare the
0.125 scaled image to the actual 0.1 scaled image in
Gold.
*** Second, I messed up and caused our test setup to
try to decode to kIndex8 and kGray8 "always" instead
of only when it is recommended. The bad effect of this
happens because we can decode jpegs to kGray8 even if
they are color images. Right now in Gold, we have a
bunch of untriaged gray versions of color images.
The second issue would have been caught if we signaled
a fatal failure for invalid conversions. Maybe we should
look into this now that 565 is supported everywhere?
BUG=skia:
Review URL: https://codereview.chromium.org/1314163007
2015-09-02 13:20:52 -07:00