AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
95376a0dde
skia2/bench
History
schenney 95376a0dde Revert of factories should return baseclass, allowing the impl to specialize (patchset #4 id:60001 of https://codereview.chromium.org/1390523005/ ) 
Reason for revert:
Breaks Chrome with this link error: ../../third_party/skia/include/effects/SkMorphologyImageFilter.h:75: error: undefined reference to 'SkMorphologyImageFilter::SkMorphologyImageFilter(int, int, SkImageFilter*, SkImageFilter::CropRect const*)'
../../third_party/skia/include/effects/SkMorphologyImageFilter.h:104: error: undefined reference to 'SkMorphologyImageFilter::SkMorphologyImageFilter(int, int, SkImageFilter*, SkImageFilter::CropRect const*)'

Presumably due to code in third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp that contains:
#include "SkMorphologyImageFilter.h"

...

    if (m_type == FEMORPHOLOGY_OPERATOR_DILATE)
        return adoptRef(SkDilateImageFilter::Create(radiusX, radiusY, input.get(), &rect));
    return adoptRef(SkErodeImageFilter::Create(radiusX, radiusY, input.get(), &rect));

Original issue's description:
> factories should return baseclass, allowing the impl to specialize
>
> waiting on https://codereview.chromium.org/1386163002/# to land
>
> BUG=skia:4424
>
> Committed: https://skia.googlesource.com/skia/+/80a6dcaa1b757826ed7414f64b035d512d9ccbf8

TBR=senorblanco@google.com,robertphillips@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4424

Review URL: https://codereview.chromium.org/1389063002
2015-10-06 12:59:55 -07:00
..
subset Remove const from const int loops. 2015-10-01 09:43:39 -07:00
AAClipBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
AlternatingColorPatternBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
bench_compare.py Make bench_compare executable. 2013-11-12 15:25:31 +00:00
bench_util.py Restore bench_util.py 2014-08-08 17:28:53 -04:00
BenchLogger.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
BenchLogger.h Remove Sk prefix from some bench classes. 2014-06-19 12:32:29 -07:00
Benchmark.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
Benchmark.h Cleanup timing state machine 2015-10-05 13:58:26 -07:00
BezierBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
BigPathBench.cpp Factor out VisualBench timing code into a helper class 2015-10-05 07:23:30 -07:00
BitmapBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
BitmapRectBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
BitmapRegionDecoderBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
BitmapRegionDecoderBench.h Remove const from const int loops. 2015-10-01 09:43:39 -07:00
BitmapScaleBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
BlurBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
BlurImageFilterBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
BlurRectBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
BlurRectsBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
BlurRoundRectBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ChartBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
check_bench_regressions.py Adds dashboard link for one-line plot on each alert item. 2014-05-13 17:38:17 +00:00
ChecksumBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ChromeBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
CmapBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
CodecBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
CodecBench.h Remove const from const int loops. 2015-10-01 09:43:39 -07:00
CodecBenchPriv.h Add nanobench tests for BitmapRegionDecoder 2015-09-22 11:56:16 -07:00
ColorCubeBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ColorFilterBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ColorPrivBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ControlBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
CoverageBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
DashBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
DecodingBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
DecodingBench.h Remove const from const int loops. 2015-10-01 09:43:39 -07:00
DisplacementBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
DrawBitmapAABench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ETCBitmapBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
FontCacheBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
FontScalerBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
FSRectBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
GameBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
gen_bench_expectations.py Added in framework to get more bench data 2014-06-12 11:27:40 -07:00
GeometryBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
GLBench.cpp S4 only has 8 texture units on the GLContext we create 2015-10-02 06:49:23 -07:00
GLBench.h Remove const from const int loops. 2015-10-01 09:43:39 -07:00
GLInstancedArraysBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
GLVec4ScalarBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
GLVertexAttributesBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
GMBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
GMBench.h Remove const from const int loops. 2015-10-01 09:43:39 -07:00
GradientBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
GrMemoryPoolBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
GrResourceCacheBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
gUniqueGlyphIDs.h switch array to uint16_t to fix overflows 2013-06-11 19:53:19 +00:00
HairlinePathBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ImageBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ImageCacheBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ImageFilterCollapse.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ImageFilterDAGBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
InterpBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
LightingBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
LineBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
MagnifierBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
MathBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
Matrix44Bench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
MatrixBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
MatrixConvolutionBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
MemoryBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
MemsetBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
MergeBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
microbench.json Fix the other microbench schema 2014-07-25 08:30:11 -07:00
MipMapBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
MorphologyBench.cpp Revert of factories should return baseclass, allowing the impl to specialize (patchset #4 id:60001 of https://codereview.chromium.org/1390523005/ ) 2015-10-06 12:59:55 -07:00
MutexBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
nanobench.cpp Specify bench_type & source_type for image benches 2015-10-05 11:03:34 -07:00
nanobench.h Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
nanobenchAndroid.cpp Implement SkGLContext swapBuffers with fence syncs 2015-06-23 13:23:44 -07:00
nanobenchAndroid.h Implement SkGLContext swapBuffers with fence syncs 2015-06-23 13:23:44 -07:00
PatchBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
PatchGridBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
PathBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
PathIterBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
PerlinNoiseBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
PictureNestingBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
PictureOverheadBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
PicturePlaybackBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
PremulAndUnpremulAlphaOpsBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ReadPixBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
RecordingBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
RecordingBench.h Remove const from const int loops. 2015-10-01 09:43:39 -07:00
RectanizerBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
RectBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
RectoriBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
RefCntBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
RegionBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
RegionContainBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
RepeatTileBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ResultsWriter.h Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
RotatedRectBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
RTreeBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ScalarBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
ShaderMaskBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
Sk4fBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
SkGlyphCacheBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
SkipZeroesBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
SKPAnimationBench.cpp Style Change: NULL->nullptr 2015-08-27 07:41:16 -07:00
SKPAnimationBench.h Make nanobench zoom animation time based 2015-06-29 14:06:10 -07:00
SKPBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
SKPBench.h Remove const from const int loops. 2015-10-01 09:43:39 -07:00
skpbench.json Fix scale type in JSON format 2014-06-26 15:39:31 -07:00
SortBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
StrokeBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
TableBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
TextBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
TextBlobBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
tile_analyze.py Script to plot tile vs. viewport comparison for given platform and revision. 2013-02-13 23:22:29 +00:00
TileBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
VertBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
WritePixelsBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
WriterBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00
XfermodeBench.cpp Remove const from const int loops. 2015-10-01 09:43:39 -07:00