skia.committer@gmail.com
3284017a60
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8568 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-09 07:01:27 +00:00
robertphillips@google.com
2e87ba0c7c
Add before and after command count to filter tool
...
https://codereview.chromium.org/13405003/
git-svn-id: http://skia.googlecode.com/svn/trunk@8562 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-08 15:45:30 +00:00
epoger@google.com
50d6862fdb
Make submit_try accept space- or comma-separated list
...
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13535005
git-svn-id: http://skia.googlecode.com/svn/trunk@8521 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-03 18:35:35 +00:00
skia.committer@gmail.com
041e2dbc06
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8503 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-03 07:01:14 +00:00
robertphillips@google.com
c52570475f
Expand filter 0 to handle transparent drawBitmapRect paints
...
https://codereview.chromium.org/13394014/
git-svn-id: http://skia.googlecode.com/svn/trunk@8486 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-02 15:30:03 +00:00
bungeman@google.com
07a69f848c
Name table iterator.
...
https://codereview.appspot.com/8180043/
git-svn-id: http://skia.googlecode.com/svn/trunk@8480 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-02 14:12:38 +00:00
skia.committer@gmail.com
05a2ee052c
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8477 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-02 07:01:34 +00:00
commit-bot@chromium.org
3bdf16496f
Taken together with the filter tool's new looping capabilities, these two optimizations can replace check_7 and apply_7.
...
Author: robertphillips@google.com
Reviewed By: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/13261019
git-svn-id: http://skia.googlecode.com/svn/trunk@8471 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-01 21:00:27 +00:00
robertphillips@google.com
d9c1853fb8
Add looping over optimizations to filter tool
...
https://codereview.chromium.org/13261018/
git-svn-id: http://skia.googlecode.com/svn/trunk@8465 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-01 19:10:21 +00:00
robertphillips@google.com
50c84da68b
Add getDrawCommandAt and setDrawCommandAt to SkDebugCanvas
...
https://codereview.chromium.org/13393005/
git-svn-id: http://skia.googlecode.com/svn/trunk@8462 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-01 18:18:49 +00:00
borenet@google.com
02009c781d
Add short option for --bot in submit_try
...
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13133011
git-svn-id: http://skia.googlecode.com/svn/trunk@8460 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-01 17:59:16 +00:00
skia.committer@gmail.com
6acd09e2b0
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8439 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-29 07:01:22 +00:00
robertphillips@google.com
c3410b8cbb
New filter targeted at desk_googlespreadsheet overdraw issues
...
https://codereview.chromium.org/12918029/
git-svn-id: http://skia.googlecode.com/svn/trunk@8424 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-28 12:25:25 +00:00
scroggo@google.com
d9ba9a05d6
Change the name of SkFlags to SkCommandLineFlags.
...
This name is more specific to what it actually does.
Also move the code into tools/flags, to (slightly) better organize
the massive tools folder.
Update the programs that use it to use the new names.
No functionality changes.
BUG=https://code.google.com/p/skia/issues/detail?id=1173
Review URL: https://codereview.chromium.org/12440067
git-svn-id: http://skia.googlecode.com/svn/trunk@8304 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-21 19:43:15 +00:00
scroggo@google.com
5dc4ca1ce6
Allow more options for setting boolean flag values in SkFlags.
...
Now booleans can be set using
--boolean=true or --boolean true (as well as other options).
Review URL: https://codereview.chromium.org/12961003
git-svn-id: http://skia.googlecode.com/svn/trunk@8285 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-21 13:10:59 +00:00
scroggo@google.com
0f2cd172af
When SkFlags encounters an invalid flag, quit.
...
This way the user knows to change their command line.
Review URL: https://codereview.chromium.org/12881014
git-svn-id: http://skia.googlecode.com/svn/trunk@8275 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-20 20:04:27 +00:00
scroggo@google.com
8366df025a
Update help in SkFlags.
...
Print the short name in addition to the standard name.
Allow an option for getting help for a specific command.
Review URL: https://codereview.chromium.org/12411007
git-svn-id: http://skia.googlecode.com/svn/trunk@8273 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-20 19:50:41 +00:00
borenet@google.com
4bfbc7f88f
Fix submit_try
...
Unreviewed
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@8270 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-20 18:00:09 +00:00
scroggo@google.com
09fd4d2169
Reland r8235 "Switch gm to use SkFlags."
...
This time, using #if guards for gpuCacheSize consistently.
Also fix some warnings.
BUG=https://code.google.com/p/skia/issues/detail?id=1094
Review URL: https://codereview.chromium.org/12440052
git-svn-id: http://skia.googlecode.com/svn/trunk@8254 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-20 14:20:18 +00:00
scroggo@google.com
0b735631b7
Revert "Make gm use SkFlags."
...
Fix the build.
This reverts commit 6f1fe2aee39308fc56854b062be244a904c209e7.
Review URL: https://codereview.chromium.org/12709005
git-svn-id: http://skia.googlecode.com/svn/trunk@8236 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 17:38:50 +00:00
scroggo@google.com
7d519305bb
Make gm use SkFlags.
...
Make flag parser its own project. It is still in the tools folder,
but can now be used by other projects.
Some changes to behavior in order to work with SkFlags:
enable-missing-warning and disable-missing-warning have become
enableMissingWarning and noenableMissingWarning.
exclude-config is now excludeConfig
--config now can only be listed once, but all configs listed
after it will be included (same with excludeConfig and match).
In addition, writeJsonSummary has been changed to
writeJsonSummaryPath for consistency with other path flags.
Provide an option to SkFlags to provide a short name, and use
it for the flags which have short names.
--tileGridReplayScales now takes space separated arguments,
like other inputs.
BUG=https://code.google.com/p/skia/issues/detail?id=1094
Review URL: https://codereview.chromium.org/12632015
git-svn-id: http://skia.googlecode.com/svn/trunk@8235 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 17:28:10 +00:00
scroggo@google.com
bb281f7f96
Improvements/additions to SkImageCache/SkLazyPixelRef.
...
SkPurgeableImageCache:
New image cache that uses virtual memory to store the pixels. Combines
features of SkAshmemImageCache (which has been removed) with SkPurgeableMemoryBlock, which has android and Mac versions.
SkImageCache:
Modified the API. pinCache now returns a status out parameter which
states whether the pinned memory retained the old data. This allows
allocAndPinCache to only be used for allocations.
Add a new debug only interface to purge unpinned data.
Updates to documentation, clarifying behavior.
Changed CachedStatus to MemoryStatus
SkLruImageCache:
Implement the new function purgeAllUnpinnedCaches and change implementation
of pinCache for the new behavior.
SkLazyPixelRef:
Rewrite onLockPixels to account for the new behavior of pinCache.
BitmapFactoryTest:
Test the new SkPurgeableImageCache.
Write tests which directly test the SkImageCaches.
Create a larger bitmap, since some of the SkImageCaches are designed
to handle large bitmaps.
bench_ and render_pictures:
Consolidate lazy_decode_bitmap into one function.
Allow using a flag to specify using the purgeable image cache.
Clean up some #includes.
Review URL: https://codereview.chromium.org/12433020
git-svn-id: http://skia.googlecode.com/svn/trunk@8207 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 21:37:39 +00:00
borenet@google.com
a74302d628
Use "svn cat" in tools/submit_try
...
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/12726006
git-svn-id: http://skia.googlecode.com/svn/trunk@8197 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 18:18:26 +00:00
robertphillips@google.com
9105ad0f85
Add translate & scale optimizations
...
https://codereview.appspot.com/7571045/
git-svn-id: http://skia.googlecode.com/svn/trunk@8182 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 18:46:16 +00:00
robertphillips@google.com
91217d0b0c
Making SkDrawCommand more robust
...
https://codereview.appspot.com/7486052/
git-svn-id: http://skia.googlecode.com/svn/trunk@8181 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 18:33:46 +00:00
skia.committer@gmail.com
03682beb8c
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8143 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-14 07:02:51 +00:00
junov@chromium.org
d34fda187c
Build fix: accessing uninitialized class member (not)
...
TBR=sugoi
git-svn-id: http://skia.googlecode.com/svn/trunk@8135 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 19:03:26 +00:00
junov@chromium.org
e286e84a6a
Modifying the behavior of render_pictures --validate to test the effect of bbh.
...
The new behavior consists in using the same renderer, with bbh disabled, as a reference
renderer when the current renderer has a bbh.
Review URL: https://codereview.chromium.org/12801002
git-svn-id: http://skia.googlecode.com/svn/trunk@8132 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 17:27:16 +00:00
junov@chromium.org
c19c19111c
Fixing crash in render_pictures when failing to create referenceBitmap for --validate
...
Review URL: https://codereview.chromium.org/12800002
git-svn-id: http://skia.googlecode.com/svn/trunk@8119 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 19:56:49 +00:00
robertphillips@google.com
febc0ec41b
Add misc. optimizations to filter tool
...
https://codereview.appspot.com/7705043/
git-svn-id: http://skia.googlecode.com/svn/trunk@8087 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 22:53:11 +00:00
borenet@google.com
fe7533eebe
Change submit_try to use checked-in master_host and master_port
...
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7719044
git-svn-id: http://skia.googlecode.com/svn/trunk@8072 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:09:40 +00:00
skia.committer@gmail.com
eed625df23
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8059 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-09 07:01:15 +00:00
borenet@google.com
2d137b6f8a
Fix Windows build - revert r8056 and r8057
...
TBR=epoger,edisonn
Review URL: https://codereview.chromium.org/12421010
git-svn-id: http://skia.googlecode.com/svn/trunk@8058 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-08 23:13:33 +00:00
edisonn@google.com
184487c808
Collect minidump and print callstack if an app chrashes.
...
Review URL: https://codereview.chromium.org/12387018
git-svn-id: http://skia.googlecode.com/svn/trunk@8044 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-08 18:00:16 +00:00
robertphillips@google.com
d59cf7c360
Remove reset of SkTileGrid in PictureRenderer::init
...
https://codereview.appspot.com/7641044/
git-svn-id: http://skia.googlecode.com/svn/trunk@8042 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-08 16:27:19 +00:00
borenet@google.com
b8f0de176f
Fix bench_pictures.cfg
...
- Add configs for Razr I
- Don't run multithreaded with --timeIndividualTiles
Review URL: https://codereview.chromium.org/12636002
git-svn-id: http://skia.googlecode.com/svn/trunk@8027 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-07 20:18:27 +00:00
skia.committer@gmail.com
075b089b1b
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7976 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-05 07:09:08 +00:00
scroggo@google.com
a560d00ba5
Provide an option in bench_pictures to count pixel ram.
...
In SkLruImageCache, provide an option to keep all pixels, and document
the new behavior.
In gm/factory.cpp, set the budget for the Lru image cache to 1, to
retain (basically) the old behavior.
BUG=https://code.google.com/p/skia/issues/detail?id=1010
Review URL: https://codereview.chromium.org/12378075
git-svn-id: http://skia.googlecode.com/svn/trunk@7972 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-04 21:32:32 +00:00
commit-bot@chromium.org
31ea3394a0
Convert skhello tool to SkFlags API.
...
BUG=https://code.google.com/p/skia/issues/detail?id=1094
R=scroggo@google.com
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: https://chromiumcodereview.appspot.com/12381087
git-svn-id: http://skia.googlecode.com/svn/trunk@7968 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-04 20:58:01 +00:00
scroggo@google.com
cc690201d2
Add a way to monitor cache hits and misses for deferred decoding.
...
Adds a new flag to bench_pictures in order to do this. Also fix
a warning.
Review URL: https://codereview.chromium.org/12393046
git-svn-id: http://skia.googlecode.com/svn/trunk@7965 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-04 19:56:21 +00:00
scroggo@google.com
161e1ba4c0
Created my own flag parser, based off of gflags.
...
Share common code between bench_ and render_ to set up the PictureRenderer.
Fix an include error in SkPictureRenderer.h.
Simplified parameter passing in render_pictures_main.
Switch to using an SkAutoTUnref for the PictureRenderer.
I also changed the input format somewhat, so the buildbots need to be updated as well: https://codereview.appspot.com/7441044/
Fixed a bug in PictureBenchmark where calling setTimeIndividualTiles(false) sets the member variable to true.
Removed setDeviceType from PictureBenchmark, since only the PictureRenderer needs to know which device type to use.
Some changes to the input format:
'--logPerIter' no longer takes a 1 or 0. Instead, '--logPerIter'
turns it on and '--nologPerIter' turns it off (with off as the
default). (Note that this is for bench_pictures; bench still uses the old format)
Change '--device' to '--config' and 'bitmap' to '8888' to be
the same as gm.
Requires '--r' before inputs (to match gm), though there can be multiple inputs following it.
Changed --enable-deferred-image-decoding (which no one uses but me yet anyway) to --deferImageDecoding, since the former is incompatible with the flag parser.
Changes to behavior:
Show a short error message on failure (rather than the explanation of all
flags).
BUG=https://code.google.com/p/skia/issues/detail?id=1094
Review URL: https://codereview.appspot.com/7230053
git-svn-id: http://skia.googlecode.com/svn/trunk@7961 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-04 16:41:06 +00:00
robertphillips@google.com
7ae918eec7
Move initialization to PictureRenderer ctor
...
https://codereview.appspot.com/7435052/
git-svn-id: http://skia.googlecode.com/svn/trunk@7942 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-02 17:45:27 +00:00
robertphillips@google.com
2c00ba3d72
Revert 7932
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7938 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-01 21:34:26 +00:00
robertphillips@google.com
f9ce42302b
Initialize grid info in TiledPictureRenderer::init
...
https://codereview.appspot.com/7444053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7932 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-01 20:15:18 +00:00
robertphillips@google.com
6177e6999d
Split GrGLContextInfo into GrGLContext & GrGLContextInfo
...
https://codereview.appspot.com/7436045/
git-svn-id: http://skia.googlecode.com/svn/trunk@7905 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-28 20:16:25 +00:00
junov@chromium.org
29b19e53cf
Change SkTileGride geometry calculations to match the Chromium compositor.
...
This patch changes the semantics of tileWidth/Height to include the border region, and
uses an offset to take into account the fact that there is no outer border for outer
tiles. This patch also fixes a previous bug where the right column and bottom row were
considered to be included in bounds that are expressed as an SkIRect.
Companion Chromium CL required for roll: https://codereview.chromium.org/12221077/
TEST=TileGrid unit test
Review URL: https://codereview.appspot.com/7350050
git-svn-id: http://skia.googlecode.com/svn/trunk@7885 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 18:35:16 +00:00
scroggo@google.com
f8d7d27313
Create SkLazyPixelRef which performs lazy decoding.
...
The new pixel ref behaves similarly to SkImageRef, with some key differences:
It does not depend on the images project.
It requires an SkImageCache, which handles allocation and caching of the pixel
memory.
It takes a function signature for decoding which decodes into already allocated
pixel memory rather than into an SkBitmap.
Add two implementations of SkImageCache: SkLruImageCache and SkAshmemImageCache.
Replace SkSerializationHelpers::DecodeBitmap with SkPicture::InstallPixelRefProc,
and update sites that referenced it.
SkBitmapFactory now sets the pixel ref to a new object of the new
class SkLazyPixelRef, provided it has an SkImageCache for caching.
Provide an option to do lazy decodes in render_pictures and bench_pictures.
SkPicture:
Eliminate the default parameters in the constructor.
If a proc for decoding bitmaps is installed, use it to decode any encoded
data in subpictures.
When parsing deserializing subpictures, check for success.
When serializing subpictures, pass the picture's bitmap encoder to the
subpicture's call to serialize.
Update BitmapFactoryTest to test its new behavior.
BUG=https://code.google.com/p/skia/issues/detail?id=1008
BUG=https://code.google.com/p/skia/issues/detail?id=1009
Review URL: https://codereview.appspot.com/7060052
git-svn-id: http://skia.googlecode.com/svn/trunk@7835 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-22 21:38:35 +00:00
borenet@google.com
46dc43da88
Make ANGLE bot run only ANGLE configs in bench_pictures
...
Review URL: https://codereview.appspot.com/7397043
git-svn-id: http://skia.googlecode.com/svn/trunk@7799 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-20 20:01:23 +00:00
epoger@google.com
bd9669ad27
bench_graph_svg: add r7618 results (NOT per-tile) to self-test source data
...
Review URL: https://codereview.appspot.com/7305098
git-svn-id: http://skia.googlecode.com/svn/trunk@7760 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-17 08:33:27 +00:00
epoger@google.com
aa6470af8e
bench_graph_svg self-test: add non-tile bench data
...
TBR=benchen
Review URL: https://codereview.appspot.com/7317048
git-svn-id: http://skia.googlecode.com/svn/trunk@7750 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-15 16:42:21 +00:00
epoger@google.com
673816c44f
tools/tests/run.sh: download test bench data from Google Storage rather than SVN
...
Review URL: https://codereview.appspot.com/7343045
git-svn-id: http://skia.googlecode.com/svn/trunk@7749 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-15 15:50:23 +00:00
epoger@google.com
2459a394b8
bench_graph_svg: generate output in consistently sorted order, to make diffs more useful
...
TBR=benchen
Review URL: https://codereview.appspot.com/7330044
git-svn-id: http://skia.googlecode.com/svn/trunk@7744 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-14 18:58:05 +00:00
epoger@google.com
9316d7a0cc
disable new bench_graph_svg test in tools/tests/run.sh that fails on housekeeper
...
TBR=bensong
Review URL: https://codereview.appspot.com/7303092
git-svn-id: http://skia.googlecode.com/svn/trunk@7739 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-14 15:35:23 +00:00
epoger@google.com
f4eeeabcdc
tools/tests/run.sh: add self-test for bench_graph_svg.py
...
Review URL: https://codereview.appspot.com/7319044
git-svn-id: http://skia.googlecode.com/svn/trunk@7735 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-14 15:10:24 +00:00
skia.committer@gmail.com
3d18d063f0
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7730 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-14 07:01:34 +00:00
robertphillips@google.com
1780a3cc84
Fix filter optimizations to take the paint's alpha into account
...
https://codereview.appspot.com/7312083/
git-svn-id: http://skia.googlecode.com/svn/trunk@7711 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-13 13:27:44 +00:00
robertphillips@google.com
e8fe4bc3ef
Allow debugger to be compiled without Ganesh
...
https://codereview.appspot.com/7311084/
git-svn-id: http://skia.googlecode.com/svn/trunk@7710 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-13 13:26:13 +00:00
borenet@google.com
b15e6061c6
Turn off per-iteration tile time reporting
...
It's overloading the bench graph generator.
Review URL: https://codereview.appspot.com/7300088
git-svn-id: http://skia.googlecode.com/svn/trunk@7691 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-11 18:42:43 +00:00
reed@google.com
01bfd753ec
Argv[0] isn't the first argument to anything.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7687 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-08 22:45:11 +00:00
humper@google.com
522dbd2e62
match chromium's approach for locating the most appropriate macos SDK to use
...
By doing this, the ninja generator for gyp works great on macos, resulting in faster (I think) and much, much terser builds.
BUG=
Review URL: https://codereview.appspot.com/7142047
git-svn-id: http://skia.googlecode.com/svn/trunk@7684 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-08 21:45:33 +00:00
scroggo@google.com
06d6ac645d
Clean up some out of order initialization warnings.
...
Review URL: https://codereview.appspot.com/7321043
git-svn-id: http://skia.googlecode.com/svn/trunk@7681 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-08 21:16:19 +00:00
scroggo@google.com
0556ea0ede
Add support for using ANGLE in bench_pictures.
...
BUG=https://code.google.com/p/skia/issues/detail?id=1012
Other cleanups:
Remove setDeviceType from PictureBenchmark, since it is unnecessary.
Dereference PictureRenderer::fGrContext when done with it.
Make PictureRenderer::fGrContext and PictureRenderer::fGrContextFactory private, since they are not used by subclasses.
Review URL: https://codereview.appspot.com/7314063
git-svn-id: http://skia.googlecode.com/svn/trunk@7677 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-08 19:38:21 +00:00
skia.committer@gmail.com
ee235f9062
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7659 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-08 07:16:45 +00:00
robertphillips@google.com
9b63c50d72
Only turn on one gpu timer in PictureBenchmark tool
...
https://codereview.appspot.com/7310060/
git-svn-id: http://skia.googlecode.com/svn/trunk@7651 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-07 20:20:27 +00:00
robertphillips@google.com
fe1b536bb7
Enhance GL error checking for non-Ganesh GL calls
...
https://codereview.appspot.com/7312057/
git-svn-id: http://skia.googlecode.com/svn/trunk@7647 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-07 19:45:46 +00:00
robertphillips@google.com
f9d0c95d8d
Temporary patch to BenchPictures gpu timing problem
...
https://codereview.appspot.com/7311059/
git-svn-id: http://skia.googlecode.com/svn/trunk@7641 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-07 16:21:22 +00:00
robertphillips@google.com
8ac811e160
Fixed warning/error in PictureRenderer.cpp
...
TBR by scroggo@google.com
git-svn-id: http://skia.googlecode.com/svn/trunk@7634 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-07 00:13:34 +00:00
scroggo@google.com
905379a74e
In picture rendering tools, draw the entire scaled image.
...
If --scale is used, limit the size of the image drawn to the
scaled picture size, rather than the original picture size.
BUG=https://code.google.com/p/skia/issues/detail?id=1095
Review URL: https://codereview.appspot.com/7307054
git-svn-id: http://skia.googlecode.com/svn/trunk@7633 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-06 22:32:57 +00:00
borenet@google.com
2fd0979c2d
Turn --timeIndividualTiles back on in bench_pictures
...
Review URL: https://codereview.appspot.com/7299049
git-svn-id: http://skia.googlecode.com/svn/trunk@7620 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-06 16:27:38 +00:00
skia.committer@gmail.com
ae683921ff
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7608 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-06 07:01:54 +00:00
robertphillips@google.com
7374355408
Improved compartmentalization of filter tool's optimizations & add new optimization
...
https://codereview.appspot.com/7294049/
git-svn-id: http://skia.googlecode.com/svn/trunk@7601 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-05 20:51:49 +00:00
borenet@google.com
69b50e3584
Fix master IP in submit_try
...
Unreviewed. Should have this reference:
http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7314045
git-svn-id: http://skia.googlecode.com/svn/trunk@7598 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-05 20:26:31 +00:00
bungeman@google.com
5b7bac5ce1
Change comment to avoid warning (don't end line comment with '\').
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7542 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-04 16:24:44 +00:00
skia.committer@gmail.com
747f1ecce6
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7499 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-31 20:28:24 +00:00
robertphillips@google.com
3b0a9fe567
Update filter tool to allow more flexible filtering
...
https://codereview.appspot.com/7227055/
git-svn-id: http://skia.googlecode.com/svn/trunk@7492 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-31 15:56:22 +00:00
scroggo@google.com
08085f808b
Change the method for timing individual tiles in bench_pictures.
...
When timing individual tiles in bench_pictures, keep a timer running
across all repeats, and then take the average. The former method of
timing each iteration separately runs into precision errors on some
platforms.
Running on my Mac Pro with OSX 10.8, the cmsecs for the new method
and the old method are roughly the same when checking the CPU time.
When checking the wall time, the old method often gives me 0ms,
while the new method gives me a larger value. I don't think this
can be entirely attributed to rounding though, since on occasion I
see the old method showing a short time period (.05 - .15ms) while
the new method shows .15ms higher (which is in range for the
difference I'm seeing for other tiles where the old method reports
0ms).
Some other changes:
PictureRenderer::resetState now takes a boolean parameter. If called
with false, it will only do a flush, while if called with true, it
will also call finish.
resetState is now called with true everywhere except in between
iterations of drawing the same tile (when timing individual tiles).
render_pictures_main no longer calls resetState directly, since it
already calls end, which calls resetState.
BUG=http://code.google.com/p/skia/issues/detail?id=1066
Review URL: https://codereview.appspot.com/7101060
git-svn-id: http://skia.googlecode.com/svn/trunk@7424 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-28 20:40:24 +00:00
skia.committer@gmail.com
e16efc1882
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7406 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-26 07:06:02 +00:00
borenet@google.com
a5d621f2ce
Manually parse arguments in submit_try
...
Argparse not supported with Python < 2.7.
Review URL: https://codereview.appspot.com/7206054
git-svn-id: http://skia.googlecode.com/svn/trunk@7403 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 20:55:35 +00:00
rmistry@google.com
647ca8bc89
Leave one and only one newline at the end of source files
...
Review URL: https://codereview.appspot.com/7216043
git-svn-id: http://skia.googlecode.com/svn/trunk@7398 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 18:26:58 +00:00
borenet@google.com
6c55b513bf
Modify submit_try to work on windows
...
Review URL: https://codereview.appspot.com/7199053
git-svn-id: http://skia.googlecode.com/svn/trunk@7379 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-24 21:38:51 +00:00
borenet@google.com
6b5388e71b
Replace gcl_try with submit_try
...
submit_try supports both git and svn and hooks directly into depot_tools rather
than calling it in a subprocess.
Review URL: https://codereview.appspot.com/7202044
git-svn-id: http://skia.googlecode.com/svn/trunk@7352 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 20:54:29 +00:00
borenet@google.com
da7cb28768
Add wrapper for "gcl try"
...
Adds some validation for --bot
Review URL: https://codereview.appspot.com/7179048
git-svn-id: http://skia.googlecode.com/svn/trunk@7315 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 18:23:56 +00:00
jvanverth@google.com
d3c208c53e
Patch for r7304. Add string in bench_pictures_main's gFilterTypes for oval filter type.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7307 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-22 13:54:52 +00:00
skia.committer@gmail.com
4d28d9889b
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7240 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 07:06:06 +00:00
junov@chromium.org
100b1c5e9e
Fixing expression logic from r7237/r7234
...
TBR=borenet
git-svn-id: http://skia.googlecode.com/svn/trunk@7238 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-16 20:12:22 +00:00
robertphillips@google.com
914a2f2823
Compiler warning fixes for r7235
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7237 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-16 19:57:02 +00:00
junov@chromium.org
20bd04e365
Turn on the kUsePathBoundsForClip_RecordingFlag in bench, gm and tools that use class PictureRenderer
...
Chrome uses this flag for recording to skpicture in order to improve performance.
Therefore, skai benchmarks should run with this flag enabled, and we need
gm and render_pictures test coverage to validate it. In gm, the vanilla
SkPicture test step will still run without the flag to ensure that case still gets test
coverage, while the SkPicture test steps that use rtree and tileGrid will now run with
the flag enabled.
Review URL: https://codereview.appspot.com/7111043
git-svn-id: http://skia.googlecode.com/svn/trunk@7234 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-16 18:43:36 +00:00
edisonn@google.com
ca1b3ff634
Add option to ignore small pixel diffs for --validate. By default, right
...
now we will default to max diff of 256, which means that for now we
report all pixels that are not as expected and we do not error out.
Ideally we will decrease the value of max diff to something that does
not have visual impact, e.g. 10, then we will report small changes with
the intensity under 10, but we will error out for anything larger.
Review URL: https://codereview.appspot.com/7137046
git-svn-id: http://skia.googlecode.com/svn/trunk@7232 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-16 18:18:48 +00:00
edisonn@google.com
ddbd83a1e9
revert change 7218
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7220 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-16 15:03:24 +00:00
edisonn@google.com
d17c865634
Add option to ignore small pixel diffs for --validate. By default, right now we will default to max diff of 256, which means that for now we report all pixels that are not as expected and we do not error out. Ideally we will decrease the value of max diff to something that does not have visual impact, e.g. 10, then we will report small changes with the intensity under 10, but we will error out for anything larger.
...
Review URL: https://codereview.appspot.com/7139043
git-svn-id: http://skia.googlecode.com/svn/trunk@7218 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-16 14:47:06 +00:00
reed@google.com
f14e4b0482
Add VALIDATE_FAILURE_IS_A_TOOL_FAILURE to specify whether a failure in validation
...
means the tool should return failure or not. For now it is not defined, which
means any failed pixels are still reported to stdout, but the tool does not
return an error, allowing the bots to go green (until we can fix these failures).
Review URL: https://codereview.appspot.com/7105056
git-svn-id: http://skia.googlecode.com/svn/trunk@7211 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-15 21:54:27 +00:00
bsalomon@google.com
4e23068b37
Re-enable inst counting in debug builds.
...
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7098066
git-svn-id: http://skia.googlecode.com/svn/trunk@7206 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-15 20:37:04 +00:00
robertphillips@google.com
76f9e938df
Added print out of SkShader information to debugger
...
https://codereview.appspot.com/7105045/
git-svn-id: http://skia.googlecode.com/svn/trunk@7201 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-15 20:17:47 +00:00
borenet@google.com
96b17aa461
Turn off timeIndividualTiles
...
The parser isn't working properly.
Review URL: https://codereview.appspot.com/7100057
git-svn-id: http://skia.googlecode.com/svn/trunk@7183 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-15 15:50:42 +00:00
borenet@google.com
b00d670114
Enable per-tile logging in bench_pictures
...
- Modify bench_pictures buildstep to translate "key: True" --> "--key" rather
than requiring "key: value" --> "--key value"
- Add whacky TileArgs helper which includes "timeIndividualTiles: True"
Review URL: https://codereview.appspot.com/7092046
git-svn-id: http://skia.googlecode.com/svn/trunk@7141 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 20:45:24 +00:00
edisonn@google.com
4fa566b34a
Add option to render PDFs to memory only.
...
Review URL: https://codereview.appspot.com/7097045
git-svn-id: http://skia.googlecode.com/svn/trunk@7140 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 20:30:41 +00:00
edisonn@google.com
01754bfd9d
Fix typo, report in validate diff teh value of the pixel, not the address of the pixel.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7135 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-11 16:08:07 +00:00
rmistry@google.com
7492f4ea13
$(SVN_VERSION) -> $SVN_VERSION in build-tot-chromium.sh
...
Review URL: https://codereview.appspot.com/7071053
git-svn-id: http://skia.googlecode.com/svn/trunk@7080 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 15:56:15 +00:00
rmistry@google.com
6b69cbf98c
Script to checkout and build ToT chromium with ToT skia
...
Review URL: https://codereview.appspot.com/7036049
git-svn-id: http://skia.googlecode.com/svn/trunk@7079 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-08 14:43:40 +00:00
reed@google.com
89d15a28b5
fix warnings
...
Review URL: https://codereview.appspot.com/7060053
git-svn-id: http://skia.googlecode.com/svn/trunk@7070 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 22:26:05 +00:00
humper@google.com
f286329ad1
fix warning in render pdf tool
...
BUG=
Review URL: https://codereview.appspot.com/7033056
git-svn-id: http://skia.googlecode.com/svn/trunk@7063 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 20:08:56 +00:00
jvanverth@google.com
9c4e5ac5b7
Cleaned up warnings in Windows build.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7057 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 18:41:28 +00:00
humper@google.com
05af1afd42
eliminate all warnings in non-thirdparty code on mac
...
Most of these issues were due to functions whose definitions appear in header files; I changed those functions to be 'static inline' instead of just 'static' or 'inline', which kills the warning for such functions.
Other functions that were static or anonymous-namespaced but were unused in cpp files were probably called at some point but are no longer; someone who knows more than I do should probably scrub all the functions I either deleted or #if 0'ed out and make sure that the right thing is happening here.
Lots of unused variables removed, and one nasty const issue handled.
There remains a single warning in thirdparty/externals/cityhash/src/city.cc on line 146 related to a signed/unsigned mismatch. I don't know if we have control over this library so I didn't fix this one, but perhaps someone could do something about that one.
BUG=
Review URL: https://codereview.appspot.com/7067044
git-svn-id: http://skia.googlecode.com/svn/trunk@7051 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-07 16:47:43 +00:00
rmistry@google.com
ee5a5eee12
* Extended skdiff to report alpha channel differences.
...
* Created a tools/tests/rebaseline.sh to copy output-actual into output-expected.
* Sample results are available here: http://www.corp.google.com/~rmistry/skia/gm-playback-windows/images-skdiff/
Review URL: https://codereview.appspot.com/7038048
git-svn-id: http://skia.googlecode.com/svn/trunk@7003 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-03 19:23:22 +00:00
epoger@google.com
3aa3358c03
Add more warnings about https://code.google.com/p/skia/issues/detail?id=677 ('make tools/tests/run.sh work cross-platform')
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6965 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-02 15:53:25 +00:00
mike@reedtribe.org
3af2b8def6
fix warnings:
...
- initializer order in PictureRenderer.h
- const in xfermode overrides
git-svn-id: http://skia.googlecode.com/svn/trunk@6946 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-24 18:26:43 +00:00
borenet@google.com
8b95474746
Tweak Android bench_pictures configs
...
Review URL: https://codereview.appspot.com/6970044
git-svn-id: http://skia.googlecode.com/svn/trunk@6895 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-19 14:47:53 +00:00
skia.committer@gmail.com
a7d8e3e990
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6891 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-19 02:01:38 +00:00
edisonn@google.com
84f548cc9d
Flags for render_pictures: verify, clone and writeWholeImage:
...
1) flag to verify PNGs produced by render_picture that produce the same pixels
as simple renderer.
2) flag to write one single image (in tile we write individual tiles) - this
will help running skdiff also
3) flag to clone the picture before rendering
git-svn-id: http://skia.googlecode.com/svn/trunk@6890 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-18 22:24:03 +00:00
borenet@google.com
9afba748fe
Modify bench_pictures configs for Android
...
Review URL: https://codereview.appspot.com/6942064
git-svn-id: http://skia.googlecode.com/svn/trunk@6888 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-18 21:44:53 +00:00
reed@google.com
457d8a77be
remove experimental setAsABlur, as it forces the instance to be mutable, and was
...
not adopted by chrome
Review URL: https://codereview.appspot.com/6939071
git-svn-id: http://skia.googlecode.com/svn/trunk@6879 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-18 18:20:44 +00:00
scroggo@google.com
82ec0b00f3
Allow setting a scaleFactor in bench_pictures (and render_pictures).
...
In TiledPictureRenderer and CopyTilesRenderer, do a postTranslate so
the translate is not affected by the scale factor.
Likewise, use clipRegion for tiled renderer so it will be
unaffected by the scale factor.
Respect the viewport for record, playbackCreation, and pipe renderers.
Review URL: https://codereview.appspot.com/6947072
git-svn-id: http://skia.googlecode.com/svn/trunk@6853 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-17 19:25:54 +00:00
borenet@google.com
3b98bfd402
Address comments for r6822: https://codereview.appspot.com/6946052/
...
Review URL: https://codereview.appspot.com/6943059
git-svn-id: http://skia.googlecode.com/svn/trunk@6847 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-17 17:21:04 +00:00
borenet@google.com
ddf36e73ac
Fix bench_pictures.cfg and add sanity check
...
Review URL: https://codereview.appspot.com/6946052
git-svn-id: http://skia.googlecode.com/svn/trunk@6822 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-14 14:56:37 +00:00
borenet@google.com
8234e5448b
Only run bench_pictures once for debug builds
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6814 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-14 13:04:24 +00:00
scroggo@google.com
cbcef70891
Provide an option to bench drawing individual tiles in bench_pictures.
...
Provides output like the following:
running bench [1236 12045] androidpolice.skp
tile_256x256: tile [0,0] out of [5,48]: msecs = 1.00
tile_256x256: tile [1,0] out of [5,48]: msecs = 1.50
tile_256x256: tile [2,0] out of [5,48]: msecs = 1.00
tile_256x256: tile [3,0] out of [5,48]: msecs = 1.50
tile_256x256: tile [4,0] out of [5,48]: msecs = 2.50
tile_256x256: tile [0,1] out of [5,48]: msecs = 2.00
tile_256x256: tile [1,1] out of [5,48]: msecs = 3.50
tile_256x256: tile [2,1] out of [5,48]: msecs = 3.50
tile_256x256: tile [3,1] out of [5,48]: msecs = 6.00
tile_256x256: tile [4,1] out of [5,48]: msecs = 2.50
tile_256x256: tile [0,2] out of [5,48]: msecs = 2.00
BUG=https://code.google.com/p/skia/issues/detail?id=1016
Review URL: https://codereview.appspot.com/6937047
git-svn-id: http://skia.googlecode.com/svn/trunk@6805 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-13 22:09:28 +00:00
scroggo@google.com
c4013c199c
In the config name, report the viewport, if one is provided.
...
Review URL: https://codereview.appspot.com/6942048
git-svn-id: http://skia.googlecode.com/svn/trunk@6804 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-13 22:07:08 +00:00
scroggo@google.com
c0d5e549ab
Allow bench_pictures to have its viewport set on the command line.
...
Instead of drawing the entire (potentially very large) picture, only
draw one viewport's worth.
example:
bench_pictures <skp directory> --viewport 640 480
BUG=https://code.google.com/p/skia/issues/detail?id=1007
Review URL: https://codereview.appspot.com/6943052
git-svn-id: http://skia.googlecode.com/svn/trunk@6799 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-13 21:40:48 +00:00
junov@chromium.org
3cb834bd27
Modifying SkTileGrid to support arbitrary query rectangles.
...
Exposing SkTileGrid functionality in the public API through SkTileGridPicture.
This patch also makes TileGrid and Rtree testable in gm, which revealed errors.
TEST=gm with '--tileGrid'
BUG=http://code.google.com/p/chromium/issues/detail?id=164636
Review URL: https://codereview.appspot.com/6933044
git-svn-id: http://skia.googlecode.com/svn/trunk@6783 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-13 16:39:53 +00:00
borenet@google.com
1558d68b5c
Add bench_pictures config
...
Review URL: https://codereview.appspot.com/6873073
git-svn-id: http://skia.googlecode.com/svn/trunk@6768 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-12 20:13:26 +00:00
skia.committer@gmail.com
c7b4be7f11
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6746 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-11 02:01:20 +00:00
reed@google.com
5a34fd3f98
add '--mode clone' option to bench_pictures
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6735 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-10 16:05:09 +00:00
skia.committer@gmail.com
c1f224ac07
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6721 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-08 02:01:38 +00:00
robertphillips@google.com
d3d377f1d6
Update filter tool to write out paths to .cpp file
...
https://codereview.appspot.com/6843125/
git-svn-id: http://skia.googlecode.com/svn/trunk@6714 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-07 20:56:13 +00:00
senorblanco@chromium.org
0b6dc190bb
Rebaseline script: check for .git and .svn in the current directory as well. Add mesa to list of configs to update.
...
R=bsalomon@google.com
Review URL: https://codereview.appspot.com/6908050
git-svn-id: http://skia.googlecode.com/svn/trunk@6707 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-07 17:19:07 +00:00
junov@google.com
dbfac8a723
Defining new color constat for transparent color
...
Review URL: https://codereview.appspot.com/6901044
git-svn-id: http://skia.googlecode.com/svn/trunk@6696 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-06 21:47:40 +00:00
bungeman@google.com
df6fe603a5
No longer generating 4444, remove from rebaseline tool.
...
https://codereview.appspot.com/6886048/
git-svn-id: http://skia.googlecode.com/svn/trunk@6692 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-06 19:16:36 +00:00
skia.committer@gmail.com
0264fb4543
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6687 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-06 02:01:25 +00:00
epoger@google.com
128db207ae
Add newline at end of tools/skdiff_html.h to happify the housekeeping bot
...
TBR=bungeman
Review URL: https://codereview.appspot.com/6893043
git-svn-id: http://skia.googlecode.com/svn/trunk@6684 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-05 20:30:00 +00:00
bungeman@google.com
e3c8ddfd03
Update skdiff.
...
https://codereview.appspot.com/6850115/
git-svn-id: http://skia.googlecode.com/svn/trunk@6681 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-12-05 20:13:12 +00:00
skia.committer@gmail.com
c3d7d90973
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6632 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-30 02:01:24 +00:00
senorblanco@chromium.org
123a0b5fbf
rebaseline.py: Allow multiple testnames on the command line.
...
Review URL: https://codereview.appspot.com/6856118
git-svn-id: http://skia.googlecode.com/svn/trunk@6623 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 21:50:34 +00:00
reed@google.com
fe7b1ed30a
add SkPictureUtils::GatherPixelRefs()
...
Review URL: https://codereview.appspot.com/6845106
git-svn-id: http://skia.googlecode.com/svn/trunk@6615 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-29 21:00:39 +00:00
reed@google.com
971aca7557
change SkDrawFilter::filter to return a bool, where false means don't-draw
...
Review URL: https://codereview.appspot.com/6851111
git-svn-id: http://skia.googlecode.com/svn/trunk@6551 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-26 20:26:54 +00:00
scroggo@google.com
4f65a77a1f
Fix a memory leak in skdiff that happens when the
...
directories do not contain the same files.
Only create the bitmaps when we need to use them.
Review URL: https://codereview.appspot.com/6850066
git-svn-id: http://skia.googlecode.com/svn/trunk@6481 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-19 16:30:08 +00:00
djsollen@google.com
a09e8838f2
Update filter tool to allow input directory.
...
Review URL: https://codereview.appspot.com/6847046
git-svn-id: http://skia.googlecode.com/svn/trunk@6399 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-13 18:50:33 +00:00
skia.committer@gmail.com
4349c31077
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6381 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-12 19:41:02 +00:00
epoger@google.com
a413a53cb2
Add a self-test for gm, similar to our self-test for skdiff.
...
Review URL: https://codereview.appspot.com/6827068
git-svn-id: http://skia.googlecode.com/svn/trunk@6380 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-12 18:04:51 +00:00
robertphillips@google.com
4e4d75b06b
Update filter tool to handle PNG encoded SkBitmaps
...
https://codereview.appspot.com/6813094/
git-svn-id: http://skia.googlecode.com/svn/trunk@6379 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-12 18:03:19 +00:00
senorblanco@chromium.org
79fc6fcc59
Add Git support to the simple rebaseline tool. Do SVN commands only in an svn checkout.
...
Review URL: https://codereview.appspot.com/6814099
git-svn-id: http://skia.googlecode.com/svn/trunk@6341 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-07 22:32:12 +00:00
scroggo@google.com
4a26d9d62a
Add a new PictureRenderer that draws the picture then breaks up into tiles.
...
Review URL: https://codereview.appspot.com/6820103
git-svn-id: http://skia.googlecode.com/svn/trunk@6333 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-07 18:01:46 +00:00
scroggo@google.com
a9e3a369c1
Add an option to render_pictures to rerecord the pictures with PNG encoded bitmaps.
...
Review URL: https://codereview.appspot.com/6821092
git-svn-id: http://skia.googlecode.com/svn/trunk@6332 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-07 17:52:48 +00:00
caryclark@google.com
e3e940cf81
Add low blur and AAClip options to picture bench.
...
Copy the settings instead of pointing to the
original set on the stack.
Review URL: https://codereview.appspot.com/6818103
git-svn-id: http://skia.googlecode.com/svn/trunk@6330 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-07 16:42:17 +00:00
reed@google.com
ea6a306457
include SkPaint.h
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6321 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-06 22:14:54 +00:00
caryclark@google.com
411bb7237e
leading character accidentally deleted on merge
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6319 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-06 21:29:16 +00:00
caryclark@google.com
a362237644
add draw filter option to picture_bench
...
Option allows adding a draw filter option per type
or for all types. All SkPaint flags may be filtered,
plus disabling blur and setting the hint level.
Review URL: https://codereview.appspot.com/6816092
git-svn-id: http://skia.googlecode.com/svn/trunk@6318 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-06 21:26:13 +00:00
junov@chromium.org
7b53706a7d
Adding SkTileGrid: a new subclass of BBoxHierarchy, optimized for tiled playback.
...
Review URL: https://codereview.appspot.com/6820093
git-svn-id: http://skia.googlecode.com/svn/trunk@6314 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-06 18:58:43 +00:00
djsollen@google.com
fd9720cfec
Fix the PictureRecord step of BenchPictures.
...
Review URL: https://codereview.appspot.com/6820100
git-svn-id: http://skia.googlecode.com/svn/trunk@6311 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-06 16:54:40 +00:00
skia.committer@gmail.com
1aa90cf11e
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6306 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-06 13:18:25 +00:00
scroggo@google.com
0a049b861e
Make bench_pictures output a meaningful config name.
...
Review URL: https://codereview.appspot.com/6813074
git-svn-id: http://skia.googlecode.com/svn/trunk@6288 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-02 22:01:26 +00:00
scroggo@google.com
a62da2fee7
In bench_pictures --multi, maintain thread local caches.
...
Builds on https://codereview.appspot.com/6718046/ by mtklein.
Previously, each iteration of drawing a picture started new threads to draw the picture. Since each thread is using thread local storage for the font cache, this means that each iteration had to start with an empty font cache.
The newly added MultiCorePictureRenderer, separated from TiledPictureRenderer, now starts the drawing threads at the beginning of the test using an SkThreadPool, and keeps them alive through all iterations, so the font cache can be reused.
For now, I have removed the pipe version of the threaded renderer.
Updated bench_pictures_main and render_pictures_main to use the new
renderer, and to unref a renderer before early exit.
Review URL: https://codereview.appspot.com/6777063
git-svn-id: http://skia.googlecode.com/svn/trunk@6285 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-02 21:28:12 +00:00
junov@chromium.org
50ff9bd4d7
Fixing crash in render_pictures. Uninitialized member in PictureRenderer
...
TBR=scroggo
git-svn-id: http://skia.googlecode.com/svn/trunk@6272 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-02 19:16:22 +00:00
junov@chromium.org
9313ca4bde
Adding rtree support to the bench_pictures utility
...
Review URL: https://codereview.appspot.com/6775080
git-svn-id: http://skia.googlecode.com/svn/trunk@6267 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-02 18:11:49 +00:00
skia.committer@gmail.com
760f2d95dd
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6258 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-02 02:01:24 +00:00
edisonn@google.com
9cf5b28648
Support render_pdfs in iOS too (add tool_main()).
...
git-svn-id: http://skia.googlecode.com/svn/trunk@6254 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-01 20:07:33 +00:00
edisonn@google.com
c319abeeef
Add utility to convert skp files to pdf files. Code compatible with render_pictures_main.cpp. I could have refactored the code to avoid code duplication, but it does not seem right, and it will overcomplicate the code.
...
Review URL: https://codereview.appspot.com/6615073
git-svn-id: http://skia.googlecode.com/svn/trunk@6253 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-11-01 19:52:38 +00:00
senorblanco@chromium.org
5682f21f99
Simple rebaseline tool: Add support for ANGLE, DirectWrite builders.
...
Set svn mime type to image/png.
Review URL: https://codereview.appspot.com/6820054
git-svn-id: http://skia.googlecode.com/svn/trunk@6199 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-30 14:34:55 +00:00
senorblanco@chromium.org
782f3b4230
First stab at a simple rebaseline script.
...
Review URL: https://codereview.appspot.com/6775045
git-svn-id: http://skia.googlecode.com/svn/trunk@6170 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-29 18:06:26 +00:00
borenet@google.com
070d354d51
Make output path to render_pictures optional
...
Review URL: https://codereview.appspot.com/6779049
git-svn-id: http://skia.googlecode.com/svn/trunk@6136 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-26 13:26:55 +00:00
robertphillips@google.com
831c726f83
Correctly set width & height in filtered SkPictures
...
https://codereview.appspot.com/6772047/
git-svn-id: http://skia.googlecode.com/svn/trunk@6103 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-25 14:45:08 +00:00
robertphillips@google.com
63f1127a70
Make filter tool actually filter the read in SkPicture
...
https://codereview.appspot.com/6765046/
git-svn-id: http://skia.googlecode.com/svn/trunk@6080 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-24 19:30:41 +00:00
robertphillips@google.com
801cee1d4c
Added ability to extract SkBitmaps to filter tool
...
https://codereview.appspot.com/6748043/
git-svn-id: http://skia.googlecode.com/svn/trunk@6021 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-19 19:06:11 +00:00
scroggo@google.com
b8e404aebe
Fix a warning.
...
Review URL: https://codereview.appspot.com/6650048
git-svn-id: http://skia.googlecode.com/svn/trunk@5902 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-11 19:10:33 +00:00
borenet@google.com
efb1d77ad2
Build Skia as a static library
...
- Roll GYP so that we get non-thin archives on Linux
- Add merge_static_libs.py
- Add skia_core_lib target which builds core, ports, opts*, and utils
- Replace dependencies on core/ports/opts/utils with skia_core_libs
- Rename exportable libraries with "skia_"
Review URL: https://codereview.appspot.com/6619049
git-svn-id: http://skia.googlecode.com/svn/trunk@5889 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-10 19:45:51 +00:00
edisonn@google.com
2a827e81b3
Add an SKP to PDF rendered. test_pdfs.py will be hooked up in buildbot testing later.
...
Review URL: https://codereview.appspot.com/6610056
git-svn-id: http://skia.googlecode.com/svn/trunk@5880 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-10 15:20:34 +00:00
edisonn@google.com
c2c4981d02
Refactor test_pictures so we can add test_pdfs without code duplication.
...
Review URL: https://codereview.appspot.com/6611050
git-svn-id: http://skia.googlecode.com/svn/trunk@5878 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-10 15:08:12 +00:00
caryclark@google.com
9598f4256d
fix filter for ios
...
Review URL: https://codereview.appspot.com/6635047
git-svn-id: http://skia.googlecode.com/svn/trunk@5859 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-09 12:32:37 +00:00
tfarina@chromium.org
a5b7cc00b9
Remove unnecessary function declaration.
...
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6593082
git-svn-id: http://skia.googlecode.com/svn/trunk@5851 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-08 14:41:10 +00:00
scroggo@google.com
5a7c6be72b
Add the ability to provide function pointers to SkPicture serialization
...
and deserialization for encoding and decoding bitmaps.
Remove kForceFlattenBitmapPixels_Flag, which is no longer used.
When an SkOrderedReadBuffer needs to read a bitmap, if it does not
have an image decoder, use a dummy bitmap.
In GM, add a tolerance option for color differences, used when
testing picture serialization, so it can assume two images are the
same even though PNG encoding/decoding may have resulted in small
differences.
Create dummy implementations for SkImageDecoder and SkImageEncoder
functions in SkImageDecoder_empty so that a project that does not
want to include the images project it can still build.
Allow ports to build without images project.
In Mac's image encoder, copy 4444 to 8888 before encoding.
Add SkWriter32::reservePad, to provide a pointer to write non 4 byte
aligned data, padded with zeroes.
In bench_ and render_ pictures, pass decode function to SkPicture
creation from a stream.
BUG=https://code.google.com/p/skia/issues/detail?id=842
Review URL: https://codereview.appspot.com/6551071
git-svn-id: http://skia.googlecode.com/svn/trunk@5818 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-04 21:46:08 +00:00
robertphillips@google.com
c7e4a5a02a
Created filter command line tool
...
https://codereview.appspot.com/6595066/
git-svn-id: http://skia.googlecode.com/svn/trunk@5803 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-04 13:00:33 +00:00
scroggo@google.com
b6e806bf17
Allow render_pictures to render using multiple threads.
...
Make write() a static function so it can be used by the
thread entry functions.
Add a helper function to append a number to a string and
call write to share code.
Review URL: https://codereview.appspot.com/6589062
git-svn-id: http://skia.googlecode.com/svn/trunk@5789 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-03 17:32:33 +00:00
caryclark@google.com
868e1f682e
fix return value for render_pictures
...
Review URL: https://codereview.appspot.com/6590049
git-svn-id: http://skia.googlecode.com/svn/trunk@5779 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-02 20:00:03 +00:00
caryclark@google.com
5987f58036
build iOS with 'make all'
...
This builds all skia tests by treating iOS tools
as executable applications. A few warnings were
fixed as well.
Removed old trace draw code and remnants.
Review URL: https://codereview.appspot.com/6597063
git-svn-id: http://skia.googlecode.com/svn/trunk@5776 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-02 18:33:14 +00:00
scroggo@google.com
b4773b4802
Fix some bugs in our picture tools.
...
When doing tiled rendering in multiple threads, clone fPicture,
rather than the blank fPictureClones. Also fix a precedence
problem so we get the correct rectangle.
In render_pictures_main, call PictureRenderer::setup().
Review URL: https://codereview.appspot.com/6585055
git-svn-id: http://skia.googlecode.com/svn/trunk@5758 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-10-01 20:06:09 +00:00
fmalita@google.com
c6157be6c0
Pinspect and bench_pictures are crashing when invoked with no arguments.
...
R=reed@google.com ,scroggo@google.com
BUG=
Review URL: https://codereview.appspot.com/6575052
git-svn-id: http://skia.googlecode.com/svn/trunk@5706 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-27 13:09:58 +00:00
borenet@google.com
71f0f8e1ca
Fix update-doxygen (again)
...
Bash trickery to find the script directory did not work, but we can just use
"trunk/tools" since trunk gets checked out into $DOXYGEN_TEMPDIR.
Review URL: https://codereview.appspot.com/6573055
git-svn-id: http://skia.googlecode.com/svn/trunk@5696 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-26 16:25:22 +00:00
borenet@google.com
72e3403914
Fix update-doxygen, which fails when skia-autogen is reset
...
static_footer.txt was removed from skia/docs in r2837, but update-doxygen.sh
requires it to exist in skia-autogen. If skia-autogen is cleared (frequently),
then static_footer.txt can't be found. Add it back to trunk/tools and manually
copy it if needed.
Review URL: https://codereview.appspot.com/6568054
git-svn-id: http://skia.googlecode.com/svn/trunk@5694 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-26 16:09:43 +00:00
tfarina@chromium.org
e0e71afc66
Remove unused includes from skhello tool.
...
R=epoger@google.com
Review URL: https://codereview.appspot.com/6546063
git-svn-id: http://skia.googlecode.com/svn/trunk@5676 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-25 20:16:46 +00:00
scroggo@google.com
3686c9d90a
Fix a warning in PictureBenchmark.
...
Forgot to change from false to NULL. False does the right thing,
but gives a warning. Fix the warning.
Review URL: https://codereview.appspot.com/6570049
git-svn-id: http://skia.googlecode.com/svn/trunk@5666 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-25 17:36:36 +00:00
borenet@google.com
2d2b9a0d8c
Remove automatic resizing in *_pictures
...
Review URL: https://codereview.appspot.com/6554045
git-svn-id: http://skia.googlecode.com/svn/trunk@5614 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-20 18:54:04 +00:00
scroggo@google.com
81f9d2e05b
In render_pictures tiled rendering, draw a separate PNG for each tile.
...
Since the passed in picture may represent an image which is too large
to be represented on the GPU, never create such a large canvas. Instead,
after drawing to each tile, create a file showing just that tile.
Review URL: https://codereview.appspot.com/6532056
git-svn-id: http://skia.googlecode.com/svn/trunk@5603 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-20 14:54:21 +00:00
scroggo@google.com
bcdf2ec50d
In bench_pictures, use a pool of tiles for multicore drawing.
...
Also includes some code cleanup and code sharing.
Allow setting the number of threads on the command line.
Rename ThreadSafePipeController::playback to ::draw, to be the same
as SkPicture so DrawTileToCanvas can take a template parameter.
Disallow multithreading with GPU turned on.
Display help information with improper tiled arguments.
BUG=https://code.google.com/p/skia/issues/detail?id=871
Review URL: https://codereview.appspot.com/6536050
git-svn-id: http://skia.googlecode.com/svn/trunk@5602 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-20 14:42:33 +00:00
borenet@google.com
57837bff3d
Skip empty directories and input files not ending in .skp in *_pictures
...
Addressing https://code.google.com/p/skia/issues/detail?id=886
Review URL: https://codereview.appspot.com/6531047
git-svn-id: http://skia.googlecode.com/svn/trunk@5597 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-19 17:28:29 +00:00
scroggo@google.com
acfb30e5bb
Reuse one canvas for every tile in bench_pictures (in single threaded mode).
...
Turn off multi threaded option for now.
In bench_pictures, do not create a large canvas, since we never use it.
Remove unused functions on TiledPictureRenderer.
Review URL: https://codereview.appspot.com/6521043
git-svn-id: http://skia.googlecode.com/svn/trunk@5583 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-18 14:32:35 +00:00
borenet@google.com
13fd5a15a1
Set DEFAULT_REPEATS to 1
...
bench defaults to 1 repeat, so bench_pictures should do the same.
This is causing the Android build cycles to be *hours* long.
Review URL: https://codereview.appspot.com/6490123
git-svn-id: http://skia.googlecode.com/svn/trunk@5575 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 21:10:05 +00:00
borenet@google.com
66bcbd12bf
Check for invalid SkPictures
...
- Remove hasRecorded() since nobody uses it.
- Add "success" boolean to SkPicture stream constructor
- Track failures in render_pictures and bench_pictures
Review URL: https://codereview.appspot.com/6493105
git-svn-id: http://skia.googlecode.com/svn/trunk@5573 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-17 18:26:06 +00:00
borenet@google.com
3a8b0d8288
Scale even smaller in bench_pictures to get things green
...
Over-the-shoulder review from reed@
Review URL: https://codereview.appspot.com/6512043
git-svn-id: http://skia.googlecode.com/svn/trunk@5545 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 15:27:41 +00:00
borenet@google.com
e21795e277
Enable automatic rescaling in bench_pictures
...
bench_pictures with "--device gpu" is failing because we're trying to allocate
too much GPU memory. Move the recently-added scaling code into picture_utils
and share it between render_pictures and bench_pictures.
Review URL: https://codereview.appspot.com/6495125
git-svn-id: http://skia.googlecode.com/svn/trunk@5543 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 14:34:28 +00:00
skia.committer@gmail.com
1d225f2b33
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5539 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-14 02:01:10 +00:00
borenet@google.com
a49bffdb03
Do not exit on failure to open logFile
...
Temporary solution for write-protected Android devices. Intention is to revert
in favor of a more permanent solution.
Review URL: https://codereview.appspot.com/6497132
git-svn-id: http://skia.googlecode.com/svn/trunk@5535 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 18:54:48 +00:00
reed@google.com
e04e92b19f
To avoid running out of memory, we rescale very large pictures before we
...
render them.
Review URL: https://codereview.appspot.com/6504045
git-svn-id: http://skia.googlecode.com/svn/trunk@5530 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 17:44:32 +00:00
robertphillips@google.com
163c84ba50
Added GPU resource cache stats printing to render_pictures
...
https://codereview.appspot.com/6492104/
git-svn-id: http://skia.googlecode.com/svn/trunk@5523 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-13 15:40:37 +00:00
scroggo@google.com
5239c32d1e
Add -logPerIter, -timers, and -min to bench_pictures.
...
Additional changes:
Add instance count to bench_pictures.
Remove various PictureBenchmark subclasses which did not do
anything besides have a different PictureRenderer.
BUG=https://code.google.com/p/skia/issues/detail?id=856
Review URL: https://codereview.appspot.com/6496109
git-svn-id: http://skia.googlecode.com/svn/trunk@5496 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-11 19:15:32 +00:00
bungeman@google.com
7c961e9e5a
Baseline DirectWrite.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5487 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-11 17:29:37 +00:00
scroggo@google.com
0a36f43d5f
Init graphics in bench_pictures.
...
Should fix http://code.google.com/p/skia/issues/detail?id=858
Review URL: https://codereview.appspot.com/6490100
git-svn-id: http://skia.googlecode.com/svn/trunk@5475 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-10 20:29:13 +00:00
rileya@google.com
a04dc02b11
Fix ordering of initializer list to fix compiler complaints.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5472 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-10 19:01:38 +00:00
borenet@google.com
03fcee8164
Add per-picture logging to render_pictures
...
This will be helpful for debugging crashes
Review URL: https://codereview.appspot.com/6495112
git-svn-id: http://skia.googlecode.com/svn/trunk@5469 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-10 18:18:38 +00:00
borenet@google.com
10ef79ec95
Fix render_pictures for skia_static_initializers=0
...
Review URL: https://codereview.appspot.com/6500097
git-svn-id: http://skia.googlecode.com/svn/trunk@5465 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-10 17:19:06 +00:00
epoger@google.com
f5ad077741
download_baselines: allow user to select which builder's images to download
...
BUG=806
Review URL: https://codereview.appspot.com/6492091
git-svn-id: http://skia.googlecode.com/svn/trunk@5435 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-07 16:05:34 +00:00
scroggo@google.com
9a4125283a
Report data from bench_pictures in the same fashion as bench.
...
Move SkBenchLogger into separate files and make bench_pictures use it.
Remove sk_tools::print_msg, since SkBenchLogger is now used instead.
Combine picture_benchmark with bench_pictures, since that is the
only project that uses it.
Refactor the aggregator for bench timer data into its own class and
make bench_pictures use it.
Consolidate the various virtual PictureBenchmark::run functions
into one for reuse.
BUG=https://code.google.com/p/skia/issues/detail?id=822
Review URL: https://codereview.appspot.com/6488086
git-svn-id: http://skia.googlecode.com/svn/trunk@5432 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-07 15:21:18 +00:00
robertphillips@google.com
94acc70312
Fixed Windows compiler complaints (esp. in debugger)
...
https://codereview.appspot.com/6497090/
git-svn-id: http://skia.googlecode.com/svn/trunk@5419 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-06 18:43:21 +00:00
bsalomon@google.com
100abf49e1
Shut up some Mac (xcode 3) warnings
...
Review URL: http://codereview.appspot.com/6503053/
git-svn-id: http://skia.googlecode.com/svn/trunk@5402 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-09-05 17:40:04 +00:00
scroggo@google.com
6bc8cf8f64
Fix windows build of tools.
...
Review URL: https://codereview.appspot.com/6494068
git-svn-id: http://skia.googlecode.com/svn/trunk@5374 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-31 18:34:09 +00:00
skia.committer@gmail.com
11f869277c
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5373 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-31 17:14:46 +00:00
scroggo@google.com
8e073ba2d6
Rename my DeferredPipeController to not conflict with the other.
...
Fixes build.
Review URL: https://codereview.appspot.com/6506055
git-svn-id: http://skia.googlecode.com/svn/trunk@5372 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-31 16:25:46 +00:00
scroggo@google.com
58b4ead36c
Perform multi core rendering in bench_pictures.
...
Add a flag in SkGPipeWriter for threadsafe drawing.
Add a deferred pipe controller to SamplePipeControllers, which can
be called to play back in multiple threads.
Depends on http://codereview.appspot.com/6459105/
Review URL: https://codereview.appspot.com/6482068
git-svn-id: http://skia.googlecode.com/svn/trunk@5371 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-31 16:15:22 +00:00
reed@google.com
b1d47e211c
add --dump-ops option to pinspect, which will invoke SkDumpCanvas on the picture(s)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5370 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-31 15:41:37 +00:00
jkleinert@google.com
ed01f12d13
Adding checkboxes to skdiff output so a user can select a subset of images to rebaseline.
...
BUG=745
Review URL: https://codereview.appspot.com/6497054
git-svn-id: http://skia.googlecode.com/svn/trunk@5360 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-30 22:05:53 +00:00
rileya@google.com
b947b91794
Fix uninitialized values in bench_pictures' tiled renderer.
...
Review URL: https://codereview.appspot.com/6506049
git-svn-id: http://skia.googlecode.com/svn/trunk@5333 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-29 17:35:07 +00:00
rileya@google.com
edfbff683e
Change picture record benchmark to include begin/end record in timings and make the source picture draw itself into record canvas, so it records the draws instead of directly copying the picture.
...
Review URL: https://codereview.appspot.com/6501045
git-svn-id: http://skia.googlecode.com/svn/trunk@5323 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-28 19:13:39 +00:00
borenet@google.com
3578eb7d06
Move gm baselines from trunk/gm to gm-expected
...
- Move images
- Update build slaves with the change
- Update baseline tools with the change
git-svn-id: http://skia.googlecode.com/svn/trunk@5319 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-28 16:53:10 +00:00
robertphillips@google.com
91ee3a11ed
Added second "truncated" cpu/wall timer to bench
...
http://codereview.appspot.com/6476064/
This CL will increase the bench baselines across the board
git-svn-id: http://skia.googlecode.com/svn/trunk@5305 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-28 12:18:40 +00:00
borenet@google.com
405ebbcade
Script to help cycle skia-autogen
...
Review URL: https://codereview.appspot.com/6481066
git-svn-id: http://skia.googlecode.com/svn/trunk@5291 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-27 19:37:48 +00:00
bungeman@google.com
6e59e498e5
Rebaseline for r5280.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5281 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-24 19:49:29 +00:00
rmistry@google.com
0032407e29
Created to fix http://code.google.com/p/skia/issues/detail?id=817 : UpdateDoxygen step does not fail when Doxygen step fails.
...
Review URL: https://codereview.appspot.com/6480060
git-svn-id: http://skia.googlecode.com/svn/trunk@5278 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-24 17:16:05 +00:00
keyar@chromium.org
e599ab74ac
Updated options for test_picturs.py to match new option in render_pictures.
...
Review URL: https://codereview.appspot.com/6481056
git-svn-id: http://skia.googlecode.com/svn/trunk@5275 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-23 21:51:11 +00:00
keyar@chromium.org
f4959ab118
Implemented power of two tiling.
...
Review URL: https://codereview.appspot.com/6485056
git-svn-id: http://skia.googlecode.com/svn/trunk@5274 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-23 20:53:25 +00:00
rmistry@google.com
d6176b0dca
Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/ )
...
This CL is part II of IV (I broke down the 1280 files into 4 CLs).
Review URL: https://codereview.appspot.com/6474054
git-svn-id: http://skia.googlecode.com/svn/trunk@5263 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-23 18:14:13 +00:00
keyar@chromium.org
ea82695325
Changed how tiles are copied to the master canvas.
...
This is in preparation for adding the powers of two mode.
Review URL: https://codereview.appspot.com/6464087
git-svn-id: http://skia.googlecode.com/svn/trunk@5254 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-23 15:24:13 +00:00
rmistry@google.com
3de7b21efa
Fix bug in tools/sanitize_source_files.py
...
Review URL: https://codereview.appspot.com/6474053
git-svn-id: http://skia.googlecode.com/svn/trunk@5253 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-23 14:46:18 +00:00
rmistry@google.com
b1faddffd8
The script does the following:
...
* Adds a newline to the end of files if it does not have one.
* Sets svn:eol-style to LF.
* Replaces CRLF with LF.
* Replaces Tabs with 4 whitespaces.
* Removes trailing whitespaces.
Created to fix http://code.google.com/p/skia/issues/detail?id=779 : New buildbot step that fixes and submits whitespace and newline source file fixes.
Review URL: https://codereview.appspot.com/6465078
git-svn-id: http://skia.googlecode.com/svn/trunk@5234 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-22 18:10:37 +00:00
keyar@chromium.org
9299eded38
Images are written by PictureRenderer and not render_pictures_main.
...
Review URL: https://codereview.appspot.com/6448174
git-svn-id: http://skia.googlecode.com/svn/trunk@5216 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-21 19:05:08 +00:00
keyar@chromium.org
db9a5fb55f
Benchmark results will now print to STDOUT if on not-Android.
...
Review URL: https://codereview.appspot.com/6446164
git-svn-id: http://skia.googlecode.com/svn/trunk@5215 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-21 17:57:59 +00:00
keyar@chromium.org
da652c2ad5
Removed the TileInfo struct used in TiledPictureRenderer.
...
Review URL: https://codereview.appspot.com/6443153
git-svn-id: http://skia.googlecode.com/svn/trunk@5206 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 22:04:07 +00:00
keyar@chromium.org
b3fb7c1f46
Added copyright notice to PictureRenderer.cpp
...
Review URL: https://codereview.appspot.com/6453156
git-svn-id: http://skia.googlecode.com/svn/trunk@5203 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 21:02:49 +00:00
keyar@chromium.org
f0fed9f978
test_pictures.py will now look for render_pictures.exe and skdiff.exe
...
Before it was not and so was failing on Windows.
Review URL: https://codereview.appspot.com/6468043
git-svn-id: http://skia.googlecode.com/svn/trunk@5191 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 17:33:06 +00:00
keyar@chromium.org
28136b308f
flush() and glFinish() are now in the timed area of rendering.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5187 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:04:15 +00:00
keyar@chromium.org
a40c20df0e
Fixed up SK_SUPPORT_GPU flags.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5186 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:04:12 +00:00
keyar@chromium.org
378c97fae0
Deleted timer for record and unflatten benchmarks.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5185 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:04:09 +00:00
keyar@chromium.org
bffacc01d6
Added some assertions.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5184 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:04:07 +00:00
keyar@chromium.org
c81686cd6e
Added the option to enable GPU rendering on render_ and bench_pictures.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5183 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:04:04 +00:00
keyar@chromium.org
6cb110b8f5
Remove fBitmap delete. Tile bitmaps are no longer kept around.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5182 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:04:02 +00:00
keyar@chromium.org
275be533fa
The tiles are properly reset.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5181 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:04:00 +00:00
keyar@chromium.org
a474ce3c0b
TiledPictureRenderer now has tiles accelerated when appropiate.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5180 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:03:57 +00:00
keyar@chromium.org
941844b3f9
Changed new and delete to SkNEW* and SkDELETE as appropriate.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5179 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:03:54 +00:00
keyar@chromium.org
f8a513fbcd
resetState is called between every benchmark run.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5178 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:03:52 +00:00
keyar@chromium.org
77a5522d0e
State reset and gpu timers added.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5177 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:03:47 +00:00
keyar@chromium.org
78a35c5f1d
Changed to Yoda style comparisons where appropriate.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5176 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:03:44 +00:00
keyar@chromium.org
fe6391a624
Have GPU based approach workingish.
...
Benchmarks do not work and it is always on.
git-svn-id: http://skia.googlecode.com/svn/trunk@5175 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:03:41 +00:00
keyar@chromium.org
02dfb12501
Minor whitespace change.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5173 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:03:36 +00:00
keyar@chromium.org
0612564bb7
The GrContext and the GrFactoryContext are now kept around.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5172 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:03:33 +00:00
keyar@chromium.org
4ea96c5e54
Dirty commit so Brian can see changes.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@5171 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-20 15:03:29 +00:00
epoger@google.com
71329d809a
skdiff: recurse over subdirectories, unless --norecurse option is given
...
in anticipation of https://code.google.com/p/skia/issues/detail?id=743 ('move gm baselines outside of trunk, and modify naming convention')
Review URL: https://codereview.appspot.com/6465053
git-svn-id: http://skia.googlecode.com/svn/trunk@5121 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 13:42:13 +00:00
robertphillips@google.com
5d8d18651a
Addressed Windows compiler complaints
...
http://codereview.appspot.com/6462062/
This CL will require re-baselining of the imagemagnifier GM
git-svn-id: http://skia.googlecode.com/svn/trunk@5108 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 14:36:41 +00:00
tomhudson@google.com
8afae61a57
Clean up most clang warnings outside animator/
...
http://codereview.appspot.com/6464058/
git-svn-id: http://skia.googlecode.com/svn/trunk@5079 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 15:03:35 +00:00
epoger@google.com
21ecba88cd
skdiff: clean up isPathAbsolute check for Windows
...
This is a followup to https://codereview.appspot.com/6458046/ ('Fix skdiff when using windows path that begins with a drive letter')
Review URL: https://codereview.appspot.com/6450106
git-svn-id: http://skia.googlecode.com/svn/trunk@5004 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-08 13:47:39 +00:00
keyar@chromium.org
9d696c0d04
Refactored the bitmap creation into PictureRenderer.
...
Further, the picture is also stored in the PictureRenderer.
The main gain of all of this is that we will not have to change how the device in more than one place when we end up adding different devices.
Review URL: https://codereview.appspot.com/6458074
git-svn-id: http://skia.googlecode.com/svn/trunk@4990 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-07 17:11:33 +00:00
keyar@chromium.org
795cd47342
render_pictures and bench_pictures now use a --mode parameter.
...
This replaces the --tile, --pipe, etc. options from before as they are mutually exclusive.
Review URL: https://codereview.appspot.com/6443076
git-svn-id: http://skia.googlecode.com/svn/trunk@4930 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-02 18:57:53 +00:00
keyar@chromium.org
163b56734f
Merged bench_pictures and render_pictures rendering methods.
...
bench_pictures now uses a class based method for choosing the benchmark type as well.
Review URL: https://codereview.appspot.com/6452070
git-svn-id: http://skia.googlecode.com/svn/trunk@4894 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-01 17:53:29 +00:00
bsalomon@google.com
f1478f8803
Fix skdiff when using windows path that begins with a drive letter
...
Review URL: https://mail.google.com/mail/u/0/?shva=1#inbox/138d92244ca33549
git-svn-id: http://skia.googlecode.com/svn/trunk@4838 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-07-30 19:16:02 +00:00