AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
16,922 Commits 1 Branch 0 Tags 544 MiB
16b254a200
Commit Graph

16922 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
senorblanco
16b254a200 Change some more GMs to clear to opaque black, not transparent black. 
N.B.: this will change results on the bots for all the tests modified.

BUG=skia:3319

Review URL: https://codereview.chromium.org/1077763002
 2015-04-09 11:13:24 -07:00
tomhudson
2df6fd650c Avoid sending empty bitmaps through proxy canvas 
Some back ends may crash when asked to draw an empty bitmap, so we
filter it out here.

BUG=skia:3692
R=djsollen@google.com,reed@google.com

Review URL: https://codereview.chromium.org/1072033002
 2015-04-09 09:20:19 -07:00
mtklein
a67572ff91 Remove ARM assembly memsets. 
Step 1 of a zillion in the quest for NEON on iOS,
and step 1 of a different zillion in the Great Assembly Purge.

ios, arm, arm64, arm_v7, arm_v7_neon all build.

BUG=skia:

Review URL: https://codereview.chromium.org/1072063002
 2015-04-09 09:16:28 -07:00
fmalita
055f6b59d8 [SkTextBlob] Custom run font record 
Instead of using a full-blown SkPaint to store run font info, use a
custom structure.

This saves 96 bytes / run on 64bit platforms.

R=reed@google.com,mtklein@google.com,joshualitt@google.com

Review URL: https://codereview.chromium.org/1070943002
 2015-04-09 08:49:32 -07:00
reed
0b18c3554c add test for opaque-preserving colormatrixfilters 
BUG=skia:

Review URL: https://codereview.chromium.org/1069463002
 2015-04-09 08:27:27 -07:00
joshualitt
62db8ba68b fix for perf regression on ugamsolutions / msaa16 
BUG=skia:

Review URL: https://codereview.chromium.org/1076853002
 2015-04-09 08:22:37 -07:00
jvanverth
8ed3b9a386 Rename DistanceFieldTextureEffect.{cpp,h} 
BUG=skia:

Review URL: https://codereview.chromium.org/1073473005
 2015-04-09 08:00:49 -07:00
stephana
195f62d07d BUG=skia: 
Review URL: https://codereview.chromium.org/1054073003
 2015-04-09 07:57:54 -07:00
mtklein
29b1afc169 Rearrange SkRecord with small N in mind 
This rearranges the record pointers and types so they can go in a single array, then preallocates some space for them and for the SkVarAlloc.

picture_overhead_draw bench drops from ~1000ns to 500-600ns, with no effect on picture_overhead_nodraw.

I don't see any significant effect on large picture recording times from our .skps.

BUG=chromium:470553

Committed: https://skia.googlesource.com/skia/+/e2dd9408cd711777afaa9410427fb0d761ab004a

Review URL: https://codereview.chromium.org/1061783002
 2015-04-09 07:46:41 -07:00
djsollen
7178a3b595 Update DEPS to use a cloned copy of libpng 
BUG=skia:3689

Review URL: https://codereview.chromium.org/1077673002
 2015-04-09 07:33:23 -07:00
robertphillips
e275fdf812 Add GM to repro crbug.com/472795 
This CL also adds a new parameter to SkBitmapSource which gives the user control of the filter quality.

BUG=472795

Review URL: https://codereview.chromium.org/1072603002
 2015-04-09 06:47:12 -07:00
fmalita
f57546ec7f Remove SK_SUPPORT_LEGACY_SCALAR_MAPPOINTS 
No longer used in Chromium.

Also drop now-unused SkMatrix::Rot_pts() & SkMatrix::RotTrans_pts().

BUG=475022
R=reed@google.com,mtklein@google.com

Review URL: https://codereview.chromium.org/1071833002
 2015-04-09 06:13:15 -07:00
jbroman
7d1b945da6 Mark SkPictureRecorder::endRecording as SK_WARN_UNUSED_RESULT. 
Ignoring the result is a memory leak.
Callers should always at least unref the result.

This bug has occurred in Blink:
  https://codereview.chromium.org/1068413002/

BUG=skia:3680

Review URL: https://codereview.chromium.org/1072633002
 2015-04-09 06:12:17 -07:00
mtklein
d9f8862ab6 Valgrind sez: new[] wants delete[]. 
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind/builds/17/steps/dm/logs/stdio

TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1075853002
 2015-04-09 03:20:04 -07:00
Mike Klein
fbcf0bd7ff expand pdf/worldjournal blacklist entry to cover the new skp too 
BUG=skia:

Review URL: https://codereview.chromium.org/1070013002
 2015-04-09 06:03:22 -04:00
mtklein
35f55764b8 Revert of Rearrange SkRecord with small N in mind (patchset #8 id:120001 of https://codereview.chromium.org/1061783002/) 
Reason for revert:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug/builds/149/steps/dm/logs/stdio

Original issue's description:
> Rearrange SkRecord with small N in mind
>
> This rearranges the record pointers and types so they can go in a single array, then preallocates some space for them and for the SkVarAlloc.
>
> picture_overhead_draw bench drops from ~1000ns to 500-600ns, with no effect on picture_overhead_nodraw.
>
> I don't see any significant effect on large picture recording times from our .skps.
>
> BUG=chromium:470553
>
> Committed: https://skia.googlesource.com/skia/+/e2dd9408cd711777afaa9410427fb0d761ab004a

TBR=reed@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:470553

Review URL: https://codereview.chromium.org/1068383003
 2015-04-08 14:09:41 -07:00
mtklein
e2dd9408cd Rearrange SkRecord with small N in mind 
This rearranges the record pointers and types so they can go in a single array, then preallocates some space for them and for the SkVarAlloc.

picture_overhead_draw bench drops from ~1000ns to 500-600ns, with no effect on picture_overhead_nodraw.

I don't see any significant effect on large picture recording times from our .skps.

BUG=chromium:470553

Review URL: https://codereview.chromium.org/1061783002
 2015-04-08 14:02:32 -07:00
halcanary
16e833d5aa SkString: remove fStr member 
Motivation:  I'd like sizeof(SkString) to be the same in Debug and Release.

Review URL: https://codereview.chromium.org/1073473003
 2015-04-08 13:01:22 -07:00
jvanverth
502286d7b8 Rename the distance field geoprocs to something more reasonable. 
Prep for adding Mali fix for distance field paths.

BUG=skia:3528

Review URL: https://codereview.chromium.org/1075543002
 2015-04-08 12:37:51 -07:00
senorblanco
aad8b27ec6 Use opaque black not transparent black as imagefilter GM background. 
For some reason, GM's are now being composited against white
in some modes, where the alpha used to be ignored (or composited
against black, I'm not sure which). At any rate, it doesn't
make much sense to have alpha in the result anyway, so let's clear to
opaque black instead of transparent black and avoid the problem.

This is a trial balloon for bitmapsource and pictureimagefilter.
If all goes well, I'll make this change more widely.

R=scroggo
BUG=skia:3319

Review URL: https://codereview.chromium.org/1074513002
 2015-04-08 12:36:08 -07:00
Derek Sollenberger
a0219f1565 Fail gracefully when dm.json is not present 
Review URL: https://codereview.chromium.org/1073593002
 2015-04-08 15:20:25 -04:00
mtklein
feaadee1c3 SkCanvas::resetForNextPicture() 
No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu.

  picture_overhead_draw	1.62us ->  1.6us	0.99x
picture_overhead_nodraw	 792ns ->  342ns	0.43x

tiles and serialization modes will also test this a bit.

BUG=chromium:470553

Committed: https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d

Review URL: https://codereview.chromium.org/1067893002
 2015-04-08 11:25:48 -07:00
bsalomon
3f324321cd Add mechanism to proactively purge old resources in GrResourceCache. 
This change leaves the feature turned off by default.

Review URL: https://codereview.chromium.org/1032873002
 2015-04-08 11:01:55 -07:00
joshualitt
b7133bed55 Adding a cache + memory pool for GPU TextBlobs 
BUG=skia:

Review URL: https://codereview.chromium.org/1055843002
 2015-04-08 09:08:31 -07:00
halcanary
2ad228e8ff SkPDF: Remove Array's unused set(i) and get(i) (leaving only append()) 
BUG=skia:3585

Review URL: https://codereview.chromium.org/1071583003
 2015-04-08 08:40:36 -07:00
bsalomon
e4579adfdf Add helper for creating a SkSurface from a client created texture. 
Review URL: https://codereview.chromium.org/1071603002
 2015-04-08 08:38:40 -07:00
caryclark
95bc5f3495 change isNestedRect to isNestedFillRect 
R=reed@google.com, bsalomon@google.com

Let isNested(Fill)Rect return true if drawn path describes filled
rectangles.

Review URL: https://codereview.chromium.org/1073473002
 2015-04-08 08:34:15 -07:00
mtklein
929f63fecc Make --undefok a little louder now that we're using it all the time. 
BUG=skia:

Review URL: https://codereview.chromium.org/1073483002
 2015-04-08 08:30:38 -07:00
joshualitt
b4c507e033 Adding bulk plot reffer to cached textblobs 
This change will prevent the atlas from evicting glyphs the TextBlob
needs.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/7281c61e7bc689d484dcbda49be3cef4ce4f11c2

Review URL: https://codereview.chromium.org/1050113004
 2015-04-08 08:07:59 -07:00
bungeman
693e993057 Remove unused InstCounterClass. 
This was added with r4719 (f7943035) to support testing
SkTRefArray. With 703d3c70 SkTRefArray and the associated test was
removed, but the supporting InstCounterClass was not.

Review URL: https://codereview.chromium.org/1063403003
 2015-04-08 08:06:26 -07:00
joshualitt
f1f8895cbe add realloc method to SkAutoSTMalloc 
BUG=skia:

Review URL: https://codereview.chromium.org/1069013002
 2015-04-08 07:33:33 -07:00
tomhudson
05e4abae89 Add missing override of willSaveLayer() 
Also tweak formatting.

BUG=3624
R=djsollen@google.com

Review URL: https://codereview.chromium.org/1068163004
 2015-04-08 06:52:59 -07:00
mtklein
c654e9016a Revert of SkCanvas::resetForNextPicture() (patchset #4 id:60001 of https://codereview.chromium.org/1067893002/) 
Reason for revert:
https://uberchromegw.corp.google.com/i/client.skia/builders/Linux%20Tests/builds/1816

Original issue's description:
> SkCanvas::resetForNextPicture()
>
> No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu.
>
>   picture_overhead_draw	1.62us ->  1.6us	0.99x
> picture_overhead_nodraw	 792ns ->  342ns	0.43x
>
> tiles and serialization modes will also test this a bit.
>
> BUG=chromium:470553
>
> Committed: https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d

TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:470553

Review URL: https://codereview.chromium.org/1062353002
 2015-04-07 15:27:14 -07:00
mtklein
f920e468ac SkCanvas::resetForNextPicture() 
No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu.

  picture_overhead_draw	1.62us ->  1.6us	0.99x
picture_overhead_nodraw	 792ns ->  342ns	0.43x

tiles and serialization modes will also test this a bit.

BUG=chromium:470553

Review URL: https://codereview.chromium.org/1067893002
 2015-04-07 14:11:22 -07:00
mtklein
b0531a790c Move uninteresting MD5 check to after adding it to JSON. 
BUG=skia:3676

Review URL: https://codereview.chromium.org/1067053002
 2015-04-07 13:38:48 -07:00
rmistry
6c27535e6f Fix formatting in the sheriff documentation 
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1066013002

Review URL: https://codereview.chromium.org/1066013002
 2015-04-07 12:17:00 -07:00
senorblanco
d762ca2586 Switch textures created by DeviceImageFilterProxy to 
approx-match.

This revealed some further 0..1 texture coordinate
depedencies,specifically in SkDisplacementMapEffect and
SkXfermodeImageFilter, fixed through use of
GrTextureDomain.

Note: causes minor pixel diffs in pictureimagefilter,
testimagefilters GMs.

Also causes minor pixel diffs in some Blink layout tests,
suppressed here: https://codereview.chromium.org/1064943002

BUG=skia:3532

Review URL: https://codereview.chromium.org/1065683002
 2015-04-07 12:16:56 -07:00
reed
3006b2e013 re-enable neon opts for some xfermodes 
BUG=skia:

Review URL: https://codereview.chromium.org/1068783003
 2015-04-07 11:14:10 -07:00
halcanary
bb264b7750 SkPDF: SkPDFString is no longer aware of wide strings. 
Since wide strings are only used in SkPDFDevice, I have moved the
function that manages them to that directory.

Motivation: The SkPDFString will be refactored later along with the
other SkPFObject heirarchy.

BUG=skia:3585

Review URL: https://codereview.chromium.org/1064013003
 2015-04-07 10:40:03 -07:00
joshualitt
3cf9863bb6 Revert of Adding bulk plot reffer to cached textblobs (patchset #7 id:110001 of https://codereview.chromium.org/1050113004/) 
Reason for revert:
Breaks linux builder

Original issue's description:
> Adding bulk plot reffer to cached textblobs
>
> This change will prevent the atlas from evicting glyphs the TextBlob
> needs.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7281c61e7bc689d484dcbda49be3cef4ce4f11c2

TBR=bsalomon@google.com,jvanverth@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1061713003
 2015-04-07 10:21:27 -07:00
joshualitt
7281c61e7b Adding bulk plot reffer to cached textblobs 
This change will prevent the atlas from evicting glyphs the TextBlob
needs.

BUG=skia:

Review URL: https://codereview.chromium.org/1050113004
 2015-04-07 10:02:25 -07:00
jvanverth
bb4a1cf0e6 Calculate inverse scale for distance field text in vertex shader 
This is for the uniform scale case only. Using the dFdx() function on certain
Mali GPUs causes issues because the precision is too low, so we have to
compute 1/scale from the view matrix instead.

BUG=skia:3528

Committed: https://skia.googlesource.com/skia/+/5b143038cb47763974d2750ed78d436eb6c38bea

Review URL: https://codereview.chromium.org/1029423003
 2015-04-07 09:06:00 -07:00
mtklein
0ea6d7150e Fix DM -r 
source_options isn't always present.

BUG=skia:

Review URL: https://codereview.chromium.org/1067863002
 2015-04-07 08:48:39 -07:00
mtklein
b7e8d69fc2 Add a Via to DM that records into two pictures and draws using the second. 
I'm going to start hacking on SkCanvas a bit to allow a fast reset method,
and I want to have some testing checking me.

BUG=skia:

Review URL: https://codereview.chromium.org/1062043004
 2015-04-07 08:30:32 -07:00
reed
687fa1c745 restore clipstack to heap-ptr, so clients can ref it 
BUG=skia:

Review URL: https://codereview.chromium.org/1068883004
 2015-04-07 08:00:56 -07:00
rmistry
04abf130bb Bypass owners check for dry run CLs. 
BUG=skia:
NOTRY=true

Review URL: https://codereview.chromium.org/1068853002
 2015-04-07 07:41:51 -07:00
bungeman
e3bea5cc60 Attempted mitigation of font tables released early. 
On Mac, it appears that sometimes fonts created from data have
their table data used after the table data copy is freed.
This appears to be most common with 'sbix' fonts for some reason,
so pin that table while in use.

Review URL: https://codereview.chromium.org/1061123002
 2015-04-07 07:34:36 -07:00
egdaniel
060a52c210 Set willReadFragmentPosition on XP when doing a DstCopy. 
BUG=472872

Review URL: https://codereview.chromium.org/1068463004
 2015-04-07 07:31:11 -07:00
scroggo
5965b73e54 Revert of Remove now-redundant SkPathOps enum. (patchset #1 id:1 of https://codereview.chromium.org/1051113005/) 
Reason for revert:
Android is still using this. See 4c2968b94c/logs/build_error.log

Original issue's description:
> Remove now-redundant SkPathOps enum.
>
> R=caryclark,reed
> BUG=473772
>
> Committed: https://skia.googlesource.com/skia/+/143244e27d95255807d8fa505ce0affef96d1fc8

TBR=caryclark@google.com,reed@google.com,schenney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=473772

Review URL: https://codereview.chromium.org/1068873002
 2015-04-07 06:53:21 -07:00
scroggo
fde1c85696 Add sheriff documentation for rebaselining. 
Copied from notes Robert emailed me.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1051653006

Review URL: https://codereview.chromium.org/1051653006
 2015-04-07 06:41:22 -07:00