AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
12,359 Commits 1 Branch 0 Tags 544 MiB
30bf3e2ffc
Commit Graph

12359 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
mtklein
30bf3e2ffc DM: add pdf 
BUG=skia:2598
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/312873002
 2014-06-03 13:57:14 -07:00
mtklein
9c4ff80d9b DM: go back to memcmp for BitmapsEqual 
Even when autovectorized, using MaxComponentDifference is slower than memcmp.
And debug builds (most runs of DM) will never even be autovectorized.

DM::MaxComponentDifference is the top function on DM profile, and memcmp moves
to ~20th.

BUG=skia:
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/315743002
 2014-06-03 13:56:54 -07:00
Ravi Mistry
182a631e98 Whitespace change to test the new cron.chrome bugdroid. 
(SkipBuildbotRuns)
BUG=skia:2139

Review URL: https://codereview.chromium.org/309333003
 2014-06-03 16:39:21 -04:00
robertphillips
795883e15b Fix neglected cleanup of SkTileGridPicture.h 
R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/312803003
 2014-06-03 13:34:06 -07:00
scroggo
65044bfe02 Return NULL when building empty LayerRasterizer. 
In SkLayerRasterizer::snapshotRasterizer() and ::detachRasterizer(),
if no layers have been added, do not attempt to create an
SkLayerRasterizer. Instead, return NULL.

This fixes an error when running tests on Android.

Update dox to state that NULL may be returned.

Add tests.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/313653006
 2014-06-03 13:12:51 -07:00
krajcevski
99ffe24200 Initial KTX file decoder 
R=bsalomon@google.com, robertphillips@google.com, halcanary@google.com, reed@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/302333002
 2014-06-03 13:04:35 -07:00
robertphillips
8a35140f3f Add LICENSE & README.google files to third_party/etc1 
R=djsollen@google.com, krajcevski@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/309343004
 2014-06-03 12:31:09 -07:00
mtklein
3a2682a77f SK_CPU_ARM --> SK_CPU_ARM32 
That's what it means.  It keeps confusing us as named today.

BUG=skia:
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/314643004
 2014-06-03 12:07:31 -07:00
jvanverth
1800b1f51e manual bench rebase after 55ada06 
R=robertphillips@google.com
TBR=robertphillips@google.com

Bypassing trybots:
NOTRY=true

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/315683004
 2014-06-03 11:46:30 -07:00
reed
868074b50b remove SkBounder -- unused and unloved 
BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/312553006
 2014-06-03 10:54:00 -07:00
epoger
55ada0630e download_actuals.py: download JSON files from Google Storage instead of skia-autogen 
uses google-api-python-client instead of gsutil binary to interact with Google Storage

BUG=skia:553
R=rmistry@google.com, bensong@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/309653005
 2014-06-03 10:35:28 -07:00
humper
2db11d18af a few rebaseline stragglers from image scaling change 
BUG=skia:
NOTRY=True
NOTREECHECKS=True
TBR=jvanverth

Author: humper@google.com

Review URL: https://codereview.chromium.org/311853004
 2014-06-03 10:20:49 -07:00
kevin.petit
866b95d65d ARM Skia NEON patches - 38 - arm64 8888 blitters 
Enable NEON on arm64 for most 8888 blitters

This patch enables NEON optimisation for the Color32, S32_Blend,
S32A_Opaque blitters on arm64.

Here are the perf improvements vs the existing code:

Color32:
========

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -2.39% |     23.78% |
+-------+------------+------------+
|     2 |     -5.46% |      8.88% |
+-------+------------+------------+
|     4 |     -4.74% |      4.89% |
+-------+------------+------------+
|     8 |     67.74% |    107.12% |
+-------+------------+------------+
|    16 |     40.03% |    101.20% |
+-------+------------+------------+
|    64 |     11.09% |     98.40% |
+-------+------------+------------+
|   256 |     -2.20% |     74.81% |
+-------+------------+------------+
|  1024 |     -4.28% |     78.90% |
+-------+------------+------------+

S32_Blend:
==========

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |      7.84% |     -6.75% |
+-------+------------+------------+
|     2 |     28.95% |     39.77% |
+-------+------------+------------+
|     4 |      5.80% |      8.26% |
+-------+------------+------------+
|     8 |      1.35% |     33.80% |
+-------+------------+------------+
|    16 |     -2.13% |     41.13% |
+-------+------------+------------+
|    64 |     -4.91% |     42.84% |
+-------+------------+------------+
|   256 |     -6.53% |     48.72% |
+-------+------------+------------+
|  1024 |     -6.65% |     46.66% |
+-------+------------+------------+

S32A_Opaque:
============

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -7.51% |    -19.06% |
+-------+------------+------------+
|     2 |     -5.02% |    -27.70% |
+-------+------------+------------+
|     4 |     15.38% |    -21.66% |
+-------+------------+------------+
|     8 |     -0.98% |      1.05% |
+-------+------------+------------+
|    16 |     -7.35% |      3.34% |
+-------+------------+------------+
|    64 |     50.53% |     94.63% |
+-------+------------+------------+
|   256 |     71.17% |    164.10% |
+-------+------------+------------+
|  1024 |     79.58% |    197.60% |
+-------+------------+------------+

Signed-off-by: Kevin PETIT <kevin.petit@arm.com>

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/302283003
 2014-06-03 10:08:07 -07:00
robertphillips
dcf9ab14a1 Remove legacy picture recording 
This is unblocked now that Android no longer uses the old interface.

This is just the first step in cleaning this up. Future CLs will constify SkPicture access in SkCanvas and split up the SkPicture/SkPicturePlayback/SkPictureRecord trio.

R=bsalomon@google.com, reed@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/313613002
 2014-06-03 10:04:47 -07:00
borenet
66aa609a49 Update SKP version to 16 
Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/313593002
 2014-06-03 09:38:11 -07:00
jcgregorio
92bfb09ac8 Fix etc1 support for SkFiddle. 
Also update design doc to fix MySQL notation for auto incrementing columns.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/315643002
 2014-06-03 09:04:44 -07:00
mtklein
04cd368cb4 Fix memory leak in etc1bitmap GM. 
We never drop our first ref on fileData. (All our ref counts start at one).
SkAutoTUnref<T> is almost always the right thing to use for refcounted types.

BUG=skia:2635
R=krajcevski@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/310793003
 2014-06-03 09:04:34 -07:00
scroggo
14052a0b5a Allow chrome to use old version of installPixels. 
R=jvanverth@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/312703003
 2014-06-03 07:57:51 -07:00
jcgregorio
d0f18b1f2b Update link to Doxygen. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/302543007
 2014-06-03 07:38:35 -07:00
Brian Salomon
c7671bec73 Rebase a few GMs and remove some tests from ignored-tests.txt 
Review URL: https://codereview.chromium.org/311813003
 2014-06-03 10:01:47 -04:00
scroggo
ef470f185f Remove brackets from gm names. 
BUG=skia:2634
R=epoger@google.com, borenet@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/307373003
 2014-06-03 06:50:26 -07:00
bsalomon
8af0523b38 Fall back to using clip effect for outer rect in drawdrrect 
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/310483010
 2014-06-03 06:34:59 -07:00
rmistry
5fb3392c3e Whitespace change to test multiple master support in CQ 
TBR=
BUG=skia:2624

(SkipBuildbotRuns)

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/315633002
 2014-06-03 06:30:09 -07:00
reed
9b4353c845 remove unneeded flags 
TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/316463002
 2014-06-03 05:31:01 -07:00
rmistry
da23e58b6d Whitespace change to test new CQ trybot 
TBR=
BUG=skia:2203
(SkipBuildbotRuns)

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/311813002
 2014-06-03 04:31:55 -07:00
mtklein
59ef7704f1 Revert of Try TSAN blacklist for SkGLContextHelper::init. (https://codereview.chromium.org/309823004/) 
Reason for revert:
the bot's clang doesn't know -fsanitize-blacklist

Original issue's description:
> Try TSAN blacklist for SkGLContextHelper::init.
>
> Submitting to test this; this particular problem only happens on the bot.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/ab2ec19b975a898d4ee2278ddad7d4268f134478

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/314543002
 2014-06-02 19:34:20 -07:00
mtklein
ab2ec19b97 Try TSAN blacklist for SkGLContextHelper::init. 
Submitting to test this; this particular problem only happens on the bot.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/309823004
 2014-06-02 19:11:06 -07:00
mtklein
cf44feb0e1 Clean up another silly race in benches when run concurrently. 
BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/309193003
 2014-06-02 18:22:12 -07:00
mtklein
a78ef795b0 Tweak TSAN suppressions. 
BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/312613002
 2014-06-02 16:40:06 -07:00
reed
73be51ee5e remove unneeded inval 
TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/307993012
 2014-06-02 14:41:24 -07:00
reed
5c404c5577 add makeOffset and makeInset to SkRect 
TBR=bsalomon

precursor for https://codereview.chromium.org/306013010

Author: reed@google.com

Review URL: https://codereview.chromium.org/306893012
 2014-06-02 14:38:32 -07:00
epoger
8ff38ccb40 use most innocuous characters possible within skimage output filenames 
BUG=skia:2634
R=scroggo@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/302323003
 2014-06-02 14:26:18 -07:00
krajcevski
8c111f783f Change #def to be opt-out 
R=jvanverth@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/308143008
 2014-06-02 13:51:34 -07:00
epoger
fc435a020a Revert of stop using brackets within skimage output filenames (https://codereview.chromium.org/303263012/) 
Reason for revert:
Broke http://108.170.220.120:10117/builders/Test-ChromeOS-Link-HD4000-x86_64-Release/builds/2806/steps/UploadSKImageResults/logs/stdio :

[13:38:43.401942] /bin/sh: 1: Syntax error: "(" unexpected
[13:38:43.902632] Command /home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/scripts/slave/../../third_party/gsutil/gsutil cp -a private /home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/slave/Test-ChromeOS-Link-HD4000-x86_64-Release/build/skia/out/Release/skimage_out/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png gs://chromium-skia-gm/skimage/output/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png failed with retcode 2, try 1.

Original issue's description:
> stop using brackets within skimage output filenames
>
> BUG=skia:2634
>
> Committed: https://skia.googlesource.com/skia/+/f07892413cd2359549dc187f1d10bc48d7d263ba

R=scroggo@google.com
TBR=scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2634

Author: epoger@google.com

Review URL: https://codereview.chromium.org/314443002
 2014-06-02 13:46:21 -07:00
mtklein
832cb66749 Update TSAN suppressions. 
TSAN suppressions need to be on their own line, even free of comments.

Also, temporarily add SK_ANNOTATE_UNPROTECTED_READ to sk_acquire_load.
Will remove this when we're done iterating on SkBarriers_tsan.h: TSAN
has an atomic load that makes the annotation moot.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/be7de4fc4229b70b0954f3ea5e3b053dae4c1a9d

R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/308073013
 2014-06-02 13:46:17 -07:00
epoger
f07892413c stop using brackets within skimage output filenames 
BUG=skia:2634
R=scroggo@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/303263012
 2014-06-02 13:35:22 -07:00
scroggo
12ba2cbb9b Update expectations to fix self tests. 
R=epoger@google.com
TBR=epoger@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/306313004
 2014-06-02 13:34:08 -07:00
mtklein
be7de4fc42 Update TSAN suppressions. 
TSAN suppressions need to be on their own line, even free of comments.

Also, temporarily add SK_ANNOTATE_UNPROTECTED_READ to sk_acquire_load.
Will remove this when we're done iterating on SkBarriers_tsan.h: TSAN
has an atomic load that makes the annotation moot.

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/308073013
 2014-06-02 13:23:49 -07:00
reed
c77392ed58 use colortype instead of config 
clone of https://codereview.chromium.org/305133006/

TBR=

BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/301233011
 2014-06-02 13:07:26 -07:00
mtklein
80f709a0d7 TSAN caught us racing in ScalarBench.cpp 
http://108.170.220.102:10117/builders/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/builds/914/steps/RunDM/logs/stdio

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14992

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/305033002
 2014-06-02 12:41:07 -07:00
jvanverth
1940df968d Allow access to device config for Moz2d. 
BUG=skia:2633
R=robertphillips@google.com, borenet@google.com, george@mozilla.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/304273009
 2014-06-02 12:27:26 -07:00
borenet
421734eb33 Revert of Update SKP version to 13 (https://codereview.chromium.org/309753004/) 
Reason for revert:
Did not include perf baselines.

Original issue's description:
> Update SKP version to 13
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/7574153e9cc52b1b560ded02a2b219cda4b1816c

R=rmistry@google.com
TBR=rmistry@google.com
NOTREECHECKS=true
NOTRY=true

Author: borenet@google.com

Review URL: https://codereview.chromium.org/309813003
 2014-06-02 12:19:29 -07:00
Robert Phillips
9d14b6d161 Adding resource files 
The ktx file is to test the new ktx reader
The pkm shrinks the size of the pkm test file

TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/312563002
 2014-06-02 15:18:27 -04:00
borenet
7574153e9c Update SKP version to 13 
R=rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/309753004
 2014-06-02 12:15:31 -07:00
robertphillips
a2551ffbc7 Remove legacy Picture-recording flags from Android build 
R=scroggo@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/304333002
 2014-06-02 12:09:30 -07:00
scroggo
f9f1547683 Remove unitmappers header. 
This file contained a bunch of unitmappers. Luckily noone includes
it, since it wouldn't compile (the unitmapper class was removed in
https://codereview.chromium.org/288313009).

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/295383013
 2014-06-02 11:32:56 -07:00
mtklein
1b81877880 Clean up SkOnce: 
1 Remove atExit feature: clients can do it just as well as SkOnce can.
  2 Remove support for functors: no one but the unit test did that.
  3 Remove support for unused non-static SkOnceFlag (no SK_ONCE_INIT).
  4 Add SkOnce variants for no-arg functions so we're not forced to pass dummy values all the time.
  5 Merge SkSpinlock and SkOnceFlag, making all members private.
  6 More notes about memory barriers, adding an acquire load after acquiring the spinlock.

BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/302083003
 2014-06-02 11:26:59 -07:00
humper
173a5c544b invert comparison sense for reason return 
BUG=skia:
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/313433003
 2014-06-02 11:09:13 -07:00
mtklein
ada3635c8e Compile-time initialize special SkMatrices. 
BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/303263011
 2014-06-02 10:59:35 -07:00
robertphillips
d537341e16 Move GrIPoint16 to SkIPoint16 (and remove GrPoint.h) 
R=bsalomon@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/309683002
 2014-06-02 10:20:15 -07:00