Commit Graph

4592 Commits

Author SHA1 Message Date
reed@google.com
3b3e895df6 remove EdgeType enum. Unimportant distinction, and removing speeds up quickReject
Review URL: https://codereview.appspot.com/6448161

git-svn-id: http://skia.googlecode.com/svn/trunk@5140 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 20:53:31 +00:00
bensong@google.com
b6204b1ec4 cleaned up algorithm codes and added 25th percentile for representation.
git-svn-id: http://skia.googlecode.com/svn/trunk@5139 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 20:49:28 +00:00
bsalomon@google.com
8a5b7bc41c Rebaseline gm due to r5136
git-svn-id: http://skia.googlecode.com/svn/trunk@5138 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 20:42:40 +00:00
scroggo
c51db02181 Fix a memory leak in SkBitmapHeap.
When I switched fLookupTable to be an array of pointers, I did not
delete those pointers when I was done with them. Do it now.

Also modify SkTDArray::deleteAll to call SkDELETE instead of delete.

Review URL: https://codereview.appspot.com/6453129

git-svn-id: http://skia.googlecode.com/svn/trunk@5137 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 20:30:18 +00:00
bsalomon@google.com
1d4edd38f6 Make all GrContext draws go through the draw buffer.
Review URL: http://codereview.appspot.com/6462069/


git-svn-id: http://skia.googlecode.com/svn/trunk@5136 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 18:36:06 +00:00
reed@google.com
da17f75844 add SK_ENABLE_CLIP_QUICKREJECT option (currently disabled)
git-svn-id: http://skia.googlecode.com/svn/trunk@5135 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 18:27:05 +00:00
scroggo@google.com
460a23e6fd Fix a parenthesis bug.
SkGPipeCanvas::needOpBytes was being called with the wrong value due to a misplaced
parens in clipRect and clipPath. This can cause a crash if clip is called at just
the right (wrong) time. Instead of writing a boolean to the stream, I have added a
flag, which helps to avoid the parens problem.

Also renamed some flags from _DrawOpsFlag to _DrawOpFlag for consistency.

Lastly, added an assert that the size provided by the SkGPipeController is a multiple
of four.

Review URL: https://codereview.appspot.com/6453126

git-svn-id: http://skia.googlecode.com/svn/trunk@5134 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 17:56:49 +00:00
bungeman@google.com
b49d989997 Remove SK_FONTHOST_WIN_DW define.
git-svn-id: http://skia.googlecode.com/svn/trunk@5132 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 17:35:58 +00:00
reed@google.com
bc4b66f42c we have no subclasses, so change protected to private.
git-svn-id: http://skia.googlecode.com/svn/trunk@5131 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 16:46:27 +00:00
bsalomon@google.com
d57d71a5b8 Fix assertion in in order draw buffer
Review URL: http://codereview.appspot.com/6460095/


git-svn-id: http://skia.googlecode.com/svn/trunk@5130 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 16:26:33 +00:00
bungeman@google.com
6ca0a5da6c Don't try to build SkFontHost_win_dw.cpp on non-Windows platforms.
git-svn-id: http://skia.googlecode.com/svn/trunk@5129 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 16:23:09 +00:00
bungeman@google.com
e8f0592ae8 DirectWrite font host for skia.
https://codereview.appspot.com/5417063/


git-svn-id: http://skia.googlecode.com/svn/trunk@5128 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 16:13:40 +00:00
reed@google.com
0557d9ea94 add SkClipStack::clipEmpty() as an optimized way to say clipDevRect(empty, intersect)
if the caller knows up-front that it wants the clipstact to become empty.
Review URL: https://codereview.appspot.com/6443132

git-svn-id: http://skia.googlecode.com/svn/trunk@5127 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 15:59:59 +00:00
bsalomon@google.com
e7249bd5ca Fix overrun in aa rect renderer
Review URL: http://codereview.appspot.com/6446146/



git-svn-id: http://skia.googlecode.com/svn/trunk@5126 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 15:28:54 +00:00
bsalomon@google.com
0d94482193 Fix uninitialized color filter data on GrPaint
Review URL: http://codereview.appspot.com/6443135/


git-svn-id: http://skia.googlecode.com/svn/trunk@5125 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 15:06:57 +00:00
robertphillips@google.com
51ee8f1fd2 Compilation fix for r5123 (disabling template inst count tracking)
git-svn-id: http://skia.googlecode.com/svn/trunk@5124 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 15:04:34 +00:00
robertphillips@google.com
a22e2117e4 Extended Inst counting to find "unknown" leaked object (SkTMaskGamma)
http://codereview.appspot.com/6453127/



git-svn-id: http://skia.googlecode.com/svn/trunk@5123 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 14:58:06 +00:00
robertphillips@google.com
1f47f4f732 Replaced TextureCacheEntry with GrTexture* and a back pointer to GrResourceEntry (in GrTexture)
http://codereview.appspot.com/6460089/



git-svn-id: http://skia.googlecode.com/svn/trunk@5122 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 14:49:16 +00:00
epoger@google.com
71329d809a skdiff: recurse over subdirectories, unless --norecurse option is given
in anticipation of https://code.google.com/p/skia/issues/detail?id=743 ('move gm baselines outside of trunk, and modify naming convention')
Review URL: https://codereview.appspot.com/6465053

git-svn-id: http://skia.googlecode.com/svn/trunk@5121 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-16 13:42:13 +00:00
reed@google.com
56b64a5331 change tiling to 16 tiles instead of 4
git-svn-id: http://skia.googlecode.com/svn/trunk@5120 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 20:44:36 +00:00
scroggo@google.com
e2dd973e4b Provide a key to go to the previous slide in SampleApp.
The left key now mirrors the right key, and goes to the previous slide.
It used to change the device type, which can still be done by pressing
'd' or using the menu.

Review URL: https://codereview.appspot.com/6443133

git-svn-id: http://skia.googlecode.com/svn/trunk@5119 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 20:03:06 +00:00
junov@chromium.org
a8db8fe39a Fixing a deferred canvas optimization that purges pending draws when the canvas is cleared
It appears that the recording canvas returns a save count of 1 when the save stack is empty.
In order to pass Canvas unit tests when a clear occurs, changes to SkGPipe were necessary
to allow SkDeferredCanvas to set the device bounds on the SkGPipeCanvas.  A positive
side effect of this change is that graphics primitives that fall outside of the device
bounds will now always be culled at the recording stage (as opposed playback).

BUG=http://code.google.com/p/skia/issues/detail?id=782
TEST=deferred_canvas_record bench test
Review URL: https://codereview.appspot.com/6454157

git-svn-id: http://skia.googlecode.com/svn/trunk@5117 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 19:49:22 +00:00
scroggo@google.com
837d31a0c9 Use SkCanvas::concat instead of SkCanvas::setMatrix so this GM can be tiled.
Review URL: https://codereview.appspot.com/6460091

git-svn-id: http://skia.googlecode.com/svn/trunk@5116 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 18:42:45 +00:00
bensong@google.com
8c1de76d0b added representation to xhtml title.
git-svn-id: http://skia.googlecode.com/svn/trunk@5115 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 18:27:38 +00:00
bensong@google.com
2ee780b5ff fixes elif bug.
git-svn-id: http://skia.googlecode.com/svn/trunk@5114 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 17:55:42 +00:00
bensong@google.com
8734816c3f adds flag for choosing bench representative algorithm.
git-svn-id: http://skia.googlecode.com/svn/trunk@5113 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 17:31:46 +00:00
scroggo@google.com
63258865c4 Skip tiled drawing in GM for magnifier image filter.
Merely skips the test until we get a real fix for the problem.

BUG=https://code.google.com/p/skia/issues/detail?id=781

Review URL: https://codereview.appspot.com/6459094

git-svn-id: http://skia.googlecode.com/svn/trunk@5111 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 16:32:19 +00:00
robertphillips@google.com
cb73b31bcd Added virtual destructor to SkColorSpaceLuminance
http://codereview.appspot.com/6459092/



git-svn-id: http://skia.googlecode.com/svn/trunk@5110 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 14:52:58 +00:00
reed@google.com
67b89eeeb0 add 't' to toggle tiling modes
Review URL: https://codereview.appspot.com/6446138

git-svn-id: http://skia.googlecode.com/svn/trunk@5109 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 14:41:58 +00:00
robertphillips@google.com
5d8d18651a Addressed Windows compiler complaints
http://codereview.appspot.com/6462062/

This CL will require re-baselining of the imagemagnifier GM



git-svn-id: http://skia.googlecode.com/svn/trunk@5108 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-15 14:36:41 +00:00
keyar@chromium.org
5bdef29ae0 GrContextFactory can now expose the GLContext it is using.
Review URL: https://codereview.appspot.com/6461081

git-svn-id: http://skia.googlecode.com/svn/trunk@5105 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 22:02:48 +00:00
bsalomon@google.com
a913a9932d revert r5100 experiment
git-svn-id: http://skia.googlecode.com/svn/trunk@5104 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 21:53:53 +00:00
rileya@google.com
9a92714d13 Revert GrTextureStripAtlas change due to performance concerns.
git-svn-id: http://skia.googlecode.com/svn/trunk@5103 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 21:33:15 +00:00
rileya@google.com
9766ecd04f Fix for GPU-less Linux build: move #include GrTextureStripAtlas into SK_SUPPORT_GPU ifdefs. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@5102 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 21:14:08 +00:00
rileya@google.com
50b2bcf321 Made gradient effects use GrTextureStripAtlas.
Review URL: https://codereview.appspot.com/6450131

git-svn-id: http://skia.googlecode.com/svn/trunk@5101 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 21:06:15 +00:00
bsalomon@google.com
5224d7532d Temporary change to bench on android to run limited set of test in order to see whether it allows bench to complete.
Review URL: http://codereview.appspot.com/6459087



git-svn-id: http://skia.googlecode.com/svn/trunk@5100 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 20:44:17 +00:00
scroggo@google.com
d5d158b325 Ensure that Pipe does not crash when attempting to draw after endRecording.
Add a test for drawing a bitmap and a bitmapshader after endRecording.

BUG=https://code.google.com/p/skia/issues/detail?id=774&can=3
Test=PipeTest

Review URL: https://codereview.appspot.com/6459088

git-svn-id: http://skia.googlecode.com/svn/trunk@5099 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 20:38:28 +00:00
rmistry@google.com
bda03db289 Fixing source files that do not have newlines at the end.
Found using the new unsubmitted newline_checker slave script:
piraeus.cnc.corp.google.com:10125/builders/Skia_House_Keeping/builds/5/steps/shell_1/logs/stdio
Review URL: https://codereview.appspot.com/6443124

git-svn-id: http://skia.googlecode.com/svn/trunk@5097 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 20:27:54 +00:00
reed@google.com
c0f1dfb4ed privatize SkScalerContext.h
git-svn-id: http://skia.googlecode.com/svn/trunk@5096 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 19:45:58 +00:00
chudy@google.com
4c7962e0a8 Bug Fix: Fixes transformation bug where debugger locked up during incremental draw due to nested clips not being cleared.
Review URL: https://codereview.appspot.com/6462060

git-svn-id: http://skia.googlecode.com/svn/trunk@5095 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 19:38:31 +00:00
chudy@google.com
b8ec32e050 Bug Fix: Fixes incremental drawing in conjunction with the highlighting filter for the OpenGL widget.
Review URL: https://codereview.appspot.com/6441141

git-svn-id: http://skia.googlecode.com/svn/trunk@5094 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 19:36:09 +00:00
chudy@google.com
6bd109a393 Refactored inspector widget such that creating custom tabs for information is straightforward for future developers.
Review URL: https://codereview.appspot.com/6463046

git-svn-id: http://skia.googlecode.com/svn/trunk@5093 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 19:34:13 +00:00
scroggo@google.com
40fbb1810a Fix broken test.
Review URL: https://codereview.appspot.com/6450133

git-svn-id: http://skia.googlecode.com/svn/trunk@5092 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 19:30:20 +00:00
scroggo@google.com
664fab1b34 Move write buffer flags used by SkFlataData::Create into SkFlatController.
Review URL: https://codereview.appspot.com/6446135

git-svn-id: http://skia.googlecode.com/svn/trunk@5091 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 19:22:05 +00:00
reed@google.com
a9d4e84c43 To allow forward declarations, move SkScalerContext::Rec to SkScalerContextRec
Review URL: https://codereview.appspot.com/6462059

git-svn-id: http://skia.googlecode.com/svn/trunk@5090 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 19:13:55 +00:00
bsalomon@google.com
b5e4703b86 Reduce number of paths created by benchs
Review URL:http://codereview.appspot.com/6454151/


git-svn-id: http://skia.googlecode.com/svn/trunk@5088 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 17:49:46 +00:00
scroggo@google.com
7811e134bb Remove baseline for flaky test.
This test goes back and forth, slightly changing the location of a
rectangle, only on this bot. Remove the baseline so we no longer
see the noise.

Review URL: https://codereview.appspot.com/6460088

git-svn-id: http://skia.googlecode.com/svn/trunk@5087 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 17:47:43 +00:00
reed@google.com
fe8765c82a privatize SkDescriptor.h
git-svn-id: http://skia.googlecode.com/svn/trunk@5086 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 17:41:34 +00:00
scroggo@google.com
d9d2967ce1 In SkGPipeCanvas, rename fSharedHeap to fBitmapHeap
to reflect the fact that it is only used for storing bitmaps.

Review URL: https://codereview.appspot.com/6446134

git-svn-id: http://skia.googlecode.com/svn/trunk@5085 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 17:21:34 +00:00
bsalomon@google.com
137209f9f4 Make SkTArray consider only the new count and reserve when determining how much to alloc
Review URL: http://codereview.appspot.com/6459084


git-svn-id: http://skia.googlecode.com/svn/trunk@5084 2bbb7eff-a529-9590-31e7-b0007b416f81
2012-08-14 17:19:08 +00:00