Commit Graph

19955 Commits

Author SHA1 Message Date
kkinnunen
546eb5c57a Initialize glGen* call id args to zero
Initialize glGenTexture, glGenBuffer call id buffer items to zero before
calls. Otherwise it's not easy to check if the call succeeded or not.

Assert the rule in debug gl context.

Make TesselatingPathRendererTests use debug gl context. It exercises
some of the GenBuffers call sites.

Review URL: https://codereview.chromium.org/1514033002
2015-12-11 00:05:34 -08:00
kkinnunen
55eeae9722 Run debug gl context for DEF_GPU_TEST_FOR_ALL_CONTEXTS
Run debug gl context for tests defined with
DEF_GPU_TEST_FOR_ALL_CONTEXTS.

Review URL: https://codereview.chromium.org/1514023002
2015-12-10 23:19:29 -08:00
msarett
62d3b10110 Revert of DM: fix --config $VIA-pdf to not crash (patchset #3 id:40001 of https://codereview.chromium.org/1513323002/ )
Reason for revert:
I believe that this is breaking master-skia in Android.

Original issue's description:
> DM: fix `--config $VIA-pdf` to not crash
>
> Committed: https://skia.googlesource.com/skia/+/6bce4177cb72faac9c10d01d57e17168ae7ecadf

TBR=mtklein@google.com,halcanary@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1513053004
2015-12-10 15:14:27 -08:00
msarett
7d2e2fadbd Remove flag needed by outdated libpng
BUG=skia:

Review URL: https://codereview.chromium.org/1514873003
2015-12-10 14:45:03 -08:00
mtklein
cff15aa36d yet another memcpy -> sk_careful_memcpy
will fix
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3834

No API changes.
TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1514923003
2015-12-10 14:34:23 -08:00
cdalton
78f915e2f1 Add a warmup flag to visualbench
Adds a flag to control whether we use a warmup bench.

BUG=skia:

Review URL: https://codereview.chromium.org/1468233003
2015-12-10 14:20:06 -08:00
herb
9449616020 Fix UB function problems for AA merger.
BUG=skia:4634

Review URL: https://codereview.chromium.org/1518863002
2015-12-10 14:17:41 -08:00
aam
419c37269f Fix 'debugging on Android' android_gdb_app script.
1) com.skia -> com.skia.sample_app
2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example:

  ./platform_tools/android/bin/android_gdb_app -d nexus_6

BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1509853006

Review URL: https://codereview.chromium.org/1509853006
2015-12-10 14:14:56 -08:00
herb
30da5f7a1e Change SkTaskGroup to use std::function. Ripple all the changes.
BUG=skia:4634

Review URL: https://codereview.chromium.org/1519573003
2015-12-10 14:12:33 -08:00
scroggo
9fba909792 Use size_t for strlen() return value
BUG=skia:2810

Review URL: https://codereview.chromium.org/1518843002
2015-12-10 13:46:04 -08:00
reed
70ee31b2fa try adding flag to allow lcd text even in a layer
BUG=skia:

Review URL: https://codereview.chromium.org/1513513002
2015-12-10 13:44:45 -08:00
scroggo
96f16e835e Use DEF_GM everywhere
BUG=skia:1902

Review URL: https://codereview.chromium.org/1518893002
2015-12-10 13:31:59 -08:00
robertphillips
4e56772432 Address precision issue in circle blur effect
BUG=560651

Review URL: https://codereview.chromium.org/1504333003
2015-12-10 13:29:14 -08:00
joshualitt
0a42e6827b Create GrTextUtils
BUG=skia:

Review URL: https://codereview.chromium.org/1514933002
2015-12-10 13:20:58 -08:00
msarett
90c4d5fec8 Add reallyHasAlpha() to SkAndroidCodec
This also modified the default implementation
of onReallyHasAlpha() in SkCodec.

BUG=skia:

Review URL: https://codereview.chromium.org/1518743002
2015-12-10 13:09:24 -08:00
halcanary
6bce4177cb DM: fix --config $VIA-pdf to not crash
Review URL: https://codereview.chromium.org/1513323002
2015-12-10 12:46:42 -08:00
halcanary
f2848b6035 default SkPixelSerializer
Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.

Add SkImageEncoder::CreatePixelSerializer() to return a
PixelSerializer that calls into SkImageEncoder::EncodeData.

SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.

Committed: https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b

Committed: https://skia.googlesource.com/skia/+/808ce2886d732b1055f89c8fb0f1b11b47fcb0ce

Review URL: https://codereview.chromium.org/1507123002
2015-12-10 12:40:23 -08:00
borenet
1812fa225d Add buildbot spec for Android One bots
BUG=skia:

Review URL: https://codereview.chromium.org/1517733002
2015-12-10 12:09:14 -08:00
xidachen
467ddc0b24 SkBlurImageFilter returns input when sigma = 0
In the current implementation, a blur filter is always created even in the
case when sigma.fX == 0 && sigma.fY == 0. This CL makes the blur filter
return input in this case.

BUG=568393

Review URL: https://codereview.chromium.org/1518643002
2015-12-10 12:08:44 -08:00
scroggo
671c06f979 Remove unused CallStacker
Found this while looking for uses of strlen (skbug.com/2810). This code
was written by a former member of the team and is not used.

BUG=skia:2810

Review URL: https://codereview.chromium.org/1512753006
2015-12-10 11:28:01 -08:00
joshualitt
2e2202e95e Move flush logic into GrAtlasTextBlob
TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1518763002
2015-12-10 11:22:08 -08:00
scroggo
565901db95 Switch SkAutoMalloc to SkAutoTMalloc to avoid cast
Make SkAutoTMalloc's interface look more like SkAutoMalloc:
- add free(), which does what you expect
- make reset() return a pointer fPtr

No public API changes (SkAutoTMalloc is in include/private)

BUG=skia:2148

Review URL: https://codereview.chromium.org/1516833003
2015-12-10 10:44:13 -08:00
halcanary
9907371f0a SkPixelSerializer: remove deprecated virtual
Review URL: https://codereview.chromium.org/1512333002
2015-12-10 09:30:57 -08:00
joshualitt
1acabf3787 Move DistanceAdjustTable to its own file
BUG=skia:

Review URL: https://codereview.chromium.org/1512823004
2015-12-10 09:10:10 -08:00
jvanverth
f10ecb71a9 Add Apple renderer strings to PowerVR detection
BUG=skia:4148

Review URL: https://codereview.chromium.org/1512903005
2015-12-10 09:06:24 -08:00
halcanary
712fdf7603 SkDocument::setDCTEncoder() for old versions of webkit
Review URL: https://codereview.chromium.org/1505763003
2015-12-10 08:59:43 -08:00
joshualitt
a06e6ab3fa Move appending of large glyphs into GrAtlasTextBlob
BUG=skia:

Review URL: https://codereview.chromium.org/1517563002
2015-12-10 08:54:41 -08:00
scroggo
04a0d3f00e Silence another PNG print statement
It can still be turned on by using setting
c_suppressPNGImageDecoderWarnings to true.

Review URL: https://codereview.chromium.org/1512293003
2015-12-10 08:54:36 -08:00
caryclark
201efb5ae0 try again on md formatting
TBR=hcm@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1520533002

Review URL: https://codereview.chromium.org/1520533002
2015-12-10 08:03:58 -08:00
halcanary
decb21e3ae experiment/fiddle
Review URL: https://codereview.chromium.org/1349163003
2015-12-10 07:52:45 -08:00
joshualitt
fd5f6c1b0d Move 'mustRegenerate' function into GrAtlasTextBlob
BUG=skia:

Review URL: https://codereview.chromium.org/1515543003
2015-12-10 07:44:50 -08:00
mtklein
067e90e72f another null src, memcpy -> sk_careful_memcpy
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3798/steps/dm/logs/stdio

BUG=skia:

Review URL: https://codereview.chromium.org/1510903005
2015-12-10 07:42:47 -08:00
joshualitt
53f26aa045 Remove uniform color for GrDistanceFieldGeoProc
BUG=skia:

Review URL: https://codereview.chromium.org/1512533003
2015-12-10 07:29:54 -08:00
caryclark
9ca30a3b9b add path ops presentations to skia.org
TBR=hcm@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1518453003

Review URL: https://codereview.chromium.org/1518453003
2015-12-10 06:29:44 -08:00
kkinnunen
5219fd9ff7 Make NVPR a GL context option instead of a GL context
Make NVPR a GL context option instead of a GL context.
This may enable NVPR to be run with command buffer
interface.

No functionality change in DM or nanobench. NVPR can
only be run with normal GL APIs.

BUG=skia:2992

Committed: https://skia.googlesource.com/skia/+/eeebdb538d476c1bfc8b63a946094ca1b505ecd1

Committed: https://skia.googlesource.com/skia/+/64492c43c3faee7ab0f69b1c84e0267616f85e52

Review URL: https://codereview.chromium.org/1448883002
2015-12-10 06:28:13 -08:00
kkinnunen
ea40943f8e Use a pseudo-extension CHROMIUM_framebuffer_mixed_samples
Use the pseudo-extension CHROMIUM_framebuffer_mixed_samples when
run with Chromium command buffer. The extension exposes
NV_framebuffer_mixed_samples subset that Skia needs in order to
use NV_path_rendering with mixed samples.

BUG=506765

Review URL: https://codereview.chromium.org/1507373004
2015-12-10 01:21:59 -08:00
kkinnunen
2ca29c0b91 Populate NVPR functions when run with command buffer
Populate the NV_path_rendering functions provided by
CHROMIUM_path_rendering when the tools are being run with
command buffer API.

BUG=skia:2992

Review URL: https://codereview.chromium.org/1510163003
2015-12-09 22:58:34 -08:00
bsalomon
e87256c462 Do elliptical clips in normalized space on devices with a "real" mediump
BUG=chromium:477684

Review URL: https://codereview.chromium.org/1517573002
2015-12-09 17:14:40 -08:00
bsalomon
f1ecd21bf6 Make "alpha only" be a property of GrTextureProducer
Review URL: https://codereview.chromium.org/1507973005
2015-12-09 17:06:02 -08:00
jvanverth
b3685c8646 Use BRGA as internal format on later iOS
BUG=skia:2733

Review URL: https://codereview.chromium.org/1504333007
2015-12-09 16:54:35 -08:00
mtklein
e0021c0b05 another memcpy -> sk_careful_memcpy
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3791/steps/dm/logs/stdio

This is getting tedious.

TBR=herb@google.com,reed@google.com
No API changes.

BUG=skia:

Review URL: https://codereview.chromium.org/1510223003
2015-12-09 16:20:25 -08:00
caryclark
2028d7ff74 add support for capped hairlines
Extend the ends of hairline and haircurve segments when the paint is set to square or round, and the line or curve is at the start or end of a contour.

R=reed@google.com
BUG=skia:4599

Review URL: https://codereview.chromium.org/1491843006
2015-12-09 14:04:46 -08:00
scroggo
645f6d9e39 Silence libjpeg warnings in SkImageDecoder
We just did the same for libpng (see crrev.com/1512043002), so we
might as well do this here.

SkImageDecoder is deprecated, and SkCodec already has a way to turn
off its messages.

BUG=skia:1649

Review URL: https://codereview.chromium.org/1505953007
2015-12-09 13:40:34 -08:00
mtklein
cefb459762 Another undefined shift caught by -fsanitize=shift.
left was -16

I didn't see any warning about fTop, but seems simplest to fix that too.

BUG=skia:

Review URL: https://codereview.chromium.org/1505993007
2015-12-09 13:32:58 -08:00
mtklein
8bf5d1754f Another memcpy -> sk_careful_memcpy
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3787/steps/dm/logs/stdio

dst is null.
TBR=herb@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1507113007
2015-12-09 13:15:07 -08:00
mtklein
9b439153fc no need for newlines in DM Errors
This should fix some odd formatting problems in the logs, e.g.

    Note tally:
    583x   (skipped: Cannot convert to requested color type.
    )
    4x     (--blacklist _ image decode 4bpp-pixeldata-cropped.bmp)

~~~>

    Note tally:
    583x   (skipped: Cannot convert to requested color type.)
    4x     (--blacklist _ image decode 4bpp-pixeldata-cropped.bmp)

BUG=skia:

Review URL: https://codereview.chromium.org/1508223006
2015-12-09 13:02:26 -08:00
benjaminwagner
5582b2be31 Fix compile error with GOOGLE3 define.
BUG=skia:

Review URL: https://codereview.chromium.org/1509023004
2015-12-09 12:51:20 -08:00
bsalomon
2bbd0c6161 Rewrite drawBitmap/ImageNine on top of GrTextureProducer
Review URL: https://codereview.chromium.org/1504723004
2015-12-09 12:50:56 -08:00
mtklein
632199ec6e Make skia_sanitizer work on Macs too.
This is of course limited by what the compiler suppports.
-fsanitize=address seems to work OK.

BUG=skia:

Review URL: https://codereview.chromium.org/1512853005
2015-12-09 12:39:01 -08:00
scroggo
dc877a7734 Remove no-op code in SkAlphaRuns::add
The old code says

        runs += x + 1;
        alpha += x + 1;
        x = 0;
        lastAlpha += x; // we don't want the +1

The last line does nothing. Remove this unnecessary line.

BUG=skia:401

Review URL: https://codereview.chromium.org/1506253002
2015-12-09 12:33:21 -08:00