reed
6b9ef90c02
SkChopCubicAt2 using Sk2s -- 2x faster
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1036753002
2015-03-24 19:24:34 -07:00
halcanary
f3d53a037d
SkPDF: unit test cleanup
...
BUG=skia:3585
Review URL: https://codereview.chromium.org/1033833002
2015-03-24 15:29:39 -07:00
reed
0dc4dd6dda
Revert of pathops version two (patchset #16 id:150001 of https://codereview.chromium.org/1002693002/ )
...
Reason for revert:
ASAN investigation
Original issue's description:
> pathops version two
>
> R=reed@google.com
>
> marked 'no commit' to attempt to get trybots to run
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/ccec0f958ffc71a9986d236bc2eb335cb2111119
TBR=caryclark@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1029993002
2015-03-24 13:55:33 -07:00
caryclark
82dec0e16a
Revert of remove obsolete tests (patchset #1 id:1 of https://codereview.chromium.org/1030883002/ )
...
Reason for revert:
working on asan fix
Original issue's description:
> remove obsolete tests
>
> remove tests that are breaking the build -- uninitialized memory
>
> TBR=reed
>
> Committed: https://skia.googlesource.com/skia/+/e02c944e97ad6a3b8befb1f4f784919767941ba6
TBR=reed@android.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1036633002
2015-03-24 13:52:49 -07:00
caryclark
74c464a6af
Revert of fix destructor order to fix build (patchset #1 id:1 of https://codereview.chromium.org/1033703002/ )
...
Reason for revert:
working on asan fix
Original issue's description:
> fix destructor order to fix build
>
> TBR=reed
>
> Committed: https://skia.googlesource.com/skia/+/c207f9b2e8d6fb5386197fa8a8d258d2c4603418
TBR=reed@android.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1033803002
2015-03-24 13:47:57 -07:00
tomhudson
7aa846c683
Revert of Enabling ico decoding with use of png and bmp decoders (patchset #10 id:280001 of https://codereview.chromium.org/1011343003/ )
...
Reason for revert:
Reverting on suspicion of massive bot failures - possible command line too long?
Original issue's description:
> Enabling ico decoding with use of png and bmp decoders
>
> BUG=skia:3257
>
> Committed: https://skia.googlesource.com/skia/+/15bfd075d38e4422a477e22940d06a137f66cc97
TBR=scroggo@google.com ,reed@google.com,djsollen@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3257
Review URL: https://codereview.chromium.org/1022843005
2015-03-24 13:47:41 -07:00
tomhudson
48dc6dc52e
Switch DM to use utils/android/SkAndroidSDKCanvas
...
Use (better) paint filter shared with nanobench, instead
of custom implementation.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/1036523002
2015-03-24 12:46:40 -07:00
msarett
15bfd075d3
Enabling ico decoding with use of png and bmp decoders
...
BUG=skia:3257
Review URL: https://codereview.chromium.org/1011343003
2015-03-24 12:24:27 -07:00
robertphillips
46bffd6fbe
Fix assert in debugger
...
Review URL: https://codereview.chromium.org/1029903002
2015-03-24 11:09:07 -07:00
rmistry
6776a538f9
Increase timeout of ukwsj to get more consistent SKP captures
...
BUG=skia:3574
TBR=borenet
NOTRY=true
Review URL: https://codereview.chromium.org/1038443002
2015-03-24 10:58:37 -07:00
halcanary
f5b17fbd94
SkPDF: Fix leak in SkPDFShader
...
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/1006813010
2015-03-24 10:21:34 -07:00
reed
816d6c78a5
enable color-matrix-floats again, watching arm64 bots
...
BUG=skia:
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/1035493002
2015-03-24 10:04:38 -07:00
mtklein
4b65059e6e
Go back to storeAligned / LoadAligned for SkPMFloat <->Sk4f.
...
This seems to fix the miscompilation bug on ARM64 / Release / GCC 4.9.
We switched this over originally for perf issues with NEON, but I can't see any now. Will keep an eye out.
BUG=skia:3570
Review URL: https://codereview.chromium.org/1026403002
2015-03-24 09:47:12 -07:00
caryclark
c207f9b2e8
fix destructor order to fix build
...
TBR=reed
Review URL: https://codereview.chromium.org/1033703002
2015-03-24 09:16:25 -07:00
caryclark
e02c944e97
remove obsolete tests
...
remove tests that are breaking the build -- uninitialized memory
TBR=reed
Review URL: https://codereview.chromium.org/1030883002
2015-03-24 08:17:16 -07:00
halcanary
547019e1a6
SkPDF: clean up extra references
...
This cleans up code left behind from http://crrev.com/870333002
Review URL: https://codereview.chromium.org/1029263004
2015-03-24 08:12:55 -07:00
senorblanco
8c24d453a2
Move SkMatrixImageFilter.h into src/core.
...
Callers in Blink have been updated to call
SkImageFilter::CreateMatrixFilter() instead.
BUG=skia:3568
Review URL: https://codereview.chromium.org/1013753013
2015-03-24 07:51:30 -07:00
caryclark
ccec0f958f
pathops version two
...
R=reed@google.com
marked 'no commit' to attempt to get trybots to run
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1002693002
2015-03-24 07:28:17 -07:00
reed
62a320c8d4
Revert of Revert of remove colorfilter native-565 support. complicating w/ no real value. (patchset #1 id:1 of https://codereview.chromium.org/1022673007/ )
...
Reason for revert:
fix for chrome has landed...
Original issue's description:
> Revert of remove colorfilter native-565 support. complicating w/ no real value. (patchset #2 id:20001 of https://codereview.chromium.org/1015533011/ )
>
> Reason for revert:
> skia/ext/benchmarking_canvas.cc references HasFilter16 :(
>
> Original issue's description:
> > remove colorfilter native-565 support. complicating w/ no real value.
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/2151353d161fe389cdc0db62cfe1932c7680f710
>
> TBR=reed@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/92b47c49016749249ff8521e424c4373b4a74241
TBR=reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1016103004
2015-03-24 06:35:23 -07:00
mtklein
470fa6f74b
aacc + bbdd
...
SkMatrix::mapPts() using aacc/bbdd was always worse than using badc():
- On Intel, it was faster than exisiting swizzle, but badc() is 10% faster still (one pshufd instead of two).
- On ARM, existing swizzle < badc() < aacc()+bbdd(), even though aacc() then bbdd() is really a single vtrn instruction.
I will revert SkMatrix.cpp before submitting. Just thought you might like to look.
Will think more and try to gear up Instruments on ARM.
BUG=skia:
Review URL: https://codereview.chromium.org/1012573003
2015-03-24 06:16:30 -07:00
reed
92b47c4901
Revert of remove colorfilter native-565 support. complicating w/ no real value. (patchset #2 id:20001 of https://codereview.chromium.org/1015533011/ )
...
Reason for revert:
skia/ext/benchmarking_canvas.cc references HasFilter16 :(
Original issue's description:
> remove colorfilter native-565 support. complicating w/ no real value.
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/2151353d161fe389cdc0db62cfe1932c7680f710
TBR=reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1022673007
2015-03-24 05:18:09 -07:00
reed
b67eb2f9b9
Revert "Revert of impl colormatrix w/ floats (patchset #7 id:120001 of https://codereview.chromium.org/967943002/ )"
...
disabled for the momment -- need to understand arm64 glitches
This reverts commit 374a4c3b74
.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1028403002
2015-03-24 04:13:45 -07:00
reed
2151353d16
remove colorfilter native-565 support. complicating w/ no real value.
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1015533011
2015-03-24 03:50:22 -07:00
reed
8d1a97e044
Revert of correct reporting of kAlphaUnchanged_Flag in ModeFilter (patchset #1 id:1 of https://codereview.chromium.org/1033583002/ )
...
Reason for revert:
reverting experiment. need to rebaseilne layouttest
svg/css/text-gradient-shadow.svg
Original issue's description:
> correct reporting of kAlphaUnchanged_Flag in ModeFilter
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/afced66b508ac4cd3616e2f707db27b7d6f670e1
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1026313002
2015-03-24 03:48:27 -07:00
reed
afced66b50
correct reporting of kAlphaUnchanged_Flag in ModeFilter
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1033583002
2015-03-23 20:05:04 -07:00
reed
374a4c3b74
Revert of impl colormatrix w/ floats (patchset #7 id:120001 of https://codereview.chromium.org/967943002/ )
...
Reason for revert:
Arm64 seems to be having glitches :(
See gm:colormatrix on Arm64/TegraK1/Nexus9
last square should be all white, but it has stripes
Original issue's description:
> impl colormatrix w/ floats
>
> this needs to land first https://codereview.chromium.org/1031713003
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7971def11be91ed08eae7107b372322d24e67544
TBR=mtklein@google.com ,caryclark@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1030743003
2015-03-23 18:52:57 -07:00
reed
7971def11b
impl colormatrix w/ floats
...
this needs to land first https://codereview.chromium.org/1031713003
BUG=skia:
Review URL: https://codereview.chromium.org/967943002
2015-03-23 14:35:25 -07:00
mtklein
2e220fb9ec
Start fresh on swizzles
...
This removes all the existing Sk4x swizzles and adds badc(), which is
both fast on all implementations and currently useful.
BUG=skia:
Review URL: https://codereview.chromium.org/997353005
2015-03-23 13:19:03 -07:00
tomhudson
f7edcdedb6
Both DM and nanobench need this, so moving the duplicated code to
...
one common spot. (It's incomplete, and has had bugs, so it's not
like we can confidently write once, copy-paste, and not maintain
again.)
Because SkPathEffect::exposedInAndroidJavaAPI() only builds in the
Android Framework, we might want to make all this code Framework-only?
R=djsollen@google.com ,mtklein@google.com
Review URL: https://codereview.chromium.org/1021823003
2015-03-23 12:51:20 -07:00
mtklein
92d04da38f
Replace _mm_cvtps_epi32(x) with _mm_cvttps_epi32(_mm_add_ps(0.5f), x).
...
We don't have control over which way _mm_cvtps_epi32 rounds.
- This makes the SSE SkPMFloat rounding consistent with _neon and _none.
- Sk4f::cast<Sk4i>() is closer to (int)float's behavior. (Correct when >=0).
Add tests that would fail at head.
BUG=skia:
Review URL: https://codereview.chromium.org/1029163002
2015-03-23 12:01:46 -07:00
bungeman
b8a1d30a42
Add font "index" to lmp parser.
...
When ttc index support was added, it was added and tested on Android
with the jb parser. This adds it to the lmp parser.
Review URL: https://codereview.chromium.org/1023313002
2015-03-23 09:08:54 -07:00
reed
8010632f24
remove meaningless matrix benches, add mapPts() and add new benches
...
mapPts definitely faster than mapPoints (identity and perspective same speed). Up to 3x for large values of N.
cloned from https://codereview.chromium.org/1031443002/
BUG=skia:
Review URL: https://codereview.chromium.org/1030653002
2015-03-23 08:15:14 -07:00
joshualitt
9c328187d9
Initial change to move text blob to GrTextContext
...
BUG=skia:
Review URL: https://codereview.chromium.org/1019633002
2015-03-23 08:13:04 -07:00
tomhudson
c589f6c968
Get rid of excess cleverness in benchmark
...
RotatedRectBench was asking for its base layer size, which may
not be what it expects with odd canvas modes (particularly proxies).
Most benchmarks are not so sophisticated; they hard-wire their
size and just use that (expected) value.
R=mtklein@google.com ,djsollen@google.com
BUG=skia:3566
Review URL: https://codereview.chromium.org/1015013004
2015-03-23 07:46:13 -07:00
tomhudson
68260fa1e9
Make SkCanvas::getBaseLayerSize() virtual
...
Subclasses of SkCanvas may need to override the behavior here - for
example, any proxy or deferred canvas may not know its own size and
need to delegate to another object.
We'll also work on reducing use of this function
(https://skbug.com/3569 ), but some of the current uses seem to be
semantically necessary.
R=reed@google.com
BUG=skia:3566
Review URL: https://codereview.chromium.org/1022423002
2015-03-23 07:22:40 -07:00
kkinnunen
dc3d96890f
Fix two typos in coding style
...
Fix two typos in coding style:
- Memory Managemt
- if (NULL == x) equated to if (x)
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1032463002
Review URL: https://codereview.chromium.org/1032463002
2015-03-23 06:27:23 -07:00
robertphillips
3e5c2b1041
Preserve texture compression when saving a revised skp from debugger
...
Without this CL, saving a revised skp out the debugger can greatly expand the memory it requires.
Review URL: https://codereview.chromium.org/1020103005
2015-03-23 05:46:51 -07:00
kkinnunen
8dcb8b04f8
Do not playback pending commands for full deferred canvas writePixels
...
Do not playback pending commands for full deferred canvas writePixels.
Changes the test to catch cases where discard is done without
a snapshot.
Review URL: https://codereview.chromium.org/939103002
2015-03-23 02:18:02 -07:00
skia.buildbots
96017dc2b8
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/1030453002
2015-03-22 01:14:17 -07:00
reed
4a8562ba64
remove SK_SUPPORT_LEGACY_ARCTO_QUADS code
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1023103004
2015-03-20 19:41:10 -07:00
reed
2fcbcea3a4
change default impl to facilitate transition in blink/chrome
...
BUG=skia:
TBR=
need deps roll to see if this works... since skia can no longer build/test in this legacy mode.
Review URL: https://codereview.chromium.org/1026923002
2015-03-20 15:25:25 -07:00
reed
5fedef1c31
remove SK_SUPPORT_LEGACY_PIXELREF_UNFLATTENABLE code
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1020403002
2015-03-20 14:20:09 -07:00
mtklein
02f46cf878
Some usability ideas around SkTHash.
...
- By default, use new SkGoodHash to hash keys, which is:
* for 4 byte values, use SkChecksum::Mix,
* for SkStrings, use SkChecksum::Murmur3 on the data,
* for other structs, shallow hash the struct with Murmur3.
- Expand SkChecksum::Murmur3 to support non-4-byte-aligned data.
- Add const foreach() methods.
- Have foreach() take a functor, which allows lambdas.
BUG=skia:
Review URL: https://codereview.chromium.org/1021033002
2015-03-20 13:48:42 -07:00
reed
ce6acc9108
cleanup using constructors
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1024193002
2015-03-20 13:46:08 -07:00
reed
b640203cd5
use Sk2s for conics
...
BUG=skia:
Review URL: https://codereview.chromium.org/1025033002
2015-03-20 13:23:43 -07:00
mtklein
cea9f35fee
Sk2x::invert() and Sk2x::approxInvert()
...
BUG=skia:
Review URL: https://codereview.chromium.org/1024993002
2015-03-20 13:17:42 -07:00
jvanverth
7b462a2b85
Return to old distance field glyph sizes.
...
Should fix some blurry or light glyphs on Windows.
Review URL: https://codereview.chromium.org/1026613003
2015-03-20 12:35:07 -07:00
halcanary
db0dcc7436
PDF: remove last use of SkPDFImage
...
Add a GM.
BUG=skia:255
Review URL: https://codereview.chromium.org/950633003
2015-03-20 12:31:52 -07:00
mtklein
bf0c56f82b
Hack around skia:3570 for now.
...
BUG=skia:3570
Review URL: https://codereview.chromium.org/1021353002
2015-03-20 12:21:53 -07:00
scroggo
1dd3ea9d45
Add SkEncodedFormat, used by SkCodec.
...
Needed by Android to determine the format.
Review URL: https://codereview.chromium.org/1018953003
2015-03-20 11:55:55 -07:00