Commit Graph

9539 Commits

Author SHA1 Message Date
reed@google.com
6fcbfcead5 Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning"
This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497.

git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 16:31:11 +00:00
reed@google.com
081560e3ab add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning
BUG=
R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org

Review URL: https://codereview.chromium.org/51033004

git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 16:24:08 +00:00
robertphillips@google.com
94bdd7e3fc Fix bug in don't-reuse-scratch-textures path
https://codereview.chromium.org/50853003/



git-svn-id: http://skia.googlecode.com/svn/trunk@12054 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 15:50:43 +00:00
vandebo@chromium.org
e4e5cabb48 Rebaseline for r12034
xfermodes changed in all configs - added more src types.
The following gms changed only for pdf configs:
xfermodes2, xfermodes3, aarectmodes, colormatrix, lumafilter, mixed_xfermodes

R=edisonn@google.com

Review URL: https://codereview.chromium.org/54763003

git-svn-id: http://skia.googlecode.com/svn/trunk@12053 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 15:46:38 +00:00
robertphillips@google.com
d5743ed263 Remove suppression of morphology image diffs
git-svn-id: http://skia.googlecode.com/svn/trunk@12050 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 13:42:30 +00:00
robertphillips@google.com
0bef50638c Rebaselines of morphology GM for r11966
https://codereview.chromium.org/54353004/



git-svn-id: http://skia.googlecode.com/svn/trunk@12049 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 13:25:18 +00:00
borenet@google.com
44b3a64811 Whitespace change to trigger builds after buildbot script changes
Review URL: https://codereview.chromium.org/54673002

git-svn-id: http://skia.googlecode.com/svn/trunk@12047 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 13:21:32 +00:00
skia.committer@gmail.com
7ed98df9ba Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12043 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 07:01:53 +00:00
robertphillips@google.com
cb505101a2 No longer use scratch textures on ARM devices
https://codereview.chromium.org/50643003/



git-svn-id: http://skia.googlecode.com/svn/trunk@12042 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-31 00:51:18 +00:00
senorblanco@chromium.org
1986756c06 Speculative Android build fix.
TBR=robertphillips

Review URL: https://codereview.chromium.org/52693003

git-svn-id: http://skia.googlecode.com/svn/trunk@12041 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 22:38:15 +00:00
bungeman@google.com
ae326bb5ca Revert r1784: SK_API on a non-concrete template is strange.
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/52843004

git-svn-id: http://skia.googlecode.com/svn/trunk@12040 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 22:22:05 +00:00
senorblanco@chromium.org
f49a0955e2 Mac build fix.
TBR=robertphillips

Review URL: https://codereview.chromium.org/45963007

git-svn-id: http://skia.googlecode.com/svn/trunk@12039 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 22:14:24 +00:00
senorblanco@chromium.org
7a47ad3bac Implement SSE2-based implementations of the morphology filters (dilate & erode). This gives a 3-5X speedup over the naive implementation, and also mitigates a timing-based security attack in Chrome (https://code.google.com/p/chromium/issues/detail?id=251711).
NOTE: this will require a corresponding GYP change on the Skia roll into Chrome: https://codereview.chromium.org/52453004/

R=mtklein@google.com, reed@google.com

Review URL: https://codereview.chromium.org/52603004

git-svn-id: http://skia.googlecode.com/svn/trunk@12038 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 21:57:04 +00:00
robertphillips@google.com
2d2e5c4e24 Make not-reusing-scratch-textures only apply to texture uploads
https://codereview.chromium.org/53133002/



git-svn-id: http://skia.googlecode.com/svn/trunk@12037 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 21:30:43 +00:00
vandebo@chromium.org
f5747daed9 Fix int/SkScalar mismatch in gm.
Review URL: https://codereview.chromium.org/45953005

git-svn-id: http://skia.googlecode.com/svn/trunk@12036 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 21:29:47 +00:00
vandebo@chromium.org
fd3c8c243a Fix int/SkScalar mismatch.
Review URL: https://codereview.chromium.org/51043005

git-svn-id: http://skia.googlecode.com/svn/trunk@12035 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 21:00:47 +00:00
vandebo@chromium.org
3b416216d1 [PDF] Improve complex xfer mode support.
Xfer mode applies only to the shape of the source drawing, not everything in the clip as in currently implemented.  It's just that the current gm examples draw a shape that fills the visible layer.

R=edisonn@google.com, reed@google.com

Review URL: https://codereview.appspot.com/4631078

git-svn-id: http://skia.googlecode.com/svn/trunk@12034 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 20:48:05 +00:00
commit-bot@chromium.org
c1362424b8 DM: add --rtree.
BUG=
R=epoger@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/51243003

git-svn-id: http://skia.googlecode.com/svn/trunk@12033 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 20:45:28 +00:00
commit-bot@chromium.org
c9424b8e6d Don't check if shaders compile or program links in release Chromium
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/52843003

git-svn-id: http://skia.googlecode.com/svn/trunk@12032 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 20:03:16 +00:00
commit-bot@chromium.org
537e26ae3c Exclude verylargebitmap test from replay modes on windows.
BUG=skia:1756
R=epoger@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/52903003

git-svn-id: http://skia.googlecode.com/svn/trunk@12030 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 18:58:03 +00:00
commit-bot@chromium.org
1ab9f737f0 Use SkPathRef gen id for SkPath::getGenerationID
R=mtklein@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/49693002

git-svn-id: http://skia.googlecode.com/svn/trunk@12029 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 18:57:55 +00:00
edisonn@google.com
b38d4e1584 Mark GMs that are not preserving the perspective for the canvas passed
Review URL: https://codereview.chromium.org/52443005

git-svn-id: http://skia.googlecode.com/svn/trunk@12028 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 18:57:09 +00:00
edisonn@google.com
dc370e213d update results for Nexus4 gms that run in perspespective mode
Review URL: https://codereview.chromium.org/48623004

git-svn-id: http://skia.googlecode.com/svn/trunk@12026 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 18:46:31 +00:00
epoger@google.com
6b288d116b semi-blindly rebaseline some GM results, keeping them marked as unreviewed
(they were unreviewed in the first place, so there's no particular reason
to think they are either better or worse than they were before)

As discussed live with bsalomon
TBR=bsalomon

Review URL: https://codereview.chromium.org/53023002

git-svn-id: http://skia.googlecode.com/svn/trunk@12024 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 18:14:29 +00:00
epoger@google.com
1f87465aa7 rebaseline GM results on Android-IntelRhb and Valgrind bots which were not running for a while
Mostly tiny diffs due to roundrect implementation changes.  Also a couple of
GM tests that are known to have changed.

Visually reviewed by bsalomon and epoger

BUG=skia:1771
TBR=bsalomon

Review URL: https://codereview.chromium.org/52963002

git-svn-id: http://skia.googlecode.com/svn/trunk@12023 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 17:56:17 +00:00
reed@google.com
4db592c408 remove contains(x,y) for rects and rrects ... not well defined, and unused
BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/51953003

git-svn-id: http://skia.googlecode.com/svn/trunk@12022 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 17:39:43 +00:00
robertphillips@google.com
4e5559af89 Allow specifying the max texture count on the bots
https://codereview.chromium.org/50413011/



git-svn-id: http://skia.googlecode.com/svn/trunk@12020 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 17:04:16 +00:00
reed@google.com
35fe7372b1 prototype for kerning api
BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/29363009

git-svn-id: http://skia.googlecode.com/svn/trunk@12018 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 15:07:03 +00:00
epoger@google.com
b08c707847 rebaseline_server: report proper URL upon launch
BUG=skia:1767
(SkipBuildbotRuns)

R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/51353002

git-svn-id: http://skia.googlecode.com/svn/trunk@12016 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 14:09:04 +00:00
reed@google.com
bbe66f0824 add triangles to fatbits sample ('t')
git-svn-id: http://skia.googlecode.com/svn/trunk@12015 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 13:41:19 +00:00
skia.committer@gmail.com
b77f0f4ae5 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12013 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-30 07:01:56 +00:00
robertphillips@google.com
7101abe5b3 Reverting r12010 (Use SkPathRef gen id for SkPath::getGenerationID https://codereview.chromium.org/49693002) due to test failures in PathTest on Android
git-svn-id: http://skia.googlecode.com/svn/trunk@12012 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 22:45:37 +00:00
commit-bot@chromium.org
af94d9a82e GM is passing the wrong flag to beginRecording() for --rtree.
BUG=
R=epoger@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/50713004

git-svn-id: http://skia.googlecode.com/svn/trunk@12011 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 21:38:54 +00:00
commit-bot@chromium.org
4cc7518d9b Use SkPathRef gen id for SkPath::getGenerationID
R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/49693002

git-svn-id: http://skia.googlecode.com/svn/trunk@12010 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 21:34:55 +00:00
commit-bot@chromium.org
658e28b081 Remove SkMatrix44 float conversions without precision loss
BUG=none
R=reed@google.com

Author: enne@chromium.org

Review URL: https://codereview.chromium.org/50423004

git-svn-id: http://skia.googlecode.com/svn/trunk@12009 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 21:08:51 +00:00
commit-bot@chromium.org
950923b437 All SkAnnotations are no-draw. Propose we fold that through.
BUG=
R=edisonn@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/48523008

git-svn-id: http://skia.googlecode.com/svn/trunk@12008 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 20:44:39 +00:00
commit-bot@chromium.org
89ff3dd5af Little changes to SkAnnotation in pipe:
- store size in the op data field rather than separately (saves 4 bytes);
  - trim out a malloc/memcpy in each of read and write;
  - remove unused enum value;
  - use the right _unpackOp function;
  - make sure we call needOpBytes().

BUG=
R=reed@google.com, scroggo@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/50523004

git-svn-id: http://skia.googlecode.com/svn/trunk@12007 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 20:29:38 +00:00
commit-bot@chromium.org
7585479202 Allow SkLazyPixelRef to use SkScaledImageCache
-   SkScaledImageCache:
    -   Add new FindAndLock/AddAndLock variants that work well with
        SkLazyPixelRefs (take width, height, generation_id).
    -   Add static versions of these new variants.

-   SkLazyPixelRef:
    -   If NULL passed in as SkImageCache* in the constructor, it will
        now default to using the static SkScaledImageCache methods to
        cache decoded images.
    -   If (fImageCache==NULL), the default allocator can be changed
        with the setAllocator method.  If (fImageCache!=NULL), the
        SkImageCache handles allocation.

-   CachedDecodingPixelRefTest to test the new functionality.

BUG=
R=scroggo@google.com, mtklein@google.com, reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/37343002

git-svn-id: http://skia.googlecode.com/svn/trunk@12006 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 19:55:00 +00:00
commit-bot@chromium.org
f9a2759d94 tests: Provide a default resources path.
This is cuts down noise when running from skia/trunk, where this is the right
path to look in.

BUG=
R=epoger@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/51263002

git-svn-id: http://skia.googlecode.com/svn/trunk@12005 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 19:50:39 +00:00
commit-bot@chromium.org
40258a5be9 Fix pipe/annotation.
We weren't keeping track of the annotation that's on the other side of the pipe.

BUG=skia:1761
R=scroggo@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/48273011

git-svn-id: http://skia.googlecode.com/svn/trunk@12004 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 19:23:26 +00:00
epoger@google.com
4259ef3dbd rebaseline_server: replace TODOs section with link to documentation/roadmap
(SkipBuildbotRuns)

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/47543008

git-svn-id: http://skia.googlecode.com/svn/trunk@12002 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 17:39:09 +00:00
epoger@google.com
f4394d5531 rebaseline_server: allow substring filtering for builder and test
If the user clicks on a particular value for one of these fields, that field's
value will go into the filtering box (so you will only see results matching
that field value).

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/47423002

git-svn-id: http://skia.googlecode.com/svn/trunk@12000 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 15:49:40 +00:00
commit-bot@chromium.org
602b9608f5 Get rid of two unused variables from the .data section.
Before:
$ objdump -x out/Release/libskia_opts.a | grep "\.data" | c++filt
1 .data         00000000  0000000000000000  0000000000000000  000004ec  2**2
0000000000000000 l    d  .data        0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000f58  2**2
0000000000000000 l    d  .data      0000000000000000 .data
2 .data         00000008  0000000000000000  0000000000000000  00001774  2**2
0000000000000000 l    d  .data    0000000000000000 .data
0000000000000000 g     O .data    0000000000000004 debug_x
0000000000000004 g     O .data    0000000000000004 debug_y
1 .data         00000000  0000000000000000  0000000000000000  00001d8c  2**2
0000000000000000 l    d  .data  0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000054  2**2
0000000000000000 l    d  .data        0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  000001f0  2**2
0000000000000000 l    d  .data      0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000044  2**2
0000000000000000 l    d  .data    0000000000000000 .data

After:
$ objdump -x out/Release/libskia_opts.a | grep "\.data" | c++filt
1 .data         00000000  0000000000000000  0000000000000000  000004ec  2**2
0000000000000000 l    d  .data        0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000f58  2**2
0000000000000000 l    d  .data      0000000000000000 .data
2 .data         00000000  0000000000000000  0000000000000000  00001774  2**2
0000000000000000 l    d  .data    0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00001d8c  2**2
0000000000000000 l    d  .data  0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000054  2**2
0000000000000000 l    d  .data        0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  000001f0  2**2
0000000000000000 l    d  .data      0000000000000000 .data
1 .data         00000000  0000000000000000  0000000000000000  00000044  2**2
0000000000000000 l    d  .data    0000000000000000 .data

Not sure why clang didn't catch them.

R=mtklein@google.com
BUG=

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/50013002

git-svn-id: http://skia.googlecode.com/svn/trunk@11999 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 15:32:09 +00:00
commit-bot@chromium.org
0caa68ab2f DM: add --quiet
This has been handy when tossing in other SkDebugf's.

BUG=
R=bsalomon@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/49323007

git-svn-id: http://skia.googlecode.com/svn/trunk@11998 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 15:02:17 +00:00
robertphillips@google.com
9ef0426e7c Don't reuse scratch textures patch
https://codereview.chromium.org/24222004/



git-svn-id: http://skia.googlecode.com/svn/trunk@11997 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 14:06:15 +00:00
robertphillips@google.com
0b7ab3bb49 Fix bug in erosion filtering
https://codereview.chromium.org/50813002/



git-svn-id: http://skia.googlecode.com/svn/trunk@11996 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 13:59:31 +00:00
bsalomon@google.com
bc0dbdc169 svndiff for the windows
R=epoger@google.com

Review URL: https://codereview.chromium.org/49323006

git-svn-id: http://skia.googlecode.com/svn/trunk@11995 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 13:55:29 +00:00
skia.committer@gmail.com
70402c3168 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11992 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-29 07:01:50 +00:00
commit-bot@chromium.org
8ab77eae2c Fix narrowing conversion errors from r11986
Although this function only gets used for SkMScalar=float, it gets
compiled in when SkMScalar=double.

R=epoger@google.com
BUG=1764

Author: enne@chromium.org

Review URL: https://codereview.chromium.org/49463005

git-svn-id: http://skia.googlecode.com/svn/trunk@11991 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 22:05:41 +00:00
commit-bot@chromium.org
ea7e69a52e A fix for annoying clang error "unused-const-variabl" in third_party code.
../../third_party/externals/libwebp/src/enc/quant.c:105:23: error: unused variable 'kCoeffThresh' [-Werror,-Wunused-const-variable]
static const uint16_t kCoeffThresh[16] = {
                              ^
                      1 error generated.

BUG=None
TEST=build with clang, ninja -C out/Debug most.
R=bsalomon@google.com, epoger@google.com, thakis@chromium.org, mtklein@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/47603012

git-svn-id: http://skia.googlecode.com/svn/trunk@11990 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-28 22:05:12 +00:00