robertphillips
730c044791
Alter Default & Software path renderers to better handle AA hairline paths
...
For some (as yet unknown reason) the guard in ConicPathBench that disables the path_hairline_big_AA_conic case isn't working. As an alternate fix, this CL makes the Default path renderer confess its lack of support for conics and allows the Software path renderer to handle non-AA cases. This will work but the real fix is to enable conics in the Default path renderer.
Here is the situation we're seeing in the path_hairline_big_AA_conic case:
the path is a hairline drawn with AA
the render target is multisampled (so AA on the draw gets disabled)
StencilAndCover path renderer doesn't handle hairlines
AAHairLine path renderer only handles AA paths (but can handle conics)
AAConvexPath renderer also only handles AA paths
Default path renderer only handles non-AA paths (but doesn't handle conics)
Software path renderer - was disallowed from handling non-AA paths
BUG=skia:2078
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/418073002
2014-07-25 05:52:38 -07:00
robertphillips
f7be19401b
Rebaseline GN & N4 perf trigger flakes
...
R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/419683005
2014-07-25 04:34:40 -07:00
borenet
75770afff8
Update SKP version to 58
...
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/420693002
2014-07-24 22:58:09 -07:00
Brian Salomon
0925a5784c
Add initial baselines for varied_text* GMs
...
Review URL: https://codereview.chromium.org/416983002
2014-07-24 17:23:44 -04:00
djsollen
bc89329fb5
Enable the SSSE3 compile time check on all platforms (4th attempt)
...
BUG=skia:2746
R=bungeman@google.com , robertphillips@google.com , mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/414033002
2014-07-24 13:53:56 -07:00
epoger
57493ba62a
check in empty SKP expectations for a single platform
...
This should trigger the http://108.170.220.120:10117/builders/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug
to start recording images from the SKPs.
BUG=skia:1942
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/410423006
2014-07-24 11:46:47 -07:00
epoger
20fa24cb3d
roll common DEPS
...
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/411063006
2014-07-24 10:39:01 -07:00
krajcevski
2a413df4da
Add ASTC to list of alpha compressed formats
...
R=bsalomon@google.com , robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/412113004
2014-07-24 08:16:01 -07:00
bungeman
8d84c99531
SkFontMgr for Android.
...
Committed: https://skia.googlesource.com/skia/+/4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06
R=djsollen@google.com , tomhudson@google.com , robertphillips@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/414483002
2014-07-24 08:05:10 -07:00
scroggo
307bcea492
skimage expectations for Android-Reference-Unknown
...
Fixes build.
NOTRY=true
R=borenet@google.com , robertphillips@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/416083002
2014-07-24 06:55:31 -07:00
robertphillips
a2c79fb412
Suppress Win8 raster verylargebitmap GM flakes
...
BUG=skia:2775
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/418863003
2014-07-24 05:30:39 -07:00
bungeman
f73c237291
Get additional DW font metrics when available.
...
BUG=chromium:395043
R=eae@chromium.org , caryclark@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/412993002
2014-07-23 13:31:07 -07:00
bungeman
2da0f85488
Revert of Enable the SSSE3 compile time check on all platforms. ( https://codereview.chromium.org/403583002/ )
...
Reason for revert:
This is blocking the roll. Chromium Windows trybots (like win_chromium_x64_rel) are crashing in the SSSE3 code (for example SkCanvasVideoRenderTest.CroppedFrame).
Original issue's description:
> Enable the SSSE3 compile time check on all platforms (3rd attempt)
>
> BUG=skia:2746
>
> Committed: https://skia.googlesource.com/skia/+/933834851f9d48fbd85b728cc92e1f0134bfaa4e
R=halcanary@google.com , mtklein@google.com , djsollen@google.com
TBR=djsollen@google.com , halcanary@google.com , mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2746
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/418523002
2014-07-23 11:28:18 -07:00
robertphillips
ddb459e746
Fix some flaky perf triggers
...
R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/416483002
2014-07-23 04:55:10 -07:00
robertphillips
7b82d0f8e6
Revert of SkFontMgr for Android. ( https://codereview.chromium.org/414483002/ )
...
Reason for revert:
Reverting to unblock DEPS roll.
Original issue's description:
> SkFontMgr for Android.
>
> Committed: https://skia.googlesource.com/skia/+/4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06
R=djsollen@google.com , tomhudson@google.com , bungeman@google.com
TBR=bungeman@google.com , djsollen@google.com , tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/408143010
2014-07-22 16:36:13 -07:00
robertphillips
ba0055b290
Revert "Update fontmgr expectations."
...
This reverts commit ff4b56b2d5
.
R=bungeman@gmail.com
TBR=bungeman@gmail.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/406323004
2014-07-22 16:34:38 -07:00
bungeman
ff4b56b2d5
Update fontmgr expectations.
2014-07-22 18:21:24 -04:00
piotaixr
76d5b477c9
Now able to set the localMatrix when creating a SkShader from a SkImage
...
BUG=skia:2771
R=junov@chromium.org , reed@chromium.org , bsalomon@chromium.org , bsalomon@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/409653003
2014-07-22 15:02:05 -07:00
djsollen
85d36525c6
fix android_framework build do to missing library at link time
...
R=scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/407073006
2014-07-22 13:56:34 -07:00
jvanverth
dd6d22751a
Replace use of GrTHashTable in GrFontCache with SkTDynamicHash.
...
Searching the font cache for existing text strikes was showing up
as a hotspot on Android. This change reduces that cost.
R=bsalomon@google.com , robertphillips@google.com , mtklein@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/390103002
2014-07-22 13:25:26 -07:00
bsalomon
1c63bf6e90
Revert "Revert of Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are… ( https://codereview.chromium.org/376703009/ )"
...
This reverts commit 249171e7d2
.
Uses 32 bit id instead of 64. Renamed instanceID to uniqueID to match existing code.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/414493002
2014-07-22 13:09:46 -07:00
bsalomon
c2553373ee
Make nanobench setup configs outside of loop over benchmarks
...
R=mtklein@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/410683005
2014-07-22 13:09:05 -07:00
bungeman
33d134656e
Suppress fontmgr gm changes while Android catches up.
2014-07-22 16:02:58 -04:00
senorblanco
bc9845bb60
Remove the single-sigma version of SkDropShadowImageFilter::Create().
...
It's no longer used in Chrome.
BUG=skia:
R=bsalomon@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/407203002
2014-07-22 12:49:25 -07:00
scroggo
24519371cb
Run CanvasState test across a library boundary.
...
Refactor CanvasStateTest to pull out functions which can
either be called directly or from a shared library. Add a
command line flag to pass in the path to a library to open
to call those functions from.
Separate different CanvasTest tests into separate DEF_TEST
tests. This allows them to be run in parallel.
Move the ifdefs outside of function declarations to skip
running CanvasTest tests which do nothing.
Add the canvas_state_lib target. It is a shared library that
exports some functions to be called by another version of
Skia.
BUG=b/15693384
R=djsollen@google.com , reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/400043003
2014-07-22 12:38:55 -07:00
scroggo
c0bc913451
Introduce skia_pic gyp variable.
...
skia_pic tells ninja to use -fPIC when building for position
independent code.
Set skia_pic to true when building our existing targets that
require position independent code.
Also use skia_pic when building for Android.
R=mtklein@google.com , djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/406613003
2014-07-22 12:09:30 -07:00
bungeman
4f9a01e03e
SkFontMgr for Android.
...
R=djsollen@google.com , tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/414483002
2014-07-22 12:07:14 -07:00
bsalomon
be035702f3
Remove unused enum value and member of GrGpuObject
...
R=robertphillips@google.com
TBR=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/413523002
2014-07-22 11:17:14 -07:00
caryclark
7419e95f39
remove command line args
...
R=robertphillips@google.com
TBR=robertphillips
NOTRY=true
NOTREECHECKS=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/408243003
2014-07-22 10:54:08 -07:00
caryclark
fa9d1356d9
fix nacl
...
R=robertphillips@google.com
TBR=robertphillips
NOTRY=true
NOTREECHECKS=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/407163002
2014-07-22 10:40:06 -07:00
robertphillips
d771f6bc27
Add auto purging for SkPicture-related Ganesh resources (esp. layers)
...
This is intended to lower the bookkeeping burden for the Layer Caching feature. Cached layers are now automatically purged when a picture is deleted.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/408923002
2014-07-22 10:18:06 -07:00
caryclark
17f0b6df72
share dm and command flags
...
Share command flags between dm and unit tests.
Also, allow dm's core to be included by itself and iOSShell.
Command line flags that are the same (or nearly the same) in DM
and in skia_tests have been moved to common_flags. Authors,
please check to see that the shared common flag is correct for
the tool.
For iOS, the 'tool_main' entry point has a wrapper to allow multiple
tools to be statically linked in the iOSShell.
Since SkCommandLineFlags::Parse can only be called once, these calls
are disabled in the IOS build.
Since the iOS app directory is dynamically assigned a name, use '@' to
select it. (This is the same convention chosen by the Mobile Harness
iOS file system utilities.)
Move the heart of dm.gyp into dm.gypi so that it can be included by
itself and iOSShell.gyp.
Add tools/flags/SkCommonFlags.* to define and declare common
command line flags.
Add support for dm to iOSShell.
BUG=skia:
R=scroggo@google.com , mtklein@google.com , jvanverth@google.com , bsalomon@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/389653004
2014-07-22 10:15:35 -07:00
joshualitt
ac9779234e
Initial change to move 2D kernel to its own file.
...
BUG=skia:
R=bsalomon@chromium.org , senorblanco@chromium.org , bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/379253003
2014-07-22 09:52:12 -07:00
krajcevski
6c354881b6
Refactor texture compressors into separate files
...
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/403383003
2014-07-22 07:44:01 -07:00
sugoi
26489839cf
Added count validation in SkImageFilter::Common::unflatten()
...
BUG=395641
R=reed@google.com , senorblanco@google.com , senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/405983006
2014-07-22 07:26:35 -07:00
djsollen
933834851f
Enable the SSSE3 compile time check on all platforms (3rd attempt)
...
BUG=skia:2746
R=halcanary@google.com , mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/403583002
2014-07-22 07:20:18 -07:00
egdaniel
f7caacdbb7
Rebaseline from recent gpu optimization changes
...
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/408203002
2014-07-22 06:46:45 -07:00
robertphillips
d09622e3d3
Rebaseline some flaky perf triggers
...
R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/411513002
2014-07-22 05:02:50 -07:00
cdalton
b85a0aab69
Add a GrPathRange class
...
Adds a GrPathRange object that represents a range of paths on the gpu.
Updates GrDrawTarget::drawPaths and supporting code to use GrPathRange
instead of an array of GrPath objects.
Change-Id: I67845f3893cd4d955db947d699aa3733cbb081e0
BUG=skia:
R=bsalomon@google.com , jvanverth@google.com , kkinnunen@nvidia.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/400713003
2014-07-21 15:32:44 -07:00
bsalomon
dcabb05113
Make GrCacheable implement its own ref counting.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/392333008
2014-07-21 14:24:01 -07:00
epoger
b0a46413e4
roll common DEPS
...
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/404823005
2014-07-21 13:55:57 -07:00
egdaniel
93a37bc91a
Add macro so that gpu trace marker can add an arg to the TRACE_EVENT it makes
...
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/379223004
2014-07-21 13:47:57 -07:00
robertphillips
7a037f494f
Move GrTMultiMap to src/core and rename it
...
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/401343002
2014-07-21 12:40:57 -07:00
krajcevski
ad1df153a1
First pass at a blitter for R11 EAC alpha masks. This shaves 10ms off
...
of the polygon gpu benchmark on the Nexus 7v2 (which is about 6.7% faster).
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/406693002
2014-07-21 11:44:37 -07:00
sugoi
518d83dbc1
Skia side RGB to YUV gpu conversion
...
This code is the one that's currently working in my local chromium build. A few things still need to be addressed and I'll highlight these directly in the code.
BUG=skia:
R=reed@google.com , bsalomon@google.com , senorblanco@google.com , senorblanco@chromium.org , robertphillips@google.com , scroggo@google.com , halcanary@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/374743003
2014-07-21 11:37:39 -07:00
egdaniel
02cafcc1bf
Remove gpu shader optimatization for solid white or trans black colors
...
Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths.
With optimization in (ms):
White Blue Checkered
Linux ~80 ~80 ~160
N7 ~800 ~1100 ~1500
Moto-e ~830 ~1100 ~2500
Without optimization in (ms):
White Blue Checkered
Linux ~80 ~80 ~80
N7 ~1100 ~1100 ~1100
Moto-e ~1100 ~1100 ~1500
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/5f78d2251a440443c9eaa321dad058d7a32bfef7
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/375823005
2014-07-21 11:37:28 -07:00
borenet
5b7c7c4ed3
Move DirectWrite skimage expectations -> GDI
...
BUG=skia:
R=scroggo@google.com , bungeman@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/407973003
2014-07-21 10:01:56 -07:00
krajcevski
75f88512a1
Let blitters be notified when they're done being used
...
R=reed@google.com , robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/399593007
2014-07-21 09:54:23 -07:00
bsalomon
63e99f7a03
Allow GrGLEffects to produce variable length keys.
...
R=robertphillips@google.com , jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/385713005
2014-07-21 08:03:14 -07:00
reed
3f8540346d
hide public factory for intermediate class
...
Use SK_DECLARE_UNFLATTENABLE_OBJECT if the subclass should not be directly instantiated.
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/399383007
2014-07-21 07:31:53 -07:00