caryclark
dfcb7abc41
make arithmode bigtext colortype* degeneratesegments gm portable
...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1235343004
2015-07-17 09:39:16 -07:00
joshualitt
a2a6fe8699
Some cleanups of VisualBench
...
BUG=skia:
Review URL: https://codereview.chromium.org/1240633005
2015-07-17 09:09:23 -07:00
borenet
5150a77ee7
llvm_coverage_build: Use CC and CXX variables by default
...
NOTRY=true
BUG=skia:2430
Review URL: https://codereview.chromium.org/1242573003
2015-07-17 07:31:07 -07:00
jvanverth
992c761239
Reland of Add fast normalize for SkLightingImageFilter. (patchset #1 id:1 of https://codereview.chromium.org/1244523002/ )
...
Reason for revert:
Florin will rebaseline the images.
Original issue's description:
> Revert of Add fast normalize for SkLightingImageFilter. (patchset #2 id:20001 of https://codereview.chromium.org/1240023002/ )
>
> Reason for revert:
> Speculative revert -- DEPS roll block on linux_blink_rel
>
> https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/71483/layout-test-results/results.html
>
> Original issue's description:
> > Add fast normalize for SkLightingImageFilter.
> >
> > The normalize routine in SkPoint3 is very robust. However, for simple
> > lighting cases we prefer speed over robustness. This fixes a perf
> > regression in smoothness.tough_filters_cases.
> >
> > BUG=chromium:510562
> >
> > Committed: https://skia.googlesource.com/skia/+/dfa0ecf169db87f7afddd93bc1c500de481a62c7
>
> TBR=reed@google.com ,senorblanco@google.com,senorblanco@chromium.org,jvanverth@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:510562
>
> Committed: https://skia.googlesource.com/skia/+/ac66a8122b27c388cc74b3913d9a9be351a44e54
TBR=reed@google.com ,senorblanco@google.com,senorblanco@chromium.org,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:510562
Review URL: https://codereview.chromium.org/1241583007
2015-07-17 07:22:30 -07:00
reed
84984efeb6
Revert[2] of guard to remove DrawBitmapRectFlags
...
This reverts commit 91110195a2
.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1240753003
2015-07-17 07:09:43 -07:00
tfarina
b9efc79015
Add an entry in directory for BugChomper.
...
BUG=None
R=borenet@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1239803008
Review URL: https://codereview.chromium.org/1239803008
2015-07-17 07:07:25 -07:00
ethannicholas
330bb956fd
No longer using non-antialiased fast path for lines when antialiasing is on.
...
BUG=skia:3776
Review URL: https://codereview.chromium.org/1223323003
2015-07-17 06:44:02 -07:00
joshualitt
9ec0d4342d
Removing GrTemplates.h
...
BUG=skia:
Review URL: https://codereview.chromium.org/1233923004
2015-07-17 06:40:29 -07:00
joshualitt
73d5de5763
Cleanup of GrFontDescKey
...
BUG=skia:
Review URL: https://codereview.chromium.org/1238473004
2015-07-17 06:19:19 -07:00
scroggo
91110195a2
Revert of guard to remove DrawBitmapRectFlags (patchset #1 id:1 of https://codereview.chromium.org/1235393003/ )
...
Reason for revert:
breaking android framework build
Original issue's description:
> guard to remove DrawBitmapRectFlags
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/6fb0b6779e40ce05c20cf279f0ecff31fa3cd60d
TBR=fmalita@chromium.org ,djsollen@google.com,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1230823007
2015-07-17 05:57:34 -07:00
reed
ac66a8122b
Revert of Add fast normalize for SkLightingImageFilter. (patchset #2 id:20001 of https://codereview.chromium.org/1240023002/ )
...
Reason for revert:
Speculative revert -- DEPS roll block on linux_blink_rel
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/71483/layout-test-results/results.html
Original issue's description:
> Add fast normalize for SkLightingImageFilter.
>
> The normalize routine in SkPoint3 is very robust. However, for simple
> lighting cases we prefer speed over robustness. This fixes a perf
> regression in smoothness.tough_filters_cases.
>
> BUG=chromium:510562
>
> Committed: https://skia.googlesource.com/skia/+/dfa0ecf169db87f7afddd93bc1c500de481a62c7
TBR=reed@google.com ,senorblanco@google.com,senorblanco@chromium.org,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:510562
Review URL: https://codereview.chromium.org/1244523002
2015-07-16 16:02:39 -07:00
senorblanco
ed7cf27322
Now that the SkImageFilter::CropRect crop edges refer to
...
width & height, name them appropriately.
BUG=240827
Review URL: https://codereview.chromium.org/1234873005
2015-07-16 15:19:11 -07:00
joshualitt
47d280d3b0
Fix visual bench memory leak
...
BUG=skia:
Review URL: https://codereview.chromium.org/1239103002
2015-07-16 14:23:22 -07:00
caryclark
ef14cb397c
make glyph_pos imageblur* largeglyphblur portable
...
R=reed@google.com ,bungeman@google.com
Review URL: https://codereview.chromium.org/1243493003
2015-07-16 14:16:04 -07:00
joshualitt
31b21f6719
Small fix for visualbench
...
BUG=skia:
Review URL: https://codereview.chromium.org/1237563005
2015-07-16 13:40:51 -07:00
reed
189186337e
refactor code to apply the croprect
...
BUG=skia:
Review URL: https://codereview.chromium.org/1218993002
2015-07-16 13:17:13 -07:00
jvanverth
dfa0ecf169
Add fast normalize for SkLightingImageFilter.
...
The normalize routine in SkPoint3 is very robust. However, for simple
lighting cases we prefer speed over robustness. This fixes a perf
regression in smoothness.tough_filters_cases.
BUG=chromium:510562
Review URL: https://codereview.chromium.org/1240023002
2015-07-16 12:56:46 -07:00
scroggo
c1121efbc6
Stop running image tests on msaa.
...
Blacklist all image tests on msaa. We do not run them anyway (since
they will not do anything interestingly different from drawing to the
raster backend) - we early exit from Src::draw(), but we still need to
create a render target that matches the size of the image (when not
blacklisted).
Remove the more specific blacklist of a particular image, which is
covered by this one.
BUG=skia:4045
Review URL: https://codereview.chromium.org/1234313006
2015-07-16 12:36:10 -07:00
caryclark
d2ce18520e
make imagefilters* imagemagnifier imageresizetiled portable
...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1238083004
2015-07-16 12:35:58 -07:00
bsalomon
bea0150d83
Revert of Remove rt flags that are not necessary (patchset #1 id:1 of https://codereview.chromium.org/1226123012/ )
...
Reason for revert:
breaks tests, e.g.
https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Nexus9-GPU-TegraK1-Arm64-Release/builds/752/steps/dm/logs/stdio
Original issue's description:
> Remove rt flags that are not necessary
>
> Committed: https://skia.googlesource.com/skia/+/b6b0a6ef179f4143c94ba7e0e1be6e7ce4b0a23a
TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1234503004
2015-07-16 10:00:28 -07:00
bsalomon
b6b0a6ef17
Remove rt flags that are not necessary
...
Review URL: https://codereview.chromium.org/1226123012
2015-07-16 09:34:57 -07:00
joshualitt
8cab9a7685
All batches do their own pipeline compare
...
BUG=skia:
Review URL: https://codereview.chromium.org/1242033002
2015-07-16 09:13:51 -07:00
bsalomon
e8d21e8f24
Make readpixels work on GrTextures
...
Review URL: https://codereview.chromium.org/1234313002
2015-07-16 08:23:13 -07:00
joshualitt
dbe1e6f0c3
Give GrBatch a pointer to GrPipeline
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/1170a12839218f7a23c93487bf95fd83aae0201f
Review URL: https://codereview.chromium.org/1237283007
2015-07-16 08:12:45 -07:00
jvanverth
3e5f55542c
Various GL testing fixes
...
Check for GL context when printing NVPR error string.
Fix some indenting.
Review URL: https://codereview.chromium.org/1235283004
2015-07-16 07:46:07 -07:00
reed
c83a29759a
have canvas send discard instead of retain if the draw would overwrite everything
...
Motivation:
- perf win for clients that overwrite the surface after a snapshot.
- may allow us to eliminate SkDeferredCanvas, as this was its primary advantage.
BUG=skia:
Review URL: https://codereview.chromium.org/1236023004
2015-07-16 07:40:45 -07:00
joshualitt
0df62e3d68
Revert of Give GrBatch a pointer to GrPipeline (patchset #1 id:1 of https://codereview.chromium.org/1237283007/ )
...
Reason for revert:
breaking nanobench
Original issue's description:
> Give GrBatch a pointer to GrPipeline
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/1170a12839218f7a23c93487bf95fd83aae0201f
TBR=bsalomon@google.com ,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1239073002
2015-07-16 07:16:53 -07:00
joshualitt
1170a12839
Give GrBatch a pointer to GrPipeline
...
BUG=skia:
Review URL: https://codereview.chromium.org/1237283007
2015-07-16 07:06:50 -07:00
caryclark
5f7f428844
increase gm offsetimagefilter stroke width
...
With a hairline width, offsetimagefilter fails to draw the
rectangle on some platforms. Make the width 2 so that it
shows up everywhere.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1236133003
2015-07-16 07:06:46 -07:00
borenet
8a955af001
Coverage script: fix missing data
...
BUG=skia:2430
Review URL: https://codereview.chromium.org/1242023002
2015-07-16 07:01:44 -07:00
mtklein
767d273ea0
Replace buggy_blend_modes GM with an exhaustive test.
...
The new test is disabled by default, as it's quite slow.
We can run it if we suspect problems by passing -x to DM.
This test would have been failing before the bug fix, and now is passing.
Assuming the Priv on the end means it's not considered public API...
TBR=reed@google.com
BUG=skia:4052
Review URL: https://codereview.chromium.org/1228333003
2015-07-16 07:01:40 -07:00
reed
6fb0b6779e
guard to remove DrawBitmapRectFlags
...
BUG=skia:
Review URL: https://codereview.chromium.org/1235393003
2015-07-16 06:10:02 -07:00
caryclark
18a240d15c
make *imagefilter morphology iamge bitmapsource gm portable
...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1236403002
2015-07-15 14:23:50 -07:00
caryclark
e148ac5262
make strokefill gm portable
...
Convert the Mac-specific font text statically into
paths so that they draw the same on all platforms.
Add drawing portable text using the fake bold paint
setting so that the code path is tested everywhere
and but draws the same thing.
R=reed@google.com
Review URL: https://codereview.chromium.org/1234463006
2015-07-15 14:03:13 -07:00
reed
af51e04dc0
rename utility to see if a paint will overwrite its pixels
...
BUG=skia:
Review URL: https://codereview.chromium.org/1228853005
2015-07-15 13:42:32 -07:00
wangyix
891f0f35db
Added GLVec4ScalarBench that doesn't use VAOs
...
BUG=skia:
Review URL: https://codereview.chromium.org/1235153008
2015-07-15 12:26:07 -07:00
caryclark
5df0575f04
make gradtext quadpaths gm portable
...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1234233003
2015-07-15 11:57:00 -07:00
bungeman
91e51cbd64
Fix leak in Android FontMgr test.
...
FontMgrAndroidParserTest deos not free the font families it creates.
This issue was discovered by asan when enabling this test on Linux
platforms.
2015-07-15 14:29:25 -04:00
bungeman
786ece17c3
Allow Android font manager on *nix.
...
There is nothing left in the SkFontMgr_android.cpp which is specific
to Android, so allow it to be built and used on *nix platforms. This
allows for easier development and testing.
The only reason to limit to *nix platforms are the dependencies on
Expat and FreeType. This should be buildable and runnable on other
platforms when these dependencies are also available.
Review URL: https://codereview.chromium.org/1228833003
2015-07-15 10:58:47 -07:00
joshualitt
dcd56e2f0e
Fix for android command line arguments to VisualBench
...
BUG=skia:
Review URL: https://codereview.chromium.org/1241923002
2015-07-15 10:17:21 -07:00
jvanverth
eeb8d99b4e
Only run test_wrapped_resources() when GL is active
...
Review URL: https://codereview.chromium.org/1234233002
2015-07-15 10:16:56 -07:00
bsalomon
b4d40ef724
Don't upload texture smaller than the min texture size when stretching a bmp up to a POT
...
BUG=skia:3932
Review URL: https://codereview.chromium.org/1238913002
2015-07-15 10:12:16 -07:00
caryclark
3aaa0db1c4
make colorwheelnative displacement dropshadowimagefilter getposttextpath gm portable
...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1237233004
2015-07-15 09:29:32 -07:00
caryclark
cae3ca65d2
make path-reverse gm portable
...
Put font glyph data in test as path
instead of getting data from the Mac
font. THe font may change, and is
not available on most platforms.
Also remove unreachable code.
R=reed@google.com
Review URL: https://codereview.chromium.org/1230703005
2015-07-15 08:58:13 -07:00
joshualitt
82874f8b28
Match works correctly on visualbench
...
BUG=skia:
Review URL: https://codereview.chromium.org/1234123004
2015-07-15 08:38:02 -07:00
halcanary
4524813cbc
experimental: remove old PDF benchmarking tools
...
TBR=
Review URL: https://codereview.chromium.org/1233093004
2015-07-15 08:06:29 -07:00
borenet
f0c84407ae
llvm-coverage script: respect SKIA_OUT
...
NOTRY=true
BUG=skia:2430
Review URL: https://codereview.chromium.org/1239803002
2015-07-15 07:43:06 -07:00
herb
fd9a6a227b
Fix undefined behavior.
...
BUG=skia:4050
Review URL: https://codereview.chromium.org/1232003008
2015-07-15 07:40:37 -07:00
yang.zhang
dc77b35918
Optimize RGB16 blitV functions with NEON for ARM platform.
...
Here are some performance resultsi on Nexus 9:
SkRGB16BlitterBlitV_neon:
+--------+-----------+
|height | C/NEON |
+--------+-----------+
|1 | 0.765230 |
+--------+-----------+
|8 | 1.273330 |
+--------+-----------+
|18 | 1.441462 |
+--------+-----------+
|32 | 1.627798 |
+--------+-----------+
|76 | 1.683131 |
+--------+-----------+
|85 | 1.679456 |
+--------+-----------+
|120 | 1.721311 |
+--------+-----------+
|128 | 1.725482 |
+--------+-----------+
|512 | 1.784117 |
+--------+-----------+
BUG=skia:
Review URL: https://codereview.chromium.org/1213723002
2015-07-15 07:07:30 -07:00
scroggo
004aebd42c
Revert of Added a GLBench for testing performance of vec4 vs scalar for coverage in generated shaders. (patchset #6 id:90001 of https://codereview.chromium.org/1225383002/ )
...
Reason for revert:
Still failing on Windows. e.g. https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-ANGLE/builds/231/steps/nanobench/logs/stdio
skbug.com/4053
Original issue's description:
> Added a glBench for testing performance of vec4 vs scalar coverage in generated shaders.
>
> Added bench for timing vec4 vs scalar type for coverage in shaders
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/6104ced165f17eb2f765ace354d5895c0bc890c5
>
> Committed: https://skia.googlesource.com/skia/+/c734e69e8cf94bacaf68d3d8ee3310d1ad1fe8b8
TBR=joshualitt@google.com ,tomhudson@google.com,wangyix@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1239503003
2015-07-15 06:36:42 -07:00