Commit Graph

7327 Commits

Author SHA1 Message Date
bsalomon@google.com
8686be2fc3 Remove 16bit asserts and casts of string length.
R=reed@google.com

Review URL: https://codereview.chromium.org/14711011

git-svn-id: http://skia.googlecode.com/svn/trunk@9112 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-13 18:48:40 +00:00
commit-bot@chromium.org
166726b117 Fix stroked roundrects on Nexus 10.
Due to floating point precision errors, using the formula b^2x^2 + a^2y^2  - a^2b^2 
doesn't work on the Nexus 10 GPU. Changed to use x^2/a^2 + y^2/b^2  - 1. 

Addresses issue 1290.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/15039016

git-svn-id: http://skia.googlecode.com/svn/trunk@9110 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-13 14:41:03 +00:00
robertphillips@google.com
63a3f6f5d9 Fix for Debug check failures in r9108
git-svn-id: http://skia.googlecode.com/svn/trunk@9109 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-13 14:40:34 +00:00
robertphillips@google.com
1d2f631594 add bench for blurred rectori case
https://codereview.chromium.org/14690014/



git-svn-id: http://skia.googlecode.com/svn/trunk@9108 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-13 14:10:31 +00:00
commit-bot@chromium.org
c7a20e4093 API modifications needed to upstream Android font changes.
Committed: http://code.google.com/p/skia/source/detail?r=9083

R=reed@google.com

Author: djsollen@google.com

Review URL: https://chromiumcodereview.appspot.com/14761003

git-svn-id: http://skia.googlecode.com/svn/trunk@9107 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-13 14:09:13 +00:00
robertphillips@google.com
28ac96e40d Partial revert of r9087
https://codereview.chromium.org/14858035/



git-svn-id: http://skia.googlecode.com/svn/trunk@9106 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-13 13:38:35 +00:00
commit-bot@chromium.org
3f4ea26ff5 Check for NULL texture in GrAutoScratchTexture::detach()
R=sugoi@chromium.org, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/14683009

git-svn-id: http://skia.googlecode.com/svn/trunk@9104 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-11 13:21:43 +00:00
skia.committer@gmail.com
66a4a4cd9a Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9103 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-11 07:01:34 +00:00
bsalomon@google.com
76202b8dc3 Don't call purgeCache() from within GrResource memebers.
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14864020

git-svn-id: http://skia.googlecode.com/svn/trunk@9102 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 19:08:22 +00:00
vandebo@chromium.org
1a47523179 [PDF] Only output the Dests dictionary if it isn't epmpty
R=edisonn@google.com

Review URL: https://codereview.chromium.org/15028012

git-svn-id: http://skia.googlecode.com/svn/trunk@9100 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 18:29:43 +00:00
robertphillips@google.com
9e9dfa3a67 Fix memory leak in SkTypeface.cpp
https://codereview.chromium.org/14617019/



git-svn-id: http://skia.googlecode.com/svn/trunk@9099 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 17:22:48 +00:00
bsalomon@google.com
94b284d719 Remove GrPathCmd
R=reed@google.com

Review URL: https://codereview.chromium.org/15068008

git-svn-id: http://skia.googlecode.com/svn/trunk@9097 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 17:14:06 +00:00
caryclark@google.com
512c9b65fc add wildcard test name matching to gm and bench.
This adds the same set of options in unit tests, i.e:

--match [~][^]match[$] [~][^]match[$] ...
~ causes a matching test to always be skipped
^ requires the start of the test to match
$ requires the end of the test to match
^ and $ requires an exact match

If a test does not match any list entry,
it is skipped unless some list entry starts with ~
Review URL: https://codereview.chromium.org/14746017

git-svn-id: http://skia.googlecode.com/svn/trunk@9096 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 15:16:13 +00:00
robertphillips@google.com
4d98b740cd Fix memory leak in filter tool
https://codereview.chromium.org/15029008/
(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9094 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 14:51:54 +00:00
junov@chromium.org
0ce0df7d24 Remove duplicated code in SkPictureRecord::drawRRect
Review URL: https://codereview.chromium.org/15057005

git-svn-id: http://skia.googlecode.com/svn/trunk@9093 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 14:39:26 +00:00
bsalomon@google.com
c978478514 Make gms use getTopDevice() rather than getDevice().
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14885012

git-svn-id: http://skia.googlecode.com/svn/trunk@9091 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 14:12:08 +00:00
robertphillips@google.com
91b7116a10 Further defer devRect computation in gpu rect drawing
https://codereview.chromium.org/14798007/



git-svn-id: http://skia.googlecode.com/svn/trunk@9090 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 14:09:54 +00:00
robertphillips@google.com
114eb9e699 Update shader rect drawing path for r9087 (removal of isIRect "opt")
https://codereview.chromium.org/14972013/

(SkipBuildbotRuns)



git-svn-id: http://skia.googlecode.com/svn/trunk@9089 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 13:16:13 +00:00
robertphillips@google.com
18136d1cf2 Remove isIRect "optimization" & defer computation of device Rect in AA rect rendering
https://chromiumcodereview.appspot.com/14890021/



git-svn-id: http://skia.googlecode.com/svn/trunk@9087 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 11:05:58 +00:00
skia.committer@gmail.com
0f20a3fc59 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9086 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-10 07:01:04 +00:00
robertphillips@google.com
e55491d846 Reverting 9083 & 9084 due to Android failures
git-svn-id: http://skia.googlecode.com/svn/trunk@9085 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 22:47:33 +00:00
reed@google.com
3a886ccf2a fix warning/error of uninitialized len
BUG=

Review URL: https://codereview.chromium.org/15001019

git-svn-id: http://skia.googlecode.com/svn/trunk@9084 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 22:02:35 +00:00
commit-bot@chromium.org
14451703f1 API modifications needed to upstream Android font changes.
R=reed@google.com

Author: djsollen@google.com

Review URL: https://chromiumcodereview.appspot.com/14761003

git-svn-id: http://skia.googlecode.com/svn/trunk@9083 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 20:54:20 +00:00
epoger@google.com
4a8084ced3 Revert r9081
Review URL: https://codereview.chromium.org/14773022

git-svn-id: http://skia.googlecode.com/svn/trunk@9082 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 20:01:26 +00:00
epoger@google.com
3a8d3d06ea add SkString::append(const char c)
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/14813013

git-svn-id: http://skia.googlecode.com/svn/trunk@9081 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 19:37:41 +00:00
robertphillips@google.com
6d58ad3a82 Fix for compiler warnings/errors in r9078
git-svn-id: http://skia.googlecode.com/svn/trunk@9079 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 19:08:57 +00:00
robertphillips@google.com
6670ab9e63 Added game-like bench marks
https://codereview.chromium.org/14772019/



git-svn-id: http://skia.googlecode.com/svn/trunk@9078 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 19:03:48 +00:00
epoger@google.com
ee2c3b9fb3 GM self-test: add --writePath and --mismatchPath , but in a way that works cross-platform
R=scroggo@google.com

Review URL: https://codereview.chromium.org/15085007

git-svn-id: http://skia.googlecode.com/svn/trunk@9077 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 18:09:06 +00:00
scroggo@google.com
614f9e3a54 Fix some warnings in SkPath.
R=caryclark@google.com

Review URL: https://codereview.chromium.org/14969003

git-svn-id: http://skia.googlecode.com/svn/trunk@9076 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 18:05:32 +00:00
commit-bot@chromium.org
a9f142e9f0 remove unneeded reference to SkTScopedPtr
R=djsollen@google.com, scroggo@google.com

Author: reed@google.com

Review URL: https://chromiumcodereview.appspot.com/14057013

git-svn-id: http://skia.googlecode.com/svn/trunk@9075 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 16:15:20 +00:00
commit-bot@chromium.org
8d47ddc19a Make GrGLShaderBuilder check whether GrEffect advertised that it would require the dst color or fragment position
R=senorblanco@chromium.org, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/14998007

git-svn-id: http://skia.googlecode.com/svn/trunk@9074 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 14:55:46 +00:00
bsalomon@google.com
504976ef6f Move loops that chain together effects into GrGLShaderBuilder from GrGLProgram.
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14925010

git-svn-id: http://skia.googlecode.com/svn/trunk@9073 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 13:45:02 +00:00
skia.committer@gmail.com
be21431872 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9072 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 07:02:04 +00:00
reed@google.com
3eff3592ac need to clamp all of the cubic points after a chop, in case our finite precision
meant we didn't compute values below the chop-point.

crbug:234190

R=caryclark@google.com

Review URL: https://codereview.chromium.org/14607012

git-svn-id: http://skia.googlecode.com/svn/trunk@9071 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 21:08:21 +00:00
scroggo@google.com
6843bdb706 Write/compare against expectations in skimage tool.
skimage:
Add two new modes: one to write expectations to a json file, and
another to compare results against expectations.
Use SkPATH_SEPARATOR instead of '/'.

gm_expectations:
Split into a static library so it can be used by skimage.
Make functions non static and move function definitions into source
file.
Capitalize static member functions to follow the coding style
guidelines.

BUG=https://code.google.com/p/skia/issues/detail?id=1241
R=epoger@google.com

Review URL: https://codereview.chromium.org/14670021

git-svn-id: http://skia.googlecode.com/svn/trunk@9069 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 19:14:23 +00:00
reed@google.com
94b366a3e8 negate FontBox.bottom, since it is negative, but we want it positive (doh)
git-svn-id: http://skia.googlecode.com/svn/trunk@9067 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 17:46:48 +00:00
epoger@google.com
2a9a8bec45 fix BitmapHasher unittest failure as of r9064
git-svn-id: http://skia.googlecode.com/svn/trunk@9066 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 16:24:05 +00:00
epoger@google.com
0a117be391 Re-land r9059 with empty cityhash.gyp, instead of deleted cityhash.gyp
R=rmistry@google.com

Review URL: https://codereview.chromium.org/15060008/



git-svn-id: http://skia.googlecode.com/svn/trunk@9064 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 16:04:02 +00:00
junov@chromium.org
d575eed354 Fix behavior of SkPicture::kUsePathBoundsForClip_RecordingFlag to handle inverse fills and all clip ops correctly.
BUG=crbug.com/229011
TEST=Picture unit test + complexclip* GMs

Review URL: https://codereview.chromium.org/14820021

git-svn-id: http://skia.googlecode.com/svn/trunk@9063 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 15:39:13 +00:00
reed@google.com
8b7463db00 remove dead code (SkBitmapSampler)
git-svn-id: http://skia.googlecode.com/svn/trunk@9062 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 15:32:41 +00:00
jvanverth@google.com
e3647415d7 Revert r9055.
Unreviewed.


git-svn-id: http://skia.googlecode.com/svn/trunk@9061 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 15:31:43 +00:00
epoger@google.com
e8d08a0fc2 Roll out r9059 to unbreak bots
git-svn-id: http://skia.googlecode.com/svn/trunk@9060 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 15:22:36 +00:00
epoger@google.com
aaf7343e16 Remove third-party cityhash, unused since r8992
R=djsollen@google.com

Review URL: https://codereview.chromium.org/15027013

git-svn-id: http://skia.googlecode.com/svn/trunk@9059 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:49:50 +00:00
reed@google.com
0a01f5a2c4 we only need one fontmetrics, since the paint (and fontcache) now know explicitly
if they are horizontal or vertical.

Review URL: https://codereview.chromium.org/14940018

git-svn-id: http://skia.googlecode.com/svn/trunk@9058 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:19:08 +00:00
reed@google.com
60af92cb6d Use more fields from OutlineFontMEtrics: linegap, bbox.
Up our canonical size to 2048 to reduce precision loss.

R=bungeman@google.com

Review URL: https://codereview.chromium.org/14759021

git-svn-id: http://skia.googlecode.com/svn/trunk@9057 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:11:28 +00:00
epoger@google.com
fed9db6930 GM self-test: add option to exercise --writePath and --mismatchPath, but not on bots
(individual developers can set WRITE_IMAGE_FILES=1 for local testing)

R=rmistry@google.com

Review URL: https://codereview.chromium.org/14863009

git-svn-id: http://skia.googlecode.com/svn/trunk@9056 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:10:28 +00:00
commit-bot@chromium.org
74d50a4d12 Better method for rendering AA ellipses.
This uses the standard ellipse equation as a signed distance 
test, and adjusts the result by the length of the gradient 
at that point to get a better approximation of the distance 
to the ellipse. It replaces the standard ellipse and 
roundrect shader renderers.

Also adds a check to see if the curvature extrema of the 
stroke are less than the curvature extrema of the ellipse (i.e. 
the radius of curvature is larger). In this case, it's no 
longer an ellipse and we can't use this renderer.

Committed: http://code.google.com/p/skia/source/detail?r=9016

R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/14938004

git-svn-id: http://skia.googlecode.com/svn/trunk@9055 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 13:59:36 +00:00
reed@google.com
d028056712 add SK_API
git-svn-id: http://skia.googlecode.com/svn/trunk@9054 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 13:25:02 +00:00
bsalomon@google.com
1b8014ce82 Comment out invalid assert.
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/15021008

git-svn-id: http://skia.googlecode.com/svn/trunk@9053 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 12:49:49 +00:00
rmistry@google.com
32ecf40696 Autogen has been reset. Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@9052 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 11:18:34 +00:00