915 Commits

Author	SHA1	Message	Date
reed	7c4cdd2c5b	Revert of allow pictures to have a full bounds (patchset #3 id:40001 of https://codereview.chromium.org/736583004/) ... Reason for revert: needed to update legacy width() helpers Original issue's description: > allow pictures to have a full bounds > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7e76bff26e7c74902841ca4f607eb0b24a833a4a TBR=fmalita@google.com,mtklein@google.com,robertphillips@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/722043005	2014-11-19 07:17:17 -08:00
reed	7e76bff26e	allow pictures to have a full bounds ... BUG=skia: Review URL: https://codereview.chromium.org/736583004	2014-11-19 06:59:41 -08:00
reed	6be2aa9a25	wip for drawables ... Idea: 1. in its mutable recording state, keep a table of drawables on the side, and store an index in the record list. 2. In "immediate-mode" draw, just call the clients drawable directly (need access to our private list to turn the stored index into a proc) 3. when we "snap", we replace the list of drawables with a list of (sub) pictures, and then during playback of the snapped picture, we invoke a private drawable which just calls "drawPicture" on the index'd subpicture. Review URL: https://codereview.chromium.org/727363003	2014-11-18 11:08:05 -08:00
reed	6a070dc06a	experimental ... BUG=skia: Review URL: https://codereview.chromium.org/716793004	2014-11-11 19:36:10 -08:00
reed	7a72c6702d	add patch and clicktracking to lua ... BUG=skia: Review URL: https://codereview.chromium.org/712613002	2014-11-07 10:23:55 -08:00
reed	789e327ad9	tell our grcontext to abandon its backend ... BUG=skia: Review URL: https://codereview.chromium.org/692803003	2014-10-30 11:29:08 -07:00
reed	89889b6939	MultiPictureDraw is taskgroup aware. ... SampleApp is multipicturedraw aware. BUG=skia: Review URL: https://codereview.chromium.org/684923002	2014-10-29 12:36:45 -07:00
sugoi	f11c574882	Adding color cube to fuzzer ... BUG=skia: Review URL: https://codereview.chromium.org/677713003	2014-10-27 08:03:57 -07:00
sugoi	234f036b3e	Adding an option to render only the shadow in SkDropShadowImageFilter ... This is basically how blink uses the filter. Currently, I can't use it for "ShadowOnly" mode with the filter at all, but instead of copying the code and risking to have the codepaths diverge, I'm simply going to add the option here. BUG=skia: Review URL: https://codereview.chromium.org/646213004	2014-10-23 13:59:52 -07:00
reed	f0b1710bdb	fix some bit-rot in the ios port of sampleapp ... BUG=skia: Review URL: https://codereview.chromium.org/637263004	2014-10-22 13:06:00 -07:00
scroggo	2a1208017d	Qualify the return value of SkImageDecoder::decode ... Add a new enum to differentiate between a complete decode and a partial decode (with the third value being failure). Return this value from SkImageDecoder::onDecode (in all subclasses, plus SkImageDecoder_empty) and ::decode. For convenience, if the enum is treated as a boolean, success and partial success are both considered true. Note that the static helper functions (DecodeFile etc) still return true and false (for one thing, this allows us to continue to use SkImageDecoder::DecodeMemory as an SkPicture::InstallPixelRefProc in SkPicture::CreateFromStream). Also correctly report failure in SkASTCImageDecoder::onDecode when SkTextureCompressor::DecompressBufferFromFormat fails. BUG=skia:3037 BUG:b/17419670 Review URL: https://codereview.chromium.org/647023006	2014-10-22 12:07:00 -07:00
reed	9fbc3f31c0	add gradients and drawPaint to lua ... BUG=skia: TBR= Review URL: https://codereview.chromium.org/667803004	2014-10-21 07:12:58 -07:00
reed	bdc49ae0d4	create and modify matrices in lua ... BUG=skia: Review URL: https://codereview.chromium.org/651823004	2014-10-14 09:34:52 -07:00
reed	0d76b95ae0	add fade_slide transition to lua slides ... TBR= BUG=skia: Review URL: https://codereview.chromium.org/646613004	2014-10-12 19:05:52 -07:00
reed	09a1d6751c	add key handlers to lua ... BUG=skia: TBR= Review URL: https://codereview.chromium.org/652473002	2014-10-11 13:13:11 -07:00
reed	18ea777638	allow for lua click handlers ... BUG=skia: TBR= Review URL: https://codereview.chromium.org/649013002	2014-10-11 11:28:07 -07:00
reed	09445a4f7f	move test for lua into separate resource file ... BUG=skia: TBR= Review URL: https://codereview.chromium.org/645283002	2014-10-10 20:31:24 -07:00
reed	ba5fb932a1	add drawImageRect to lua, update sample ... BUG=skia: TBR= Review URL: https://codereview.chromium.org/642353005	2014-10-10 15:28:19 -07:00
caryclark	feff7d2d77	Draw more accurate thick-stroked Beziers (disabled) ... Draw thick-stroked Beziers by computing the outset quadratic, measuring the error, and subdividing until the error is within a predetermined limit. To try this CL out, change src/core/SkStroke.h:18 to #define QUAD_STROKE_APPROXIMATION 1 or from the command line: CPPFLAGS="-D QUAD_STROKE_APPROXIMATION=1" ./gyp_skia Here's what's in this CL: bench/BezierBench.cpp : a microbench for examining where the time is going gm/beziers.cpp : random Beziers with various thicknesses gm/smallarc.cpp : a distillation of bug skia:2769 samplecode/SampleRotateCircles.cpp : controls added for error, limit, width src/core/SkStroke.cpp : the new stroke implementation (disabled) tests/StrokerTest.cpp : a stroke torture test that checks normal and extreme values The new stroke algorithm has a tweakable parameter: stroker.setError(1); (SkStrokeRec.cpp:112) The stroke error is the allowable gap between the midpoint of the stroke quadratic and the center Bezier. As the projection from the quadratic approaches the endpoints, the error is decreased proportionally so that it is always inside the quadratic curve. An overview of how this works: - For a given T range of a Bezier, compute the perpendiculars and find the points outset and inset for some radius. - Construct tangents for the quadratic stroke. - If the tangent don't intersect between them (may happen with cubics), subdivide. - If the quadratic stroke end points are close (again, may happen with cubics), draw a line between them. - Compute the quadratic formed by the intersecting tangents. - If the midpoint of the quadratic is close to the midpoint of the Bezier perpendicular, return the quadratic. - If the end of the stroke at the Bezier midpoint doesn't intersect the quad's bounds, subdivide. - Find where the Bezier midpoint ray intersects the quadratic. - If the intersection is too close to the quad's endpoints, subdivide. - If the error is large proportional to the intersection's distance to the quad's endpoints, subdivide. BUG=skia:723,skia:2769 Review URL: https://codereview.chromium.org/558163005	2014-10-09 05:36:04 -07:00
reed	ddb5eca198	use SkDocument to capture pdfs from SampleApp 'e' ... BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/634293004	2014-10-08 11:10:51 -07:00
bsalomon	f80bfedc42	GrContext::copyTexture->GrContext::copySurface. ... Add a flush writes pixel ops flag. Add an explicit flush writes for GrSurface. BUG=skia:2977 Committed: https://skia.googlesource.com/skia/+/cf99b00980b6c9c557e71abf1a7c9f9b21217262 Review URL: https://codereview.chromium.org/622663002	2014-10-07 05:56:02 -07:00
reed	59c01e0884	extra call to flush until brian can figure it out ... BUG=skia: TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/633643004	2014-10-07 04:04:46 -07:00
reed	4302ae91b0	add surfaceprops to SkWindow, and 'D' to toggle distancefieldfonts ... BUG=skia: Review URL: https://codereview.chromium.org/631943002	2014-10-06 12:29:56 -07:00
reed	9e96aa07db	remove unused TextBufferDirection enum ... BUG=skia: Review URL: https://codereview.chromium.org/621403002	2014-10-03 12:44:37 -07:00
bsalomon	85d3427d49	Revert of GrContext::copyTexture->GrContext::copySurface. Add a flush writes pixel ops flag. (patchset #3 id:40001 of https://codereview.chromium.org/622663002/) ... Reason for revert: Breaking GMs on some bots Original issue's description: > GrContext::copyTexture->GrContext::copySurface. > > Add a flush writes pixel ops flag. > > Add an explicit flush writes for GrSurface. > > BUG=skia:2977 > > Committed: https://skia.googlesource.com/skia/+/cf99b00980b6c9c557e71abf1a7c9f9b21217262 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2977 Review URL: https://codereview.chromium.org/621073002	2014-10-02 11:23:04 -07:00
bsalomon	cf99b00980	GrContext::copyTexture->GrContext::copySurface. ... Add a flush writes pixel ops flag. Add an explicit flush writes for GrSurface. BUG=skia:2977 Review URL: https://codereview.chromium.org/622663002	2014-10-02 10:42:24 -07:00
reed	c5e15a1afa	remove alphatype from colortable ... the owning bitmap is (already) responsible for knowing the alphatype BUG=skia: R=djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/611093002	2014-09-29 12:10:27 -07:00
piotaixr	b5fae93d72	SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas ... BUG=skia:2947 Committed: https://skia.googlesource.com/skia/+/432789972c1e1f8a66165c75a250dba1853efa08 R=junov@chromium.org, reed@google.com, bsalomon@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/583453002	2014-09-24 13:03:30 -07:00
borenet	2456b7681a	Revert of SkCanvas::drawImage is the new way for drawing an SkImage to a Canvas (patchset #9 id:160001 of https://codereview.chromium.org/583453002/) ... Reason for revert: Broke ChromiumOS Ozone builder: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/4087/steps/compile/logs/stdio Reverting to unblock DEPS roll. Original issue's description: > SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas > > BUG=skia:2947 > > Committed: https://skia.googlesource.com/skia/+/432789972c1e1f8a66165c75a250dba1853efa08 R=junov@chromium.org, reed@google.com, bsalomon@google.com, piotaixr@chromium.org TBR=bsalomon@google.com, junov@chromium.org, piotaixr@chromium.org, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2947 Author: borenet@google.com Review URL: https://codereview.chromium.org/598133002	2014-09-24 11:03:35 -07:00
piotaixr	432789972c	SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas ... BUG=skia:2947 R=junov@chromium.org, reed@google.com, bsalomon@google.com Author: piotaixr@chromium.org Review URL: https://codereview.chromium.org/583453002	2014-09-23 14:10:50 -07:00
reed	5d9ab2816f	enable conservative clips for gpudevice ... TBR=bsalomon Author: reed@google.com Review URL: https://codereview.chromium.org/587793003	2014-09-19 13:04:17 -07:00
reed	0397e9f341	use surface in SkView/SampleApp ... BUG=skia: R=bsalomon@google.com, robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/580073003	2014-09-18 11:29:01 -07:00
bsalomon	49f085dddf	"NULL !=" = NULL ... R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/544233002	2014-09-05 13:34:00 -07:00
robertphillips	c5ba71d2e5	Change SkPicture::draw to playback ... R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/540963002	2014-09-04 08:42:50 -07:00
reed	e5ea500d47	Hide fields in SkImageInfo ... R=rmistry@google.com TBR=bsalomon Author: reed@google.com Review URL: https://codereview.chromium.org/536003002	2014-09-03 11:54:58 -07:00
reed	848250415e	make allocPixels throw on failure ... BUG=skia: R=mtklein@google.com, fmalita@google.com, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/510423005	2014-09-02 12:50:45 -07:00
robertphillips	a8d7f0b13c	Try out scalar picture sizes ... This paves the way for removing the 'fTile' parameter from SkPictureShader (although that should be a different CL). If we like this we could also move to providing an entire cull SkRect. R=reed@google.com, mtklein@google.com, fmalita@google.com, fmalita@chromium.org Author: robertphillips@google.com Review URL: https://codereview.chromium.org/513983002	2014-08-29 08:03:56 -07:00
bsalomon	23b406cc04	Make SkGpuDevice constructors private. ... R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/517033002	2014-08-28 14:06:42 -07:00
mtklein	2a65a238b0	Remove SkQuadTree. ... We're not testing it to the same degree we do RTree and TileGrid. Any changes we'll make to BBH APIs become 33% easier without it. If find we want it again, we can always resurrect it. BUG=skia:1021,skia:2834 R=robertphillips@google.com, mtklein@google.com TBR=reed Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/500373005	2014-08-26 14:07:04 -07:00
reed	99ae881a7f	remove (unused) scale parameter from measureText ... BUG=skia: R=bungeman@google.com, djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/510433002	2014-08-26 11:30:01 -07:00
reed	9fa60daad4	Simplify flattening to just write enough to call the factory/public-constructor for the class. We want to *not* rely on private constructors, and not rely on calling through the inheritance hierarchy for either flattening or unflattening(CreateProc). ... Refactoring pattern: 1. guard the existing constructor(readbuffer) with the legacy build-flag 2. If you are a instancable subclass, implement CreateProc(readbuffer) to create a new instances from the buffer params (or return NULL). If you're a shader subclass 1. You must read/write the local matrix if your class accepts that in its factory/constructor, else ignore it. R=robertphillips@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org, sugoi@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/395603002	2014-08-21 07:59:51 -07:00
humper	d1d3baeb98	add an animated test to verify that high-quality identity scaling doesn't change the image ... BUG=skia: R=reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/454913002	2014-08-08 12:11:33 -07:00
reed	cdf2db90d9	parameterize tesselation params ... TBR= NOTREECHECKS=True Author: reed@google.com Review URL: https://codereview.chromium.org/446913002	2014-08-06 09:54:19 -07:00
reed	147476da9e	fix hittest in Patch sample ... TBR= BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/441373002	2014-08-06 07:00:27 -07:00
Cary Clark	992c7b03ef	Add standard fonts to all GMs. ... Allow GM results to be compared across machines and platforms by standardizing the fonts used by all tests. This adds runtime flags to DM to use either the system font context (the default), the fonts in the resources directory ( --resourceFonts ) or a set of canonical paths generated from the fonts ( --portableFonts ). This CL should leave the current DM results unchanged by default. If the portable font data or resource font is missing when DM is run, it falls back to using the system font context. The create_test_font tool generates the paths and metrics read by DM with the --portableFonts flag set, and generates the font substitution tables read by DM with the --resourceFonts flag set. If DM is run in SkDebug mode with the --reportUsedChars flag set, it generates the corresponding data compiled into the create_test_font tool. All GM tests set their typeface information by calling either sk_tool_utils::set_portable_typeface or sk_tool_utils::portable_typeface . (The former takes the paint, the latter returns a SkTypeface.) These calls can be removed in the future when the Font Manager can be superceded. BUG=skia:2687 R=mtklein@google.com Review URL: https://codereview.chromium.org/407183003	2014-07-31 08:58:44 -04:00
tfarina	a8e2e1504b	Cleanup: Rename SkOSPath functions. ... Mostly for brevity and matches better with Python: Python | Old C++ | New C++ os.path.join | SkOSPath::SkPathJoin | SkOSPath::Join os.path.basename | SkOSPath::SkBasename | SkOSPath::Basename BUG=None TEST=make all R=mtklein@google.com, bsalomon@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/428443002	2014-07-28 19:26:58 -07:00
senorblanco	bc9845bb60	Remove the single-sigma version of SkDropShadowImageFilter::Create(). ... It's no longer used in Chrome. BUG=skia: R=bsalomon@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/407203002	2014-07-22 12:49:25 -07:00
caryclark	17f0b6df72	share dm and command flags ... Share command flags between dm and unit tests. Also, allow dm's core to be included by itself and iOSShell. Command line flags that are the same (or nearly the same) in DM and in skia_tests have been moved to common_flags. Authors, please check to see that the shared common flag is correct for the tool. For iOS, the 'tool_main' entry point has a wrapper to allow multiple tools to be statically linked in the iOSShell. Since SkCommandLineFlags::Parse can only be called once, these calls are disabled in the IOS build. Since the iOS app directory is dynamically assigned a name, use '@' to select it. (This is the same convention chosen by the Mobile Harness iOS file system utilities.) Move the heart of dm.gyp into dm.gypi so that it can be included by itself and iOSShell.gyp. Add tools/flags/SkCommonFlags.* to define and declare common command line flags. Add support for dm to iOSShell. BUG=skia: R=scroggo@google.com, mtklein@google.com, jvanverth@google.com, bsalomon@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/389653004	2014-07-22 10:15:35 -07:00
caryclark	f568f6a557	git sample app working on iOS ... R=jvanverth@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/405653002	2014-07-18 10:58:56 -07:00
reed	285d375508	remove dead code from sample ... TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/393063002	2014-07-15 19:56:55 -07:00
robertphillips	dd528967fc	Remove SkPicture copy constructor ... Given where we're heading with SkPicture why would you need to make a copy? R=reed@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/381133002	2014-07-13 07:55:53 -07:00
Ben Wagner	b17c764f85	Handle NULL typeface in SampleApp. ... It is possible that SampleApp will use the NULL typeface as the default. This is valid and should be handled properly on shutdown.	2014-07-10 16:21:49 -04:00
tfarina	c846f4a96b	Cleanup usage of GetResourcePath() after commit bcbc1788b4. ... There was a clean up opportunity left over after https://skia.googlesource.com/skia/+/bcbc1788b478b1e54079318ad073e8490aa66fae, that could make use of the default parameter of GetResourcePath() function to make some call sites cleaner. We decided to make it in a separate CL to make reviewer's and author's life easier, so we could catch errors and/or mistakes easily. BUG=None TEST=make all && out/Debug/dm && out/Debug/SampleApp R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/351133003	2014-07-01 12:35:49 -07:00
reed	52d9ac6c92	stop calling SkCanvas::getDevice ... BUG=skia: R=bsalomon@google.com, robertphillips@google.com, junov@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/355193006	2014-06-30 09:05:34 -07:00
reed	8c0c7b0bcd	remove unnecessary bitmapdevice references ... TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/354143004	2014-06-27 05:49:54 -07:00
senorblanco	7bf1068473	Remove SkBicubicImageFilter, and all related tests. ... Now that we have SkResizeImageFilter, and the bicubic resizing is part of skia proper, there's no need for a specialized image filter. BUG=skia: R=bsalomon@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/357793002	2014-06-25 14:39:06 -07:00
caryclark	5fb6bd4b7e	use platform-independent font for gm ... Create a custom typeface and scaler to render simple paths the same on all platforms. GM tests are modified to explicitly select the custom typeface. R=reed@google.com, mtklein@google.com, bungeman@google.com TBR=reed Author: caryclark@google.com Review URL: https://codereview.chromium.org/348323003	2014-06-23 11:25:00 -07:00
mtklein	fd117d8829	Port SampleApp to SkCommandLineFlags. ... BUG=skia: R=bsalomon@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/344873004	2014-06-19 14:18:56 -07:00
tfarina	bcbc1788b4	Refactor how we handle resources path in Tests. ... This idea emerged while doing https://codereview.chromium.org/321723002/ (commit 880914c35c). BUG=None TEST=make tests && out/Debug/tests R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/346453002	2014-06-18 14:32:49 -07:00
reed	c3b3266b7d	hide SkBitmap::Config entirely (behind a flag) ... patch from issue 339463002 TBR= I think the NoGPU failure is unrelated, so ignoring NOTRY=True Author: reed@google.com Review URL: https://codereview.chromium.org/340533002	2014-06-17 08:38:31 -07:00
reed	bfefc7c95f	hide Config in SkImageDecoder -- use SkColorType instead ... patch from issue 334613003 TBR=scroggo Author: reed@chromium.org Review URL: https://codereview.chromium.org/334793002	2014-06-12 17:40:00 -07:00
robertphillips	9b14f26d0f	Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) ... R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/313613004	2014-06-04 05:40:44 -07:00
reed	868074b50b	remove SkBounder -- unused and unloved ... BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/312553006	2014-06-03 10:54:00 -07:00
reed	73be51ee5e	remove unneeded inval ... TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/307993012	2014-06-02 14:41:24 -07:00
robertphillips	d537341e16	Move GrIPoint16 to SkIPoint16 (and remove GrPoint.h) ... R=bsalomon@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/309683002	2014-06-02 10:20:15 -07:00
robertphillips	901e96df69	Add Sample slide for Rectanizers ... R=jvanverth@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/303263005	2014-06-02 07:15:18 -07:00
senorblanco@chromium.org	97f5fc6519	Allow SkPictureImageFilter to be serialized when not run cross-process. ... Picture serialization is not yet hardened, but it turns out we do need serialization of SkPictureImageFilter for deferred SVG-on-SVG filters, since the SkPaints (and thus the SkImageFilters) are serialized by SkPictureRecord. However, deferred filters are always drawn in the same process, so we can safely serialize them in this case. We do this by turning the compile-time check for SK_ALLOW_PICTUREIMAGEFILTER_SERIALIZATION to a runtime check for isCrossProcess(). The image filter fuzzer sample was also modified to enable fuzzing of basic picture image filters (the code had rotted a bit, being behind an #ifdef that no one sets). BUG=375162 R=sugoi@google.com Review URL: https://codereview.chromium.org/311443003 git-svn-id: http://skia.googlecode.com/svn/trunk@15008 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-30 20:50:56 +00:00
commit-bot@chromium.org	9a558d495d	using real tiles when simulating tiling ... BUG=skia: R=mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/303403003 git-svn-id: http://skia.googlecode.com/svn/trunk@14993 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-30 15:06:24 +00:00
reed@google.com	687a26defa	fix int->scalar warnings ... git-svn-id: http://skia.googlecode.com/svn/trunk@14990 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-30 13:45:36 +00:00
commit-bot@chromium.org	1803f4eb34	new animated sample to show subpixel translate bug with high quality scaling ... BUG=1445 R=reed@google.com, robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/303123003 git-svn-id: http://skia.googlecode.com/svn/trunk@14981 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-29 22:01:08 +00:00
commit-bot@chromium.org	00f8d6c75d	Revert "Revert of add colortable support to imagegenerator (https://codereview.chromium.org/304443003/)" ... Fix is to add colortable param to installPixels() This reverts commit 924205aaf2. BUG=skia: R=scroggo@google.com, reed@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/300263005 git-svn-id: http://skia.googlecode.com/svn/trunk@14958 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-29 15:57:20 +00:00
commit-bot@chromium.org	b859fe6530	Fixing windows warnings ... BUG=skia: R=bsalomon@google.com, epoger@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/298093006 git-svn-id: http://skia.googlecode.com/svn/trunk@14899 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-27 17:03:25 +00:00
commit-bot@chromium.org	2d970b5128	hide discardable factory from public imagegenerator api ... BUG=skia: R=halcanary@google.com, scroggo@google.com, djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/295243006 git-svn-id: http://skia.googlecode.com/svn/trunk@14889 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-27 14:14:22 +00:00
commit-bot@chromium.org	067fe48266	Adding new filters to fuzzer ... New image filters were added since the last time I worked on the fuzzer, so I added them to the fuzzer. Same changes will be made to the clusterfuzz fuzzer. BUG=skia: R=bsalomon@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/300153002 git-svn-id: http://skia.googlecode.com/svn/trunk@14887 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-27 13:52:51 +00:00
commit-bot@chromium.org	83f23d87f1	Remove unused (by clients) SkUnitMapper ... This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98. TBR=scroggo Author: reed@google.com Review URL: https://codereview.chromium.org/288313009 git-svn-id: http://skia.googlecode.com/svn/trunk@14842 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-22 12:27:41 +00:00
commit-bot@chromium.org	3339ac54a5	Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (https://codereview.chromium.org/288343009/) ... Reason for revert: required blink change failed to land Original issue's description: > Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) > > This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f. > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14830 R=scroggo@google.com, reed@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@chromium.org Review URL: https://codereview.chromium.org/296823008 git-svn-id: http://skia.googlecode.com/svn/trunk@14838 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-22 02:55:59 +00:00
commit-bot@chromium.org	4b8f802255	Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) ... This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f. BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/288343009 git-svn-id: http://skia.googlecode.com/svn/trunk@14830 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-21 19:56:46 +00:00
commit-bot@chromium.org	628ed0b220	Add Dashing gpu effect for simple dashed lines ... BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/274673004 git-svn-id: http://skia.googlecode.com/svn/trunk@14775 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-19 14:32:49 +00:00
commit-bot@chromium.org	e2b193ca5c	Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) ... Reason for revert: does not address all legacy callsites in chrome. e.g. [13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’ [13:45:32.091919] gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL)); Original issue's description: > remove unused (by clients) SkUnitMapper > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14761 R=robertphillips@google.com, scroggo@google.com, george@mozilla.com TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/287063009 git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-16 13:49:08 +00:00
commit-bot@chromium.org	ee0cac336c	remove unused (by clients) SkUnitMapper ... BUG=skia: R=robertphillips@google.com, scroggo@google.com, george@mozilla.com Author: reed@google.com Review URL: https://codereview.chromium.org/283273002 git-svn-id: http://skia.googlecode.com/svn/trunk@14761 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-16 13:35:01 +00:00
commit-bot@chromium.org	5970f625e9	re-land hide get/setLocalMatrix ... This reverts commit b1d702a43b07934f5b001b1b09db2c57ede909a1. TBR=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/279903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14702 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-12 20:42:21 +00:00
commit-bot@chromium.org	e003aecb30	remove unused Kernel33MaskFilter ... R=robertphillips@google.com TBR=robertphilips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/280233002 git-svn-id: http://skia.googlecode.com/svn/trunk@14691 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-12 13:35:55 +00:00
commit-bot@chromium.org	d12de02542	Revert of hide get/setLocalMatrix (https://codereview.chromium.org/279563002/) ... Reason for revert: broke gms Original issue's description: > hide get/setLocalMatrix > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14675 R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org TBR=dominikg@chromium.org, fmalita@chromium.org, fmalita@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/278903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14677 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-09 15:42:07 +00:00
commit-bot@chromium.org	5adad325c5	hide get/setLocalMatrix ... BUG=skia: R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/279563002 git-svn-id: http://skia.googlecode.com/svn/trunk@14675 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-09 15:19:48 +00:00
commit-bot@chromium.org	95c2003740	cleanup GrContext resource cache api ... R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/275563005 git-svn-id: http://skia.googlecode.com/svn/trunk@14669 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-09 14:29:32 +00:00
skia.committer@gmail.com	b2c82c99f8	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@14636 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-08 03:05:29 +00:00
commit-bot@chromium.org	8fae213590	add localmatrix-shader ... BUG=skia: R=scroggo@google.com, dominikg@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/272593002 git-svn-id: http://skia.googlecode.com/svn/trunk@14633 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-07 22:26:37 +00:00
reed@google.com	2e74f9d375	remove code behind SK_SUPPORT_LEGACY_PROCXFERMODE ... BUG=skia: R=scroggo@google.com Review URL: https://codereview.chromium.org/264923004 git-svn-id: http://skia.googlecode.com/svn/trunk@14504 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-01 15:56:52 +00:00
commit-bot@chromium.org	fb6fefed09	fix cycle_colortypes so we can test 565 ... TBR=bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/255133004 git-svn-id: http://skia.googlecode.com/svn/trunk@14437 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-29 16:25:36 +00:00
commit-bot@chromium.org	e396455d2d	move common blur types into central header ... BUG=skia: R=scroggo@google.com, djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/253833002 git-svn-id: http://skia.googlecode.com/svn/trunk@14411 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-28 16:25:35 +00:00
commit-bot@chromium.org	9c9005a347	Move SkShader::fLocalMatrix into SkShader constructor. ... As a first step towards removing SkShader::setLocalMatrix, which will make SkShader thread-safe, remove calls to setLocalMatrix that happen immediately after the shader is being created. Instead, pass the matrix into the constructor or factory method. BUG=skia:1976 R=scroggo@google.com, reed@google.com, skyostil@google.com, mtklein@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/245963010 git-svn-id: http://skia.googlecode.com/svn/trunk@14401 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-28 14:55:39 +00:00
robertphillips@google.com	770963f23f	Staging for cleanup of SkPicture-related headers ... https://codereview.chromium.org/243173002 git-svn-id: http://skia.googlecode.com/svn/trunk@14258 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-18 18:04:41 +00:00
commit-bot@chromium.org	091a594dbc	Reduce internal explicit SaveFlags usage. ... Most of these are either redundant/defaults or (hopefully) unnecessarily specific. R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/241453003 git-svn-id: http://skia.googlecode.com/svn/trunk@14253 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-18 14:19:31 +00:00
commit-bot@chromium.org	5fb2ce38b3	Staged removal of SkPicture-derived classes ... This CL removes the SkPicture-derived classes (with a flag to keeps clients working). In the process it also lightens the recording factory function so it is no longer ref counted). The only interesting bits are in SkPicture* and Sk*Picture.* R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/238273012 git-svn-id: http://skia.googlecode.com/svn/trunk@14251 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-17 23:35:06 +00:00
commit-bot@chromium.org	d393b17cf3	Retract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API ... This CL sets the stage for retracting the SkPicture::kOptimizeForClippedPlayback_RecordingFlag flag from the public API (more work needs to be done in Blink & Chrome). In the new world the only way to set this flag (and thus instantiate an SkPicture-derived class) is by passing a factory to the SkPictureRecorder class. This is to get all clients always using factories so that we can then change the factory call used (i.e., so the factory just creates a BBH) and do away with the SkPicture-derived classes. BUG=skia:2315 R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/239703006 git-svn-id: http://skia.googlecode.com/svn/trunk@14221 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-16 16:02:10 +00:00
commit-bot@chromium.org	0dd01ee5b5	Fix bug in SampleApp's Tiling View ... SampleApp was crashing when invoked as "SampleApp --slide Tiling" due to r14171 (split SkPictureRecorder out of SkPicture - https://codereview.chromium.org/214953003/) R=bungeman@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/239353006 git-svn-id: http://skia.googlecode.com/svn/trunk@14214 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-15 23:00:57 +00:00
commit-bot@chromium.org	73cb15351f	Make sure SkDrawLooper objects can only be allocated on the heap. ... Make constructors of SkLayerDrawLooper and SkBlurDrawLooper non-public. Remove addLayer* methods from SkLayerDrawLooper. SkLayerDrawLooper::Builder is used to create new objects. Provide factory method for creating SkBlurDrawLooper. BUG=2141 R=scroggo@google.com, reed@google.com, djsollen@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/232913003 git-svn-id: http://skia.googlecode.com/svn/trunk@14200 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-15 15:48:36 +00:00
skia.committer@gmail.com	5199701acb	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@14172 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-14 03:04:57 +00:00
robertphillips@google.com	84b18c7e3e	split SkPictureRecorder out of SkPicture ... https://codereview.chromium.org/214953003/ git-svn-id: http://skia.googlecode.com/svn/trunk@14171 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-13 19:09:42 +00:00
commit-bot@chromium.org	28fcae2ec7	Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/) ... Reason for revert: Want to reland the original CL. Original issue's description: > Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) > > Reason for revert: > breaking the Chrome deps roll. > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio > > Original issue's description: > > Rename kPMColor_SkColorType to kN32_SkColorType. > > > > The new name better represents what this flag means. > > > > BUG=skia:2384 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14117 > > TBR=reed@google.com,scroggo@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14144 R=reed@google.com, bensong@google.com TBR=bensong@google.com, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: scroggo@google.com Review URL: https://codereview.chromium.org/235523003 git-svn-id: http://skia.googlecode.com/svn/trunk@14156 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-11 17:15:40 +00:00
commit-bot@chromium.org	96edc24598	Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) ... Reason for revert: Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now. Original issue's description: > Rename kPMColor_SkColorType to kN32_SkColorType. > > The new name better represents what this flag means. > > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14117 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/234833003 git-svn-id: http://skia.googlecode.com/svn/trunk@14149 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-11 13:47:30 +00:00
commit-bot@chromium.org	d923288e50	Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/) ... Reason for revert: fixes on the chrome side are landing (brettw), keep fingers crossed. Original issue's description: > Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) > > Reason for revert: > breaking the Chrome deps roll. > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio > > Original issue's description: > > Rename kPMColor_SkColorType to kN32_SkColorType. > > > > The new name better represents what this flag means. > > > > BUG=skia:2384 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14117 > > TBR=reed@google.com,scroggo@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14144 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/233813004 git-svn-id: http://skia.googlecode.com/svn/trunk@14145 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-10 22:49:20 +00:00
commit-bot@chromium.org	757ebd20ef	Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) ... Reason for revert: breaking the Chrome deps roll. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio Original issue's description: > Rename kPMColor_SkColorType to kN32_SkColorType. > > The new name better represents what this flag means. > > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14117 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/234243002 git-svn-id: http://skia.googlecode.com/svn/trunk@14144 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-10 22:36:34 +00:00
commit-bot@chromium.org	149e9a107c	Rename kPMColor_SkColorType to kN32_SkColorType. ... The new name better represents what this flag means. BUG=skia:2384 R=reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/227433009 git-svn-id: http://skia.googlecode.com/svn/trunk@14117 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-09 20:45:29 +00:00
commit-bot@chromium.org	9fbbcca1c9	SkPerlinNoiseShader::CreateTubulenceNoise() is misspelled ... Add missing 'r'. BUG=skia:2329 R=bsalomon@google.com, hcm@google.com, sugoi@chromium.org Author: siglesias@igalia.com Review URL: https://codereview.chromium.org/207543008 git-svn-id: http://skia.googlecode.com/svn/trunk@14008 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-01 16:09:37 +00:00
commit-bot@chromium.org	0f10f7bf1f	Allow toString capability to be toggled independent of developer mode. ... This change is motivated by the desire to see the text information in the debugger when not in developer mode. It is structured so user's can disable it if the capability is not wanted. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/197763008 git-svn-id: http://skia.googlecode.com/svn/trunk@13795 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-13 18:02:17 +00:00
commit-bot@chromium.org	cac5fd597f	Factory methods for heap-allocated SkImageFilter objects. ... This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkImageFilter and its subclasses non-public and instead provides factory methods for creating these objects on the heap. We temporarily keep constructor of publicly visible classes public behind a flag. BUG=skia:2187 R=scroggo@google.com, mtklein@chromium.org, reed@google.com, senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com, sugoi@chromium.org, zork@chromium.org Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/182983003 git-svn-id: http://skia.googlecode.com/svn/trunk@13718 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-10 10:51:58 +00:00
reed@google.com	b144743834	remove dead code ... git-svn-id: http://skia.googlecode.com/svn/trunk@13711 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-07 19:44:59 +00:00
commit-bot@chromium.org	38aeb0fd7a	DM: also run benches once. ... Also: - make GrMemoryPoolBenches threadsafe - some tweaks to various DM code - rename GM::shortName() to getName() to match benches and tests On my desktop, (289 GMs, 617 benches) x 4 configs, 227 tests takes 46s in Debug, 14s in Release. (Still minutes faster than running tests && bench && gm.) GPU singlethreading is definitely the limiting factor again; going to reexamine whether that's helpful to thread it again. BUG=skia: R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/178473006 git-svn-id: http://skia.googlecode.com/svn/trunk@13603 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-26 23:01:57 +00:00
commit-bot@chromium.org	f792a1b207	Builder class for SkLayerRasterizer. ... Provide builder class to make SkLayerRasterizer immutable. We have to keep the addLayer() methods for now because they are used in Chrome. They will be removed once this changed has been rolled into Chrome. An added benefit of this is that this class can only be allocated on the heap. BUG=skia:2187 R=reed@google.com, scroggo@google.com, mtklein@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/176873004 git-svn-id: http://skia.googlecode.com/svn/trunk@13590 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-26 13:27:37 +00:00
commit-bot@chromium.org	8a2ad3cae7	add new copyTo version to SkBitmap, which takes SkColorType ... BUG=skia: R=scroggo@google.com, halcanary@google.com, bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/171723007 git-svn-id: http://skia.googlecode.com/svn/trunk@13553 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-23 03:59:35 +00:00
commit-bot@chromium.org	7c9d0f3104	Factory methods for heap-allocated SkMaskFilter objects. ... This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkMaskFilter and its subclasses non-public and instead provides factory methods for creating these objects on the heap. We temporarily keep constructor of publicly visible classes public behind a flag. BUG=skia:2187 R=scroggo@google.com, mtklein@google.com, reed@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/173633003 git-svn-id: http://skia.googlecode.com/svn/trunk@13527 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-21 10:13:32 +00:00
commit-bot@chromium.org	0a2bf90dcc	Factory methods for heap-allocated SkPathEffect and SkXfermode objects. ... This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkPathEffect, SkXfermode and their subclasses non-public and instead provides factory methods for creating these objects on the heap. We temporarily keep the constructors of the following classes public to not break Chrome/Blink: SkXfermode SkCornerPathEffect SkDashPathEffect BUG=skia:2187 R=scroggo@google.com, reed@google.com, mtklein@google.com, bungeman@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/166583002 git-svn-id: http://skia.googlecode.com/svn/trunk@13519 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-20 20:40:19 +00:00
commit-bot@chromium.org	dac522589e	replace SkBitmap::Config with SkColorType in gms ... add helper installMaskPixels() to SkBitmap BUG=skia: R=halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/169913003 git-svn-id: http://skia.googlecode.com/svn/trunk@13482 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-17 21:21:46 +00:00
commit-bot@chromium.org	a8c183125f	use SkColorType instead of SkBitmap::Config in samplecode ... BUG=skia: R=reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/169063002 git-svn-id: http://skia.googlecode.com/svn/trunk@13473 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-17 02:55:57 +00:00
commit-bot@chromium.org	e24ad23ae6	use SkColorType instead of SkBitmap::Config in views/effects ... R=scroggo@google.com, reed@google.com TBR=scroggo Author: reed@chromium.org Review URL: https://codereview.chromium.org/168843002 git-svn-id: http://skia.googlecode.com/svn/trunk@13469 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-16 22:03:38 +00:00
commit-bot@chromium.org	c3bd8af6d5	add peekPixels to SkCanvas and SkSurface ... fix reference to SkBaseDevice, which was only a problem in no-gpu build This reverts commit 4fa44a6bf73891b21917fb90d02beef9143bffa3. R=reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/163603003 git-svn-id: http://skia.googlecode.com/svn/trunk@13432 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-13 17:14:46 +00:00
commit-bot@chromium.org	bda591c739	Revert of add peekPixels to SkCanvas and SkSurface (https://codereview.chromium.org/161733002/) ... Reason for revert: compile issues with gm/xfermodes3 Original issue's description: > add peekPixels to SkCanvas and SkSurface > > clone of https://codereview.chromium.org/159723006/ > > Committed: https://code.google.com/p/skia/source/detail?r=13427 R=jvanverth@google.com NOTREECHECKS=true NOTRY=true Author: reed@chromium.org Review URL: https://codereview.chromium.org/163823002 git-svn-id: http://skia.googlecode.com/svn/trunk@13428 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-13 15:29:03 +00:00
mike@reedtribe.org	b2d93a9122	add peekPixels to SkCanvas and SkSurface ... clone of https://codereview.chromium.org/159723006/ Review URL: https://codereview.chromium.org/161733002 git-svn-id: http://skia.googlecode.com/svn/trunk@13427 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-13 15:11:11 +00:00
commit-bot@chromium.org	b21fac156d	Make GMs aware of what tool they're being run in. ... Add a saveLayer set of draws to convex_poly_clip and fix GPU bug where polygon clips don't account for the translation between clip and device space. BUG=skia:2051 R=robertphillips@google.com, reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/148283017 git-svn-id: http://skia.googlecode.com/svn/trunk@13371 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-07 21:13:11 +00:00
commit-bot@chromium.org	5e0995e4b3	Revert of Revert "Serialization of SkPictureImageFilter" (https://codereview.chromium.org/153583007/) ... Reason for revert: New SKPs with version20 are in Google Storage due to http://108.170.219.160:10117/builders/Housekeeper-Nightly-RecreateSKPs/builds/22 Original issue's description: > Revert "Serialization of SkPictureImageFilter" > > This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e. > > Revert "Sanitizing source files in Housekeeper-Nightly" > > This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77. > > TBR=robertphillips@google.com,sugoi@google.com > > Committed: https://code.google.com/p/skia/source/detail?r=13356 R=robertphillips@google.com, sugoi@google.com, fmalita@google.com, fmalita@chromium.org TBR=fmalita@chromium.org, fmalita@google.com, robertphillips@google.com, sugoi@google.com NOTREECHECKS=true NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/143163005 git-svn-id: http://skia.googlecode.com/svn/trunk@13357 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-07 12:20:04 +00:00
fmalita@google.com	7713c38dc0	Revert "Serialization of SkPictureImageFilter" ... This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e. Revert "Sanitizing source files in Housekeeper-Nightly" This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77. TBR=robertphillips@google.com,sugoi@google.com Review URL: https://codereview.chromium.org/153583007 git-svn-id: http://skia.googlecode.com/svn/trunk@13356 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-07 05:55:39 +00:00
commit-bot@chromium.org	4f6318d2e6	Serialization of SkPictureImageFilter ... BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13347 R=senorblanco@google.com, reed@google.com, mtklein@google.com, sugoi@google.com, senorblanco@chromium.org, robertphillips@google.com, scroggo@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/138063005 git-svn-id: http://skia.googlecode.com/svn/trunk@13354 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-07 02:09:50 +00:00
robertphillips@google.com	8b4799a98b	Revert of r13347 (Serialization of SkPictureImageFilter - https://codereview.chromium.org/138063005) due to bump in skp file format ... git-svn-id: http://skia.googlecode.com/svn/trunk@13348 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-06 18:47:25 +00:00
commit-bot@chromium.org	670b98ea5d	Serialization of SkPictureImageFilter ... BUG=skia: R=senorblanco@google.com, reed@google.com, mtklein@google.com, sugoi@google.com, senorblanco@chromium.org, robertphillips@google.com, scroggo@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/138063005 git-svn-id: http://skia.googlecode.com/svn/trunk@13347 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-06 18:06:14 +00:00
reed@google.com	76f10a3bd9	remove SkCanvas::createCompatibleDevice, and add SkCanvas::newSurface ... BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/154163002 git-svn-id: http://skia.googlecode.com/svn/trunk@13319 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-05 15:32:21 +00:00
reed@google.com	6fcd28ba1d	fix samplefuzz, fix some 32/64bit warnings ... git-svn-id: http://skia.googlecode.com/svn/trunk@13303 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-04 16:03:51 +00:00
commit-bot@chromium.org	8c6f4b3261	Adding int cast to prevent warning ... BUG=skia: R=fmalita@google.com, fmalita@chromium.org, bsalomon@google.com, bsalomon@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/149463009 git-svn-id: http://skia.googlecode.com/svn/trunk@13285 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-03 19:40:32 +00:00
commit-bot@chromium.org	c22d139808	Initial QuadTree implementation ... In an effort to find a faster bounding box hierarchy than the R-Tree, a QuadTree has been implemented here. For now, the QuadTree construction is generally faster than the R-Tree and the queries are a bit slower, so overall, SKP local tests showed QuadTree performance similar to the R-Tree performance. Tests and bench are included in this cl. At this point, I'd like to be able to commit this in order to more easily use the bots to test multiple configurations and a larger number of SKPs. The R-Tree BBH is still used by default so this change shouldn't affect chromium. BUG=skia: R=junov@chromium.org, junov@google.com, senorblanco@google.com, senorblanco@chromium.org, reed@google.com, sugoi@google.com, fmalita@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/131343011 git-svn-id: http://skia.googlecode.com/svn/trunk@13282 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-02-03 18:08:33 +00:00
commit-bot@chromium.org	8b0e8ac5f5	Refactor read and write buffers. ... Eliminates SkFlattenable{Read,Write}Buffer, promoting SkOrdered{Read,Write}Buffer a step each in the hierarchy. What used to be this: SkFlattenableWriteBuffer -> SkOrderedWriteBuffer SkFlattenableReadBuffer -> SkOrderedReadBuffer SkFlattenableReadBuffer -> SkValidatingReadBuffer is now SkWriteBuffer SkReadBuffer -> SkValidatingReadBuffer Benefits: - code is simpler, names are less wordy - the generic SkFlattenableFooBuffer code in SkPaint was incorrect; removed - write buffers are completely devirtualized, important for record speed This refactoring was mostly mechanical. You aren't going to find anything interesting in files with less than 10 lines changed. BUG=skia: R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/134163010 git-svn-id: http://skia.googlecode.com/svn/trunk@13245 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-30 18:58:24 +00:00
reed@google.com	7fa2a65c0c	fix more 64bit warnings ... BUG=skia: Review URL: https://codereview.chromium.org/147683003 git-svn-id: http://skia.googlecode.com/svn/trunk@13190 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-27 13:42:58 +00:00
commit-bot@chromium.org	d8ed85101e	Turn NVPR on by default (but off in tools). ... BUG=skia:2042 Committed: http://code.google.com/p/skia/source/detail?r=13164 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/144003006 git-svn-id: http://skia.googlecode.com/svn/trunk@13176 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-24 20:49:44 +00:00
halcanary@google.com	68c74884d0	Revert "Turn NVPR on by default (but off in tools)." ... This reverts commit 83d81c96de. Broke Windows build. Autorevert didn't work. TBR=bsalomon@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true BUG=skia:2042 Review URL: https://codereview.chromium.org/146863003 git-svn-id: http://skia.googlecode.com/svn/trunk@13169 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-24 16:04:09 +00:00
commit-bot@chromium.org	83d81c96de	Turn NVPR on by default (but off in tools). ... BUG=skia:2042 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/144003006 git-svn-id: http://skia.googlecode.com/svn/trunk@13164 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-24 14:38:13 +00:00
tfarina@chromium.org	b2c323a91a	Remove unused SampleTests.cpp source file. ... We never compile this file. BUG=None TEST=tests R=reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/143823016 git-svn-id: http://skia.googlecode.com/svn/trunk@13157 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-23 21:30:43 +00:00
mike@reedtribe.org	d173b87608	remove SkScalarMul macro ... git-svn-id: http://skia.googlecode.com/svn/trunk@13145 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-23 02:02:45 +00:00
commit-bot@chromium.org	7873333236	Remove GetGr() hack. ... It seems no GM are using this. BUG=None TEST=SampleApp R=bsalomon@google.com, caryclark@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/144543003 git-svn-id: http://skia.googlecode.com/svn/trunk@13141 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-22 14:43:47 +00:00
commit-bot@chromium.org	7b8d72d892	Adding SkPictureImageFilter to the fuzzer ... BUG=skia: R=senorblanco@google.com, senorblanco@chromium.org, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/140993004 git-svn-id: http://skia.googlecode.com/svn/trunk@13116 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-16 22:54:41 +00:00
commit-bot@chromium.org	43f4a55104	Change to fuzzer for new constructor ... BUG=skia: R=senorblanco@google.com, sugoi@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/139613002 git-svn-id: http://skia.googlecode.com/svn/trunk@13099 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-15 20:20:24 +00:00
commit-bot@chromium.org	32678d9a45	use some helper Make functions to initialize SkImageInfo ... BUG= R=halcanary@google.com, scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/137993012 git-svn-id: http://skia.googlecode.com/svn/trunk@13081 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-15 02:38:22 +00:00
reed@google.com	bf0001d047	remove remaining references to Sk64 (obsolete) ... BUG= Review URL: https://codereview.chromium.org/136673002 git-svn-id: http://skia.googlecode.com/svn/trunk@13042 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-13 14:53:55 +00:00
halcanary@google.com	9acb8cdf20	SampleApp Cleanup: ... - Set resoursePath to sensible default. - Remove verbosity of DitherBitmap. - SampleEncode no longer tries to mkdir('/encoded'), now stores encoded data in memory and uses the SkDecodingImageGenerator to decode. BUG= R=reed@google.com Review URL: https://codereview.chromium.org/132513003 git-svn-id: http://skia.googlecode.com/svn/trunk@13015 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-10 14:53:49 +00:00
halcanary@google.com	3d50ea1b87	Add Options to SkDecodingImageGenerator, simplify API. ... Motivation: We want to remove redundant classes from Skia. To that end we want to remove SkImageRef and its subclasses and replace their uses with SkDiscardablePixelRef + SkDecodingImageGenerator. Since Android uses SkImageRef, we need to make sure that SkDecodingImageGenerator allows all of the settings that Android exposes in BitmapFactory.Options. To that end, we have created an Options struct for the SkDecodingImageGenerator which lets the client of the generator set sample size, dithering, and bitmap config. We have made the SkDecodingImageGenerator constructor private and replaced the SkDecodingImageGenerator::Install functions with a SkDecodingImageGenerator::Create functions (one for SkData and one for SkStream) which now take a SkDecodingImageGenerator::Options struct. Also added a ImageDecoderOptions test which loops through a list of sets of options and tries them on a set of 5 small encoded images. Also updated several users of SkDecodingImageGenerator::Install to follow new call signature - gm/factory.cpp, LazyDecodeBitmap.cpp, and PictureTest.cpp, CachedDecodingPixelRefTest.cpp. We also added a new ImprovedBitmapFactory Test which simulates the exact function that Android will need to modify to use this, installPixelRef() in BitmapFactory. R=reed@google.com, scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=12744 Review URL: https://codereview.chromium.org/93703004 git-svn-id: http://skia.googlecode.com/svn/trunk@12855 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-01-02 13:15:13 +00:00
commit-bot@chromium.org	1ad518bf38	Revert of https://codereview.chromium.org/93703004/ ... Reason for revert: Test failures R=scroggo@google.com, djsollen@google.com, reed@google.com, halcanary@google.com TBR=djsollen@google.com, halcanary@google.com, reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true Author: robertphillips@google.com Review URL: https://codereview.chromium.org/103753007 git-svn-id: http://skia.googlecode.com/svn/trunk@12747 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-18 18:33:15 +00:00
halcanary@google.com	d665dc4c10	Add Options to SkDecodingImageGenerator, simplify API. ... Motivation: We want to remove redundant classes from Skia. To that end we want to remove SkImageRef and its subclasses and replace their uses with SkDiscardablePixelRef + SkDecodingImageGenerator. Since Android uses SkImageRef, we need to make sure that SkDecodingImageGenerator allows all of the settings that Android exposes in BitmapFactory.Options. To that end, we have created an Options struct for the SkDecodingImageGenerator which lets the client of the generator set sample size, dithering, and bitmap config. We have made the SkDecodingImageGenerator constructor private and replaced the SkDecodingImageGenerator::Install functions with a SkDecodingImageGenerator::Create functions (one for SkData and one for SkStream) which now take a SkDecodingImageGenerator::Options struct. Also added a ImageDecoderOptions test which loops through a list of sets of options and tries them on a set of 5 small encoded images. Also updated several users of SkDecodingImageGenerator::Install to follow new call signature - gm/factory.cpp, LazyDecodeBitmap.cpp, and PictureTest.cpp, CachedDecodingPixelRefTest.cpp. We also added a new ImprovedBitmapFactory Test which simulates the exact function that Android will need to modify to use this, installPixelRef() in BitmapFactory. R=reed@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/93703004 git-svn-id: http://skia.googlecode.com/svn/trunk@12744 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-18 17:40:25 +00:00
halcanary@google.com	e2380570de	SamplePicture no longer uses SkImageRef ... Motivation: in an attempt to simplify life, we are depricating SkImageRef and its subclasses. To that end, SamplePicture will now use SkDiscardablePixelRef. Also, fixed missing resource. BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/116423006 git-svn-id: http://skia.googlecode.com/svn/trunk@12737 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-18 15:08:35 +00:00
commit-bot@chromium.org	ef74fa189b	Fixed more fuzzer issues ... - Added the "isAvailable" function to check how much bytes are remaining in the stream before doing potentially large mallocs. That way, we can signal a bad stream instead of crashing. - Added data validation in SkImageInfo.cpp - Added NULL pointer check in displacement - Modified the fuzzer for randomized bitmap types BUG=328934,329254 R=senorblanco@google.com, senorblanco@chromium.org, reed@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/116773002 git-svn-id: http://skia.googlecode.com/svn/trunk@12723 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-17 20:49:46 +00:00
reed@google.com	e1ca705cac	deprecate SkScalarRound (and its ilk), use SkScalarRound[ToInt,ToScalar]. #define SK_SUPPORT_DEPRECATED_SCALARROUND for legacy clients ... BUG= R=robertphillips@google.com Review URL: https://codereview.chromium.org/111353003 git-svn-id: http://skia.googlecode.com/svn/trunk@12719 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-17 19:22:07 +00:00
reed@google.com	8f4d2306fa	remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats ... To keep the CL (slightly) managable, this does not make any changes to existing macros (e.g. SkScalarMul). Just tackling #ifdef constructs this time around. BUG= R=bsalomon@google.com, caryclark@google.com Review URL: https://codereview.chromium.org/117053002 git-svn-id: http://skia.googlecode.com/svn/trunk@12712 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-17 16:44:46 +00:00
tfarina@chromium.org	4f3c305a5b	Fix some presubmit warnings. ... I found this while running a modified version of v8's tools/presubmit.py script. samplecode/SampleImage.cpp does not end with a single new line. samplecode/SampleImageDir.cpp does not end with a single new line. src/ports/SkFontHost_sandbox_none.cpp does not end with a single new line. tests/FlatDataTest.cpp does not end with a single new line. tests/ImageCacheTest.cpp has trailing whitespaces in line 31. * Removed three empty files. * Add single new line to FlatDataTest.cpp * Removed trailing whitespace in ImageCacheTest.cpp BUG=None TEST=None R=bsalomon@google.com TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/111503008 git-svn-id: http://skia.googlecode.com/svn/trunk@12684 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-14 15:12:48 +00:00
reed@google.com	bf790232f6	Update all callsites to use info for pixelrefs ... #define SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR in chrome to keep old API signature (for now) BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/100723005 git-svn-id: http://skia.googlecode.com/svn/trunk@12677 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-13 19:45:58 +00:00
robertphillips@google.com	0daa1adb03	Reverting r12665 & r12666 (Remove duplicate impl for SkImageInfo flattening) due to Chromium/Blink compilation errors ... https://codereview.chromium.org/112603003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12667 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-13 15:24:37 +00:00
reed@google.com	93b40594b7	Remvoe duplicate impl for SkImageInfo flattening ... Add onNewLockPixels This reverts commit bb8eff6a70c52b7644391cfd4f4d21bf7294a6bf. BUG= Review URL: https://codereview.chromium.org/111323005 git-svn-id: http://skia.googlecode.com/svn/trunk@12665 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-13 14:18:14 +00:00
reed@google.com	398337b3a5	Revert "remvoe duplicate impl for SkImageInfo flattening" ... Reason: breaks chrome_mac_tests which still have non-imageinfo constructors This reverts commit a06b8cf60b39bda93e9ef1a73579007b2b930d29. BUG= Review URL: https://codereview.chromium.org/103033005 git-svn-id: http://skia.googlecode.com/svn/trunk@12631 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-11 21:22:39 +00:00
reed@google.com	a0d183d891	Revert "Revert of https://codereview.chromium.org/108773003/" ... This reverts commit 947e6a3142af66b750f1247ef933b11ed8455dd4. BUG= Review URL: https://codereview.chromium.org/112963003 git-svn-id: http://skia.googlecode.com/svn/trunk@12630 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-11 21:15:58 +00:00
commit-bot@chromium.org	ff9c6c92e5	Revert of https://codereview.chromium.org/108773003/ ... Reason for revert: breaks chrome-mac-tests TBR= NOTREECHECKS=true NOTRY=true Author: reed@google.com Review URL: https://codereview.chromium.org/113193003 git-svn-id: http://skia.googlecode.com/svn/trunk@12629 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-11 20:55:41 +00:00
reed@google.com	f3aead2829	remvoe duplicate impl for SkImageInfo flattening ... Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""""" This reverts commit eabd6b2ed4e494b323c08f32358f45950a0368c3. BUG= Review URL: https://codereview.chromium.org/108773003 git-svn-id: http://skia.googlecode.com/svn/trunk@12624 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-11 18:38:46 +00:00
reed@google.com	6a32add491	Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""""" ... This reverts commit d08eca87a0bef10112a211de540f89656a80b86a. BUG= Review URL: https://codereview.chromium.org/108303003 git-svn-id: http://skia.googlecode.com/svn/trunk@12623 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-11 18:19:10 +00:00
reed@google.com	6965a0a2df	PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""" ... BUG= Review URL: https://codereview.chromium.org/110503003 git-svn-id: http://skia.googlecode.com/svn/trunk@12622 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-11 18:04:56 +00:00
commit-bot@chromium.org	6de4a7836f	Fix SampleApp bounding box hierarchy shortcut collision. ... 'b' is currently bound to the AA toggle, AND to the bounding box hierachy toggle. The CL switches BBH to 'B', and fixes a deferred title update issue. R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/112903002 git-svn-id: http://skia.googlecode.com/svn/trunk@12620 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-11 17:05:23 +00:00
fmalita@google.com	9a65e2c22d	More signed/unsigned comparison warnings. ... TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/100103006 git-svn-id: http://skia.googlecode.com/svn/trunk@12615 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-10 22:25:53 +00:00
fmalita@google.com	e6a98d4259	Fix warning after bbe43a9ce0. ... TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/108973006 git-svn-id: http://skia.googlecode.com/svn/trunk@12614 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-10 22:12:40 +00:00
commit-bot@chromium.org	bbe43a9ce0	Add SkTileGridPicture SampleApp playback support. ... SampleApp already supports switching to a bbox hierarchy playback mode ('b' shortcut). This CL adds an SkTileGridPicture bbox mode. R=reed@google.com, robertphillips@google.com, fmalita@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/108513006 git-svn-id: http://skia.googlecode.com/svn/trunk@12613 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-10 21:51:06 +00:00
reed@google.com	15bc13d20f	change 'n' toggle to cycle through all filterlevels ... BUG= R=humper@google.com Review URL: https://codereview.chromium.org/109473004 git-svn-id: http://skia.googlecode.com/svn/trunk@12602 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-10 16:53:13 +00:00
reed@google.com	2ebc10dd12	Revert "Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""" ... This reverts commit 5f035e90d6dea0139a4f204b634e7b7b3b4976d7. Reverting because it breaks chrome/blink due to new SkPixelRef constructor arg. BUG= Review URL: https://codereview.chromium.org/108993002 git-svn-id: http://skia.googlecode.com/svn/trunk@12551 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-06 21:43:05 +00:00
reed@google.com	473f0aa2bb	Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."" ... This reverts commit 4174afb18a9746bbad2a06c0ec2d4ad35f72d790. BUG= Review URL: https://codereview.chromium.org/108723003 git-svn-id: http://skia.googlecode.com/svn/trunk@12547 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-06 20:31:45 +00:00
commit-bot@chromium.org	cc63b32eb8	Additional SampleApp tiling options. ... Adding some more tiling options (both relative and fixed size): kNo_Tiling, kAbs_128x128_Tiling, kAbs_256x256_Tiling, kRel_4x4_Tiling, kRel_1x16_Tiling, kRel_16x1_Tiling, R=bungeman@google.com, reed@google.com, fmalita@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/108213004 git-svn-id: http://skia.googlecode.com/svn/trunk@12545 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-06 20:14:55 +00:00
commit-bot@chromium.org	c2e9db30d3	Fixed a few places where uninitialized memory could have been read ... Also added early exit in SkImageFilter's constructor to avoid attempting to deserialize all inputs once a bad input has been found. This avoids hanging if a filter pretends to have 1 billion inputs when that's just an error on the number of inputs read by the filter. BUG=326206,326197,326229 R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/106943002 git-svn-id: http://skia.googlecode.com/svn/trunk@12544 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-06 20:14:46 +00:00
reed@google.com	5b132b28da	Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap." ... This reverts commit 154e08b2f5904ef533da694e3510befcb9a3f3e2. revert due to warnings Review URL: https://codereview.chromium.org/108513003 git-svn-id: http://skia.googlecode.com/svn/trunk@12538 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-06 18:51:08 +00:00
reed@google.com	3e89524e74	PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap. ... R=mtklein@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/68973005 git-svn-id: http://skia.googlecode.com/svn/trunk@12537 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-06 18:41:33 +00:00
commit-bot@chromium.org	ab1c13864d	Fix compilation with SK_ENABLE_INST_COUNT=1 ... Add INHERITED declarations to class declarations that prevent compilation with the flag. Remove SK_DEFINE_INST_COUNT from all class implementations. Instead, use function-local static variables in the reference count helper classes to create the global instances to store the needed info. The accessor functions are defined inline in the helper classes, so definitions are not needed. The initialization point of the variables should be as well defined as previously. Remove SK_DECLARE_INST_COUNT_TEMPLATE and use SK_DECLARE_INST_COUNT instead. This avoids possible future compilation errors further. For SK_ENABLE_INST_COUNT=0 compilation, add an empty static member function to all classes that use SK_DECLARE_INST_COUNT and SK_DECLARE_INST_COUNT_ROOT macros. The function ensures that classes contain public INHERITED typedef. This member function seems to be compiled away. This shouĺd ensure that part of the compilation errors are caught earlier. Also adds DSK_DECLARE_INST_COUNT to few SkPDFDict subclasses. R=robertphillips@google.com, richardlin@chromium.org, bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/98703002 git-svn-id: http://skia.googlecode.com/svn/trunk@12501 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-05 12:08:12 +00:00
commit-bot@chromium.org	cd3b15ca63	Fixed bad bitmap size crashes ... There were 2 issues : 1 ) If the size of an SkBitmap's underlying SkPixelRef's alocated memory is too small to fit the bitmap, then the deserialization will now check this and set an error appropriately. 2 ) If a device fails to allocate its pixels, the device will be deleted and NULL will be returned to avoid attempting to draw on a bad device. BUG= R=senorblanco@chromium.org, reed@google.com, sugoi@google.com, halcanary@google.com, mtklein@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/92793002 git-svn-id: http://skia.googlecode.com/svn/trunk@12484 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-04 17:06:49 +00:00
rmistry@google.com	d6bab02386	Reverting r12427 ... git-svn-id: http://skia.googlecode.com/svn/trunk@12428 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-02 13:50:38 +00:00
skia.committer@gmail.com	5b39f5ba9c	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@12427 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-12-02 13:36:22 +00:00
commit-bot@chromium.org	11f392ed53	Revert "Revert "remove kA1_Config, as it is no longer supported"" ... This reverts commit 36d712f2d4c5c79719280ad95523e6aaa88b068e. BUG= R=rmistry@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/86483002 git-svn-id: http://skia.googlecode.com/svn/trunk@12392 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-26 12:51:57 +00:00
reed@google.com	72e7808d62	Revert "remove kA1_Config, as it is no longer supported" ... This reverts commit 2d72d8b242eac6e9d30228f5b0a407236491c369. git-svn-id: http://skia.googlecode.com/svn/trunk@12387 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-25 20:54:56 +00:00
commit-bot@chromium.org	4b413c8bb1	remove SkFloatToScalar macro ... BUG= R=reed@google.com, djsollen@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/85463005 git-svn-id: http://skia.googlecode.com/svn/trunk@12385 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-25 19:44:07 +00:00
reed@google.com	2a1f4464d1	remove kA1_Config, as it is no longer supported ... BUG= R=djsollen@google.com Review URL: https://codereview.chromium.org/83093005 git-svn-id: http://skia.googlecode.com/svn/trunk@12384 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-25 18:58:29 +00:00
commit-bot@chromium.org	e61a86cfa0	Guard against most unintentionally ephemeral SkAutoFoo instantiations. ... I think I applied the trick everywhere possible. Limitations: - can't be used with templated classes - all constructors and destructors must be defined inline A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I deleted them. This change caught the same bugs Cary found in SkPath, plus one more in SampleApp. BUG= R=reed@google.com, caryclark@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/72603005 git-svn-id: http://skia.googlecode.com/svn/trunk@12301 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-18 16:03:59 +00:00
scroggo@google.com	909228992c	Pdfviewer refactoring. ... Mostly superficial changes, to help me make sure I understand the code while making modifications. SkPdfRenderer: First class I'm modifying. Move it into include/ and src/ directories. Inherit from SkNoncopyable. Replace load() with factory function which returns NULL if the load fails. Remove unload() and loaded(), which no longer make sense, since the factory will return NULL on a failure to load, and unload() happens on destruction. Use a const char* for loading a PDF, following the convention of SkStream::NewFromFile. Remove unnecessary call to sqrt in SkPDFNativeRenderToBitmap. Also in SkPDFNativeRenderToBitmap, use an appropriate SkScalar macro to convert to an integer. Use this-> when calling member functions. pdf_viewer_main.cpp: Call the new interface for SkPdfRenderer. gyp files: Refer to the new location of SkPdfRenderer. R=edisonn@google.com Review URL: https://codereview.chromium.org/59493011 git-svn-id: http://skia.googlecode.com/svn/trunk@12296 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-14 19:09:27 +00:00
commit-bot@chromium.org	21a0b10d7c	Remove deprecated setIsOpaque() API from SkBitmap. ... Clients we care (Blink, Chromium) were updated, so we can remove this now. BUG=None R=bsalomon@google.com, reed@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/66723017 git-svn-id: http://skia.googlecode.com/svn/trunk@12251 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-12 18:16:34 +00:00
commit-bot@chromium.org	4faa869cda	Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream. ... BUG= R=reed@google.com, mtklein@google.com, senorblanco@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=12114 Committed: https://code.google.com/p/skia/source/detail?r=12119 Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/41253002 git-svn-id: http://skia.googlecode.com/svn/trunk@12130 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-05 15:46:56 +00:00
reed@google.com	12a23866fe	Revert "Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream." ... This reverts commit 6bc22e8ef1ea70a1b58409aa21254358c50f149a. git-svn-id: http://skia.googlecode.com/svn/trunk@12124 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-04 21:35:55 +00:00
sugoi@google.com	b48a59ae81	Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream. ... BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12114 Review URL: https://codereview.chromium.org/41253002 git-svn-id: http://skia.googlecode.com/svn/trunk@12119 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-04 20:28:23 +00:00
epoger@google.com	eb221268ab	Revert r12114 due to https://code.google.com/p/skia/issues/detail?id=1794 ('Assertion failures on various buildbots as of r12114') ... git-svn-id: http://skia.googlecode.com/svn/trunk@12115 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-04 18:06:12 +00:00
sugoi@google.com	305f78e8c1	Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream. ... BUG= R=reed@google.com Review URL: https://codereview.chromium.org/41253002 git-svn-id: http://skia.googlecode.com/svn/trunk@12114 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-04 16:18:15 +00:00
reed@google.com	2bd8b81005	move SkImage::ColorType into SkColorType ... objective -- move clients over to SkImage tasks - use SkImageInfo instead of SkBitmap::Config - add support for colortables to SkImage - add drawImage to SkCanvas - return SkImage from readPixels This CL works towards the first task R=robertphillips@google.com Review URL: https://codereview.chromium.org/54363008 git-svn-id: http://skia.googlecode.com/svn/trunk@12077 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-11-01 13:46:54 +00:00
reed@google.com	4469938e92	Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning"" ... This reverts commit 1e787c38fa71f2a21fd728f1b1d620b9b09b0d3d. BUG= Review URL: https://codereview.chromium.org/54603004 git-svn-id: http://skia.googlecode.com/svn/trunk@12057 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-31 17:28:30 +00:00
reed@google.com	6fcbfcead5	Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning" ... This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497. git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-31 16:31:11 +00:00
reed@google.com	081560e3ab	add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning ... BUG= R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org Review URL: https://codereview.chromium.org/51033004 git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-31 16:24:08 +00:00
skia.committer@gmail.com	7ed98df9ba	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@12043 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-31 07:01:53 +00:00
reed@google.com	bbe66f0824	add triangles to fatbits sample ('t') ... git-svn-id: http://skia.googlecode.com/svn/trunk@12015 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-30 13:41:19 +00:00
commit-bot@chromium.org	77e079af1a	Enabling validation code in serialization and adding serialization to fuzzer ... BUG= Committed: http://code.google.com/p/skia/source/detail?r=11968 R=reed@google.com, mtklein@google.com, senorblanco@chromium.org, bsalomon@google.com, robertphillips@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/44573002 git-svn-id: http://skia.googlecode.com/svn/trunk@11981 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-28 15:52:02 +00:00
robertphillips@google.com	3721ee652a	Reverting r11968 (Enabling validation code in serialization and adding serialization to fuzzer - https://codereview.chromium.org/44573002) due to failure on Chromium AllQuads test. ... git-svn-id: http://skia.googlecode.com/svn/trunk@11974 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-28 12:08:52 +00:00
commit-bot@chromium.org	d25d6c7b8e	Enabling validation code in serialization and adding serialization to fuzzer ... BUG= R=reed@google.com, mtklein@google.com, senorblanco@chromium.org, bsalomon@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/44573002 git-svn-id: http://skia.googlecode.com/svn/trunk@11968 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-25 21:04:40 +00:00
reed@google.com	383a697692	store SkAlphaType inside SkBitmap, on road to support unpremul ... BUG= R=bsalomon@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/25275004 git-svn-id: http://skia.googlecode.com/svn/trunk@11877 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-21 14:00:07 +00:00
halcanary@google.com	805ca19625	SampleApp - reduce unnecessary verbosity [with --picture $path] ... Before this change, `SampleApp --picture $path` prints out usage (as well as --pictureDir) as if there was a syntax error in the command line arguments. BUG=skia:1677 R=reed@google.com Review URL: https://codereview.chromium.org/24503003 git-svn-id: http://skia.googlecode.com/svn/trunk@11748 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-14 12:47:37 +00:00
bungeman@google.com	fab44db294	Clean up SkTypes.h. ... This change removes sk_stdint.h since it is only needed for vs2008 and earlier. This change removes SK_MMAP_SUPPORT define since it is no longer used. This change removes the stdio.h include from SkTypes.h since on many systems this is a very large header, few Skia files actually use it, it is available everywhere standard, and SkDebugf should be used instead. After this change there is no need for external users to put Skia's include/config into their own list of includes, saving the headache of having two header files of the same name and sometimes getting the wrong one depending on include order. R=bsalomon@google.com, djsollen@google.com Review URL: https://codereview.chromium.org/27044002 git-svn-id: http://skia.googlecode.com/svn/trunk@11738 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-11 18:50:45 +00:00
reed@google.com	0a6151d66c	Revert "Revert "change SkColorTable to be immutable"" ... This reverts commit b8162cb840f4cb6002ef68d5ac775c6a122c52a9. Fixed was call-sites in benches that used the (now gone) setIsOpaque api. R=scroggo@google.com Review URL: https://codereview.chromium.org/26572006 git-svn-id: http://skia.googlecode.com/svn/trunk@11695 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-10 14:44:56 +00:00
reed@google.com	48d9ff5b34	Revert "change SkColorTable to be immutable" ... This reverts commit 1c0ff422868b3badf5ffe0790a5d051d1896e2f7. BUG= Review URL: https://codereview.chromium.org/26709002 git-svn-id: http://skia.googlecode.com/svn/trunk@11677 2bbb7eff-a529-9590-31e7-b0007b416f81	2013-10-09 16:49:45 +00:00