Commit Graph

9997 Commits

Author SHA1 Message Date
skia.committer@gmail.com
cf0803b46f Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12590 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-10 07:02:03 +00:00
vandebo@chromium.org
969967ed68 [PDF] PDF rasterizers fed garbage data in release mode.
BUG=skia:1885
TBR=epoger@google.com

Review URL: https://codereview.chromium.org/103213007

git-svn-id: http://skia.googlecode.com/svn/trunk@12589 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 23:22:15 +00:00
reed@google.com
e4eb122a61 support scaledimagecache instantiable using discardablememory
Add this to your build/gyp system to use discardable instead of malloc+budget

#define SK_USE_DISCARDABLE_SCALEDIMAGECACHE

R=halcanary@google.com

Review URL: https://codereview.chromium.org/105933003

git-svn-id: http://skia.googlecode.com/svn/trunk@12588 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 22:29:30 +00:00
reed@google.com
f309dbcf2a add
git-svn-id: http://skia.googlecode.com/svn/trunk@12587 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 22:09:41 +00:00
reed@google.com
9230ea2971 make info real in SkPixelRef, and add bitmap::asImageInfo
BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/108663004

git-svn-id: http://skia.googlecode.com/svn/trunk@12586 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 22:01:03 +00:00
epoger@google.com
331e237890 GM expectations: create initial empty expectations for Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind
(SkipBuildbotRuns)
TBR=djsollen

Review URL: https://codereview.chromium.org/100643003

git-svn-id: http://skia.googlecode.com/svn/trunk@12585 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 21:02:11 +00:00
bsalomon@google.com
bc8b1ff885 add hq clipped biptmap shader GMs to ignored-tests.txt
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/93633003

git-svn-id: http://skia.googlecode.com/svn/trunk@12584 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 20:52:47 +00:00
senorblanco@chromium.org
c80f2f7ab3 New Nexus4 baselines due to r12571.
R=robertphillips

Review URL: https://codereview.chromium.org/110603003

git-svn-id: http://skia.googlecode.com/svn/trunk@12583 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 20:52:40 +00:00
bsalomon@google.com
862c4d658f Mark rrect_clip_aa, skbug1719, and pathopsskpclip as ignored on N4 gpu
BUG=skia:1888
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/107843003

git-svn-id: http://skia.googlecode.com/svn/trunk@12582 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 20:41:00 +00:00
robertphillips@google.com
871840d606 Revert the revert of (ARM Skia NEON patches - 34 - Blur Filter - https://codereview.chromium.org/109403004/)
git-svn-id: http://skia.googlecode.com/svn/trunk@12581 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 20:35:03 +00:00
reed@google.com
d7b1af68de cast -1 to Mode to avoid warning (enum compared to signed int)
git-svn-id: http://skia.googlecode.com/svn/trunk@12580 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 20:31:50 +00:00
robertphillips@google.com
8bbf6b92ee Reverting r12568 (ARM Skia NEON patches - 34 - Blur Filter - https://codereview.chromium.org/109403004) due to image quality regressions on the N4.
git-svn-id: http://skia.googlecode.com/svn/trunk@12578 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 20:16:17 +00:00
bungeman@google.com
aeec33448f Fix one too many levels of indirection introduced in 12573.
git-svn-id: http://skia.googlecode.com/svn/trunk@12577 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 19:30:28 +00:00
commit-bot@chromium.org
cea9abb001 Do not use GrBicubic effect when downscaling. Also, don't use glTexStorage as it interferes with deleyed mipmap generation.
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/105353002

git-svn-id: http://skia.googlecode.com/svn/trunk@12576 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 19:15:37 +00:00
commit-bot@chromium.org
c9c0b1e90e adding to whitespace.txt using a pure git checkout
(SkipBuildbotRuns)

BUG=
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/110553002

git-svn-id: http://skia.googlecode.com/svn/trunk@12574 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 19:08:44 +00:00
bungeman@google.com
0ff457bd5e Fix threading issue in DirectWrite port initialization.
The DirectWrite port maintains a global instance of an IDWriteFactory,
which is used to create all other DirectWrite objects. However, the
initialization of this object is not currently thread safe.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/107963003

git-svn-id: http://skia.googlecode.com/svn/trunk@12573 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 18:58:31 +00:00
bsalomon@google.com
ee9fb43774 fix file names in gpu.gypi
Review URL: https://codereview.chromium.org/99193004

git-svn-id: http://skia.googlecode.com/svn/trunk@12572 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 18:48:51 +00:00
senorblanco@chromium.org
e93e1dbf0e Implement srcRect and dstRect functionality in SkBitmapSource. This is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource".
This also includes some changes to the xfermodeimagefilter and tileimagefilter GMs to properly handle the CTM. This worked before only because SkBitmapSource was ignoring the CTM. Now that it respects it, we need to give the correct transform. This also means the GMs now work while zoomed. It also implements CTM support for SkTileImageFilter.

NOTE: this will require rebaselining a number of imagefilter GMs on Nexus4, since they render in perspective (using the CTM). The changes to the results should all be improvements.

R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/106933002

git-svn-id: http://skia.googlecode.com/svn/trunk@12571 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 18:31:42 +00:00
commit-bot@chromium.org
907fbd53c5 Make texture domain a helper so that it can be incorporated into other effects.
R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/98893006

git-svn-id: http://skia.googlecode.com/svn/trunk@12569 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 17:03:02 +00:00
commit-bot@chromium.org
2a7d4ddb17 ARM Skia NEON patches - 34 - Blur Filter
Improve a little on Blur

Grouping operations gives a 5-15% speed improvement on a Cortex-A15 based Chromebook.

before:
running bench [640 480]   blur_image_filter_large_10.00_10.00   8888:  cmsecs =  30887.69
running bench [640 480]   blur_image_filter_small_10.00_10.00   8888:  cmsecs =  30751.35
running bench [640 480]     blur_image_filter_large_1.00_1.00   8888:  cmsecs =  30757.92
running bench [640 480]     blur_image_filter_small_1.00_1.00   8888:  cmsecs =  30673.88
running bench [640 480]     blur_image_filter_large_0.00_1.00   8888:  cmsecs =  19602.17
running bench [640 480]    blur_image_filter_large_0.00_10.00   8888:  cmsecs =  20613.81
running bench [640 480]     blur_image_filter_large_1.00_0.00   8888:  cmsecs =  17855.46
running bench [640 480]    blur_image_filter_large_10.00_0.00   8888:  cmsecs =  17957.79

after:
running bench [640 480]   blur_image_filter_large_10.00_10.00   8888:  cmsecs =  27015.75
running bench [640 480]   blur_image_filter_small_10.00_10.00   8888:  cmsecs =  27148.02
running bench [640 480]     blur_image_filter_large_1.00_1.00   8888:  cmsecs =  27241.60
running bench [640 480]     blur_image_filter_small_1.00_1.00   8888:  cmsecs =  27077.44
running bench [640 480]     blur_image_filter_large_0.00_1.00   8888:  cmsecs =  18458.10
running bench [640 480]    blur_image_filter_large_0.00_10.00   8888:  cmsecs =  19643.42
running bench [640 480]     blur_image_filter_large_1.00_0.00   8888:  cmsecs =  16176.73
running bench [640 480]    blur_image_filter_large_10.00_0.00   8888:  cmsecs =  16450.50

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=
R=senorblanco@chromium.org, mtklein@google.com, luisjoseromeroesclusa@hotmail.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/109403004

git-svn-id: http://skia.googlecode.com/svn/trunk@12568 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 16:03:30 +00:00
robertphillips@google.com
aad7e0b607 Add more valgrind suppressions
https://codereview.chromium.org/102443003/



git-svn-id: http://skia.googlecode.com/svn/trunk@12561 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 13:55:33 +00:00
halcanary@google.com
29d96935ae SkDecodingImageGenerator now uses SkStreamRewindable
This makes sense since Android will be giving us a stream and the
decoders expect a stream.  This also removes some glue code,
DecodeMemoryToTarget, that works better using a SkImageGenerator.

Motivation: This is a necessary step to move from SkImageRef to
SkDiscardablePixelRef.

SkImageDecoder::DecodeMemoryToTarget function removed.

BUG=
R=reed@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/101973005

git-svn-id: http://skia.googlecode.com/svn/trunk@12560 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 13:45:02 +00:00
reed@google.com
61867875ef add SkImageInfo to SkGrPixelRef constructor, to prep for larger CL
BUG=

Review URL: https://codereview.chromium.org/104923011

git-svn-id: http://skia.googlecode.com/svn/trunk@12559 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 13:41:06 +00:00
commit-bot@chromium.org
bc451d2823 Just a typo. Rename StrokeRect to StrokeRects in strokerects.cpp, making it different from the class name in strokerect.cpp for debugging.
R=bungeman@google.com, reed@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/99573004

git-svn-id: http://skia.googlecode.com/svn/trunk@12557 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-09 09:14:59 +00:00
skia.committer@gmail.com
56710d1905 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12555 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-07 07:02:21 +00:00
commit-bot@chromium.org
3e7f385336 gpudevice should never allocate pixels for its backend
BUG=
R=bsalomon@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/109013002

git-svn-id: http://skia.googlecode.com/svn/trunk@12554 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 22:59:02 +00:00
reed@google.com
b0eb102ed6 remove explicit when we have 2 args
git-svn-id: http://skia.googlecode.com/svn/trunk@12553 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 22:16:10 +00:00
reed@google.com
f1715706f7 add SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR, initially always on
BUG=

Review URL: https://codereview.chromium.org/106183007

git-svn-id: http://skia.googlecode.com/svn/trunk@12552 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 22:07:17 +00:00
reed@google.com
2ebc10dd12 Revert "Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""
This reverts commit 5f035e90d6dea0139a4f204b634e7b7b3b4976d7.

Reverting because it breaks chrome/blink due to new SkPixelRef constructor arg.

BUG=

Review URL: https://codereview.chromium.org/108993002

git-svn-id: http://skia.googlecode.com/svn/trunk@12551 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 21:43:05 +00:00
reed@google.com
473f0aa2bb Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""
This reverts commit 4174afb18a9746bbad2a06c0ec2d4ad35f72d790.

BUG=

Review URL: https://codereview.chromium.org/108723003

git-svn-id: http://skia.googlecode.com/svn/trunk@12547 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 20:31:45 +00:00
commit-bot@chromium.org
cc63b32eb8 Additional SampleApp tiling options.
Adding some more tiling options (both relative and fixed size):

    kNo_Tiling,
    kAbs_128x128_Tiling,
    kAbs_256x256_Tiling,
    kRel_4x4_Tiling,
    kRel_1x16_Tiling,
    kRel_16x1_Tiling,

R=bungeman@google.com, reed@google.com, fmalita@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/108213004

git-svn-id: http://skia.googlecode.com/svn/trunk@12545 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 20:14:55 +00:00
commit-bot@chromium.org
c2e9db30d3 Fixed a few places where uninitialized memory could have been read
Also added early exit in SkImageFilter's constructor to avoid attempting to deserialize all inputs once a bad input has been found. This avoids hanging if a filter pretends to have 1 billion inputs when that's just an error on the number of inputs read by the filter.

BUG=326206,326197,326229
R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/106943002

git-svn-id: http://skia.googlecode.com/svn/trunk@12544 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 20:14:46 +00:00
commit-bot@chromium.org
7842c817e9 Add GM to test bitmap shaders with basic geometry and bitmap masks.
R=reed@google.com, bsalomon@google.com, rmistry@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/98433004

git-svn-id: http://skia.googlecode.com/svn/trunk@12543 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 20:14:39 +00:00
reed@google.com
5b132b28da Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."
This reverts commit 154e08b2f5904ef533da694e3510befcb9a3f3e2.

revert due to warnings

Review URL: https://codereview.chromium.org/108513003

git-svn-id: http://skia.googlecode.com/svn/trunk@12538 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 18:51:08 +00:00
reed@google.com
3e89524e74 PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.
R=mtklein@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/68973005

git-svn-id: http://skia.googlecode.com/svn/trunk@12537 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 18:41:33 +00:00
commit-bot@chromium.org
332999eabf Fix #define for distance field fonts
R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/108413002

git-svn-id: http://skia.googlecode.com/svn/trunk@12536 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 18:05:03 +00:00
jvanverth@google.com
ed41106ffb Nobody knows the rebaselines I've seen...
git-svn-id: http://skia.googlecode.com/svn/trunk@12535 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 17:59:33 +00:00
robertphillips@google.com
40757703bd Reverting 12528 & 12533 (Implement srcRect and dstRect functionality in SkBitmapSource) due to image differences on N4
https://codereview.chromium.org/108623002/



git-svn-id: http://skia.googlecode.com/svn/trunk@12534 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 17:44:15 +00:00
robertphillips@google.com
86b82767bd Fix Windows compiler warnings/errors
https://codereview.chromium.org/108563002/



git-svn-id: http://skia.googlecode.com/svn/trunk@12533 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 17:08:50 +00:00
commit-bot@chromium.org
5f8ef4f510 Whitespace change to test CQ.
(SkipBuildbotRuns)

BUG=
TBR=borenet@google.com
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/108553002

git-svn-id: http://skia.googlecode.com/svn/trunk@12532 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 17:08:19 +00:00
robertphillips@google.com
ffb68f6753 Generalize valgrind suppressions & a 2 more
https://codereview.chromium.org/107443004/



git-svn-id: http://skia.googlecode.com/svn/trunk@12531 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 17:03:39 +00:00
epoger@google.com
e605b8383a commit remaining pdf-poppler GM results as unreviewed-by-humans
BUG=skia:1884
TBR=vandebo

Review URL: https://codereview.chromium.org/103033004

git-svn-id: http://skia.googlecode.com/svn/trunk@12530 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 17:03:25 +00:00
epoger@google.com
990962bde8 pdf-poppler GM results: updated more still-unreviewed expectations
(The prior revision of these expectations were unreviewed-by-humans anyway)
BUG=skia:1578,skia:1759
TBR=vandebo

Review URL: https://codereview.chromium.org/93883003

git-svn-id: http://skia.googlecode.com/svn/trunk@12529 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 16:35:26 +00:00
commit-bot@chromium.org
094147d522 Implement srcRect and dstRect functionality in SkBitmapSource. This is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource".
This also includes some changes to the xfermodeimagefilter and tileimagefilter GMs to properly handle the CTM. This worked before only because SkBitmapSource was ignoring the CTM. Now that it respects it, we need to give the correct transform. This also means the GMs now work while zoomed.

R=reed@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/106933002

git-svn-id: http://skia.googlecode.com/svn/trunk@12528 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 15:59:03 +00:00
commit-bot@chromium.org
80bd0c995d A simple draw() function in Javascript.
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/102803003

git-svn-id: http://skia.googlecode.com/svn/trunk@12527 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 15:24:52 +00:00
jvanverth@google.com
650660212d Really truly final (?) rebaseline for https://codereview.chromium.org/102683002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12526 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 15:23:15 +00:00
commit-bot@chromium.org
d611864e67 ARM Skia NEON patches - 32 - Xfermode: 1-pixel NEON modeprocs
In some cases, it's easy to provide a NEON version of the 1-pixel modeprocs.
Combined with https://codereview.chromium.org/23724013/ (merged) it allows
up to 35% speed improvement on Xfermodes when aa is non-NULL.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=
R=djsollen@google.com, reed@google.com, mtklein@google.com, luisjoseromeroesclusa@hotmail.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/104883004

git-svn-id: http://skia.googlecode.com/svn/trunk@12525 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 11:32:27 +00:00
skia.committer@gmail.com
726b97a3c4 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12524 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-06 07:02:04 +00:00
senorblanco@chromium.org
899b22ab97 Revert "Implement srcRect and dstRect functionality in SkBitmapSource. This is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource"." until I can sort out the xfermodeimagefilter and tileimagefilter failures.
This reverts commit b26725c8c9755415284c34399e76be098868e01a, aka r12522.

BUG=
TBR=reed@google.com

Review URL: https://codereview.chromium.org/107093005

git-svn-id: http://skia.googlecode.com/svn/trunk@12523 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 23:06:07 +00:00
senorblanco@chromium.org
af35920e6d Implement srcRect and dstRect functionality in SkBitmapSource. This is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource".
Note: I initially implemented this as a fully-generic SkResizeImageFilter, but then I realized that the dstRect should always be transformed by the filter matrix, but that the srcRect should not (since it's specified relative to the dimensions of the original bitmap). Since this would be confusing for someone attempting to use this as a generic resizing filter, I decided to build the functionality into SkBitmapSource instead.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/106933002

git-svn-id: http://skia.googlecode.com/svn/trunk@12522 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-05 22:41:53 +00:00