AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
46eaab3959
skia2/RELEASE_NOTES.txt

1038 lines
45 KiB
Plaintext
Raw Normal View History

Introduce crowdsourced release notes file Bug: skia: Change-Id: I9d76b56ef88ec5caf305deed8bf839443427a260 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229760 Commit-Queue: Heather Miller <hcm@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-07-25 15:33:30 +00:00
Skia Graphics Release Notes
This file includes a list of high level updates for each milestone release.
Reland "Add glGetFloatv and glSamplerParameterf to GrGLInterface." This is a reland of commit 171450a1a0433cbe3e103d9b2163f3c0b9805e25 Original change's description: > Add glGetFloatv and glSamplerParameterf to GrGLInterface. > > > Bug: skia:13036 > Change-Id: Ie15e0c2b0ada468b82bced818eec67c32d70126b > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522100 > Auto-Submit: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Bug: skia:13036 Change-Id: Id594ea5fd68c76703ff61d8414c203facbf28801 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522359 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-03-18 14:36:29 +00:00
Milestone 102
-------------
* Add glGetFloatv and glSamplerParameterf to GrGLInterface.
Remove GrGLCreateNativeInterface Bug: skia:13087 Change-Id: Ibaf7b223631a7282393cb670779a0a769bd0f86a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526301 Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2022-03-31 18:26:29 +00:00
* GrGLCreateNativeInterface is removed. Use GrGLMakeNativeInterface.
Remove GrContextOptions::fSharpenMipmappedTextures It was already a no-op. Bug: skia:13078 Change-Id: I7c7e1a86650ebdbd79bfcc4c1e739a3901345e76 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/527836 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-04-05 20:16:23 +00:00
* GrContextOptions::fSharpenMipmappedTextures is removed. MIP LOD is now always
Reland "Always apply mipmap sharpening on GPU" This is a reland of commit 1aedd5dc117db2d71ba052319132e54975eef6e8 Original change's description: > Always apply mipmap sharpening on GPU > > Bug: skia:13078 > > Change-Id: If459a96eba09fb10e967bc364435f79b83fdc1ec > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522099 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Bug: skia:13078 Change-Id: Ic05b38fc07566f090d609431f2738d64dfdc8a66 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/524218 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-04-01 15:26:15 +00:00
biased on the GPU backend. The CPU backend implementation is modified to match
this behavior.
SkCanvas::kStrict_SrcRectConstraint disables mipmapping. The implementation is inconsistent across CPU and GPU. CPU currently always implements kStrict even when kFast is passed. For mipmapping this means computing a set of levels from the subset, which is an expensive. GPU limits the texture sampling coordinates to the subset in the base level. However, higher level mipmap pixels that map back to a footprint outside the subset are still sampled. So GPU pays a higher shader complexity cost without really providing the benefit of kStrict. We are adding anisotropic filtering, which will not work well with kStrict, and thus will also be disabled by kStrict. Must land after https://chromium-review.googlesource.com/c/chromium/src/+/3571661 Bug: skia:10481 Bug: skia:13078 Bug: skia:13036 Canary-Chromium-CL: 3571661 Change-Id: I011b8698a3f9fafa9b819486873c8ff54df6299e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/527284 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-04-05 13:40:21 +00:00
* Passing SkCanvas::kStrict_SrcRectConstraint disables mipmapping. The old behavior differed
between GPU and CPU. CPU always computed a new set of mipmap based on the subset. GPU restricted
the sampling coordinates to the subset in the base level but upper level pixels that map to
pixels outside the subset in the base level were still used. To get the previous CPU behavior
use SkImage::makeSubset() to make a subset image and draw that. The previous GPU behavior is
similar, though not exactly, equivalent to making a mipmapped image shader from the original
image and applying that to a rectangle.
Disable experimental HW tessellation This should make it so the HW tessellation path renderers are never used; it will always select the atlas or direct fixed-count renderers instead. This CL will give us a good indication of what visual diffs to expect, layout tests to rebase, and any performance regressions. If those are acceptable, then we can proceed with the rest of the code removal. Bug: skia:13263 Change-Id: I273bb231461932047768c1c7233ae4291483bc95 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/533810 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2022-04-27 01:02:09 +00:00
* Fully disable experimental support for HW tessellation shaders.
GrContextOptions::fEnableExperimentalHardwareTessellation is ignored and behaves as if it is
Improve legibility of release note Bug: skia:13263 Change-Id: I1a1bff427964c9d0899a533ce7add1829e980c19 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534566 Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2022-04-27 14:38:33 +00:00
false. The optimized path renderer no longer requires hardware tessellation at all, and
is automatically enabled when drawing to an SkSurface created with MSAA, or when
Disable experimental HW tessellation This should make it so the HW tessellation path renderers are never used; it will always select the atlas or direct fixed-count renderers instead. This CL will give us a good indication of what visual diffs to expect, layout tests to rebase, and any performance regressions. If those are acceptable, then we can proceed with the rest of the code removal. Bug: skia:13263 Change-Id: I273bb231461932047768c1c7233ae4291483bc95 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/533810 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2022-04-27 01:02:09 +00:00
GrContextOptions::fInternalMultisampleCount is set to a non-zero value.
Reland "Add glGetFloatv and glSamplerParameterf to GrGLInterface." This is a reland of commit 171450a1a0433cbe3e103d9b2163f3c0b9805e25 Original change's description: > Add glGetFloatv and glSamplerParameterf to GrGLInterface. > > > Bug: skia:13036 > Change-Id: Ie15e0c2b0ada468b82bced818eec67c32d70126b > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522100 > Auto-Submit: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Bug: skia:13036 Change-Id: Id594ea5fd68c76703ff61d8414c203facbf28801 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522359 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-03-18 14:36:29 +00:00
* * *
Add maxSurfaceSampleCountForColorType to GrContextThreadSafeProxy Change-Id: I7d98b2dff9fbb29bb9709c72679551473078fe0f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/513877 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2022-03-01 14:38:59 +00:00
Milestone 101
-------------
* Add maxSurfaceSampleCountForColorType(SkColorType ct) in GrContextThreadSafeProxy
[includes] Prepare to remove SkColor<->SkImageInfo This breaks out the SkAlphaType and SkColorType enums into their own files, which lets us break the dependency between SkColor and SkImageInfo. It does not yet sever the link, but we plan to land this so as to migrate clients to the new enum files if necessary. This is estimated to save Chrome 230 MB of build size [1] (about 0.1%) http://screen/4dMqPC9rvAyCk6y [1] https://commondatastorage.googleapis.com/chromium-browser-clang/chrome_includes_2022-03-08_182556.html#view=edges&filter=%5Ethird_party%2Fskia%2Finclude%2Fcore%2FSkColor%5C.h%24&sort=asize&reverse=&includer=%5Ethird_party%2Fskia%2Finclude%2Fcore%2FSkColor%5C.h%24&included=&limit=1000 Change-Id: I331d414fe2996632ab11825c1092060ff5fe2ebd Bug: 242216 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/517678 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-03-09 14:50:30 +00:00
* Enums SkAlphaType and SkColorType are broken out into their own header files in include/core/
Add maxSurfaceSampleCountForColorType to GrContextThreadSafeProxy Change-Id: I7d98b2dff9fbb29bb9709c72679551473078fe0f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/513877 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2022-03-01 14:38:59 +00:00
Reland "Add glGetFloatv and glSamplerParameterf to GrGLInterface." This is a reland of commit 171450a1a0433cbe3e103d9b2163f3c0b9805e25 Original change's description: > Add glGetFloatv and glSamplerParameterf to GrGLInterface. > > > Bug: skia:13036 > Change-Id: Ie15e0c2b0ada468b82bced818eec67c32d70126b > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522100 > Auto-Submit: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Bug: skia:13036 Change-Id: Id594ea5fd68c76703ff61d8414c203facbf28801 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522359 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2022-03-18 14:36:29 +00:00
* * *
Upgrade from C++14 to C++17. Change-Id: Ib11a528f41a4a1d5d8eb4c11ff95d88a50f019ff Reviewed-on: https://skia-review.googlesource.com/c/skia/+/500898 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2022-01-27 02:36:51 +00:00
Milestone 100
-------------
* Skia now requires C++17 and the corresponding standard library (or newer).
Remove skstd::string_view entirely. We now use std::string_view throughout. SkStringView.h has been moved to include/private/ and is only used for our C++20/23 compatibility methods (starts_with/ends_with/contains). Change-Id: I961842c6778256a03868e7602d48add34f420763 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/502306 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2022-02-01 20:31:57 +00:00
* Skia on iOS now requires iOS 11 to build; earlier versions of iOS do not support C++17.
Remove references to skstd::optional in Skia. In this CL, Skia has been updated to use std::optional throughout. skstd::optional continues to exist as a synonym for std::optional so that Flutter does not break. The typedef will be removed in a few days, once Flutter rolls into google3 have landed. Original change's description: > Revert "Reland "Remove skstd::optional entirely."" > > This reverts commit d161e2f6ecc802d069a61de71a4e7d9bc6b419cd. > > Reason for revert: Need to wait for Flutter fix to roll into Google3. > > Original change's description: > > Reland "Remove skstd::optional entirely." > > > > This reverts commit 98e51006b9c1c8747ab99d6e2a738f64f5fc4f3b. > > > > Flutter fix: https://github.com/flutter/engine/pull/31193 > > > > Original change's description: > > > Revert "Remove skstd::optional entirely." > > > > > > This reverts commit 17d0fc087ced7f1deeea92de6404ce48f8433698. > > > > > > Reason for revert: flutter still uses the skstd class > > > > > > Original change's description: > > > > Remove skstd::optional entirely. > > > > > > > > Skia now uses C++17's std::optional. > > > > > > > > Change-Id: I387069589baaefadd25e25bcec3f4cc6ee6fd090 > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/501477 > > > > Reviewed-by: Ben Wagner <bungeman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > Change-Id: I2c001588007640ac7b8c9f0760038b46c220a07e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/502702 > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Change-Id: Ia0cd41eda845b02f518c501a23293d344756a4eb > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/502703 > > Reviewed-by: Brian Osman <brianosman@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > Commit-Queue: John Stiles <johnstiles@google.com> > > Change-Id: I8f89412292ba5dfe955c3f44c403c3c232cdad2b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/503336 > Auto-Submit: Brian Osman <brianosman@google.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Change-Id: I28ef3f543bf74de72645485698affb54921a50f0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/504176 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-02-03 22:08:53 +00:00
* The skstd::string_view and skstd::optional Skia classes have been replaced with the C++17 native
std::string_view and std::optional.
Reland "Add SkSurface resolve function." This is a reland of d921f21fbcc59dbc1fd4e4831a3b3c2ba5b7d469 Original change's description: > Add SkSurface resolve function. > > This will insert a resolve msaa call into the stream of commands for > the SkSurface. This is mostly useful for cases when a client wraps the > resolve texture but has Skia draw with MSAA, and the client wants to > make sure Skia resolves to their wrapped texture. > > Bug: chromium:1292418 > Change-Id: I6eddae967136716b9215fcd96e7d77a2457efdf2 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/503340 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> Bug: chromium:1292418 Change-Id: I810b5618092c560f5bba900024b3b8c0c88baea9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/503717 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2022-02-03 15:44:00 +00:00
* Added SkSurface::resolveMSAA api to force Skia to resolve MSAA draws. Useful for when
Remove references to skstd::optional in Skia. In this CL, Skia has been updated to use std::optional throughout. skstd::optional continues to exist as a synonym for std::optional so that Flutter does not break. The typedef will be removed in a few days, once Flutter rolls into google3 have landed. Original change's description: > Revert "Reland "Remove skstd::optional entirely."" > > This reverts commit d161e2f6ecc802d069a61de71a4e7d9bc6b419cd. > > Reason for revert: Need to wait for Flutter fix to roll into Google3. > > Original change's description: > > Reland "Remove skstd::optional entirely." > > > > This reverts commit 98e51006b9c1c8747ab99d6e2a738f64f5fc4f3b. > > > > Flutter fix: https://github.com/flutter/engine/pull/31193 > > > > Original change's description: > > > Revert "Remove skstd::optional entirely." > > > > > > This reverts commit 17d0fc087ced7f1deeea92de6404ce48f8433698. > > > > > > Reason for revert: flutter still uses the skstd class > > > > > > Original change's description: > > > > Remove skstd::optional entirely. > > > > > > > > Skia now uses C++17's std::optional. > > > > > > > > Change-Id: I387069589baaefadd25e25bcec3f4cc6ee6fd090 > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/501477 > > > > Reviewed-by: Ben Wagner <bungeman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > Change-Id: I2c001588007640ac7b8c9f0760038b46c220a07e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/502702 > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Change-Id: Ia0cd41eda845b02f518c501a23293d344756a4eb > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/502703 > > Reviewed-by: Brian Osman <brianosman@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > Commit-Queue: John Stiles <johnstiles@google.com> > > Change-Id: I8f89412292ba5dfe955c3f44c403c3c232cdad2b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/503336 > Auto-Submit: Brian Osman <brianosman@google.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Change-Id: I28ef3f543bf74de72645485698affb54921a50f0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/504176 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-02-03 22:08:53 +00:00
Skia wraps a client's texture as the resolve target.
Remove isOpaque from SkRuntimeEffect::makeShader signature Bug: skia:12643 Change-Id: Id5eecb3445082e747def8c87f99a16552857af3f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/506462 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-02-09 19:57:07 +00:00
* All of the `makeShader` functions associated with `SkRuntimeEffect` no longer take an
`isOpaque` parameter. These functions will now make a best effort to determine if your
shader always produces opaque output, and optimize accordingly. If you definitely want your
shader to produce opaque output, do so in the shader's SkSL code. This can be done by adjusting
any `return` statement in your shader with a swizzle: `return color.rgb1;`.
https://review.skia.org/506462
Add SkRSXform to SK_API Change-Id: I9ee142f949e644dcd06f359bb6838b5b4f04ec21 Bug: skia:12990 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/513736 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-02-28 13:27:33 +00:00
* SkRSXform is now exported to DLL/.so files.
Upgrade from C++14 to C++17. Change-Id: Ib11a528f41a4a1d5d8eb4c11ff95d88a50f019ff Reviewed-on: https://skia-review.googlesource.com/c/skia/+/500898 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2022-01-27 02:36:51 +00:00
* * *
SkSL: Add color transform intrinsics These convert a color between the working color space and a known, useful space (linear TF, sRGB gamut). Bug: skia:10479 Change-Id: I3308e691beeaca5120ed0c2e30cf08661caa3684 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/481416 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-07 21:05:39 +00:00
Milestone 99
------------
* Added two new intrinsic functions to SkSL for use in runtime effects:
vec3 toLinearSrgb(vec3 color)
vec3 fromLinearSrgb(vec3 color)
These convert RGB color values between the working color space (the color space of the
destination surface) and a known, fixed color space. `toLinearSrgb` converts a color to the
sRGB color gamut, with a linear transfer function. `fromLinearSrgb` converts a color from that
same color space. These are helpful for effects that need to work in a specific color space, or
want to apply effects (like lighting) that work best in a linear color space.
Note that if the destination surface has no color space (color space is `nullptr`), these
intrinsics will do no conversion, and return the input color unchanged.
https://review.skia.org/481416
Add support for multiple child nodes to SkImageFilters::RuntimeShader Bug: skia:12766 Change-Id: I9dfe07a71961ab952c1593b9cc68c61191fbc13c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489536 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-28 19:17:28 +00:00
* Added a new variant of SkImageFilters::RuntimeShader that supports multiple child nodes.
https://review.skia.org/489536
Add SkRSXform to SK_API Change-Id: I9ee142f949e644dcd06f359bb6838b5b4f04ec21 Bug: skia:12990 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/513736 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-02-28 13:27:33 +00:00
* Add the ability to specify palette overrides in SkFontArguments. Implemented
Support font palette overrides through SkFontArguments Co-authored with Ben Wagner, bungeman@google.com. Similar to how we allow configuration of variable font configurations, provide additional SkFontArguments to select a base palette and a set of potentially sparse color overrides. This is required for implementing CSS font-palette. Modify the more_samples-glyf_colr_1.ttf to have two additional palettes, and two additional test glyphs, one that draws with COLRv0 logic, one that draws with COLRv1 logic and has a foreground palette index dot in the middle. See [1] & [2] for the additions to the test font. Add a GM which tests this on the SkFontMgr_custom using makeClone() and makeFromStreamArgs(). The test displays the two glyphs in default palette on the left, then with palette overrides (as in the title of the test) on the right. The first row uses a typeface created with makeFromStreamArgs(), the second uses one created with makeClone(). [1] https://github.com/googlefonts/color-fonts/pull/91 [2] https://github.com/googlefonts/color-fonts/pull/92 Bug: skia:12730, chromium:1170794 Cq-Include-Trybots: luci.skia.skia.primary:Test-Android-Clang-GalaxyS20-GPU-MaliG77-arm64-Release-All-Android_NativeFonts,Test-Debian10-Clang-GCE-CPU-AVX2-x86_64-Debug-All-NativeFonts Change-Id: Ia1334f069240edc78fd4791969914e8a6f4fbaf9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/479616 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2022-02-17 10:37:49 +00:00
for the FreeType-backed SkFontMgrs.
SkSL: Add color transform intrinsics These convert a color between the working color space and a known, useful space (linear TF, sRGB gamut). Bug: skia:10479 Change-Id: I3308e691beeaca5120ed0c2e30cf08661caa3684 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/481416 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-07 21:05:39 +00:00
* * *
Add #ifdefs to GrBackendSemaphore to guard includes and methods Change-Id: Ia969cda749fe15df645300248e0f17d3e4b77215 Bug: skia:12584 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/466438 Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-11-05 13:41:03 +00:00
Milestone 98
------------
* The following functions and methods are not defined in SkSurface when SK_SUPPORT_GPU is 0:
MakeFromBackendTexture, MakeFromBackendRenderTarget, MakeRenderTarget,
getBackendTexture, getBackendRenderTarget, replaceBackendTexture. flush() with parameters
was removed as well. These were all no-ops anyway when just the CPU backend was compiled in
(noting that flush() and flushAndSubmit() are still no-ops on the CPU backend).
* GrBackendSemaphore only includes methods that match the GPU backend that Skia was compiled for.
For example, initVulkan and vkSemaphore are not defined unless the Vulkan backend is compiled
into Skia.
Limit surfaces/images to 2GB in size The CPU blitters use signed 32-bit offsets when gathering source pixels, so any image larger than that can't be fully indexed. Instead, we'd wrap around and sample from invalid memory. This does put a new (smaller) limit on valid image sizes, but it seems unlikely to impact any client. Bug: chromium:1264705 Change-Id: I21b088c11b49e6410b1f237cbfb6b1639cb22ca0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/471764 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-11-15 20:25:37 +00:00
* Surfaces and images are now limited to just under 2GB of total size. Previously, larger images
could be created, but the CPU backend would fail to index them correctly.
Remove drawPatch/Vertices helpers that don't take SkBlendMode Bug: skia:12662 Change-Id: Ic18220668a4f87e7340a53b3f191887a7a016a04 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473141 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-11-18 15:14:06 +00:00
* SkCanvas::drawVertices and SkCanvas::drawPatch variants that did not take SkBlendMode are
removed.
Reland "Add public API support for SkImageFilters::RuntimeShader" This new image filter constructor enables SkRuntimeEffects to be used as shaders within the ImageFilter DAG. The shader is created lazily using the SkRuntimeShaderBuilder enabling the resulting shader to consume the previous stage of the ImageFilter graph. This relands commit ad9d774c1fd570c27c85559bc350a606042fd92c after fixing the threading issue found by the TSAN bot. Change-Id: I06dc4cf6a304b14804c55531a5bc3f2afa34e219 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/477156 Auto-Submit: Derek Sollenberger <djsollen@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-11-29 21:41:31 +00:00
* SkImageFilters::RuntimeShader is a new public API that enables adding RuntimeShaderEffects into
image filter graph.
Add SkImage::makeRawShader to RELEASE_NOTES Change-Id: I34063f4d84472ddae57b244ab424d859dd3bcf00 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/480418 Auto-Submit: Brian Osman <brianosman@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
2021-12-06 18:15:29 +00:00
* SkImage::makeRawShader is a new public API that creates "raw" image shaders. makeRawShader
functions like SkImage::makeShader, but for images that contain non-color data. This includes
images encoding things like normals, material properties (eg roughness), heightmaps, or any
other purely mathematical data that happens to be stored in an image. These types of images are
useful with some programmable shaders (ie SkRuntimeEffect).
Raw image shaders work like regular image shaders (including filtering and tiling), with a few
major differences:
- No color space transformation is ever applied (the color space of the image is ignored).
- Images with an alpha type of kUnpremul are not automatically premultiplied.
- Bicubic filtering is not supported. If SkSamplingOptions::useCubic is true, these factories
will return nullptr.
Remove canvas marker stack, marked matrices, etc... This entire API existed, but was unused (no longer connected to drawVertices or runtime effects). In theory, we could further simplify some of the matrix providers, but more importantly - I have serious doubts about the correctness of localToDeviceHitsPixelsCenters for most of them. Change-Id: If5af182015dd96e5ed3353a117223e8dbbe17097 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/481683 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-08 21:12:32 +00:00
* Removed SkCanvas::markCTM and SkCanvas::findMarkedCTM. These were created to be used with other
features that have since been deleted, so they served no purpose.
Add MVP implementation of JPEGXL decoder. Change-Id: I90140348eeb87c849a857a12008c201efc9e328d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/482596 Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-02-02 13:45:33 +00:00
* Added limited JPEGXL support.
Reland "Add public API support for SkImageFilters::RuntimeShader" This new image filter constructor enables SkRuntimeEffects to be used as shaders within the ImageFilter DAG. The shader is created lazily using the SkRuntimeShaderBuilder enabling the resulting shader to consume the previous stage of the ImageFilter graph. This relands commit ad9d774c1fd570c27c85559bc350a606042fd92c after fixing the threading issue found by the TSAN bot. Change-Id: I06dc4cf6a304b14804c55531a5bc3f2afa34e219 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/477156 Auto-Submit: Derek Sollenberger <djsollen@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-11-29 21:41:31 +00:00
* * *
Add #ifdefs to GrBackendSemaphore to guard includes and methods Change-Id: Ia969cda749fe15df645300248e0f17d3e4b77215 Bug: skia:12584 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/466438 Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-11-05 13:41:03 +00:00
Add support for vk drm format modifiers. On linux we need to support drm format modifiers on vulkan images. When we have a modifier it can restrict the allowed usages/features of the VkImage. The current use case we have for images coming into skia that have these modifiers are from video decoders. All these images are only used as sampled images in draws and they have no filtering applied. Therefore, for now, instead of tracking all format and modifier pairs to know what is supported, we internally set these images to be external which already restricts their use to basic in shader sampling. Additionally in chrome, all these images are coming in ycbcr conversions already which we treat as external. Bug: skia:12336 Change-Id: I59a564f937f49a6d906efe954b24cebe5c7470ff Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441298 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-10-20 16:03:54 +00:00
Milestone 97
------------
* Added basic support for vulkan DRM modifiers. All of these are treated as read only textures
internally (versus querying specific modifier support). Clients can either pass a flag to Vulkan
GrBackendFormat to say it uses modifiers or pass the VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT
to a GrBackendTexture via the GrVkImageInfo struct.
Remove GPU-related calls from SkImage.h when !SK_SUPPORT_GPU Change-Id: Icf6f45069b078f7936cfa08224fd8796d8c283b4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/464122 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-10-28 11:31:32 +00:00
* The following functions and methods are not defined in SkImage when SK_SUPPORT_GPU is 0:
MakeTextureFromCompressed, MakeFromTexture, MakeFromCompressedTexture,
MakeCrossContextFromPixmap, MakeFromAdoptedTexture, MakeFromYUVATextures,
MakeFromYUVAPixmaps, MakePromiseTexture, MakePromiseYUVATexture, MakeBackendTextureFromSkImage,
flush, flushAndSubmit, getBackendTexture, makeTextureImage.
These were all no-ops anyway when just the CPU backend was compiled in.
Add #ifdefs to GrBackendSemaphore to guard includes and methods Change-Id: Ia969cda749fe15df645300248e0f17d3e4b77215 Bug: skia:12584 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/466438 Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-11-05 13:41:03 +00:00
* * *
Add support for vk drm format modifiers. On linux we need to support drm format modifiers on vulkan images. When we have a modifier it can restrict the allowed usages/features of the VkImage. The current use case we have for images coming into skia that have these modifiers are from video decoders. All these images are only used as sampled images in draws and they have no filtering applied. Therefore, for now, instead of tracking all format and modifier pairs to know what is supported, we internally set these images to be external which already restricts their use to basic in shader sampling. Additionally in chrome, all these images are coming in ycbcr conversions already which we treat as external. Bug: skia:12336 Change-Id: I59a564f937f49a6d906efe954b24cebe5c7470ff Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441298 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-10-20 16:03:54 +00:00
Add release note for SkRuntimeEffect change in Milestone 96. Change-Id: I3a159fb4f96a4f8071efb8e88bbe097e0fedd88f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457296 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-10-08 13:53:43 +00:00
Milestone 96
------------
* SkRuntimeEffect no longer clamps the RGB values of an effect's output to the range 0..A.
This makes it easier to use a hierarchy of SkSL shaders where intermediate values do not
represent colors but are, for example, non-color inputs to a lighting model.
http://review.skia.org/452558
Add support for vk drm format modifiers. On linux we need to support drm format modifiers on vulkan images. When we have a modifier it can restrict the allowed usages/features of the VkImage. The current use case we have for images coming into skia that have these modifiers are from video decoders. All these images are only used as sampled images in draws and they have no filtering applied. Therefore, for now, instead of tracking all format and modifier pairs to know what is supported, we internally set these images to be external which already restricts their use to basic in shader sampling. Additionally in chrome, all these images are coming in ycbcr conversions already which we treat as external. Bug: skia:12336 Change-Id: I59a564f937f49a6d906efe954b24cebe5c7470ff Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441298 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-10-20 16:03:54 +00:00
* * *
Update supported iOS to 11 Skia bots build and test on iOS with a minimum of iOS 11. Chrome currently requires 13 and other internal users are at minimum 11. While Skia may currently build with older minimum targets (currently back to iOS 8, though shortly will require iOS 9) it is not tested on versions older than 11. Change-Id: I34305438caccd4f990904a4cc4dcdff2c64b6cc5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/447717 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2021-09-10 18:03:46 +00:00
Milestone 95
------------
* Minimum supported iOS raised from 8 to 11. Skia may build back to iOS 9 but versions older
than 11 are not tested. Community contributions to support versions 9 and 10 of iOS may be
considered, but they may not be complex as they cannot be tested.
update release notes Change-Id: Ida17b9d3da4d3a6489f62d2959379747a671fbab Docs-Preview: https://skia.org/?cl=428982 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428982 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2021-07-16 15:00:59 +00:00
* * *
Milestone 94
------------
Add release note on Metal resource tracking change Bug: skia:12253 Change-Id: Iaf7cb2f2f3ee9310cc5edc8425d7123d11857055 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/438537 Commit-Queue: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> Auto-Submit: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-08-11 14:37:22 +00:00
* Metal backend has been changed to track command buffer resources manually
rather than using retained resources.
https://review.skia.org/432878
Rename/simplify SkCanvas::resetClip() and make recordable AndroidFramework uses both their own custom display list (which could handle resetClip with android-side changes) AND conventional picture recording. In order for replace op emulation to work when they have been recorded into a picture, we need to make it virtual and supported in SkPicture. This also renames the API to ResetClip() from ReplaceClip() and does not have any additional arguments. Based on AF's usage pattern, it only n needs to reset the clip to the surface bounds or the device clip restriction, it seems best to reduce the API as much as possible before it's adopted. Bug: skia:10209 Change-Id: I37adb097c84a642f4254b8c0f9d4c7fea8d9abdf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430897 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-07-23 15:48:34 +00:00
* Added virtual onResetClip() to SkCanvas for Android Framework, to emulate the soon-to-be-removed
expanding clip ops guarded by SK_SUPPORT_DEPRECATED_CLIPOPS.
https://review.skia.org/430897
Remove SkMatrix44 Change-Id: I4b33603f7318bc5881929b50258bf166c8a5cb04 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420818 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2021-06-23 15:27:19 +00:00
Remove SK_SUPPORT_DEPRECATED_CLIPOPS and expanding clip op defs Bug: skia:10209 Change-Id: I72639b7e768742dcdec810a5a714ce21ff0f6e0a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/436565 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-08-06 15:19:26 +00:00
* Removed SK_SUPPORT_DEPRECATED_CLIPOPS build flag. Clips can only be intersect and difference.
https://review.skia.org/436565
SkSL: Allow invoking children (shaders, etc) like functions Previously, you would declare child objects (shaders, colorFilters, etc.) and "sample" them like this: uniform shader input; uniform colorFilter filter; half4 main(float2 coord) { half4 inColor = sample(input, coord); return sample(filter, inColor); } With the new syntax, those child objects become directly callable, reflecting the way that Skia assembles all parts of the paint (as functions) in the overall fragment shader: uniform shader input; uniform colorFilter filter; half4 main(float2 coord) { half4 inColor = input(coord); return filter(inColor); } Bug: skia:12302 Change-Id: Ia12351964dc5d2300660187933188e738671cd83 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/436517 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2021-08-04 15:34:16 +00:00
* There is a new syntax for invoking (sampling) child effects in SkSL. Previously, children
(shaders, colorFilters, blenders) were invoked using different overloads of `sample`. That
Convert internal SkSL to use .eval() Also update RELEASE_NOTES to describe new syntax. Change-Id: I2666551b98f80b61ae3a48c92a9e306cdc7242b0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/444735 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2021-09-02 13:26:27 +00:00
syntax is deprecated (but still supported). Now, the child behaves like an object, with a method
name `eval`. The arguments to these `eval` methods are the same as the arguments in the old
`sample` intrinsics. For example:
// Old syntax:
sample(shader, xy)
sample(colorFilter, color)
sample(blender, srcColor, dstColor)
// New syntax:
shader.eval(xy)
colorFilter.eval(color)
blender.eval(srcColor, dstColor)
https://review.skia.org/444735
SkSL: Allow invoking children (shaders, etc) like functions Previously, you would declare child objects (shaders, colorFilters, etc.) and "sample" them like this: uniform shader input; uniform colorFilter filter; half4 main(float2 coord) { half4 inColor = sample(input, coord); return sample(filter, inColor); } With the new syntax, those child objects become directly callable, reflecting the way that Skia assembles all parts of the paint (as functions) in the overall fragment shader: uniform shader input; uniform colorFilter filter; half4 main(float2 coord) { half4 inColor = input(coord); return filter(inColor); } Bug: skia:12302 Change-Id: Ia12351964dc5d2300660187933188e738671cd83 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/436517 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2021-08-04 15:34:16 +00:00
doc: cleanup release notes No-try: true Change-Id: Ice2803974c7451aff200c75a609414cf9f0a17fe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245374 Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-01 19:15:36 +00:00
* * *
Update release notes for m92 cut, m93 begin Change-Id: I216fa16d6dfd57214def9099cb3fa1b5cb281f23 Docs-Preview: https://skia.org/?cl=411299 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/411299 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2021-05-21 17:20:02 +00:00
Milestone 93
------------
Remove SkPaint::getHash This was a particularly bad hash (A == B didn't imply hash(A) == hash(B)). It was also entirely unused. Change-Id: Id923bf1035effce04e12b1cc01d1c6aa4d11fdb6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/419336 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Reed <reed@google.com>
2021-06-17 13:36:58 +00:00
* Removed SkPaint::getHash
https://review.skia.org/419336
Update release notes for m92 cut, m93 begin Change-Id: I216fa16d6dfd57214def9099cb3fa1b5cb281f23 Docs-Preview: https://skia.org/?cl=411299 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/411299 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2021-05-21 17:20:02 +00:00
Remove SkShaders::Lerp It's entirely unused, and trivial for clients to create with SkSL. Change-Id: I197986232d3706f5af3a197f0fb8e744e1009e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/419796 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Reed <reed@google.com>
2021-06-18 14:41:23 +00:00
* Removed SkShaders::Lerp. It was unused (and easy to replicate with SkRuntimeEffect).
https://review.skia.org/419796
Enable reduceOpsTaskSplitting by default Chrome does not rely on the default – this option is under a finch trial named "ReduceOpsTaskSplitting." See crbug.com/1210578. Android does not rely on the default – the flag is controlled by a property named "renderthread.skia.reduceopstasksplitting", and enabled by default. See b/183612348. Flutter does not rely on the default – they explicitly disable the option. See https://github.com/flutter/engine/pull/26568. Our tools do not rely on the default – they enable the flag unless the user passes --dontReduceOpsTaskSplitting on command line. Our bots run with the flag enabled except the NUC5PPYH, for the sake of coverage. The flag has no effect for Adreno 620 and 640, on drivers older than v571, due to a driver bug. Bug: skia:10877 Change-Id: Iafc84f3463194f0cf6cf135b2be05ec8eb08e446 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/419836 Auto-Submit: Adlai Holler <adlai@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-06-21 15:11:44 +00:00
* The default value of GrContextOptions::fReduceOpsTaskSplitting is now enabled.
https://review.skia.org/419836
update release notes Change-Id: Ida17b9d3da4d3a6489f62d2959379747a671fbab Docs-Preview: https://skia.org/?cl=428982 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428982 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2021-07-16 15:00:59 +00:00
* Removed SkMatrix44
Update release notes for m92 cut, m93 begin Change-Id: I216fa16d6dfd57214def9099cb3fa1b5cb281f23 Docs-Preview: https://skia.org/?cl=411299 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/411299 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2021-05-21 17:20:02 +00:00
* * *
update release notes for M91 branch Change-Id: I5bddb5aa3543953cf5fb6090a247359ab69a239c Docs-Preview: https://skia.org/docs/user/release/release_notes?cl=395097 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/395097 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2021-04-09 18:35:53 +00:00
Milestone 92
------------
Implement computeFastBounds for PathEffects Makes computeFastBounds not part of the public API, it's only accessible to subclasses of SkPathEffect, GrStyle, and SkPaint. Subclasses can invoke it other path effects using SkPathEffectPriv::ComputeFastBounds. Changes the internal function to bool computeFastBounds(SkRect* bounds) const; Subclasses of SkPathEffect must implement this, and can choose to return false when fast bounds aren't computable. Provides implementations of computeFastBounds() for path effects bundled with Skia. Bug: skia:11974 Change-Id: I545ccf99b4e669d3af9df13acfac28573306fab8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/406140 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Reed <reed@google.com>
2021-05-11 15:39:36 +00:00
* Hides SkPathEffect::computeFastBounds() from public API; external subclasses of SkPathEffect
must implement onComputeFastBounds() but can return false to signal it's not computable.
https://review.skia.org/406140
Add mapRect function and RectToRect constructor to SkM44 The SkM44::RectToRect function matches the semantics of SkMatrix::RectToRect(kFill_ScaleToFit). No other ScaleToFit variants are ported over to SkM44. skottie uses some instances of kCenter_ScaleToFit so that functionality may need to be added in the future (in SkM44 or in skottie). There are no current usages of the kStart and kEnd_ScaleToFit semantics. The SkM44::mapRect() function is implemented to correspond to the SkMatrix::mapRect() that returns the mapped rect (instead of modifying a pointer) and always has ApplyPerspectiveClip::kYes. This was chosen to keep its behavior simple and because perspective clipping is almost always the right thing to do. In the new implementation there is no longer a performance cliff to worry about (see below). For the timebeing mapRect is hidden behind SkMatrixPriv::MapRect(). Performance: I added benchmarks for mapRect() on SkM44 and SkMatrix that use the same matrices to get a fair comparison on their different specializations. SkMatrix has a very efficient mapRect when it's scale+translate or simpler, then another impl. for affine matrices, and then falls back to SkPath clipping when there's perspective. On the other hand, SkM44 only has 2 modes: affine and perspective. On my desktop, with a Ryzen 9 3900X, here are the times for 100,000 calls to mapRect for different types of matrices: SkMatrix SkM44 scale+translate 0.35 ms 0.42 ms rotate 1.70 ms 0.42 ms perspective 63.90 ms 0.66 ms clipped-perspective 138.0 ms 0.96 ms To summarize, the SkM44::mapRect is almost as fast as the s+t specialization in SkMatrix, but for all non-perspective matrices. For perspective matrices it's only 2x slower than that specialization when no vertices are clipped, and still almost 2x faster than the affine specialization when vertices are clipped (and 100x faster than falling back to SkPath). Given that, there's the open question of whether or not keeping an affine specialization is worth it for SkM44's code size. Bug: skia:11720 Change-Id: I6771956729ed64f3b287a9de503513375c9f42a0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/402957 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com>
2021-05-05 13:05:10 +00:00
* Add SkM44::RectToRect constructor (SkM44's equivalent to SkMatrix::RectToRect)
https://review.skia.org/402957
Remove Metal support on older OSes. SkSL now requires the array<> feature in MSL, so practically we no longer support OS versions older than iOS 10.0 and MacOS 10.13. And because of the shader compilation issues we are no longer testing nor can we recommend running on MacOS 10.13, so this minimum version is bumped up to MacOS 10.14. Bug: skia:10777 Change-Id: I76d9eab4baa1631656d4b10b9ba6c126866b4530 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/401816 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-04-27 16:23:53 +00:00
* Metal support has been removed for versions of iOS older than 10.0 and MacOS older than 10.14.
https://review.skia.org/401816
Remove custom SkVertices data and runtime effect `varying` support This was an experimental feature. It worked (but only the GPU backend). It was never adopted or used by anyone, to my knowledge. It's a large amount of code, and a strange corner of SkSL for users to stumble into. Bug: skia:10680 Change-Id: I0dda0364bce7dbffa58c32de4c7801ec2a6bc42e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/398222 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-04-19 15:15:24 +00:00
* Removed custom attributes from SkVertices and the corresponding `varying` feature from
SkRuntimeEffect.
https://review.skia.org/398222
update release notes for M91 branch Change-Id: I5bddb5aa3543953cf5fb6090a247359ab69a239c Docs-Preview: https://skia.org/docs/user/release/release_notes?cl=395097 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/395097 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2021-04-09 18:35:53 +00:00
Delete mixed samples Mixed samples is no longer relevant for Ganesh. DMSAA and the new Ganesh architecture both rely on full MSAA, and any platform where mixed samples is supported will ultimately not use the old architecture. Change-Id: I5acc745010e090ef26310d92ec6240be2cd494cf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/399837 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-04-22 18:57:28 +00:00
* Dropped support for mixed samples. Mixed samples is no longer relevant for Ganesh. DMSAA and the
new Ganesh architecture both rely on full MSAA, and any platform where mixed samples is
supported will ultimately not use the old architecture.
Make the generic SkRuntimeEffect::Make factories private All clients have been moved to the stage-specific factories. The old flexible factories are still used internally (for now), but this prevents any new usage from creeping in accidentally. Bug: skia:11813 Change-Id: I6c34dfd19b396541f9a0e2f9eab8a51591ed8b70 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/402156 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-04-28 13:41:06 +00:00
* SkRuntimeEffect::Make has been removed. It is replaced by MakeForShader and MakeForColorFilter.
These functions do stricter error checking on the SkSL, to ensure it is valid for a particular
stage of the Skia pipeline.
https://review.skia.org/402156
update release notes for M91 branch Change-Id: I5bddb5aa3543953cf5fb6090a247359ab69a239c Docs-Preview: https://skia.org/docs/user/release/release_notes?cl=395097 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/395097 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2021-04-09 18:35:53 +00:00
* * *
update release notes Change-Id: If6157c345b0329665ac385de23e42d4cd7331cbc Docs-Preview: https://skia.org/?cl=376847 TBR Joe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/376847 Reviewed-by: Heather Miller <hcm@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2021-02-26 21:10:28 +00:00
Milestone 91
------------
Made SkSL DSL into public API In addition to the unsurprising changes to eliminate references to src/, we also had to tighten up some C++17-isms as they are not permitted in public headers. Change-Id: Ie5005a33d7a135e69fb66beca5e7a5f960dbd453 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/378496 Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-04 19:30:25 +00:00
* The SkSL DSL API has been moved into public headers, although it is still under active
development and isn't quite ready for prime time yet.
https://review.skia.org/378496
update release notes Change-Id: If6157c345b0329665ac385de23e42d4cd7331cbc Docs-Preview: https://skia.org/?cl=376847 TBR Joe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/376847 Reviewed-by: Heather Miller <hcm@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2021-02-26 21:10:28 +00:00
Remove NVPR Bug: skia:11760 Change-Id: Ie0fc1aaa3120b37b1d452fdc9a8b5cb91b6ffe1e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/386559 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-03-18 17:32:56 +00:00
* Skia's GPU backend no longer supports NVPR. Our more recent path renderers are more
performant and are not limited to nVidia hardware.
Add integer uniforms to runtime effects Bug: skia:11803 Change-Id: I925f14be282b96355721986de6049090b35adf3d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/391856 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2021-04-01 13:56:07 +00:00
* SkRuntimeEffect now supports uniforms of type int, int2, int3, and int4. Per the OpenGL ES
Shading Language Version 1.00 specification, there are few guarantees about the representation
or range of integral types, and operations that assume integral representation (eg, bitwise),
are not supported.
https://review.skia.org/391856
Require that runtime effect child variables are 'uniform' Bug: skia:11374 Change-Id: I63d605eabbe514a0469d00d8a671969874f3edd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/393081 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-04-06 18:28:07 +00:00
* SkRuntimeEffect requires that 'shader' variables be declared as 'uniform'. The deprecated
syntax of 'in shader' is no longer supported.
https://review.skia.org/393081
update release notes Change-Id: If6157c345b0329665ac385de23e42d4cd7331cbc Docs-Preview: https://skia.org/?cl=376847 TBR Joe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/376847 Reviewed-by: Heather Miller <hcm@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2021-02-26 21:10:28 +00:00
* * *
update release notes for m89 Change-Id: Ie23baa11be7c52f969676512efabc44648c23dc4 Docs-Preview: https://skia.org/?cl=354663 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354663 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2021-01-15 19:19:53 +00:00
Milestone 90
------------
Reland "Remove ARC from tools lib." This is a reland of 4c4c80fa12649e2512e4601d0a19f19f8907d6ca Original change's description: > Remove ARC from tools lib. > > Trying this in baby steps to manage leaks better. > > Change-Id: Id8597ba236c752bcbf1c7ec94f6c1021e636d547 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/372556 > Commit-Queue: Jim Van Verth <jvanverth@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Reviewed-by: Adlai Holler <adlai@google.com> Change-Id: Ib5c949ee9e8ac9f47de1991297aec718f3185424 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/373616 Reviewed-by: Adlai Holler <adlai@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-02-22 14:41:27 +00:00
* Renamed use of sk_cf_obj in external Metal types to sk_cfp.
https://review.skia.org/372556
Remove GrDirectContext::ComputeImageSize. Use SkImage::textureSize. Bug: skia:11208 Change-Id: Ie5f56b6d168ab43189be75bb2be60b315e724569 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/371958 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-02-18 14:02:14 +00:00
* GrDirectContext::ComputeImageSize() is removed. Use SkImage::textureSize() instead.
rm pow2 arg to GrDirectContext::ComputeImagesize Bug: skia:11208 Change-Id: I573be306e168adbd1c521626b2d1e4a303f8d5d9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/368621 Auto-Submit: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-02-10 22:09:02 +00:00
https://review.skia.org/368621
Remove GrDirectContext::ComputeImageSize. Use SkImage::textureSize. Bug: skia:11208 Change-Id: Ie5f56b6d168ab43189be75bb2be60b315e724569 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/371958 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-02-18 14:02:14 +00:00
https://review.skia.org/369317
https://review.skia.org/371958
update release notes for m89 Change-Id: Ie23baa11be7c52f969676512efabc44648c23dc4 Docs-Preview: https://skia.org/?cl=354663 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354663 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2021-01-15 19:19:53 +00:00
Reland "Remove deprecated SkImageFilter::MakeMatrixFilter" This reverts commit fde740c7f26e84a9398f3c50322ec082bc81daa1. Reason for revert: g3 updated so roll won't be stopped Original change's description: > Revert "Remove deprecated SkImageFilter::MakeMatrixFilter" > > This reverts commit ed63d4f177f55bf933dd6b45dcfbc99765533309. > > Reason for revert: Breaking G3 roll? > > Original change's description: > > Remove deprecated SkImageFilter::MakeMatrixFilter > > > > The equivalent functionality is available in > > include/effects/SkImageFilters.h via SkImageFilters::MatrixTransform. > > > > Bug: skia:11230 > > Change-Id: I77b78d508d653a32c913a7599f1004ab634e3e6d > > Docs-Preview: https://skia.org/?cl=361497 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/361497 > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > Commit-Queue: Mike Reed <reed@google.com> > > Auto-Submit: Michael Ludwig <michaelludwig@google.com> > > Reviewed-by: Mike Reed <reed@google.com> > > TBR=reed@google.com,michaelludwig@google.com > > Change-Id: I60a98a1ca9a42db6bfc5796cf4df69042571161e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:11230 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/364097 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> TBR=robertphillips@google.com,reed@google.com,michaelludwig@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:11230 Change-Id: I76ef4d762151475c498e8cf9392bc2191d84fe1a Docs-Preview: https://skia.org/?cl=366318 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/366318 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-02-04 17:32:33 +00:00
* Remove SkImageFilter::MakeMatrixFilter as it was unused and replaced with
SkImageFilters::MatrixTransform.
https://review.skia.org/366318
Particle refactor: Only have one code string, uniforms, etc. Leverage the field visitor to temporarily support effects with the old JSON layout. See also: https://skia-review.googlesource.com/c/buildbot/+/363784 Change-Id: Ifab128172089fe9e570be96d7067c6c9d25aae9b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363878 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2021-01-29 19:32:09 +00:00
* Refactored particle system to use a single code string containing both Effect and Particle code.
Uniform APIs are now shared for all program entry points, and no longer prefixed with 'Effect'
or 'Particle'. For example, instead of `SkParticleEffect::effectUniformInfo` and
`SkParticleEffect::particleUniformInfo`, there is just `SkParticleEffect::uniformInfo`.
Hide SkImageFilter::CropRect Moves the (SkRect + flags) struct into SkImageFilter_Base with protected access only. Base constructor and all src/effects/imagefilters Make functions now take a "const SkRect*" instead. CropRect is still what's stored and used by filter implementations during filterImage(), but it's no longer publicly available. The SkImageFilters factory implementations now can go straight to the Make functions in src/effects/imagefilters instead of wrapping its "const SkRect*" in an SkImageFilter::CropRect. Bug: skia:9296, skia:11230 Change-Id: I2c62f42031910ec405623d4519c8a434cd2b3bdd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/361496 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com>
2021-01-28 18:20:16 +00:00
* Remove SkImageFilter::CropRect from the public API as it's no longer usable. All factories
work with 'SkRect', 'SkIRect', or nullable pointers to 'Sk[I]Rect'.
https://review.skia.org/361496
Move deprecated image filter headers out of include/ and into src/ Bug: skia:9310 Change-Id: I387f0251f05a2b6f2bc5a759f608d5766ed11ce2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/357285 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Reed <reed@google.com>
2021-01-22 18:01:26 +00:00
* Remove deprecated SkImageFilter factory functions and supporting types. All default-provided
SkImageFilters are now only constructed via 'include/effects/SkImageFilters.h'
https://review.skia.org/357285
Add SkRuntimeEffect::makeImage() Allows creation of an image directly from a RTE. Caller provides the effect input bindings, image info for the image, and optional local matrix. The info's alpha type and colorspace are tags for the output image. No alpha type or color space conversions are applied to the output of RTE. CPU does not yet support making kUnpremul images. Bug: chromium:1151490 Change-Id: I69babc9dbbce4431d756cd7a3eef4753e727d6fe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/357284 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-01-23 16:41:54 +00:00
* Added SkRuntimeEffect::makeImage() to capture the output of an SkRuntimeEffect in an SkImage.
https://review.skia.org/357284
Update SkRuntimeEffect::Make to take an Options struct. This allows us to control the inline threshold of runtime effects in a thread-safe way. The new Make API now returns a struct, for readability; the old Make API continues to return a tuple. The old Make function is deprecated and subject to removal. You can migrate to the new API by passing a default-constructed Options struct. In this case there will be no difference in behavior. Change-Id: Ic62d6f294f596d0a61095e35a87ccdbbe0b1cf93 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363785 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-02-03 16:15:20 +00:00
* Updated SkRuntimeEffect::Make() to take an Options struct. It also now returns a Results struct
instead of a tuple.
https://review.skia.org/363785
Reland "Remove deprecated form of SkRuntimeEffect::Make." This reverts commit e89b50ae054c08fc03ad5e7349d28c6a565e054b. Reason for revert: landed Android fix at http://ag/13544365 (master) and http://ag/13554983 (sc-dev) Original change's description: > Android roll broke with a compilation error: > frameworks/base/libs/hwui/jni/Shader.cpp:243:37: error: no matching function for call to 'get' > sk_sp<SkRuntimeEffect> effect = std::get<0>(result) > > Revert "Remove deprecated form of SkRuntimeEffect::Make." > > This reverts commit 1cda19436633c283561fe9a51f221ea9bf0ba2a3. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Remove deprecated form of SkRuntimeEffect::Make. > > > > Chromium has migrated to the new API at https://crrev.com/c/2675855. > > > > Change-Id: Id4af77db2c462348e8031d28f56e543ad619c19c > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/367060 > > Reviewed-by: Brian Osman <brianosman@google.com> > > Commit-Queue: Brian Osman <brianosman@google.com> > > Commit-Queue: John Stiles <johnstiles@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=mtklein@google.com,brianosman@google.com,johnstiles@google.com > > Change-Id: Ie18f865f3b7f5b0263db1e52b19cf6faa0500fdd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/368616 > Reviewed-by: Stan Iliev <stani@google.com> > Commit-Queue: Stan Iliev <stani@google.com> TBR=mtklein@google.com,brianosman@google.com,stani@google.com,johnstiles@google.com Change-Id: I9d679013cb275dc80aaaa977b7f1f4da31f36d1e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/369037 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-02-11 22:40:03 +00:00
https://review.skia.org/367060
Update SkRuntimeEffect::Make to take an Options struct. This allows us to control the inline threshold of runtime effects in a thread-safe way. The new Make API now returns a struct, for readability; the old Make API continues to return a tuple. The old Make function is deprecated and subject to removal. You can migrate to the new API by passing a default-constructed Options struct. In this case there will be no difference in behavior. Change-Id: Ic62d6f294f596d0a61095e35a87ccdbbe0b1cf93 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363785 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-02-03 16:15:20 +00:00
Remove 'f' prefix on SkRuntimeEffect::Varying struct Change-Id: I10184e60617f65a513980e5389f226f2ebe3eb46 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/365656 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-02-03 19:30:27 +00:00
* Changed SkRuntimeEffect::Varying to have lower-case member names, with no 'f' prefix.
https://review.skia.org/365656
Remove 'f' prefix on SkRuntimeEffect::Uniform struct Change-Id: Ibb48d30b9c0d80db3bf7b92d8c4a60bd9ce6839d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/365696 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2021-02-03 19:48:41 +00:00
* Changed SkRuntimeEffect::Uniform to have lower-case member names, with no 'f' prefix.
https://review.skia.org/365696
Deprecate (and ignore) SkAndroidCodec::ExifOrientation This was originally added so that some clients (BitmapFactory, BitmapRegionDecoder) could ignore exif for backwards compatibility, and others (ImageDecoder) could respect it. With the addition of NDK APIs for decoding all frames of an animated image, hwui/ImageDecoder will handle compositing frames, including handling the orientation, so it may as well always handle it. This removes tests for SkAndroidCodec that are no longer applicable. Android already has tests for most of them. AndroidCodec_sampledOrientation is recreated in ag/Ieda439910ae52e609f0710d424503616d99ae5c7. Change-Id: Ibd280986892176f284895d543f2f50bca22d196b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344763 Commit-Queue: Leon Scroggins <scroggo@google.com> Auto-Submit: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
2020-12-15 20:58:53 +00:00
* Deprecate (and ignore) SkAndroidCodec::ExifOrientation
https://review.skia.org/344763
Fix lighting image filters 1. Removes clamping of spotlight's specular exponent, which is not the specified behavior of feSpotLight in SVG. (note: we never clamped a specular lighting effect's specular exponent/shininess parameter, although SVG 1.1 does clamp that; that is the client's responsibility). 2. Fixes a bug in the GPU implementation of scale factor for spot lights. 3. Saturate computed lighting color after multiplying with color scale, instead of just saturating the color scale (allows high intensity lights to saturate to white which is more reasonable approximation of an HDR effect stored in an LDR color). Note: fixes 1 and 2 were originally addressed in https://bugs.chromium.org/p/chromium/issues/detail?id=472849 but the change was reverted for layout failure reasons and it was never relanded after rebasing. Note2: most of the layout test rebaselines necessary for chrome are minor and related to fix 2. The exception is svg/dynamic-updates/SVGFESpecularLightingElement-dom-kernelUnitLength-attr.html which is the result of fix 3. It took a little digging, but I believe that fix 3 actually makes that generated SVG more correct (it's original expected image was "wrong"). In that test, it has a specular constant of 4 (which is a multiplier) and a shininess of 1 (which makes it practically a "diffuse" specular). So basically we are multiplying the greenYellow color by 4 for most of the image that has a normal pointing out of the screen. Firefox renders a similarly yellow oversaturated appearance instead of clamping to the base greenYellow. Reading the feSpecularLighting spec, there is no saturation that is specified where it had been performed before this change. Instead, all that is mentioned is that the results of a given filter have to be pinned to the color channel range (e.g. the last step). Bug: skia:11007, skia:11057, skia:11153 Change-Id: I82e4a6f1742fecea59816fda75eb931c2a51d3e1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/355496 Reviewed-by: Fredrik Söderquist <fs@opera.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Tyler Denniston <tdenniston@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-01-21 23:43:58 +00:00
* Fix several minor issues in lighting image filters:
- The spotlight falloff exponent is no longer clamped to [1, 128]. SVG 1.1 requires the specular
lighting effect's exponent (shininess) to be clamped; not the spotlight's falloff. Any such
parameter clamping is the client's responisibility, which makes Skia's lighting effect easily
adaptable to SVG 1.1 (clamp exponent) or SVG 2 (no clamp).
- Fix spotlight incorrectly scaling light within the cone angle.
- Move saturation of RGBA to after multiplying lighting intensity with the lighting color, which
improves rendering when diffuse and specular constants are greater than 1.
https://review.skia.org/355496
update release notes for m89 Change-Id: Ie23baa11be7c52f969676512efabc44648c23dc4 Docs-Preview: https://skia.org/?cl=354663 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354663 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2021-01-15 19:19:53 +00:00
Add a new entry point for making promise images This paves the way for promise image sharing among direct & recording contexts, and untethers promise images from DDL recorder. Followup CLs will migrate us to actually use this entry point, and then migrate Chrome to do same. Bug: skia:10286 Change-Id: I0ad46e8e4b91d8bc03cb039b304d2ea6d8a65c35 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/373716 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-02-22 19:08:07 +00:00
* SkDeferredDisplayListRecorder::makePromiseTexture has moved to SkImage::MakePromiseTexture.
New code should use the new entry point – migration CLs will be coming soon.
https://review.skia.org/373716
Switch to using GrMtlBackendContext for GrDirectContext creation. Makes the Metal backend more consistent with the other backends, and allows new init parameters to be added without significantly changing API. Added updated sk_cf_obj because I needed some of its functionality. Bug: skia:10804 Change-Id: I6f1dd1c03ddc4c4b702ea75eff14bc0f98ab5ad2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/334426 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-11-12 20:21:11 +00:00
Milestone 89
------------
Remove SkYUVASizeInfo, make SkYUVAIndex a private part of SkYUVAInfo Bug: skia:10632 Change-Id: If4dd7779b0856f6d0b441381bf7f2f51527cdb9d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/352497 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-01-11 19:40:44 +00:00
* Removed SkYUVAIndex and SkYUVASizeInfo. These were no longer used in any
public APIs.
https://review.skia.org/352497
Add release notes summarizing breaking changes to SkRuntimeEffect No-Try: true Change-Id: I98f90add9ec3449a16ff40dfe833b124a98cc502 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/352507 Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-01-11 18:10:59 +00:00
* Numerous changes to SkRuntimeEffect, aligning the capabilities and restrictions with
The OpenGL ES Shading Language 1.00 (aka, the shading language of OpenGL ES2 and WebGL 1.0).
All built-in functions from sections 8.1 through 8.6 implemented & tested on all backends.
Removed types and features that require newer versions of GLSL:
https://review.skia.org/346657 [Non-square matrices]
https://review.skia.org/347046 [uint, short, ushort, byte, ubyte]
https://review.skia.org/349056 [while and do-while loops]
https://review.skia.org/350030 [Bitwise operators and integer remainder]
Add SkShadowUtils::GetLocalBounds. Generates a bounding rect that encompasses both shadows for a given path, relative to the path local space. Bug: skia:11146 Change-Id: Ib8edb1072ed9cbfe36285523330be95fdf661d6b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/351922 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Yegor Jbanov <yjbanov@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-01-11 16:01:09 +00:00
* Add SkShadowUtils::GetLocalBounds. Generates bounding box for shadows
relative to path.
https://review.skia.org/351922
Remove Improved Perlin Noise Is not used by a major client and can be implemented using runtime effects for users who want this noise. Bug: skia:10536 Change-Id: Iaa06e6e1406b808c7f8dc0f76621fecf2becabf5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/352057 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-01-08 23:11:33 +00:00
* Removed SkPerlinNoiseShader::MakeImprovedNoise.
https://review.skia.org/352057
Add SkShadowUtils::GetLocalBounds. Generates a bounding rect that encompasses both shadows for a given path, relative to the path local space. Bug: skia:11146 Change-Id: Ib8edb1072ed9cbfe36285523330be95fdf661d6b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/351922 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Yegor Jbanov <yjbanov@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-01-11 16:01:09 +00:00
* Removed deprecated version of MakeFromYUVATextures. Use the version
Revert "Revert "Remove legacy SkImage::MakeFromYUVATextures."" Bug: skia:10632 This reverts commit 10089c6a428757953f63310b9bfb971be76ff0ae. Cq-Include-Trybots: luci.skia.skia.primary:Canary-Android,Canary-Chromium,Canary-Flutter,Canary-G3 Change-Id: I40f17827c7bf77c005995a198f135718ec4047f4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345174 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-12-24 01:28:53 +00:00
that takes GrYUVABackendTextures instead.
https://review.skia.org/345174
SkAnimatedImage: Always respect exif orientation No known clients (CanvasKit, Android) want to ignore the exif orientation in an animation. A follow-on CL will deprecate SkAndroidCodec::ExifOrientation, leaving it up to the client (e.g. SkAnimatedImage, hwui/ImageDecoder) to handle the orientation. Add SkEncodedOriginSwapsWidthHeight to assist clients to do so. Update stoplight_animated_image GM. It previously showed using SkAnimatedImage without respecting the orientation, which is no longer supported. The new version replaces the left half of the image with the right. Remove assert that is no longer true. Originally, an SkAnimatedImage was "simple" if it did not have a crop or postProcessor. This is no longer true if has an exif orientation. Add a test that calls the simple constructor and verifies it does not crash. Change-Id: I421fd02700f220fb90458cd03c4431dee7daf399 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344762 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-12-15 20:52:39 +00:00
* SkAnimatedImage: Always respect exif orientation
Replace SkPixmapPriv::ShouldSwapWidthHeight with
SkEncodedOriginSwapsWidthHeight.
https://review.skia.org/344762
Add support for directional lights. Adds a new kDirectionLight_ShadowFlag which indicates that lightPosition is a vector pointing towards the light, and lightRadius is the blur radius when the occluder is at z == 1. For other values of z it will scale linearly. The direction is specified in device space. Bug: skia:10781 Change-Id: I14d530f006e5541ed6e22bfbeb29c7441c21fb8e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/321792 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-12-16 16:56:11 +00:00
* Add kDirectionalLight_ShadowFlag support. If enabled, light position represents
a vector pointing towards the light, and light radius is blur radius at elevation 1.
https://review.skia.org/321792
Take origin when creating/updating backend texture using pixmaps. Bug: skia:11042 Change-Id: I511c7556f97f19d7f162031c245019d2da33c129 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/341005 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-12-07 16:30:16 +00:00
Support luminance-alpha GL format for YUVA planes Bug: skia:10632 Change-Id: Ic91510b55644c15ee4eb5f96e7c35193b5ce49df Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344761 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-12-15 21:06:26 +00:00
* Support GL_LUMINANCE8_ALPHA8 textures. These can be used with GrBackendTexture APIs
on GrDirectContext and as planes of YUVA images via GrYUVABackendTextures.
https://review.skia.org/344761
Remove SkImage::MakeFromYUVATexturesCopyToExternal It's no longer used by Chrome. Inline helper that draws yuva->rgba into the now single use case. Move yuva proxy making helper from SkImage_GpuBase to SkImage_GpuYUVA since it is only used there now. Remove gm that tested the API and associated helper code in YUVUtils. Bug: skia:10632 Change-Id: If6bd49befa1d1098bb6a268b9d856794f7eb80c3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/342077 Reviewed-by: Adlai Holler <adlai@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-12-08 21:39:32 +00:00
* Removed previously deprecated SkImage::MakeFromYUVATexturesCopyToExternal.
https://review.skia.org/342077
Take origin when creating/updating backend texture using pixmaps. Bug: skia:11042 Change-Id: I511c7556f97f19d7f162031c245019d2da33c129 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/341005 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-12-07 16:30:16 +00:00
* Add versions of GrDirectContext::createBackendTexture and updateBackendTexture
that take a GrSurfaceOrigin. The previous versions are deprecated.
https://review.skia.org/341005
Remove support for deprecated kDontClipToLayer_SaveLayerFlag This removes the conditional behavior based on #defines, and the private flag definitions. It removes GMs and updates tests that tested the feature. Follow-up CLs will go through and simplify the internals of SkCanvas to take advantage of this support removal. Bug: skia:10986 Change-Id: Id42c9e7d134dd06507fabf6577e7872942ef9077 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/339988 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-12-04 17:59:39 +00:00
* Remove support for deprecated kDontClipToLayer_SaveLayerFlag in SkCanvas::SaveLayerRec
https://review.skia.org/339988
Expose more info in SkCodec::FrameInfo Bug: b/160984428 Add more fields to SkCodec::FrameInfo, which describes the properties of an individual frame in an animated image. This allows a client that wishes to seek to determine frame dependencies so that they can decode an arbitrary frame, which in turn will allow SkCodec to remove SkCodec::FrameInfo::fRequiredFrame. Currently, SkCodec seeks through the stream to determine frame dependencies, but this is unnecessary work (and storage) for a client that does not want to seek. These fields also support the proposed APIs in go/animated-ndk. Move SkCodecAnimation::Blend from SkCodecAnimationPriv (and delete that file) into SkCodecAnimation.h. Rename its values to be more clear. Merge common code for populating SkCodec::FrameInfo. Add a test for a GIF with offsets outside the range of the image. Note that libwebp rejects such an image. Update libgifcodec. Change-Id: Ie27e0531e7d62eaae153eccb3105bf2121b5aac4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/339857 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: Nigel Tao <nigeltao@google.com>
2020-11-11 17:45:40 +00:00
* Expose more info in SkCodec::FrameInfo
https://review.skia.org/339857
Preserve dithering for SkImageFilters::Shader Migrating chromium code to use SkImageFilters::Shader over SkPaintImageFilter requires dithering to be preserved for its gradient fills. I debated always forcing it to true, but dithering was never turned on for the turbulence filter and it's not necessary for const color shaders Given that, I opted to just make it a parameter to the filter factory, which seems okay since we're unlikely to embed dithering into SkShader itself, it's a shading-related parameter of SkPaint, and if we migrate to always dithering, then we can remove it. Bug: skia:9310 Change-Id: I86f14969e2446f3a84e71e687cb263bcd44cf9d9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/338156 Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-11-24 18:14:04 +00:00
* Added dither control to the SkImageFilters::Shader factory.
https://review.skia.org/338156
Switch to using GrMtlBackendContext for GrDirectContext creation. Makes the Metal backend more consistent with the other backends, and allows new init parameters to be added without significantly changing API. Added updated sk_cf_obj because I needed some of its functionality. Bug: skia:10804 Change-Id: I6f1dd1c03ddc4c4b702ea75eff14bc0f98ab5ad2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/334426 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-11-12 20:21:11 +00:00
Add MTLBinaryArchive support to iOS Metal build Change-Id: I7a4f58e4fc1fc18c42de372dd480e0681000e2f2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333758 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Chinmay Garde <chinmaygarde@google.com> Reviewed-by: Adlai Holler <adlai@google.com>
2020-11-19 17:59:06 +00:00
* Add MTLBinaryArchive parameter to GrMtlBackendContext. This allows
Skia to cache PipelineStates in the given archive for faster
shader compiles on future runs. The client must handle loading and
saving of the archive.
https://review.skia.org/333758
Remove SkYUVAInfo::PlanarConfig Bug: skia:10632 Change-Id: I72b4379c82fd7dc4c7169387014f8fffbb86e23f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/334161 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-11-18 13:46:44 +00:00
* Deprecated enum SkYUVAInfo::PlanarConfig has been removed.
https://review.skia.org/334161
Remove deprecated DDL promise texture image factories. Bug: skia:10632 Change-Id: I218281256ea5ab4a5a5a7ea7bf209350082f8dc7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335038 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-11-16 15:31:49 +00:00
* Deprecated SkImage factories have been removed from
SkDeferredDisplayListRecorder.
Remove unused copy-to-external YUV SkImage factories. Also inline some helper functions into newer factory method that are no longer shared. Bug: skia:10632 Change-Id: I466c59f668d882802087acad1ec1f229505a3377 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/334596 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-11-12 21:34:28 +00:00
* The following YUV image factories have been removed:
SkImage::MakeFromYUVTexturesCopyWithExternalBackend
SkImage::MakeFromNV12TexturesCopyWithExternalBackend
Replacement pattern outlined below.
1) Make image using MakeFromYUVATextures
2) Make a SkSurface around result texture using SkSurface::MakeFromBackendTexture
3) surface->getCanvas()->drawImage(image, 0, 0);
4) surface->flushAndSubmit()
5) Optional: SkImage::MakeFromBackendTexture() to use as SkImage.
https://review.skia.org/334596
Switch to using GrMtlBackendContext for GrDirectContext creation. Makes the Metal backend more consistent with the other backends, and allows new init parameters to be added without significantly changing API. Added updated sk_cf_obj because I needed some of its functionality. Bug: skia:10804 Change-Id: I6f1dd1c03ddc4c4b702ea75eff14bc0f98ab5ad2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/334426 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-11-12 20:21:11 +00:00
* Added a new interface for GrDirectContext creation in Metal, using
a new struct called GrMtlBackendContext. The previous interface taking
a MTLDevice and MTLCommandQueue is deprecated.
https://review.skia.org/334426
Remove SkBaseDevice::flush (take 2) Another small step in removing SkCanvas::flush Change-Id: I6f3bec367e582754b8463b7bfe6a2542436ca829 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335647 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Adlai Holler <adlai@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-11-30 13:32:38 +00:00
* SkCanvas::flush has been deprecated.
Switch to using GrMtlBackendContext for GrDirectContext creation. Makes the Metal backend more consistent with the other backends, and allows new init parameters to be added without significantly changing API. Added updated sk_cf_obj because I needed some of its functionality. Bug: skia:10804 Change-Id: I6f1dd1c03ddc4c4b702ea75eff14bc0f98ab5ad2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/334426 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-11-12 20:21:11 +00:00
* * *
Update release notes for M87 branch cut, M88 begin Bug: skia: Change-Id: Id4cc2f42389dac1e087026fee5c0df0eff4e89c4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/321776 Reviewed-by: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-10-02 12:44:30 +00:00
Milestone 88
add M86 branch release notes Bug: skia: Change-Id: I62331cab6cfadbaf9ab2f74e316cb7a2515249d0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312305 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-08-20 19:59:08 +00:00
------------
Split SkYUVAInfo::PlanarConfig into PlaneConfig and Subsampling enums Sometimes it's helpful to think about subsampling separately from how the channels are spread across planes. Bug: skia:10632 Change-Id: Ib03f71195f9706ef6def418b1f2125c29e0cf738 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/334102 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-11-11 21:34:19 +00:00
* SkYUVAInfo now has separate enums for division of channels among planes and
the subsampling. The previous combined enum, PlanarConfig, is deprecated.
https://review.skia.org/334102
Simplify promise image callbacks. Remove done and release distinction. Chrome is not using either as it tracks texture access using other synchronization mechanisms (semaphores, flush finish procs). Now there is just fulfill and release where release is called when the texture can be deleted. Also, release proc can be null. Simplify texture idle mechanism as the "flushed" state was only used to implement the old idea of a release proc. The "finished" idle state is still used to implement the new release proc. Though, it could also be removed if GrTexture were to be removed for textures returned by fulfill. Not directly tied to this bug, but a new YUVA factory will be required and it's good to clean things up first to avoid adding another instance of the current complexity. Bug: skia:10632 Change-Id: I4fe3c0af3f5a591506b1b3c736fd3284a38465a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331836 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-11-09 20:40:27 +00:00
* Simplified SkDeferredDisplayListRecorder promise image API. Removed "release"
callback and renamed "done" callback to "release". The new "release" proc can
Add SkYUVAInfo-based promise texture image factory Bug: skia:10632 Change-Id: I6a31f2d712f704850ba5246208dc8a4a6e6916eb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333519 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-11-10 19:17:58 +00:00
be null. Added a new SkYUVAInfo-based factory for YUVA promise texture images
and deprecated the old SkYUVAIndex-based one.
Simplify promise image callbacks. Remove done and release distinction. Chrome is not using either as it tracks texture access using other synchronization mechanisms (semaphores, flush finish procs). Now there is just fulfill and release where release is called when the texture can be deleted. Also, release proc can be null. Simplify texture idle mechanism as the "flushed" state was only used to implement the old idea of a release proc. The "finished" idle state is still used to implement the new release proc. Though, it could also be removed if GrTexture were to be removed for textures returned by fulfill. Not directly tied to this bug, but a new YUVA factory will be required and it's good to clean things up first to avoid adding another instance of the current complexity. Bug: skia:10632 Change-Id: I4fe3c0af3f5a591506b1b3c736fd3284a38465a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331836 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-11-09 20:40:27 +00:00
https://review.skia.org/331836
Add SkYUVAInfo-based promise texture image factory Bug: skia:10632 Change-Id: I6a31f2d712f704850ba5246208dc8a4a6e6916eb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333519 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-11-10 19:17:58 +00:00
https://review.skia.org/333519
New variant of SkImage::MakeFromYUVATextures. Takes a new type GrYUVATextures. This a set of GrBackendTextures and SkYUVAInfo that have been pre-validated to be compatible. Bug: skia:10632 Change-Id: Id252f8662ede0f268e88fd40dc1b0b8f4ab6345f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317762 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-10-16 20:11:27 +00:00
Reland "Rearrange SkSL pre-include modules to hide things" This reverts commit 4cb5c5e1728933637ca9b8653ff95f876871dc9b, and fixes the Chromium issue by declaring sign(x) in sksl_public.sksl. Original description: This makes numerous internal and GLSL types or intrinsics hidden from public (runtime effect) SkSL. In particular: - Only core numeric types are visible to all program types. GLSL types involving images, textures, and sampling are restricted to internal use. - sk_Caps is no longer visible to runtime effects. - The set of intrinsics available to runtime effects is now a separate, curated list in sksl_public.sksl. It exactly matches the GLSL ES 1.00 spec order. - The blend intrinsics are no longer visible, which also fixes a bug. These are nice, but we're not going to offer them yet - they involve enums, which creates complications. Bug: skia:10680 Bug: skia:10709 Bug: skia:10913 Cq-Include-Trybots: luci.chromium.try:linux-chromeos-rel,linux-rel Change-Id: I42deeeccd725a9fe18314d091ce253404e3572e2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/332750 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2020-11-06 16:45:36 +00:00
* Limit the types and intrinsics supported in SkRuntimeEffect to GLSL ES 1.00
https://review.skia.org/332597
Reland "heif: Add AVIF type and AVIF sniffing" Fix: Do not use std::optional. Bug: b/141654151 Change-Id: I6237db0d55b1ea92f7be3588a2b648b9e6014e3f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331878 Reviewed-by: Vignesh Venkatasubramanian <vigneshv@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-11-04 22:13:39 +00:00
* Add AVIF support to SkHeifCodec.
Allow creating SkSurfaceCharacterizations directly for vk secondary CB context. Bug: chromium:1144921 Change-Id: I9ca905eb9f2542aafbde25e0baa5430640277699 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331877 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-11-04 15:50:39 +00:00
* Add support for creating SkSurfaceCharacterizations directly for use by a
GrVkSecondaryCBDrawContext.
https://review.skia.org/331877
Remove code guarded by SK_LEGACY_SURFACE_PROPS. This removes the last of the SkFontHost LCD globals and the SkSurfaceProps::kLegacyFontHost_InitType. Bug: skia:3934 Change-Id: Ic2342a3ea3dbcd075d6817cbd3fc27274e376b8d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/329364 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-10-23 15:29:03 +00:00
* Removed SkSurfaceProps::kLegacyFontHost_InitType, SkFontLCDConfig, and related code.
The default pixel geometry for SkSurfaceProps is now kUnknown instead of kRGB_H.
The removal was guarded by the SK_LEGACY_SURFACE_PROPS build flag which was later removed.
https://review.skia.org/322490
https://review.skia.org/329364
Remove legacy SkImageGenerator YUV planes interface Bug: skia:10632 Change-Id: Iaed6b51e03ef9023a74d77f3262104c1677c416f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/327917 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-10-19 17:31:49 +00:00
* Legacy 8-bit YUV interface removed from SkImageGenerator. Use more flexible SkYUVAPixmaps-
based interface instead.
https://review.skia.org/327917
Revert "Revert "New variant of SkImage::MakeFromYUVATextures."" This reverts commit be8004d2fb6c8575d7da7c580811639654a9d255. Bug: skia:10632 Change-Id: I52dd36ae167623563c7554c40092442a3822ee3c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/327760 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-10-19 14:55:45 +00:00
* New variant of SkImage::MakeFromYUVATextures. Takes a new type GrYUVATextures
which wraps an SkYUVAInfo and compatible set of GrBackendTextures. The provides
a more complete and structured specification of the planar configuration. Previous
version is deprecated.
Revert "Revert changes to unbreak bots." This reverts commit 49721c84376bcb91daff84bcaa0225298866ee60. Reason for revert: fixed double usage of plane release context in YUVUtils. Original change's description: > Revert changes to unbreak bots. > > f01a9d90209d824ea7449b06ad7c5e35349d6d17 > is the culprit > > > Revert "GrRefCntedCallback has Make function." > > This reverts commit b2c42140ea10d1781917023a84465386f92d2a06. > > Revert "Add SkImage::MakeFromYUVATexturesCopyToExternal" > > This reverts commit f01a9d90209d824ea7449b06ad7c5e35349d6d17. > > Bug: skia:10632 > Change-Id: Ief076f168b63ff8ca15b607163a13d5f52a733d2 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331798 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com Change-Id: I41cdfe0d5b8587f85fae0c804c059c0d6ff92800 Bug: skia:10632 Change-Id: I41cdfe0d5b8587f85fae0c804c059c0d6ff92800 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331876 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-11-04 21:54:28 +00:00
Already deprecated MakeFromYUVATexturesCopyToExternal added to replace other deprecated
APIs. It's not recommended that clients use this and instead use the pattern described
in the API comment.
Remove legacy SkImageGenerator YUV planes interface Bug: skia:10632 Change-Id: Iaed6b51e03ef9023a74d77f3262104c1677c416f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/327917 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-10-19 17:31:49 +00:00
https://review.skia.org/317762
Revert "Revert changes to unbreak bots." This reverts commit 49721c84376bcb91daff84bcaa0225298866ee60. Reason for revert: fixed double usage of plane release context in YUVUtils. Original change's description: > Revert changes to unbreak bots. > > f01a9d90209d824ea7449b06ad7c5e35349d6d17 > is the culprit > > > Revert "GrRefCntedCallback has Make function." > > This reverts commit b2c42140ea10d1781917023a84465386f92d2a06. > > Revert "Add SkImage::MakeFromYUVATexturesCopyToExternal" > > This reverts commit f01a9d90209d824ea7449b06ad7c5e35349d6d17. > > Bug: skia:10632 > Change-Id: Ief076f168b63ff8ca15b607163a13d5f52a733d2 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331798 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com Change-Id: I41cdfe0d5b8587f85fae0c804c059c0d6ff92800 Bug: skia:10632 Change-Id: I41cdfe0d5b8587f85fae0c804c059c0d6ff92800 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331876 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-11-04 21:54:28 +00:00
https://review.skia.org/329956
Revert "Revert "New variant of SkImage::MakeFromYUVATextures."" This reverts commit be8004d2fb6c8575d7da7c580811639654a9d255. Bug: skia:10632 Change-Id: I52dd36ae167623563c7554c40092442a3822ee3c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/327760 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-10-19 14:55:45 +00:00
Add context option to disable mipmap support This is desired for a short term memory improvement on low memory devices. Bug: chromium:1138979 Change-Id: I7df41a9c4d21b7a7f62b738e6358b36dd262f77d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/327345 Commit-Queue: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-10-19 14:07:48 +00:00
* Add field to GrContextOptions to disable mipmap support even if the backend
supports it.
move SkTPin to include/private Change-Id: Ib0dc823d331a7cddc5da1d1be83136ce803a7871 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/327783 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-10-16 16:04:18 +00:00
* SkTPin() removed from public API.
Add SkImageFilters::Blend rename for Xfermode filter This better matches SkShaders::Blend and SkColorFilters::Blend factories. Bug: skia:9310 Change-Id: I02a3fe488a446b803df96518caacff1fdf536e9f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324623 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2020-10-09 14:45:07 +00:00
* Add new SkImageFilters::Blend factory function, in place of the now deprecated
SkImageFilters::Xfermode factory function. Behavior is identical, but name better matches
conventions in SkShader and SkColorFilter.
https://review.skia.org/324623
Expand image filter factories to accept more types for crop rects The original SkIRect* crop rect argument was a little too onerous. First, as a pointer, it required you to declare your crop rect separately just to take a pointer to it. Now, you can pass an SkIRect or SkRect in directly when you are explicitly constructing a cropped filter. Second, the crop rect is transformed by the same matrix as the other filter parameters, so it can be scaled and translated. Allowing SkRect instead of just SkIRect gives more precision and flexibility for local coordinate systems. Now a crop rect could be defined to be from [-.5, .5] and still map to real pixels after transformation (this was a request from the skia-discuss mailing list, and also better matches the SVG spec). The crop rect argument was always meant to be a convenience, since I plan to refactor cropping into an indenendent image filter that will give more explicit control over when the crop is applied in the DAG. To maintain the convenience for the factories, the constructors of the new CropRect type are not explicit so that callers don't ever need to concern themselves with it. Bug: skia:9296 Change-Id: I29a684cb925f1fca4dabc803114ab2b125660aaa Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324622 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-10-09 14:31:28 +00:00
* SkImageFilters::Foo() factory functions now accept SkIRect, SkRect, and optional SkIRect* or
SkRect*, instead of previously just the optional SkIRect*. Internally, the crop rects are stored
as floats to allow for fractional crops to be defined in the local coordinate system (before
transformation by the canvas matrix).
https://review.skia.org/324622
Add SkImageFilters::Shader in place of Paint factory SkImageFilters::Paint did not use every slot of the SkPaint, with only its color, alpha, color filter, and shader having a meaningful effect on the image filter result. It was always blended into a transparent dst, so blend mode wasn't very relevant, and it was always filled to whatever required geometry, so stroke style, path effect, and mask filters were ignored or not well specified. Color, alpha, and color filter can all be combined into an SkShader, so a more constrained SkImageFilters::Shader provides the same useful capabilities without as many surprises. SkImageFilters::Paint still exists, but is deprecated to be removed once I've confirmed clients aren't depending on it. Bug: skia:9310 Change-Id: I11a82bda1a5d440726cf4e2b5bfaae4929568679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/323680 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-10-07 19:27:20 +00:00
* Add new SkImageFilters::Shader factory and deprecate SkImageFilters::Paint factory. All
supported/valid Paint() filters can be represented more cleanly as a Shader image filter.
https://review.skia.org/323680
Reland "Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext"" This reverts commit cf43fc676856c4db0122ff3bcb49d90b0e7b1115. Reason for revert: Fixed g3 Original change's description: > Revert "Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext"" > > This reverts commit ff13ffbeacec5335cfdb84c8a9d20bb78e10da58. > > Reason for revert: Blink in g3 > > Original change's description: > > Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext" > > > > This reverts commit 89bdc90ac877dc8cd49c86c35a20d9df0d3b9016. > > > > Reason for revert: Fix metal > > > > Original change's description: > > > Revert "Take GrContext private, GrDDLContext inherit from GrRecordingContext" > > > > > > This reverts commit d2daa94edeca88281796524fae45f38f11a7bef2. > > > > > > Reason for revert: Metaru > > > > > > Original change's description: > > > > Take GrContext private, GrDDLContext inherit from GrRecordingContext > > > > > > > > Woo! > > > > > > > > Change-Id: I8d201b709343dc18cad31ea740575285dd035f35 > > > > Docs-Preview: https://skia.org/?cl=317436 > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317436 > > > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > > > Commit-Queue: Adlai Holler <adlai@google.com> > > > > > > TBR=bsalomon@google.com,robertphillips@google.com,adlai@google.com > > > > > > Change-Id: I9b58dee285fbdc49ebc8e76df5da0fe224cf9787 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318758 > > > Reviewed-by: Adlai Holler <adlai@google.com> > > > Commit-Queue: Adlai Holler <adlai@google.com> > > > > TBR=bsalomon@google.com,robertphillips@google.com,adlai@google.com > > > > > > Change-Id: Id4b10795193a904cd4ed8c36e60e74abe3b6702a > > Docs-Preview: https://skia.org/?cl=318759 > > Cq-Include-Trybots: luci.skia.skia.primary:Build-Mac10.15.5-Clang-arm64-Debug-iOS_Metal,Build-Mac-Clang-x86_64-Debug-Metal > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318759 > > Commit-Queue: Adlai Holler <adlai@google.com> > > Reviewed-by: Adlai Holler <adlai@google.com> > > TBR=bsalomon@google.com,robertphillips@google.com,adlai@google.com > > Change-Id: Ib20fe933120d56b72efaec73a0bedec60bc28def > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319184 > Commit-Queue: Adlai Holler <adlai@google.com> > Reviewed-by: Adlai Holler <adlai@google.com> TBR=bsalomon@google.com,robertphillips@google.com,adlai@google.com Change-Id: I4f01291f4b3bfbb8fd7dd8cf2bf8415430c3392e Docs-Preview: https://skia.org/?cl=322437 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322437 Reviewed-by: Adlai Holler <adlai@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adlai Holler <adlai@google.com> Auto-Submit: Adlai Holler <adlai@google.com>
2020-10-06 18:04:35 +00:00
* GrContext has been replaced by two separate classes: GrDirectContext which is
the traditional notion of GrContext, and GrRecordingContext which is a context
that is recording an SkDeferredDisplayList and therefore has reduced functionality.
Unless you are using SkDeferredDisplayList, migrate directly to GrDirectContext in
all cases.
Start removal of tool usage of SkSurface::MakeFromBackendTextureAsRenderTarget. Adds a new helper that creates a GrBackendRenderTarget using GrGpu and then wraps it in a SkSurface. Uses the SkSurface release proc to delete the BERT using GrGpu. Upgrades GrGpu::createTestingOnlyBackendRenderTarget to create MSAA buffers. Updates many tests/tool to call sites to use the helper instead of SkSurface::MakeFromBackendTextureAsRenderTarget. Adds syncToCpu bool to SkSurface:: and GrContext::flushAndSubmit. Bug: skia:9832 Change-Id: I73a8f0ce09dc6523729af0814464c6b6657fda06 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293683 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-10-06 14:07:38 +00:00
* CPU sync bool added to SkSurface::flushAndSubmit() and GrContext::flushAndSubmit()
Remove unused variant of SkImage::MakeFromYUVAPixmaps Bug: skia:10632 Change-Id: I337d79d856945071b2b68651a80013184d443267 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322480 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Adlai Holler <adlai@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Adlai Holler <adlai@google.com>
2020-10-05 17:25:05 +00:00
* Removed legacy variant of SkImage::MakeFromYUVAPixmaps. Use the version that
takes SkYUVAPixmaps instead. It has a more structured description of the
planar configuration.
https://review.skia.org/322480
Remove unused SkImage YUVA factories. Bug: skia:10632 Change-Id: Icb27e44d234063ab049fef95587f474323d7ada9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/321537 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-10-02 18:37:57 +00:00
* Some SkImage YUV image factories have been removed. Replacement patterns
outlined below.
SkImage::MakeFromYUVATexturesCopy
1) Make SkImage from YUVA planes using SkImage::MakeFromYUVATextures
2) Use Skia to allocate a surface using SkSurface::MakeRenderTarget
3) surface->getCanvas()->drawImage(image, 0, 0);
4) surface->makeImageSnapShot() produces RGBA image.
SkImage::MakeFromYUVATexturesCopyWithExternalBackend
1) Make image using MakeFromYUVATextures
2) Make a SkSurface around result texture using SkSurface::MakeFromBackendTexture
3) surface->getCanvas()->drawImage(image, 0, 0);
4) surface->flushAndSubmit()
5) Optional: SkImage::MakeFromBackendTexture() to use as SkImage.
SkImage::MakeFromNV12TexturesCopy
Same as SkImage::MakeFromYUVATexturesCopy
https://review.skia.org/321537
Require stencil bits on wrapped GrBackendRenderTargets to 0, 8, or 16. This will allow us in a follow on change to put in a "fake" gl stencil format for the wrapped FBO. Bug: skia:10727 Change-Id: Iba1eca5114b34d25e6a220591d28a20f7b36b12b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/321545 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-10-02 15:13:33 +00:00
* GrBackendRenderTargets which are created with a stencilBits param, now require
the stencilBits to be 0, 8, or 16.
https://review.skia.org/321545
Update release notes for M87 branch cut, M88 begin Bug: skia: Change-Id: Id4cc2f42389dac1e087026fee5c0df0eff4e89c4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/321776 Reviewed-by: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-10-02 12:44:30 +00:00
* * *
Milestone 87
------------
Add sample count to GrVkImageInfo. Pre-req for allowing rendering to an externally created MSSA VkImage. Bug: skia:9832 Cq-Include-Trybots: luci.skia.skia.primary:Test-Debian10-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Release-All-Vulkan,Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Release-All-Vulkan,Test-Win10-Clang-ShuttleA-GPU-RadeonHD7770-x86_64-Release-All-Vulkan,Test-Android-Clang-GalaxyS9-GPU-MaliG72-arm64-Release-All-Android_Vulkan,Test-Android-Clang-GalaxyS7_G930FD-GPU-MaliT880-arm64-Release-All-Android_Vulkan,Test-Android-Clang-GalaxyS20-GPU-MaliG77-arm64-Release-All-Android_Vulkan,Test-Android-Clang-Pixel4XL-GPU-Adreno640-arm64-Release-All-Android_Vulkan,Test-Android-Clang-P30-GPU-MaliG76-arm64-Release-All-Android_Vulkan Change-Id: Ibf41944c6946dda7e27bdcd509ecd04976fc9ade Reviewed-on: https://skia-review.googlesource.com/c/skia/+/320262 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-09-28 21:02:49 +00:00
* GrVkImageInfo now has a field for sample count. GrBackendRenderTarget constructor
that took both a GrVkImageInfo and separate sample count is deprecated. Use the
Add sample count field to GrD3DTextureResourceInfo. Remove separate constructor arg from GrBackendRenderTarget. Add appropriate checks in onWrap functions in GrD3DGpu to limit to previous functionality. Bug: skia:9832 Cq-Include-Trybots: luci.skia.skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-Direct3D,Test-Win10-Clang-ShuttleA-GPU-RadeonHD7770-x86_64-Debug-All-Direct3D Change-Id: Ieba398d4bc00d18fdb0adffcda81f1a166db24b3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/320757 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-09-29 20:52:49 +00:00
version without sample count instead. Similarly, GrD3DTextureResourceInfo now
has a sample count field and GrBackendRenderTarget no longer takes a separate
Get GrBackendRenderTarget's sample count from MtlTexture. Instead of being passed separately. Check sample count in various onWrap methods in GrMtlGpu. Bug: skia:9832 Cq-Include-Trybots: luci.skia.skia.primary:Test-iOS-Clang-iPhone8-GPU-AppleA11-arm64-Release-All-Metal,Test-iOS-Clang-iPhone7-GPU-PowerVRGT7600-arm64-Release-All-Metal,Test-iOS-Clang-iPadPro-GPU-PowerVRGT7800-arm64-Release-All-Metal,Test-iOS-Clang-iPhone11-GPU-AppleA13-arm64-Release-All-Metal,Test-iOS-Clang-iPhone6-GPU-PowerVRGX6450-arm64-Release-All-Metal,Test-Mac10.15-Clang-MacBookAir7.2-GPU-IntelHD6000-x86_64-Release-All-Metal Change-Id: If5813db95b07f5d272e80920486f461cc5a587fc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/320956 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-09-30 17:50:18 +00:00
sample count for Direct3D. The sample count for GrBackendRenderTarget is now
directly queried from MtlTexture rather than passed separately. The version that
takes a separate sample count is deprecated and the parameter is ignored.
Add sample count field to GrD3DTextureResourceInfo. Remove separate constructor arg from GrBackendRenderTarget. Add appropriate checks in onWrap functions in GrD3DGpu to limit to previous functionality. Bug: skia:9832 Cq-Include-Trybots: luci.skia.skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-Direct3D,Test-Win10-Clang-ShuttleA-GPU-RadeonHD7770-x86_64-Debug-All-Direct3D Change-Id: Ieba398d4bc00d18fdb0adffcda81f1a166db24b3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/320757 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-09-29 20:52:49 +00:00
https://review.skia.org/320262
https://review.skia.org/320757
Get GrBackendRenderTarget's sample count from MtlTexture. Instead of being passed separately. Check sample count in various onWrap methods in GrMtlGpu. Bug: skia:9832 Cq-Include-Trybots: luci.skia.skia.primary:Test-iOS-Clang-iPhone8-GPU-AppleA11-arm64-Release-All-Metal,Test-iOS-Clang-iPhone7-GPU-PowerVRGT7600-arm64-Release-All-Metal,Test-iOS-Clang-iPadPro-GPU-PowerVRGT7800-arm64-Release-All-Metal,Test-iOS-Clang-iPhone11-GPU-AppleA13-arm64-Release-All-Metal,Test-iOS-Clang-iPhone6-GPU-PowerVRGX6450-arm64-Release-All-Metal,Test-Mac10.15-Clang-MacBookAir7.2-GPU-IntelHD6000-x86_64-Release-All-Metal Change-Id: If5813db95b07f5d272e80920486f461cc5a587fc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/320956 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-09-30 17:50:18 +00:00
https://review.skia.org/320956
Add sample count to GrVkImageInfo. Pre-req for allowing rendering to an externally created MSSA VkImage. Bug: skia:9832 Cq-Include-Trybots: luci.skia.skia.primary:Test-Debian10-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Release-All-Vulkan,Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Release-All-Vulkan,Test-Win10-Clang-ShuttleA-GPU-RadeonHD7770-x86_64-Release-All-Vulkan,Test-Android-Clang-GalaxyS9-GPU-MaliG72-arm64-Release-All-Android_Vulkan,Test-Android-Clang-GalaxyS7_G930FD-GPU-MaliT880-arm64-Release-All-Android_Vulkan,Test-Android-Clang-GalaxyS20-GPU-MaliG77-arm64-Release-All-Android_Vulkan,Test-Android-Clang-Pixel4XL-GPU-Adreno640-arm64-Release-All-Android_Vulkan,Test-Android-Clang-P30-GPU-MaliG76-arm64-Release-All-Android_Vulkan Change-Id: Ibf41944c6946dda7e27bdcd509ecd04976fc9ade Reviewed-on: https://skia-review.googlesource.com/c/skia/+/320262 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-09-28 21:02:49 +00:00
Add deprecation warning when running Metal on older OSes. Older versions of MacOS are unstable when compiling shaders, and we don't have the testing support for older versions of iOS. Bug: skia:10777 Change-Id: I95d9fe0f1007af6bec5c7525dacda565e32989f2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/320260 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-09-28 19:36:00 +00:00
* Added deprecation warning for Metal support on MacOS 10.13, iOS 8.3, and older.
https://review.skia.org/320260
Add sample count to GrVkImageInfo. Pre-req for allowing rendering to an externally created MSSA VkImage. Bug: skia:9832 Cq-Include-Trybots: luci.skia.skia.primary:Test-Debian10-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Release-All-Vulkan,Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Release-All-Vulkan,Test-Win10-Clang-ShuttleA-GPU-RadeonHD7770-x86_64-Release-All-Vulkan,Test-Android-Clang-GalaxyS9-GPU-MaliG72-arm64-Release-All-Android_Vulkan,Test-Android-Clang-GalaxyS7_G930FD-GPU-MaliT880-arm64-Release-All-Android_Vulkan,Test-Android-Clang-GalaxyS20-GPU-MaliG77-arm64-Release-All-Android_Vulkan,Test-Android-Clang-Pixel4XL-GPU-Adreno640-arm64-Release-All-Android_Vulkan,Test-Android-Clang-P30-GPU-MaliG76-arm64-Release-All-Android_Vulkan Change-Id: Ibf41944c6946dda7e27bdcd509ecd04976fc9ade Reviewed-on: https://skia-review.googlesource.com/c/skia/+/320262 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-09-28 21:02:49 +00:00
* GrVkImageInfo now has a field for sample count. GrBackendRenderTarget constructor
that took both a GrVkImageInfo and separate sample count is deprecated. Use the
version without sample count instead.
Update SkClipOp::kMax_EnumValue to match non-deprecated values Even when expanding clip ops were disabled, the max value allowed the fuzzer to produce those disabled values. This should fix the fuzzer to only produce valid intersect or difference clip ops. Bug: chromium:1132687 Change-Id: I7368ff36a00e6b0e87ecbae5ba647d249299b9ca Reviewed-on: https://skia-review.googlesource.com/c/skia/+/320064 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-09-28 14:33:42 +00:00
* Update SkClipOp::kMax_EnumValue to include only intersect and difference when
SK_SUPPORT_DEPRECATED_CLIPOPS is not defined.
https://review.skia.org/320064
Add AMD allocator to D3D12 backend. Adds base class GrD3DAlloc and GrD3DMemoryAllocator, and a reference to a GrD3DMemoryAllocator in GrBackendContext and a reference to a GrD3DAlloc in GrD3DTextureResourceInfo. Internally, we override this base class to define the AMD memory allocator. Change-Id: I033924b0247ea330969b1398f25985e7a84aec11 Bug: skia:9935 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317243 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-09-23 20:29:51 +00:00
* Add support for external allocator for Direct3D 12 backend.
Defines base classes for an allocation associated with a backend texture and a
a memory allocator to create such allocations.
Adds memory allocator to backend context.
https://review.skia.org/317243
Add optional param to setBackendTextureState to return previous state. Bug: skia:10742 Change-Id: I334e7896d0a1509eb666c46d5731d2573a5c1aba Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318698 Reviewed-by: Austin Eng <enga@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-09-23 18:23:36 +00:00
* Add new optional parameter to GrContext::setBackend[Texture/RenderTarget]State which can
be used to return the previous GrBackendSurfaceMutableState before the requested change.
https://review.skia.org/318698
Reland "Enable novel GrClipStack on bots, disable elsewhere" This reverts commit f6e0f58b2ea5748da14a29c3da59a984c1c4c180. Reason for revert: benches and tests updated here: https://skia-review.googlesource.com/c/skia/+/317380 Original change's description: > Revert "Enable novel GrClipStack on bots, disable elsewhere" > > This reverts commit e1ade2ac4a8d11065395f4e2ea85891495d82bcb. > > Reason for revert: Need to remove benchmarks that use deprecated SkClipOps first. > > Original change's description: > > Enable novel GrClipStack on bots, disable elsewhere > > > > As a result of this change, the new GrClipStack will run on all of our > > default bots. However, the SK_DISABLE_NEW_GR_CLICK_STACK define is used > > to explicitly disable the clip stack when we build for the Android > > Framework, Google3, Flutter, and Fuchsia. These projects can have staging > > controlled from within the skia repo. This CL in chromium also disables > > the new clip stack: https://chromium-review.googlesource.com/c/chromium/src/+/2412768 > > and must land before this CL does in Skia. > > > > When GrClipStack originally landed, I had it disabled by checking the > > value of the define SK_USE_NEW_GR_CLICK_STACK for 0 or 1. To be a little > > simpler, and work with the flutter and fuchsia gn defines, this CL > > switches GrClipStack control over to SK_DISABLE_NEW_GR_CLICK_STACK and > > it just checks for whether or not it's defined. > > > > Bug: skia:10205 > > Change-Id: I6b8bd18290844c02839fe99fdf629b48ffd86f27 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317209 > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com > > Change-Id: I14fddccfdea8e91ebad92e55193b0034f8bb28af > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:10205 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317377 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > Commit-Queue: Michael Ludwig <michaelludwig@google.com> TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com # Not skipping CQ checks because this is a reland. Bug: skia:10205 Change-Id: I1f26496437ed04a79e9c1058428cdc867ae3be39 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317385 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-09-16 18:41:38 +00:00
* New optimized clip stack for GPU backends. Enabled by default but old behavior based on
SkClipStack can be restored by defining SK_DISABLE_NEW_GR_CLIP_STACK when building. It is not
compatible with SK_SUPPORT_DEPRECATED_CLIPOPS and we are targeting the removal of support for
the deprecated, expanding clip ops.
https://review.skia.org/317209
Filter transformed atlas images correctly on GPU. The GPU backend was not considering the SkRSXform when optimizing the filter mode. This would cause rotated or scaled atlas images to look pixelated, regardless of the paint filter. Change-Id: I65f4bee6351e10349114869b823b2114bbcf70be Bug: skia:10662 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/313081 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-08-25 17:33:45 +00:00
* GPU backends now properly honor the SkFilterQuality when calling drawAtlas.
https://review.skia.org/313081
SkRuntimeEffect SkSL has a new signature for main() There is no more 'inout half4 color'. Effects return their output color. If an effect wants the input color, it must use the (already existing) approach of sampling a nullptr input shader. The change is guarded for Chromium (so we can update their runtime color filters in skia_renderer.cc). For the GPU backend, FPs can now override usesExplicitReturn to indicate that their emitCode will generate a return statement. If that's true, then writeProcessorFunction doesn't inject the automatic return of the output color, and emitFragProc will *always* wrap that FP in a helper function, even as a top-level FP. GrSkSLFP opts in to this behavior, so that the user-supplied return becomes the actual return in the FP's emitCode. Adapting the skvm code to this wasn't too bad: It looks fragile (what happens if there are multiple returns?), but that's not really possible today, without varying control flow. Bug: skia:10613 Change-Id: I205b81fd87dd32bab30b6d6d5fc78853485da036 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310756 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-13 20:59:48 +00:00
* The signature of 'main' used with SkRuntimeEffect SkSL has changed. There is no longer an
'inout half4 color' parameter, effects must return their color instead.
Valid signatures are now 'half4 main()' or 'half4 main(float2 coord)'.
https://review.skia.org/310756
Expand SkYUVAInfo::PlanarConfig/SkYUVAPixmapInfo::DataType values. Now supports all plane configurations tested by WackyYUVFormatsGM. Added WackyYUVFormatsGM that tests YUVA interface on SkImageGenerator. Change-Id: I8326f098f1453b9702f04ff366431a516ca160c3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317097 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-09-18 18:09:51 +00:00
* New YUVA planar specifications for SkCodec, SkImageGenerator, SkImage::MakeFromYUVAPixmaps.
Chroma subsampling is specified in more structured way. SkCodec and SkImageGenerator
don't assume 3 planes with 8bit planar values. Old APIs are deprecated.
A new way to specify YUVA planar data from SkCodec to SkImage_Lazy Tunnels through SkImageGenerator as well. The new SkCodec interface doesn't assume three 8 bit planes. New SkYUVASpec more clearly defines chroma subsampling and siting of the planes. The intent is to use this for other YUVA APIs as well, in particular SkImage factories in the future. In this change we convert to the SkYUVASpec to SkYUVASizeInfo and SkYUVAIndex[4] representation. But the intent is to use the SkYUVASpec representation throughout the pipeline once legacy APIs are removed. orientation GM is replicated to test a variety of chroma subsampling configs. Bug: skia:10632 Change-Id: I3fad35752b87cac16c51b24824331f2ae7d458d3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/309658 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
2020-08-24 13:18:16 +00:00
https://review.skia.org/309658
New helpers for SkYUVAInfo when used with pixmaps. SkYUVAPixmapInfo is a SkYUVAInfo with per-plane color types and row bytes. It describes a set of pixmaps that make up a planar image. Consolidates validity checks of the SkYUVAInfo with the color types and row bytes. It can provide SkImageInfos for each plane and also assist with configuring planes to share a common allocation. SkYUVAPixmaps is a collection of SkPixmaps that are valid for a SkYUVAInfo. It can either wrap existing SkPixmaps or allocate and own the memory. It consolidates validity checking of SkPixmaps with the SkYUVAInfo. Replaces sk_gpu_test::YUVAPixmaps. Minor tweaks to SkYUVAInfo naming, parameter order consistency, adds a hasAlpha() method. Bug: skia:10632 Change-Id: Ib0f48b8448fff22805fd0c04e07887d0b7338b76 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312886 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
2020-08-27 15:00:04 +00:00
https://review.skia.org/312886
Reland "Add idea of DataType to SkYUVAPixmapInfo." This is a reland of ed6344458750c0389b7ccce588b96d0c25397b19 Original change's description: > Add idea of DataType to SkYUVAPixmapInfo. > > DataType describes the data type of YUVA channels > independent of how they are grouped into planes. > > Adds mapping functions between SkColorType/channel count > and DataType. > > SkYUVAPixmapInfo can be constructed from DataType and will > choose appropriate SkColorTypes for each plane. > > Valid SkYUVAPixmapInfos now have the same DataType for each > plane (could relax this in the future, esp for alpha plane). > > SkYUVAPixmapInfo::SupportedDataTypes specifies the supported > combinations of SkYUVAInfo::PlanarConfig and > kYUVAPixmapInfo::DataType supported by a GrContext (based on > supported texture formats). > > SkImageGenerator/SkCodec YUVA query API now takes a > SupportedDataTypes. > > Change-Id: I8791234638e6ba3396d1e7960b7bc210edc6dd57 > Bug: skia:10632 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314276 > Reviewed-by: Leon Scroggins <scroggo@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Bug: skia:10632 Change-Id: I35b55b7477c11c822fdb3729a9f84acff1eb785d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315284 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-09-01 19:01:15 +00:00
https://review.skia.org/314276
Expand SkYUVAInfo::PlanarConfig/SkYUVAPixmapInfo::DataType values. Now supports all plane configurations tested by WackyYUVFormatsGM. Added WackyYUVFormatsGM that tests YUVA interface on SkImageGenerator. Change-Id: I8326f098f1453b9702f04ff366431a516ca160c3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317097 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-09-18 18:09:51 +00:00
https://review.skia.org/316837
https://review.skia.org/317097
A new way to specify YUVA planar data from SkCodec to SkImage_Lazy Tunnels through SkImageGenerator as well. The new SkCodec interface doesn't assume three 8 bit planes. New SkYUVASpec more clearly defines chroma subsampling and siting of the planes. The intent is to use this for other YUVA APIs as well, in particular SkImage factories in the future. In this change we convert to the SkYUVASpec to SkYUVASizeInfo and SkYUVAIndex[4] representation. But the intent is to use the SkYUVASpec representation throughout the pipeline once legacy APIs are removed. orientation GM is replicated to test a variety of chroma subsampling configs. Bug: skia:10632 Change-Id: I3fad35752b87cac16c51b24824331f2ae7d458d3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/309658 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
2020-08-24 13:18:16 +00:00
Add image usage flags to GrVkImageInfo Bug: skia:9898 Change-Id: I46a66d4415af0bb013201ce756e8dbceb9e234cf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/311437 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-08-21 15:26:12 +00:00
* Added VkImageUsageFlags to GrVkImageInfo struct.
add M86 branch release notes Bug: skia: Change-Id: I62331cab6cfadbaf9ab2f74e316cb7a2515249d0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312305 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-08-20 19:59:08 +00:00
* * *
Implement Direct3D semaphores Change-Id: Iadfa14965bbe11cfea556ade5d46e264f0ace61a Bug: skia:9935 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298752 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-06-25 17:10:29 +00:00
Milestone 86
------------
Remove unused GrFlushFlags. This also adds back default flush() calls which simply do a flush without any submit. Change-Id: Ia8c92bbdecd515d871abfa6364592f502e98656b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298818 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2020-06-30 17:42:46 +00:00
Remove 'in' variables from SkRuntimeEffect Runtime effects previously allowed two kinds of global input variables: 'in' variables could be bool, int, or float. 'uniform' could be float, vector, or matrix. Uniform variables worked like you'd expect, but 'in' variables were baked into the program statically. There was a large amount of machinery to make this work, and it meant that 'in' variables needed to have values before we could make decisions about program caching, and before we could catch some errors. It was also essentially syntactic sugar over the client just inserting the value into their SkSL as a string. Finally: No one was using the feature. To simplify the mental model, and make the API much more predictable, this CL removes 'in' variables entirely. We no longer need to "specialize" runtime effect programs, which means we can catch more errors up front (those not detected until optimization). All of the API that referred to "inputs" (the previous term that unified 'in' and 'uniform') now just refers to "uniforms". Bug: skia:10593 Change-Id: I971f620d868b259e652b3114f0b497c2620f4b0c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/309050 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2020-08-10 18:26:16 +00:00
* Remove support for 'in' variables from SkRuntimeEffect. API now exclusively refers to inputs
as 'uniforms'.
https://review.skia.org/309050
Add platform image encoder for using NDK APIs Bug: skia:10369 Add SkEncodeImageWithNDK, mirroring the CG and WIC versions, for encoding with the NDK APIs added to R. Rename SK_ENABLE_NDK_DECODING to SK_ENABLE_NDK_IMAGES and use it for both encoding and decoding. Move code for converting to/from NDK types into a common location. Update encode_platform.cpp to use NDK encoding APIs when available and to use both types of webp (lossy and lossless). Add tests specifically for the new implementation. Update NdkDecodeTest to use ToolUtils::equal_pixels for comparing pixels. Change-Id: Ic62f89af27372ccce90b8e028e01c388a135a68c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308800 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-05 20:51:10 +00:00
* Add SkImageGeneratorNDK and SkEncodeImageWithNDK for using Android's NDK APIs to decode and
encode.
https://review.skia.org/308185
https://review.skia.org/308800
Reland "Add an SkImageGenerator that uses NDK APIs" This reverts commit 07438b0cdaa326d5e4b969e03bfb67e0c8066f13. Bug: skia:10369 Bug: skia:10371 This will allow Skia clients developing for Android 11+ to rely on Android's NDK APIs for decoding, which will allow them to decode without including their own decoding libraries (e.g. libjpeg-turbo). Using these APIs also provides support for static HEIF images. Run ImageGenSrc in kPlatform_Mode on Android to verify decoding visually. Add tests and a grayscale png. Update some test bots running Android R to specify ndk_api so they will run the new code. Change-Id: I4ca07d832dbd6a9d8cff0faea975fd70da00718f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308185 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-08-05 14:44:17 +00:00
remove (unused) DirectTo... methods Change-Id: Ie5eea2902c64fc44e4e6e53b1ee3b869d430d482 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306331 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-07-28 21:24:21 +00:00
* SkImage:remove DecodeToRaster, DecodeToTexture
https://review.skia.org/306331
Reland "Add GrContext api to update compressed backend textures." This reverts commit ceebe424b1475ebdcf55f769e58b5e1a45b272c9. Reason for revert: relanding with fix Original change's description: > Revert "Add GrContext api to update compressed backend textures." > > This reverts commit 2c180304dc239a44770df7bf2649f3138f25922c. > > Reason for revert: attempted workaround did not fix techno spark so needs further investigation > > Original change's description: > > Add GrContext api to update compressed backend textures. > > > > Bug: chromium:1099255 > > Change-Id: I0c3f25ddb037e47e3b910fa89c3d8b3aa27b3114 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302265 > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com > > Change-Id: Ib5433def02dc5dad97dcdbd4476ced6de2361e6a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1099255 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302576 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1099255 Change-Id: Ie238a56b7f12fea8b6e251a050e5e2f4b20d2ede Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304741 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-07-22 16:09:26 +00:00
* Add GrContext api to update compressed backend textures.
https://review.skia.org/302265
Rename GrMipMapped GrMipmapped Change-Id: Ia2cfbca8982b57399b6681cbb4501c2933ab4df7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304576 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-07-21 13:27:25 +00:00
* Rename GrMipMapped to GrMipmapped for consistency with new APIs.
Rename GrBackendTexture::fMipMapped -> fMipmapped Also mipMapped params to GrBackendTexture functions to mipmapped GrBackendTexture::hasMipMaps -> GrBackendTexture::hasMipmaps Misc test vars fMipMapped -> fMipmapped Change-Id: Ic0651d14fc106c21b0ab45529875b95ed8dc2dfd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304598 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-07-21 14:32:07 +00:00
Also rename GrBackendTexture::hasMipMaps() to GrBackendTexture::hasMipmaps()
Rename GrMipMapped GrMipmapped Change-Id: Ia2cfbca8982b57399b6681cbb4501c2933ab4df7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304576 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-07-21 13:27:25 +00:00
https://review.skia.org/304576
Rename GrBackendTexture::fMipMapped -> fMipmapped Also mipMapped params to GrBackendTexture functions to mipmapped GrBackendTexture::hasMipMaps -> GrBackendTexture::hasMipmaps Misc test vars fMipMapped -> fMipmapped Change-Id: Ic0651d14fc106c21b0ab45529875b95ed8dc2dfd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304598 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-07-21 14:32:07 +00:00
https://review.skia.org/304598
Rename GrMipMapped GrMipmapped Change-Id: Ia2cfbca8982b57399b6681cbb4501c2933ab4df7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304576 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-07-21 13:27:25 +00:00
Add option for client to own semaphores after telling to skia to wait. Bug: chromium:1004772 Change-Id: Ifdad0b12925d13d3e896f6321c35312f9daa330c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/301216 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-07-08 15:44:25 +00:00
* Add option for clients to own semaphores after wait calls.
https://review.skia.org/301216
Remove unused GrFlushFlags. This also adds back default flush() calls which simply do a flush without any submit. Change-Id: Ia8c92bbdecd515d871abfa6364592f502e98656b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298818 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2020-06-30 17:42:46 +00:00
* Remove obsolete GrFlushFlags.
https://review.skia.org/298818
Add default flush calls to gpu backend. Change-Id: I7cd8ff975502128dbde86397218b7e5c115cdaa6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299141 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-06-26 01:00:17 +00:00
* Adds default flush() calls to SkSurface, SkImage, and GrContext. These calls do
Remove unused GrFlushFlags. This also adds back default flush() calls which simply do a flush without any submit. Change-Id: Ia8c92bbdecd515d871abfa6364592f502e98656b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298818 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2020-06-30 17:42:46 +00:00
a basic flush without a submit. If you haven't updated Skia in a couple releases
Add default flush calls to gpu backend. Change-Id: I7cd8ff975502128dbde86397218b7e5c115cdaa6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299141 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-06-26 01:00:17 +00:00
and still have flush() calls in your code that you expect to do a flush and
submit, you should update all those to the previously added flushAndSubmit() calls
instead.
https://review.skia.org/299141
Implement Direct3D semaphores Change-Id: Iadfa14965bbe11cfea556ade5d46e264f0ace61a Bug: skia:9935 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298752 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-06-25 17:10:29 +00:00
* Enable BackendSemaphores for the Direct3D backend.
https://review.skia.org/298752
Reland "Add async rescale and read APIs to SkImage." This reverts commit 1caf3789f8c6e7e8d50f08cd56a5b725922aa044. Makes the image GMs detect an abandoned context just like the surface GMs. Bug: skia:10431 Change-Id: I56a3631a75e6b0383f96a73f461cfa314ee29afa Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299379 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-06-26 17:32:09 +00:00
* Added SkImage:asyncRescaleAndReadPixels and SkImage::asyncRescaleAndReadPixelsYUV420
https://review.skia.org/299281
Remove all internal uses of (and deprecate) SkSurface::getContext We are replacing GrContext with the GrDirectContext/GrRecordingContext pair. This starts making that change visible to clients (and weaning Skia off of GrContext). Change-Id: I00cc9bf208499984de855a1646229bd7557fc925 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/300706 Reviewed-by: Adlai Holler <adlai@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-07-06 19:50:15 +00:00
* Ganesh is moving towards replacing GrContext with the GrDirectContext/GrRecordingContext
pair. GrDirectContexts have _direct_ access to the GPU and are very similar to the old
GrContext. GrRecordingContexts are less powerful contexts that lack GPU access but provided
context-like utilities during DDL recording. SkSurfaces and SkCanvas will now only return
GrRecordingContexts. Clients requiring context features that need GPU access can then
check (via GrRecordingContext::asDirectContext) if the available recording context is actually
a direct context.
Remove unnecessary macros from SkString header. They have been replaced with equivalent constants (and given the requisite k prefix). Change-Id: I70907eec234e0861cc97aac1ca03086faca42f9a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306160 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-07-28 13:23:54 +00:00
* Replace #defined values in SkString with equivalent constexprs.
http://review.skia.org/306160
Implement Direct3D semaphores Change-Id: Iadfa14965bbe11cfea556ade5d46e264f0ace61a Bug: skia:9935 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298752 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-06-25 17:10:29 +00:00
* * *
update release notes file, site for 84 branch Bug: skia: Change-Id: Icdc056e7972cad814fa633b7c9b021f4534d60c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290119 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-05-15 14:53:49 +00:00
Milestone 85
------------
Add GrContext::oomed() and implement for GL and VK. Surfaces to client whether GrContext has seen a GL_OUT_MEMORY, VK_ERROR_OUT_OF_HOST_MEMORY, or VK_ERROR_OUT_OF_DEVICE_MEMORY error. Bug: chromium:1093997 Change-Id: I8e9799a0f7d8a74df056629d7d1d07c0d0a0fe30 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298216 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-06-24 14:19:52 +00:00
* Added GrContext::oomed() which reports whether Skia has seen a GL_OUT_OF_MEMORY
error from Open GL [ES] or VK_ERROR_OUT_OF_*_MEMORY from Vulkan.
https://review.skia.org/298216
Add GrContext API to allow updating GrBackendSurfaceMutableState. This is currently only supported for the Vulkan backend Bug: skia:10254 Change-Id: I9274799098dc00dec5abcbcec95ce7cc23fec537 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293844 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-06-09 21:29:32 +00:00
Add SkSurface flush call that takes a GrBackendSurfaceMutableState. This new api will eventually replace the version that takes an SkSurface::BackendAccess. Change-Id: I48cd013725e14027f386b0b111223459944ac44a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295567 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-06-11 15:51:06 +00:00
* Add option on SkSurface::flush to pass in a GrBackendSurfaceMutableState which
we will set the gpu backend surface to be at the end of the flush.
https://review.skia.org/295567
Add GrContext API to allow updating GrBackendSurfaceMutableState. This is currently only supported for the Vulkan backend Bug: skia:10254 Change-Id: I9274799098dc00dec5abcbcec95ce7cc23fec537 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293844 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-06-09 21:29:32 +00:00
* Add GrContext function to set mutable state on a backend surface. Currently this
is only used for setting vulkan VkImage layout and queue family.
https://review.skia.org/293844
Always call release procs on SkSurface GPU factories Change-Id: Id1ca19630aea88200dfe2444aca1f8e9f679a616 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293762 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-06-03 02:01:39 +00:00
* SkSurface factores that take GrBackendTexture or GrBackendRenderTarget now always
Add GrContext API to allow updating GrBackendSurfaceMutableState. This is currently only supported for the Vulkan backend Bug: skia:10254 Change-Id: I9274799098dc00dec5abcbcec95ce7cc23fec537 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293844 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-06-09 21:29:32 +00:00
call the release proc (if provided) on failure. SkSurface::replaceBackendTexture
Always call release procs on SkSurface GPU factories Change-Id: Id1ca19630aea88200dfe2444aca1f8e9f679a616 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293762 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-06-03 02:01:39 +00:00
also calls the release proc on failure.
https://review.skia.org/293762
Remove submit from async read pixels. User must submit. Bug: chromium:1087118 Change-Id: Iab152ac483787fbdcca448aee0c4b9d2b354a92b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292840 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2020-06-02 15:47:26 +00:00
* SkSurface::asyncRescaleAndReadPixels and SkSurfaceasyncRescaleAndReadPixelsYUV420
now require explicit GrContext submit to guarantee finite time before callback
is invoked.
https://review.skia.org/292840
update release notes file, site for 84 branch Bug: skia: Change-Id: Icdc056e7972cad814fa633b7c9b021f4534d60c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290119 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-05-15 14:53:49 +00:00
Add support for vk image sharing mode and handle queues xfers correctly. Change-Id: I9dbe6020d67cc452c9cbbdeace68f1d01275b419 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293559 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
2020-06-02 15:10:41 +00:00
* Add VkSharingMode field to GrVkImageInfo.
https://review.skia.org/293559
Remove SkBitmapRegionDecoder and SkBRDAllocator Bug: skia:10154 Once ag/11371053 lands, Android will only be referencing the new version at android::skia::BitmapRegionDecoder. Remove the old code that remained for the transition. Change-Id: Ic532d705e8f2861f56dcaa0ac1c68dd2b0712035 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/291357 Commit-Queue: Leon Scroggins <scroggo@google.com> Auto-Submit: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
2020-05-21 15:14:31 +00:00
* Move SkBitmapRegionDecoder into client_utils/android.
[canvaskit] Make SkCanvas.drawColor/clear take SkColor4f CanvasKit converts 4 floats to an int, just to have it be converted back into 4 floats when it goes into the paint. Change-Id: I93cf1c596283b83cc9452fb205b7000ceed09bb9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293538 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-06-03 15:19:49 +00:00
* SkCanvas.clear and SkCanvas.drawColor now accept SkColor4f in addition to SkColor.
Remove SkSurface::MakeFromBackendTextureAsRenderTarget from public API Still some more work to do to remove internal usage. Bug: skia:9832 Change-Id: Id0403d92debc26af2002630a4dfcf960c9343260 Docs-Preview: https://skia.org/?cl=292719 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292719 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-05-28 21:44:05 +00:00
* Remove SkSurface::MakeFromBackendTextureAsRenderTarget.
This factory existed to work around issues with GL_TEXTURE_RECTANGLE that existed
in Chrome's command buffer. Those issues have since been resolved. Use
SkSurface::MakeFromBackendTexutre or SkSurface::MakeFromBackendRenderTarget instead.
https://review.skia.org/292719
Add submittedProc to GrFlushInfo. Bug: skia:10118 Change-Id: Iad848310d0f2fb22f19e9890209548fda103bd27 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/291078 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-05-26 15:26:45 +00:00
* Adds submittedProc callback to GrFlushInfo which will be called when the work
from the flush call is submitted to the GPU. This is specifically useful for knowing
when semahpores sent with the flush have been submitted and can be waiting on.
https://review.skia.org/291078
Reland "Implement submit API to GrContext." This reverts commit 9ee15d7b57075e2f8a533cfc9516aff0611a0ef3. Reason for revert: relanding with fixes Original change's description: > Revert "Implement submit API to GrContext." > > This reverts commit 40f288c72e4e836a2316cc058b5bb3aea92bde3f. > > Reason for revert: canvaskit breaking for some reason??? > > Original change's description: > > Implement submit API to GrContext. > > > > Change-Id: Ib813d42abb5f63e2ecdbf245d416658143853288 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289033 > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com,penghuang@chromium.org,vasilyt@chromium.org > > Change-Id: Iee6c8342cccc601edf64ea011f1303e5d72559a9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290917 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,penghuang@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because this is a reland. Change-Id: I5203676f88893cbbaba685301b8a713b40396b48 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290960 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-05-20 17:16:00 +00:00
* GrContext submit is now required to be called in order to send GPU work to the
actual GPU. The flush calls simply produces 3D API specific objects that are ready
to be submitted (e.g. command buffers). For the GL backend, the flush will still
send commands to the driver. However, clients should still assume the must call
submit which is where any glFlush that is need for sync objects will be called. There,
are flushAndSubmit() functions of GrContext, SkSurface, and SkImage that will act
like the previous flush() functions. This will flush the work and immediately call
submit.
https://review.skia.org/289033
Reland "Remove deprecated flush calls." This reverts commit 5e6d789ce47c8ce474b597073f7580602fcca467. Reason for revert: Relanding with fix landed in chrome Original change's description: > Revert "Remove deprecated flush calls." > > This reverts commit d8fd0bf5749c62302eb1d1c9f4eaab151d839341. > > Reason for revert: chrome roll > > Original change's description: > > Remove deprecated flush calls. > > > > Bug: skia:10118 > > Change-Id: I13758b5416784c296b8b5be9f3228230ac1be05f > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290540 > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com > > Change-Id: I49d35cdb258e632f645974c5ec62075d3392efe0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:10118 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290834 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com # Not skipping CQ checks because this is a reland. Bug: skia:10118 Change-Id: Ie24d7845a4ad75f95afe59037ea80a9f38082f13 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290918 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-05-19 22:06:26 +00:00
* Remove deprecated version of flush calls on GrContext and SkSurface.
https://review.skia.org/2290540
For vertices/patches with a shader and no texCoords, use positions This was another surprising (to me) inconsistency. Just because these geometric primitives allow for explicit local coords, doesn't mean we should require them (vs. all others that implicitly sample using local position). Change-Id: If3e7f6077bd15891b06cd2ffc969f1a649305d42 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290130 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-05-15 17:04:48 +00:00
* SkCanvas::drawVertices and drawPatch now support mapping an SkShader without explicit
texture coordinates. If they're not supplied, the local positions (vertex position or
patch cubic positions) will be directly used to sample the SkShader.
https://review.skia.org/290130
update release notes file, site for 84 branch Bug: skia: Change-Id: Icdc056e7972cad814fa633b7c9b021f4534d60c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290119 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-05-15 14:53:49 +00:00
* * *
Update release schedule, notes Bug: skia: Change-Id: I993eec22654edf93ea93e37282b0e08d19acd589 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281516 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-04-03 16:01:51 +00:00
Milestone 84
update release notes file, site for 84 branch Bug: skia: Change-Id: Icdc056e7972cad814fa633b7c9b021f4534d60c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290119 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-05-15 14:53:49 +00:00
------------
Add GrContext getter to SkSurface. Currently this is possible by getting the canvas off of surface and then getting the context off of the canvas. However, if in the future we wanted a surface that didn't have a canvas (maybe something that looked like a mutible image that only had a writePixels call), this would allow us to still get the GrContext. Bug: skia:10118 Change-Id: Ie8504bb708c1e4532edc8c7832ead86ae711e237 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289479 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-05-13 18:11:40 +00:00
Reland "Reland "Add api on GrContext to update the data of GrBackendTextures."" This reverts commit ed219fe171df7bdd9ca7ab4edb25a529cad75682. Reason for revert: relanding with fix Original change's description: > Revert "Reland "Add api on GrContext to update the data of GrBackendTextures."" > > This reverts commit 83c6626946d03dce41a2aaeaf562a471bcaaa848. > > Reason for revert: technospark is failing to upload pixmaps to non base mip levels > > Original change's description: > > Reland "Add api on GrContext to update the data of GrBackendTextures." > > > > This reverts commit 93ca54e0ac5b90e91ef8b54a9d581d9b9e84eb26. > > > > Reason for revert: relanding with fix > > > > Original change's description: > > > Revert "Add api on GrContext to update the data of GrBackendTextures." > > > > > > This reverts commit ac09f7cd7a283292e81d57e94936dfd3cc8ca018. > > > > > > Reason for revert: breaking bots, may need to use swizzled color for > > > correctness test > > > > > > Original change's description: > > > > Add api on GrContext to update the data of GrBackendTextures. > > > > > > > > Change-Id: I680f12bf58fc7b66a6b2f3fa4c4723ae84d3f949 > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288555 > > > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > > > > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com > > > > > > Change-Id: I47f41f536619ac13ca3ceeb216e7eaed9a9af255 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288630 > > > Reviewed-by: Greg Daniel <egdaniel@google.com> > > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com > > > > # Not skipping CQ checks because this is a reland. > > > > Change-Id: I82283b2437e523b80acead71c5f7c651180620db > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288631 > > Reviewed-by: Greg Daniel <egdaniel@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com > > Change-Id: I5d6614db8db59a69ded511726507a186596cfbd4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288907 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com # Not skipping CQ checks because this is a reland. Change-Id: I35fa1ae7dc47a697bbc358655f5c821942033234 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288909 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-05-13 19:32:04 +00:00
* Add api on GrContext, updateBackendTexture that will upload new data to a
GrBackendTexture.
https://review.skia.org/288909
Add GrContext getter to SkSurface. Currently this is possible by getting the canvas off of surface and then getting the context off of the canvas. However, if in the future we wanted a surface that didn't have a canvas (maybe something that looked like a mutible image that only had a writePixels call), this would allow us to still get the GrContext. Bug: skia:10118 Change-Id: Ie8504bb708c1e4532edc8c7832ead86ae711e237 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289479 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-05-13 18:11:40 +00:00
* Add GrContext getter to SkSurface.
https://review.skia.org/289479
A flush and submit apis to public headers. We add a new flushAndSubmit() to replace the current flush() call. In the future all other flush(GrFlushInfo) type calls will not do a submission of work to the GPU. Instead an explicit submit call will have to be made. flushAndSubmit will do a flush and submit. Also adds a no-op submit call. This allows us to stage the flush submit changes by updating all clients that use non simple flushes to add a submit call immediately after each flush. Then we can change the logic of where the submission happens from flush to submit without breaking folks. Bug: skia:10118 Change-Id: I4f02189a21912d52b888597c7734b4ca0baee792 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289478 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-05-13 18:07:40 +00:00
* Deprecate GrContext and SkSurface flush() call and replace ith with flushAndSubmit().
This only effects the default flush call that takes no parameters.
https://review.skia.org/289478
Update release schedule, notes Bug: skia: Change-Id: I993eec22654edf93ea93e37282b0e08d19acd589 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281516 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-04-03 16:01:51 +00:00
Add finisehd proc to backend texture creation. The callback lets the caller know when the data uploads to the texture from the create call are finished. This is important since the caller cannot delete the backend texture till the gpu is finished on vulkan and d3d. This change also removes the hard sync in vulkan during creation. Change-Id: I660d142219474e22b1337d2b0c81cda66fe18a4b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286517 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-05-06 15:40:03 +00:00
* GrContext::createBackendTexture functions that initialize the texture no longer
guarantee that all the data has been uploaded and the gpu is done with the texture.
Instead the client can assume the upload work has been submitted to the gpu and they
must wait for that work to finish before deleting the texture. This can be done via
their own synchronization or by passing in a finish proc into the create calls which
will be called when it is safe to delete the texture (at least in terms of work
done during the create).
https://review.skia.org/286517
Update release schedule, notes Bug: skia: Change-Id: I993eec22654edf93ea93e37282b0e08d19acd589 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281516 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-04-03 16:01:51 +00:00
remove unused maskfilter helpers: Combine, Compose Change-Id: I8c6bf2c3539905c9c7bc9c29454322dbf944fe96 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/287823 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2020-05-05 18:40:42 +00:00
* Remove unused SkMaskFilter helpers: compbine, compose
Note: shadermaskfilter will likely be removed next (clipShader should serve)
Restore SkCanvas::kPreserveLCDText_SaveLayerFlag Will use this in Chrome to support LCDText in saveLayer/restore with opacity. This partly reverts https://skia-review.googlesource.com/c/skia/+/181841. Bug: 1076019 Change-Id: Id870fb1dcc95c9b319797e936725b4447a97d1d5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285956 Commit-Queue: Florin Malita <fmalita@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
2020-05-01 16:34:57 +00:00
* Add back SkCanvas::kPreserveLCDText_SaveLayerFlag to indicate that saveLayer()
will preserve LCD-text. All text in the layer must be drawn on opaque background
to ensure correct rendering.
Reland "Move SkFrontBufferedStream into Android-only dir" This reverts commit b25f30348bfee972b509fd4a13a0de99e89caa6a. Bug: skia:10154 Original message: > Add client_utils for code that is specifically for a single client. > Move SkFrontBufferedStream into its android/ subdir. Rename the class > to android::skia::FrontBufferedStream. Temporarily leave in > SkFrontBufferedStream until Android updates to the new API. > > Add a new optional target for client_utils/android. It is built in dev > builds for testing, and when building for the Android framework. Deliberately do not include client_utils in Google3, since the whole point is to only include where necessary. Change-Id: I48938c56aabb98e1ed820240d43ffcd0fdce7956 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285104 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-04-24 17:00:48 +00:00
* Add the new directory client_utils/ for code that is specific to a single client and
should be considered separate from Skia proper. Move SkFrontBufferedStream into the
subdir android/.
add SkColorSpace param to SkPixmap::erase() We don't have a way to erase with a non-sRGB color. Update the P3 gm to test this, removing the SkBitmap erase case where there's no option for even an SkColor4f, let alone non-sRGB. I'm not sure it's really important to have one when we've got this on pixmap. Updated release notes. Change-Id: Ie98270d3f83e041593b4c6b2da8e325b36d4ff18 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285341 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-04-24 12:44:50 +00:00
* SkBitmap and SkPixmap's erase() methods now treat their color parameters
consistently with the rest of Skia, with all SkColors and any untagged
SkColor4fs interpreted as sRGB, not as a color in the bitmap's color space.
SkPixmap::erase(SkColor4f) now takes an SkColorSpace, so you can pass
pixmap.colorSpace() if you want the old behavior.
SkMatrix44 is deprecated: use SkM44 instead Change-Id: I9a269b9c0c3cda29d06827d016db3a3f963a91fd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283504 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-04-14 19:44:21 +00:00
* SkCamera.h and SkMatrix44.h are DEPRECATED.
SkCamera.h is deprecated Change-Id: I57bd99f2bddb7ac182f7830245c9d342d2adda62 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283430 Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-04-14 15:35:40 +00:00
Use SkM44 if you want to have 3d transformations.
Take MorphologyImageFilter radii as SkScalar. The morphology image filters work on pixels, so took the radii as integers. However, these radii will be mapped through the CTM, so any rounding should happen as late as possible or the effect will be overly discretized. Bug: skia:10110 Change-Id: I62ab6c37d0b4612690addc48c9bc473099ac36b9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/282636 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2020-04-09 17:00:44 +00:00
* Changed Dilate and Erode image filters to take SkScalar for radius instead of int. While
the image filters themselves are defined in terms of discrete pixels, the radii provided by
the user are mapped through the CTM so taking ints forced over discretization. After mapping
through the CTM the radii are now rounded to pixels.
https://review.skia.org/281731
https://review.skia.org/282636
Update gpu flush semaphore contract. From my scanning of clients this should not change how any of our main users interact with semaphores. The biggest change here is that we don't give up on submitted all the semaphores if a creation fails. We just submit the semaphores we do have. It also makes it explicit that the client is responsible for deleting any initialized semaphore regardless if we were able to submit the semaphores or not or if the semaphore was wrapped or created by Skia. The motivation for this change is to more align the current API with how things will work when we separate flushing and submit into different calls. Bug: skia:10118 Change-Id: I3e8b5d3a9852ddb2b5dc972fee21bf46ded7a36f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/282265 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-04-08 16:52:51 +00:00
* Updated the contract of GrContext and SkSurface flush calls in regards to semaphores. Made it
clear that the caller is responsible for deleting any initialized semaphores after the flush
call regardless if we were able to submit them or not. Also, allows skia to only submit a
subset of the requested semaphores if we failed to create some.
https://review.skia.org/282265
Remove secret wireframe mode from drawVertices Now, drawing vertices without colors or a shader simply fills with the paint color, like anyone would expect. Bug: skia:9984 Change-Id: I9f7cf72f89948756b9c2c6e055a11c6b64fc22ff Reviewed-on: https://skia-review.googlesource.com/c/skia/+/282043 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-04-07 17:48:15 +00:00
* SkCanvas::drawVertices will now always fill the triangles specified by the vertices. Previously,
vertices with no colors and no (texture coordinates or shader) would be drawn in wireframe.
https://review.skia.org/282043
Update release schedule, notes Bug: skia: Change-Id: I993eec22654edf93ea93e37282b0e08d19acd589 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281516 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-04-03 16:01:51 +00:00
* * *
fix up release notes file for milestone 83 Bug: skia: Change-Id: Ia83f2b69948eeb747ecc171fb8677c8e22cc8ba7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277176 Reviewed-by: Heather Miller <hcm@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-03-16 14:50:49 +00:00
Milestone 83
update release notes file, site for 84 branch Bug: skia: Change-Id: Icdc056e7972cad814fa633b7c9b021f4534d60c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290119 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-05-15 14:53:49 +00:00
------------
Fix up release notes file Bug: skia: Change-Id: I124abbb54f13e70e5d9c6a71f43cea5adf0ce49a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250038 Auto-Submit: Heather Miller <hcm@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-22 19:45:45 +00:00
remove localmatrix parameter from Blend and Lerp compose shaders Bug: skia:10080 Change-Id: I936d6d696c86c50d5b51dc84894127c38ad753d4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/279048 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2020-03-25 17:13:20 +00:00
* Remove localmatrix option from SkShaders::[Blend, Lerp]
Flesh out backend textures and rendertargets to support Direct3D. Add GrD3DTextureInfo and GrD3DBackendSurfaceInfo, and uses those to initialize GrBackendTexture and GrBackendRendertarget. Bug: skia:9935 Change-Id: I4571c1b3aa8115250ff748deb8cf4a95f80f1237 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278036 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2020-03-20 15:23:39 +00:00
* Fill out Direct3D parameters for backend textures and backend rendertargets.
Add SkBudgeted parameter to SkImage::makeTextureImage(). Also strengthens/adds some guarantees about this function: * Always returns the same image if the original is texture-backed and compatible with GrMipMapped (WRT HW MIP support) * If a new texture backed image is returned it is always an uncached texture that is not shared with another image or owned by an image generator. Adds a GrImageTexGenPolicy that allows control through image/bitmap GrTextureProducers of whether a new texture must be made and whether that texture should be budgeted or not. Increases unit test coverage of this API. Bug: skia:8669 Change-Id: Ifc0681856114a08fc8cfc57ca83d22efb1c1f166 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274938 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-03-18 14:06:13 +00:00
* SkImage::makeTextureImage() takes an optional SkBudgeted param
Remove drawBitmap et al. from SkDevice SkCanvas keeps its non-exotic drawBitmap calls for now but they immediately wrap the bitmap in SkImage::MakeFromBitmap. This will add a copy for mutable bitmaps, but this can be worked around by using images directly (preferred), or marking the bitmap as immutable. In practice, mutable bitmaps do not seem to be widely used so this is deemed acceptable for now. Several GMs are updated to mark the bitmaps as immutable in order to avoid pixel churn in how CPU vs. GPU mipmaps are generated. As we move towards explicit mipmap generation, this distinction will become less critical, so I'm just avoiding it for now. See skbug.com/9337 for mipmap proposal. The image diffs encountered in this CL directly related to generating mipmaps for bitmaps already cached on the GPU vs. not on the GPU yet. It was decided to copy if mutable vs. never copying the bitmap because it preserves the image guarantees the devices and canvas' rely on, and imposing the need to inspect an image for mutability is undesired. Bug: skia:10037, skia:9337 Change-Id: If152e6cae1e155ccf6bd2cd755895f3c7a0135a5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276004 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-03-12 14:52:15 +00:00
Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" Updated to use sentinel GL context even when GL backend is not built. This reverts commit 1171d314efc7e131b039c94126d26575cfb9e70c. Change-Id: Ia94bbe4865ddd4e898446c13886877c539f0eb0b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277976 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-03-19 19:54:28 +00:00
* Made non-GL builds of GPU backend more robust.
https://review.skia.org/277456
* MoltenVK support removed. Use Metal backend instead.
https://review.skia.org/277612
fix up release notes file for milestone 83 Bug: skia: Change-Id: Ia83f2b69948eeb747ecc171fb8677c8e22cc8ba7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277176 Reviewed-by: Heather Miller <hcm@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-03-16 14:50:49 +00:00
* * *
Milestone 82
update release notes file, site for 84 branch Bug: skia: Change-Id: Icdc056e7972cad814fa633b7c9b021f4534d60c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290119 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-05-15 14:53:49 +00:00
------------
fix up release notes file for milestone 83 Bug: skia: Change-Id: Ia83f2b69948eeb747ecc171fb8677c8e22cc8ba7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277176 Reviewed-by: Heather Miller <hcm@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-03-16 14:50:49 +00:00
Remove drawBitmap et al. from SkDevice SkCanvas keeps its non-exotic drawBitmap calls for now but they immediately wrap the bitmap in SkImage::MakeFromBitmap. This will add a copy for mutable bitmaps, but this can be worked around by using images directly (preferred), or marking the bitmap as immutable. In practice, mutable bitmaps do not seem to be widely used so this is deemed acceptable for now. Several GMs are updated to mark the bitmaps as immutable in order to avoid pixel churn in how CPU vs. GPU mipmaps are generated. As we move towards explicit mipmap generation, this distinction will become less critical, so I'm just avoiding it for now. See skbug.com/9337 for mipmap proposal. The image diffs encountered in this CL directly related to generating mipmaps for bitmaps already cached on the GPU vs. not on the GPU yet. It was decided to copy if mutable vs. never copying the bitmap because it preserves the image guarantees the devices and canvas' rely on, and imposing the need to inspect an image for mutability is undesired. Bug: skia:10037, skia:9337 Change-Id: If152e6cae1e155ccf6bd2cd755895f3c7a0135a5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276004 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-03-12 14:52:15 +00:00
* Removed drawBitmap and related functions from SkDevice; all public drawBitmap functions on
SkCanvas automatically wrap the bitmap in an SkImage and call the equivalent drawImage function.
Drawing mutable SkBitmaps will now incur a mandatory copy. Switch to using SkImage directly or
mark the bitmap as immutable before drawing.
SkVertices: Remove volatile/nonvolatile bit No one was using this, and it added significant complexity to GrDrawVerticesOp. Bug: skia:9984 Change-Id: I23f38b3f5d853a8e531f13b6931cd57b5985a2c8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276407 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-03-11 16:26:56 +00:00
* Removed "volatile" flag from SkVertices. All SkVertices objects are assumed to be
volatile (the previous default behavior).
Remove drawBitmap et al. from SkDevice SkCanvas keeps its non-exotic drawBitmap calls for now but they immediately wrap the bitmap in SkImage::MakeFromBitmap. This will add a copy for mutable bitmaps, but this can be worked around by using images directly (preferred), or marking the bitmap as immutable. In practice, mutable bitmaps do not seem to be widely used so this is deemed acceptable for now. Several GMs are updated to mark the bitmaps as immutable in order to avoid pixel churn in how CPU vs. GPU mipmaps are generated. As we move towards explicit mipmap generation, this distinction will become less critical, so I'm just avoiding it for now. See skbug.com/9337 for mipmap proposal. The image diffs encountered in this CL directly related to generating mipmaps for bitmaps already cached on the GPU vs. not on the GPU yet. It was decided to copy if mutable vs. never copying the bitmap because it preserves the image guarantees the devices and canvas' rely on, and imposing the need to inspect an image for mutability is undesired. Bug: skia:10037, skia:9337 Change-Id: If152e6cae1e155ccf6bd2cd755895f3c7a0135a5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276004 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-03-12 14:52:15 +00:00
* Removed exotic legacy bitmap functions from SkCanvas (drawBitmapLattic, drawBitmapNine); the
exotic SkImage functions still exist.
Reland "Split building encoding from decoding" This reverts commit 9d4b788807fcca010399c0987aed41b3af5d938f. Copyright issue has been fixed in https://skia-review.googlesource.com/c/skia/+/275998. Original description: Bug: skia:9756 In CanvasKit, a large part of the binary is for encoding. Clients would be happier with a smaller binary and no webp/jpeg encoding. Make this an option by splitting up the GN arguments. Split SK_HAS_WEBP_LIBRARY into SK_CODEC_DECODES_WEBP (to match the existing SK_CODEC_DECODES_RAW) and SK_ENCODE_WEBP. Same for JPEG and PNG. Update CanvasKit compile script to disable webp and jpeg encoding. Update debugger compile script to disable all encoding. Change IsPng signature to match other SkCodecs. TBR=djsollen@google.com Change-Id: Ic847bae0154e0a2922100b3f2ee14a077ee5635a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276007 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-03-09 18:23:30 +00:00
* Make it possible to selectively turn on/off individual encoders/decoders,
using skia_use_(libpng/libjpeg_turbo/libwebp)(decode/encode).
Reland "Move GrGpuResource GrSurface and GrTexture into src." This reverts commit f6ed96d1c23b79130ca7344c984b07ef9d94fb7b. Reason for revert: google3 change landed Original change's description: > Revert "Move GrGpuResource GrSurface and GrTexture into src." > > This reverts commit e5a06ce678aad7640411f99f70f220f82ad49908. > > Reason for revert: Need to make change in google3 first > > Original change's description: > > Move GrGpuResource GrSurface and GrTexture into src. > > > > Must land https://chromium-review.googlesource.com/c/chromium/src/+/2087980 > > before this can land. > > > > Bug: skia:7966 > > Change-Id: I60bbb1765bfbb2c96b2bc0c9826b6b9d57eb2a03 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275077 > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com > > Change-Id: Id39e0a351e49a87209de88a6ad9fadb0219db72c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7966 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275216 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: I746ce739cb084cefc46f9dab24ef773e7c3cc621 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7966 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275436 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-03-05 19:14:18 +00:00
* Removed GrGpuResource, GrSurface, and GrTexture from public api. These were not
Remove SkImage getTexture call. Change-Id: Ib9f3d8c58ee5736bfee03eaedff20f24b51d5ff9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275625 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-03-06 18:07:10 +00:00
meant to be public, and we now can move them into src. Also removed getTexture
function from SkImage.h
Reland "Move GrGpuResource GrSurface and GrTexture into src." This reverts commit f6ed96d1c23b79130ca7344c984b07ef9d94fb7b. Reason for revert: google3 change landed Original change's description: > Revert "Move GrGpuResource GrSurface and GrTexture into src." > > This reverts commit e5a06ce678aad7640411f99f70f220f82ad49908. > > Reason for revert: Need to make change in google3 first > > Original change's description: > > Move GrGpuResource GrSurface and GrTexture into src. > > > > Must land https://chromium-review.googlesource.com/c/chromium/src/+/2087980 > > before this can land. > > > > Bug: skia:7966 > > Change-Id: I60bbb1765bfbb2c96b2bc0c9826b6b9d57eb2a03 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275077 > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com > > Change-Id: Id39e0a351e49a87209de88a6ad9fadb0219db72c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7966 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275216 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: I746ce739cb084cefc46f9dab24ef773e7c3cc621 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7966 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275436 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-03-05 19:14:18 +00:00
remove bones from SkVertices Bug: skia:9984 Change-Id: I7c4f33ee82087eb1b0a60243183f0c68e310f10d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274547 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-02 19:57:09 +00:00
* Removed Bones from SkVertices
Add GrContextOption for GL error checking, shader, and program success. Small behavior change: will not check for shader success and program linking success over the command buffer in a debug build. Also fail gracefully if stencil renderbuffer allocation fails. Bug: skia:9938 Bug: chromium:1040186 Change-Id: I623f09d306261d28070078268f6242f92d65fd5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273276 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-02-25 17:13:29 +00:00
* Added a field to GrContextOptions that controls whether GL errors are checked after
GL calls that allocate textures, etc. It also controls checking for shader compile
success, and program linking success.
Add a program iterator to SkDeferredDisplayList Bug: skia:9455 Change-Id: I201218174b5d6efb72f7c06766a49f6711325bd5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272530 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-02-24 13:38:34 +00:00
* Made SkDeferredDisplayList.h officially part of the public API (i.e., moved it to
include/core). Also added a ProgramIterator to SkDeferredDisplayList which allows
clients to pre-compile some of the shaders the DDL requires.
Add createBackendFormat and createFBO0 helper methods to SkSurfaceCharacterization These make it easier for clients to create new surface characterizations that differ only a little from an existing surface characterization. Change-Id: Iebd0b32ae941d3f91427927108d092cb5864b09f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/270444 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-02-13 18:24:47 +00:00
* Added two new helper methods to SkSurfaceCharacterization: createBackendFormat and
createFBO0. These make it easier for clients to create new surface characterizations that
differ only a little from an existing surface characterization.
Remove SkTMin and SkTMax Use std::min and std::max everywhere. SkTPin still exists. We can't use std::clamp yet, and even when we can, it has undefined behavior with NaN. SkTPin is written to ensure that we return a value in the [lo, hi] range. Change-Id: I506852a36e024ae405358d5078a872e2c77fa71e Docs-Preview: https://skia.org/?cl=269357 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269357 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-02-07 15:36:46 +00:00
* Removed SkTMax and SkTMin.
Replace usage of SkTClamp with SkTPin I prefer the SkTClamp spelling, but there were 4 uses vs. ~200. And eventually we'll replace all of these with std::clamp anyway. Change-Id: I418fce5080d089745c3f9eb42c36e3fc7962c895 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269155 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-02-06 19:51:46 +00:00
* Removed SkTClamp and SkClampMax.
Remove SkScalarClampMax and SkScalarPin Change-Id: Ic96a0ea2cd1bfd59ee3f236543e1d6dd102544ec Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269142 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-02-06 17:52:25 +00:00
* Removed SkScalarClampMax and SkScalarPin.
Remove SkMin32/SkMax32 Use std::max and std::min instead Change-Id: I7fd2626ea9ea8ea09c709ff962523ca3de2f8a16 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269136 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-02-06 16:25:43 +00:00
* Removed SkMax32 and SkMin32.
Remove SkMaxScalar and SkMinScalar Use std::max and std::min instead Change-Id: Icf3796609e5cb511687fb50bd31229ae4b6b9b39 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268841 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-02-05 18:34:09 +00:00
* Removed SkMaxScalar and SkMinScalar.
SkColorSetA now warns if the result is unused. Change-Id: Ie0d2ec6e1ca1ddeb83338df232570443502e6cdb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268697 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-02-04 22:27:22 +00:00
* SkColorSetA now warns if the result is unused.
Allow decoding without color conversion Bug: b/135133301 Especially for the Android NDK, which may not be able to report the default profile, we should be able to decode the image without doing any color correction. That way if the client wants to figure out the color profile on their own (e.g. by parsing the data manually), they can retrieve the un-corrected pixels and treat them appropriately. Note that internally, we still require a destination profile for F16, but we will use the source profile if there is one, or SRGB for source and destination otherwise. Regardless, this will result in no color correction. Change-Id: Id1157bb99d3119a114b25f64b38620480a027f34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/268157 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-02-03 17:39:54 +00:00
* An SkImageInfo with a null SkColorSpace passed to SkCodec::getPixels() and
related calls is treated as a request to do no color correction at decode
time.
Remove CGFontRef parameter from SkMakeTypefaceFromCTFont Since the Blink side CTFontRefs are no longer created from CGFontRefs after [1], we do not need to pass CGFontRefs to Skia any longer for keeping them alive. Clean up related plumbing which previously passed through the CGFontRef to the SkTypefaceMac constructor. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1964073 Bug: chromium:1033478 Change-Id: Ic85cae6289fa9b4886201c92defb54fcc5622720 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266816 Reviewed-by: Dominik Röttsches <drott@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-01-31 16:13:37 +00:00
Re-land: Support adding attributes to PDF document structure nodes. Originally landed: https://skia-review.googlesource.com/c/skia/+/268878 Reverted: https://skia-review.googlesource.com/c/skia/+/271858 The issue was with compilation when PDF support is disabled. See the diff between patchsets 1 and 2. This is an important part of writing a tagged PDF. Many of the nodes in the document structure tree need additional attributes, just like in HTML. This change aims to add support for a few useful attributes, not to be comprehensive. Bug: chromium:1039816 Change-Id: I15f8b6c41d4fdaa4b6e21775ab6d26ec57eb0f5d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271916 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
2020-02-19 18:59:29 +00:00
* Add new APIs to add attributes to document structure node when
creating a tagged PDF.
Remove CGFontRef parameter from SkMakeTypefaceFromCTFont Since the Blink side CTFontRefs are no longer created from CGFontRefs after [1], we do not need to pass CGFontRefs to Skia any longer for keeping them alive. Clean up related plumbing which previously passed through the CGFontRef to the SkTypefaceMac constructor. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1964073 Bug: chromium:1033478 Change-Id: Ic85cae6289fa9b4886201c92defb54fcc5622720 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266816 Reviewed-by: Dominik Röttsches <drott@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-01-31 16:13:37 +00:00
* Remove CGFontRef parameter from SkCreateTypefaceFromCTFont.
Use CTFontManagerCreateFontDescriptorFromData instead of
CGFontCreateWithDataProvider to create CTFonts to avoid memory use issues.
Allow decoding without color conversion - part 2 Bug: b/135133301 Follow-on to 196f319b. - Add SkCodec::getICCProfile to match the SkAndroidCodec version. - Update comments on getPixels() regarding how the SkColorSpace on the SkImageInfo is treated. - Add two new images that have ICC profiles that do not map to an SkColorSpace. Add a test to verify that they have the un-transformed color we expect. - Stop uploading ColorCodecSrc images decoded to a null SkColorSpace to Gold. Though they may be correct, they do not match other images they're compared against. The new test above verifies that we do not do color conversion with a null SkColorSpace. Change-Id: I08635e4262f16500fab32ef97511d305c2c06483 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269236 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-02-06 20:47:58 +00:00
* Added SkCodec:: and SkAndroidCodec::getICCProfile for reporting the native
ICC profile of an encoded image, even if it doesn't map to an SkColorSpace.
new section and formatting Bug: skia: Change-Id: I759f2eb1ee26245ba3d3c971e030793b9c52aa5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267820 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2020-01-30 18:57:13 +00:00
Update SkSurface::ReplaceBackendTexture to take ContentChangeMode In SkSurface::ReplaceBackendTexture, it used to always retain a copy of the the current content. The ContentChangeMode is added as a parameter to allow the callers to decide whether retain or discard the current content. Bug: 1014246 Change-Id: I8736e7795b4755bbde94009ffe4d943c75112b98 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271016 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
2020-02-14 23:10:40 +00:00
* SkSurface::ReplaceBackendTexture takes ContentChangeMode as a parameter,
which allow callers to specify whether retain a copy of the current content.
Remove drawBitmap et al. from SkDevice SkCanvas keeps its non-exotic drawBitmap calls for now but they immediately wrap the bitmap in SkImage::MakeFromBitmap. This will add a copy for mutable bitmaps, but this can be worked around by using images directly (preferred), or marking the bitmap as immutable. In practice, mutable bitmaps do not seem to be widely used so this is deemed acceptable for now. Several GMs are updated to mark the bitmaps as immutable in order to avoid pixel churn in how CPU vs. GPU mipmaps are generated. As we move towards explicit mipmap generation, this distinction will become less critical, so I'm just avoiding it for now. See skbug.com/9337 for mipmap proposal. The image diffs encountered in this CL directly related to generating mipmaps for bitmaps already cached on the GPU vs. not on the GPU yet. It was decided to copy if mutable vs. never copying the bitmap because it preserves the image guarantees the devices and canvas' rely on, and imposing the need to inspect an image for mutability is undesired. Bug: skia:10037, skia:9337 Change-Id: If152e6cae1e155ccf6bd2cd755895f3c7a0135a5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276004 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-03-12 14:52:15 +00:00
* Enforce the existing documentation in SkCanvas::saveLayer that it ignores
any mask filter on the restore SkPaint. The 'coverage' of a layer is
Enforce saveLayer ignoring restore paint's mask filter Documentation specifies that only the alpha, color filter, image filter and blend mode are used when restoring the saved layer. The coverage that would be sent to the mask filter is ill-defined, whereas the explicit boundary of the separate clip image gets around this. This also removes the issue of the order in which the mask filter and image filter would be applied. Some GMs exercised the save layer with mask filter, but those have been updated to either expect the MF to be ignored, or modified to no longer use saveLayer+MF. While Android and Flutter expose a saveLayer with general Paint API, their documentation matches SkCanvas so hopefully no one is actually relying on the mask filter in those cases. It does not appear as if Chrome ever tries to use a saveLayer+MF. Bug: skia:9561 Change-Id: I67a350fbf565683ea60ea88f83a91270e7dcd187 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274508 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-03-03 15:39:41 +00:00
ill-defined, and masking should be handled by pre-clipping or using the
auxiliary clip mask image of the SaveLayerRec.
Update SkSurface::ReplaceBackendTexture to take ContentChangeMode In SkSurface::ReplaceBackendTexture, it used to always retain a copy of the the current content. The ContentChangeMode is added as a parameter to allow the callers to decide whether retain or discard the current content. Bug: 1014246 Change-Id: I8736e7795b4755bbde94009ffe4d943c75112b98 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271016 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
2020-02-14 23:10:40 +00:00
new section and formatting Bug: skia: Change-Id: I759f2eb1ee26245ba3d3c971e030793b9c52aa5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267820 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2020-01-30 18:57:13 +00:00
* * *
Milestone 81
update release notes file, site for 84 branch Bug: skia: Change-Id: Icdc056e7972cad814fa633b7c9b021f4534d60c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290119 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-05-15 14:53:49 +00:00
------------
new section and formatting Bug: skia: Change-Id: I759f2eb1ee26245ba3d3c971e030793b9c52aa5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267820 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2020-01-30 18:57:13 +00:00
Add functions for GL_NV_fence to GrGLInterface. Also add macro for ALL_COMPLETED We plan to use this with ANGLE ES2 contexts. Change-Id: I6c967fa9b9aefc41c31cd806aece8533f846f940 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/265756 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-01-22 14:59:56 +00:00
* Added support for GL_NV_fence extension.
Update release notes files Docs-Preview: https://skia.org/?cl=258417 Bug: skia: Change-Id: I4716231ad260f2f7f29776f7cc455c6837ec6a43 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258417 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2019-12-05 20:27:42 +00:00
Make SkImageInfo::validRowBytes consider alignment SkSurface will already reject a rowBytes that does not align on a pixel boundary. Push that check into SkImageInfo. This will make SkBitmap, SkPixmap, SkMallocPixelRef, and SkImage_Raster, which already call validRowBytes, make the same check. If an SkSurface cannot use a non-pixel-aligned rowBytes, then an SkCanvas wrapping an SkBitmap should not either. Update MallocPixelRefTest to use a rowBytes that is still valid. Change-Id: I848d94dbeab8b58b92877104dd67ea23a9d19ca8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/265599 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com>
2020-01-22 15:44:00 +00:00
* Make SkImageInfo::validRowBytes require rowBytes to be pixel aligned. This
makes SkBitmap match the behavior of raster SkSurfaces in rejecting
non-aligned rowBytes.
Add SkImage::MakeRasterFromCompressed and make MakeFromCompressed fall back to decompression for unsupported compression types (take 2) This is intended to make using compressed textures easier since developers can just provided compressed data and it will be uploaded to the GPU in some way, shape or form. TBR=reed@google.com Change-Id: I8c672ccc7db5cd098f629c3469ae7cbdc7436392 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266939 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-01-27 21:11:57 +00:00
* Added an SkImage::MakeRasterFromCompressed entry point. Also updated
SkImage::MakeFromCompressed to decompress the compressed image data if
the GPU doesn't support the specified compression type (i.e., macOS Metal
doesn't support BC1_RGB8_UNORM so such compressed images will always be
decompressed on that platform).
Add SkImage::CompressionType::kBC1_RGBA8_UNORM support This is mainly so we can test the compression code on macOS. Bug: skia:9680 Change-Id: Ie0a2eacfe9100ee4ce4cc94c878d3032d6985832 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/264480 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-01-15 17:56:52 +00:00
* Added support for BC1 RGBA compressed textures
Add CachingHint to makeRasterImage, default to kDisallow When a client calls makeRasterImage, they're likely to hold on to that image, and throw away the source (GPU or Lazy). In that situation, it makes no sense to leave the buffer in the resource cache. Change-Id: Ic0be8ceb643ed9196526469516be0d200bea42fd Bug: b/144232910 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263347 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-01-09 15:21:44 +00:00
* Added CachingHint to SkImage::makeRasterImage
[canvaskit] Create an SkImage from a frame of an SkAnimatedImage Flutter on the web wants to be able to extract arbitrary frames from an animated image and pass those into functions like: drawAtlas, drawImage, drawImageRect This should allow that to happen w/o having to add lots of variants like drawAnimatedImage. If this sticks, is drawAnimatedImage still useful? (maybe it saves a copy?) Change-Id: I99d7045c5dea61d0a1bd6d335c88e7517f2c4fc2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263020 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-01-08 18:29:31 +00:00
* Added SkAnimatedImage::getCurrentFrame()
Add method to delay drawable acquisition from MTKView Change-Id: Iad9fadd113d0c97e8ece51df19c7824252d7eb9c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263197 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2020-01-08 17:15:44 +00:00
* Add support to create an SkSurface from an MTKView, with delayed acquisition of
the MTLDrawable.
Entry point: SkSurface::MakeFromMTKView
Remove SkIRect::EmptyIRect Replace with SkIRect::MakeEmpty. Docs-Preview: https://skia.org/?cl=262382 Change-Id: I001cc76f4af223490be3734bb461ab4fca36d710 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/262382 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-01-06 20:20:18 +00:00
* Removed SkIRect::EmptyIRect(). Use SkIRect::MakeEmpty() instead.
https://review.skia.org/262382/
new section and formatting Bug: skia: Change-Id: I759f2eb1ee26245ba3d3c971e030793b9c52aa5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267820 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2020-01-30 18:57:13 +00:00
* Moved SkRuntimeEffect to public API. This is the new (experimental) interface to custom SkSL
shaders and color filters.
Move SkRuntimeEffect.h to include/effects Change-Id: I0b11d4210c6e663cfb4854fc33e1396fd79fe9a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261780 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-01-02 16:55:24 +00:00
new section and formatting Bug: skia: Change-Id: I759f2eb1ee26245ba3d3c971e030793b9c52aa5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267820 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2020-01-30 18:57:13 +00:00
* Added BC1 compressed format support. Metal and Vulkan seem to only support the BC
formats on desktop machines.
Add BC1_RGB8_UNORM support This is working in the GL and Vulkan back ends. MacOS only supports the RGBA8 variants. For mobile devices, probably only nVidia GPUs will support this. Bug: skia:9680 Change-Id: I9d886b72232a031603e93e46059a97a8aa288b3c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261093 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-12-20 16:32:27 +00:00
new section and formatting Bug: skia: Change-Id: I759f2eb1ee26245ba3d3c971e030793b9c52aa5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267820 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2020-01-30 18:57:13 +00:00
* Added compressed format support for backend texture creation API.
This adds the following new entry points:
GrContext::compressedBackendFormat
GrContext::createCompressedBackendTexture
The latter method comes in variants that allow color-initialized and
compressed texture data initialized.
Add interface(s) for compressed backend texture support This is just the API level interface(s) and the backend virtual calls needed to implement them. Bug: skia:9680 Change-Id: I6c655751e23ce18c6a184c925e8d472902e8a478 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259976 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-12-17 19:44:37 +00:00
Support clipRegion on GPU backend Bug: skia:9580 Change-Id: I663549dafc4239248e265bee8d6927bf5b259303 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259804 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-12-13 15:48:33 +00:00
* Added SkMatrix::MakeTrans(SkIVector)
https://review.skia.org/259804
Update release notes files Docs-Preview: https://skia.org/?cl=258417 Bug: skia: Change-Id: I4716231ad260f2f7f29776f7cc455c6837ec6a43 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258417 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2019-12-05 20:27:42 +00:00
new section and formatting Bug: skia: Change-Id: I759f2eb1ee26245ba3d3c971e030793b9c52aa5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267820 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2020-01-30 18:57:13 +00:00
* * *
Update release notes files Docs-Preview: https://skia.org/?cl=258417 Bug: skia: Change-Id: I4716231ad260f2f7f29776f7cc455c6837ec6a43 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258417 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2019-12-05 20:27:42 +00:00
Milestone 80
update release notes file, site for 84 branch Bug: skia: Change-Id: Icdc056e7972cad814fa633b7c9b021f4534d60c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290119 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-05-15 14:53:49 +00:00
------------
Update release notes files Docs-Preview: https://skia.org/?cl=258417 Bug: skia: Change-Id: I4716231ad260f2f7f29776f7cc455c6837ec6a43 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258417 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2019-12-05 20:27:42 +00:00
Always destroy resources instead of simply "abandoning" them in Vulkan backend. This also now requires that when using a vulkan GrContext, the backing VkDevice, Queue, and Instance must be alive when the GrContext is first destroyed or abandoned. Additionally any GrBackendTextures created from the GrContext must be deleted before destroying or abandoning the GrContext. Bug: skia:9603 Change-Id: Ibf194d2ffdcddd61e34214d7d59a2d9a33c880e5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257921 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-12-04 20:17:54 +00:00
* For Vulkan backend, we now require that the VkDevice, Queue, and Instance outlive
either the destruction or abandoning of the GrContext. Additionally, all
GrBackendTextures created via GrContext::createBackendTexture calls must be deleted
before destroying or abandoning the GrContext.
https://review.skia.org/257921
Remove SkSize& SkSize::operator=(const SkISize&) Having it means you cannot write: SkSize size; float x, y; size = {x , y}; clang allows it but GCC does not, claiming it is ambiguous between the implicitly generated SkSize& SkSize::operator=(const SkSize&) and SkSize& SkSize::operator=(const SkISize&) clang gives the same error if the former is explicitly declared default. Change-Id: I3b64436ef6aa669b3d87e7f37057c5dcb4add987 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257880 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-12-04 15:33:52 +00:00
* Removed SkSize& SkSize::operator=(const SkISize&)
https://review.skia.org/257880
Fix for 420/422 chroma subsampling of odd dimension images when converting from YUV to RGB on GPU. Change-Id: I872e1e85f3efccce7bf93d2f3d5f2a841b8a5b0f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/257680 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
2019-12-04 16:05:35 +00:00
* SkISize width() and height() now constexpr
https://review.skia.org/257680
Test texture domain effect with local matrix. Add a common way to make rect op for testing that uses a GP with a local matrix. Change-Id: I958d1230bd5067b2e4b60fcd374e2f7718681e43 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255782 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2019-11-22 21:56:36 +00:00
* Added SkMatrix::MakeTrans(SkVector) and SkRect::makeOffset(SkVector).
https://review.skia.org/255782
Clamp RGB outputs of GrYUVtoRGBEffect. The matrices we're using can produce very slightly out of range color channels. This gives surprising results when in shader blending is used for color burn and color dodge. After this change we clamp the RGB values to 0..1 before applying premul. Adds a GM modeled on a blink layout test that shows the problem using SkImageMakeFromYUVAPixmaps. Bug: skia:9619 Change-Id: I446d39763a7f5a2f7c5f61d94d163927d851baa3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/253879 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-11-11 18:47:25 +00:00
* Added SkImageInfo::MakeA8(SkISize) and added optional color space parameter to
SkImageInfo::MakeN32Premul(SkISize).
Fix up release notes file Bug: skia: Change-Id: I124abbb54f13e70e5d9c6a71f43cea5adf0ce49a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250038 Auto-Submit: Heather Miller <hcm@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-22 19:45:45 +00:00
[canvaskit] Expand SkAnimatedImage With these things exposed, I think Flutter will not need CanvasKit to expose the very complex SkCodec API. Change-Id: Iace1b496d1dcb8842181466e860e8f212aba7b48 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/253542 Reviewed-by: Leon Scroggins <scroggo@google.com>
2019-11-08 14:55:15 +00:00
* Added dimensions() and getFrameCount() to SkAnimatedImage
https://review.skia.org/253542
Reland "Fully embrace skcms types in SkColorSpace API" This reverts commit 6af9b1c673b1f017ecf5b845a1328a6c539f3c0d. Change-Id: I7954951497e57475ab6f1c7f946b47aa17f1ac8c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252817 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2019-11-05 16:41:16 +00:00
* Removed SkMatrix44 version of toXYZD50 from SkColorSpace. Switched to skcms types in
transferFn, invTrasnferFn, and gamutTransformTo functions.
https://review.skia.org/252596
SkColorMatrix cleanup Remove the RGB/YUV helpers (use SkYUVMath instead), along with the unused get20/set20. Change-Id: Id83467a1b7f33657869e0a933af75387a4e36a88 Bug: skia:9543 Change-Id: Id83467a1b7f33657869e0a933af75387a4e36a88 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252188 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Reed <reed@google.com>
2019-11-01 21:10:28 +00:00
* Removed rotation and YUV support from SkColorMatrix
https://review.skia.org/252188
Add BT2020 (non-constant-luminance) YUV color space Change-Id: I8ef13b78a5f2f49ff9c59db285b3e0e7ee708c9b Bug: chromium:960620 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252160 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2019-11-01 14:02:24 +00:00
* Added kBT2020_SkYUVColorSpace. This is BT.2020's YCbCr conversion (non-constant-luminance).
https://review.skia.org/252160
Remove legacy async read pixels APIs. Chrome is now using the newer version. Bug: skia:8962 Change-Id: I8c38bde63e1e032281d19b0cc7cb8cf301061a9e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251198 Commit-Queue: Greg Daniel <egdaniel@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-10-28 13:16:47 +00:00
* Remove old async read pixels APIs
https://review.skia.org/251198
Make SkBlendMode_AsCoeff() public Change-Id: Ie704f0f83b1034ff8ee1a5d3cd194e555cae20a3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252600 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2019-11-04 20:01:52 +00:00
* Expose SkBlendModeCoeff and SkBlendMode_AsCoeff for Porter-Duff blend modes.
https://review.skia.org/252600
Fix up release notes file Bug: skia: Change-Id: I124abbb54f13e70e5d9c6a71f43cea5adf0ce49a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250038 Auto-Submit: Heather Miller <hcm@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-22 19:45:45 +00:00
* * *
update formatting, add links Bug: skia: Change-Id: I1f74e95781d575570d560003f706eb073b1b0a01 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249118 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2019-10-17 04:03:36 +00:00
Fix up release notes file Bug: skia: Change-Id: I124abbb54f13e70e5d9c6a71f43cea5adf0ce49a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250038 Auto-Submit: Heather Miller <hcm@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-22 19:45:45 +00:00
Milestone 79
update release notes file, site for 84 branch Bug: skia: Change-Id: Icdc056e7972cad814fa633b7c9b021f4534d60c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290119 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-05-15 14:53:49 +00:00
------------
update formatting, add links Bug: skia: Change-Id: I1f74e95781d575570d560003f706eb073b1b0a01 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249118 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2019-10-17 04:03:36 +00:00
Simple iterator for textblobs bug: skia:9503 Change-Id: I5b4e2434c6085d048d6d0fc42b2b928439b1066b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246296 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2019-10-04 14:18:34 +00:00
* SkTextBlob::Iter to discover the glyph indices and typefaces in each run
https://skia-review.googlesource.com/246296
Starting to hack up HDR transfer function support Brings over skcms' encoding scheme, etc. Change-Id: Ib8abec911acd1c50df3b201b4a9bde01b1cb123b Bug: chromium:960620 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249000 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2019-10-16 17:58:42 +00:00
* Added support for PQ and HLG transfer functions to SkColorSpace.
update formatting, add links Bug: skia: Change-Id: I1f74e95781d575570d560003f706eb073b1b0a01 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249118 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2019-10-17 04:03:36 +00:00
https://skia-review.googlesource.com/c/skia/+/249000
Starting to hack up HDR transfer function support Brings over skcms' encoding scheme, etc. Change-Id: Ib8abec911acd1c50df3b201b4a9bde01b1cb123b Bug: chromium:960620 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249000 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2019-10-16 17:58:42 +00:00
Add new public api on GrContext for computing image size. This api will replace ComputeTextureSize. Change-Id: I9befd8706f44250805315bdb13a559cf81c7142d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247337 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-10-09 16:38:22 +00:00
* Added new api on GrContext ComputeImageSize. This replaces the hold static helper
ComputeTextureSize.
update formatting, add links Bug: skia: Change-Id: I1f74e95781d575570d560003f706eb073b1b0a01 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249118 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com> Auto-Submit: Heather Miller <hcm@google.com>
2019-10-17 04:03:36 +00:00
https://skia-review.googlesource.com/c/skia/+/247337
doc: cleanup release notes No-try: true Change-Id: Ice2803974c7451aff200c75a609414cf9f0a17fe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245374 Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-01 19:15:36 +00:00
Reland "Reland "SkSurface asynchronous read APIs allow client to extend pixel lifetime"" This is a reland of 6fc04f88a89ed2c9a1b4aa48bcd28602a69a457b Original change's description: > Reland "SkSurface asynchronous read APIs allow client to extend pixel lifetime" > > This is a reland of ce240cc6fd8ec95bd051c7df2173dad2ae8f6ad6 > > Original change's description: > > SkSurface asynchronous read APIs allow client to extend pixel lifetime > > > > Previously the pixel data passed to the client was only valid during > > the client's callback. This meant if the client wanted to defer > > processing of the data a copy was necessary. > > > > Now we pass an object to the callback and the pixel lifetime is tied > > to the lifetime of that object. > > > > The object may be holding a GPU transfer buffer mapped. We don't assume > > that the object will be released on the direct GrContext thread. So > > when the object is destroyed it posts a message to a new type, > > GrClientMappedBufferManager, hanging off the direct context. The direct > > context will periodically check for messages and unmap and then unref > > buffers so that they can be reused. Currently this is done in > > GrContext::performDeferredCleanup() and GrDrawingManager::flush(). > > > > The old API is kept around for backwards compatibility but it is > > reimplemented as a bridge on top of the new mechanism. > > > > Also a utility function to SkImageInfo is added to directly make a new > > info with a specified dimensions rather than passing the width and > > height separately to makeWH(). > > > > Bug: chromium:973403 > > Bug: skia:8962 > > > > Change-Id: Id5cf04235376170142a48e90d3ecd13fd021a2a6 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245457 > > Reviewed-by: Brian Osman <brianosman@google.com> > > Commit-Queue: Brian Salomon <bsalomon@google.com> > > Bug: chromium:973403, skia:8962 > Change-Id: I5cecd36276c8b6dc942cf549c7095db2df88530c > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245678 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Bug: chromium:973403, skia:8962 Change-Id: Ie584c1c3ef8021c976f71b708e53871c693cc450 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246057 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-10-03 17:26:54 +00:00
* New versions of SkSurface async-rescale-and read APIs that allow client to extend
the lifetime of the result data. Old versions are deprecated.
https://review.skia.org/245457
doc: cleanup release notes No-try: true Change-Id: Ice2803974c7451aff200c75a609414cf9f0a17fe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245374 Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-01 19:15:36 +00:00
* Add SkColorInfo. It's dimensionless SkImageInfo.
https://review.skia.org/245261
* Added SkPixmap-based createBackendTexture method to GrContext. This allows clients to create
backend resources (initialized with texture data) that Skia/Ganesh doesn't know about/track.
https://review.skia.org/244676
Revert "Revert "add explicit src and dst colorspaces to filterColor4f"" This reverts commit 355111bf7cf53c11bfc6dd4c6924fc9895d3fd8f. Change-Id: I0aa45bf92f437a0d680aa788ef4dc5c0299c6fe0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244882 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Mike Reed <reed@google.com>
2019-09-28 01:05:24 +00:00
* Add explicit src and dst colorspace parameters to SkColorFilter::filterColor4f()
doc: cleanup release notes No-try: true Change-Id: Ice2803974c7451aff200c75a609414cf9f0a17fe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245374 Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-01 19:15:36 +00:00
https://review.skia.org/244882
* Remove Vulkan/Metal float32 RGBA texture support
https://review.skia.org/244881
Revert "Revert "add explicit src and dst colorspaces to filterColor4f"" This reverts commit 355111bf7cf53c11bfc6dd4c6924fc9895d3fd8f. Change-Id: I0aa45bf92f437a0d680aa788ef4dc5c0299c6fe0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244882 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Mike Reed <reed@google.com>
2019-09-28 01:05:24 +00:00
Set up prototype interface for MakeFromCAMetalLayer Change-Id: I87b0fc76ef48c1a21498e576853a6c3b4a6a98f9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/242563 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-09-19 17:03:09 +00:00
* Add SkSurface::MakeFromCAMetalLayer
doc: cleanup release notes No-try: true Change-Id: Ice2803974c7451aff200c75a609414cf9f0a17fe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245374 Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-01 19:15:36 +00:00
https://review.skia.org/242563
* Added kAlpha_F16_SkColorType, kRG_F16_SkColorType and kRGBA_16161616_SkColorType.
This is intended to help support HDR YUV uses case (e.g., P010 and P016). As such,
the addition is focused on allowing creation of SkPixmaps and SkImages and not
SkSurfaces (i.e., who wants to render to render to these?)
https://review.skia.org/241357
Introduce crowdsourced release notes file Bug: skia: Change-Id: I9d76b56ef88ec5caf305deed8bf839443427a260 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229760 Commit-Queue: Heather Miller <hcm@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-07-25 15:33:30 +00:00
Pull path nested types out to root level Change-Id: I66a854fa157c5c22d0caaf8bc6f5989baa876a5c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/241079 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-09-13 12:26:56 +00:00
* Start to move nested SkPath types (e.g. Direction, Verb) up to root level in SkPathTypes.h
doc: cleanup release notes No-try: true Change-Id: Ice2803974c7451aff200c75a609414cf9f0a17fe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245374 Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-01 19:15:36 +00:00
https://review.skia.org/241079
make rectcontour and nestedrects private Change-Id: I37b81f3cd96acc310ce78244d427eeb9c7999061 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/241078 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Mike Reed <reed@google.com>
2019-09-12 21:09:12 +00:00
doc: cleanup release notes No-try: true Change-Id: Ice2803974c7451aff200c75a609414cf9f0a17fe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245374 Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-01 19:15:36 +00:00
* Remove isRectContour and ksNestedFillRects from public
https://review.skia.org/241078
* Added kRG_88_SkColorType. This is intended to help support YUV uses case (e.g., NV12).
As such, the addition is focused on allowing creation of SkPixmaps and SkImages and not
SkSurfaces (i.e., who wants to render to RG?)
https://review.skia.org/239930
https://review.skia.org/235797
Make the size of program/pipeline caches configurable in GrContextOptions Change-Id: I988fd8cc7e78e2124f20b7d8a815f160bb166756 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239756 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-09-06 14:16:02 +00:00
* Make the size of program/pipeline caches configurable via
GrContextOptions::fRuntimeProgramCacheSize
https://review.skia.org/239756
doc: cleanup release notes No-try: true Change-Id: Ice2803974c7451aff200c75a609414cf9f0a17fe Reviewed-on: https://skia-review.googlesource.com/c/skia/+/245374 Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-01 19:15:36 +00:00
* Added kAlpha_16_SkColorType and kRG_1616_SkColorType. This is intended to help support HDR YUV
uses case (e.g., P010 and P016). As such, the addition is focused on allowing creation of
SkPixmaps and SkImages and not SkSurfaces (i.e., who wants to render to render to these?)
https://review.skia.org/239930
* Add GrContext::precompileShader to allow up-front compilation of previously-cached shaders.
https://review.skia.org/239438
* * *
Introduce crowdsourced release notes file Bug: skia: Change-Id: I9d76b56ef88ec5caf305deed8bf839443427a260 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229760 Commit-Queue: Heather Miller <hcm@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-07-25 15:33:30 +00:00
Milestone 78
update release notes file, site for 84 branch Bug: skia: Change-Id: Icdc056e7972cad814fa633b7c9b021f4534d60c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290119 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
2020-05-15 14:53:49 +00:00
------------
Introduce crowdsourced release notes file Bug: skia: Change-Id: I9d76b56ef88ec5caf305deed8bf839443427a260 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/229760 Commit-Queue: Heather Miller <hcm@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
2019-07-25 15:33:30 +00:00
RELEASE_NOTES: note change to SkMallocPixelRef No-Try: true Change-Id: I04b5193bab1524debb5a9ad2baf655ddd4209288 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235857 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 15:28:37 +00:00
* SkDrawLooper is no longer supported in SkPaint or SkCanvas.
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
https://review.skia.org/230579
https://review.skia.org/231736
remove code now that loopers are dead (w.r.t. canvas and paint) We can't remove the loopers themselves, as they are still used by android and chrome (they just don't ever pass them to skia). Eventually each of those clients will resolve this, but for now we just keep the classes (and tests) in skia. Bug: skia:4783 Change-Id: I5f507e6bb82280f2bc7c0b21eebe59c287aa9265 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230579 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
2019-07-29 21:52:48 +00:00
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
* SkPath::Iter::next() now ignores its consumDegenerates bools. Those will so
go away entirely
https://review.skia.org/235104
never check for degenerates in path::iter This does not appear to be used externally, and only internally in 3 sites in GPU, which we can handle explicitly. For now you can still pass bools to Iter::next() but they are ignored. After this lands, I will update the callers to remove those. FWIW: none of our other tests or gms seem to notice this change... Bug: skia:9339 Change-Id: If40077b1ebb3d47cfce0ec43996ff272318e4a62 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235104 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Mike Reed <reed@google.com>
2019-08-16 17:30:34 +00:00
RELEASE_NOTES: note change to SkMallocPixelRef No-Try: true Change-Id: I04b5193bab1524debb5a9ad2baf655ddd4209288 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235857 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 15:28:37 +00:00
* SkImage: new factories: DecodeToRaster, DecodeToTexture
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
https://review.skia.org/234476
expose direct methods for decoding to an image These are meant to contrast MakeFromEncoded(), and emphasize that it is deferred/cached, while the new methods are not. Change-Id: I83ac22394cb14cdc84ff8507a514bf708734b84f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/234476 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Reed <reed@google.com>
2019-08-14 15:08:41 +00:00
RELEASE_NOTES: note change to SkMallocPixelRef No-Try: true Change-Id: I04b5193bab1524debb5a9ad2baf655ddd4209288 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235857 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 15:28:37 +00:00
* SkImageFilter API refactor started:
- Provide new factory API in include/effects/SkImageFilters
- Consolidated enum types to use SkTileMode and SkColorChannel
- Hide filter implementation classes
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
- Hide previously public functions on SkImageFilter that were intended for
internal use only
https://review.skia.org/230198
https://review.skia.org/230876
https://review.skia.org/231256
Reland: SkColorfilters::HSLAMatrix Introduce an SkColorFilter_Matrix flavor operating in HSLA space. (CPU-only for now) TBR=mtklein Change-Id: I3a8686775593ccc9ce0e46159a17bec7f4ab4228 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/231736 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-08-01 21:20:19 +00:00
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
* SkColorFilters::HSLAMatrix - new matrix color filter operating in HSLA
space.
https://review.skia.org/231736
Rework how backend-specific formats are retrieved from GrBackendFormat. Change-Id: If1047c477ff3f2cc4aaf19d2e2e838f2dbcb0126 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233160 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-08-08 16:08:24 +00:00
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
* Modify GrBackendFormat getters to not return internal pointers. Use an enum
class for GL formats.
https://review.skia.org/233160
Expose GrContext::dump() when SK_ENABLE_DUMP_GPU is defined. Change-Id: I499228454bc387de2c988b8f607320b7e5ea57b0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233557 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-08-09 13:41:48 +00:00
RELEASE_NOTES: note change to SkMallocPixelRef No-Try: true Change-Id: I04b5193bab1524debb5a9ad2baf655ddd4209288 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235857 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 15:28:37 +00:00
* Expose GrContext::dump() when SK_ENABLE_DUMP_GPU is defined.
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
https://review.skia.org/233557
Reland: Enable YCbCr sampler support on platforms other than Android Previously YCbCr Vulkan samplers were supported only on Android for external images, while Vulkan requires YCbCr sampler for I420 YUV image formats such as VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM, VK_FORMAT_G8_B8R8_2PLANE_420_UNORM. This CL: - Adds VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM and VK_FORMAT_G8_B8R8_2PLANE_420_UNORM as supported Vulkan formats - Updates GrVkYcbcrConversionInfo to add fFormat field and allow fExternalFormat=0. - Removes assertions format=VK_FORMAT_UNDEFINED for all images that have ycbcr info. Bug: chromium:981022 Change-Id: Id4d81b20d9fda4d9ad0831f77e6025eed3db2bfd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233776 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
2019-08-12 05:46:33 +00:00
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
* Vulkan backend now supports YCbCr sampler for I420 Vulkan images that are
not backed by external images.
https://review.skia.org/233776
Hook up SkHeifCodec for ImageDecoder animation bug: 78868457 bug: 120414514 test: local test with OpenGL Rendrerer Tests animation demo and heifs files Change-Id: I09a7667a57f545927dbe9ac24c1a6b405ff0006d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/232839 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Auto-Submit: Chong Zhang <chz@google.com>
2019-08-14 15:29:29 +00:00
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
* Add SkCodec::SelectionPolicy for distinguishing between decoding a still
image or an image sequence for a container format that has both (e.g. HEIF).
https://review.skia.org/232839
Remove unused dstColorSpace parameter from makeTextureImage Old version still exists until client code is migrated. Change-Id: I087b6b977f586d334f9a20954e7ed7b5e4b7ea5e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/234579 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2019-08-14 17:19:04 +00:00
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
* SkImage::makeTextureImage and SkImage::MakeCrossContextFromPixmap no longer
take an SkColorSpace parameter. It was unused.
https://review.skia.org/234579
https://review.skia.org/234912
Add SkImage::reinterpretColorSpace This reinterprets the contents of an image as though they were in a different color space. Helpful for tools and debug visualization. Bug: chromium:795132 chromium:985500 Change-Id: Ia8739bbd73d72249b8bee9d51dfa11d560a2a1f5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/234328 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2019-08-14 20:14:51 +00:00
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
* SkImage::reinterpretColorSpace - to reinterpret image contents in a new
color space.
https://review.skia.org/234328
Remove MakeCrossContextFromEncoded, unused argument from ...FromPixmap Change-Id: I962e923a4994eb549a9c1002323f33d05b936b84 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/234912 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2019-08-15 16:13:53 +00:00
RELEASE_NOTES: note change to SkMallocPixelRef No-Try: true Change-Id: I04b5193bab1524debb5a9ad2baf655ddd4209288 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235857 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 15:28:37 +00:00
* Removed SkImage::MakeCrossContextFromEncoded.
RELEASE_NOTES: formatting cleanup, add some urls No-Try: true Change-Id: Ic8f8416fa10d37205ab27a8e8da173869d158ab1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235862 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 18:52:02 +00:00
https://review.skia.org/234912
RELEASE_NOTES: note change to SkMallocPixelRef No-Try: true Change-Id: I04b5193bab1524debb5a9ad2baf655ddd4209288 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235857 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 15:28:37 +00:00
Implement fences and semaphores for Metal. GrFence is implemented by a single MTLSharedEvent where we increase the value with each new invocation. GrSemaphore uses a MTLEvent (the assumption here is that we are signaling and waiting on the same device) with an associated value that defaults to 1. For generating a large number of GrSemaphores at once it should be possible to use the same MTLEvent but with different assigned values. Bug: skia:8243 Change-Id: Ic7de2d9d295fbe51e67bc7c3c4354257cb0774d4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233416 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-08-28 18:35:55 +00:00
* Add Metal support for GrFence, GrSemaphore, and GrBackendSemaphore
https://review.skia.org/233416
RELEASE_NOTES: note change to SkMallocPixelRef No-Try: true Change-Id: I04b5193bab1524debb5a9ad2baf655ddd4209288 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235857 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-08-20 15:28:37 +00:00
* SkMallocPixelRef: remove MakeDirect and MakeWithProc from API.
https://review.skia.org/234660
remove unused sk_sp comparison operators These unused comparison operators are the only users of <functional> in SkRefCnt.h, for std::less. <functional> is an expensive header to compile, and SkRefCnt.h is popular, so it helps to cut dependencies like this. Mostly we just need to add #include <functional> in a few places that were picking it up via SkRefCnt.h. In SkPixmapPriv.h, it looked simpler to template the argument, since everything was inline anyway. Change-Id: I7c125bb26a04199847357c729a1b178256c6ef8d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/236942 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2019-08-27 13:12:15 +00:00
Add Color4f variant for DrawEdgeAAQuad Bug: chromium:795132,chromium:985500 Change-Id: Idbb4d45b29d2c0d0fd54b05b807086ecf0b8cf26 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/237492 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-08-27 19:25:49 +00:00
* Remove 4-parameter variant of SkRect::join() and intersect(), and
noemptycheck variants of intersect().
https://review.skia.org/235832
https://review.skia.org/237142
remove unused sk_sp comparison operators These unused comparison operators are the only users of <functional> in SkRefCnt.h, for std::less. <functional> is an expensive header to compile, and SkRefCnt.h is popular, so it helps to cut dependencies like this. Mostly we just need to add #include <functional> in a few places that were picking it up via SkRefCnt.h. In SkPixmapPriv.h, it looked simpler to template the argument, since everything was inline anyway. Change-Id: I7c125bb26a04199847357c729a1b178256c6ef8d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/236942 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2019-08-27 13:12:15 +00:00
* Remove unused sk_sp comparison operators.
https://review.skia.org/236942
Add Color4f variant for DrawEdgeAAQuad Bug: chromium:795132,chromium:985500 Change-Id: Idbb4d45b29d2c0d0fd54b05b807086ecf0b8cf26 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/237492 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-08-27 19:25:49 +00:00
* Add SkColor4f variant to experimental_DrawEdgeAAQuad for SkiaRenderer.
https://review.skia.org/237492
Remove maxCount resource cache limit Change-Id: I0f1064c8433d69e24ca3d5b970c99d539dc1dadd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238442 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-09-03 14:29:20 +00:00
* Deprecated maxCount resource cache limit for Ganesh.
This hasn't been relevant for a long time.
Move SkSL caching out of GR_TEST_UTILS, trim persistent cache options Combines the two boolean options into a single tri-state enum. Old GLSL option is still present (temporarily) until Chrome is switched over. Also add a type tag for cached program binaries, so we can safely detect cache entries of the wrong type. Change-Id: I0ddeefa9180b27bc2c46e2e7b77e6c9cdf4a730a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238856 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-09-03 18:59:26 +00:00
* Changed GrContextOptions' fDisallowGLSLBinaryCaching to fShaderCacheStrategy,
and allow caching SkSL.
https://review.skia.org/238856
Add GL_QCOM_TILED_RENDERING as an optional interface Change-Id: I29b53e674cd788ac188295060028bbb7805858a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246281 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-10-07 17:51:07 +00:00
* Use GL_QCOM_TILED_RENDERING to explicitly discard stencil
Fix up release notes file Bug: skia: Change-Id: I124abbb54f13e70e5d9c6a71f43cea5adf0ce49a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250038 Auto-Submit: Heather Miller <hcm@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-22 19:45:45 +00:00
* Added RELEASE_NOTES.txt file
https://review.skia.org/229760
Add back door support for GLSL tessellation shaders Implements tessellation support at the Ganesh level, and adds back door methods for supplying raw GLSL strings directly to the OpenGL driver. Adds a new gm to verify tessellation is works in GL. Change-Id: Idfc285b955cbe5e8e6bf0475be8b518b0cc6ed2c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261196 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-12-27 21:56:38 +00:00
* Implemented internal support for OpenGL tessellation.
Reference in New Issue Copy Permalink