epoger@google.com
b28b5e4e26
Warn when an SkScalar is passed into SkIntToScalar() (converted twice)
...
http://codereview.appspot.com/4548051/
git-svn-id: http://skia.googlecode.com/svn/trunk@1405 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-24 14:51:57 +00:00
reed@google.com
ac45f00d5a
return the bytes read, not the total provided
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1404 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-24 13:50:21 +00:00
reed@google.com
69d0555133
add copyright notices
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1403 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-24 12:14:28 +00:00
thakis@chromium.org
598b859211
Fix a new clang warning:
...
third_party/skia/src/ports/SkFontHost_FreeType.cpp:957:7:error: switch case is
in protected scope
default:
^
third_party/skia/src/ports/SkFontHost_FreeType.cpp:918:17: note: jump bypasses
variable initialization
FT_BBox bbox;
^
third_party/skia/src/ports/SkFontHost_FreeType.cpp:946:7:error: switch case is
in protected scope
case FT_GLYPH_FORMAT_BITMAP:
^
third_party/skia/src/ports/SkFontHost_FreeType.cpp:918:17: note: jump bypasses
variable initialization
FT_BBox bbox;
^
2 errors generated.
This is arguably a false positive, but since |bbox| can only safely be used in
the first case branch, it's a good idea to scope it to there anyway. This is
the only instance this warning occurs in all of chrome.
Review URL: http://codereview.appspot.com/4532081/
git-svn-id: http://skia.googlecode.com/svn/trunk@1402 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-24 05:42:55 +00:00
reed@google.com
eb5a8151a5
call notify after we write the kDone verb
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1401 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-23 21:09:13 +00:00
reed@google.com
80b09de87f
add optoinal bytesRead argument (output) to playback()
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1400 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-23 13:54:24 +00:00
reed@google.com
21b1c5c7b1
fix warnings
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1399 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-23 12:44:44 +00:00
reed@google.com
103c036218
pass correct size to read(buffer, ...) tests
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1398 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-23 12:28:48 +00:00
reed@google.com
dde0956375
add cross-process option to gpipe
...
add unittests for reader32 and writer32
git-svn-id: http://skia.googlecode.com/svn/trunk@1397 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-23 12:21:05 +00:00
ctguil@chromium.org
c7d9f9d8ae
Expose SkComposeShader as SK_API.
...
This is used by the ChromeOS build of Chrome.
Review URL: http://codereview.appspot.com/4548054
git-svn-id: http://skia.googlecode.com/svn/trunk@1396 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-20 22:16:08 +00:00
senorblanco@chromium.org
1a39493b32
Fix unnitialized memory in Sk2DPathEffect. The SkDescriptor checksum
...
calculation for Sk2DPathEffect currently evaluates all the bytes in the
embedded SkMatrix. This includes the type mask, which contains some
uninitialized padding. Changing it to use SkMatrix::flatten() and
SkMatrix::unflatten() (as SkGroupShape was doing) avoids the uninitialized
data errors.
Review URL: http://codereview.appspot.com/4529074/
git-svn-id: http://skia.googlecode.com/svn/trunk@1395 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-20 19:19:09 +00:00
bungeman@google.com
8c5753ea2e
Fixed point no longer crashes when GL enabled in gm tests.
...
http://codereview.appspot.com/4532073/
git-svn-id: http://skia.googlecode.com/svn/trunk@1394 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-20 19:11:50 +00:00
senorblanco@chromium.org
e4c98ff48d
Clean up some valgrind errors in SkTransparentShader. Valgrind complains
...
about overlapping memcpy(). In fact, it seems that src and dest are the same,
so we should be able to skip the copy in this case.
Review URL: http://codereview.appspot.com/4535085/
git-svn-id: http://skia.googlecode.com/svn/trunk@1393 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-20 19:06:10 +00:00
bsalomon@google.com
0251b2fe99
Tag GrPrintf with GR_API so that it is exposed to users of a Skia DLL
...
Review URL: http://codereview.appspot.com/4530059/
git-svn-id: http://skia.googlecode.com/svn/trunk@1392 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-20 18:50:54 +00:00
epoger@google.com
bcc56836ea
tiny document-only change
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1391 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-20 17:35:46 +00:00
bsalomon@google.com
271cffc77b
Add dual source blending support for proper blending with coverage.
...
Review URL: http://codereview.appspot.com/4535088/
git-svn-id: http://skia.googlecode.com/svn/trunk@1390 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-20 14:13:56 +00:00
bungeman@google.com
3c14d0f3d1
Fix gm tests for fixed point.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1389 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-20 14:05:03 +00:00
bungeman@google.com
0368d06a29
Fix clipping in StrokeRectGM test for fixed point.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1388 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 21:29:25 +00:00
bsalomon@google.com
2368f6f572
Remove createPlatformRenderTarget, undeprecate createRenderTargetFrom3DAPIState
...
Review URL: http://codereview.appspot.com/4552053/
git-svn-id: http://skia.googlecode.com/svn/trunk@1387 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 21:22:39 +00:00
senorblanco@chromium.org
64cc579efa
The plain Makefile was using -Wall, but the gyp build wasn't. This CL turns on
...
-Wall -Wextra and -Wno-unused in common.gypi. This revealed a lot of warnings
(and some actual bugs), all of which I fixed here. This is pretty mindless
stuff for the most part (order of intialization, missing initializers, && within
||, etc), but will allow us to build cleanly with -Wall and -Wextra (and
-Werror, if we so choose).
I put defaults into switches that were missing cases. I could put in the actual
missing enums instead if that's desired. I could also assert on missing enums
instead of break, if that's desired. I wasn't sure how to test the stuff in
"animator", so that should be looked at a bit more closely.
Review URL: http://codereview.appspot.com/4547055/
git-svn-id: http://skia.googlecode.com/svn/trunk@1386 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 19:58:58 +00:00
bungeman@google.com
9e0f2ee033
Add build for unix to gyp.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1385 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 19:02:20 +00:00
senorblanco@chromium.org
e580bc195a
Plug a leak in SampleShaderTest.
...
Review URL: http://codereview.appspot.com/4517086/
git-svn-id: http://skia.googlecode.com/svn/trunk@1384 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 18:33:33 +00:00
bungeman@google.com
71ff02c8ef
Add unix and mesa GL files to gyp.
...
http://codereview.appspot.com/4545055/
git-svn-id: http://skia.googlecode.com/svn/trunk@1383 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 18:04:48 +00:00
bungeman@google.com
0e45441994
Add Mesa as a GL backend.
...
http://codereview.appspot.com/4545055/
git-svn-id: http://skia.googlecode.com/svn/trunk@1382 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 17:47:02 +00:00
epoger@google.com
65245ade84
fix assertion failure in Skia_Linux_Fixed_Debug build
...
http://codereview.appspot.com/4556043/
git-svn-id: http://skia.googlecode.com/svn/trunk@1381 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 17:36:21 +00:00
senorblanco@chromium.org
ef3913bcbf
Batch up draws into triangle fans as large as possible when drawing convex
...
edge AA polys, so we minimize state changes and GL calls. This requires
querying GL for the maximum number of fragment uniforms. It also makes the
shader generator produce custom shaders for the number of relevant edges.
This gives a ~5X speedup on the "Shapes" SampleApp.
Review URL: http://codereview.appspot.com/4536070/
git-svn-id: http://skia.googlecode.com/svn/trunk@1380 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 17:11:07 +00:00
bsalomon@google.com
27661181d7
Fix windows color order
...
Review URL: http://codereview.appspot.com/4553048/
git-svn-id: http://skia.googlecode.com/svn/trunk@1379 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 15:57:44 +00:00
bsalomon@google.com
346ff6c684
Add snapshot of gyp-generated vs proj for any third party devs who were using the old project. README.TXT explains how to generate an up to date one.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1378 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 14:45:11 +00:00
bsalomon@google.com
c386b8752b
Fix windows build (missing SkFontHost.cpp)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1377 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 14:39:57 +00:00
bsalomon@google.com
ec965186e4
Remove old visual studio project
...
Review URL: http://codereview.appspot.com/4524054/
git-svn-id: http://skia.googlecode.com/svn/trunk@1376 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-19 14:24:59 +00:00
vandebo@chromium.org
466f3d66f0
[PDF] Implement clear xfermode with a mask instead of pushing the clip down.
...
This approach is much less likely to use an SkRegion and ends up working better for Webkit.
Review URL: http://codereview.appspot.com/4550057
git-svn-id: http://skia.googlecode.com/svn/trunk@1375 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 23:06:29 +00:00
vandebo@chromium.org
8989d31cf0
[PDF] Fix windows compile warning.
...
Review URL: http://codereview.appspot.com/4545056
git-svn-id: http://skia.googlecode.com/svn/trunk@1374 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 22:10:09 +00:00
reed@google.com
05ea1810a2
move SHIFT default definitions from SkColorPriv.h to SkPostConfig.h, so that
...
clients don't accidentally see them defined on some platforms when they only
include SkTypes.h, and not others.
git-svn-id: http://skia.googlecode.com/svn/trunk@1373 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 21:24:16 +00:00
reed@google.com
9d7576724c
setHinting modifies fFlags in places, so call it last (after initializing fFlags)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1372 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 21:14:39 +00:00
epoger@google.com
1f75399dce
fix PathTest for SKIA_SCALAR=fixed
...
http://codereview.appspot.com/4528083/
git-svn-id: http://skia.googlecode.com/svn/trunk@1371 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 20:23:30 +00:00
reed@google.com
bad8c87812
show consistent timings between debug and release
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1370 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 20:10:31 +00:00
bsalomon@google.com
00e17c5a1b
Fix uninit of mask var
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1369 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 19:02:42 +00:00
reed@google.com
02b5331078
encode current LCD orientation and order into font-cache-key
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1368 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 19:00:53 +00:00
bungeman@google.com
2ed67e83c8
Fix tests with incorrect swizzle.
...
http://codereview.appspot.com/4552046/
git-svn-id: http://skia.googlecode.com/svn/trunk@1367 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 18:54:23 +00:00
bungeman@google.com
d1a416a97c
glFinish to complete bench before stopping stopwatch.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1366 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 18:37:07 +00:00
vandebo@chromium.org
6cc26da383
[PDF] Fix PDF primitives test for fixed scalars.
...
110999 is out of range for SkFixed (+/- 32767)
BUG=269
Review URL: http://codereview.appspot.com/4530051
git-svn-id: http://skia.googlecode.com/svn/trunk@1365 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 17:08:05 +00:00
reed@google.com
6271117d82
support BW glyphs, instead of always forcing them to AA
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1364 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 15:08:10 +00:00
reed@google.com
b36334d46a
lockPixels before looking at them in Zoomer
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1363 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 15:07:20 +00:00
reed@google.com
79b3b7e916
checkpoint for 8->5 bit reduction
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1362 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 13:07:22 +00:00
reed@google.com
9e39bb3603
code style, inherit from SampleView
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1361 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 12:17:53 +00:00
reed@google.com
09e3baaaf5
add 'h' to tri-toggle font hinting
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1360 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 12:04:31 +00:00
reed@google.com
bde3c8ed97
improve gray approximation for LCD LERP
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1359 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-18 11:58:10 +00:00
reed@google.com
c518134fa2
add optional decolorization value for lcd text
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1358 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-17 20:52:46 +00:00
reed@google.com
1fbb30051a
add more keys
...
git-svn-id: http://skia.googlecode.com/svn/trunk@1357 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-17 20:44:54 +00:00
bsalomon@google.com
26c2d0a69e
Use coverage stages for supersample AA resolve, edgeAA, and glyph masks. Expose a mask stage through GrPaint
...
Review URL: http://codereview.appspot.com/4548048/
git-svn-id: http://skia.googlecode.com/svn/trunk@1356 2bbb7eff-a529-9590-31e7-b0007b416f81
2011-05-17 20:15:30 +00:00