Brian Salomon
a9424995ac
Add additional tests to ignored-tests
...
BUG=skia:
Review URL: https://codereview.chromium.org/463993003
2014-08-13 12:08:01 -04:00
bsalomon
c30aaa0e40
Use combined color/coverage attribute when possible in aa rect renderer.
...
Also restore the is_irect test to detect AA rects that are integer aligned.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/466873002
2014-08-13 07:15:30 -07:00
Brian Salomon
0a82f5be21
Rebaseline current failures and those ignored for GPU rect change.
...
BUG=skia:
Review URL: https://codereview.chromium.org/460343003
2014-08-12 11:10:35 -04:00
joshualitt
5acfea789d
2D kernel initial wiring for Guassian
...
BUG=skia:
R=senorblanco@chromium.org , bsalomon@chromium.org , bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/418223009
2014-08-11 13:55:34 -07:00
Brian Salomon
4596c98908
Mark convex_poly_clip as flaky on msaa16/win8 bots. Add more tests to ignored_tests.txt after GPU rect change.
...
BUG=skia:
Review URL: https://codereview.chromium.org/460023002
2014-08-11 15:36:43 -04:00
bsalomon
9c0822a415
Always use both a color and coverage attribute in GrAARectRenderer.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/435743002
2014-08-11 11:07:48 -07:00
Brian Salomon
6dff71f44b
Remove bleed test from ignored-tests.txt
...
BUG=skia:
Review URL: https://codereview.chromium.org/463503004
2014-08-11 11:21:25 -04:00
bsalomon
0673676854
Don't compare coord change matrices to determine effect compatibility when using explicit local coords.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/438053002
2014-08-04 10:56:40 -07:00
bungeman
c6f5784047
No longer ignore and rebaseline fontmgr gms.
2014-08-01 15:02:36 -04:00
joshualitt
0e67808da7
Enabling texture_domain_effect
...
BUG=skia:
REVIEW=tbr
R=rmistry@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/425253003
2014-07-30 10:31:10 -07:00
Brian Salomon
00683c7b9a
Mark bleed GM images on GPU configs as baselined but associated with bug 2762
...
BUG=skia:2762
Review URL: https://codereview.chromium.org/431453006
2014-07-30 10:08:09 -04:00
Brian Salomon
5520e3be26
Rebaseline some images from ignored-tests.txt
...
BUG=skia:
Review URL: https://codereview.chromium.org/431583004
2014-07-30 09:40:56 -04:00
joshualitt
5ae5fc59b2
Adding repeat mode to texture domain
...
BUG=skia:
R=bsalomon@chromium.org , senorblanco@chromium.org , bsalomon@google.com , junov@chromium.org
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/422123003
2014-07-29 12:59:27 -07:00
cdalton
15ab26d942
Rebaseline needed nvpr gms after text change
...
Updates a few nvpr expectations for slight pixel diffs after a change
in the math that positions glyphs.
BUG=skia:
R=jvanverth@google.com , bungeman@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/421423002
2014-07-28 15:39:06 -07:00
cdalton
b2808cd041
Send less transform data when drawing text with nvpr
...
Before this change, GrStencilAndCoverTextContext would send 6-float
affine transforms to drawPaths for every glyph. This updates it to
concat the text scale onto the context matrix, and then only send
2-float translates (or 1-float x-translates when possible).
Also adds a glyph_pos_align test to gm that exercises the newly added
codepaths, and starts ignoring a few gm tests with benign pixel diffs
until we can rebaseline.
BUG=skia:
R=bsalomon@google.com , kkinnunen@nvidia.com , jvanverth@google.com , bungeman@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/406523003
2014-07-25 14:13:57 -07:00
robertphillips
ba0055b290
Revert "Update fontmgr expectations."
...
This reverts commit ff4b56b2d5
.
R=bungeman@gmail.com
TBR=bungeman@gmail.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/406323004
2014-07-22 16:34:38 -07:00
bungeman
ff4b56b2d5
Update fontmgr expectations.
2014-07-22 18:21:24 -04:00
bungeman
33d134656e
Suppress fontmgr gm changes while Android catches up.
2014-07-22 16:02:58 -04:00
egdaniel
f7caacdbb7
Rebaseline from recent gpu optimization changes
...
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/408203002
2014-07-22 06:46:45 -07:00
egdaniel
02cafcc1bf
Remove gpu shader optimatization for solid white or trans black colors
...
Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths.
With optimization in (ms):
White Blue Checkered
Linux ~80 ~80 ~160
N7 ~800 ~1100 ~1500
Moto-e ~830 ~1100 ~2500
Without optimization in (ms):
White Blue Checkered
Linux ~80 ~80 ~80
N7 ~1100 ~1100 ~1100
Moto-e ~1100 ~1100 ~1500
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/5f78d2251a440443c9eaa321dad058d7a32bfef7
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/375823005
2014-07-21 11:37:28 -07:00
senorblanco
3a3eef4a63
New baselines for perlin noise changes.
...
Pixel results affected by ca6a7c2945
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/385643003
2014-07-10 10:52:21 -07:00
robertphillips
e6b28cf25b
Remove shadows suppression
...
The 'shadows' GM isn't appearing on the "Recent GM Failures" page. It might have been a blip.
R=jcgregorio@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/387533002
2014-07-10 07:57:16 -07:00
robertphillips
5fe23b357a
Add suppression for shadows test
...
R=jvanverth@google.com
TBR=jcgregorio@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/377403004
2014-07-09 14:24:00 -07:00
jvanverth
085f334c47
Update remaining expectations for https://codereview.chromium.org/337603008 .
...
TBR=bungeman@chromium.org
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/371003004
2014-07-07 08:44:46 -07:00
egdaniel
8119e6a85d
Rebaseline for gpu dashing4 now doing circle dashes
...
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/374623003
2014-07-07 06:28:44 -07:00
jvanverth
c6bbd82210
Ignore some GM images for https://codereview.chromium.org/337603008 .
...
R=bungeman@google.com
TBR=bungeman@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/361333002
2014-07-02 15:54:24 -07:00
jvanverth
23ff2a5d46
More expectation updates for https://codereview.chromium.org/337603008 .
...
R=bungeman@google.com
TBR=bungeman@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/368073002
2014-07-02 14:15:37 -07:00
mtklein
217daa7ec5
Revert of Remove the AA requirement for selecting GrEffect-based clipping. ( https://codereview.chromium.org/367013003/ )
...
Reason for revert:
We think this is breaking the roll.
Original issue's description:
> Remove the AA requirement for selecting GrEffect-based clipping.
>
> Also, optionally use the scissor for a bw clip rect element instead of an effect.
>
> Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11
>
> Committed: https://skia.googlesource.com/skia/+/e9a729cb4d3f05b9c750dc1f63a9cc65b5659f04
R=robertphillips@google.com , bsalomon@google.com
TBR=bsalomon@google.com , robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/361313002
2014-07-02 12:55:21 -07:00
bsalomon
e9a729cb4d
Remove the AA requirement for selecting GrEffect-based clipping.
...
Also, optionally use the scissor for a bw clip rect element instead of an effect.
Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/367013003
2014-07-02 11:42:29 -07:00
jvanverth
5c76a0f1d1
Update some expectations for https://codereview.chromium.org/337603008 .
...
R=bungeman@google.com
TBR=bungeman@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/362373002
2014-07-02 11:33:07 -07:00
bsalomon
e1593862fe
Revert of Remove the AA requirement for selecting GrEffect-based clipping. ( https://codereview.chromium.org/367013003/ )
...
Reason for revert:
Assertion failing.
Original issue's description:
> Remove the AA requirement for selecting GrEffect-based clipping.
>
> Also, optionally use the scissor for a bw clip rect element instead of an effect.
>
> Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/369613002
2014-07-02 11:11:30 -07:00
bsalomon
a73218bbbd
Remove the AA requirement for selecting GrEffect-based clipping.
...
Also, optionally use the scissor for a bw clip rect element instead of an effect.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/367013003
2014-07-02 10:40:52 -07:00
egdaniel
f767e792b9
Add the ability for gpu to render dotted lines (dashed line, 0 on interval, round caps)
...
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/345113003
2014-07-02 06:21:34 -07:00
jvanverth
dc1cf66483
Remove A8_LCD luminance hack.
...
It no longer appears to be necessary, and the powf function is slowing down
Android text rendering.
R=bungeman@google.com , bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/337603008
2014-07-01 13:43:00 -07:00
senorblanco
ca6a7c2945
Make perlin noise do CTM-correct scaling.
...
When drawing perlin noise, generate noise at the resolution determined
by CTM, not by the resolution at construction time. This required moving
the generation of PaintingData to getContext() and asNewEffect() for the
raster and GPU paths, respectively.
It also required adjusting the matrices used during rendering
to be translate-only.
R=sugoi@chromium.org , bsalomon@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/358903002
2014-06-27 13:35:52 -07:00
robertphillips
c8fd7b58c5
Remove suppression of distantclip image differences
...
R=rmistry@google.com , rmistry@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/349233004
2014-06-23 09:01:52 -07:00
krajcevski
912d809a85
Rebaseline after dithering change
...
TBR=bsalomon@google.com
BUG=skia:
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/347103003
2014-06-20 09:02:16 -07:00
krajcevski
f461a8fdf6
Simple GPU based dithering:
...
If dithering is turned on, apply an effect that filters the pixel through
the following pipeline:
for each channel c:
1. Compute quantized colors [low, high] that c is between
2. Pick high by flipping a coin weighted by (c - low)
R=bsalomon@google.com , egdaniel@google.com , robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/321253002
2014-06-19 14:14:06 -07:00
egdaniel
00fb42704a
Rebaslines from recent dashing changes
...
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/339203003
2014-06-18 06:56:19 -07:00
reed
1777f233bd
unignore canvas-layer-state
...
TBR=
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/336273005
2014-06-18 05:47:45 -07:00
humper
4a24cd8ff4
Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader.
...
approved over in https://codereview.chromium.org/331863006/ ; reuploading
because it had the wrong base url
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/341543005
2014-06-17 13:39:31 -07:00
reed
0992d0764b
rebaseline after changing labels in bitmapfilters
...
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/340583004
2014-06-17 12:31:49 -07:00
dandov
baa860c297
* Removed bitmapshaders from expectations/gm/ignored-tests.txt.
...
* Rebaseline bitmapshaders, gpu didn't produce the same images when using only alpha bitmaps
because it didn't consider the skpaint's color.
BUG=skia:2293
R=jvanverth@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/339923004
2014-06-17 11:21:46 -07:00
reed
12d4aa69b5
ignore bitmapfilters failures until we can rebaseline
...
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/339153004
2014-06-17 10:28:08 -07:00
kevin.petit
cf2187267b
Armv8/64bit doesn't (apparently) need rebaselining
...
BUG=skia:
R=reed@google.com
NOTRY=True
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/334743009
2014-06-16 10:05:41 -07:00
senorblanco
9a8699f45c
New baselines for perlin noise tests affected by ce6a35.
...
New baselines for perlinnoise, imagefiltersclipped and
imagefiltersscaled GMs.
R=scroggo@google.com
TBR=scroggo
NOTRY=true
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/336703002
2014-06-12 14:31:57 -07:00
reed
2526f0e5fd
rebaselines for removal of unitmapper
...
TBR=
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/330513005
2014-06-12 12:53:01 -07:00
Stephen White
1b5e04ec5f
Add more tests to ignore-tests.txt.
...
Add imagefiltersclipped and imagefiltersscaled to ignored-tests.txt
until they can be rebaselined, since they're failing on Android after
https://codereview.chromium.org/332523006/ .
TBR=scroggo
BUG=skia:
Review URL: https://codereview.chromium.org/336663002
2014-06-12 15:51:46 -04:00
scroggo
e07c1ab408
Revert of third try at landing improved blur rect; this time with more correctness ( https://codereview.chromium.org/331443003/ )
...
Reason for revert:
Failing layout test: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/32762/layout-test-results/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-pretty-diff.html
Original issue's description:
> third try at landing improved blur rect; this time with more correctness
>
> BUG=skia:2095
> R=bsalomon@google.com
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/72abfc2b4e7caead660f6b6a05e60d05eaf1a66f
R=bsalomon@google.com , reed@google.com , humper@google.com
TBR=bsalomon@google.com , humper@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/333763002
2014-06-12 12:10:24 -07:00
senorblanco
ce6a354e12
Fix tiled perlin noise.
...
It turns out that the perlin implementation we inherited from WebKit
does not actually generate tileable noise (see Chromium bug
http://crbug.com/383495 ).
The main problem is that when generating coordinates for gradient
interpolation, it was attempting to wrap both x and (x + 1)
simultaneously at the tile boundary (that is, either both or neither
are wrapped). This obviously won't work, since along the tile seams,
(x + 1) should be wrapped, but x should not. The same is true in y.
This patch fixes both the CPU and GPU paths, renames some variables to
more closely match the spec, and modifies the perlin noise GM to
actually test tiling. (Note that the clipping the GM was doing was
removed, since it's superfluous: it used to be necessary for image
filters, but isn't anymore, and this isn't an image filter GM anyway.)
R=sugoi@google.com , sugoi
TBR=senorblanco
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/332523006
2014-06-12 11:24:20 -07:00
egdaniel
e61c411c12
Use vertex attributes for dash effect in gpu
...
This will allow us to batch dashed lines together when drawing. Also, this removes the need for
a coord transform matrix in the shader, thus we save the cost of uploading a new matrix uniform
everytime we do a simple transform to the dashed line we are drawing.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/326103002
2014-06-12 10:24:21 -07:00
humper
72abfc2b4e
third try at landing improved blur rect; this time with more correctness
...
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/331443003
2014-06-11 12:42:49 -07:00
reed
b0b1aa04ed
Revert of second try at landing improved blur rect ( https://codereview.chromium.org/325703002/ )
...
Reason for revert:
broke some fast/canvas layout tests
Original issue's description:
> second try at landing improved blur rect
>
> BUG=skia:2095
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/e9ea0d6b7d59ac3b7e257281e545b24bcc0d2a76
R=bsalomon@google.com , reed@chromium.org , humper@google.com
TBR=bsalomon@google.com , humper@google.com , reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095
Author: reed@google.com
Review URL: https://codereview.chromium.org/322423002
2014-06-11 07:26:23 -07:00
dandov
9de5b514d3
SkShader::asNewEffect Refactoring
...
The new signature is:
bool asNewEffect(GrContext* context, const SkPaint& paint, GrColor* grColor, GrEffectRef** grEffect, const SkMatrix* localMatrixOrNull) const;
It will fix the hack for skcolorshader by modifying the GrColor parameter in SkGr::SkPaint2GrPaintShader.
BUG=skia:2646
R=jvanverth@google.com , bsalomon@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/318923005
2014-06-10 14:38:28 -07:00
humper
e9ea0d6b7d
second try at landing improved blur rect
...
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/325703002
2014-06-09 14:35:21 -07:00
robertphillips
9f1c241e0d
Remove SkPicture::kUsePathBoundsForClip_RecordingFlag
...
The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer?
R=reed@google.com , mtklein@google.com , djsollen@google.com , scroggo@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/316143003
2014-06-09 06:25:34 -07:00
jvanverth
d78a2fac37
Rollback of fe689c46
and all subsequent changes
...
BUG=skia:
R=humper@google.com
TBR=humper@google.com
NOTRY=True
NOTREECHECKS=True
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/324463005
2014-06-06 13:40:36 -07:00
jvanverth
a07213ac83
Disable bigblurs GM (for fe689c46a7
)
...
BUG=skia:
R=humper@google.com
TBR=humper@google.com
NOTRY=True
NOTREECHECKS=True
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/325453002
2014-06-06 11:59:26 -07:00
humper
ede6cfc0f5
Revert of Revert of another GM to ignore for blur rebaseline ( https://codereview.chromium.org/319943004/ )
...
Reason for revert:
Hopefully working now
Original issue's description:
> Revert of another GM to ignore for blur rebaseline (https://codereview.chromium.org/319203002/ )
>
> Reason for revert:
> Follow-on to fe689c46a7
, which needs to be reverted due to bot failures.
>
> Original issue's description:
> > another GM to ignore for blur rebaseline
> >
> > BUG=skia:
> > TBR=jvanverth
> > NOTRY=True
> > NOTREECHECKS=True
> >
> > Committed: https://skia.googlesource.com/skia/+/f131055929afb9c9671aee3e575c380d48c5ee4d
>
> TBR=humper@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f255de0fe160e33b340301859be1d9374c5607fe
R=jvanverth@google.com
TBR=jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: humper@google.com
Review URL: https://codereview.chromium.org/324453004
2014-06-06 11:18:17 -07:00
jvanverth
f255de0fe1
Revert of another GM to ignore for blur rebaseline ( https://codereview.chromium.org/319203002/ )
...
Reason for revert:
Follow-on to fe689c46a7
, which needs to be reverted due to bot failures.
Original issue's description:
> another GM to ignore for blur rebaseline
>
> BUG=skia:
> TBR=jvanverth
> NOTRY=True
> NOTREECHECKS=True
>
> Committed: https://skia.googlesource.com/skia/+/f131055929afb9c9671aee3e575c380d48c5ee4d
R=humper@google.com
TBR=humper@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/319943004
2014-06-06 10:59:13 -07:00
humper
f131055929
another GM to ignore for blur rebaseline
...
BUG=skia:
TBR=jvanverth
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/319203002
2014-06-06 10:36:02 -07:00
humper
fe689c46a7
Faster GPU rect blur that doesn't require computing vertical and horizontal
...
scanlines on the CPU first. Should make extremely large drop shadows fast
again.
BUG=skia:
R=bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/316273004
2014-06-06 09:48:40 -07:00
kevin.petit
ea6b46b6c0
ARM Skia NEON patches - 39 - arm64 565 blitters
...
This enables all 565 blitters except S32A_D565_Opaque.
Here are some performance results:
S32_D565_Opaque:
================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -18.37% | -13.04% |
+-------+------------+------------+
| 2 | -9.90% | -13.78% |
+-------+------------+------------+
| 4 | -8.28% | -6.77% |
+-------+------------+------------+
| 8 | 157.63% | 78.15% |
+-------+------------+------------+
| 16 | 72.67% | 44.81% |
+-------+------------+------------+
| 64 | 76.78% | 40.89% |
+-------+------------+------------+
| 256 | 73.85% | 36.05% |
+-------+------------+------------+
| 1024 | 75.73% | 36.70% |
+-------+------------+------------+
S32_D565_Blend:
===============
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -9.99% | -13.79% |
+-------+------------+------------+
| 2 | -9.17% | -6.74% |
+-------+------------+------------+
| 4 | -6.73% | -4.42% |
+-------+------------+------------+
| 8 | 163.31% | 112.82% |
+-------+------------+------------+
| 16 | 55.21% | 44.68% |
+-------+------------+------------+
| 64 | 54.09% | 41.99% |
+-------+------------+------------+
| 256 | 52.63% | 40.64% |
+-------+------------+------------+
| 1024 | 52.46% | 40.45% |
+-------+------------+------------+
S32A_D565_Blend:
================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -5.88% | -6.06% |
+-------+------------+------------+
| 2 | -4.74% | -0.01% |
+-------+------------+------------+
| 4 | -5.42% | -3.03% |
+-------+------------+------------+
| 8 | 78.78% | 77.96% |
+-------+------------+------------+
| 16 | 98.19% | 79.61% |
+-------+------------+------------+
| 64 | 111.56% | 72.60% |
+-------+------------+------------+
| 256 | 113.80% | 69.96% |
+-------+------------+------------+
| 1024 | 114.42% | 70.85% |
+-------+------------+------------+
S32_D565_Opaque_Dither:
=======================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -4.18% | -0.93% |
+-------+------------+------------+
| 2 | -2.43% | -2.04% |
+-------+------------+------------+
| 4 | -1.09% | -1.23% |
+-------+------------+------------+
| 8 | 184.89% | 136.53% |
+-------+------------+------------+
| 16 | 128.64% | 89.11% |
+-------+------------+------------+
| 64 | 132.68% | 100.98% |
+-------+------------+------------+
| 256 | 157.02% | 100.86% |
+-------+------------+------------+
| 1024 | 163.85% | 103.62% |
+-------+------------+------------+
S32_D565_Blend_Dither:
======================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -4.87% | 0.01% |
+-------+------------+------------+
| 2 | -2.71% | 2.97% |
+-------+------------+------------+
| 4 | -2.20% | 0.28% |
+-------+------------+------------+
| 8 | 149.76% | 146.80% |
+-------+------------+------------+
| 16 | 85.69% | 95.77% |
+-------+------------+------------+
| 64 | 88.81% | 101.39% |
+-------+------------+------------+
| 256 | 97.32% | 107.22% |
+-------+------------+------------+
| 1024 | 98.08% | 115.71% |
+-------+------------+------------+
S32A_D565_Opaque_Dither:
========================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -1.86% | 0.02% |
+-------+------------+------------+
| 2 | -0.58% | -1.52% |
+-------+------------+------------+
| 4 | -0.75% | 1.16% |
+-------+------------+------------+
| 8 | 240.74% | 155.16% |
+-------+------------+------------+
| 16 | 181.97% | 132.15% |
+-------+------------+------------+
| 64 | 203.11% | 136.48% |
+-------+------------+------------+
| 256 | 223.45% | 133.05% |
+-------+------------+------------+
| 1024 | 225.96% | 134.05% |
+-------+------------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/317193003
2014-06-06 08:45:36 -07:00
bsalomon
93c2fb02f1
Rebaselines for drrect GM on GPU
...
TBR=
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/318773007
2014-06-05 07:56:56 -07:00
Brian Salomon
c7671bec73
Rebase a few GMs and remove some tests from ignored-tests.txt
...
Review URL: https://codereview.chromium.org/311813003
2014-06-03 10:01:47 -04:00
bsalomon
8af0523b38
Fall back to using clip effect for outer rect in drawdrrect
...
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/310483010
2014-06-03 06:34:59 -07:00
commit-bot@chromium.org
c4be1462df
re-enable downsample and filterbitmap GMs
...
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/301963003
git-svn-id: http://skia.googlecode.com/svn/trunk@14953 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 14:53:24 +00:00
commit-bot@chromium.org
f87f1e31c5
rebaselines for shadertext after unitmapper removal
...
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/308653002
git-svn-id: http://skia.googlecode.com/svn/trunk@14948 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 13:56:19 +00:00
commit-bot@chromium.org
e9ba81f43a
rebaseline shadertext2 shadertext3 and stroketext (sans 2)
...
NOTRY=True
TBR=epoger
Author: reed@google.com
Review URL: https://codereview.chromium.org/304763003
git-svn-id: http://skia.googlecode.com/svn/trunk@14924 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 18:49:15 +00:00
commit-bot@chromium.org
fa95b26b7a
rename ignored tests
...
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=true
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/304533008
git-svn-id: http://skia.googlecode.com/svn/trunk@14922 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 18:05:42 +00:00
commit-bot@chromium.org
f449156bd0
Make image scaling have floating point scales. Third attempt to land this
...
due to some struggles with the CQ. Original CL here:
https://codereview.chromium.org/298243003/
BUG=
R=bsalomon@google.com , epoger@google.com
TBR=bsalomon, epoger
Author: humper@google.com
Review URL: https://codereview.chromium.org/300113008
git-svn-id: http://skia.googlecode.com/svn/trunk@14920 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 17:30:02 +00:00
bsalomon@google.com
025e6d53d7
Take care of a bunch of pending GPU rebaselines and remove tests from ignored-tests.txt
...
Review URL: https://codereview.chromium.org/300863006
git-svn-id: http://skia.googlecode.com/svn/trunk@14918 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 16:41:21 +00:00
commit-bot@chromium.org
e8765c4654
rebaseline simpleblurroundrect
...
BUG=
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/300833002
git-svn-id: http://skia.googlecode.com/svn/trunk@14895 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 15:28:03 +00:00
commit-bot@chromium.org
f21991b104
Revert of Modify sample buffer size for larger displays. ( https://codereview.chromium.org/240433002/ )
...
Reason for revert:
This also changes verylargebitmap, and the difference appears to be meaningful. Henrik, I have emailed you the images that differ.
Original issue's description:
> Modify sample buffer size for larger displays.
>
> Increases the intermediate buffer size for sample pixel indexes,
> used in the sample proc function calls. If the operation is bigger
> than the buffer it's split into multiple calls, creating overhead.
> This would especially impact the performance of SIMD optimizations.
> Also, aligns the start address of the buffer to 16 bytes, to enable
> more efficient SIMD optimizations.
>
> Author: henrik.smiding@intel.com
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: http://code.google.com/p/skia/source/detail?r=14825
>
> Committed: http://code.google.com/p/skia/source/detail?r=14872
R=reed@google.com , mtklein@google.com , tomhudson@google.com , djsollen@google.com , joakim.landberg@intel.com , bsalomon@chromium.org , bsalomon@google.com , henrik.smiding@intel.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/294023016
git-svn-id: http://skia.googlecode.com/svn/trunk@14878 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 19:13:56 +00:00
commit-bot@chromium.org
334ec00234
Revert of Suppress more GMs pending rebaseline after 0533146d00
( https://codereview.chromium.org/296173009/ )
...
Reason for revert:
The CL for which these were added needs to be reverted. The best example of its breakage is in verylargebitmap.
Original issue's description:
> Suppress more GMs pending rebaseline after 0533146d00
>
> TBR=scroggo@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=14874
R=fmalita@chromium.org
TBR=fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/298973008
git-svn-id: http://skia.googlecode.com/svn/trunk@14877 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 19:09:46 +00:00
commit-bot@chromium.org
446aefe2af
instead of ignoring testimagefilters EVERYWHERE, just ignore particular failures
...
BUG=skia:2603
NOTREECHECKS=True
NOTRY=True
R=fmalita@google.com
TBR=fmalita
Author: epoger@google.com
Review URL: https://codereview.chromium.org/296213009
git-svn-id: http://skia.googlecode.com/svn/trunk@14876 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 19:08:17 +00:00
fmalita@google.com
720b703ee7
Suppress testimagefilters GM.
...
Failing on Android, but results missing.
BUG=skia:2603
TBR=epoger@google.com
Review URL: https://codereview.chromium.org/299143006
git-svn-id: http://skia.googlecode.com/svn/trunk@14875 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 18:44:21 +00:00
fmalita@google.com
af6d1701f9
Suppress more GMs pending rebaseline after 0533146d00
...
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/296173009
git-svn-id: http://skia.googlecode.com/svn/trunk@14874 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 18:34:18 +00:00
commit-bot@chromium.org
0533146d00
Modify sample buffer size for larger displays.
...
Increases the intermediate buffer size for sample pixel indexes,
used in the sample proc function calls. If the operation is bigger
than the buffer it's split into multiple calls, creating overhead.
This would especially impact the performance of SIMD optimizations.
Also, aligns the start address of the buffer to 16 bytes, to enable
more efficient SIMD optimizations.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
Committed: http://code.google.com/p/skia/source/detail?r=14825
R=reed@google.com , mtklein@google.com , tomhudson@google.com , djsollen@google.com , joakim.landberg@intel.com , scroggo@google.com , bsalomon@chromium.org , bsalomon@google.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/240433002
git-svn-id: http://skia.googlecode.com/svn/trunk@14872 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 16:05:43 +00:00
commit-bot@chromium.org
c93e68161f
fix the visual diff of raster vs gpu -- vertices_80. The sw-raster is correct, all images are blurry.
...
While some images generated by gpu doesn't respect SkPaint's alpha value.
In gpu path, when pass SkPaint's alpha and color to GrPaint by SkPaint2GrPaintNoShader,
either alpha or colors can't not be passed. We can't pass both of them by the API.
Premultiply paint's alpha to colors's alpha in drawVertices, and pass colors to GrPaint.
The rendering result will respect colors in drawVertices, and the alpha value set in SkPaint as well.
BUG=skia:2592
R=bsalomon@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/292943002
git-svn-id: http://skia.googlecode.com/svn/trunk@14863 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 08:09:26 +00:00
commit-bot@chromium.org
74266814a0
update stroketext gm
...
TBR=bungeman
Author: reed@google.com
Review URL: https://codereview.chromium.org/293983016
git-svn-id: http://skia.googlecode.com/svn/trunk@14848 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-22 17:41:41 +00:00
commit-bot@chromium.org
83f23d87f1
Remove unused (by clients) SkUnitMapper
...
This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98.
TBR=scroggo
Author: reed@google.com
Review URL: https://codereview.chromium.org/288313009
git-svn-id: http://skia.googlecode.com/svn/trunk@14842 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-22 12:27:41 +00:00
commit-bot@chromium.org
3339ac54a5
Revert of Remove unused (by clients) SkUnitMapper ( https://codereview.chromium.org/283273002/ ) ( https://codereview.chromium.org/288343009/ )
...
Reason for revert:
required blink change failed to land
Original issue's description:
> Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/ )
>
> This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14830
R=scroggo@google.com , reed@google.com
TBR=reed@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/296823008
git-svn-id: http://skia.googlecode.com/svn/trunk@14838 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-22 02:55:59 +00:00
commit-bot@chromium.org
4b8f802255
Remove unused (by clients) SkUnitMapper ( https://codereview.chromium.org/283273002/ )
...
This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/288343009
git-svn-id: http://skia.googlecode.com/svn/trunk@14830 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-21 19:56:46 +00:00
reed@google.com
b03be0b887
Revert "Modify sample buffer size for larger displays."
...
This reverts commit dd72f3bd0d500b9b3f900bcb8e904161ee51eae5.
git-svn-id: http://skia.googlecode.com/svn/trunk@14827 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-21 16:38:43 +00:00
commit-bot@chromium.org
af159a580b
Modify sample buffer size for larger displays.
...
Increases the intermediate buffer size for sample pixel indexes,
used in the sample proc function calls. If the operation is bigger
than the buffer it's split into multiple calls, creating overhead.
This would especially impact the performance of SIMD optimizations.
Also, aligns the start address of the buffer to 16 bytes, to enable
more efficient SIMD optimizations.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com , mtklein@google.com , tomhudson@google.com , djsollen@google.com , joakim.landberg@intel.com , scroggo@google.com , bsalomon@chromium.org , bsalomon@google.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/240433002
git-svn-id: http://skia.googlecode.com/svn/trunk@14825 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-21 15:16:15 +00:00
commit-bot@chromium.org
9927bd355f
Centralize decision about whether to do bicubic filtering, and fallbacks to mip, bilerp, or nearest
...
R=robertphillips@google.com , humper@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/282293004
git-svn-id: http://skia.googlecode.com/svn/trunk@14809 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-20 17:51:13 +00:00
commit-bot@chromium.org
4297430b93
Rebaselines for gpu dashing
...
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/291893004
git-svn-id: http://skia.googlecode.com/svn/trunk@14796 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-20 13:43:34 +00:00
commit-bot@chromium.org
7ba1702bbb
fix off-by-one error in texture coordinate calculations for rrect gpu
...
blur; output now matches CPU
BUG=
R=bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/292773003
git-svn-id: http://skia.googlecode.com/svn/trunk@14788 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-19 18:51:05 +00:00
commit-bot@chromium.org
628ed0b220
Add Dashing gpu effect for simple dashed lines
...
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/274673004
git-svn-id: http://skia.googlecode.com/svn/trunk@14775 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-19 14:32:49 +00:00
commit-bot@chromium.org
e2b193ca5c
Revert of remove unused (by clients) SkUnitMapper ( https://codereview.chromium.org/283273002/ )
...
Reason for revert:
does not address all legacy callsites in chrome.
e.g.
[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919] gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));
Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761
R=robertphillips@google.com , scroggo@google.com , george@mozilla.com
TBR=george@mozilla.com , robertphillips@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/287063009
git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-16 13:49:08 +00:00
commit-bot@chromium.org
ee0cac336c
remove unused (by clients) SkUnitMapper
...
BUG=skia:
R=robertphillips@google.com , scroggo@google.com , george@mozilla.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/283273002
git-svn-id: http://skia.googlecode.com/svn/trunk@14761 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-16 13:35:01 +00:00
commit-bot@chromium.org
a17773f0b0
Disable filtering in draw Bitmap operation when pixels are aligned
...
The check is now performed in the callers of internalDrawBitmap() to
avoid retrieve the texture with wrong filter mode when the pixels were
aligned.
This bug was spotted in Chrome for Android: Chrome for Androids's
Canvas drawImage loses fidelity in canvases larger than 64k pixels.
BUG=chromium:231916
R=bsalomon@google.com , robertphillips@google.com
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Author: siglesias@igalia.com
Review URL: https://codereview.chromium.org/264303008
git-svn-id: http://skia.googlecode.com/svn/trunk@14665 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 13:53:38 +00:00
commit-bot@chromium.org
6803c219dd
Revert of fix the error that path is inversed for stroke and strokeAndFill styles ( https://codereview.chromium.org/183683010/ )
...
R=bsalomon@google.com , reed@google.com , yunchao.he@intel.com
TBR=reed@google.com
NOTRY=True
Reason for revert:
broke unittests
Original issue's description:
> fix the error that path is inversed for stroke and strokeAndFill styles.
>
> However, because hairline stroke + fill = fill (see src/core/SkStrokeRec.cpp), strokeAndFill will be thought as fill style when paint.getStrokeWidth() <= 0, this edge case can be inverse-filled.
>
> BUG=skia:2222
>
> Committed: http://code.google.com/p/skia/source/detail?r=14561
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/269903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14562 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-04 18:08:27 +00:00
commit-bot@chromium.org
1f99d933e5
fix the error that path is inversed for stroke and strokeAndFill styles.
...
However, because hairline stroke + fill = fill (see src/core/SkStrokeRec.cpp), strokeAndFill will be thought as fill style when paint.getStrokeWidth() <= 0, this edge case can be inverse-filled.
BUG=skia:2222
R=bsalomon@google.com , reed@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/183683010
git-svn-id: http://skia.googlecode.com/svn/trunk@14561 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-04 03:43:20 +00:00
commit-bot@chromium.org
82bc432683
re-enable simpleblurroundrect gm now that all the rebaselines have landed
...
BUG=skia:
R=djsollen@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/268763004
git-svn-id: http://skia.googlecode.com/svn/trunk@14542 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-02 18:00:58 +00:00
commit-bot@chromium.org
1d146d431a
Revert of Roll ANGLE. ( https://codereview.chromium.org/237173002/ )
...
Reason for revert:
breaking the buildbots (see http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Release-ANGLE/builds/3198 ).
NOTRY=true
Original issue's description:
> Roll ANGLE.
>
> BUG=skia:2272
>
> Committed: http://code.google.com/p/skia/source/detail?r=14243
>
> Committed: http://code.google.com/p/skia/source/detail?r=14509
R=bsalomon@chromium.org , bsalomon@google.com , geofflang@chromium.org , djsollen@google.com , mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/264733006
git-svn-id: http://skia.googlecode.com/svn/trunk@14517 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 20:20:50 +00:00
commit-bot@chromium.org
1267219c53
Roll ANGLE.
...
BUG=skia:2272
Committed: http://code.google.com/p/skia/source/detail?r=14243
R=bsalomon@chromium.org , bsalomon@google.com
Author: geofflang@chromium.org
Review URL: https://codereview.chromium.org/237173002
git-svn-id: http://skia.googlecode.com/svn/trunk@14509 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 19:22:22 +00:00
commit-bot@chromium.org
47f9419760
Revert of re-enable simpleblurroundrect gm ( https://codereview.chromium.org/263823002/ )
...
Reason for revert:
broken rebaseline.
Original issue's description:
> re-enable simpleblurroundrect gm
>
> BUG=skia:
> TBR=caryclark
>
> Committed: http://code.google.com/p/skia/source/detail?r=14498
R=caryclark@google.com
TBR=caryclark@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: humper@google.com
Review URL: https://codereview.chromium.org/265863002
git-svn-id: http://skia.googlecode.com/svn/trunk@14500 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 15:18:06 +00:00
commit-bot@chromium.org
4363a66662
re-enable simpleblurroundrect gm
...
BUG=skia:
R=caryclark@google.com
TBR=caryclark
Author: humper@google.com
Review URL: https://codereview.chromium.org/263823002
git-svn-id: http://skia.googlecode.com/svn/trunk@14498 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 14:38:45 +00:00
commit-bot@chromium.org
618bb5269f
remove inverse_paths from ignored tests
...
new expectations have been checked in
https://codereview.chromium.org/264653003
R=reed@android.com
TBR=reed
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/265453009
git-svn-id: http://skia.googlecode.com/svn/trunk@14477 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 16:34:43 +00:00
commit-bot@chromium.org
87bbefda9d
un-ignore image-surface GM results
...
NOTRY=True
TBR=reed@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/264623004
git-svn-id: http://skia.googlecode.com/svn/trunk@14468 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 15:22:47 +00:00
senorblanco@chromium.org
83ad45ae3a
New baselines for tileimagefilter GM after r14432.
...
TBR=caryclark@google.com
Review URL: https://codereview.chromium.org/260753002
git-svn-id: http://skia.googlecode.com/svn/trunk@14462 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 14:35:57 +00:00
commit-bot@chromium.org
b8b8b6d151
remove rebaselined tests from ignore file
...
this removes the lines corresponding to this rebaseline CL
Change committed as 14447
https://codereview.chromium.org/263473002/
R=reed@android.com
TBR=reed
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/262583005
git-svn-id: http://skia.googlecode.com/svn/trunk@14461 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 14:33:04 +00:00
senorblanco@chromium.org
0a5c233e3b
Implement bounds traversals for tile and matrix convolution filters.
...
Add a new GM that exercises tiled drawing all pixel-moving filters
(and some non-pixel-moving ones) and compares it against non-tiled
drawing of the same filters. Fixing this test revealed that tile and
matrix convolution filters had no onFilterBounds() traversals
(test-driven development FTW). Tile requires (conservatively) the
bounds to include the whole source rect, since it may end up in the
result. Matrix convolution requires the bounds to be offset by the
kernel size and target.
R=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/258243005
git-svn-id: http://skia.googlecode.com/svn/trunk@14432 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-29 15:20:39 +00:00
commit-bot@chromium.org
3d8bf232bd
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
...
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=14392
Committed: http://code.google.com/p/skia/source/detail?r=14404
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14420 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 19:49:24 +00:00
commit-bot@chromium.org
55aec08681
revert humper changes
...
https://skia.googlesource.com/skia.git/+/24e91ba3029a3a1fb60cab3ae4e68c3c44776f25
https://skia.googlesource.com/skia.git/+/a36c78240e14aeb130a97c43f3992ea19696b929
NOTREECHECKS=true
BUG=skia:
R=caryclark@google.com , mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/256803011
git-svn-id: http://skia.googlecode.com/svn/trunk@14414 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 18:21:24 +00:00
commit-bot@chromium.org
a36c78240e
spelling fix
...
BUG=skia:
R=caryclark@google.com
TBR=caryclark
Author: humper@google.com
Review URL: https://codereview.chromium.org/259043002
git-svn-id: http://skia.googlecode.com/svn/trunk@14409 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 16:02:23 +00:00
commit-bot@chromium.org
24e91ba302
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
...
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=14392
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14404 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 15:09:14 +00:00
commit-bot@chromium.org
c76a4b2a81
Revert of Fast path for blurred round rects -- blur a small 9patch rect on the CPU ( https://codereview.chromium.org/248613004/ )
...
Reason for revert:
Looks like this causes unit tests to fail with a zero constructor like this one: http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Release/builds/2326/steps/RunTests/logs/stdio
Original issue's description:
> Fast path for blurred round rects -- blur a small 9patch rect on the CPU
> And nonlinearly stretch the resulting texture across proxy geometry.
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=14392
R=bsalomon@google.com , reed@google.com , humper@google.com
TBR=bsalomon@google.com , humper@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/258893010
git-svn-id: http://skia.googlecode.com/svn/trunk@14400 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 14:44:54 +00:00
commit-bot@chromium.org
5729387fe0
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
...
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
R=bsalomon@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14392 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 13:19:23 +00:00
commit-bot@chromium.org
0ad7936b7b
Rebaselines for 2pt Conical Gradients
...
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/249523003
git-svn-id: http://skia.googlecode.com/svn/trunk@14325 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-23 16:12:52 +00:00
commit-bot@chromium.org
c8379d7f1b
Add gpu fast path for two point conical gradients.
...
Also shader changes should help numerical issues on certain android gpus
BUG=179264
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/238443006
git-svn-id: http://skia.googlecode.com/svn/trunk@14316 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 20:56:37 +00:00
commit-bot@chromium.org
44d83c1e81
Add flipped gradient branch to two point conical gradient
...
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=14235
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/227623004
git-svn-id: http://skia.googlecode.com/svn/trunk@14271 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-21 13:10:25 +00:00
bsalomon@google.com
d15b4537b4
Mass baseline for filltypespersp
...
Review URL: https://codereview.chromium.org/243853002
git-svn-id: http://skia.googlecode.com/svn/trunk@14263 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-18 21:57:48 +00:00
bsalomon@google.com
015514c591
Mass baselining of drrect GM
...
Review URL: https://codereview.chromium.org/243723003
git-svn-id: http://skia.googlecode.com/svn/trunk@14262 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-18 21:06:59 +00:00
bsalomon@google.com
39d7f0d9a7
Mass rebaseline of the rrect_* GMs
...
Review URL: https://codereview.chromium.org/243693002
git-svn-id: http://skia.googlecode.com/svn/trunk@14261 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-18 20:13:43 +00:00
commit-bot@chromium.org
0b17feaa64
Revert of Roll ANGLE. ( https://codereview.chromium.org/237173002/ )
...
Reason for revert:
http://skbug.com/2437
Original issue's description:
> Roll ANGLE.
>
> BUG=skia:2272
>
> Committed: http://code.google.com/p/skia/source/detail?r=14243
R=bsalomon@chromium.org , geofflang@chromium.org
TBR=bsalomon@chromium.org , geofflang@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2272
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/238863006
git-svn-id: http://skia.googlecode.com/svn/trunk@14248 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-17 21:31:32 +00:00
commit-bot@chromium.org
cd66af0ae0
Roll ANGLE.
...
BUG=skia:2272
R=bsalomon@chromium.org , bsalomon@google.com
Author: geofflang@chromium.org
Review URL: https://codereview.chromium.org/237173002
git-svn-id: http://skia.googlecode.com/svn/trunk@14243 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-17 18:29:06 +00:00
commit-bot@chromium.org
5d0b150257
resize canvas for GM + typo
...
This change resized the canvas for some GM cases. It is better to show the visual difference in viewer.html for these cases after the CL applied.
BUG=skia:2375
R=reed@google.com , djsollen@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/221953002
git-svn-id: http://skia.googlecode.com/svn/trunk@14177 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-14 15:02:19 +00:00
robertphillips@google.com
c202ea7cc6
Adding image-surface to ignored-tests.txt
...
git-svn-id: http://skia.googlecode.com/svn/trunk@14170 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-13 18:01:01 +00:00
commit-bot@chromium.org
0a09d7195b
Implement drawDRRect for GPU
...
BUG=skia:2259
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/220233011
git-svn-id: http://skia.googlecode.com/svn/trunk@14118 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-09 21:26:11 +00:00
commit-bot@chromium.org
cb1926cc7a
Rebaselines for https://codereview.chromium.org/181523002/
...
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/230733004
git-svn-id: http://skia.googlecode.com/svn/trunk@14105 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-09 14:34:24 +00:00
commit-bot@chromium.org
95c2e5532b
ARM Skia NEON patches - 22 - S32_D565_Blend
...
BlitRow565: new NEON version of S32_D565_Blend
This new implementation brings a good speedup in most cases and
gives exact results (removes one mismatch in gm).
Here are the benchmark results (speedup vs. existing S32A_D565_Blend):
+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1 | -26,7% | -27,5% |
+-------+-----------+------------+
| 2 | 0% | +53% |
+-------+-----------+------------+
| 4 | +38,3% | +26,5% |
+-------+-----------+------------+
| 8 | +10,9% | -4,5% |
+-------+-----------+------------+
| 16 | +18,2% | +1,6% |
+-------+-----------+------------+
| 64 | +22,3% | +8,75% |
+-------+-----------+------------+
| 256 | +12,3% | +11,2% |
+-------+-----------+------------+
| 1024 | +79,2% | +10,9% |
+-------+-----------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/181523002
git-svn-id: http://skia.googlecode.com/svn/trunk@14103 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-09 09:46:31 +00:00
commit-bot@chromium.org
c5d9bb0f67
Initial picture shader implementation
...
This CL adds an SkPictureShader class to support SkPicture-based
patterns.
The implementation renders the picture into an SkBitmap tile and then
delegates to SkBitmapProcShader for the actual operation.
R=bsalomon@google.com , reed@google.com , robertphillips@google.com
Committed: http://code.google.com/p/skia/source/detail?r=14085
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/221923007
git-svn-id: http://skia.googlecode.com/svn/trunk@14092 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-08 15:19:34 +00:00
fmalita@google.com
98f4e5cea3
Suppress pictureshader GM failures.
...
Pending baselines.
TBR=bensong@google.com
Review URL: https://codereview.chromium.org/225413018
git-svn-id: http://skia.googlecode.com/svn/trunk@14086 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-07 23:30:37 +00:00
commit-bot@chromium.org
78842e4ad2
Rebaselining resizeimagefilter
...
BUG=skia:
R=senorblanco@google.com , senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/226413002
git-svn-id: http://skia.googlecode.com/svn/trunk@14068 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-04 21:23:30 +00:00
fmalita@google.com
96050eb5a1
Rebaseline two tests after r13940.
...
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/217423013
git-svn-id: http://skia.googlecode.com/svn/trunk@14005 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-01 13:28:19 +00:00
fmalita@google.com
f41e93b06a
Suppress failing GMs for rebaseline.
...
https://codereview.chromium.org/203203004 caused a couple of minor GM
diffs:
fontscaler
bleed
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/204983023
git-svn-id: http://skia.googlecode.com/svn/trunk@13943 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-25 19:36:20 +00:00
commit-bot@chromium.org
08f6d86f8e
update bitmapshader to avoid potential rendering error for kA8_Config
...
A local matrix is set to the shader, which will show the potential error for SkCanvas::drawBitmap when the bitmap is kA8_Config, as well as the potential error for drawing a geometry with a bitmapshader who's bitmap is kA8_Config.
A simple case is also added for SkCanvas::drawBitmap when the bitmap is kA8_Config, but there is not shader. Then the drawing area will be colorized by the solid color set in SkPaint.
BUG=skia:2278
BUG=skia:2293
R=reed@google.com , bsalomon@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/204143004
git-svn-id: http://skia.googlecode.com/svn/trunk@13904 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-24 02:49:48 +00:00
commit-bot@chromium.org
b659333bf6
Fixed double offset in resize filter
...
The fix is trivial, simply remove the extra offset
I added another case to the resizeimagefilter gm and made it so that it looks exactly like the one next to it, so that failure is easy to detect visually.
BUG=skia:
R=senorblanco@google.com , senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/208303002
git-svn-id: http://skia.googlecode.com/svn/trunk@13892 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-21 16:19:28 +00:00
senorblanco@chromium.org
d5104782f6
New baselines for imagefiltersscaled and lighting GMs.
...
TBR=jcgregorio@google.com
Review URL: https://codereview.chromium.org/206443003
git-svn-id: http://skia.googlecode.com/svn/trunk@13878 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-20 17:41:32 +00:00
commit-bot@chromium.org
2472b3219e
Only use analytic effect-based clipping when AA is required by at least one element.
...
BUG=352718
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/204983003
git-svn-id: http://skia.googlecode.com/svn/trunk@13867 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 21:26:35 +00:00
senorblanco@chromium.org
b9c95978c6
Use rounding to 8888 in lighting filters, raster path.
...
when converting float -> 8-bit BGRA in lighting filters, use rounding
rather than floor(). This makes the GPU and raster paths match more
closely (as tested by Blink test
feDiffuseLighting-linearrgb-lighting-color.svg).
Will affect the LSB of lighting, imagefiltersscaled GMs.
R=junov@chromium.org
BUG=skia:
Review URL: https://codereview.chromium.org/205073002
git-svn-id: http://skia.googlecode.com/svn/trunk@13863 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-19 19:44:41 +00:00
senorblanco@chromium.org
3604853488
Rebaseline imagefiltersscaled GM.
...
Rebaseline imagefiltersscaled GM for new test cases added in
https://code.google.com/p/skia/source/detail?r=13798 .
TBR=jcgregorio@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/203093004
git-svn-id: http://skia.googlecode.com/svn/trunk@13854 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-18 17:59:47 +00:00
commit-bot@chromium.org
1037d92bbc
Added Z scale when X and Y scale to spot lights and point lights
...
Z scale is set as the average of X scale and Y scale.
BUG=skia:
R=senorblanco@google.com , senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/198013002
git-svn-id: http://skia.googlecode.com/svn/trunk@13798 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-13 19:45:41 +00:00
senorblanco@chromium.org
fb882d774e
New GPU baselines for colormatrix GM.
...
TBR=halcanary@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/198973003
git-svn-id: http://skia.googlecode.com/svn/trunk@13784 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-13 15:33:02 +00:00
senorblanco@chromium.org
2ca677e75d
Fix GPU colormatrix color filter with saturated alpha.
...
Clamp RGBA values before unpremultiplying, to match the raster path. This causes a problem when the resulting
alpha is >1.0, resulting in overly saturated RGB.
Covered by the setYUV2RGB() test case in the colormatrix GM.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/196133006
git-svn-id: http://skia.googlecode.com/svn/trunk@13778 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-12 21:37:42 +00:00
commit-bot@chromium.org
4355f21dbc
Add elliptical-corner rrect clip effect. Currently only handles the case where all corners have the same pair of radii.
...
BUG=skia:2181
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/194603004
git-svn-id: http://skia.googlecode.com/svn/trunk@13766 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-12 15:32:50 +00:00
senorblanco@chromium.org
fb142aa07a
New baselines for imagefiltersclipped, offsetimagefilter GMs.
...
These were modified by
https://code.google.com/p/skia/source/detail?r=13744
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/196603005
git-svn-id: http://skia.googlecode.com/svn/trunk@13762 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-12 14:01:48 +00:00
senorblanco@chromium.org
06342a2666
Fix SkOffsetImageFilter to use a temporary for bounds computations.
...
SkOffsetImageFilter::onFilterBounds() was writing to *dst, and later
referring to src. These may be the same memory location, so the results
were incorrect.
Covered by the 5th test case in offsetimagefilter.
BUG=skia:
Review URL: https://codereview.chromium.org/195163004
git-svn-id: http://skia.googlecode.com/svn/trunk@13744 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-11 18:29:42 +00:00
commit-bot@chromium.org
c5c748c147
Handle rrects with one circular corner and three square corners in GrRRectEffect.
...
BUG=skia:2181
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/193263002
git-svn-id: http://skia.googlecode.com/svn/trunk@13739 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-11 15:54:51 +00:00
bsalomon@google.com
45b9de81bc
Rebase bezier_effect GMs and lingering changed GMs from laggy bots
...
Review URL: https://codereview.chromium.org/190663019
git-svn-id: http://skia.googlecode.com/svn/trunk@13734 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-10 21:42:48 +00:00
reed@google.com
b93ba45b58
flag to make kClipToLayer_SaveFlag the default behavior
...
#define SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG to get the old behavior
The goal is to remove the feature of saveLayer that allows the canvas to draw outside of the top-most layer.
R=robertphillips@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/190723004
git-svn-id: http://skia.googlecode.com/svn/trunk@13730 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-10 19:47:58 +00:00
commit-bot@chromium.org
bfce48e0bc
reorg iteration code in rrects GM, tightly pack rrects drawn in _effect version.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/190953008
git-svn-id: http://skia.googlecode.com/svn/trunk@13728 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-10 19:33:16 +00:00
bsalomon@google.com
77286a5945
Rebaselines for https://codereview.chromium.org/188693008/
...
Review URL: https://codereview.chromium.org/189913006
git-svn-id: http://skia.googlecode.com/svn/trunk@13713 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 22:34:32 +00:00
bsalomon@google.com
a10f26e5d1
update ignored-tests.txt to accound for acceptable changes due to r13710
...
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/189803005
git-svn-id: http://skia.googlecode.com/svn/trunk@13712 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 20:33:07 +00:00
commit-bot@chromium.org
e5a041c068
Implement the clip as 4 or fewer GrEffects when possible.
...
BUG=skia:2181
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/188693008
git-svn-id: http://skia.googlecode.com/svn/trunk@13710 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 19:43:43 +00:00
commit-bot@chromium.org
cabf4b2f36
Unify edge type enums across GrEffect subclasses that clip rendering to a geometry.
...
BUG=skia:
R=egdaniel@google.com , robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/183893023
git-svn-id: http://skia.googlecode.com/svn/trunk@13674 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 18:27:43 +00:00
senorblanco@chromium.org
968f1623af
New baselines for offsetimagefilter GM.
...
TBR=rmistry@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/187883002
git-svn-id: http://skia.googlecode.com/svn/trunk@13670 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-05 15:38:21 +00:00
senorblanco@chromium.org
a100bb25a5
New baselines for imagefiltersclipped, imagefiltersscaled GMs.
...
Required after r13637.
TBR=rmistry@google.com
Review URL: https://codereview.chromium.org/186933002
git-svn-id: http://skia.googlecode.com/svn/trunk@13659 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-04 19:22:43 +00:00
senorblanco@chromium.org
e09244d463
Apply the CTM to the offset in the slow SkOffsetImageFilter path.
...
This was being done in the fast path, but not the slow path.
Since I had to rebaseline the offsetimagefilter GM anyway (to accomodate
the new test case), I added a red border around the intersection
of the (transformed) crop rect and clip rect in each sample, beyond
which no pixels should be drawn.
Chrome bug: https://code.google.com/p/chromium/issues/detail?id=346362
BUG=skia:
R=sugoi@google.com
Review URL: https://codereview.chromium.org/186643003
git-svn-id: http://skia.googlecode.com/svn/trunk@13656 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-04 19:05:25 +00:00
senorblanco@chromium.org
47d98c8e85
Fix CTM scaling and clipping of SkRectShaderImageFilter.
...
Pass the CTM as part of the local matrix passed by
SkRectShaderImageFilter. Teach SkPerlinNoiseShader to respect the local
matrix. Embiggen imagefiltersscaled GM size to accommodate the new test
cases.
Note: will require rebaselines of imagefiltersscaled and imagefiltersclipped
R=sugoi@chromium.org
BUG=skia:
Review URL: https://codereview.chromium.org/184973007
git-svn-id: http://skia.googlecode.com/svn/trunk@13637 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-03 14:58:09 +00:00
commit-bot@chromium.org
335619b26b
update comments within expectations/gm/ignored-tests.txt
...
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=reed@android.com
TBR=reed
Author: epoger@google.com
Review URL: https://codereview.chromium.org/179023004
git-svn-id: http://skia.googlecode.com/svn/trunk@13593 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-26 17:30:43 +00:00
bsalomon@google.com
036405d4fb
Change comment for inverse_paths GM in ignored-tests.txt
...
BUG=skia:2222
Review URL: https://codereview.chromium.org/180213002
git-svn-id: http://skia.googlecode.com/svn/trunk@13585 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-25 18:54:34 +00:00
commit-bot@chromium.org
ee1d758dcc
rebaseline extractbitmap GMs, as the test itself changed
...
NOTRY=True
TBR=bsalomon
Author: reed@google.com
Review URL: https://codereview.chromium.org/180153002
git-svn-id: http://skia.googlecode.com/svn/trunk@13584 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-25 18:28:53 +00:00
bsalomon@google.com
888999a75b
rebaseline rrect gms
...
Review URL: https://codereview.chromium.org/180113002
git-svn-id: http://skia.googlecode.com/svn/trunk@13581 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-25 18:10:18 +00:00
commit-bot@chromium.org
5cf54d7b7d
Rebaselines for https://codereview.chromium.org/177963003/
...
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
NOTRY=true
NOTREECHECKS=true
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/179723004
git-svn-id: http://skia.googlecode.com/svn/trunk@13579 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-25 16:46:25 +00:00
senorblanco@chromium.org
418d00ffc3
Rebaseline canvas-layer-state (PDF only).
...
Remove expectations for now-passing tests.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/179403007
git-svn-id: http://skia.googlecode.com/svn/trunk@13578 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-25 15:49:07 +00:00
commit-bot@chromium.org
fe68eb6a40
ARM Skia NEON patches - 25 - S32A_D565_Opaque_Dither clean/bugfix/speed
...
BlitRow565: S32A_D565_Opaque_Dither: some improvements
- Supports ARGB and ABGR
- Less magic numbers
- Reduced instruction count : 5-25% speedup
- Fixed indentation, removed some commented and useless code
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/177963003
git-svn-id: http://skia.googlecode.com/svn/trunk@13577 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-25 10:54:32 +00:00
senorblanco@chromium.org
89f077ced4
Fix saveLayer() clipping w/filters, GPU path.
...
Don't modify the clipstack in saveLayer() if the kClipToLayer_SaveFlag is
not set. Without this the GPU path will clip the offscreen to the layer's
bounds, even if the flag is not set.
R=robertphillips@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/164203002
git-svn-id: http://skia.googlecode.com/svn/trunk@13561 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-24 15:16:42 +00:00
commit-bot@chromium.org
b0a1990bad
Rebaselines for https://codereview.chromium.org/158973002/
...
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/176683004
git-svn-id: http://skia.googlecode.com/svn/trunk@13559 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-24 13:36:21 +00:00
commit-bot@chromium.org
374ea4ee26
ARM Skia NEON patches - 12 - S32_Blend
...
Blitrow32: S32_Blend fix and little speed improvement
- the results are now exactly similar as the C code
- the speed has improved, especially for small values of count
+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1 | +30% | +18% |
+-------+-----------+------------+
| 2 | 0 | 0 |
+-------+-----------+------------+
| 4 | - <1% | +14% |
+-------+-----------+------------+
| > 4 | -0.5..+5% | -0.5..+4% |
+-------+-----------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=13532
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/158973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13543 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-21 19:49:17 +00:00
commit-bot@chromium.org
5b92499f8f
Revert of ARM Skia NEON patches - 12 - S32_Blend ( https://codereview.chromium.org/158973002/ )
...
Reason for revert:
Breaking the build.
See http://108.170.219.164:10117/builders/Build-Ubuntu12-GCC-Arm7-Debug-Nexus4/builds/2966 (and others).
We are getting warnings that vsrc and vdst may be uninitialized. Please fix and resubmit.
Original issue's description:
> ARM Skia NEON patches - 12 - S32_Blend
>
> Blitrow32: S32_Blend fix and little speed improvement
>
> - the results are now exactly similar as the C code
> - the speed has improved, especially for small values of count
>
> +-------+-----------+------------+
> | count | Cortex-A9 | Cortex-A15 |
> +-------+-----------+------------+
> | 1 | +30% | +18% |
> +-------+-----------+------------+
> | 2 | 0 | 0 |
> +-------+-----------+------------+
> | 4 | - <1% | +14% |
> +-------+-----------+------------+
> | > 4 | -0.5..+5% | -0.5..+4% |
> +-------+-----------+------------+
>
> Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13532
R=djsollen@google.com , mtklein@google.com , kevin.petit@arm.com
TBR=djsollen@google.com , kevin.petit@arm.com , mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/175433002
git-svn-id: http://skia.googlecode.com/svn/trunk@13534 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-21 17:52:17 +00:00
commit-bot@chromium.org
dfff2737f8
ARM Skia NEON patches - 12 - S32_Blend
...
Blitrow32: S32_Blend fix and little speed improvement
- the results are now exactly similar as the C code
- the speed has improved, especially for small values of count
+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1 | +30% | +18% |
+-------+-----------+------------+
| 2 | 0 | 0 |
+-------+-----------+------------+
| 4 | - <1% | +14% |
+-------+-----------+------------+
| > 4 | -0.5..+5% | -0.5..+4% |
+-------+-----------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/158973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13532 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-21 17:40:35 +00:00
commit-bot@chromium.org
c4f3b23b83
Rebaselines for https://codereview.chromium.org/167433002/
...
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com , hshi@chromium.org
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/174093006
git-svn-id: http://skia.googlecode.com/svn/trunk@13530 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-21 15:04:07 +00:00
commit-bot@chromium.org
0b45dc45d6
fix the visual difference of raster vs gpu -- inverse_paths
...
If a path has no verbs, it is empty. If a path has verbs, but both the width and height of the bounds are zero. the path is empty too. This situation happens when you add an empty rect or circle... , say a rect{x, y, width, height} = {100, 100, 0, 0}, to a path.
For 8888 config, drawPath() checked the bounds.
For gpu config, it doesn't.
BUG=skia:2176
R=reed@google.com , bsalomon@google.com , schenney@chromium.org
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/166023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13526 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-21 05:42:57 +00:00
commit-bot@chromium.org
4012ba51a2
ARM Skia NEON patches - 20bis - BitmapProcState accurracy
...
Use SkFractionalInt for some calculations to improve accuracy.
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:2175
NOTRY=true
R=djsollen@google.com , mtklein@google.com , hshi@chromium.org
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/167433002
git-svn-id: http://skia.googlecode.com/svn/trunk@13518 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-20 20:13:54 +00:00
senorblanco@chromium.org
897b73f62c
Fix CTM application in SkResizeImagefilter; implement bounds traversals.
...
SkResizeImageFilter resizes all the pixels from its input (subject to
the input's crop rect), but the offset to be applied was incorrect.
It should take the CTM into account, so that the origin of the resize is
the world space origin, unaffected by whatever clipping is applied.
New GM imageresizetiled exercises the behaviour under
impl-side-painting-like conditions, and existing GMs now have resize
cases added.
R=reed@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/168283006
git-svn-id: http://skia.googlecode.com/svn/trunk@13506 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-19 22:10:12 +00:00
commit-bot@chromium.org
c2f7824436
Analytic rrect clip for cicular corners, radius >= 0.5
...
BUG=skia:2181
R=robertphillips@google.com , jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/171413004
git-svn-id: http://skia.googlecode.com/svn/trunk@13498 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-19 15:18:05 +00:00
commit-bot@chromium.org
dcfaa73e68
Allowing Lanczos3 to be used in chromium
...
BUG=skia:
R=senorblanco@google.com , reed@google.com , humper@google.com , senorblanco@chromium.org , robertphillips@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/163663002
git-svn-id: http://skia.googlecode.com/svn/trunk@13459 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-14 18:46:08 +00:00
commit-bot@chromium.org
4a2d9a053a
Rebaselines for https://codereview.chromium.org/156113005/
...
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com , halcanary@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/166403004
git-svn-id: http://skia.googlecode.com/svn/trunk@13451 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-14 14:29:22 +00:00
commit-bot@chromium.org
be233d63ca
ARM Skia NEON patches - 27 - S32A_D565_Blend
...
BlitRow565: new intrinsics version of S32A_D565_Blend
This new version is basically a rewrite of the existing code with
a few speed and accuracy improvements. There is a switch to enable
pixel perfect results at the cost of a (quite big) decrease of
performances (disabled in this patch).
Here are the benchmark results (speedup vs. existing code):
+-------+------------+------------+
| count | Cortex -A9 | Cortex-A15 |
+-------+------------+------------+
| 1 | +103.6% | +12% |
+-------+------------+------------+
| 2 | +3.6% | +21.6% |
+-------+------------+------------+
| 4 | +0.8% | -0.8% |
+-------+------------+------------+
| 8 | +3.9% | -1% |
+-------+------------+------------+
| 16 | +14.7% | +5.7% |
+-------+------------+------------+
| 64 | +18.1% | +13.2% |
+-------+------------+------------+
| 256 | +16.3% | +27.4% |
+-------+------------+------------+
| 1024 | +78.2% | +17.4% |
+-------+------------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com , halcanary@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/156113005
git-svn-id: http://skia.googlecode.com/svn/trunk@13438 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-13 18:37:35 +00:00
bsalomon@google.com
5847b68888
Rebase files after recent GPU clipping changes
...
BUG=skia:2051
Review URL: https://codereview.chromium.org/158443002
git-svn-id: http://skia.googlecode.com/svn/trunk@13377 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-09 04:46:47 +00:00
commit-bot@chromium.org
f053980016
Specialize GrConvexPolyEffect for AA rects, use for AA clip rects.
...
BUG=skia:2051
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/140093004
git-svn-id: http://skia.googlecode.com/svn/trunk@13375 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-08 19:31:05 +00:00
senorblanco@chromium.org
c01eeb30d7
Add new baselines for tests affected by https://code.google.com/p/skia/source/detail?r=13323 , namely:
...
colorfilterimagefilter
dropshadowimagefilter
imageblur
imageblur_large
imagefiltersbase
imagefilterscropped
imagefiltersgraph
imagefiltersscaled
morphology
offsetimagefilter
spritebitmap
xfermodeimagefilter
TBR=fmalita@chromium.org
Review URL: https://codereview.chromium.org/156243003
git-svn-id: http://skia.googlecode.com/svn/trunk@13335 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 01:04:50 +00:00
senorblanco@chromium.org
c4b12f19a4
Implement correct clipping for image filters.
...
Image filters in Skia currently clip the size of the the offscreen
bitmap used for filtering to the device clip bounds. This means that
any pixel-moving filter (e.g., blur) has edge artifacts at the clip
boundaries. This is problematic for tiling, where a single SkPicture
is played back with a clip set to the tile boundaries.
By implementing the onFilterBounds() traversal, and using it in
saveLayer() when a filter is present, we can clip the layer to the
expanded clip rect. Note that this requires that the traversal be
performed in reverse as compared to computeFastBounds(). (It's also
done in device space, unlike computeFastBounds()).
New test imagefiltersclipped tests pixel-moving filters when clipped
by various clip rects.
New test imageblurtiled tests tiled (compositor-style) rendering of
blurred text. There should be no artifacts at the tile boundaries.
BUG=337831
R=reed@google.com
Review URL: https://codereview.chromium.org/23011012
git-svn-id: http://skia.googlecode.com/svn/trunk@13323 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 17:51:22 +00:00
reed@google.com
76f10a3bd9
remove SkCanvas::createCompatibleDevice, and add SkCanvas::newSurface
...
BUG=skia:
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/154163002
git-svn-id: http://skia.googlecode.com/svn/trunk@13319 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 15:32:21 +00:00
commit-bot@chromium.org
65ee5f424c
Use GrConvexPolyEffect when clip is a single convex polygon
...
BUG=skia:2051
Committed: http://code.google.com/p/skia/source/detail?r=13286
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/151523005
git-svn-id: http://skia.googlecode.com/svn/trunk@13306 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-04 17:49:48 +00:00
bsalomon@google.com
d3066bd9b4
Revert of Use GrConvexPolyEffect when clip is a single convex polygon ( https://codereview.chromium.org/151523005/ )
...
Reason for revert:
unit tests crashing on windows?
Original issue's description:
> Use GrConvexPolyEffect when clip is a single convex polygon
>
> BUG=skia:2051
>
> Committed: http://code.google.com/p/skia/source/detail?r=13286
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2051
Review URL: https://codereview.chromium.org/142443006
git-svn-id: http://skia.googlecode.com/svn/trunk@13288 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-03 20:09:56 +00:00
commit-bot@chromium.org
e89d903378
Use GrConvexPolyEffect when clip is a single convex polygon
...
BUG=skia:2051
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/151523005
git-svn-id: http://skia.googlecode.com/svn/trunk@13286 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-03 19:42:42 +00:00
bsalomon@google.com
2739684716
Rebase simpleblurroundrect and bleed GMs after GPU blur radius changes.
...
BUG=skia:1998
Review URL: https://codereview.chromium.org/151503005
git-svn-id: http://skia.googlecode.com/svn/trunk@13263 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-31 15:17:34 +00:00
commit-bot@chromium.org
fd1fdfc3a5
rebaseline GM changes resulting from fast GPU blur algorithm
...
BUG=skia:
R=bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/150493005
git-svn-id: http://skia.googlecode.com/svn/trunk@13243 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 18:17:06 +00:00
commit-bot@chromium.org
cf34bc0634
patch from issue 119343003
...
compile on 10.6, exclude failing gms
Sorry for making another CL; rebasing ToT on the old one ended up with code in a tangled mess; was easier to start over.
NOTRY=true
R=bsalomon@google.com , epoger@google.com , reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/148883005
git-svn-id: http://skia.googlecode.com/svn/trunk@13238 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-30 15:34:43 +00:00
senorblanco@chromium.org
200d75c074
New baselines for displacement GM.
...
This had a new test case added in r12773.
TBR=epoger@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/143263020
git-svn-id: http://skia.googlecode.com/svn/trunk@13231 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 21:41:39 +00:00
senorblanco@chromium.org
7824768e5e
New baselines for GM tests affected by r13221.
...
The following tests were affected:
imagefiltersbase
imagefilterscropped
imagefiltersgraph
imagefiltersscaled
dropshadowimagefilter
offsetimagefilter
spritebitmap
tileimagefilter
TBR=epoger@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/148283008
git-svn-id: http://skia.googlecode.com/svn/trunk@13230 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 20:00:54 +00:00
commit-bot@chromium.org
6df2f2b539
Rebaslines for https://codereview.chromium.org/23835006/
...
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com , mtklein@google.com , reed@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://codereview.chromium.org/137833005
git-svn-id: http://skia.googlecode.com/svn/trunk@13229 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-29 11:48:31 +00:00
senorblanco@chromium.org
78cf11980d
Give correct bounds to SkCanvas's AutoDrawLooper use for filter draws.
...
In conjuction with https://codereview.chromium.org/137423005/ , this allows the canvas to tighten the bounds passed to saveLayer() only the affected region.
R=reed@google.com
BUG=100703
Review URL: https://codereview.chromium.org/141433017
git-svn-id: http://skia.googlecode.com/svn/trunk@13221 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-28 19:22:35 +00:00
commit-bot@chromium.org
a96176dc03
ARM Skia NEON patches - 20 - New improved BitmapProcState code
...
BitmapProcState: new factorised code
This one basically factorises the clamp and repeat transformations with
some performance improvements. It has the benefit of being faster, much
easier to maintain (nearly three times less code for more work
done :-)), and more complete (all persp transformations weren't optimised
in the previous version).
It also introduces the use of can_truncate_to_fixed_for_decal where
useful.
The effect on benchmarks ranges from a 5% penalty to a 25% gain on a
Cortex-A9 and from a 5% penalty to a 100% gain on a Cortex-A15.
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com , mtklein@google.com , luisjoseromeroesclusa@hotmail.com , reed@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://codereview.chromium.org/23835006
git-svn-id: http://skia.googlecode.com/svn/trunk@13218 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-28 15:18:54 +00:00
senorblanco@chromium.org
83c39db913
Remove misc. suppressions from ignored-tests.txt added in https://codereview.chromium.org/105893003 . These tests were rebaselined shortly after that patch landed, but the suppressions weren't removed, so differences have snuck in and not been rebaselined.
...
New Android baselines for imagefiltersgraph, imagefilterscropped, imagefiltersbase, imageblur GMs.
New Nexus4 baselines for testimagefilters, spritebitmap GM.
R=borenet@google.com
TBR=borenet, bungeman
BUG=skia:
Review URL: https://codereview.chromium.org/141033008
git-svn-id: http://skia.googlecode.com/svn/trunk@13191 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-27 15:05:39 +00:00
commit-bot@chromium.org
df79acdbab
Revert of Rebaselining bleed GMs due to recent GPU blur changes. ( https://codereview.chromium.org/138353002/ )
...
Reason for revert:
the bleed_gpu GM is failing on all the test builders.
Original issue's description:
> Rebaselining bleed GMs due to recent GPU blur changes.
>
> BUG=skia:1998
>
> Committed: https://code.google.com/p/skia/source/detail?r=13063
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1998
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/138133003
git-svn-id: http://skia.googlecode.com/svn/trunk@13064 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 16:21:31 +00:00
bsalomon@google.com
3f88f4d5ad
Rebaselining bleed GMs due to recent GPU blur changes.
...
BUG=skia:1998
Review URL: https://codereview.chromium.org/138353002
git-svn-id: http://skia.googlecode.com/svn/trunk@13063 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 15:28:24 +00:00
commit-bot@chromium.org
3e62ebf93b
make ignored-tests.txt specify full test name, not partial name
...
BUG=skia:2022
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/136883006
git-svn-id: http://skia.googlecode.com/svn/trunk@13060 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 02:54:11 +00:00
bsalomon@google.com
cd9175eddb
remove _gpu suffix from tests in ignored-tests.txt that are changed on all gpu configs (msaa, ...).
...
Review URL: https://codereview.chromium.org/136713005
git-svn-id: http://skia.googlecode.com/svn/trunk@13049 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 18:26:14 +00:00
commit-bot@chromium.org
439ff1b9ca
Use correct matrix to adjust blur radius for gpu
...
BUG=skia:1998
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/134973002
git-svn-id: http://skia.googlecode.com/svn/trunk@13047 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 16:39:39 +00:00
bsalomon@google.com
4db7a31678
Remove rects GM from ignored-tests.txt and rebaseline
...
BUG=skia:1882
Review URL: https://codereview.chromium.org/136803002
git-svn-id: http://skia.googlecode.com/svn/trunk@13045 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 15:06:54 +00:00
commit-bot@chromium.org
a7d89c83a4
Handle drawBitmapRect src_rect->dst_rect mapping as a local matrix rather than view matrix when there is a mask filter.
...
BUG=skia:1998
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/131323004
git-svn-id: http://skia.googlecode.com/svn/trunk@13041 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 14:47:00 +00:00
commit-bot@chromium.org
c45ece5f7f
NEON fast path for box blur
...
Calculate 8 channels in parallel by using 16-bits to store each channel. Due to the limitation of VQRDMULH, (int16 * int16 * 2 + 0x8000) >> 16, the fast path can only support kernelSize < 128.
8 significant bits are kept at least in each stage, the final error should less-equal than 1.
Pre-fetching memory for X-direction read. In fact pre-fetching memory doesn't help much for Y direction read, since it is a waste to load a cache line for only read 8 bytes.(I left it there to keep the symmetry. pre-fetch is cheap :) )
bench data on Nexus 10
before:
running bench [640 480] blur_image_filter_large_10.00_10.00 8888: cmsecs = 25081.48
running bench [640 480] blur_image_filter_small_10.00_10.00 8888: cmsecs = 25038.04
running bench [640 480] blur_image_filter_large_1.00_1.00 8888: cmsecs = 25209.04
running bench [640 480] blur_image_filter_small_1.00_1.00 8888: cmsecs = 24928.01
running bench [640 480] blur_image_filter_large_0.00_1.00 8888: cmsecs = 17160.98
running bench [640 480] blur_image_filter_large_0.00_10.00 8888: cmsecs = 17924.11
running bench [640 480] blur_image_filter_large_1.00_0.00 8888: cmsecs = 14609.19
running bench [640 480] blur_image_filter_large_10.00_0.00 8888: cmsecs = 14625.91
after:
running bench [640 480] blur_image_filter_large_10.00_10.00 8888: cmsecs = 14848.42
running bench [640 480] blur_image_filter_small_10.00_10.00 8888: cmsecs = 16037.29
running bench [640 480] blur_image_filter_large_1.00_1.00 8888: cmsecs = 14819.55
running bench [640 480] blur_image_filter_small_1.00_1.00 8888: cmsecs = 14563.69
running bench [640 480] blur_image_filter_large_0.00_1.00 8888: cmsecs = 11905.34
running bench [640 480] blur_image_filter_large_0.00_10.00 8888: cmsecs = 11883.85
running bench [640 480] blur_image_filter_large_1.00_0.00 8888: cmsecs = 9576.51
running bench [640 480] blur_image_filter_large_10.00_0.00 8888: cmsecs = 9793.84
BUG=
R=senorblanco@chromium.org , mtklein@google.com , reed@google.com , kevin.petit@arm.com , kevin.petit.arm@gmail.com
Author: zheng.xu@arm.com
Review URL: https://codereview.chromium.org/105893003
git-svn-id: http://skia.googlecode.com/svn/trunk@13036 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 08:16:45 +00:00
bsalomon@google.com
4fdf25e6cc
rebaseline downsample_text and downsample_checkerboard GMs on gpu configs
...
BUG=skia:1879
Review URL: https://codereview.chromium.org/125463002
git-svn-id: http://skia.googlecode.com/svn/trunk@12930 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 22:31:14 +00:00
bsalomon@google.com
7b22744ff0
Rebaselines for filterbitmap_text GMs
...
BUG=skia:1879
Review URL: https://codereview.chromium.org/109403007
git-svn-id: http://skia.googlecode.com/svn/trunk@12929 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-06 22:00:04 +00:00