mtklein
fe81e2d274
Make SkGraphics::Term a no-op, stop calling it.
...
I'd remove it entirely but Android is calling it explicitly.
BUG=skia:4259
Committed: https://skia.googlesource.com/skia/+/925979f733fe8e70d84627147dee04d030423349
Review URL: https://codereview.chromium.org/1329853005
2015-09-09 07:35:42 -07:00
mtklein
d9b8d7ac1f
Revert of Make SkGraphics::Term a no-op, stop calling it. (patchset #2 id:20001 of https://codereview.chromium.org/1329853005/ )
...
Reason for revert:
SK_ATTR_DEPRECATED is meaningful to Android. Don't use it.
Original issue's description:
> Make SkGraphics::Term a no-op, stop calling it.
>
> I'd remove it entirely but Android is calling it explicitly.
>
> BUG=skia:4259
>
> Committed: https://skia.googlesource.com/skia/+/925979f733fe8e70d84627147dee04d030423349
TBR=reed@google.com ,scroggo@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4259
Review URL: https://codereview.chromium.org/1314483006
2015-09-09 07:22:09 -07:00
mtklein
925979f733
Make SkGraphics::Term a no-op, stop calling it.
...
I'd remove it entirely but Android is calling it explicitly.
BUG=skia:4259
Review URL: https://codereview.chromium.org/1329853005
2015-09-08 15:18:21 -07:00
reed
f4a6d30044
remove duplicated sample (already have a gm)
...
BUG=skia:
Review URL: https://codereview.chromium.org/1317693011
2015-09-04 10:03:22 -07:00
reed
1a9cafff04
add interactive xfer sample
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1323223004
2015-09-02 19:05:10 -07:00
bsalomon
afcd7cd324
Rename flag from "distance field" to "device independent."
...
Review URL: https://codereview.chromium.org/1322433006
2015-08-31 12:39:41 -07:00
hendrikw
885bf09255
skia: add ability to load command_buffer_gles2
...
BUG=skia:
Review URL: https://codereview.chromium.org/1306823003
2015-08-27 10:38:39 -07:00
halcanary
96fcdcc219
Style Change: NULL->nullptr
...
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
2015-08-27 07:41:16 -07:00
halcanary
385fe4d4b6
Style Change: SkNEW->new; SkDELETE->delete
...
DOCS_PREVIEW= https://skia.org/?cl=1316123003
Review URL: https://codereview.chromium.org/1316123003
2015-08-26 13:07:49 -07:00
bungeman
60e0fee6d4
Remove include of stdlib.h from SkTypes.h.
...
Unfortunately, immintrin.h (which is also included by SkTypes)
includes xmmintrin.h which includes mm_malloc.h which includes
stdlib.h for malloc even though, from the implementation, it is
difficult to see why.
Fortunately, arm_neon.h does not seem to be involved in such
shenanigans, so building for Android will keep things sane.
TBR=reed@google.com
Doesn't change Skia API, just moves an include.
Review URL: https://codereview.chromium.org/1313203003
2015-08-26 05:15:46 -07:00
bungeman
99fe822606
Use static_assert instead of SK_COMPILE_ASSERT.
...
Now that static_assert is allowed, there is no need to use a non-
standard compile time assertion
Review URL: https://codereview.chromium.org/1306443004
2015-08-20 07:57:52 -07:00
robertphillips
2f0dbc761a
Update SkLightingShader to support rotation
...
This also:
makes the SkLightingShader handle normal maps where the rects aren't aligned between the diffuse and normal maps.
adds a light aggregating class (Lights) to SkLightingShader (along with a Builder nested class).
Split out of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call)
Committed: https://skia.googlesource.com/skia/+/45b59ed6e4e231814dbdb9f707b3d2a7ee50de84
Review URL: https://codereview.chromium.org/1291783003
2015-08-20 05:15:07 -07:00
robertphillips
f7d602a458
Revert "Update SkLightingShader to support rotation"
...
This reverts commit 45b59ed6e4
.
TBR=herb@google.com
Review URL: https://codereview.chromium.org/1304673002
2015-08-19 13:11:23 -07:00
reed
216b643fc7
private iterator to visit all resource cache entries
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1271033002
2015-08-19 12:25:41 -07:00
robertphillips
45b59ed6e4
Update SkLightingShader to support rotation
...
This also:
makes the SkLightingShader handle normal maps where the rects aren't aligned between the diffuse and normal maps.
adds a light aggregating class (Lights) to SkLightingShader (along with a Builder nested class).
Split out of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call)
Review URL: https://codereview.chromium.org/1291783003
2015-08-19 10:35:14 -07:00
reed
451af5062e
remove SkDeferredCanvas
...
Waiting a day or so to see if the blink-removal of SkDeferredCanvas sticks
BUG=skia:
Review URL: https://codereview.chromium.org/1269093002
2015-08-19 08:18:04 -07:00
reed
8a41adb1d1
support both box and circle lcd
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1292943003
2015-08-15 14:02:29 -07:00
reed
5f629b42e5
show LCD on max fat-zoom
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1295483003
2015-08-15 11:57:23 -07:00
reed
bb886749fe
increase zoom in fatbits
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1300513002
2015-08-15 07:42:31 -07:00
jvanverth
4d0d81aec2
Add high resolution WallTimer to SampleApp
...
Gives better than 1 ms results when timing framerate.
Review URL: https://codereview.chromium.org/1288473002
2015-08-11 11:07:07 -07:00
halcanary
8ee06f21a2
SkPDF: allow PDF module to be disabled in DM and SampleApp
...
To disable PDF:
GYP_DEFINES='skia_pdf=0' bin/sync-and-gyp
ninja -C out/Debug dm SampleApp
When disabled, SkDocument::CreatePDF() always returns NULL.
Review URL: https://codereview.chromium.org/1279123007
2015-08-11 10:30:12 -07:00
reed
e47829b6b1
flag to use const& instead of const* for src-rect
...
BUG=skia:
Review URL: https://codereview.chromium.org/1272713005
2015-08-06 10:02:53 -07:00
reed
2dcc759cd2
use kFast_SrcRectConstraint to match drawAtlas semantics
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1272743003
2015-08-06 06:51:52 -07:00
reed
fd3d87cf67
simulate drawatlas
...
BUG=skia:
Review URL: https://codereview.chromium.org/1279733002
2015-08-06 05:14:11 -07:00
bungeman
d3ebb48320
IWYU: 'core' target, files starting A-C.
...
TBR=reed@google.com
Verbal lgtm, does not change API.
Committed: https://skia.googlesource.com/skia/+/7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69
Review URL: https://codereview.chromium.org/1265033002
2015-08-05 13:57:49 -07:00
reed
093b4e8f51
- allow for stepping through a picture with 'n' and 'p'
...
- save current slide as .skp with 'K'
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1272063002
2015-08-04 18:46:38 -07:00
reed
fb8c1fcab1
Revert of IWYU: 'core' target, files starting A-C. (patchset #5 id:80001 of https://codereview.chromium.org/1265033002/ )
...
Reason for revert:
revert to unblock DEPS roll
../../chrome/browser/chromeos/display/overscan_calibrator.cc:43:10: error: variable has incomplete type 'SkPath'
SkPath base_path;
Original issue's description:
> IWYU: 'core' target, files starting A-C.
>
> TBR=reed@google.com
> Verbal lgtm, does not change API.
>
> Committed: https://skia.googlesource.com/skia/+/7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69
TBR=reed@google.com ,mtklein@google.com,bungeman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1273613002
2015-08-04 18:44:57 -07:00
bungeman
7403d87db8
IWYU: 'core' target, files starting A-C.
...
TBR=reed@google.com
Verbal lgtm, does not change API.
Review URL: https://codereview.chromium.org/1265033002
2015-08-04 14:56:53 -07:00
robertphillips
a9652ac09e
Address some SkLightingShader TODOs
...
This CL:
switches the light colors to be 3 scalars (SkColor3f)
adds some dox
Review URL: https://codereview.chromium.org/1265983003
2015-07-31 05:17:24 -07:00
reed
6b38eabc16
add helper to create RSXform w/ anchorPt
...
BUG=skia:
Review URL: https://codereview.chromium.org/1269563006
2015-07-30 05:46:05 -07:00
robertphillips
640898f588
Update SkLightingShader to take a localMatrix
...
W/o this we can't draw lit objects anywhere but the origin.
Review URL: https://codereview.chromium.org/1253223003
2015-07-30 05:09:17 -07:00
robertphillips
5f865b9cf1
Move LightingShader to effects
...
Additionally this CL:
forces the light colors to be opaque
forces the light direction to be normalized
adds a raster implementation
adds a gm
Review URL: https://codereview.chromium.org/1245883003
2015-07-29 12:28:04 -07:00
joshualitt
b542bae1f5
Rename GrInOrderDrawBuffer to GrBufferedDrawTarget
...
BUG=skia:
Review URL: https://codereview.chromium.org/1261033002
2015-07-28 09:58:39 -07:00
wangyix
7c157a9888
Added GrGLFragmentProcessor::EmitArgs struct for use with emitCode()
...
BUG=skia:
Review URL: https://codereview.chromium.org/1251173002
2015-07-22 15:08:53 -07:00
bungeman
b7069e9c1f
Compile with VS2015.
...
Visual Studio 2015 has additional warnings around noexcept and
disabling exceptions, which can be worked around with the
(undocumented) _HAS_EXCEPTIONS macro.
Visual Studio 2013 and 2015 have roundf in math.h, so use it to
avoid extra work and casts.
We avoid using cmath, as it undefs isfinite on gcc, but Visual Studio
2015 no longer provides overloads of copysign from math.h (which is
actually correct). As a result, use copysignf (which is available in
math.h in 2013 and 2015) directly.
Review URL: https://codereview.chromium.org/1244173005
2015-07-21 14:14:30 -07:00
caryclark
6531c3619f
Generate platform specific fontmgr gm.
...
The gm output on different font platforms is so different
that comparing images in Gold has little value. Separate the
images by appending platform information to the gm name to
group somewhat similar images together.
Note that this does not attempt to make sure that all images
generated by Gold are nearly pixel identical; it only reduces
the number of nonsensical comparisons.
R=bungeman@google.com
Review URL: https://codereview.chromium.org/1245643002
2015-07-20 13:38:56 -07:00
reed
84984efeb6
Revert[2] of guard to remove DrawBitmapRectFlags
...
This reverts commit 91110195a2
.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1240753003
2015-07-17 07:09:43 -07:00
scroggo
91110195a2
Revert of guard to remove DrawBitmapRectFlags (patchset #1 id:1 of https://codereview.chromium.org/1235393003/ )
...
Reason for revert:
breaking android framework build
Original issue's description:
> guard to remove DrawBitmapRectFlags
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/6fb0b6779e40ce05c20cf279f0ecff31fa3cd60d
TBR=fmalita@chromium.org ,djsollen@google.com,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1230823007
2015-07-17 05:57:34 -07:00
reed
6fb0b6779e
guard to remove DrawBitmapRectFlags
...
BUG=skia:
Review URL: https://codereview.chromium.org/1235393003
2015-07-16 06:10:02 -07:00
robertphillips
3d32d768cd
Add new SkPoint3 class
...
The existing Light filter and the upcoming Lighting Shader both need a Point3 class
Review URL: https://codereview.chromium.org/1229693009
2015-07-13 13:16:44 -07:00
mtklein
f059900f75
Fix up -Winconsistent-missing-override
...
(and a couple presubmit fixes)
This allows us to turn back on -Werror for LLVM coverage builds,
and more generally supports building with Clang 3.7.
No public API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1232463006
2015-07-13 06:18:39 -07:00
jvanverth
d17a32966a
Add normal map sample
...
This adds an example of an SkShader that does normal
mapping. It has a single directional light and an
ambient light.
Committed: https://skia.googlesource.com/skia/+/8e0da72ba890de395c9946ec6639c9e1e7b16027
Review URL: https://codereview.chromium.org/1212813009
2015-07-09 09:04:16 -07:00
robertphillips
426388eeb7
Revert of Add normal map sample (patchset #6 id:100001 of https://codereview.chromium.org/1212813009/ )
...
Reason for revert:
Compilation failures:
../../../../../samplecode/SampleLighting.cpp:13:18: fatal error: SkGr.h: No such file or directory
Original issue's description:
> Add normal map sample
>
> This adds an example of an SkShader that does normal
> mapping. It has a single directional light and an
> ambient light.
>
> Committed: https://skia.googlesource.com/skia/+/8e0da72ba890de395c9946ec6639c9e1e7b16027
TBR=reed@google.com ,bsalomon@google.com,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1230603002
2015-07-08 14:46:12 -07:00
jvanverth
8e0da72ba8
Add normal map sample
...
This adds an example of an SkShader that does normal
mapping. It has a single directional light and an
ambient light.
Review URL: https://codereview.chromium.org/1212813009
2015-07-08 14:21:47 -07:00
mtklein
2766c00fc0
remove SkInstCnt
...
It's been outclassed by Valgrind and leak sanitizer,
and it seems to be causing problems for external folks building Skia.
I'm not sure why our own builds seem unaffected.
Latest thread:
https://groups.google.com/forum/#!topic/skia-discuss/oj9FsQwwSF0
BUG=skia:
Review URL: https://codereview.chromium.org/1217573002
2015-06-26 11:45:03 -07:00
reed
ca10953d9c
implement drawAtlas natively on gpu-device
...
BUG=skia:
Review URL: https://codereview.chromium.org/1216433002
2015-06-25 16:25:25 -07:00
reed
71c3c760a8
add SkCanvas::drawAtlas
...
BUG=skia:
Review URL: https://codereview.chromium.org/1181913003
2015-06-24 10:29:18 -07:00
mtklein
00b621cfc0
Add sk_parallel_for()
...
This should be a drop-in replacement for most for-loops to make them run in parallel:
for (int i = 0; i < N; i++) { code... }
~~~>
sk_parallel_for(N, [&](int i) { code... });
This is just syntax sugar over SkTaskGroup to make this use case really easy to write.
There's no more overhead that we weren't already forced to add using an interface like batch(),
and no extra heap allocations.
I've replaced 3 uses of SkTaskGroup with sk_parallel_for:
1) My unit tests for SkOnce.
2) Cary's path fuzzer.
3) SkMultiPictureDraw.
Performance should be the same. Please compare left and right for readability. :)
BUG=skia:
No public API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1184373003
2015-06-17 15:26:15 -07:00
fmalita
822ace9001
Use SkPaintFilterCanvas for SampleApp paint filtering
...
(one less SkDrawFilter user)
BUG=skia:3587
R=robertphillips@google.com ,reed@google.com
Review URL: https://codereview.chromium.org/1177323002
2015-06-15 07:07:32 -07:00
vbuzinov
dded69693d
Implement support for mixed sampled render targets
...
Adds a new FBO type kStencil_MSFBOType that is selected whenever
NV_framebuffer_mixed_samples extension is available. In this new
FBO type a non-msaa color buffer is created with a multisampled
stencil buffer attachment.
Replaces numSamples() with separate numColorSamples and numStencilSamples
methods in RenderTarget.
In mixed samples mode non-MSAA codepaths are used to draw simple shapes,
while NVPR-rendered paths and text are rendered with a multisampled
stencil.
BUG=skia:3177
Review URL: https://codereview.chromium.org/1001503002
2015-06-12 08:59:45 -07:00
reed
56263c78d8
delete (unused) TransparentShader
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1153193014
2015-06-05 11:31:26 -07:00
caryclark
a76b7a3b04
remove SK_LEGACY_STROKE_CURVES
...
The change in Chrome has been landed so this guard is no longer needed.
R=reed@google.com ,fmalita@chromium.org
BUG=102411
Review URL: https://codereview.chromium.org/1157623003
2015-05-22 06:26:52 -07:00
caryclark
612f70d5fa
handle large conic strokes better
...
A stroked conic computes the outset quad's control point by
computing the intersection of the quad's endpoints. If the
the denominator used to compute the scale factor for the
control point is small, check to see if the numerator is also
small so that the division stays bounded.
Also clean up error returns and internal function calls to
simplify the code.
Additionally, remove comic max curvature (unimplemented) and call
extrema functions instead to handle cases where the conic is degenerate
or is a line.
R=reed@google.com , fmalita@chromium.org
BUG=skia:3843
Review URL: https://codereview.chromium.org/1144883003
2015-05-19 11:05:37 -07:00
reed
80ea19ca4b
Revert of Revert of stop calling SkScalarDiv (patchset #1 id:1 of https://codereview.chromium.org/1138263002/ )
...
Reason for revert:
android patched, blink has rolled
Original issue's description:
> Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/ )
>
> Reason for revert:
> need to wait for Blink roll (and patch android)
>
> Original issue's description:
> > stop calling SkScalarDiv
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a
>
> TBR=
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2629697933b5cc975e45d2a45c48f803fc6cbcec
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1135693003
2015-05-12 10:37:34 -07:00
reed
2629697933
Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/ )
...
Reason for revert:
need to wait for Blink roll (and patch android)
Original issue's description:
> stop calling SkScalarDiv
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1138263002
2015-05-12 10:28:06 -07:00
reed
67d71c8982
stop calling SkScalarDiv
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1135053002
2015-05-12 09:47:22 -07:00
reed
beedb81a7f
add DeferredCanvas mode to SampleApp
...
BUG=skia:
Review URL: https://codereview.chromium.org/1129603002
2015-05-05 12:14:45 -07:00
reed
71a6cbfc58
remove redundant/deprecated TwoPointRadial gradiet -- use TwoPointConical
...
This CL derived from https://codereview.chromium.org/1114243005/
BUG=skia:
Review URL: https://codereview.chromium.org/1117423003
2015-05-04 08:32:51 -07:00
reed
ca1a22ee53
Revert of Revert of remove unused (by clients) SkPathUtils (patchset #1 id:1 of https://codereview.chromium.org/1060703003/ )
...
Reason for revert:
fix (removal from gypi/gn files) has landed in chrome.
Original issue's description:
> Revert of remove unused (by clients) SkPathUtils (patchset #1 id:1 of https://codereview.chromium.org/1088383003/ )
>
> Reason for revert:
> This change is causing the DEPS roll to fail:
>
>
> http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/78771/steps/gn/logs/stdio
>
> Original issue's description:
> > remove unused (by clients) SkPathUtils
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/aab35d91b8b80acd1902594bbf542083fdfa4bb7
>
> TBR=scroggo@google.com ,reed@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/bdb0bf5f8858043878d8a4fa8130c6c87bef3fd4
TBR=scroggo@google.com ,jcgregorio@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1091963002
2015-04-16 20:10:55 -07:00
jcgregorio
bdb0bf5f88
Revert of remove unused (by clients) SkPathUtils (patchset #1 id:1 of https://codereview.chromium.org/1088383003/ )
...
Reason for revert:
This change is causing the DEPS roll to fail:
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/78771/steps/gn/logs/stdio
Original issue's description:
> remove unused (by clients) SkPathUtils
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/aab35d91b8b80acd1902594bbf542083fdfa4bb7
TBR=scroggo@google.com ,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1060703003
2015-04-16 09:47:36 -07:00
reed
aab35d91b8
remove unused (by clients) SkPathUtils
...
BUG=skia:
Review URL: https://codereview.chromium.org/1088383003
2015-04-16 06:16:38 -07:00
mtklein
36352bf5e3
C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}
...
NOPRESUBMIT=true
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002
Review URL: https://codereview.chromium.org/1037793002
2015-03-25 18:17:32 -07:00
senorblanco
8c874eee94
Move SkMatrixImageFilter into core, and add a factory fn for it.
...
BUG=skia:
Review URL: https://codereview.chromium.org/1011273003
2015-03-20 06:38:17 -07:00
senorblanco
24e06d5244
Remove uniqueID from all filter serialization.
...
(This is essentially a revert of https://codereview.chromium.org/503833002/ .)
This was necessary back when SkPaint was flattened even for in-process use. Now that we only flatten SkPaint for cross-process use, there's no need to serialize UniqueIDs.
Note: SkDropShadowImageFilter is being constructed with a croprect and UniqueID (of 0) in Blink. I've made the uniqueID param default to 0 temporarily, until this rolls in and Blink can be changed. (Blink can't be changed first, since unlike the other filters, there's no constructor that takes a cropRect but not a uniqueID.)
BUG=skia:
Review URL: https://codereview.chromium.org/1019493002
2015-03-18 12:11:33 -07:00
reed
93a1215fe0
SkPaint::FilterLevel -> SkFilterQuality
...
clone (+rebase) of https://codereview.chromium.org/1009183002/
BUG=skia:
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/1014533004
2015-03-16 10:08:34 -07:00
caryclark
94b4ee85f2
(starting with mtklein's 966503002 mod to 963593003)
...
fix casts
Committed: https://skia.googlesource.com/skia/+/9e73a84deb5e6c201081b1d30175863898543e8d
Review URL: https://codereview.chromium.org/979453004
2015-03-04 12:32:22 -08:00
mtklein
a84cff9b99
Revert of fix casts (patchset #1 id:1 of https://codereview.chromium.org/979453004/ )
...
Reason for revert:
64-bit windows build warnings-as-errors
Original issue's description:
> (starting with mtklein's 966503002 mod to 963593003)
> fix casts
>
> Committed: https://skia.googlesource.com/skia/+/9e73a84deb5e6c201081b1d30175863898543e8d
TBR=caryclark@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/977583007
2015-03-04 11:46:27 -08:00
caryclark
9e73a84deb
(starting with mtklein's 966503002 mod to 963593003)
...
fix casts
Review URL: https://codereview.chromium.org/979453004
2015-03-04 11:22:05 -08:00
caryclark
63c684a8a6
fuzzer fixes
...
Fix path bugs exposed by the path fuzzer.
Changes to existing gm and samplecode files defer their calls to construct
SkPath objects until the first draw instead of at test initialization.
Add an experimental call to SkPath to validate the internal SkPathRef.
Fix SkPath::addPoly to set the last moveto after adding a close verb.
Fix stroke to handle failures when computing the unit normal.
Add a unit test for the unit normal failure.
R=reed@google.com
Review URL: https://codereview.chromium.org/953383002
2015-02-25 09:04:04 -08:00
caryclark
1297ecfd1d
flip stroke to chrome compatible define
...
Review URL: https://codereview.chromium.org/932723003
2015-02-24 06:02:06 -08:00
reed
0ab326f530
move GMSampleView into its own cpp
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/947733002
2015-02-21 09:36:50 -08:00
reed
f7f79d2a6e
remove dead code from sampleapp, trim bad asserts
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/948693002
2015-02-21 09:03:21 -08:00
caryclark
04e4d08556
This uses quad approximations of the outer and inner paths describing a stroke. Cubics and conics' thick strokes are approximated with quads as well.
...
The approximation uses a similar error term as the fill scan converter to determine the number of quads to use.
This also updates SampleApp QuadStroker test with conics, ovals, and stroked text.
Review URL: https://codereview.chromium.org/932113002
2015-02-20 06:33:57 -08:00
joshualitt
25d9c15408
Pass Rendertarget into context.
...
Adding Jim for text context stuff, and Steven for image blur stuff.
BUG=skia:
Review URL: https://codereview.chromium.org/939623005
2015-02-18 12:29:52 -08:00
caryclark
88c748aeea
update sampleapp for stroking experiment
...
Add RotateCircles3 back as better-named QuadStroker.
Switch pathfill test to call skia before draw instead of in
initializer to avoid triggering debugging breakpoints.
Review URL: https://codereview.chromium.org/912273003
2015-02-18 10:56:00 -08:00
reed
9e447c08de
remove unneeded preroll
...
BUG=skia:
TBR=robertphilips
Review URL: https://codereview.chromium.org/927443006
2015-02-15 11:08:40 -08:00
bsalomon
bb0502eec5
Support multiple null GL contexts on a thread.
...
This has the side effect of requiring SkNullGLContext to use the null GL interface.
It exposes SkNullGLContext and also removes null context support from SampleApp.
Review URL: https://codereview.chromium.org/916733002
2015-02-11 11:11:11 -08:00
reed
61adb1b649
more gms for conics
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/869843006
2015-02-09 13:01:05 -08:00
robertphillips
c89f6fb29c
Salvage the SampleApp portion of the ill-fated "nudge" CL
...
Trying a different approach than nudging but this will still be useful.
Review URL: https://codereview.chromium.org/907453004
2015-02-09 07:47:17 -08:00
reed
3cb3840c9a
Rename SkCanvasDrawable to SkDrawable, and make public
...
(patchset #2 id:20001 of https://codereview.chromium.org/903993002/ )"
This reverts commit c4e8772492
.
BUG=skia:
TBR=
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/898343004
2015-02-06 08:36:15 -08:00
reed
c4e8772492
Revert of rename SkCanvasDrawable to SkDrawable, and make public (patchset #2 id:20001 of https://codereview.chromium.org/903993002/ )
...
Reason for revert:
bug in gyp
Original issue's description:
> rename SkCanvasDrawable to SkDrawable, and make public
>
> BUG=skia:
> NOTRY=True
> ... winbuilder flake
>
> Committed: https://skia.googlesource.com/skia/+/4ae9eb7463cf2160723407359608f221c0d5e2a6
TBR=robertphillips@google.com ,djsollen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/882853006
2015-02-06 08:20:07 -08:00
reed
4ae9eb7463
rename SkCanvasDrawable to SkDrawable, and make public
...
BUG=skia:
NOTRY=True
... winbuilder flake
Review URL: https://codereview.chromium.org/903993002
2015-02-06 08:02:57 -08:00
reed
339cdbfb75
migrate more samples over to SkAnimTImer
...
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/901933004
2015-02-05 22:02:37 -08:00
reed
bf015c34e4
add textual overview
...
BUG=skia:
Review URL: https://codereview.chromium.org/898573002
2015-02-03 15:02:24 -08:00
reed
76113a9b77
add SkAnimTimer, SPACE = pause/resume, ESP = stop
...
BUG=skia:
Review URL: https://codereview.chromium.org/894083003
2015-02-02 12:55:02 -08:00
reed
d9adfe6a22
allow GMs to animate
...
BUG=skia:
Review URL: https://codereview.chromium.org/888283002
2015-02-01 19:01:04 -08:00
robertphillips
7f14c9bbf1
Revert of Add device space "nudge" to gpu draws (patchset #6 id:90001 of https://codereview.chromium.org/877473005/ )
...
Reason for revert:
Blink layout tests this time :(
Original issue's description:
> Add device space "nudge" to gpu draws
>
> This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
>
> BUG=423834
>
> Committed: https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78
>
> Committed: https://skia.googlesource.com/skia/+/b9329991426d0b77ea194a380d72d73fb855308a
TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=423834
Review URL: https://codereview.chromium.org/886153002
2015-01-30 14:44:22 -08:00
scroggo
e7ea40f4e0
Reland "remove unused SkAvoidXfermode"
...
(patchset #2 id:20001 of https://codereview.chromium.org/860583002/ )
SkAvoidXfermode has been moved into Android, so it is safe to remove.
Review URL: https://codereview.chromium.org/890893003
2015-01-30 13:16:02 -08:00
caryclark
c8fcafb3f0
First cut at cleaning up Sergio's example code and moving some common code to SkWindow.
...
Eventually, this will be moved to be a peer of SampleApp so it is compiled by the bots to avoid future bit rot.
Also ignore XCode auto-generated flag in CommandLineFlags, and remove the unused multiple-example part.
Review URL: https://codereview.chromium.org/890873003
2015-01-30 12:37:02 -08:00
robertphillips
b932999142
Add device space "nudge" to gpu draws
...
This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
BUG=423834
Committed: https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78
Review URL: https://codereview.chromium.org/877473005
2015-01-30 11:24:50 -08:00
humper
f75a130c45
enable subpixel text on the subpixel translate sample
...
BUG=skia:
Review URL: https://codereview.chromium.org/885783006
2015-01-29 10:26:37 -08:00
robertphillips
9cc2f2613a
Revert of Add device space "nudge" to gpu draws (patchset #5 id:70001 of https://codereview.chromium.org/877473005/ )
...
Reason for revert:
Chrome pixel test :(
Original issue's description:
> Add device space "nudge" to gpu draws
>
> This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
>
> BUG=423834
>
> Committed: https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78
TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=423834
Review URL: https://codereview.chromium.org/890433003
2015-01-28 17:37:33 -08:00
robertphillips
2d55d07501
Add device space "nudge" to gpu draws
...
This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
BUG=423834
Review URL: https://codereview.chromium.org/877473005
2015-01-28 14:41:57 -08:00
reed
40dab98de1
Use murmur3 finisher to improve font hash efficiency.
...
Add dump() method to inspect glyphcache strikes.
Murmur addition improves hash efficient roughly 50%
BUG=skia:
Review URL: https://codereview.chromium.org/877113002
2015-01-28 13:28:53 -08:00
robertphillips
7defaa6c4a
Add ClipDrawMatch SampleApp slide
...
This slide can be used to find and diagnose discrepancies between BW clipping and drawing.
BUG=skia:423834
Review URL: https://codereview.chromium.org/872363003
2015-01-27 06:17:22 -08:00
halcanary
b0cce2c1d3
s/sk_tools::DrawCheckerboard/sk_tool_utils::draw_checkerboard/
...
BUG=skia:
Review URL: https://codereview.chromium.org/873333004
2015-01-26 12:49:00 -08:00
halcanary
878fa0204b
Factor out checkerboard function in gm and sampleapp into tools.
...
Review URL: https://codereview.chromium.org/834303005
2015-01-26 11:24:32 -08:00
robertphillips
42dbfa8651
Add patheffects to debugger printout
...
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/872043002
2015-01-26 06:08:52 -08:00
reed
96a857ef5a
initial preroll api
...
BUG=skia:
Review URL: https://codereview.chromium.org/855473002
2015-01-25 10:33:58 -08:00
fmalita
7a2c8f3f28
Fix SampleApp picture-mode transform.
...
The multi-picture-draw path should not ignore the inherited transform.
R=reed@google.com ,robertphillips@google.com
Review URL: https://codereview.chromium.org/867303002
2015-01-23 10:03:15 -08:00