Matthias Clasen
dff2aa20ff
gl: Fixed clipped offscreen rendering
...
When we are rendering a texture node to an offscreen,
and we have a clip, we must force the offscreen rendering.
Otherwise, the code will notice: Hey, it already is a texture
node, so no need to render it to a texture again. But when
clipping is involved, that is exactly what we want to do.
Testcase included.
Fixes : #3651
2021-02-09 22:43:15 -05:00
Timm Bäder
79f273348d
gl renderer: Fix viewport computation when rendering offscreen
...
Fixes #3615
2021-01-29 10:37:48 +01:00
Timm Bäder
8ebcef97ff
shader builder: Improve error output
2021-01-29 09:45:25 +01:00
Matthias Clasen
0d0bdaa02e
gsk: Fix a thinko
...
With subpixel positioning, we need to offset the
cached glyphs by their phase.
2021-01-28 18:16:16 -05:00
Fabio Lagalla
d83502d054
gskglshaderbuilder: bind correct uv location
2021-01-28 17:08:46 +01:00
Fabio Lagalla
a1dd6521e8
gskglrenderer: Remove switch fallthrough comments
2021-01-27 12:52:11 +01:00
Fabio Lagalla
0088f840fe
gskrendernode: Cache angle in conic gradients
2021-01-27 12:44:10 +01:00
Fabio Lagalla
1b698c896e
gskglrenderer: Use gboolean instead of bool
2021-01-27 12:44:10 +01:00
Fabio Lagalla
04000f28e7
gskglrenderer: First class support of repeating-radial-gradient
2021-01-27 12:44:10 +01:00
Fabio Lagalla
976a05f6eb
gskglrenderer: First class support of repeating-linear-gradient
2021-01-27 12:44:10 +01:00
Fabio Lagalla
b15902bf44
gskglrenderer: Optimize conic-gradient shader
2021-01-27 12:44:10 +01:00
Fabio Lagalla
5ac7529771
gskglrenderer: Optimize radial-gradient shader
2021-01-27 12:44:10 +01:00
Fabio Lagalla
bbf68c0d9d
gskglrenderer: Optimize linear-gradient shader
2021-01-27 12:44:10 +01:00
Timm Bäder
d9f6b268d3
gl renderer: Use rect_contains_rect() copy
...
And this way the contains_rect() inside
rounded_inner_rect_contains_rect() goes from 3.3% to 0.79% in the
fishbowl when rendering the levelbars.
2021-01-17 04:39:26 +01:00
Timm Bäder
4d7a01562e
gl renderer: Don't reset offset when drawing offscreen
2021-01-17 04:39:26 +01:00
Timm Bäder
650eed7f72
gl renderer: Properly y-flip non-offscreen children of rounded clips
2021-01-17 04:39:26 +01:00
Fabio Lagalla
8c61038b9f
gl renderer: print fragment shader info
...
It was logged twice the vertex shader info, instead
2021-01-11 17:06:03 +01:00
xndcn
34ffdc6e3f
gl: Fix implicit leaking of shader object
...
According to OpenGL spec, a shader object will only be flagged
for deletion unless it has been detached; when a program object
is deleted, those shader objects attached to it will be detached
but not deleted unless they have already been flagged for deletion.
So we shall detach a shader object before it is deleted, and delete
it before the program object is deleted best.
2020-12-29 23:50:45 +08:00
Timm Bäder
526c76181e
gl renderer: Check for pointer equality in rounded_rect_equal
2020-12-21 15:22:08 +01:00
Timm Bäder
e1cf0cff26
gl renderer: Proper state tracking for color matrix ops
2020-12-21 10:26:03 +01:00
Timm Bäder
634fa772c9
gl renderer: Add missing debug output for repeat ops
2020-12-21 10:26:03 +01:00
Timm Bäder
4b3bbe0ecd
gl renderer: Create shader-global uniform ops on draw()
...
This way we can render the first frame of tests/testoutsetshadowdrawing
in 153 ops instead of 183.
And the first frame of gtk4-demo in 260 instead of 300.
2020-12-21 10:26:03 +01:00
Timm Bäder
cde43541d0
gl renderer: Unify new clip/viewport rects in blur_texture()
2020-12-21 10:26:03 +01:00
Timm Bäder
a8213d7f45
gl renderer: Avoid setting modelview to identical values
...
The previous comment here was incorrect. We can save the op itself, we
just can't save us the entry in the modelview stack.
2020-12-21 10:26:02 +01:00
Matthias Clasen
d5143a1bf0
Revert "gl renderer: Render too big textures to the clipped area"
...
This reverts commit 7f6608cbed
.
2020-12-19 11:43:56 -05:00
Matthias Clasen
12611fa142
Revert "gl renderer: Take a out graphene_rect in blur_node()"
...
This reverts commit 7eece7e769
.
2020-12-19 11:43:43 -05:00
Timm Bäder
7eece7e769
gl renderer: Take a out graphene_rect in blur_node()
2020-12-16 09:13:12 +01:00
Timm Bäder
7f6608cbed
gl renderer: Render too big textures to the clipped area
2020-12-16 08:26:46 +01:00
Timm Bäder
f816a8fb82
gl renderer: Unify viewport setting in add_offscreen_ops()
...
We use the same rect here a few times.
2020-12-16 08:26:46 +01:00
Timm Bäder
33ed42d985
gl renderer: Remove RESET_OPACITY flag
...
We always need to do that (and always passed the flag to
add_offscreen_ops() anyway).
2020-12-06 20:03:35 +01:00
Timm Bäder
1ee4f6138b
gl renderer: Reset opacity when rendering blend node children
...
We render those on a texture, so we need to reset the opacity because
that will be applied when rendering the resulting texture.
2020-12-06 20:01:36 +01:00
Timm Bäder
7b61ef9e0f
gl renderer: Initialize rounded rect early
2020-12-06 19:57:48 +01:00
Timm Bäder
b46d077b3a
gl renderer: Fix rendering clipped blurred inset shadow nodes
2020-12-06 19:18:10 +01:00
Timm Bäder
e32331d002
gl renderer: Ignore crossfades between equal texture nodes
2020-12-06 19:18:10 +01:00
Timm Bäder
05928608ec
gl renderer: Use scale_x and scale_y everywhere
...
Try to handle two different values for scale in horizontal and vertical
direction better.
Fixes #3431
2020-12-06 19:18:05 +01:00
Christian Hergert
6883c2214b
gl: specify attribute locations for vUv and aPosition
...
These positions are not guaranteed to be in a specific order when linked
into the final GPU program. They need to be specified so that our code
in gskglrenderer.c can use known positions for them to match up with
our GskQuadVertex.
This fixes the GL renderer on macOS's OpenGL shader compiler.
Fixes #3420
2020-12-04 13:33:34 -08:00
Benjamin Otte
2c1bd399d2
glrenderer: Implement a shader for conic gradients
2020-12-03 13:07:17 +01:00
Benjamin Otte
c907ad83b0
glrenderer: Emit more useful error messages
...
Catch the error when it happens, so that we can emit a specific and more
helpful error message.
Also verify that all branches in the code now do indeed set a proper
GError when they fail, so that the final catch-all is no longer needed.
Instead, assert that the error is set so that we catch future code
additions early that do not set the GError.
2020-12-03 13:07:17 +01:00
Benjamin Otte
55a242bd81
gsk: Add GskConicGradientNode
2020-12-03 00:47:54 +01:00
Timm Bäder
da514187f5
gl renderer: Make minimal rounded rects more minimal
2020-11-30 09:21:34 -05:00
Christian Hergert
82b4c34eca
gl: add some debugging information to DEBUG_OPS
2020-11-18 20:16:40 -08:00
Christian Hergert
eae5eaeb21
gl: use glFramebufferTexture2D to set framebuffer texture
...
When mapping a texture to the framebuffer, we can use the 2D
form instead of the cube mapping form.
2020-11-18 20:09:01 -08:00
Benjamin Otte
1c7daece7a
Merge branch 'wip/otte/for-master' into 'master'
...
Wip/otte/for master
See merge request GNOME/gtk!2855
2020-11-17 19:08:01 +00:00
Benjamin Otte
f2284ff40f
rendernode: Rename all gsk_render_node_peek_*() functions
...
Those are getters, they should be gsk_render_node_get_*() functions.
2020-11-17 19:04:39 +01:00
Christian Hergert
12a9164414
gsk: use glFrameBufferTexture2D and release texture
...
glFrameBufferTexture maps to all faces of a cube and that is not needed
here. Additionally, texture_id is not deleted after we use the additional
flipped texture, but should be.
2020-11-16 09:26:07 -08:00
Emmanuel Gil Peyrot
08193ecf1c
gl renderer: Generate queries only on desktop GL
...
On desktop GL, GL 1.5 or GL_ARB_occlusion_query is required to get the
glGenQueries() etc. symbols. This isn’t the case on GLES, where they
are provided by GL_EXT_occlusion_query_boolean, and more importantly
have never been made core.
This patch allows gtk4-demo to start when GDK_DEBUG=gl-gles is set, on
my Mali 400 MP running the Lima driver from Mesa.
2020-11-07 21:49:42 +01:00
Timm Bäder
82ca65956f
gl renderer: Make debugging code shorter
2020-11-02 14:55:14 -05:00
Timm Bäder
c8c2106f3e
gl renderer: Refactor vertex data loading code
2020-11-02 14:55:14 -05:00
Timm Bäder
8178dfb85a
gl renderer: Use the load_vertex_data* functions more often
2020-11-02 14:55:14 -05:00
Timm Bäder
50e78198a8
gl renderer: More load_vertex_data* usage
2020-11-02 14:55:14 -05:00