Commit Graph

1153 Commits

Author SHA1 Message Date
robertphillips
2e5a986bc7 New baselines
New baseline images for multipicturedraw_biglayer* GMs added in (Add a MultiPictureDraw GM to exercise layer clipping - https://codereview.chromium.org/617723004/).

NOTRY=true
TBR=reed@google.com

Review URL: https://codereview.chromium.org/629293002
2014-10-06 10:57:14 -07:00
jvanverth
5d271f1581 Update fontcache expectations
TBR=reed@google.com

Review URL: https://codereview.chromium.org/634623002
2014-10-06 10:47:59 -07:00
jvanverth
fa38a30897 Add GrAASmallPathRenderer.
Uses cached signed distance fields to render scaled and rotated versions
of small paths.

BUG=skia:2935

Review URL: https://codereview.chromium.org/589103004
2014-10-06 05:59:05 -07:00
robertphillips
4611e7f479 Don't turn on dither for saveLayers which have no paint
Only the gpu, 565 and msaa configs of GMs in ignored-tests.txt need rebaselining.

NOTRY=true

Review URL: https://codereview.chromium.org/619363002
2014-10-03 06:53:04 -07:00
fmalita
08bd03bc17 Add blobshader GM baselines.
TBR=robertphillips@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/616853003
2014-10-02 05:00:29 -07:00
reed
5817f21e0b remove suppression for gm
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/617193003
2014-10-01 12:53:53 -07:00
reed
8324a6a27e add baseline for clip_strokerect
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/618373002
2014-10-01 12:41:13 -07:00
reed
39f31c6ed0 baseline new GMs
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/623443004
2014-10-01 12:18:40 -07:00
robertphillips
6589dec11e Rebaseline Unknown-Arm64 GM flakes
These inconsequential changes appeared after (GrResourceCache2 manages scratch texture - https://codereview.chromium.org/608883003) but persisted even after that CL was reverted.

TBR=bsalomon@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/617103005
2014-10-01 09:47:11 -07:00
fmalita
dbcb5ff125 Add pdf-native textblobshader GM baseline
BUG=skia:2983
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/615853004
2014-10-01 09:19:05 -07:00
robertphillips
92656eaaa8 Add buggy GPU baselines for MultiPictureDraw Sierpinski GM (with bug label)
I am checking in these baseline images even though they are afflicted by a bug (skia:2979).

NOTRY=true
NOTREECHECKS=true
BUG=skia:2979
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/619873003
2014-10-01 08:04:29 -07:00
Justin Novosad
e946f7115c New baselines for image=surface gm
TBR=robertphillips@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/623473002
2014-10-01 10:29:16 -04:00
robertphillips
24e430ff32 Add 8888 & 565 baselines for multipicturedraw Sierpinski GM
TBR=jvanverth@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/614353002
2014-10-01 05:33:25 -07:00
robertphillips
dbe6074a06 Revert of GrResourceCache2 manages scratch texture. (patchset #14 id:260001 of https://codereview.chromium.org/608883003/)
Reason for revert:
Turning bots red:
Nanobench seems to be uniformly failing on Android
(http://108.170.220.21:10117/builders/Perf-Android-Venue8-PowerVR-x86-Release/builds/99/steps/RunNanobench/logs/stdio)

Ubuntu GTX660 32bit is failing in both Debug and Release on GM generation (it appears to be out of memory) (http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/builds/2457/steps/GenerateGMs/logs/stdio)

Original issue's description:
> GrResourceCache2 manages scratch texture.
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3d398c876440deaab39bbf2a9b881c337e6dc8d4

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/611383003
2014-09-30 06:54:17 -07:00
bsalomon
3d398c8764 GrResourceCache2 manages scratch texture.
BUG=skia:
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/608883003
2014-09-30 06:02:23 -07:00
robertphillips
92f7fc4868 Rebaselining Win7 image failures (textblob, verttext2)
Rebaselining these for now and see if they recur.

R=borenet@google.com
TBR=borenet@google.com

BUG=skia:2956

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/600533003
2014-09-29 11:17:58 -07:00
Justin Novosad
cce6bbf494 Adding test suppression for image-surface GM
Test needs to be rebaselined on gpu

TBR=bsalomon

Review URL: https://codereview.chromium.org/602203006
2014-09-26 17:41:28 -04:00
cdalton
9959c21dc7 Rebaseline gm expectations after nvpr text change
BUG=skia:2951
BUG=skia:2954
R=bsalomon@google.com, borenet@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/580943003
2014-09-22 12:26:41 -07:00
jvanverth
f782639a7c Add ignored expectation for https://codereview.chromium.org/563283004.
BUG=skia:2951
R=bsalomon@google.com
TBR=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/585943002
2014-09-19 06:46:09 -07:00
cdalton
855d83ff79 Uses a single pre-baked set of paths for drawing nvpr text of a given
typeface. Loads the paths using the driver's glyph loading routines.

Refactors GrPathRange to accept a PathGenerator class that it uses to
lazily initialize its paths. The client code is no longer expected to
initialize the paths in a GrPathRange; instead it must provide a
PathGenerator* instance to createPathRange().

Adds a new createGlyphs() method to GrPathRendering that creates a
range of glyph paths, indexed by glyph id. GrPathRendering implements
createGlyphs() with a PathGenerator that loads glyph paths using the
skia frameworks. GrGLPathRendering uses glMemoryGlyphIndexArrayNV()
instead, when possible, to load the glyph paths.

Removes all GlyphPathRange logic from GrStencilAndCoverTextContext.
It instead uses createGlyphs().

BUG=skia:2939
R=bsalomon@google.com, jvanverth@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/563283004
2014-09-18 13:51:53 -07:00
Florin Malita
8bb9e1e412 Rebaseline textblob GM after acb882c
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/575893003
2014-09-17 10:21:48 -04:00
fmalita
acb882c239 Ensure blob typeface information survives SkGPipe serialization.
When flattening text blobs to the temp buffer, we need to collect
typeface info and ship it across the pipe explicitly.

R=mtklein@google.com, reed@google.com, robertphillips@google.com, bungeman@google.com
BUG=412445

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/563783003
2014-09-16 17:58:34 -07:00
Mike Klein
a63d5df455 Rebaseline hittestpath and ignore flaky failure on TARUAD
BUG=skia:2937

Review URL: https://codereview.chromium.org/571963002
2014-09-15 10:56:59 -04:00
rileya
abaef86f2b Add support for the Rec601 YUV color space to GrYUVtoRGBEffect.
R=bsalomon@google.com, senorblanco@chromium.org, sugoi@chromium.org, reed@google.com

Author: rileya@chromium.org

Review URL: https://codereview.chromium.org/516463005
2014-09-12 17:45:58 -07:00
Mike Klein
d0af38793e Expectation file update for bot changes.
BUG=skia:

Review URL: https://codereview.chromium.org/560873002
2014-09-10 11:10:48 -04:00
reed
9728a2bf56 correct prev suppression
TBR=
NOTRY=True

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/543903005
2014-09-09 19:22:37 -07:00
reed
9a6300a2b0 suppress multipicturedraw_pathclip_tiled_nvprmsaa4 after the conservative-rasterclip cl
TBR=
NOTRY=True

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/555403002
2014-09-09 19:08:28 -07:00
bungeman
87a79236f5 Rebaselines for 6bc2c94de3 (fontmgr_iter).
Rebaselines for "Add font fallback support to SkFontMgr_fontconfig."
2014-09-09 21:38:04 -04:00
Mike Klein
be20c5a118 rebase a couple oddballs
BUG=skia:

Review URL: https://codereview.chromium.org/555193004
2014-09-09 17:52:40 -04:00
Mike Klein
ef53f158de Rebase intel rhb gpu GMs.
Looks like I accidentally re-enabled GPU mode in GM for Intel RHB.
Rebaseline it so it's green today before we turn it off tomorrow.

BUG=skia:

Review URL: https://codereview.chromium.org/552413002
2014-09-09 16:00:58 -04:00
bungeman
6bc2c94de3 Add font fallback support to SkFontMgr_fontconfig.
R=mtklein@google.com, djsollen@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/489733005
2014-09-09 12:50:36 -07:00
joshualitt
52354b6df7 Updating expectations
TBR=
BUG=skia:

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/543813003
2014-09-04 13:52:34 -07:00
joshualitt
bd769d0f1c Initial change to create GeometryProcessor
BUG=skia:
R=bsalomon@google.com, robertphillips@google.com, egdaniel@google.com, jvanverth@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/509153002
2014-09-04 08:56:46 -07:00
Mike Klein
227c54e3d4 Finish off some lingering rebaselines.
BUG=skia:

Review URL: https://codereview.chromium.org/538023002
2014-09-04 11:08:07 -04:00
Mike Klein
d204a1b039 rebaseline downsamplebitmaps
BUG=skia:

Review URL: https://codereview.chromium.org/537913003
2014-09-04 11:03:30 -04:00
Mike Klein
f8b4563e15 remove unused n4 expectations
BUG=skia:

Review URL: https://codereview.chromium.org/537163002
2014-09-03 17:39:25 -04:00
Mike Klein
ab799fe66c fix up GM suppressions
BUG=skia:2911

Review URL: https://codereview.chromium.org/538723002
2014-09-03 17:02:04 -04:00
mtklein
6a2f5fe867 Turn downsamplebitmap GMs vertical to fit in 2048x2048.
BUG=skia:2911
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/536103002
2014-09-03 13:40:52 -07:00
jvanverth
3f5417590a Update fontcache GM to stress the font atlas.
Pulled out of https://codereview.chromium.org/466363009/.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/534253003
2014-09-03 08:44:59 -07:00
Derek Sollenberger
2e9176c348 Update failing testimagefilter GM with new baseline and bug number
Review URL: https://codereview.chromium.org/535843003
2014-09-03 09:10:20 -04:00
Derek Sollenberger
afbfc2212e Rebase NEON image procs based on C++ implementation.
BUG=skia:2845

Review URL: https://codereview.chromium.org/532193003
2014-09-03 09:01:29 -04:00
Derek Sollenberger
c56653cdd2 Update GM baselines for Arm64 bot.
Review URL: https://codereview.chromium.org/530423003
2014-09-03 08:31:02 -04:00
egdaniel
7f91c3359f Rebaseline bezier cubics
TBR=bsalomon@google.com
NOTRY=True

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/528033002
2014-09-02 12:53:12 -07:00
djsollen
871dca8ea9 Disable NEON procs for box blur as it produces invalid results
R=reed@google.com, mtklein@google.com, senorblanco@google.com
TBR=reed@google.com
BUG=skia:2845

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/527973002
2014-09-02 08:57:39 -07:00
djsollen
4d6484e764 Revert of Disable NEON procs for box blur as it produces invalid results (patchset #1 id:1 of https://codereview.chromium.org/520963002/)
Reason for revert:
failing more GMs than expected.

Original issue's description:
> Disable NEON procs for box blur as it produces invalid results
>
> BUG=skia:2845
>
> Committed: https://skia.googlesource.com/skia/+/4a1764688c990fb926aaeab538497dad52768d99

R=senorblanco@google.com, mtklein@google.com
TBR=mtklein@google.com, senorblanco@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2845

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/531023002
2014-09-02 06:32:26 -07:00
djsollen
4a1764688c Disable NEON procs for box blur as it produces invalid results
BUG=skia:2845
R=senorblanco@google.com, mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/520963002
2014-09-02 05:32:23 -07:00
Mike Klein
6d134201a9 Rebaseline one N4 GM we must have missed.
BUG=skia:

Review URL: https://codereview.chromium.org/524103002
2014-08-30 10:33:22 -04:00
Derek Sollenberger
566a22c543 Add baselines for all GMs that are currently labeled "no comparison".
R=mtklein@google.com

Review URL: https://codereview.chromium.org/519063004
2014-08-29 15:46:28 -04:00
Greg Humphreys
f2b5f2c2e9 rebaseline and re-enable all perspective tests
BUG=skia:

Review URL: https://codereview.chromium.org/518253002
2014-08-29 15:39:03 -04:00
Greg Humphreys
a8cf3bee44 fix names of suppresssed tests on win7
BUG=skia:

Review URL: https://codereview.chromium.org/524643003
2014-08-29 15:35:49 -04:00
Greg Humphreys
7ad2f08ba1 partial rebaseline for image scaling
BUG=skia:

Review URL: https://codereview.chromium.org/520863002
2014-08-29 15:29:38 -04:00
egdaniel
b2f94d1f4a Use highp for gpu bezier effects
BUG=skia:2860
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/519473003
2014-08-29 10:08:36 -07:00
borenet
2269bce9be Rebaseline N10 Recipes bot
BUG=skia:
R=djsollen@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/522803002
2014-08-29 09:43:06 -07:00
Derek Sollenberger
2953238dd2 Add Nexus 5 baselines to Android.
Review URL: https://codereview.chromium.org/519813002
2014-08-29 12:29:28 -04:00
Derek Sollenberger
e92707916d Massive rebase of Nexus 4 bots.
Review URL: https://codereview.chromium.org/517183003
2014-08-29 12:00:09 -04:00
humper
76273bb9ec suppress one more filterbitmap GM
BUG=skia:
TBR=djsollen

Author: humper@google.com

Review URL: https://codereview.chromium.org/522703002
2014-08-29 07:45:23 -07:00
humper
7af7a48ed2 more suppressions to handle differences on Win7 bot
BUG=skia:
TBR=djsollen

Author: humper@google.com

Review URL: https://codereview.chromium.org/518833002
2014-08-29 07:45:01 -07:00
humper
d73c169637 Second attempt to land the integral image scaling change.
Scale all images to the nearest rounded integer, and if there's still
any scaling factor left over, pass it on to the subsequent bilerp code.
Should avoid artifacts when tiling scaled images.

Original CL received an LGTM from reed; new version disabled tiling
in the downsamplebitmap GM; I verified that this fixes the issue
we were seeing there on non-neon androids.

BUG=skia:2888
R=reed@android.com
TBR=reed

Author: humper@google.com

Review URL: https://codereview.chromium.org/514383003
2014-08-28 14:27:42 -07:00
jvanverth
d21a686324 Rebaseline N10 GPU hairmodes.
This bug appears to be gone.

BUG=skia:1655
TBR=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/515303004
2014-08-28 12:18:41 -07:00
Derek Sollenberger
4f7c78ef11 Update FontMgr expectations now the Win7 ANGLE bot is back online.
BUG=skia:2829

Review URL: https://codereview.chromium.org/510383004
2014-08-28 14:53:43 -04:00
jvanverth
63b9dc8247 Restore text vertex buffer alloc and other optimizations.
Modifies the fontcache GM to ensure that the font cache is forced to flush.

Committed: https://skia.googlesource.com/skia/+/9c3d24b9d1ba3d955094ff0cb1ba2d11e1c1adca

R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/466363009
2014-08-28 10:39:40 -07:00
humper
60cc7d353b manual revert of bitmap scale change while I investigate failures
on chromeos

TBR=reed
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/516923003
2014-08-28 09:54:41 -07:00
bungeman
7e7136f47d Update baselines for the fontMgr GMs.
BUG=skia:2829
2014-08-28 12:34:28 -04:00
Derek Sollenberger
da0b7a6a52 Update expectations for FontMgr that were missed in previous runs
BUG=skia:2829

Review URL: https://codereview.chromium.org/516533003
2014-08-27 17:02:18 -04:00
djsollen
2e1a82675c Revert of Restore text alloc optimizations. (patchset #4 of https://codereview.chromium.org/466363009/)
Reason for revert:
GM failures on http://108.170.220.120:10115/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/1867/

Original issue's description:
> Restore text vertex buffer alloc and other optimizations.
>
> Modifies the fontcache GM to ensure that the font cache is forced to flush.
>
> Committed: https://skia.googlesource.com/skia/+/9c3d24b9d1ba3d955094ff0cb1ba2d11e1c1adca

R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com
TBR=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/510103003
2014-08-27 13:12:25 -07:00
Derek Sollenberger
9694d63cf0 Update fontMgr expectations for Mac/Linux/Windows
BUG=skia:2829

Review URL: https://codereview.chromium.org/514913002
2014-08-27 15:50:03 -04:00
jvanverth
9c3d24b9d1 Restore text vertex buffer alloc and other optimizations.
Modifies the fontcache GM to ensure that the font cache is forced to flush.

R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/466363009
2014-08-27 11:53:17 -07:00
Derek Sollenberger
31067ddfdd Update GPU baselines for the fontMgr GMs.
BUG=skia:2829

Review URL: https://codereview.chromium.org/511973002
2014-08-27 14:48:09 -04:00
Derek Sollenberger
f0393f035b Update non-GPU baselines for the fontMgr GMs.
BUG=skia:2829

Review URL: https://codereview.chromium.org/515473003
2014-08-27 14:38:45 -04:00
humper
ce7b1d5fad always scale to an integer; compensate for fractional image sizes by leaving the fractional scale in the matrix
BUG=skia:
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/470233002
2014-08-27 07:56:49 -07:00
Derek Sollenberger
390f62479a Ignore font_mgr gms until we can rebase them
BUG=skia:2829
R=mtklein@google.com

Review URL: https://codereview.chromium.org/513813002
2014-08-27 10:45:37 -04:00
Florin Malita
0b14aa80dd Add text blob gm baselines.
Review URL: https://codereview.chromium.org/504203002
2014-08-26 11:17:02 -04:00
bungeman
bc818f513b Rebaselines for a6785ccb54 (Add a working SkFontMgr_fontconfig.) 2014-08-25 17:18:53 -04:00
bungeman
a8b53b547f Rebaselines for a6785ccb54 (Add a working SkFontMgr_fontconfig.) 2014-08-25 15:47:55 -04:00
Mike Klein
b2a16919d9 gradtext also needed rebaselining from the gamma change
BUG=skia:

Review URL: https://codereview.chromium.org/501113002
2014-08-25 13:50:29 -04:00
Mike Klein
708f154d7e Rebaseline 565 precision changes and matrixconvolution.
BUG=skia:2797

Review URL: https://codereview.chromium.org/504873002
2014-08-25 13:14:16 -04:00
Mike Klein
3e42a46385 suppress matrixconvolution
BUG=skia:

Review URL: https://codereview.chromium.org/476283003
2014-08-22 13:09:02 -04:00
fmalita
37ecbaffd1 [SkTextBlob] Merge run font data at draw time.
R=bungeman@google.com, reed@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/496773002
2014-08-22 09:01:20 -07:00
Mike Klein
4d88bf547f Some early 565 rebaselines.
BUG=skia:2797

Review URL: https://codereview.chromium.org/488453003
2014-08-22 11:23:18 -04:00
Mike Klein
6f1cd27536 Ignore GMs that will need 565 rebaselines.
BUG=skia:

Review URL: https://codereview.chromium.org/483883004
2014-08-22 10:16:03 -04:00
caryclark
fe9384910d add tool generated whitespace
the rebaseline tool adds whitespace at the end of lines in the json file.
While harmless, git flags this as something worth fixing. Fixing it causes
the rebaseline tool to generate a new difference with the whitespace.

Checking the whitespace back in to avoid future back-and-forth.

TBR=
NOTRY=true
NOTREECHECKS=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/494363002
2014-08-22 04:55:14 -07:00
caryclark
accce6ed75 fix remaining arm64 expectations
R=halcanary@google.com
TBR=halcanary@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:2845

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/496253004
2014-08-22 04:48:13 -07:00
caryclark
78fc1dbed0 update expectations for Nexus 10 Debug
NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2860

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/492303003
2014-08-21 12:37:55 -07:00
halcanary
c2d04e1bb8 temporary rebaseline on arm64
Affects all blur tests.

BUG=skia:2845
NOTRY=true
R=caryclark@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/495093002
2014-08-21 09:03:50 -07:00
caryclark
5d74806b47 update gm expectations for Nexus 10
the Android version was updated, introducing a new GPU driver

NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2860

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/496733002
2014-08-21 07:43:43 -07:00
caryclark
74206bc489 ignore flaky failure on android
this failed to commit the first time

NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/488273002
2014-08-20 14:01:28 -07:00
caryclark
367d03fb5a ignore release as well
This GM is flaky as Brian expected on both Release and Debug,
so suppress the Release expectation as well.

NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2826

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/489083002
2014-08-20 06:34:15 -07:00
caryclark
de218041b9 add patch grid update for 64 bit arm
TBR=
NOTREECHECKS=true
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/463353003
2014-08-19 05:28:23 -07:00
borenet
81d92659cf Copy N10 GM expectations for recipe bot
BUG=skia:761
R=epoger@google.com, rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/481963002
2014-08-18 08:50:43 -07:00
borenet
de512d9a6c Rebaseline astcbitmap and etc1bitmap on Recipes bot
BUG=skia:761
NOTREECHECKS=true
R=robertphillips@google.com, bsalomon@google.com, krajcevski@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/481883003
2014-08-18 06:50:33 -07:00
Brian Salomon
f878e3cb3c Rebaseline and remove tests from ignored-tests.txt
BUG=skia:

Review URL: https://codereview.chromium.org/475013002
2014-08-14 13:51:16 -04:00
krajcevski
e1c78ae553 Rebaseline R11 and ASTC bitmap GMs
TBR=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/471723002
2014-08-14 07:24:53 -07:00
Brian Salomon
81ecaa2e4c Fix typo in ignored-tests.txt
BUG=skia:

Review URL: https://codereview.chromium.org/475583002
2014-08-13 18:31:03 -04:00
mtklein
3140576f2f Baseline Android-Reference-Unknown-Arm64
BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/474563002
2014-08-13 11:59:53 -07:00
Brian Salomon
f411ee7178 git cl land# Enter a description of the change.
Even more tests to ignored-tests for gpu rect changes

BUG=skia:

Review URL: https://codereview.chromium.org/468223003
2014-08-13 13:37:45 -04:00
joshualitt
97a0d43771 Updating expectations for matrix convolution
R=bsalomon@chromium.org
BUG=skia:

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/464913003
2014-08-13 10:31:04 -07:00
epoger
785246ee38 add expectations for Test-Android-Reference-Unknown-Arm64-{Debug,Release}
BUG=skia:2828
NOTREECHECKS=true
NOTRY=true
R=mtklein@google.com
TBR=mtklein

Author: epoger@google.com

Review URL: https://codereview.chromium.org/468243002
2014-08-13 09:36:46 -07:00
Brian Salomon
a9424995ac Add additional tests to ignored-tests
BUG=skia:

Review URL: https://codereview.chromium.org/463993003
2014-08-13 12:08:01 -04:00
bsalomon
c30aaa0e40 Use combined color/coverage attribute when possible in aa rect renderer.
Also restore the is_irect test to detect AA rects that are integer aligned.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/466873002
2014-08-13 07:15:30 -07:00
Brian Salomon
b0c855146d Mark degeneratesegments GM as flakly on nvpr/ubuntu/debug
BUG=skia:2826

Review URL: https://codereview.chromium.org/456653005
2014-08-12 11:19:54 -04:00
Brian Salomon
0a82f5be21 Rebaseline current failures and those ignored for GPU rect change.
BUG=skia:

Review URL: https://codereview.chromium.org/460343003
2014-08-12 11:10:35 -04:00
joshualitt
5acfea789d 2D kernel initial wiring for Guassian
BUG=skia:
R=senorblanco@chromium.org, bsalomon@chromium.org, bsalomon@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/418223009
2014-08-11 13:55:34 -07:00
Brian Salomon
4596c98908 Mark convex_poly_clip as flaky on msaa16/win8 bots. Add more tests to ignored_tests.txt after GPU rect change.
BUG=skia:

Review URL: https://codereview.chromium.org/460023002
2014-08-11 15:36:43 -04:00
bsalomon
9c0822a415 Always use both a color and coverage attribute in GrAARectRenderer.
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/435743002
2014-08-11 11:07:48 -07:00
Brian Salomon
6dff71f44b Remove bleed test from ignored-tests.txt
BUG=skia:

Review URL: https://codereview.chromium.org/463503004
2014-08-11 11:21:25 -04:00
Brian Salomon
136aa8fb7e Rebase convex_poly_clip test on Win8 msaa16
BUG=skia:

Review URL: https://codereview.chromium.org/458243002
2014-08-11 10:22:10 -04:00
borenet
0898e2b420 Empty the Recipes bot's GM expectations
BUG=skia:761
NOTRY=true
R=epoger@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/455433002
2014-08-07 13:02:43 -07:00
borenet
c3cbc1dc0e Duplicate NoGPU expectations for new recipes bot
BUG=skia:761
R=epoger@google.com
TBR=epoger
NOTRY=true

Author: borenet@google.com

Review URL: https://codereview.chromium.org/447323003
2014-08-07 11:28:21 -07:00
bsalomon
0673676854 Don't compare coord change matrices to determine effect compatibility when using explicit local coords.
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/438053002
2014-08-04 10:56:40 -07:00
bungeman
c6f5784047 No longer ignore and rebaseline fontmgr gms. 2014-08-01 15:02:36 -04:00
joshualitt
0e67808da7 Enabling texture_domain_effect
BUG=skia:
REVIEW=tbr
R=rmistry@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/425253003
2014-07-30 10:31:10 -07:00
Brian Salomon
00683c7b9a Mark bleed GM images on GPU configs as baselined but associated with bug 2762
BUG=skia:2762

Review URL: https://codereview.chromium.org/431453006
2014-07-30 10:08:09 -04:00
Brian Salomon
5520e3be26 Rebaseline some images from ignored-tests.txt
BUG=skia:

Review URL: https://codereview.chromium.org/431583004
2014-07-30 09:40:56 -04:00
Brian Salomon
b174f2b3cc Rebaseline currently failing images. All look better or insignificantly different
Review URL: https://codereview.chromium.org/423283005
2014-07-30 09:27:19 -04:00
joshualitt
5ae5fc59b2 Adding repeat mode to texture domain
BUG=skia:
R=bsalomon@chromium.org, senorblanco@chromium.org, bsalomon@google.com, junov@chromium.org

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/422123003
2014-07-29 12:59:27 -07:00
cdalton
15ab26d942 Rebaseline needed nvpr gms after text change
Updates a few nvpr expectations for slight pixel diffs after a change
in the math that positions glyphs.

BUG=skia:
R=jvanverth@google.com, bungeman@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/421423002
2014-07-28 15:39:06 -07:00
cdalton
b2808cd041 Send less transform data when drawing text with nvpr
Before this change, GrStencilAndCoverTextContext would send 6-float
affine transforms to drawPaths for every glyph. This updates it to
concat the text scale onto the context matrix, and then only send
2-float translates (or 1-float x-translates when possible).

Also adds a glyph_pos_align test to gm that exercises the newly added
codepaths, and starts ignoring a few gm tests with benign pixel diffs
until we can rebaseline.

BUG=skia:
R=bsalomon@google.com, kkinnunen@nvidia.com, jvanverth@google.com, bungeman@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/406523003
2014-07-25 14:13:57 -07:00
Brian Salomon
0925a5784c Add initial baselines for varied_text* GMs
Review URL: https://codereview.chromium.org/416983002
2014-07-24 17:23:44 -04:00
robertphillips
a2c79fb412 Suppress Win8 raster verylargebitmap GM flakes
BUG=skia:2775

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
NOTREECHECKS=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/418863003
2014-07-24 05:30:39 -07:00
robertphillips
ba0055b290 Revert "Update fontmgr expectations."
This reverts commit ff4b56b2d5.

R=bungeman@gmail.com
TBR=bungeman@gmail.com
NOTRY=true
NOTREECHECKS=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/406323004
2014-07-22 16:34:38 -07:00
bungeman
ff4b56b2d5 Update fontmgr expectations. 2014-07-22 18:21:24 -04:00
bungeman
33d134656e Suppress fontmgr gm changes while Android catches up. 2014-07-22 16:02:58 -04:00
egdaniel
f7caacdbb7 Rebaseline from recent gpu optimization changes
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/408203002
2014-07-22 06:46:45 -07:00
egdaniel
02cafcc1bf Remove gpu shader optimatization for solid white or trans black colors
Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths.

With optimization in (ms):
         White       Blue        Checkered
Linux    ~80         ~80         ~160
N7       ~800        ~1100       ~1500
Moto-e   ~830        ~1100       ~2500

Without optimization in (ms):
         White       Blue        Checkered
Linux    ~80         ~80         ~80
N7       ~1100       ~1100       ~1100
Moto-e   ~1100       ~1100       ~1500

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5f78d2251a440443c9eaa321dad058d7a32bfef7

R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/375823005
2014-07-21 11:37:28 -07:00
Mike Klein
dddf564ee7 rebaseline most dw changes
BUG=skia:

Review URL: https://codereview.chromium.org/402443002
2014-07-16 16:20:12 -04:00
senorblanco
b02ab4b47b New Mac 10.6 x86_64 Debug baselines for perlin noise tests.
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/384043002
2014-07-11 10:09:02 -07:00
senorblanco
3031a2f1df Yet more perlin noise rebaselines.
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/385733003
2014-07-10 13:02:30 -07:00
senorblanco
bb02bb5ab1 You guessed it -- more perlin noise rebaselines.
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/386693002
2014-07-10 12:42:01 -07:00
senorblanco
250b59dd49 Ibid.
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/381223002
2014-07-10 12:01:29 -07:00
senorblanco
0c4a70d6e9 Yet more perlin noise rebaselines.
(Apparently my rebaseline_server skills leave something to be desired.)

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/384863002
2014-07-10 11:57:26 -07:00
senorblanco
626650f62f Some more perlinnoise rebaselines.
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/381973002
2014-07-10 11:29:20 -07:00
senorblanco
3a3eef4a63 New baselines for perlin noise changes.
Pixel results affected by ca6a7c2945

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/385643003
2014-07-10 10:52:21 -07:00
robertphillips
e6b28cf25b Remove shadows suppression
The 'shadows' GM isn't appearing on the "Recent GM Failures" page. It might have been a blip.

R=jcgregorio@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/387533002
2014-07-10 07:57:16 -07:00
robertphillips
5fe23b357a Add suppression for shadows test
R=jvanverth@google.com
TBR=jcgregorio@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/377403004
2014-07-09 14:24:00 -07:00
jvanverth
2d9d9c9ded Update one last expectation from gamma change.
R=bungeman@google.com
TBR=bungeman@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/380823002
2014-07-09 11:12:06 -07:00
jvanverth
085f334c47 Update remaining expectations for https://codereview.chromium.org/337603008.
TBR=bungeman@chromium.org

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/371003004
2014-07-07 08:44:46 -07:00
egdaniel
705a1535a3 Rebaseline Angle gms for recent dashing4 rebaseline
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/378513004
2014-07-07 07:27:37 -07:00
egdaniel
8119e6a85d Rebaseline for gpu dashing4 now doing circle dashes
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/374623003
2014-07-07 06:28:44 -07:00
jvanverth
c6bbd82210 Ignore some GM images for https://codereview.chromium.org/337603008.
R=bungeman@google.com
TBR=bungeman@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/361333002
2014-07-02 15:54:24 -07:00
jvanverth
23ff2a5d46 More expectation updates for https://codereview.chromium.org/337603008.
R=bungeman@google.com
TBR=bungeman@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/368073002
2014-07-02 14:15:37 -07:00
mtklein
217daa7ec5 Revert of Remove the AA requirement for selecting GrEffect-based clipping. (https://codereview.chromium.org/367013003/)
Reason for revert:
We think this is breaking the roll.

Original issue's description:
> Remove the AA requirement for selecting GrEffect-based clipping.
>
> Also, optionally use the scissor for a bw clip rect element instead of an effect.
>
> Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11
>
> Committed: https://skia.googlesource.com/skia/+/e9a729cb4d3f05b9c750dc1f63a9cc65b5659f04

R=robertphillips@google.com, bsalomon@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/361313002
2014-07-02 12:55:21 -07:00
bsalomon
e9a729cb4d Remove the AA requirement for selecting GrEffect-based clipping.
Also, optionally use the scissor for a bw clip rect element instead of an effect.

Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/367013003
2014-07-02 11:42:29 -07:00
jvanverth
5c76a0f1d1 Update some expectations for https://codereview.chromium.org/337603008.
R=bungeman@google.com
TBR=bungeman@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/362373002
2014-07-02 11:33:07 -07:00
bsalomon
e1593862fe Revert of Remove the AA requirement for selecting GrEffect-based clipping. (https://codereview.chromium.org/367013003/)
Reason for revert:
Assertion failing.

Original issue's description:
> Remove the AA requirement for selecting GrEffect-based clipping.
>
> Also, optionally use the scissor for a bw clip rect element instead of an effect.
>
> Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/369613002
2014-07-02 11:11:30 -07:00
bsalomon
a73218bbbd Remove the AA requirement for selecting GrEffect-based clipping.
Also, optionally use the scissor for a bw clip rect element instead of an effect.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/367013003
2014-07-02 10:40:52 -07:00
egdaniel
f767e792b9 Add the ability for gpu to render dotted lines (dashed line, 0 on interval, round caps)
BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/345113003
2014-07-02 06:21:34 -07:00
jvanverth
dc1cf66483 Remove A8_LCD luminance hack.
It no longer appears to be necessary, and the powf function is slowing down
Android text rendering.

R=bungeman@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/337603008
2014-07-01 13:43:00 -07:00
Ben Wagner
529b7f6d62 Expectations updates for DirectWrite change 761b25. 2014-06-30 16:18:24 -04:00
reed
4eec156659 rebaseline srcmode for gpus -- now pass samplecount
TBR=
NOTRY=True
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/357393002
2014-06-30 10:59:48 -07:00
senorblanco
d4fa483504 Some straggler rebaselines for imagefiltersclipped.
NOTRY=true
NOTREECHECKS=true
R=rmistry@google.com
TBR=rmistry
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/348313006
2014-06-27 16:20:03 -07:00
senorblanco
d297d0f2c2 New baselines for imagefiltersclipped GM after perlin noise change.
R=rmistry@google.com
TBR=rmistry
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/361523003
2014-06-27 14:45:30 -07:00
senorblanco
ca6a7c2945 Make perlin noise do CTM-correct scaling.
When drawing perlin noise, generate noise at the resolution determined
by CTM, not by the resolution at construction time. This required moving
the generation of PaintingData to getContext() and asNewEffect() for the
raster and GPU paths, respectively.

It also required adjusting the matrices used during rendering
to be translate-only.

R=sugoi@chromium.org, bsalomon@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/358903002
2014-06-27 13:35:52 -07:00
rmistry
8ba8d923da Rebaseline Test-Android-Logan-Nvidia-Arm7-*
Reviewed both by mtklein and bsalomon in skia:2695.

TBR=
BUG=skia:2695
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/352353004
2014-06-26 11:35:33 -07:00
senorblanco
7bf1068473 Remove SkBicubicImageFilter, and all related tests.
Now that we have SkResizeImageFilter, and the bicubic
resizing is part of skia proper, there's no need for a
specialized image filter.

BUG=skia:
R=bsalomon@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/357793002
2014-06-25 14:39:06 -07:00
Mike Klein
85a08789c0 Rebase Test-Ubuntu12-ShuttleA-GTX660-x86-Release.
BUG=skia:2575

Review URL: https://codereview.chromium.org/353883002
2014-06-25 13:21:56 -04:00
kkinnunen
55106da359 Ignore degeneratesegments for nvprmsaa4 to unbreak the build
Ignore degeneratesegments for nvprmsaa4 to unbreak the build. The result image
seems to be inconsistent with different Linux GTX660 builds. Ignore the test for
Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release.

BUG=skia:2689
R=rmistry@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/345423006
2014-06-25 04:30:38 -07:00
Brian Salomon
20fa0c3238 rebase GMs
BUG=skia:

Review URL: https://codereview.chromium.org/351973003
2014-06-24 18:08:09 -04:00
kkinnunen
68dd81bde9 Rebaseline gm results after "Implement text rendering with NVPR"
Rebaseline gm results after "Implement text rendering with NVPR".  The text is
rasterized by NV_path_rendering extension, so pixels are expected to be a bit
different.

NOTRY=true
R=rmistry@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/346413002
2014-06-24 04:45:58 -07:00
rmistry
798496c66f Rebaseline shadertext2_{gpu,8888} after SkPaint::measureText changes
These two GMs were missing from https://codereview.chromium.org/347393002/.

This CL is to fix http://108.170.220.121:10117/static/view.html#/view.html?resultsToLoad=%2Fresults%2Ffailures&displayLimitPending=50&showThumbnailsPending&mergeIdenticalRowsPending&imageSizePending=100&sortColumnSubdict=differenceData&sortColumnKey=perceptualDifference&hiddenResultTypes=failure-ignored,no-comparison,succeeded&hiddenConfigs=&builder=Test-Win7-ShuttleA-HD2000-x86-Release&test=

BUG=skia:
R=kkinnunen@nvidia.com, jvanverth@google.com, mtklein@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/333193003
2014-06-23 10:32:29 -07:00
robertphillips
c8fd7b58c5 Remove suppression of distantclip image differences
R=rmistry@google.com, rmistry@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/349233004
2014-06-23 09:01:52 -07:00
kkinnunen
0156c7646c Rebaseline shadertext2 after SkPaint::measureText changes
Rebaseline shadertext2 after commit "Fix SkPaint::measureText for stroked
hairline text".

Unignore ignored shadertext2 for Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug
pdf-poppler.

The label "Filled" in the test moves to the left due to the changes in the
measurement. The SkPaint::measureText will use the "use paths" code path,
similar to the drawing code. This results in different length for the string
"Filled".

As a side-note, the test probably measures either wrong text or uses wrong
paint. This can be fixed separately.

NOTREECHECKS=true
NOTRY=true
R=jvanverth@google.com, mtklein@google.com, rmistry@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/347393002
2014-06-23 06:59:46 -07:00
rmistry
c4b84aef1a Revert of Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/354433002/)
Reason for revert:
Rebaseline CL is ready to be submitted

Original issue's description:
> Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/335603003/)
>
> Reason for revert:
> Caused many shadertext GM failures
>
> Original issue's description:
> > Fix SkPaint::measureText for stroked hairline text
> >
> > SkPaint::measureText and text drawing used different criteria for
> > determining whether text should be drawn as paths or not.
> >
> > Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
> > positioning in the rendering. Mainly added in order to define what is the
> > expected text rendering when hairline stroke is used with various transform
> > options.
> >
> > The testcase also tries to note or highlight the fact that SkPaint::measureText
> > is not expected to produce intuitively matching results when compared to a
> > rendering, if the rendering is done so that the device ends up having a device
> > transform.
> >
> > This fixes the glyph_pos_h_s (hairline, stroked) test-case.
> >
> > Ignore shadertext2_pdf-poppler.png gm on
> > Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
> >
> > Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793
>
> TBR=jvanverth@google.com,reed@google.com,kkinnunen@nvidia.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/abc9bb55ddfeb4b1a7acc335a34841fddcd22d27

R=jvanverth@google.com, reed@google.com, kkinnunen@nvidia.com
TBR=jvanverth@google.com, kkinnunen@nvidia.com, reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/349153005
2014-06-23 06:59:15 -07:00
rmistry
abc9bb55dd Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/335603003/)
Reason for revert:
Caused many shadertext GM failures

Original issue's description:
> Fix SkPaint::measureText for stroked hairline text
>
> SkPaint::measureText and text drawing used different criteria for
> determining whether text should be drawn as paths or not.
>
> Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
> positioning in the rendering. Mainly added in order to define what is the
> expected text rendering when hairline stroke is used with various transform
> options.
>
> The testcase also tries to note or highlight the fact that SkPaint::measureText
> is not expected to produce intuitively matching results when compared to a
> rendering, if the rendering is done so that the device ends up having a device
> transform.
>
> This fixes the glyph_pos_h_s (hairline, stroked) test-case.
>
> Ignore shadertext2_pdf-poppler.png gm on
> Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
>
> Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793

R=jvanverth@google.com, reed@google.com, kkinnunen@nvidia.com
TBR=jvanverth@google.com, kkinnunen@nvidia.com, reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/354433002
2014-06-23 05:39:26 -07:00
kkinnunen
196af73802 Fix SkPaint::measureText for stroked hairline text
SkPaint::measureText and text drawing used different criteria for
determining whether text should be drawn as paths or not.

Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
positioning in the rendering. Mainly added in order to define what is the
expected text rendering when hairline stroke is used with various transform
options.

The testcase also tries to note or highlight the fact that SkPaint::measureText
is not expected to produce intuitively matching results when compared to a
rendering, if the rendering is done so that the device ends up having a device
transform.

This fixes the glyph_pos_h_s (hairline, stroked) test-case.

Ignore shadertext2_pdf-poppler.png gm on
Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.

R=jvanverth@google.com, reed@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/335603003
2014-06-22 22:18:14 -07:00
krajcevski
61843107f6 Rebaseline clip on Win7 ShuttleA HD2000
BUG=skia:
R=bsalomon@google.com
TBR=bsalomon@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/342403002
2014-06-20 13:07:15 -07:00
Ben Wagner
909f91dc4c Rebaselines for DirectWrite non-rounding.
Review URL: https://codereview.chromium.org/337923004
2014-06-20 14:41:35 -04:00
krajcevski
bbf93efdd0 Restore bug numbers
BUG=skia:
R=bsalomon@google.com
TBR=bsalomon@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/341313002
2014-06-20 11:39:27 -07:00
krajcevski
912d809a85 Rebaseline after dithering change
TBR=bsalomon@google.com
BUG=skia:

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/347103003
2014-06-20 09:02:16 -07:00
egdaniel
6b8f1ba1ef Rebaseline win7-HD2000 for flaky dashing4 gm
R=bsalomon@google.com
TBR=bsalomon@google.com

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/344853005
2014-06-20 06:33:05 -07:00
krajcevski
f461a8fdf6 Simple GPU based dithering:
If dithering is turned on, apply an effect that filters the pixel through
the following pipeline:

for each channel c:
  1. Compute quantized colors [low, high] that c is between
  2. Pick high by flipping a coin weighted by (c - low)

R=bsalomon@google.com, egdaniel@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/321253002
2014-06-19 14:14:06 -07:00
senorblanco
373dd9b52f New Nexus4 baselines for imagefiltersclipped, GPU path.
R=reed@google.com
TBR=reed@google.com
NOTRY=True
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/347693002
2014-06-18 16:26:39 -07:00
egdaniel
de10fdeee5 Add additional dashing rebaselines
NOTRY=True
NOTREECHECK=True
R=bsalomon@google.com
TBR=bsalomon@google.com

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/347543003
2014-06-18 07:31:08 -07:00
egdaniel
00fb42704a Rebaslines from recent dashing changes
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/339203003
2014-06-18 06:56:19 -07:00
reed
1777f233bd unignore canvas-layer-state
TBR=
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/336273005
2014-06-18 05:47:45 -07:00
Ben Wagner
60741912fd Rebaseline ANGLE bots. 2014-06-17 18:39:09 -04:00
humper
4a24cd8ff4 Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader.
approved over in https://codereview.chromium.org/331863006/; reuploading
because it had the wrong base url

BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon

Author: humper@google.com

Review URL: https://codereview.chromium.org/341543005
2014-06-17 13:39:31 -07:00
Ben Wagner
9323b01e90 Update Windows baselines due to VS2013 update.
Floating point operations now differ in the low bits from before.
2014-06-17 16:28:20 -04:00
reed
0992d0764b rebaseline after changing labels in bitmapfilters
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/340583004
2014-06-17 12:31:49 -07:00
dandov
baa860c297 * Removed bitmapshaders from expectations/gm/ignored-tests.txt.
* Rebaseline bitmapshaders, gpu didn't produce the same images when using only alpha bitmaps
	because it didn't consider the skpaint's color.

BUG=skia:2293
R=jvanverth@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/339923004
2014-06-17 11:21:46 -07:00
reed
057ef35280 rebaseline after GM change to bitmapfilters
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/341593003
2014-06-17 10:32:31 -07:00
reed
12d4aa69b5 ignore bitmapfilters failures until we can rebaseline
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/339153004
2014-06-17 10:28:08 -07:00
kevin.petit
cf2187267b Armv8/64bit doesn't (apparently) need rebaselining
BUG=skia:
R=reed@google.com
NOTRY=True

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/334743009
2014-06-16 10:05:41 -07:00
senorblanco
9a8699f45c New baselines for perlin noise tests affected by ce6a35.
New baselines for perlinnoise, imagefiltersclipped and
imagefiltersscaled GMs.

R=scroggo@google.com
TBR=scroggo
NOTRY=true

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/336703002
2014-06-12 14:31:57 -07:00
reed
2526f0e5fd rebaselines for removal of unitmapper
TBR=
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/330513005
2014-06-12 12:53:01 -07:00
Stephen White
1b5e04ec5f Add more tests to ignore-tests.txt.
Add imagefiltersclipped and imagefiltersscaled to ignored-tests.txt
until they can be rebaselined, since they're failing on Android after
https://codereview.chromium.org/332523006/.

TBR=scroggo
BUG=skia:

Review URL: https://codereview.chromium.org/336663002
2014-06-12 15:51:46 -04:00
scroggo
e07c1ab408 Revert of third try at landing improved blur rect; this time with more correctness (https://codereview.chromium.org/331443003/)
Reason for revert:
Failing layout test: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/32762/layout-test-results/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-pretty-diff.html

Original issue's description:
> third try at landing improved blur rect; this time with more correctness
>
> BUG=skia:2095
> R=bsalomon@google.com
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/72abfc2b4e7caead660f6b6a05e60d05eaf1a66f

R=bsalomon@google.com, reed@google.com, humper@google.com
TBR=bsalomon@google.com, humper@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/333763002
2014-06-12 12:10:24 -07:00
egdaniel
8b6fee1eb9 Add another fail-ignore for flaky dashing4 gm
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/329223007
2014-06-12 11:58:16 -07:00
senorblanco
ce6a354e12 Fix tiled perlin noise.
It turns out that the perlin implementation we inherited from WebKit
does not actually generate tileable noise (see Chromium bug
http://crbug.com/383495).

The main problem is that when generating coordinates for gradient
interpolation, it was attempting to wrap both x and (x + 1)
simultaneously at the tile boundary (that is, either both or neither
are wrapped). This obviously won't work, since along the tile seams,
(x + 1) should be wrapped, but x should not. The same is true in y.

This patch fixes both the CPU and GPU paths, renames some variables to
more closely match the spec, and modifies the perlin noise GM to
actually test tiling. (Note that the clipping the GM was doing was
removed, since it's superfluous: it used to be necessary for image
filters, but isn't anymore, and this isn't an image filter GM anyway.)

R=sugoi@google.com, sugoi
TBR=senorblanco

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/332523006
2014-06-12 11:24:20 -07:00
egdaniel
e61c411c12 Use vertex attributes for dash effect in gpu
This will allow us to batch dashed lines together when drawing. Also, this removes the need for
a coord transform matrix in the shader, thus we save the cost of uploading a new matrix uniform
everytime we do a simple transform to the dashed line we are drawing.

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/326103002
2014-06-12 10:24:21 -07:00
egdaniel
b5dcdf1e7e Rebase flakey windows dash4 gm
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:2667

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/335443003
2014-06-12 08:02:43 -07:00
egdaniel
aea9cfbe8a Add expectations for dashing gm
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/330033002
2014-06-12 06:26:16 -07:00
humper
72abfc2b4e third try at landing improved blur rect; this time with more correctness
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon

Author: humper@google.com

Review URL: https://codereview.chromium.org/331443003
2014-06-11 12:42:49 -07:00
reed
b0b1aa04ed Revert of second try at landing improved blur rect (https://codereview.chromium.org/325703002/)
Reason for revert:
broke some fast/canvas layout tests

Original issue's description:
> second try at landing improved blur rect
>
> BUG=skia:2095
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/e9ea0d6b7d59ac3b7e257281e545b24bcc0d2a76

R=bsalomon@google.com, reed@chromium.org, humper@google.com
TBR=bsalomon@google.com, humper@google.com, reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095

Author: reed@google.com

Review URL: https://codereview.chromium.org/322423002
2014-06-11 07:26:23 -07:00
dandov
9de5b514d3 SkShader::asNewEffect Refactoring
The new signature is:

	bool asNewEffect(GrContext* context, const SkPaint& paint, GrColor* grColor, GrEffectRef** grEffect, const SkMatrix* localMatrixOrNull) const;

It will fix the hack for skcolorshader by modifying the GrColor parameter in SkGr::SkPaint2GrPaintShader.

BUG=skia:2646
R=jvanverth@google.com, bsalomon@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/318923005
2014-06-10 14:38:28 -07:00
humper
e9ea0d6b7d second try at landing improved blur rect
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon

Author: humper@google.com

Review URL: https://codereview.chromium.org/325703002
2014-06-09 14:35:21 -07:00
krajcevski
9193e77db3 New etcbitmap baselines
R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/325783003
2014-06-09 10:54:04 -07:00
robertphillips
9f1c241e0d Remove SkPicture::kUsePathBoundsForClip_RecordingFlag
The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer?

R=reed@google.com, mtklein@google.com, djsollen@google.com, scroggo@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/316143003
2014-06-09 06:25:34 -07:00
jvanverth
d78a2fac37 Rollback of fe689c46 and all subsequent changes
BUG=skia:
R=humper@google.com
TBR=humper@google.com
NOTRY=True
NOTREECHECKS=True

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/324463005
2014-06-06 13:40:36 -07:00
jvanverth
a07213ac83 Disable bigblurs GM (for fe689c46a7)
BUG=skia:
R=humper@google.com
TBR=humper@google.com
NOTRY=True
NOTREECHECKS=True

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/325453002
2014-06-06 11:59:26 -07:00
humper
ede6cfc0f5 Revert of Revert of another GM to ignore for blur rebaseline (https://codereview.chromium.org/319943004/)
Reason for revert:
Hopefully working now

Original issue's description:
> Revert of another GM to ignore for blur rebaseline (https://codereview.chromium.org/319203002/)
>
> Reason for revert:
> Follow-on to fe689c46a7, which needs to be reverted due to bot failures.
>
> Original issue's description:
> > another GM to ignore for blur rebaseline
> >
> > BUG=skia:
> > TBR=jvanverth
> > NOTRY=True
> > NOTREECHECKS=True
> >
> > Committed: https://skia.googlesource.com/skia/+/f131055929afb9c9671aee3e575c380d48c5ee4d
>
> TBR=humper@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f255de0fe160e33b340301859be1d9374c5607fe

R=jvanverth@google.com
TBR=jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: humper@google.com

Review URL: https://codereview.chromium.org/324453004
2014-06-06 11:18:17 -07:00
jvanverth
f255de0fe1 Revert of another GM to ignore for blur rebaseline (https://codereview.chromium.org/319203002/)
Reason for revert:
Follow-on to fe689c46a7, which needs to be reverted due to bot failures.

Original issue's description:
> another GM to ignore for blur rebaseline
>
> BUG=skia:
> TBR=jvanverth
> NOTRY=True
> NOTREECHECKS=True
>
> Committed: https://skia.googlesource.com/skia/+/f131055929afb9c9671aee3e575c380d48c5ee4d

R=humper@google.com
TBR=humper@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/319943004
2014-06-06 10:59:13 -07:00
humper
f131055929 another GM to ignore for blur rebaseline
BUG=skia:
TBR=jvanverth
NOTRY=True
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/319203002
2014-06-06 10:36:02 -07:00
humper
fe689c46a7 Faster GPU rect blur that doesn't require computing vertical and horizontal
scanlines on the CPU first.  Should make extremely large drop shadows fast
again.

BUG=skia:
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/316273004
2014-06-06 09:48:40 -07:00
kevin.petit
ea6b46b6c0 ARM Skia NEON patches - 39 - arm64 565 blitters
This enables all 565 blitters except S32A_D565_Opaque.

Here are some performance results:

S32_D565_Opaque:
================

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |    -18.37% |    -13.04% |
+-------+------------+------------+
|     2 |     -9.90% |    -13.78% |
+-------+------------+------------+
|     4 |     -8.28% |     -6.77% |
+-------+------------+------------+
|     8 |    157.63% |     78.15% |
+-------+------------+------------+
|    16 |     72.67% |     44.81% |
+-------+------------+------------+
|    64 |     76.78% |     40.89% |
+-------+------------+------------+
|   256 |     73.85% |     36.05% |
+-------+------------+------------+
|  1024 |     75.73% |     36.70% |
+-------+------------+------------+

S32_D565_Blend:
===============

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -9.99% |    -13.79% |
+-------+------------+------------+
|     2 |     -9.17% |     -6.74% |
+-------+------------+------------+
|     4 |     -6.73% |     -4.42% |
+-------+------------+------------+
|     8 |    163.31% |    112.82% |
+-------+------------+------------+
|    16 |     55.21% |     44.68% |
+-------+------------+------------+
|    64 |     54.09% |     41.99% |
+-------+------------+------------+
|   256 |     52.63% |     40.64% |
+-------+------------+------------+
|  1024 |     52.46% |     40.45% |
+-------+------------+------------+

S32A_D565_Blend:
================

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -5.88% |     -6.06% |
+-------+------------+------------+
|     2 |     -4.74% |     -0.01% |
+-------+------------+------------+
|     4 |     -5.42% |     -3.03% |
+-------+------------+------------+
|     8 |     78.78% |     77.96% |
+-------+------------+------------+
|    16 |     98.19% |     79.61% |
+-------+------------+------------+
|    64 |    111.56% |     72.60% |
+-------+------------+------------+
|   256 |    113.80% |     69.96% |
+-------+------------+------------+
|  1024 |    114.42% |     70.85% |
+-------+------------+------------+

S32_D565_Opaque_Dither:
=======================

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -4.18% |     -0.93% |
+-------+------------+------------+
|     2 |     -2.43% |     -2.04% |
+-------+------------+------------+
|     4 |     -1.09% |     -1.23% |
+-------+------------+------------+
|     8 |    184.89% |    136.53% |
+-------+------------+------------+
|    16 |    128.64% |     89.11% |
+-------+------------+------------+
|    64 |    132.68% |    100.98% |
+-------+------------+------------+
|   256 |    157.02% |    100.86% |
+-------+------------+------------+
|  1024 |    163.85% |    103.62% |
+-------+------------+------------+

S32_D565_Blend_Dither:
======================

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -4.87% |      0.01% |
+-------+------------+------------+
|     2 |     -2.71% |      2.97% |
+-------+------------+------------+
|     4 |     -2.20% |      0.28% |
+-------+------------+------------+
|     8 |    149.76% |    146.80% |
+-------+------------+------------+
|    16 |     85.69% |     95.77% |
+-------+------------+------------+
|    64 |     88.81% |    101.39% |
+-------+------------+------------+
|   256 |     97.32% |    107.22% |
+-------+------------+------------+
|  1024 |     98.08% |    115.71% |
+-------+------------+------------+

S32A_D565_Opaque_Dither:
========================

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -1.86% |      0.02% |
+-------+------------+------------+
|     2 |     -0.58% |     -1.52% |
+-------+------------+------------+
|     4 |     -0.75% |      1.16% |
+-------+------------+------------+
|     8 |    240.74% |    155.16% |
+-------+------------+------------+
|    16 |    181.97% |    132.15% |
+-------+------------+------------+
|    64 |    203.11% |    136.48% |
+-------+------------+------------+
|   256 |    223.45% |    133.05% |
+-------+------------+------------+
|  1024 |    225.96% |    134.05% |
+-------+------------+------------+

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/317193003
2014-06-06 08:45:36 -07:00
bsalomon
93c2fb02f1 Rebaselines for drrect GM on GPU
TBR=

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/318773007
2014-06-05 07:56:56 -07:00
bungeman
30bcaa0c57 Update expectations for gyp change.
It appears that with the gyp update, floating point operations
on x86_32 are ever so slightly different when drawing some paths.

R=jvanverth@google.com
TBR=jvanverth@google.com
NOTRY=True

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/315043006
2014-06-04 15:04:11 -07:00
humper
2db11d18af a few rebaseline stragglers from image scaling change
BUG=skia:
NOTRY=True
NOTREECHECKS=True
TBR=jvanverth

Author: humper@google.com

Review URL: https://codereview.chromium.org/311853004
2014-06-03 10:20:49 -07:00
Brian Salomon
c7671bec73 Rebase a few GMs and remove some tests from ignored-tests.txt
Review URL: https://codereview.chromium.org/311813003
2014-06-03 10:01:47 -04:00
bsalomon
8af0523b38 Fall back to using clip effect for outer rect in drawdrrect
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/310483010
2014-06-03 06:34:59 -07:00
commit-bot@chromium.org
6175d50a25 more rebaselines for filterbitmap and downsamplebitmap.
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/304353007

git-svn-id: http://skia.googlecode.com/svn/trunk@14995 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-30 15:11:28 +00:00
bsalomon@google.com
ecc8649204 Mark remaining Ubuntu msaa shadertext2 images as ignore-failure.
BUG=skia:2619

Review URL: https://codereview.chromium.org/304323002

git-svn-id: http://skia.googlecode.com/svn/trunk@14969 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 18:10:46 +00:00
bsalomon@google.com
0b8bbf685b Rebaseline stragglers, mark shadertext2 as ignore on ubunutu for msaa configs.
BUG=skia:2619

Review URL: https://codereview.chromium.org/308723002

git-svn-id: http://skia.googlecode.com/svn/trunk@14964 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 16:56:53 +00:00
bsalomon@google.com
97415aa6fc Rebase shadertext2,3 and stroketext on gpu configs
Review URL: https://codereview.chromium.org/304203003

git-svn-id: http://skia.googlecode.com/svn/trunk@14955 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 15:45:19 +00:00
senorblanco@chromium.org
f970b70db5 New baselines for imagefilter GMs in perspective mode post-r14920.
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/301183002

git-svn-id: http://skia.googlecode.com/svn/trunk@14954 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 15:36:09 +00:00
commit-bot@chromium.org
c4be1462df re-enable downsample and filterbitmap GMs
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/301963003

git-svn-id: http://skia.googlecode.com/svn/trunk@14953 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 14:53:24 +00:00
commit-bot@chromium.org
0e59c3a2e7 rebaselines for ignored filterbitmap / downsamplebitmap tests
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/305933002

git-svn-id: http://skia.googlecode.com/svn/trunk@14952 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 14:42:32 +00:00
bsalomon@google.com
5bf38e24ca Rebaseline GMs with missing expectated images and shadertext2 msaa
Review URL: https://codereview.chromium.org/308673002

git-svn-id: http://skia.googlecode.com/svn/trunk@14950 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 14:27:16 +00:00
commit-bot@chromium.org
0a92d8e1dc ignore failing pdf-native for shadertext
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/304923002

git-svn-id: http://skia.googlecode.com/svn/trunk@14949 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 14:05:56 +00:00
commit-bot@chromium.org
f87f1e31c5 rebaselines for shadertext after unitmapper removal
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/308653002

git-svn-id: http://skia.googlecode.com/svn/trunk@14948 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 13:56:19 +00:00
commit-bot@chromium.org
7ac83bb9d6 ignore failures for acutals that never appear
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/304153003

git-svn-id: http://skia.googlecode.com/svn/trunk@14947 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 13:43:05 +00:00
bsalomon@google.com
050b3b8075 Massive rebaseline of gpu images after matrix change.
Review URL: https://codereview.chromium.org/304153002

git-svn-id: http://skia.googlecode.com/svn/trunk@14946 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 13:30:42 +00:00
commit-bot@chromium.org
537326089e git cl dcommit# Enter a description of the change.
shadertext2 rebaselines

TBR=
NOTRY=True
NOTREECHECKS=True

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/305853002

git-svn-id: http://skia.googlecode.com/svn/trunk@14943 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 01:03:18 +00:00
commit-bot@chromium.org
940aa237bb rebaseline #5 for shadertext2
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/305603005

git-svn-id: http://skia.googlecode.com/svn/trunk@14937 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 21:32:25 +00:00
commit-bot@chromium.org
f263f34b20 yet more rebaselines for shadertext and mandrills
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/302953002

git-svn-id: http://skia.googlecode.com/svn/trunk@14936 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 21:14:31 +00:00
commit-bot@chromium.org
c950ee6a52 more rebaselines for shadertext2 and stroketext and a couple of mandrills
TBR=epoger
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/303693013

git-svn-id: http://skia.googlecode.com/svn/trunk@14935 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 21:00:53 +00:00
commit-bot@chromium.org
77cb589a3d more rebaselines for shadertext
TBR=epoger
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/302433017

git-svn-id: http://skia.googlecode.com/svn/trunk@14927 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 19:25:08 +00:00
commit-bot@chromium.org
e9ba81f43a rebaseline shadertext2 shadertext3 and stroketext (sans 2)
NOTRY=True
TBR=epoger

Author: reed@google.com

Review URL: https://codereview.chromium.org/304763003

git-svn-id: http://skia.googlecode.com/svn/trunk@14924 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 18:49:15 +00:00
commit-bot@chromium.org
fa95b26b7a rename ignored tests
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=true
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/304533008

git-svn-id: http://skia.googlecode.com/svn/trunk@14922 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 18:05:42 +00:00
commit-bot@chromium.org
f449156bd0 Make image scaling have floating point scales. Third attempt to land this
due to some struggles with the CQ.  Original CL here:

https://codereview.chromium.org/298243003/

BUG=
R=bsalomon@google.com, epoger@google.com
TBR=bsalomon, epoger

Author: humper@google.com

Review URL: https://codereview.chromium.org/300113008

git-svn-id: http://skia.googlecode.com/svn/trunk@14920 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 17:30:02 +00:00
bsalomon@google.com
d4c5f2f1bf Followup GM rebaselines for non-GPU configs after removing tests from ignored-tests.txt
Review URL: https://codereview.chromium.org/303693012

git-svn-id: http://skia.googlecode.com/svn/trunk@14919 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 17:25:02 +00:00
bsalomon@google.com
025e6d53d7 Take care of a bunch of pending GPU rebaselines and remove tests from ignored-tests.txt
Review URL: https://codereview.chromium.org/300863006

git-svn-id: http://skia.googlecode.com/svn/trunk@14918 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 16:41:21 +00:00
commit-bot@chromium.org
fdf2c55fe1 Add another expectation for bug with perspective gpu
BUG=skia:2605
R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/301593006

git-svn-id: http://skia.googlecode.com/svn/trunk@14900 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 17:31:25 +00:00
commit-bot@chromium.org
e8765c4654 rebaseline simpleblurroundrect
BUG=
TBR=bsalomon

Author: humper@google.com

Review URL: https://codereview.chromium.org/300833002

git-svn-id: http://skia.googlecode.com/svn/trunk@14895 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 15:28:03 +00:00
commit-bot@chromium.org
212b211ce8 Update expectations for etc1bitmap
R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/300063007

git-svn-id: http://skia.googlecode.com/svn/trunk@14893 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 15:04:57 +00:00
commit-bot@chromium.org
778873acdb rather than committing new unreviewed expectations, just ignore the failures
This way, subsequent runs of the bots will try to re-upload the image file.  (They don't try to upload images for passing tests.)

BUG=skia:2603
NOTREECHECKS=True
NOTRY=True
R=fmalita@google.com
TBR=fmalita

Author: epoger@google.com

Review URL: https://codereview.chromium.org/297853007

git-svn-id: http://skia.googlecode.com/svn/trunk@14879 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 19:22:13 +00:00
commit-bot@chromium.org
f21991b104 Revert of Modify sample buffer size for larger displays. (https://codereview.chromium.org/240433002/)
Reason for revert:
This also changes verylargebitmap, and the difference appears to be meaningful. Henrik, I have emailed you the images that differ.

Original issue's description:
> Modify sample buffer size for larger displays.
>
> Increases the intermediate buffer size for sample pixel indexes,
> used in the sample proc function calls. If the operation is bigger
> than the buffer it's split into multiple calls, creating overhead.
> This would especially impact the performance of SIMD optimizations.
> Also, aligns the start address of the buffer to 16 bytes, to enable
> more efficient SIMD optimizations.
>
> Author: henrik.smiding@intel.com
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: http://code.google.com/p/skia/source/detail?r=14825
>
> Committed: http://code.google.com/p/skia/source/detail?r=14872

R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, bsalomon@chromium.org, bsalomon@google.com, henrik.smiding@intel.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/294023016

git-svn-id: http://skia.googlecode.com/svn/trunk@14878 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 19:13:56 +00:00
commit-bot@chromium.org
334ec00234 Revert of Suppress more GMs pending rebaseline after 0533146d00 (https://codereview.chromium.org/296173009/)
Reason for revert:
The CL for which these were added needs to be reverted. The best example of its breakage is in verylargebitmap.

Original issue's description:
> Suppress more GMs pending rebaseline after 0533146d00
>
> TBR=scroggo@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=14874

R=fmalita@chromium.org
TBR=fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/298973008

git-svn-id: http://skia.googlecode.com/svn/trunk@14877 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 19:09:46 +00:00
commit-bot@chromium.org
446aefe2af instead of ignoring testimagefilters EVERYWHERE, just ignore particular failures
BUG=skia:2603
NOTREECHECKS=True
NOTRY=True
R=fmalita@google.com
TBR=fmalita

Author: epoger@google.com

Review URL: https://codereview.chromium.org/296213009

git-svn-id: http://skia.googlecode.com/svn/trunk@14876 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 19:08:17 +00:00
fmalita@google.com
720b703ee7 Suppress testimagefilters GM.
Failing on Android, but results missing.

BUG=skia:2603
TBR=epoger@google.com

Review URL: https://codereview.chromium.org/299143006

git-svn-id: http://skia.googlecode.com/svn/trunk@14875 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 18:44:21 +00:00
fmalita@google.com
af6d1701f9 Suppress more GMs pending rebaseline after 0533146d00
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/296173009

git-svn-id: http://skia.googlecode.com/svn/trunk@14874 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 18:34:18 +00:00
commit-bot@chromium.org
0533146d00 Modify sample buffer size for larger displays.
Increases the intermediate buffer size for sample pixel indexes,
used in the sample proc function calls. If the operation is bigger
than the buffer it's split into multiple calls, creating overhead.
This would especially impact the performance of SIMD optimizations.
Also, aligns the start address of the buffer to 16 bytes, to enable
more efficient SIMD optimizations.

Author: henrik.smiding@intel.com

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>

Committed: http://code.google.com/p/skia/source/detail?r=14825

R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, scroggo@google.com, bsalomon@chromium.org, bsalomon@google.com

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/240433002

git-svn-id: http://skia.googlecode.com/svn/trunk@14872 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 16:05:43 +00:00
commit-bot@chromium.org
a3746a0f41 (bad) rebaselines for shader change
TBR=halcanary
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/296983013

git-svn-id: http://skia.googlecode.com/svn/trunk@14871 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 16:01:31 +00:00
commit-bot@chromium.org
f757fd3238 rebaseline after unitmapper shader change
TBR=epoger
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/294973012

git-svn-id: http://skia.googlecode.com/svn/trunk@14868 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 13:55:44 +00:00
commit-bot@chromium.org
c93e68161f fix the visual diff of raster vs gpu -- vertices_80. The sw-raster is correct, all images are blurry.
While some images generated by gpu doesn't respect SkPaint's alpha value.

In gpu path, when pass SkPaint's alpha and color to GrPaint by SkPaint2GrPaintNoShader,
either alpha or colors can't not be passed. We can't pass both of them by the API.
Premultiply paint's alpha to colors's alpha in drawVertices, and pass colors to GrPaint.
The rendering result will respect colors in drawVertices, and the alpha value set in SkPaint as well.

BUG=skia:2592
R=bsalomon@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/292943002

git-svn-id: http://skia.googlecode.com/svn/trunk@14863 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-23 08:09:26 +00:00
commit-bot@chromium.org
74266814a0 update stroketext gm
TBR=bungeman

Author: reed@google.com

Review URL: https://codereview.chromium.org/293983016

git-svn-id: http://skia.googlecode.com/svn/trunk@14848 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-22 17:41:41 +00:00
bsalomon@google.com
df1d83d786 Rebaseline two GMs that subtly changed in perspective after convexity fix.
BUG=skia:

Review URL: https://codereview.chromium.org/292983015

git-svn-id: http://skia.googlecode.com/svn/trunk@14847 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-22 17:06:31 +00:00
commit-bot@chromium.org
83f23d87f1 Remove unused (by clients) SkUnitMapper
This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98.

TBR=scroggo

Author: reed@google.com

Review URL: https://codereview.chromium.org/288313009

git-svn-id: http://skia.googlecode.com/svn/trunk@14842 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-22 12:27:41 +00:00
commit-bot@chromium.org
3339ac54a5 Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (https://codereview.chromium.org/288343009/)
Reason for revert:
required blink change failed to land

Original issue's description:
> Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
>
> This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14830

R=scroggo@google.com, reed@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/296823008

git-svn-id: http://skia.googlecode.com/svn/trunk@14838 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-22 02:55:59 +00:00
commit-bot@chromium.org
4b8f802255 Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.

BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/288343009

git-svn-id: http://skia.googlecode.com/svn/trunk@14830 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-21 19:56:46 +00:00
reed@google.com
b03be0b887 Revert "Modify sample buffer size for larger displays."
This reverts commit dd72f3bd0d500b9b3f900bcb8e904161ee51eae5.

git-svn-id: http://skia.googlecode.com/svn/trunk@14827 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-21 16:38:43 +00:00
commit-bot@chromium.org
af159a580b Modify sample buffer size for larger displays.
Increases the intermediate buffer size for sample pixel indexes,
used in the sample proc function calls. If the operation is bigger
than the buffer it's split into multiple calls, creating overhead.
This would especially impact the performance of SIMD optimizations.
Also, aligns the start address of the buffer to 16 bytes, to enable
more efficient SIMD optimizations.

Author: henrik.smiding@intel.com

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>

R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, scroggo@google.com, bsalomon@chromium.org, bsalomon@google.com

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/240433002

git-svn-id: http://skia.googlecode.com/svn/trunk@14825 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-21 15:16:15 +00:00
commit-bot@chromium.org
bbdfe29a17 Rebaseline Alex/Debug for FP math with SSE.
BUG=skia:

NOTREECHECKS=true
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/297703003

git-svn-id: http://skia.googlecode.com/svn/trunk@14815 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-20 22:31:46 +00:00
commit-bot@chromium.org
a3e7c18027 Rebaseline Alex/Release for FP math with SSE.
BUG=skia:

NOTREECHECKS=true
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/298793002

git-svn-id: http://skia.googlecode.com/svn/trunk@14814 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-20 20:48:23 +00:00
commit-bot@chromium.org
7bdd6b5118 Rebase 32-bit Linux GMs now that they use SSE for FP math.
BUG=skia:

NOTREECHECKS=true
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/297683006

git-svn-id: http://skia.googlecode.com/svn/trunk@14813 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-20 20:29:04 +00:00
bsalomon@google.com
fc9eef4b43 rebaseline pictureshader GM on GPU
Review URL: https://codereview.chromium.org/294103003

git-svn-id: http://skia.googlecode.com/svn/trunk@14810 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-20 18:57:34 +00:00
commit-bot@chromium.org
9927bd355f Centralize decision about whether to do bicubic filtering, and fallbacks to mip, bilerp, or nearest
R=robertphillips@google.com, humper@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/282293004

git-svn-id: http://skia.googlecode.com/svn/trunk@14809 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-20 17:51:13 +00:00
commit-bot@chromium.org
93d5355447 Rebaseline poppler (for me) and pictureshader/bleed on GPU (for Brian).
BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/284313009

git-svn-id: http://skia.googlecode.com/svn/trunk@14805 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-20 17:05:45 +00:00
commit-bot@chromium.org
4297430b93 Rebaselines for gpu dashing
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/291893004

git-svn-id: http://skia.googlecode.com/svn/trunk@14796 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-20 13:43:34 +00:00
commit-bot@chromium.org
7ba1702bbb fix off-by-one error in texture coordinate calculations for rrect gpu
blur; output now matches CPU

BUG=
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/292773003

git-svn-id: http://skia.googlecode.com/svn/trunk@14788 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-19 18:51:05 +00:00
commit-bot@chromium.org
628ed0b220 Add Dashing gpu effect for simple dashed lines
BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/274673004

git-svn-id: http://skia.googlecode.com/svn/trunk@14775 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-19 14:32:49 +00:00
commit-bot@chromium.org
e2b193ca5c Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
Reason for revert:
does not address all legacy callsites in chrome.

e.g.

[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919]            gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));


Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761

R=robertphillips@google.com, scroggo@google.com, george@mozilla.com
TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/287063009

git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-16 13:49:08 +00:00
commit-bot@chromium.org
dbe0cd13a0 Rebase for https://codereview.chromium.org/283803003/
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/291483008

git-svn-id: http://skia.googlecode.com/svn/trunk@14762 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-16 13:47:56 +00:00
commit-bot@chromium.org
ee0cac336c remove unused (by clients) SkUnitMapper
BUG=skia:
R=robertphillips@google.com, scroggo@google.com, george@mozilla.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/283273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14761 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-16 13:35:01 +00:00
commit-bot@chromium.org
36b3d34ef2 update canvas-layer-state (which should be deleted soon)
R=reed@android.com
TBR=reed
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/274133002

git-svn-id: http://skia.googlecode.com/svn/trunk@14671 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 14:39:26 +00:00
commit-bot@chromium.org
063e6b40a3 commit GM actuals as expectations for all tests, marking them as unreviewed
BUG=skia:1578
NOTRY=True
R=caryclark@google.com
TBR=caryclark

Author: epoger@google.com

Review URL: https://codereview.chromium.org/279773003

git-svn-id: http://skia.googlecode.com/svn/trunk@14668 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 14:16:11 +00:00
commit-bot@chromium.org
a17773f0b0 Disable filtering in draw Bitmap operation when pixels are aligned
The check is now performed in the callers of internalDrawBitmap() to
avoid retrieve the texture with wrong filter mode when the pixels were
aligned.

This bug was spotted in Chrome for Android: Chrome for Androids's
Canvas drawImage loses fidelity in canvases larger than 64k pixels.

BUG=chromium:231916

R=bsalomon@google.com, robertphillips@google.com

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>

Author: siglesias@igalia.com

Review URL: https://codereview.chromium.org/264303008

git-svn-id: http://skia.googlecode.com/svn/trunk@14665 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 13:53:38 +00:00
commit-bot@chromium.org
263918ca01 update Test-Linux-Bare-NoGPU-Arm8_64-Debug expectations
R=djsollen@google.com
TBR=djsollen
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/276893002

git-svn-id: http://skia.googlecode.com/svn/trunk@14664 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 12:00:19 +00:00
djsollen@google.com
80b1d031ba Disable broken GMs on Nexus 4.
BUG=skia:2528
R=humper@google.com

Review URL: https://codereview.chromium.org/272633002

git-svn-id: http://skia.googlecode.com/svn/trunk@14619 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-07 17:22:36 +00:00
commit-bot@chromium.org
6803c219dd Revert of fix the error that path is inversed for stroke and strokeAndFill styles (https://codereview.chromium.org/183683010/)
R=bsalomon@google.com, reed@google.com, yunchao.he@intel.com
TBR=reed@google.com
NOTRY=True

Reason for revert:
broke unittests

Original issue's description:
> fix the error that path is inversed for stroke and strokeAndFill styles.
>
> However, because hairline stroke + fill = fill (see src/core/SkStrokeRec.cpp), strokeAndFill will be thought as fill style when paint.getStrokeWidth() <= 0, this edge case can be inverse-filled.
>
> BUG=skia:2222
>
> Committed: http://code.google.com/p/skia/source/detail?r=14561

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/269903002

git-svn-id: http://skia.googlecode.com/svn/trunk@14562 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-04 18:08:27 +00:00
commit-bot@chromium.org
1f99d933e5 fix the error that path is inversed for stroke and strokeAndFill styles.
However, because hairline stroke + fill = fill (see src/core/SkStrokeRec.cpp), strokeAndFill will be thought as fill style when paint.getStrokeWidth() <= 0, this edge case can be inverse-filled.

BUG=skia:2222
R=bsalomon@google.com, reed@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/183683010

git-svn-id: http://skia.googlecode.com/svn/trunk@14561 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-04 03:43:20 +00:00
commit-bot@chromium.org
d8e0afde0b mark flaky GM tests as ignore-failure
followup to https://codereview.chromium.org/265043002 ('commit GM actuals as expectations for all tests, marking them as unreviewed')

BUG=skia:2332
NOTREECHECKS=True
NOTRY=True
R=djsollen@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/269763003

git-svn-id: http://skia.googlecode.com/svn/trunk@14546 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-02 20:26:01 +00:00
commit-bot@chromium.org
82bc432683 re-enable simpleblurroundrect gm now that all the rebaselines have landed
BUG=skia:
R=djsollen@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/268763004

git-svn-id: http://skia.googlecode.com/svn/trunk@14542 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-02 18:00:58 +00:00
commit-bot@chromium.org
daf48e02ad commit GM actuals as expectations for all tests, marking them as unreviewed
BUG=skia:1578
NOTREECHECKS=True
NOTRY=True
R=reed@google.com
TBR=reed

Author: epoger@google.com

Review URL: https://codereview.chromium.org/265043002

git-svn-id: http://skia.googlecode.com/svn/trunk@14532 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-02 14:57:25 +00:00
bsalomon@google.com
5d0c0bfbbe Add initial baselines for discard GM
Review URL: https://codereview.chromium.org/267763003

git-svn-id: http://skia.googlecode.com/svn/trunk@14528 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-02 14:12:54 +00:00
bungeman@google.com
89457e7146 Rebaselines for r14518 (Add support for kEmbeddedBitmapText_Flag to DirectWrite.)
git-svn-id: http://skia.googlecode.com/svn/trunk@14523 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 22:37:56 +00:00
commit-bot@chromium.org
1d146d431a Revert of Roll ANGLE. (https://codereview.chromium.org/237173002/)
Reason for revert:
breaking the buildbots (see http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Release-ANGLE/builds/3198).

NOTRY=true

Original issue's description:
> Roll ANGLE.
>
> BUG=skia:2272
>
> Committed: http://code.google.com/p/skia/source/detail?r=14243
>
> Committed: http://code.google.com/p/skia/source/detail?r=14509

R=bsalomon@chromium.org, bsalomon@google.com, geofflang@chromium.org, djsollen@google.com, mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/264733006

git-svn-id: http://skia.googlecode.com/svn/trunk@14517 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 20:20:50 +00:00
commit-bot@chromium.org
f096afcd82 rebaseline simpleblurroundrect
BUG=skia:
TBR=epoger

Author: humper@google.com

Review URL: https://codereview.chromium.org/269573007

git-svn-id: http://skia.googlecode.com/svn/trunk@14510 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 19:22:41 +00:00
commit-bot@chromium.org
1267219c53 Roll ANGLE.
BUG=skia:2272

Committed: http://code.google.com/p/skia/source/detail?r=14243

R=bsalomon@chromium.org, bsalomon@google.com

Author: geofflang@chromium.org

Review URL: https://codereview.chromium.org/237173002

git-svn-id: http://skia.googlecode.com/svn/trunk@14509 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 19:22:22 +00:00
commit-bot@chromium.org
47f9419760 Revert of re-enable simpleblurroundrect gm (https://codereview.chromium.org/263823002/)
Reason for revert:
broken rebaseline.

Original issue's description:
> re-enable simpleblurroundrect gm
>
> BUG=skia:
> TBR=caryclark
>
> Committed: http://code.google.com/p/skia/source/detail?r=14498

R=caryclark@google.com
TBR=caryclark@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: humper@google.com

Review URL: https://codereview.chromium.org/265863002

git-svn-id: http://skia.googlecode.com/svn/trunk@14500 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 15:18:06 +00:00
commit-bot@chromium.org
4363a66662 re-enable simpleblurroundrect gm
BUG=skia:
R=caryclark@google.com
TBR=caryclark

Author: humper@google.com

Review URL: https://codereview.chromium.org/263823002

git-svn-id: http://skia.googlecode.com/svn/trunk@14498 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 14:38:45 +00:00
commit-bot@chromium.org
9be9034e64 Rename expectations for Valgrind bot: ATI5770->GTX550Ti
This will likely cause GM failures, since the GPU has changed.

BUG=skia:2506
R=caryclark@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/265773004

git-svn-id: http://skia.googlecode.com/svn/trunk@14493 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-01 12:32:39 +00:00
senorblanco@chromium.org
374a6e7427 Rebaseline tileimagefilter on IntelRhb post-r14432.
TBR=caryclark@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/267573004

git-svn-id: http://skia.googlecode.com/svn/trunk@14490 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 21:46:38 +00:00
commit-bot@chromium.org
618bb5269f remove inverse_paths from ignored tests
new expectations have been checked in

https://codereview.chromium.org/264653003

R=reed@android.com
TBR=reed
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/265453009

git-svn-id: http://skia.googlecode.com/svn/trunk@14477 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 16:34:43 +00:00
commit-bot@chromium.org
2d0c75c534 unsuppress inverse_paths gm images
R=reed@android.com
TBR=reed
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/264653003

git-svn-id: http://skia.googlecode.com/svn/trunk@14475 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 16:15:49 +00:00
commit-bot@chromium.org
c4d297398a refresh expectations for android intel conical gradients
TBR=reed
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/260513005

git-svn-id: http://skia.googlecode.com/svn/trunk@14469 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 15:29:53 +00:00
commit-bot@chromium.org
87bbefda9d un-ignore image-surface GM results
NOTRY=True
TBR=reed@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/264623004

git-svn-id: http://skia.googlecode.com/svn/trunk@14468 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 15:22:47 +00:00
senorblanco@chromium.org
6ef2d23cb0 New Ubuntu baselines for tileimagefilter GM post-r14432.
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/254323003

git-svn-id: http://skia.googlecode.com/svn/trunk@14467 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 15:18:53 +00:00
commit-bot@chromium.org
601207aa55 rebaseline but with known incorrectness
BUG=skia:2497
NOTRY=True
TBR=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/266473006

git-svn-id: http://skia.googlecode.com/svn/trunk@14466 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 15:17:01 +00:00
commit-bot@chromium.org
f10aa51196 rebaseline GM changes to image-surface
NOTRY=True
TBR=caryclark@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/254283003

git-svn-id: http://skia.googlecode.com/svn/trunk@14465 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 14:59:38 +00:00
senorblanco@chromium.org
83ad45ae3a New baselines for tileimagefilter GM after r14432.
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/260753002

git-svn-id: http://skia.googlecode.com/svn/trunk@14462 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 14:35:57 +00:00
commit-bot@chromium.org
b8b8b6d151 remove rebaselined tests from ignore file
this removes the lines corresponding to this rebaseline CL

Change committed as 14447

https://codereview.chromium.org/263473002/

R=reed@android.com
TBR=reed
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/262583005

git-svn-id: http://skia.googlecode.com/svn/trunk@14461 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 14:33:04 +00:00
senorblanco@chromium.org
d3571ed359 Rebaselines post-r14433.
Update testimagefilters GM on SGX540 GPU and matrixconvolution GM on
Win7 (perspective).

TBR=caryclark@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/261533004

git-svn-id: http://skia.googlecode.com/svn/trunk@14459 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 14:11:29 +00:00
commit-bot@chromium.org
2e21823e64 update yunchao suppressed expectations
R=reed@android.com
TBR=reed
NOTRY=true
NOTREECHECK=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/263473002

git-svn-id: http://skia.googlecode.com/svn/trunk@14447 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-29 20:44:12 +00:00
commit-bot@chromium.org
d9a9628e9e Rename expectations for renamed bots (Ubuntu13.10)
BUG=skia:2449
NOTRY=true
R=epoger@google.com
TBR=epoger

Author: borenet@google.com

Review URL: https://codereview.chromium.org/259263002

git-svn-id: http://skia.googlecode.com/svn/trunk@14436 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-29 15:56:36 +00:00
senorblanco@chromium.org
0a5c233e3b Implement bounds traversals for tile and matrix convolution filters.
Add a new GM that exercises tiled drawing all pixel-moving filters
(and some non-pixel-moving ones) and compares it against non-tiled
drawing of the same filters. Fixing this test revealed that tile and
matrix convolution filters had no onFilterBounds() traversals
(test-driven development FTW). Tile requires (conservatively) the
bounds to include the whole source rect, since it may end up in the
result. Matrix convolution requires the bounds to be offset by the
kernel size and target.

R=reed@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/258243005

git-svn-id: http://skia.googlecode.com/svn/trunk@14432 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-29 15:20:39 +00:00
commit-bot@chromium.org
4efe1fa672 fix android logal gm for filltypespersp
BUG=skia:
NOTRY=true
TBR=borenet

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/253743005

git-svn-id: http://skia.googlecode.com/svn/trunk@14423 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 20:34:48 +00:00
commit-bot@chromium.org
3d8bf232bd Fast path for blurred round rects -- blur a small 9patch rect on the CPU
And nonlinearly stretch the resulting texture across proxy geometry.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=14392

Committed: http://code.google.com/p/skia/source/detail?r=14404

R=bsalomon@google.com, reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/248613004

git-svn-id: http://skia.googlecode.com/svn/trunk@14420 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 19:49:24 +00:00
commit-bot@chromium.org
55aec08681 revert humper changes
https://skia.googlesource.com/skia.git/+/24e91ba3029a3a1fb60cab3ae4e68c3c44776f25

https://skia.googlesource.com/skia.git/+/a36c78240e14aeb130a97c43f3992ea19696b929

NOTREECHECKS=true

BUG=skia:
R=caryclark@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/256803011

git-svn-id: http://skia.googlecode.com/svn/trunk@14414 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 18:21:24 +00:00
commit-bot@chromium.org
8d0a32c622 update expectations on linux bots that have recently come on line
BUG=skia:
R=borenet@google.com
TBR=borenet
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/250803019

git-svn-id: http://skia.googlecode.com/svn/trunk@14412 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 16:26:47 +00:00
commit-bot@chromium.org
a36c78240e spelling fix
BUG=skia:
R=caryclark@google.com
TBR=caryclark

Author: humper@google.com

Review URL: https://codereview.chromium.org/259043002

git-svn-id: http://skia.googlecode.com/svn/trunk@14409 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 16:02:23 +00:00