Jim Van Verth
25c0fc8bdb
Viewer doc cleanup.
...
No-Try: true
Docs-Preview: https://skia.org/?cl=75360
Change-Id: I915ae012e0f80ac2595ec9088ae8339b337e860e
Reviewed-on: https://skia-review.googlesource.com/75360
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2017-11-22 15:55:04 +00:00
Jim Van Verth
3ca9a0db91
Update Viewer docs.
...
Also deletes SampleApp docs.
No-Try: true
Docs-Preview: https://skia.org/?cl=74700
Change-Id: Ida594d12db9ea38fdd7d91a920ed1cc7afd04e0d
Reviewed-on: https://skia-review.googlesource.com/74700
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2017-11-22 13:53:34 +00:00
Ben Wagner
bb68066cfd
Remove Skolo NVIDIA Linux bots.
...
Docs-Preview: https://skia.org/?cl=74160
No-Try: true
Change-Id: Icb3a8ac00e640de345f4fbed89642bee569bbe9b
Reviewed-on: https://skia-review.googlesource.com/74160
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
2017-11-21 19:43:09 +00:00
Hal Canary
c60dea17d8
style nit: s/RIGHT SINGLE QUOTATION MARK/APOSTROPHE/g when apropriate
...
Change-Id: If834febee09266cad6a7a2fb64b06adc25790e33
Reviewed-on: https://skia-review.googlesource.com/73742
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-11-20 19:09:18 +00:00
Ben Wagner
e580649a38
Update doc and example for SkPaint::FontMetrics.
...
The underline position is actually the top of the underline. Also
clarify that the strike through position is the bottom of the strike
through.
This adds documentation that the values are always y-down in a way that
will end up in the SkPaint header file for those who look for
information there.
Change-Id: I40281c0e47557d23291b6a91474e2d3e3b37f09f
Docs-Preview: https://skia.org/user/api/SkPaint_Reference?cl=69361#FontMetrics
Reviewed-on: https://skia-review.googlesource.com/69361
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2017-11-09 18:20:14 +00:00
Ben Wagner
700ff17125
Bookmaker to work on Linux.
...
This also updates one fiddle example which used SkTypeface::kBold, which
is now private.
Change-Id: I799b64bfaa377d02f0a045d2f077410d4f38413d
Reviewed-on: https://skia-review.googlesource.com/68902
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2017-11-08 21:07:27 +00:00
Ravi Mistry
75a1377e54
Add section for how to connect to Skia swarming bots
...
No-Try: true
Docs-Preview: https://skia.org/?cl=67849
Bug: skia:7098
Change-Id: Ib603bdd2117aab6f626cd68e26529d277a0f1508
Reviewed-on: https://skia-review.googlesource.com/67849
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-11-07 01:51:32 +00:00
Mike Klein
97f0bc6a1a
clean up cruft about --portableFonts and --resourceFonts
...
--portableFonts exists but does nothing.
--resourceFonts doesn't even exist.
Change-Id: I7880208de4aaa9674ba720b9e70c34c145561ac0
Reviewed-on: https://skia-review.googlesource.com/67800
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2017-11-06 15:09:09 +00:00
Cary Clark
2ade997831
filling holes in canvas doc
...
filling holes in canvas doc
Docs-Preview: https://skia.org/?cl=66920
TBR=caryclark@google.com
Bug: skia:6898
Change-Id: I3a211df5f19ecfbfa0bb060bb6d55005a38cd360
Reviewed-on: https://skia-review.googlesource.com/66920
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2017-11-02 22:10:53 +00:00
Kevin Lubick
8be4a33005
Add instructions for building Skia for Chromebooks
...
No-Try: true
Docs-Preview: https://skia.org/?cl=66561
Bug: skia:
Change-Id: Ie4d74eea74a48b5177daefc45498bf67334daf2f
Reviewed-on: https://skia-review.googlesource.com/66561
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 16:34:41 +00:00
Cary Clark
d49980c435
streamline doc menus
...
No-Try: true
Docs-Preview: https://skia.org/?cl=66145
Bug: skia:6898
Change-Id: I11acd8c17db5faa833ca38550d82819e799dd311
Reviewed-on: https://skia-review.googlesource.com/66145
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-11-01 14:23:50 +00:00
Cary Clark
bef063af14
cataloger
...
Docs-Preview: https://skia.org/?cl=64900
Bug: skia:6898
Change-Id: Ifbaf909854680a88060f16b1559863cc124aaa7a
Reviewed-on: https://skia-review.googlesource.com/64900
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-10-31 20:09:25 +00:00
Cary Clark
cfee6ecf5d
fix matrix order bug
...
corrected matrix illustration for SkMatrix::MakeTrans
Docs-Preview: https://skia.org/?cl=64120
Bug: skia:6898
Change-Id: Iec8ceae6893598919349b24197f30727be892a37
Reviewed-on: https://skia-review.googlesource.com/64120
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-10-26 16:47:07 +00:00
Cary Clark
154beea859
Add docs for SkMatrix, SkRect, SkIRect, SkBitmap
...
Also minor changes to earlier docs.
Many small changes to improve indentation in generated includes.
Added support for matrix math illustrations.
Docs-Preview: https://skia.org/?cl=58500
Bug: skia:6898
Change-Id: I7da58ad55f82d7fd41d19288beb2cd71730fb01f
Reviewed-on: https://skia-review.googlesource.com/58500
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-10-26 12:17:36 +00:00
Ben Wagner
b2fd61a058
Move most remaining ANGLE bots to Clang.
...
Sort job names.
Docs-Preview: https://skia.org/?cl=63080
No-Try: true
Change-Id: Ia72c055c4ddb903063b8a4be5ebd6ba92fc8b6d6
Reviewed-on: https://skia-review.googlesource.com/63080
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-24 18:01:21 +00:00
Eric Boren
c7bdefa80d
Add a segment about bin/try to the site docs
...
No-Try: true
Docs-Preview: https://skia.org/?cl=60586
Bug: skia:
Change-Id: I8169d4199564380cc602e0c46a5d4fadd1c28dcb
Reviewed-on: https://skia-review.googlesource.com/60586
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-10-24 15:31:11 +00:00
Mike Klein
8fed655df8
fix libc++/MSAN instructions
...
Change-Id: I2305595eeacc6ed7f8b264b85d6a8c33823c77eb
Reviewed-on: https://skia-review.googlesource.com/61700
Reviewed-by: Yuqian Li <liyuqian@google.com>
2017-10-18 18:45:41 +00:00
Yuqian Li
a0dc0143f8
Update MSAN gn args to match our bots
...
The previous gn args would result in linking errors.
No-Try: true
Docs-Preview: https://skia.org/?cl=60761
Bug: skia:
Change-Id: Ia9e1472080484d29dfbc2f86728f10721c05856c
Reviewed-on: https://skia-review.googlesource.com/60761
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-10-18 18:19:05 +00:00
Cary Clark
884dd7d428
General clean up on bookmaker.
...
Command line runs without error for
SkBitmap, SkPath, SkRect, SkIRect,
SkPixmap, SkCanvas.
Docs-Preview: https://skia.org/?cl=57112
TBR: caryclark@google.com
Bug: skia:6898
Change-Id: I73b69ae8ffdf0a1e6bc187dc8a9dfb28f7766faa
Reviewed-on: https://skia-review.googlesource.com/57112
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2017-10-11 15:26:37 +00:00
Cary Clark
7fc1d12e67
first cut at SkRect, SkIRect documentation
...
All functions should have descriptions, examples, cross-references.
References and spelling have been checked.
More work to do creating and organizing topics.
Docs-Preview: https://skia.org/?cl=56140
Tbr: caryclark@google.com
Bug: skia:6898
Change-Id: I9d1e55d04ab64874c33cac8b91534aa192c2f545
Reviewed-on: https://skia-review.googlesource.com/56140
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2017-10-09 19:36:14 +00:00
Cary Clark
bc5697d3b1
starting next gaggle of docs
...
starting next gaggle of docs
Docs-Preview: https://skia.org/?cl=50264
Bug: skia:6898
Change-Id: I639795b55c0c96b2efccac13cb67592f055a75a2
Reviewed-on: https://skia-review.googlesource.com/50264
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-10-04 18:50:33 +00:00
Ben Wagner
172c6bd8e9
Add more detail to Swarming bot doc.
...
No-Try: true
Docs-Preview: https://skia.org/?cl=54561
Change-Id: Id7bcccf1ffa7b1726bc5f9394178a629078b1225
Reviewed-on: https://skia-review.googlesource.com/54561
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-10-04 16:31:33 +00:00
Ben Wagner
05572fa6e7
Update docs on Skia bots.
...
No-Try: true
Docs-Preview: https://skia.org/?cl=52163
Change-Id: I2bcd73bc7597219e4748c28e9120b5138a0eb3d1
Reviewed-on: https://skia-review.googlesource.com/52163
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-28 13:45:37 +00:00
Ravi Mistry
6f4c5d5a31
Update Skia trooper page
...
Highlights:
* Add link to the trooper handoff doc.
* Describe how to update trooper/sheriff/wrangler/robocop schedules.
* Add link to the trooper chrome extension.
* Remove things that appear to be no longer valid.
No-Try: true
Docs-Preview: https://skia.org/?cl=51803
Bug: skia:
Change-Id: I82cd2965836a7916f85ffc85c372b8a07b9628f5
Reviewed-on: https://skia-review.googlesource.com/51803
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-09-27 15:17:48 +00:00
Cary Clark
6fc5041adb
feedback
...
feedback from include review
Docs-Preview: https://skia.org/?cl=49260
Bug: skia: 6898
Change-Id: Ic60980dfe53d14fd8c6973ef2f4dabb6b650cdd8
Reviewed-on: https://skia-review.googlesource.com/49260
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-09-21 16:50:10 +00:00
Cary Clark
e4aa37128f
missing description for FontMetricFlags
...
rearrange class descriptions to make them
appear consistently inside the #Class
declaration in the .bmh files.
Look for the descriptions there and
regenerate the .md files.
Docs-Preview: https://skia.org/?cl=46523
TBR=caryclark@google.com
Bug: skia: 6898
Change-Id: I00a176428725ef27667d3f23d76d6b7ff0cfced1
Reviewed-on: https://skia-review.googlesource.com/46523
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-09-15 14:03:53 +00:00
Cary Clark
d0530ba8f4
wip pixmap docs
...
wip pixmap docs
Docs-Preview: https://skia.org/?cl=42522
Bug: skia: 6898
Change-Id: I85947bc36ea057ed008b87d7bef2efa82d7c89ad
Reviewed-on: https://skia-review.googlesource.com/42522
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2017-09-14 16:05:21 +00:00
Ravi Mistry
da669f1506
Add links to autoroller cloud logs for roboCops
...
No-Try: true
Docs-Preview: https://skia.org/?cl=42901
Change-Id: I065c69085a8b32e8ff25ab5667882067f26a38c9
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/42901
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-09-07 15:30:51 +00:00
Cary Clark
ce1012403b
bookmaker spelling with fixed linux build
...
Work on spell-checker
to identify errors and
isolate more concepts
requiring definitions.
fix linux build
Docs-Preview: https://skia.org/?cl=42103
Docs-Preview: https://skia.org/?cl=41180
Tbr: caryclark@google.com
Bug: skia: 6898
Change-Id: Id939b0c2915c22e0fa1b15623c1a56fbe9d4051d
Reviewed-on: https://skia-review.googlesource.com/42103
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
2017-09-01 20:10:51 +00:00
Cary Clark
e040384627
Revert "wip spelling mania"
...
This reverts commit da65a0489a
.
Reason for revert: fails to build on linux
Original change's description:
> wip spelling mania
>
> Work on spell-checker
> to identify errors and
> isolate more concepts
> requiring definitions.
>
> Docs-Preview: https://skia.org/?cl=41180
> TBR: reed@google.com
> Bug: skia: 6898
> Change-Id: I0759beb42eaf6095908a9bd7decfcd0026253609
> Reviewed-on: https://skia-review.googlesource.com/41180
> Reviewed-by: Cary Clark <caryclark@skia.org>
> Commit-Queue: Cary Clark <caryclark@skia.org>
TBR=caryclark@google.com ,caryclark@skia.org
Change-Id: I173e50ea5b51273cd316ac9964af3a498b5300e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia: 6898
Reviewed-on: https://skia-review.googlesource.com/42140
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
2017-09-01 19:21:40 +00:00
Cary Clark
da65a0489a
wip spelling mania
...
Work on spell-checker
to identify errors and
isolate more concepts
requiring definitions.
Docs-Preview: https://skia.org/?cl=41180
TBR: reed@google.com
Bug: skia: 6898
Change-Id: I0759beb42eaf6095908a9bd7decfcd0026253609
Reviewed-on: https://skia-review.googlesource.com/41180
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2017-09-01 18:19:37 +00:00
Brian Salomon
f43d0001e4
Revert "Revert "Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.""""
...
This reverts commit 6df4d6be0d
.
Reason for revert: Google3 fix landed
Original change's description:
> Revert "Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget."""
>
> This reverts commit 71554bc256
.
>
> Reason for revert: Google3
>
> Original change's description:
> > Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.""
> >
> > This reverts commit 807371c15b
.
> >
> > Docs-Preview: https://skia.org/?cl=40260
> > Change-Id: I28e0434c455155ff39a5aaa4141abdf442474e87
> > Reviewed-on: https://skia-review.googlesource.com/40260
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
> > Commit-Queue: Brian Salomon <bsalomon@google.com>
>
> TBR=egdaniel@google.com ,bsalomon@google.com
>
> Change-Id: Ifdfa896a70db69935473276d12dce54de5c6b6f7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/41500
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
TBR=egdaniel@google.com ,bsalomon@google.com
Change-Id: I827419bb19972c3644929a8c984bb9534baab0ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/41700
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-08-31 20:04:12 +00:00
Brian Osman
c3cdef5fb0
Add top-level trace markers for each benchmark
...
Also add new paragraph about using systrace correctly
Docs-Preview: https://skia.org/?cl=41502
Change-Id: I114c14cc2e87a8b72aec46d8c354d3ea877a41ab
Reviewed-on: https://skia-review.googlesource.com/41502
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-08-31 18:36:51 +00:00
Brian Salomon
6df4d6be0d
Revert "Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget."""
...
This reverts commit 71554bc256
.
Reason for revert: Google3
Original change's description:
> Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.""
>
> This reverts commit 807371c15b
.
>
> Docs-Preview: https://skia.org/?cl=40260
> Change-Id: I28e0434c455155ff39a5aaa4141abdf442474e87
> Reviewed-on: https://skia-review.googlesource.com/40260
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
TBR=egdaniel@google.com ,bsalomon@google.com
Change-Id: Ifdfa896a70db69935473276d12dce54de5c6b6f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/41500
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-08-31 15:57:42 +00:00
Brian Salomon
71554bc256
Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.""
...
This reverts commit 807371c15b
.
Docs-Preview: https://skia.org/?cl=40260
Change-Id: I28e0434c455155ff39a5aaa4141abdf442474e87
Reviewed-on: https://skia-review.googlesource.com/40260
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-08-30 17:59:46 +00:00
Cary Clark
a523d2d155
fix param return descriptions
...
enforce that param and return
descriptions are phrases (begin
with lower case, no trailing
period).
Docs-Preview: https://skia.org/?cl=40767
Bug: skia: 6898
Change-Id: Ib5f2a02441673f71c0780d81c5e4c61200a678e3
Reviewed-on: https://skia-review.googlesource.com/40767
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-08-30 13:16:12 +00:00
Cary Clark
73fa972d0b
work on path
...
Work on SkPath.h documentation; fixed self-consistency
bugs identified by bookmaker. Fixed a couple of
minor typos in SkPath.h itself.
Also brought SkPaint and SkCanvas docs up to date.
TBR=reed@google.com
Docs-Preview: https://skia.org/?cl=39040
Bug: skia: 6898
Change-Id: Id89d4e2fa7fb6ee2e3cbec7ea762e06308b67d8b
Reviewed-on: https://skia-review.googlesource.com/39040
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-08-30 11:06:02 +00:00
Cary Clark
493df1f9f3
try again to fix method links
...
generate method links from
fiddle names to keep them
consistent and unique.
Docs-Preview: https://skia.org/?cl=38727
Bug: skia:6898
Change-Id: I3434801b46002a3a9095e007d456e9e871307304
Reviewed-on: https://skia-review.googlesource.com/38727
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-08-25 17:32:57 +00:00
Cary Clark
8cc16c7fde
fix generated links
...
qualify bookmaker links to remove
file reference if intra-file and
add class reference if part of
a class
TBR=caryclark@google.com
Docs-Preview: https://skia.org/?cl=38722
Bug: skia: 6898
Change-Id: Ie0548485a6e3f596efc0f15b819bd5060e983a5b
Reviewed-on: https://skia-review.googlesource.com/38722
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2017-08-25 16:13:08 +00:00
Cary Clark
f05bddaac3
update canvas doc, primarily readpixels and writepixels
...
also fixed minor bookmaker bugs so canvas
include and online docs are (bookmaker detected)
error-free
TBR=reed@google.com
Docs-Preview: https://skia.org/?cl=37840
Bug: skia:
Change-Id: Ifcec9c751105444047c37d89fd984dbd4dfd1913
Reviewed-on: https://skia-review.googlesource.com/37840
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2017-08-24 18:00:33 +00:00
Joe Gregorio
a71e2ef412
Remove examples of now removed SkArcToPathEffect.
...
SkArcToPathEffect was removed in: https://skia-review.googlesource.com/25981
No-Try: true
Docs-Preview: https://skia.org/?cl=35442
Bug: skia:
Change-Id: I8fefa6730d8f1d3fdc5516d46ef706052d84b6bf
Reviewed-on: https://skia-review.googlesource.com/35442
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2017-08-16 18:38:15 +00:00
Heather Miller
3d35d14657
fix Vulkan doc typo
...
No-Try: true
Docs-Preview: https://skia.org/?cl=31463
Bug: skia:6923
Change-Id: I8dcb40a186dac59ca0ec684afff26c81e97bcc9c
Reviewed-on: https://skia-review.googlesource.com/31463
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
2017-08-07 16:53:19 +00:00
Cary Clark
4c06f5ee08
fix links and missing constructor
...
Docs-Preview: https://skia.org/?cl=31145
Bug: skia: 6898
Change-Id: Ic94a15551f3683d9de5d3bda53394d2efce0d6a4
Reviewed-on: https://skia-review.googlesource.com/31145
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-08-04 17:25:24 +00:00
Cary Clark
bad5ad7d60
canvas include checkpoint
...
All fixes to bookmaker to allow creating SkCanvas.h
Docs-Preview: https://skia.org/?cl=29022
TBR=caryclark@google.com
Bug: skia: 6898
Change-Id: If10638fbc77cfe680f21868c97f9c0643b87ebf9
Reviewed-on: https://skia-review.googlesource.com/29022
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2017-08-03 21:36:08 +00:00
Yuqian Li
ddea570db6
Fix typo XPS to SVG
...
No-Try: true
Docs-Preview: https://skia.org/?cl=30301
Bug: skia:
Change-Id: Ib96f9ec61f5959ccb968b60a0d22f9bedef9dc97
Reviewed-on: https://skia-review.googlesource.com/30301
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-08-02 20:53:36 +00:00
Yuqian Li
d301629d1d
Add links to Analytic AA design docs
...
No-Try: true
Docs-Preview: https://skia.org/?cl=28860
Bug: skia:
Change-Id: I19b4227bebba9070884b7dbf3530e6305e45aaf2
Reviewed-on: https://skia-review.googlesource.com/28860
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-07-31 18:36:13 +00:00
Cary Clark
12799e17d5
bookmaker generated site docs
...
The documents were generated by running
tools/bookmaker against docs/*.bmh
No-Try: true
Docs-Preview: https://skia.org/?cl=28002
Change-Id: I7d7dd73cdea4a234c6175646d5b8938e1af3117a
Reviewed-on: https://skia-review.googlesource.com/28002
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
2017-07-28 19:25:53 +00:00
Ben Wagner
713195071d
Remove internal use of SkTypeface::Style.
...
Change-Id: I71cf04b12be95a54b7fb47d048ba1f8672ed9a8f
Reviewed-on: https://skia-review.googlesource.com/27760
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-07-27 21:30:45 +00:00
Greg Daniel
02611d9afd
Add Make[backend] calls for creating GrContexts
...
Docs-Preview: https://skia.org/?cl=26369
Bug: skia:
Change-Id: I460ee63e466f85b05918479f068a2e5ca2d70550
Reviewed-on: https://skia-review.googlesource.com/26369
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-07-25 14:33:03 +00:00
Yuqian Li
8661248942
Translate index.md to Chinese
...
No-Try: true
Docs-Preview: https://skia.org/?cl=24083
Bug: skia:
Change-Id: I6b3aaabfda26c8e0472e1dd9d9d9db0f6deeca5b
Reviewed-on: https://skia-review.googlesource.com/24083
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-07-25 13:23:52 +00:00
Brian Osman
1627c04d86
Quick documentation of tracing support in our tools
...
No-Try: true
Docs-Preview: https://skia.org/?cl=26260
Bug: skia:
Change-Id: I3cf09f1c94cdc9551ece44da022ef2c2f374d6e4
Reviewed-on: https://skia-review.googlesource.com/26260
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-07-24 17:25:05 +00:00
Brian Salomon
807371c15b
Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget."
...
This reverts commit e2d37c2a07
.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.
>
> Also removes a reference to GrBackendTextureDesc in a comment and updates markdown docs.
>
> Docs-Preview: https://skia.org/?cl=24861
> Bug: skia:
> Change-Id: Ic6490d5ef46953450e6dee69271397bb2b94d0d6
> Reviewed-on: https://skia-review.googlesource.com/24861
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
TBR=egdaniel@google.com ,bsalomon@google.com,robertphillips@google.com
Change-Id: I4b85b529727f0bf5aec21d87e725a8195666e2e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/25182
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-07-20 20:48:23 +00:00
Brian Salomon
e2d37c2a07
Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.
...
Also removes a reference to GrBackendTextureDesc in a comment and updates markdown docs.
Docs-Preview: https://skia.org/?cl=24861
Bug: skia:
Change-Id: Ic6490d5ef46953450e6dee69271397bb2b94d0d6
Reviewed-on: https://skia-review.googlesource.com/24861
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2017-07-20 20:28:57 +00:00
Brian Osman
430e4c84e9
Some basic Flutter/Fuchsia docs
...
No-Try: true
Docs-Preview: https://skia.org/?cl=24406
Bug: skia:
Change-Id: I18ba9bf86b44b27262c9785cc0b5edbc982ae076
Reviewed-on: https://skia-review.googlesource.com/24406
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-07-19 13:17:54 +00:00
Hal Canary
7cbf5e3e03
SkPDF: simplify drawImage/Bitmap/Sprite code.
...
- SkImageSubset becomes SkKeyedImage
- SkPDFCanvas::onDraw{Bitmap, Image} go away
- Remove SkPDFCanvas: base classes now do the right thing.
- SkPDFDevice::draw{Bitmap,Image}{Rect,}() simplified
- 244 fewer SLOC.
All but a few PDFs are identical, those rasterize almost the same.
Change-Id: I3ceb3b8935c689719cedf1ad544b0407b5c1733e
Reviewed-on: https://skia-review.googlesource.com/22218
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2017-07-12 20:41:41 +00:00
Mike Klein
c55a6cb05f
build regenerating SkJumper stages into GN
...
I _think_ this makes it so changes to _stages.cpp or _lowp.cpp get
noticed, regenerated, and baked into Skia all in the same Ninja
invocation.
Now you just need to set up the tools we use in GN:
skia_jumper_clang = ...
skia_jumper_objdump = ...
skia_jumper_ccache = ...
Change-Id: I09fb54d965644ff6e5825056fb0be2c7cab2ea92
Reviewed-on: https://skia-review.googlesource.com/21140
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-06-28 18:22:16 +00:00
Allan MacKinnon
0059f97c3f
Broken link in Tree Sheriffs Documentation
...
No-Try: true
Docs-Preview: https://skia.org/?cl=19326
Bug: skia:
Change-Id: I215d02470d14f076af68bfdc88046a0123429fb7
Reviewed-on: https://skia-review.googlesource.com/19326
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Allan MacKinnon <allanmac@google.com>
2017-06-09 17:56:14 +00:00
Ben Wagner
094dcc51c1
Update link to testing infrastructure.
...
No-Try: true
Docs-Preview: https://skia.org/?cl=18596
Change-Id: I0d3cae67ccb7db06f3a85a0b1360873a77bbe78f
Reviewed-on: https://skia-review.googlesource.com/18596
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-06-05 18:20:55 +00:00
Yuqian Li
3e2df5a2b8
A little help message for Android viewer's build dir
...
I think that I've mis-used out/Debug multiple times to build Android
viewer. Maybe this message would help me and others in the future.
No-Try: true
Docs-Preview: https://skia.org/?cl=18587
Bug: skia:
Change-Id: I810920a0ca4aa8a46dd58b35966e08513520953c
Reviewed-on: https://skia-review.googlesource.com/18587
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-06-05 15:02:36 +00:00
Brian Salomon
96789b31f2
Fix resource and skp paths in Android viewer
...
Docs-Preview: https://skia.org/?cl=18037
Change-Id: If92e561c6c24de1f51f81477d89b927e10308f13
Reviewed-on: https://skia-review.googlesource.com/18037
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-05-26 18:29:48 +00:00
Ravi Mistry
c823fb598b
Update documentation to specify the new Gerrit style CQ keywords
...
BUG=skia:6667
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=17762
Change-Id: I440b5565589102ae6026b5da4716fd43d4a48d6a
Reviewed-on: https://skia-review.googlesource.com/17762
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-05-23 20:28:54 +00:00
Hal Canary
35a87d60e6
documentaion: consistant formatting
...
NOTRY=true
Change-Id: I2dd9d755242ca6c3522c465e1fa00139dda71a9d
Reviewed-on: https://skia-review.googlesource.com/16220
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-05-15 20:05:56 +00:00
Mike Reed
36015ab796
remove SkXfermode from api dox -- it is gone
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=16868
Bug: skia:1312
Change-Id: I28aafb80bcad0f3a810ca0b08caa15b70707b4a1
Reviewed-on: https://skia-review.googlesource.com/16868
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-05-15 14:24:02 +00:00
Mike Klein
892af1ec7b
add a guide to contributing to SkJumper
...
Change-Id: Icd40cf5eff3d2156a3ca00d7950059d5b77f48bf
Reviewed-on: https://skia-review.googlesource.com/15890
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-08 23:40:14 +00:00
Mike Klein
f2daf74760
update Windows build docs
...
- mention 2017
- describe 32-bit builds a bit more
Change-Id: I386c51bcf4863f91db2eade01bad1e54c1049e6c
Reviewed-on: https://skia-review.googlesource.com/15314
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-05-04 16:27:42 +00:00
Hal Canary
5e958e9291
Documentation: site/user/api/canvas updated
...
BUG=skia:6523
NOTRY=true
Change-Id: I1fed8c65ba55c00f5045e56a23cbcf72d676e8d5
Reviewed-on: https://skia-review.googlesource.com/13873
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-04-21 14:57:41 +00:00
Ravi Mistry
7efa047630
Document the new bug and test lines behavior of the release rollers
...
BUG=skia:6506
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=13686
Change-Id: I8f38d2f87784a846ccdc4be54d0f07e0fe98f7dc
Change-Id: I8f38d2f87784a846ccdc4be54d0f07e0fe98f7dc
Reviewed-on: https://skia-review.googlesource.com/13686
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-18 12:20:57 +00:00
Matt Sarett
8530211fbf
Add documentation for color correct skia to website
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=10043
Change-Id: I025bf296518470dd2d5f62d7024a0f5d0fcc91c4
Reviewed-on: https://skia-review.googlesource.com/10043
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2017-04-14 15:18:12 +00:00
Ravi Mistry
028c3d77ea
Add documentation for android-o-roll.skia.org
...
BUG=skia:6438
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=13475
Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076
Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076
Reviewed-on: https://skia-review.googlesource.com/13475
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-14 14:38:56 +00:00
Ravi Mistry
6d2cf4726c
Update Android autoroller documentation
...
BUG=skia:5538
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=13266
Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517
Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517
Reviewed-on: https://skia-review.googlesource.com/13266
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-12 17:03:17 +00:00
Kevin Lubick
7cad9897d4
Add docs for downloading prebuilt binaries from CIPD
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=13101
Bug: skia:
Change-Id: Iefa8070c65881ff8c05a3b88aa8385fcc1a427ff
Change-Id: Iefa8070c65881ff8c05a3b88aa8385fcc1a427ff
Reviewed-on: https://skia-review.googlesource.com/13101
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-04-12 12:10:05 +00:00
bungeman
981108b004
Update instructions on Skia/Chromium multi try.
...
Change-Id: I7ac583dbf04d18210847c54f7c69cf8a4f46deea
Reviewed-on: https://skia-review.googlesource.com/10597
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
2017-03-30 15:59:50 +00:00
Mike Klein
a6c7c7ae6e
Add docs for iOS simulator build.
...
The new bot[1] seems to be working.
[1] https://status.skia.org/repo/skia?filter=search&search_value=Build-Mac-Clang-x64-Release-iOS
BUG=skia:6329
Change-Id: I40ea4b19cba14a160d84317d7fee11aef5b17051
Reviewed-on: https://skia-review.googlesource.com/9973
Reviewed-by: Hal Canary <halcanary@google.com>
2017-03-21 17:12:46 +00:00
Brian Salomon
6405e71279
Remove gpu configs that don't have explicit API.
...
DOCS_PREVIEW= https://skia.org/?cl=9871
Change-Id: I510473cf91d8bee38d1e33424b1ae7b30dc86968
Reviewed-on: https://skia-review.googlesource.com/9871
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-03-20 13:31:49 +00:00
Hal Canary
30a6b81f4b
Documentation: Consistancy
...
* Don't rely on '#!', since it doesn't work for Windows cmd shell.
* Consistantly use `tools/git-sync-deps` rather than `bin/sync`.
* Always call `bin/gn` ranther than `gn` in case depot_tools is
missing from the path.
NOTRY=true
Change-Id: I27909f2610d1bb3241874399d7d2f7286f99f43b
Reviewed-on: https://skia-review.googlesource.com/9640
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-03-14 14:21:49 +00:00
Mike Klein
47f5d8466a
Remove dead links in SampleApp docs.
...
NOTRY=true
Change-Id: I503e413a22855301610427743912ccad1f1f8ed9
Reviewed-on: https://skia-review.googlesource.com/9384
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-03-07 16:29:39 +00:00
Hal Canary
0f4f3e875d
Documentation: fix width
...
NOTRY=true
Change-Id: I60861019cc19537eaff000dec15b4ecbea54e915
Reviewed-on: https://skia-review.googlesource.com/9298
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2017-03-06 15:34:39 +00:00
Hal Canary
51aa1f5cce
Documentation: ASAN, MSAN, and TSAN
...
NOTRY=true
Change-Id: I7ed212047a60d323e2e98470fc1eed454d333958
Reviewed-on: https://skia-review.googlesource.com/9170
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-03-06 15:23:55 +00:00
Mike Klein
e459afd6ce
Strengthen is_official_build, update docs.
...
This makes is_official_build turn off all development targets and
features in Skia, including building third-party dependencies from
source.
This will intentionally break some external users, who will find
themselves no longer able to find third-party headers or link against
third-party libraries. These users have been building with our testing
third-party dependencies unknowingly. They'll need to either explicitly
turn back on building each dependency from source
(skia_use_system_foo=false) or disable that dependency entirely
(skia_use_foo=false).
is_skia_standalone is now basically !is_official_build, so I've
propagated that through, removing is_skia_standalone. In a few places
we were using it as a stand-in for defined(ndk), so I've just written
defined(ndk) there. Duh.
gn_to_bp:
is_offical_build's new strength also makes gn_to_bp.py simpler to
write. In spirit, Android builds are official Skia builds that also
build DM and nanobench.
It seems that SkJumper (src/jumper/*) is (unintentionally) enabled
on Android. Switching to an is_official_build would have disabled
that. But as that accidental launch seems to have gone fine, I've
kept it explicitly enabled.
In the end, no changes to Android.bp or its SkUserConfig.h.
The -Mini builder no longer needs to explicitly disable tools.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Ubuntu-Clang-x86_64-Release-Mini
Change-Id: Id06e53268a5caf55c6046ada354a0863c3031c73
Reviewed-on: https://skia-review.googlesource.com/9190
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-03-03 15:41:24 +00:00
Hal Canary
34a3256e6c
Documentation: detailed iOS
...
NOTRY=true
Change-Id: I24328509fc902f4f41198e249e82e88eda5dd21d
Reviewed-on: https://skia-review.googlesource.com/9189
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-03-03 14:12:15 +00:00
Heather Miller
7df440bbaf
remove no longer used links from directory
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=8914
Change-Id: I8497764cf12c0a0df96ea559f0595365d76252a3
Reviewed-on: https://skia-review.googlesource.com/8914
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-02-23 16:08:20 +00:00
Yuqian Li
46b83a43e7
Update endRecordingAsPicture to finishRecordingAsPicture
...
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=8854
Change-Id: Ia3ad32d088d44fbe47ec37de016931c4bd21231c
Reviewed-on: https://skia-review.googlesource.com/8854
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
2017-02-22 19:55:27 +00:00
Heather Miller
a9d0d9e71a
Update milestone schedule on skia.org
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=8809
Change-Id: Ic46ee37e90f90ebf6826cf5ead18bfd5ed75817a
Reviewed-on: https://skia-review.googlesource.com/8809
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-02-21 19:12:37 +00:00
Joe Gregorio
ca4c60f541
Move documentation to use the embedded fiddle elements.
...
Now code and images will always be in sync, and
users can edit and run the fiddles that are inline with
the docs.
Previews:
https://skia.org/user/api/skcanvas?cl=8507
https://skia.org/user/api/skpaint?cl=8507
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=8507
Change-Id: Iaf62d98d9aa73cf7b4e4a6baa522402ecb9e505a
Reviewed-on: https://skia-review.googlesource.com/8507
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-02-15 19:53:59 +00:00
Ben Wagner
33064926c7
Update codesearch docs.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=8321
Change-Id: Ia8c87fbb3b2380c18d27bffbbd060a0d77194f7d
Reviewed-on: https://skia-review.googlesource.com/8321
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-02-10 21:47:45 +00:00
Mike Klein
160907f8de
Clean up more references to GYP.
...
Delete files only used by GYP, and files that used GYP. Neither can
possibly be actively used. Beyond that, just a couple doc tweaks.
Change-Id: I0220d7226e7bb9ed7c54a7d8f2906a718313c521
Reviewed-on: https://skia-review.googlesource.com/8062
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Hal Canary <halcanary@google.com>
2017-02-06 17:55:35 +00:00
Mike Klein
c34b235871
Start updating iOS docs.
...
This removes the docs for the old GYP-based local development and
replaces them with ones for GN-based development.
I have not yet updated the docs for iOS on the bots... still in flux.
Change-Id: I1f9c5c1a3331ae192dc08c614ef7da26924f808e
Reviewed-on: https://skia-review.googlesource.com/8002
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-02-06 14:38:25 +00:00
Hal Canary
4d3adb6b0d
bin/sync : call tools/git-sync-deps now
...
Also, update some docs.
NOTRY=true
Change-Id: I7ad3375fc1cbf8f71ed42a460ecfe29ef6c1d85e
Reviewed-on: https://skia-review.googlesource.com/7657
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-01-27 16:03:35 +00:00
Mike Reed
918e144408
change clip-bounds getters to always return the rect
...
(actually fixes undefined result in getClipBounds)
future CLs
- update all callers to new apis
- move/rename virtuals
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=7400
Change-Id: I45b93014e915c0d1c36d97d948c9ac8931f23258
Reviewed-on: https://skia-review.googlesource.com/7400
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2017-01-23 17:14:53 +00:00
Skia_Android Canary Bot
5b92e4ab8e
Fix autoroller instructions
...
BUG=skia:6065
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=7377
Change-Id: Iefd6af3104f4aea2f2ae93c556b6b429e54ebff4
Reviewed-on: https://skia-review.googlesource.com/7377
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-23 15:53:15 +00:00
Mike Klein
efaad3cd53
Remove SkColorCubeFilter. It is unused.
...
Change-Id: Iec5fc759e331de24caea1347f9510917260d379b
Reviewed-on: https://skia-review.googlesource.com/7363
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-01-21 15:09:31 +00:00
Eric Boren
6d4d6cce5e
Update Buildbot doc for Task Scheduler
...
BUG=skia:6118
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=7023
Change-Id: I398f4fd98959bb37bcb5499d38e517542e0df90f
Reviewed-on: https://skia-review.googlesource.com/7023
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-01-17 14:54:12 +00:00
Mike Klein
aa9b5a1fd9
call fetch-gn from git-sync-deps
...
https://skia.org/?cl=6994
Change-Id: Icac009bdef49f38ae7b8f082ffda6408481a03cd
Reviewed-on: https://skia-review.googlesource.com/6994
Reviewed-by: Hal Canary <halcanary@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-01-13 17:25:56 +00:00
Mike Klein
905a94ff39
gclient-free download and build instructions.
...
https://skia.org/?cl=6988
Change-Id: If1275fe3cb1866216cc24c42c11a2d1f1be04a66
Reviewed-on: https://skia-review.googlesource.com/6988
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-01-13 15:14:28 +00:00
Hal Canary
6294d3f79e
documentation: corrections to PDF docs
...
NOTRY=true
Change-Id: Ib3a1ca0111c9fa2ed34021420c410f816e196274
Reviewed-on: https://skia-review.googlesource.com/6820
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2017-01-09 21:03:29 +00:00
Ravi Mistry
b5bb0d2292
Add robocop instructions on how to interact with the autoroller
...
BUG=skia:6065
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=6812
Change-Id: I04acc6d4a75ce01a3c0af94091ada84aeadc7da8
Reviewed-on: https://skia-review.googlesource.com/6812
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-09 20:02:10 +00:00
Derek Sollenberger
6172d432ba
Add a script and documentation for building the Viewer APK.
...
BUG=skia:6009
DOCS_PREVIEW= https://skia.org/?cl=6660
Change-Id: Ibcf0d1e7f3519e703bc74f0329d0ac92110e70ec
Reviewed-on: https://skia-review.googlesource.com/6660
Commit-Queue: Derek Sollenberger <djsollen@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-01-06 17:14:31 +00:00
Yuqian Li
db90e26e2b
Fix typos in the sheriffing document
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=6470
Change-Id: Id80f5bb1a3f0279162b0397fd6822aec83eae322
Reviewed-on: https://skia-review.googlesource.com/6470
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
2016-12-29 15:38:01 +00:00
Mike Klein
5d7c6ff1fc
Restore fetch-gn instructions.
...
The automatic DEPS hook doesn't actually work with the checkout instructions we have on the site.
BUG=skia:6058
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=6180
Change-Id: Ib1caa617791d3de2b60ddf00fed24d28fd9f83d1
Reviewed-on: https://skia-review.googlesource.com/6180
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-12-16 13:14:32 +00:00
Brian Osman
2052c86a30
Move, rename, and document Visual Studio GN helper script
...
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=5983
Change-Id: I32ac2c5275eb86adaa2be9ceee061b2956db70ad
Reviewed-on: https://skia-review.googlesource.com/5983
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2016-12-14 16:41:52 +00:00
Jim Van Verth
18b4f981ae
Fix doc typo
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5942
Change-Id: I3861a4f56cd325b1bff322613d93c7b697492e75
Reviewed-on: https://skia-review.googlesource.com/5942
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
2016-12-13 15:43:48 +00:00
Derek Sollenberger
cb2c8ae42a
Add documentation for being a Android RoboCop.
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5759
Change-Id: I6172c9edfcac63855b3f7c2b120bac44760a24a5
Reviewed-on: https://skia-review.googlesource.com/5759
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Derek Sollenberger <djsollen@google.com>
2016-12-12 13:35:19 +00:00
Jim Van Verth
bbab477b49
Add documentation for Viewer
...
BUG=skia:5488
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5682
Change-Id: I635468f6a17576e990e159f7f02ba2f1946317ab
Reviewed-on: https://skia-review.googlesource.com/5682
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2016-12-11 21:32:39 +00:00
Hal Canary
a4a3381790
tools and docs: clean up gyp-specific things
...
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=5770
Change-Id: Iadc436a68cbf7ec0d1dd3c019072eb28bf589bb6
Reviewed-on: https://skia-review.googlesource.com/5770
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2016-12-09 21:15:27 +00:00
Mike Klein
385836d3d7
remove Building with Skia Tutorial
...
It's mostly "How to Effectively Fight with GYP", which is no longer interesting.
BUG=skia:6043
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5761
Change-Id: I760e8d9c6577846b34d8f1f0d2e37b5a3c553ccf
Reviewed-on: https://skia-review.googlesource.com/5761
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-12-09 20:37:30 +00:00
Mike Klein
feda468155
Run bin/fetch-gn as a gclient hook.
...
Seems like the bots don't run hooks. That's okay, even ideal.
They'll keep getting GN via recipes.
DOCS_PREVIEW= https://skia.org/?cl=5725
Change-Id: I000bad3390dddaeb4548972f29c96b8b3288ea6c
Reviewed-on: https://skia-review.googlesource.com/5725
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2016-12-09 17:06:21 +00:00
Joe Gregorio
87da4efd63
docs: Use the new floating ment on skpaint.md
...
Screenshot:
https://screenshot.googleplex.com/C3E0hpuNwdu.png
https://screenshot.googleplex.com/vdfQMRc24Nv.png
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5757
Change-Id: I00b1bb01cab05592d19f020f3190576bf7907aa2
Reviewed-on: https://skia-review.googlesource.com/5757
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2016-12-09 16:43:56 +00:00
Joe Gregorio
6a4cdb6ba9
Remove documentation about emboss.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5708
Change-Id: Iac133df3778061509f5754aa6a742cebc2ab6ba6
Reviewed-on: https://skia-review.googlesource.com/5708
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2016-12-08 21:07:46 +00:00
Mike Klein
019be7b472
add missing []
...
BUG=skia:6039
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5653
Change-Id: I8bb0e0fec71cea99a9804cc855371fd153b52ce1
Reviewed-on: https://skia-review.googlesource.com/5653
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-12-08 02:13:01 +00:00
Joe Gregorio
dd56632ae3
docs: Update Perf docs.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5458
Change-Id: If8a452711076bef19566fa64a5a52ca9b3e7b83c
Reviewed-on: https://skia-review.googlesource.com/5458
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
2016-12-01 20:51:04 +00:00
Ben Wagner
aa5fe5ef07
Clarify documentation for CQ_INCLUDE_TRYBOTS.
...
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=5330
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE
Change-Id: I2e9fa401c470951a8676c2357bb409d136b971ad
Reviewed-on: https://skia-review.googlesource.com/5330
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2016-11-30 15:39:31 +00:00
Brian Salomon
fc74ec7c7a
Fix documents for creating a GPU surface.
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=5284
Change-Id: I9ca559576d9e7fdff612cfe79628303bc7677bd7
Reviewed-on: https://skia-review.googlesource.com/5284
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2016-11-29 18:02:16 +00:00
Mike Klein
c168a3ac3c
Revert "Always build the ANGLE test code. Always build ANGLE on windows and linux."
...
This reverts commit 238b820369
.
Reason for revert: breaks 32-bit bots, iOS bots, Google3 roll, -ASAN bot.
Original change's description:
> Always build the ANGLE test code. Always build ANGLE on windows and linux.
>
> Make ANGLE test code independent of having ANGLE lib. Make ANGLE test code not include EGL headers.
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4040
>
> DOCS_PREVIEW= https://skia.org/?cl=4040
>
> Change-Id: I7b857e9785246743f53fb969647b1162ce7419ab
> Reviewed-on: https://skia-review.googlesource.com/4040
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
>
TBR=mtklein@chromium.org ,mtklein@google.com,bsalomon@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I19bab8c93baebf032f8a4cefbedfe7359317e806
Reviewed-on: https://skia-review.googlesource.com/4758
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2016-11-14 14:53:23 +00:00
Brian Salomon
238b820369
Always build the ANGLE test code. Always build ANGLE on windows and linux.
...
Make ANGLE test code independent of having ANGLE lib. Make ANGLE test code not include EGL headers.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4040
DOCS_PREVIEW= https://skia.org/?cl=4040
Change-Id: I7b857e9785246743f53fb969647b1162ce7419ab
Reviewed-on: https://skia-review.googlesource.com/4040
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2016-11-14 14:34:11 +00:00
Hal Canary
d7148f673a
Documentation: move some things around
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4750
Change-Id: I0d1bc77a533ede8e0514ff0b680a5aa851051fc6
Reviewed-on: https://skia-review.googlesource.com/4750
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2016-11-14 14:31:14 +00:00
Mike Klein
38af9438d7
GN: build Lua tools when skia_use_lua.
...
When we opt into Lua, this builds SampleLua into SampleApp, and the lua_app and lua_pictures tools.
I've tested this builds with and without skia_use_system_lua on my Mac laptop and Linux desktop.
I've made lua_pictures.cpp's flags static to avoid conflicts with flags in SkCommonFlags.cpp.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4699
DOCS_PREVIEW= https://skia.org/?cl=4699
Change-Id: I8176fd51d8a38746e7d730cfcce66da42b9a015a
Reviewed-on: https://skia-review.googlesource.com/4699
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-11-11 17:34:36 +00:00
Hal Canary
64dded3d95
Documentation: more gn, less gyp
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4698
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4698
Change-Id: I03100542752a769060a7f0c9671cc44acbea2e48
Reviewed-on: https://skia-review.googlesource.com/4698
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Hal Canary <halcanary@google.com>
2016-11-11 16:59:14 +00:00
Ravi Mistry
152ad7e7fb
Update skia.org docs to reference Gerrit instead of Rietveld
...
BUG=skia:5958
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4648
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4648
Change-Id: I6a57b7f9b92f6b769ba2b78f8e0ab9f4ae7bb24e
Reviewed-on: https://skia-review.googlesource.com/4648
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
2016-11-10 16:20:59 +00:00
Mike Klein
308b7d9933
update Vulkan docs for GN.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4458
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4458
Change-Id: Ifb21b28440b5725775b40e79aef2a0286e1de103
Reviewed-on: https://skia-review.googlesource.com/4458
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-11-07 16:11:58 +00:00
Mike Klein
25495f7706
update ANGLE docs for GN, current test tools
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4454
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4454
Change-Id: If9e5d763b599db358597e79e090f7a8aba618e10
Reviewed-on: https://skia-review.googlesource.com/4454
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-11-07 14:50:54 +00:00
stephana
db64acacf9
Add indexfile to obsolute quickstart section
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2477153002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2477153002
Review-Url: https://codereview.chromium.org/2477153002
2016-11-05 13:28:47 -07:00
Mike Klein
e33998aa26
Trim down quick start docs for a GN world.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4431
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4431
Change-Id: I2a10494158e7415ae655baf212a951afd87dcbde
Reviewed-on: https://skia-review.googlesource.com/4431
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-11-04 21:05:45 +00:00
Ben Wagner
d49128ab8e
Add note about CQ_INCLUDE_TRYBOTS and -Trybot suffix.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4428
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=4428
Change-Id: I5f1fc4ad1cca50ed245d5c14ceff28aa7dfaee53
Reviewed-on: https://skia-review.googlesource.com/4428
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2016-11-04 16:45:11 +00:00
bsalomon
bab7945563
Add documentation for using testing using the command buffer
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2479833003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2479833003
Review-Url: https://codereview.chromium.org/2479833003
2016-11-04 08:36:00 -07:00
Mike Klein
9caeb0bc83
Add a Windows Android NDK asset.
...
We can build for Android from Windows now. I intend to add a bot to keep it that way, just like Build-Mac-Clang-arm64-Debug-GN_Android does for Mac. The Windows Android builder will need this NDK.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4280
DOCS_PREVIEW= https://skia.org/?cl=4280
Change-Id: Ifaeeb9b81822a410bdf79b39c7e66d0765f78e0b
Reviewed-on: https://skia-review.googlesource.com/4280
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-11-02 13:16:08 +00:00
Mike Klein
10d665d000
Allow most third_party targets to use system libraries if asked.
...
This extends the pattern in freetype2 to expat, icu, libjpeg-turbo, libpng, libwebp, and zlib, and gives all these an arg to control which to use.
Homebrew doesn't have dng_sdk, piex, or sftnly, or I'd have done the same for them too.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4260
DOCS_PREVIEW= https://skia.org/?cl=4260
Change-Id: I82e780502bf2217336e791787f172a6fc8f55460
Reviewed-on: https://skia-review.googlesource.com/4260
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Hal Canary <halcanary@google.com>
2016-11-01 16:17:38 +00:00
Hal Canary
3effb79fc5
Documentation: SkBitmap->SkImage
...
NOTRY=true
Change-Id: Ieb99a447b4198b1ba5d1bc17668b307d82d62be5
Reviewed-on: https://skia-review.googlesource.com/4121
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2016-10-28 16:21:19 +00:00
Mike Klein
b00c949c36
Mac GN doc.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3906
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=3906
Change-Id: I1ad13dd5b7df3d76f99f11e02f04169c5b37ce95
Reviewed-on: https://skia-review.googlesource.com/3906
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-25 16:23:09 +00:00
Ben Wagner
a3f79c0b42
Update trooper doc with chrome-infra chat.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3745
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=3745
Change-Id: Icc9b52a7b4bc90f4ef8d8b952d49663f74104ba9
Reviewed-on: https://skia-review.googlesource.com/3745
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2016-10-24 16:14:01 +00:00
Mike Klein
24a865c2c0
update GN docs
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3425
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=3425
Change-Id: Iafd5a7b9feca6855d595f9ecbc05292a924e00e4
Reviewed-on: https://skia-review.googlesource.com/3425
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-15 15:47:12 +00:00
Brian Salomon
30d99c66f5
Update CQ_INCLUDE_TRYBOTS examples in docs to actually be "real world"
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3409
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=3409
Change-Id: I5f524b2d04822dd9780302fae9bd064d81f10c6c
Reviewed-on: https://skia-review.googlesource.com/3409
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2016-10-14 14:23:39 +00:00
stephana
f79d6a1a2b
Add description to Gold
...
BUG=skia:
R=hcm,jcgregorio
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2406753002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2406753002
Review-Url: https://codereview.chromium.org/2406753002
2016-10-10 07:59:08 -07:00
Joe Gregorio
bc4cc336d5
Update Perf docs and add a couple screenshots.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3121
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=3121
Change-Id: Ic2d1743b2dc42701202ff316277db4c944d969d3
Reviewed-on: https://skia-review.googlesource.com/3121
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2016-10-10 13:42:06 +00:00
borenet
777ee88129
Make the housekeeper upload doxygen to a newer bucket
...
BUG=skia:2969
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370153003
DOCS_PREVIEW= https://skia.org/?cl=2370153003
Review-Url: https://codereview.chromium.org/2370153003
2016-10-04 13:23:57 -07:00
halcanary
919f21f877
SkPDF/Documentation: backend limitations
...
NOTRY=true
Review-Url: https://codereview.chromium.org/2377473002
2016-09-29 08:43:41 -07:00
halcanary
ca9654e4c6
documentation: update PDF design doc
...
NOTRY=true
Review-Url: https://codereview.chromium.org/2295373002
2016-09-28 11:19:52 -07:00
liyuqian
21112deff8
Fix typo
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370003002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2370003002
Review-Url: https://codereview.chromium.org/2370003002
2016-09-26 12:49:06 -07:00
halcanary
75a171cf17
Documentation: fix links
...
TBR=
NOTRY=true
Review-Url: https://codereview.chromium.org/2366403002
2016-09-26 07:27:04 -07:00
hcm
3d89a7c0d2
Update Chrome section to include Skia roll/sheriff/bug info
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2351593003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2351593003
Review-Url: https://codereview.chromium.org/2351593003
2016-09-22 12:47:14 -07:00
mtklein
60b7ab7a8e
GN: compiler_prefix -> cc_wrapper
...
I was a bit mixed up thinking Chrome called this feature compiler_prefix.
They actually call it cc_wrapper. So let's switch to their name before we
get too used to this.
No bots are affected.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355003002
DOCS_PREVIEW= https://skia.org/?cl=2355003002
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2355003002
2016-09-20 12:09:13 -07:00
mtklein
e7904f3979
Flesh out GN/Android run docs.
...
The process is simple enough that it's clearer to see all the steps laid out.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343263002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2343263002
Review-Url: https://codereview.chromium.org/2343263002
2016-09-16 12:40:18 -07:00
mtklein
40efbe8552
Update GN docs to mention is_official_build and ndk_api.
...
is_official_build is the closest approximation to what we'd recommend people ship, and we'll keep tweaking it further toward that goal. I want it to be the first choices people see reading the doc to nudge them to defaulting into that if they don't know better. The familiar old Debug and Release for developers come later.
It'd be a fine choice, for instance, for fiddle to build against. I dropped Stripped because that's something is_official_build now does more naturally.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342333002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2342333002
Review-Url: https://codereview.chromium.org/2342333002
2016-09-16 07:17:45 -07:00
halcanary
d39d6f3756
Documentation: MSKP
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332783002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2332783002
Review-Url: https://codereview.chromium.org/2332783002
2016-09-12 11:56:28 -07:00
mtklein
f3155ad97c
GN: add a helper script for running Android builds
...
Think of this as the spiritual equivalent of platform_tools/android/bin/android_run_skia, but for GN and easier to type.
Cutting down the debug symbols makes Android builds about 1/4 the size.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323833002
DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2323833002
Review-Url: https://codereview.chromium.org/2323833002
2016-09-08 10:03:21 -07:00
jcgregorio
e050555bf3
docs: Add instructions on how to download isolated intermediaries.
...
Screenshot:
https://screenshot.googleplex.com/2cXAQMqypHv.png
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316113002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2316113002
Review-Url: https://codereview.chromium.org/2316113002
2016-09-07 06:23:44 -07:00
bsalomon
54dd2e244c
Add Vulkan docs
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318603002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2318603002
Review-Url: https://codereview.chromium.org/2318603002
2016-09-06 14:18:13 -07:00
mtklein
adbd480102
Add docs for GN/Android
...
While I'm at it, add a few more examples of other types of builds you can do.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289883002
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2289883002
Review-Url: https://codereview.chromium.org/2289883002
2016-08-29 10:27:16 -07:00
rmistry
674b925227
Add trooper documentation for CT bots and for iOS "the service is invalid"
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263103003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2263103003
Review-Url: https://codereview.chromium.org/2263103003
2016-08-22 12:54:54 -07:00
hcm
d4d8b39441
Expand Issue Tracking docs to include triage, Chrome instructions
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255133003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2255133003
Review-Url: https://codereview.chromium.org/2255133003
2016-08-18 18:32:17 -07:00
halcanary
997d017eed
Documentation: Important things on front page
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2112643003
Review-Url: https://codereview.chromium.org/2112643003
2016-08-15 06:56:18 -07:00
halcanary
4e44efe504
SkRTConf: eliminate
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
[mtklein]
TBR=reed@google.com
Only removing unused public API.
Review-Url: https://codereview.chromium.org/2212473002
2016-08-04 10:47:16 -07:00
mtklein
b979634012
Revert of SkRTConf: reduce functionality to what we use, increase simplicity (patchset #8 id:150001 of https://codereview.chromium.org/2212473002/ )
...
Reason for revert:
missed GrVkPipelineStateCache
Original issue's description:
> SkRTConf: reduce functionality to what we use, increase simplicity
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
> DOCS_PREVIEW= https://skia.org/?cl=2212473002
> CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> [mtklein]
> TBR=reed@google.com
> Only removing unused public API.
>
> Committed: https://skia.googlesource.com/skia/+/ef59974708dade6fa72fb0218d4f8a9590175c47
TBR=halcanary@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2215433003
2016-08-03 19:19:48 -07:00
halcanary
ef59974708
SkRTConf: reduce functionality to what we use, increase simplicity
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
[mtklein]
TBR=reed@google.com
Only removing unused public API.
Review-Url: https://codereview.chromium.org/2212473002
2016-08-03 15:30:37 -07:00
mtklein
5259da5377
GN: gpu support in tools
...
If you want to try this out, the DOCS_PREVIEW link is a quickstart.
Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library
or just used by testing tools? I've got it written here as tool-only,
but we could easily move it to libskia if it's a thing we want to ship.
I'm honestly not sure I understand how this linked before without a definition
of GrGLCreateNativeInterface(). Or are there two, one real and one no-op
default with some sort of weak linking setup? dlopen()?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003
DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2201233003
Review-Url: https://codereview.chromium.org/2201233003
2016-08-03 08:28:20 -07:00
mtklein
73106225d1
Docs: ooops, debug is the default in GN.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2195173002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2195173002
TBR=jcgregorio@google.com
Review-Url: https://codereview.chromium.org/2195173002
2016-07-30 07:50:15 -07:00
mtklein
3a88056994
GN: quick doc
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192203002
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2192203002
Review-Url: https://codereview.chromium.org/2192203002
2016-07-29 08:35:54 -07:00
borenet
917d6f3005
Fix docs for checking out Skia
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179023003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2179023003
Review-Url: https://codereview.chromium.org/2179023003
2016-07-26 11:11:50 -07:00
brianosman
fe8d2cf520
Add special Windows instructions for getting SKPs
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184723002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2184723002
Review-Url: https://codereview.chromium.org/2184723002
2016-07-26 06:43:51 -07:00
borenet
1543487fc6
Change SKPs to new asset management format
...
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169653003
DOCS_PREVIEW= https://skia.org/?cl=2169653003
Review-Url: https://codereview.chromium.org/2169653003
2016-07-22 08:31:07 -07:00
jcgregorio
59e3039fad
docs: Add info on using blamer to the sheriffing docs.
...
BUG=skia:
R=kjlubick
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167803002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2167803002
Review-Url: https://codereview.chromium.org/2167803002
2016-07-21 05:37:28 -07:00
liyuqian
e25faf3e18
Fix option name typo
...
BUG=skia:
TBR=jvanverth@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143093002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2143093002
Review-Url: https://codereview.chromium.org/2143093002
2016-07-12 15:11:31 -07:00
liyuqian
e7d15fe870
Update documents/scripts for SampleApp removal
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2140663002
DOCS_PREVIEW= https://skia.org/?cl=2140663002
Review-Url: https://codereview.chromium.org/2140663002
2016-07-12 09:12:39 -07:00
pdr
48898561db
Update markdown docs to specify --local for the local devserver
...
If the devserver is run locally following the instructions on
https://skia.org/dev/tools/markdown , you'll get an error about influxdb.
It looks like an influxdb username/password is required but using
--local works around this issue.
-------------------8<-------------------
$ ./bin/docserver --preview
E0703 19:33:31.510379 30448 common.go:37] Initializing logserver for log level ERROR.
F0703 19:33:31.516750 30448 common.go:63] metadata.Get() failed to make HTTP request for influxdb_name: Get http://metadata/computeMetadata/v1/project/attributes/influxdb_name : dial tcp: lookup metadata: no such host
goroutine 1 [running]:
github.com/skia-dev/glog.stacks(0x772300, 0x0, 0x0, 0x0)
/src/github.com/skia-dev/glog/glog.go:769 +0xb8
github.com/skia-dev/glog.(*loggingT).output(0x756000, 0xc800000003, 0xc820136000, 0x73613e, 0x9, 0x3f, 0x0)
/src/github.com/skia-dev/glog/glog.go:720 +0x259
github.com/skia-dev/glog.(*loggingT).printDepth(0x756000, 0x3, 0x1, 0xc8200dde28, 0x1, 0x1)
/src/github.com/skia-dev/glog/glog.go:649 +0x1b8
github.com/skia-dev/glog.(*loggingT).print(0x756000, 0x3, 0xc8200dde28, 0x1, 0x1)
/src/github.com/skia-dev/glog/glog.go:640 +0x50
github.com/skia-dev/glog.Fatal(0xc8200dde28, 0x1, 0x1)
/src/github.com/skia-dev/glog/glog.go:1128 +0x49
go.skia.org/infra/go/common.StartMetrics2(0x5103e0, 0x9, 0xc820104400, 0xc820104430, 0xc820104450, 0xc820104470, 0xc8200dde00)
/src/go.skia.org/infra/go/common/common.go:63 +0x192
go.skia.org/infra/go/common.InitWithMetrics2(0x5103e0, 0x9, 0xc820104400, 0xc820104430, 0xc820104450, 0xc820104470, 0xc820104498)
/src/go.skia.org/infra/go/common/common.go:48 +0x65
main.main()
/src/skia.googlesource.com/buildbot.git/doc/go/docserver/main.go:183 +0x95
-------------------8<-------------------
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2118113002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2118113002
Review-Url: https://codereview.chromium.org/2118113002
2016-07-09 17:08:24 -07:00
pdr
c42475cea2
Update markdown to use absolute image paths, fixing broken images
...
Markdown can be served with or without a trailing slash but when a
trailing slash is present, relative image links were broken.
The following example works as expected:
url: https://skia.org/dev/design/pdftheory
image url: PdfLogicalDocumentStructure.png
resolves to: https://skia.org/dev/design/PdfLogicalDocumentStructure.png
The following example was broken before this patch:
url: https://skia.org/dev/design/pdftheory/
image url: PdfLogicalDocumentStructure.png
resolves to: https://skia.org/dev/design/pdftheory/PdfLogicalDocumentStructure.png
The PdfLogicalDocumentStructure.png file lives in /dev/design/, not
/dev/design/pdftheory/. This patch updates all images in our markdown
files to be served with the full path so a trailing slash no longer
breaks images.
I hit this bug when promoting the new Skia debugger:
https://groups.google.com/a/chromium.org/d/msg/paint-dev/QJ8xpu8dNyA/F4KX2O4ZBwAJ
BUG=skia:5493
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128013003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2128013003
Review-Url: https://codereview.chromium.org/2128013003
2016-07-07 14:48:53 -07:00
bungeman
52fa668dc5
Update rebaseline instructions.
...
BUG=skia:2805
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2127953002
Review-Url: https://codereview.chromium.org/2127953002
2016-07-06 10:19:54 -07:00
pdr
1e2a702c19
Update dev docs to reference the new skia debugger (skiaserve)
...
This patch adds a new markdown file describing the new debugger along
with instructions on running it locally and a sweet screenshot. The
screenshot has been sized to not be clipped when viewed in production.
The old documentation for the qt-based debugger has been marked as
deprecated and all docs referencing the old debugger have been updated.
BUG=skia:5493
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2121673002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2121673002
Review-Url: https://codereview.chromium.org/2121673002
2016-07-06 06:10:25 -07:00
rmistry
d9114cb8f3
Update CT documentation on skia.org
...
BUG=skia:5465
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103853002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2103853002
Review-Url: https://codereview.chromium.org/2103853002
2016-06-28 10:52:47 -07:00
hcm
8e0a09c1a1
Update roadmap and remove highlights
...
Use new file hosted on skia.org for 16-17 roadmap
Remove aging published highlights in favor of release notes
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104563002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2104563002
Review-Url: https://codereview.chromium.org/2104563002
2016-06-27 12:54:07 -07:00
rmistry
6a3f07e985
Update documentation on how to download CT SKPs
...
BUG=skia:5465
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103443003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2103443003
Review-Url: https://codereview.chromium.org/2103443003
2016-06-27 12:51:47 -07:00
halcanary
de8ae90478
Documentaion: top level link.
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2084593008
Review-Url: https://codereview.chromium.org/2084593008
2016-06-23 07:00:44 -07:00
stani
a80bb676d3
Remove check for cmake in android make script.
...
Update docs explaining how to setup Android SDK.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084763003
DOCS_PREVIEW= https://skia.org/?cl=2084763003
Review-Url: https://codereview.chromium.org/2084763003
2016-06-21 13:13:20 -07:00
rmistry
0b04fea228
Update CQ keywords documentation
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056733002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2056733002
Review-Url: https://codereview.chromium.org/2056733002
2016-06-09 06:56:39 -07:00
martina.kollarova
2f64bf7931
Document dm error about missing skps
...
BUG=None
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2049703002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2049703002
Review-Url: https://codereview.chromium.org/2049703002
2016-06-08 09:25:24 -07:00
bungeman
f283c07695
Update VC++ version in Windows quick start.
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2019093002
Review-Url: https://codereview.chromium.org/2019093002
2016-05-27 12:27:33 -07:00
benjaminwagner
bac5eb073e
Fix example code in skpaint.md.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1993903002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1993903002
Review-Url: https://codereview.chromium.org/1993903002
2016-05-18 13:28:56 -07:00
halcanary
bcb8fee6db
documentation: SkMilestone
...
https://skia.org/schedule?cl=1956473006
NOTRY=true
TBR=
Review-Url: https://codereview.chromium.org/1956473006
2016-05-06 14:09:09 -07:00
halcanary
676ab68b04
documentation: SkDocument::MakePDF()
...
also, update some tools.
DOCS_PREVIEW= https://skia.org/user/sample/pdf?cl=1936283003
DOCS_PREVIEW= https://skia.org/user/api/canvas?cl=1936283003
Review-Url: https://codereview.chromium.org/1936283003
2016-05-03 12:10:04 -07:00
halcanary
5441e9f8eb
Documentation: Skia+Harfbuzz example
...
BUG=skia:4742
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/tips?cl=1939123002#kerning
Review-Url: https://codereview.chromium.org/1939123002
2016-05-03 10:18:30 -07:00
bungeman
7ae5627be2
Update running Chromium trybots on Skia CLs docs.
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1930773005
Review-Url: https://codereview.chromium.org/1930773005
2016-04-29 07:08:12 -07:00
djsollen
efe46d2094
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
...
The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.
Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1931903002
DOCS_PREVIEW= https://skia.org/?cl=1931903002
Review-Url: https://codereview.chromium.org/1931903002
2016-04-29 06:41:35 -07:00
reed
28d5bdd97e
Revert of Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. (patchset #2 id:20001 of https://codereview.chromium.org/1927583002/ )
...
Reason for revert:
still blocking DEPS roll
Original issue's description:
> Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
>
> The Release_Developer build type is now used to build Skia with
> release level optimizations but still enable SK_DEBUG. This in turn
> means that SkASSERTS and SkRTConf are available in this mode.
>
> Further we can then remove SK_DEVELOPER as a define as it is true
> iff SK_DEBUG is true.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002
> DOCS_PREVIEW= https://skia.org/?cl=1927583002
>
> Committed: https://skia.googlesource.com/skia/+/48d6f88479e72efaf9b9d8f9c0769acb1ba773db
TBR=bungeman@gmail.com ,bungeman@google.com,benjaminwagner@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1918253006
2016-04-28 08:12:55 -07:00
djsollen
48d6f88479
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
...
The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.
Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002
DOCS_PREVIEW= https://skia.org/?cl=1927583002
Review-Url: https://codereview.chromium.org/1927583002
2016-04-27 13:37:23 -07:00
liyuqian
cbaafc34bc
Add runhooks to multi_repo_trybots
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924573002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1924573002
Review URL: https://codereview.chromium.org/1924573002
2016-04-26 12:54:05 -07:00
djsollen
e6e2e54036
Update android docs for how to sync source code
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921023002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1921023002
Review URL: https://codereview.chromium.org/1921023002
2016-04-26 12:38:52 -07:00
halcanary
ff6596460e
Documentation: FAQ: drop shadow
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/tips?cl=1918833003#text-shadow
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918833003
Review URL: https://codereview.chromium.org/1918833003
2016-04-26 04:49:45 -07:00
liyuqian
8528912215
Improve Android Quick Start Guide
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919973002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1919973002
Review URL: https://codereview.chromium.org/1919973002
2016-04-25 13:15:37 -07:00
borenet
6c3c0c69e8
"Using Skia" tutorial: googlecode -> googlesource
...
BUG=skia:5212
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915013002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1915013002
Review URL: https://codereview.chromium.org/1915013002
2016-04-25 06:01:51 -07:00
jcgregorio
4ff7c74236
docs: fix fiddle image links.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915493004
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1915493004
TBR=hal
Review URL: https://codereview.chromium.org/1915493004
2016-04-22 11:43:42 -07:00
jcgregorio
1c2a2fe3c8
skia.org: Update all fiddles for fiddle 2.0.
...
The images won't show up in the preview, which won't happen until I switch over to fiddle 2.0 in production later today.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1910593005
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1910593005
Review URL: https://codereview.chromium.org/1910593005
2016-04-22 11:25:43 -07:00
scroggo
9d08172828
Add instructions for building with MSAN
...
Move static functions only used by GPU into if SK_SUPPORT_GPU guard.
This enables building MSAN, which seems to default to not supporting
GPU.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908493002
DOCS_PREVIEW= https://skia.org/?cl=1908493002
Review URL: https://codereview.chromium.org/1908493002
2016-04-20 08:27:18 -07:00
bungeman
bc95173756
Explain Rietveld patching better on site.
...
State which values should be updated and how to determine them.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1883213002
Review URL: https://codereview.chromium.org/1883213002
2016-04-14 10:25:01 -07:00
bungeman
ccb0de64f3
Add doc instructions for multi-repo Chromium trybots.
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1865153003
Review URL: https://codereview.chromium.org/1865153003
2016-04-14 09:23:41 -07:00
bungeman
85c9447d4d
Add note about Chromium's use of old libstdc++ to docs.
...
Chromium must still build against libstdc++4.6.4, which presents limits
on at least type traits and perhaps performance.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1820873002
Review URL: https://codereview.chromium.org/1820873002
2016-03-21 07:46:28 -07:00
halcanary
2c9c469cc9
SkPDF: metadata first
...
Motivation: while experimenting with serializing images immediately, I would like to keep serializing metadata first.
TBR=djsollen@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1780463008
Review URL: https://codereview.chromium.org/1780463008
2016-03-20 07:07:11 -07:00
halcanary
3bcef213d1
documentation: simplify pdf diagram
...
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1810943003
2016-03-17 13:33:50 -07:00
halcanary
b78afe9286
documentation: simplify pdf diagram
...
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1810943003
2016-03-17 13:27:57 -07:00
halcanary
3eac8d1b23
Doc: pdf illustration
...
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/1807963002
2016-03-16 10:19:33 -07:00
bsalomon
c43c35fb7e
update site dox - windows prefer msvs-ninja and add vulkan
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1785743003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1785743003
NOTREECHECKS=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1785743003
2016-03-10 13:38:21 -08:00
bsalomon
5ec26ae9bf
Move Budgeted enum out of SkSurface, use in GrTextureProvider
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005
Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/1728093005
2016-02-25 08:33:02 -08:00
bsalomon
bd500f09ce
Revert of Move Budgeted enum out of SkSurface, use in GrTextureProvider (patchset #6 id:100001 of https://codereview.chromium.org/1728093005/ )
...
Reason for revert:
Need workaround for chrome to build
Original issue's description:
> Move Budgeted enum out of SkSurface, use in GrTextureProvider
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
> DOCS_PREVIEW= https://skia.org/?cl=1728093005
>
> Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1734043002
2016-02-25 06:52:12 -08:00
bsalomon
57599fe6c0
Move Budgeted enum out of SkSurface, use in GrTextureProvider
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005
Review URL: https://codereview.chromium.org/1728093005
2016-02-25 06:33:27 -08:00
halcanary
1cc345f699
Documentation: sync-and-gyp design document
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/dev/design/sync-and-gyp?cl=1736483002
Review URL: https://codereview.chromium.org/1736483002
2016-02-24 10:50:35 -08:00
hcm
85a7a5fc6c
Skia schedule on skia.org
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726253002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1726253002
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1726253002
2016-02-23 16:26:03 -08:00
benjaminwagner
e52bebbb47
skia.org internal links: Add link to Google3 Autoroller doc.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720943003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1720943003
Review URL: https://codereview.chromium.org/1720943003
2016-02-22 09:31:38 -08:00
halcanary
6f96cf4bde
Documantation: nanobench
...
DOCS_PREVIEW= https://skia.org/dev/testing/tests?cl=1696723002
https://skia.org/dev/testing/tests?cl=1696723002#bench
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696723002
NOTRY=true
Review URL: https://codereview.chromium.org/1696723002
2016-02-12 08:08:27 -08:00
rmistry
d31588523c
Documentation for accessing the different repositories of SKPs
...
BUG=skia:2306
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683233002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1683233002
Review URL: https://codereview.chromium.org/1683233002
2016-02-10 12:55:07 -08:00
kjlubick
a58ec2162c
Fix autoroll link
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676993002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1676993002
Review URL: https://codereview.chromium.org/1676993002
2016-02-08 05:23:37 -08:00
mtklein
98b2f0c096
update C++11 doc
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1678673002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1678673002
Review URL: https://codereview.chromium.org/1678673002
2016-02-06 15:45:28 -08:00
brianosman
5923535a04
Fix SampleApp instructions in the Windows quick-start
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1661553002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1661553002
Review URL: https://codereview.chromium.org/1661553002
2016-02-02 10:59:30 -08:00
benjaminwagner
5962957d95
Fix typo on trooper page.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1642183002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1642183002
Review URL: https://codereview.chromium.org/1642183002
2016-01-28 12:58:02 -08:00
hcm
4020665b81
Fix patch check-in instructions for non-committers
...
BUG=skia:4681
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606003003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1606003003
Review URL: https://codereview.chromium.org/1606003003
2016-01-19 13:57:27 -08:00
jcgregorio
8bae7c537a
docs: Fix link to 'How to submit a patch'.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1579593002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1579593002
Review URL: https://codereview.chromium.org/1579593002
2016-01-11 07:42:33 -08:00
halcanary
217a333eb6
Documentation: FAQ TOC
...
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1542853003
2015-12-22 07:08:12 -08:00
halcanary
7d1c3e6361
Documentation: HarfBuzz link
...
NOTRY=true
TBR=caryclark@google.com
Review URL: https://codereview.chromium.org/1526683002
2015-12-14 10:03:31 -08:00
halcanary
a58d67603b
Documentation: text shaping
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/tips?cl=1523023002#kerning
Review URL: https://codereview.chromium.org/1523023002
2015-12-14 09:50:15 -08:00
aam
419c37269f
Fix 'debugging on Android' android_gdb_app script.
...
1) com.skia -> com.skia.sample_app
2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example:
./platform_tools/android/bin/android_gdb_app -d nexus_6
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1509853006
Review URL: https://codereview.chromium.org/1509853006
2015-12-10 14:14:56 -08:00
caryclark
201efb5ae0
try again on md formatting
...
TBR=hcm@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1520533002
Review URL: https://codereview.chromium.org/1520533002
2015-12-10 08:03:58 -08:00
caryclark
9ca30a3b9b
add path ops presentations to skia.org
...
TBR=hcm@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1518453003
Review URL: https://codereview.chromium.org/1518453003
2015-12-10 06:29:44 -08:00
kjlubick
222b30d3a8
Make building with clang documentation a bit easier to find
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1495913002
Review URL: https://codereview.chromium.org/1495913002
2015-12-03 09:20:55 -08:00
borenet
b1514801cc
Add documentation for Status bot filters
...
BUG=skia:4602
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1489583002
Review URL: https://codereview.chromium.org/1489583002
2015-11-30 09:58:56 -08:00
jcgregorio
15d5b82f90
Add an example of embedding a Skia Perf graph to the site docs.
...
This specific page:
https://skia.org/dev/testing/skiaperf?cl=1462583002
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1462583002
Review URL: https://codereview.chromium.org/1462583002
2015-11-18 11:14:31 -08:00
rmistry
7224ae9d51
Update all code site issue tracker links to point to bug.skia.org
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1461613002
Review URL: https://codereview.chromium.org/1461613002
2015-11-18 06:47:11 -08:00
hcm
059dbe1a31
Update issue tracker in docs
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1462493002
Review URL: https://codereview.chromium.org/1462493002
2015-11-18 05:04:08 -08:00
halcanary
b5002394d1
Documentation: Further cleanup
...
* /user/download: remove instruction to compile and run skia
tests - moved to /user/quick/${OS}
* /user/quick/desktop: move Gyp options to a section in the
FAQ (distracts from quick start narritive).
* /user/tips: reformat, rewrite.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1443653002
Review URL: https://codereview.chromium.org/1443653002
2015-11-16 07:37:23 -08:00
halcanary
e0c64c5846
Documentation: clean up
...
- /user/quick/desktop to bring together all common information for
using Skia on desktop OSes. Remove duplication.
- Replace all instances of call ing gyp_skia directly with calling
`python bin/sync-and-gyp`. This is more correct on Windows
- Remove outdated linux prerequisite packages
- Formatting, formatting, formatting.
- Note command-line syntax differences in Windows
- SampleApp.app is no longer a bundle on MacOS
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1439493003
Review URL: https://codereview.chromium.org/1439493003
2015-11-13 04:29:59 -08:00
Hal Canary
824f46ca2c
GYP: remove stale skia_scalar gyp variable
...
DOCS_PREVIEW= https://skia.org/?cl=1417703013
Review URL: https://codereview.chromium.org/1417703013 .
2015-11-10 13:25:12 -05:00
halcanary
3a210bfd40
Documentation - Remove references to gclient sync
...
skia.org/user/download
- Move sections "Making changes" and "Uploading changes for review"
to "How to submit a patch" page
- Mention bin/sync-and-gyp
skia.org/dev/contrib/submit
- Mention branch.autosetuprebase=always to fit with Skia's linear
history style.
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/download?cl=1411403010
DOCS_PREVIEW= https://skia.org/dev/contrib/submit?cl=1411403010
Review URL: https://codereview.chromium.org/1411403010
2015-11-09 11:47:09 -08:00
halcanary
6950de6c41
Comments Style: s/skbug.com/bug.skia.org/
...
DOCS_PREVIEW= https://skia.org/?cl=1432503003
Review URL: https://codereview.chromium.org/1432503003
2015-11-07 05:29:00 -08:00
hcm
6065d8eae6
Adding Skia Debugger documentation
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1414393010
Review URL: https://codereview.chromium.org/1414393010
2015-11-06 11:29:06 -08:00
stephana
5b8faf7c7c
Add docs on how to install iOS test tools
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1413653002
Review URL: https://codereview.chromium.org/1413653002
2015-10-16 11:47:37 -07:00
jvanverth
9617431dfe
Update iOS docs
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1399533005
Review URL: https://codereview.chromium.org/1399533005
2015-10-15 10:31:51 -07:00
benjaminwagner
e8dc3f2f0b
Move code search info to sub-page. Add additional code search options.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1375523003
Review URL: https://codereview.chromium.org/1375523003
2015-09-28 11:15:09 -07:00
halcanary
044284bba3
Documentation: minor style changes.
...
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1361393003
2015-09-24 04:39:33 -07:00
halcanary
04d7de42c1
Documentation: SkDocument::setMetadata()
...
Land after http://crrev.com/1359943003
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/sample/pdf?cl=1360193002
Review URL: https://codereview.chromium.org/1360193002
2015-09-23 12:50:54 -07:00
hcm
3e48aabbf1
update roadmap link to latest
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1354413003
Review URL: https://codereview.chromium.org/1354413003
2015-09-21 07:32:55 -07:00
jcgregorio
2440fcd941
skia.og: Update the home page to have a showcase of Skia capabilities.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1353473007
Review URL: https://codereview.chromium.org/1353473007
2015-09-18 14:05:41 -07:00
tomhudson
2582dc5395
DOC: Mention install_dependencies in Android quickstart
...
Embeds #prerequisites anchor in Linux so we don't duplicate the details.
TBR=hcm,jcgregorio
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1342263004
Review URL: https://codereview.chromium.org/1342263004
2015-09-17 08:28:15 -07:00
benjaminwagner
474df7fc03
Add documentation of cs.skia.org.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1332303005
Review URL: https://codereview.chromium.org/1332303005
2015-09-15 07:02:02 -07:00
benjaminwagner
212aab07d9
Provide link to worker logs.
...
BUG=skia:4063
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1338823002
Review URL: https://codereview.chromium.org/1338823002
2015-09-11 10:56:24 -07:00
mtklein
2bd5d02472
Add simd.md to document Skia SIMD code / plans.
...
BUG=skia:4117
NOTRY=true
DOCS_PREVIEW= https://skia.org/dev/contrib/simd?cl=1330083002
Review URL: https://codereview.chromium.org/1330083002
2015-09-10 14:21:12 -07:00
benjaminwagner
00c3252bb9
Update documentation of colors on Status.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1330063002
Review URL: https://codereview.chromium.org/1330063002
2015-09-08 12:51:23 -07:00
mdempsky
214046e8a1
Fix memory leak in build example
...
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1319703004
Review URL: https://codereview.chromium.org/1319703004
2015-09-03 12:19:23 -07:00
benjaminwagner
fbf908c857
Add some useful information to trooper doc.
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1308253005
Review URL: https://codereview.chromium.org/1308253005
2015-09-03 09:06:30 -07:00
benjaminwagner
9a40a9e6a5
Provide some detail about valentine password
...
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1317683006
Review URL: https://codereview.chromium.org/1317683006
2015-08-31 07:27:24 -07:00
benjaminwagner
5b4c69e555
Change 900k to 910k in another location.
...
BUG=skia:4063
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1317373002
Review URL: https://codereview.chromium.org/1317373002
2015-08-28 12:23:54 -07:00
benjaminwagner
fd0eca2583
Update CT documentation on Skia site.
...
BUG=skia:4063
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1314413002
Review URL: https://codereview.chromium.org/1314413002
2015-08-28 10:34:47 -07:00
halcanary
96fcdcc219
Style Change: NULL->nullptr
...
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
2015-08-27 07:41:16 -07:00
halcanary
385fe4d4b6
Style Change: SkNEW->new; SkDELETE->delete
...
DOCS_PREVIEW= https://skia.org/?cl=1316123003
Review URL: https://codereview.chromium.org/1316123003
2015-08-26 13:07:49 -07:00
rmistry
8d624bd44e
Add markdown for Infra troopers
...
BUG=skia:4251
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1313993002
Review URL: https://codereview.chromium.org/1313993002
2015-08-25 13:39:41 -07:00
hcm
7b076c41a1
Add internal links section to skia.org
...
BUG=skia:4142
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1284043004
Review URL: https://codereview.chromium.org/1284043004
2015-08-18 10:38:00 -07:00