1704 Commits

Author	SHA1	Message	Date
epoger	b492c6ff30	add --descriptions flag to render_pictures tool ... Needed because right now, when you look at the full set of SKP results in rebaseline_server, you can't tell which renderMode (or builder) generated each one. BUG=skia:2833 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/466153006	2014-08-14 07:32:50 -07:00
epoger	5c4b137592	rebaseline_server: include setA/setB descriptions in output JSON ... This is needed for rebaselining using the shared rebaseline_server instance: by telling the client which git revision was used to fetch expectations, we allow the client to pass that back along with new baselines (so the server knows which revision to patch). This is also handy in that it allows the server to tell the client more about the different result sets (which files they were generated from). BUG=skia:1918 NOTRY=true R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/474813002	2014-08-14 07:12:46 -07:00
epoger	30e26cdb41	rebaseline_server UI: add link to raw JSON ... patchset 3 from https://codereview.chromium.org/467843002 NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana Author: epoger@google.com Review URL: https://codereview.chromium.org/475623002	2014-08-13 19:29:49 -07:00
epoger	4c808253f4	rebaseline_server: move more code into common path for GET_live_results and GET_prefetch_results ... patchset 1 from issue 467843002 BUG=skia:1918 NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana Author: epoger@google.com Review URL: https://codereview.chromium.org/465143004	2014-08-13 19:23:33 -07:00
stephana	e8d74d988a	This is a bit of a hack, but will work. I have a cleaner fix ready (but still need to fix some broken tests). ... BUG=skia: NOTRY=true R=epoger@google.com Author: stephana@google.com Review URL: https://codereview.chromium.org/472703002	2014-08-13 19:12:59 -07:00
krajcevski	12b3544028	Add runtime flag to turn compressed alpha masks on ... R=bsalomon@google.com, robertphillips@google.com, mtklein@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/468293002	2014-08-13 12:06:26 -07:00
krajcevski	69a5560ea5	Add entry point for passing options to the GrContextFactory ... R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/465073002	2014-08-13 10:46:31 -07:00
stephana	21b342d19c	This eliminates the need to copy the generated images from a temporary directory to the directory that is served by the rebaseline_server. ... BUG=skia:2815, skia:2818 R=epoger@google.com Author: stephana@google.com Review URL: https://codereview.chromium.org/457203003	2014-08-13 10:36:06 -07:00
epoger	fb261109ec	rebaseline_server: add some live-view.html links to index.html ... NOTREECHECKS=true NOTRY=true R=stephana@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/463213002	2014-08-13 09:38:22 -07:00
dandov	cc03adb909	Proposal for the mesh gradient interface. Implemented as a grid of ... patches and uses 4 private arrays to store the values of the control points and colors. When it needs a patch at a certain position of the grid it just builds it using the corresponding values of the array and the grid coordinates provided. Details on implementation are documented in the corresponding classes' comments. Also added a gm for mesh gradients. BUG=skia: R=egdaniel@google.com, reed@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/451723003	2014-08-12 17:14:57 -07:00
dandov	b3c9d1c33c	SkCanvas::drawPatch param SkPoint[12] ... drawPatch now receives as parameter const SkPoint cubics[12] Adjusted derived classes and serialization. Ajusted GM's and benches that take into account combinations of optional parameters, the scale of the patch and 4 different types of patches. Planning on adding the extra functionality of SkPatch in another CL. BUG=skia: R=egdaniel@google.com, reed@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/463493002	2014-08-12 08:34:29 -07:00
epoger	9c7695b0b5	rebaseline_server: periodically log tasks_queue size ... Without this, it's hard to tell whether the server is stuck (or why it's taking so long). NOTRY=true R=stephana@google.com, rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/454953002	2014-08-12 08:30:10 -07:00
epoger	8d66dd1d43	change setA/setB labels if viewing actuals vs expectations ... NOTRY=true R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/451053004	2014-08-12 08:29:05 -07:00
reed	d7127e7b83	re-add samplerstress gm, but use blurmaskfilter instead (std filter) ... BUG=skia: R=robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/468483002	2014-08-12 06:53:09 -07:00
reed	5b1b2dbe76	remove SkStippleMaskFilter - no external clients ... TBR= Author: reed@google.com Review URL: https://codereview.chromium.org/462013002	2014-08-12 05:50:10 -07:00
joshualitt	5acfea789d	2D kernel initial wiring for Guassian ... BUG=skia: R=senorblanco@chromium.org, bsalomon@chromium.org, bsalomon@google.com Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/418223009	2014-08-11 13:55:34 -07:00
reed	d5fa1a455a	add drawPicture variant that takes a matrix and paint ... will need some staging strategy, since chrome and blink have overrides of onDrawPicture R=robertphillips@google.com, fmalita@google.com, bsalomon@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/448793004	2014-08-09 11:08:05 -07:00
krajcevski	a50b8f0ec0	Add R11 KTX GM ... R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/456873002	2014-08-08 11:38:27 -07:00
stephana	d9bf7dbf09	Rebaseline-server: sorting of columns in asc/desc order in frontend. ... NOTRY=true BUG=skia:1907 R=epoger@google.com Author: stephana@google.com Review URL: https://codereview.chromium.org/449843002	2014-08-08 07:21:00 -07:00
epoger	acc1258600	don't list out all sourceSkpFile names in the rebaseline_server UI ... (the list is long and crowds out the results themselves; better to use a text filter to select the sourceSkpFiles of interest) R=stephana@google.com TBR=stephana NOTREECHECKS=true NOTRY=true Author: epoger@google.com Review URL: https://codereview.chromium.org/451853002	2014-08-07 14:55:34 -07:00
epoger	c8d8a604bf	make rebaseline_server properly handle unescaped URLs ... R=rmistry@google.com TBR=rmistry NOTREECHECKS=true NOTRY=true Author: epoger@google.com Review URL: https://codereview.chromium.org/445753005	2014-08-07 14:39:06 -07:00
krajcevski	95b1b3d82d	Add astcbitmap to gm slides. ... Add additional ASTC formats. Add astc image decoder files. R=reed@google.com, robertphillips@google.com, halcanary@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/444093002	2014-08-07 12:58:38 -07:00
epoger	e73cd5ab0f	rebaseline_server: allow live queries to examine JSONKEY_EXPECTEDRESULTS or JSONKEY_ACTUALRESULTS ... See https://goto.google.com/CorrectnessTestingBigIssues for full context BUG=skia:1942 NOTRY=true R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/453433004	2014-08-07 12:13:13 -07:00
krajcevski	7b62448065	Revert of - Add astcbitmap to gm slides (https://codereview.chromium.org/444093002/) ... Reason for revert: Breaking DM Original issue's description: > - Add astcbitmap to gm slides > - Add additional ASTC formats > - Add astc image decoder files > > Committed: https://skia.googlesource.com/skia/+/2fc05823fed4b9649338f3029cd1ba05ef49a02f R=reed@google.com, robertphillips@google.com, halcanary@google.com TBR=halcanary@google.com, reed@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: krajcevski@google.com Review URL: https://codereview.chromium.org/447343002	2014-08-07 11:33:59 -07:00
krajcevski	2fc05823fe	- Add astcbitmap to gm slides ... - Add additional ASTC formats - Add astc image decoder files R=reed@google.com, robertphillips@google.com, halcanary@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/444093002	2014-08-07 11:18:09 -07:00
dandov	963137b75c	Stopped skipping tests in dm of SkPatch by implementing the ... corresponding drawPath calls on classes that derive from SkCanvas. BUG=skia: R=egdaniel@google.com, bsalomon@google.com, mtklein@google.com, robertphillips@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/429343004	2014-08-07 07:49:53 -07:00
fmalita	b5f7826c51	Explicit tile bounds for SkPictureShader ... The integer picture size is not granular enough to allow precise tiling in arbitrary coordinate systems. This CL adds an optional tile bounds float rect param to control the tile size and location. (this also allows tile spacing emulation for picture shaders). R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/437393003	2014-08-06 13:07:15 -07:00
humper	27ff227589	make the action buttons for rebaseline server stick to the top of the window as you scroll ... NOTRY=true BUG=skia:1912 R=stephana@google.com, epoger@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/446933002	2014-08-06 12:39:59 -07:00
epoger	3facc7c87d	rebaseline_server: add "prefetch" directive that just warms the cache without awaiting results ... This will allow the buildbots to warn the production rebaseline_server: "I just generated some new results; here's a comparison that a human might ask for soon. Download whatever images and generate whatever diffs you would need to provide those results." BUG=skia:1942 NOTREECHECKS=true NOTRY=true R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/443013002	2014-08-06 10:56:51 -07:00
epoger	7909f47b42	rebaseline_server live queries: allow comparison against summary files within the Skia repo ... This is a step towards providing SKP comparisons against expectations, not just other actual results... we still need to allow the user to select JSONKEY_EXPECTEDRESULTS vs JSONKEY_ACTUALRESULTS within the summary files found. BUG=skia:1942 NOTREECHECKS=true NOTRY=true R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/442203002	2014-08-06 08:37:53 -07:00
djsollen	1b27704eba	Remove ALL font fallback logic from Skia. ... R=reed@google.com, bungeman@google.com, caryclark@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/434623002	2014-08-06 06:58:06 -07:00
epoger	0b7127635d	teach rebaseline_server to generate diffs of rendered SKPs ... Creates a new live-view.html page, served by the rebaseline_server, that will display diffs between two sets of rendered SKP images. BUG=skia:1942 NOTRY=true R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/424263005	2014-08-05 10:07:22 -07:00
dandov	ecfff21bde	SkCanvas interface for drawing a patch. ... Added function SkCanvas::drawPatch to the API. This function receives the patch to draw and the paint. Added function SkBaseDevice::drawPatch to the API. This function also receives the patch to draw and the paint. Currently SkGpuDevice and SkBitmapDevice generate the mesh taking into account the scale factor and call the corresponding device's drawVertices. BUG=skia: R=jvanverth@google.com, egdaniel@google.com, bsalomon@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/424663006	2014-08-04 10:02:00 -07:00
Cary Clark	992c7b03ef	Add standard fonts to all GMs. ... Allow GM results to be compared across machines and platforms by standardizing the fonts used by all tests. This adds runtime flags to DM to use either the system font context (the default), the fonts in the resources directory ( --resourceFonts ) or a set of canonical paths generated from the fonts ( --portableFonts ). This CL should leave the current DM results unchanged by default. If the portable font data or resource font is missing when DM is run, it falls back to using the system font context. The create_test_font tool generates the paths and metrics read by DM with the --portableFonts flag set, and generates the font substitution tables read by DM with the --resourceFonts flag set. If DM is run in SkDebug mode with the --reportUsedChars flag set, it generates the corresponding data compiled into the create_test_font tool. All GM tests set their typeface information by calling either sk_tool_utils::set_portable_typeface or sk_tool_utils::portable_typeface . (The former takes the paint, the latter returns a SkTypeface.) These calls can be removed in the future when the Font Manager can be superceded. BUG=skia:2687 R=mtklein@google.com Review URL: https://codereview.chromium.org/407183003	2014-07-31 08:58:44 -04:00
joshualitt	5ae5fc59b2	Adding repeat mode to texture domain ... BUG=skia: R=bsalomon@chromium.org, senorblanco@chromium.org, bsalomon@google.com, junov@chromium.org Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/422123003	2014-07-29 12:59:27 -07:00
tfarina	a8e2e1504b	Cleanup: Rename SkOSPath functions. ... Mostly for brevity and matches better with Python: Python | Old C++ | New C++ os.path.join | SkOSPath::SkPathJoin | SkOSPath::Join os.path.basename | SkOSPath::SkBasename | SkOSPath::Basename BUG=None TEST=make all R=mtklein@google.com, bsalomon@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/428443002	2014-07-28 19:26:58 -07:00
cdalton	b2808cd041	Send less transform data when drawing text with nvpr ... Before this change, GrStencilAndCoverTextContext would send 6-float affine transforms to drawPaths for every glyph. This updates it to concat the text scale onto the context matrix, and then only send 2-float translates (or 1-float x-translates when possible). Also adds a glyph_pos_align test to gm that exercises the newly added codepaths, and starts ignoring a few gm tests with benign pixel diffs until we can rebaseline. BUG=skia: R=bsalomon@google.com, kkinnunen@nvidia.com, jvanverth@google.com, bungeman@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/406523003	2014-07-25 14:13:57 -07:00
dandov	50d715476b	Added classes SkPatch and SkPatchMesh which help encapsulate and generalize this new primitive. The functionality and responsability of each class is better explained in the comments of the files. ... Each patch defines a method genMesh that produces the geometry to draw. To do this they receive a SkPatchMesh object which they need to initialize in order to set up how the data is going to be formatted. Later they call function like setColor or pointAt to set the values at a specific index, the SkMeshPatch object handles the indices based on the format and makes it transparent to the client. Added a slide to sample app to show how to set up this classes and how they interact. BUG=skia: R=jvanverth@google.com, egdaniel@google.com, bsalomon@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/405163003	2014-07-25 10:44:54 -07:00
senorblanco	bc9845bb60	Remove the single-sigma version of SkDropShadowImageFilter::Create(). ... It's no longer used in Chrome. BUG=skia: R=bsalomon@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/407203002	2014-07-22 12:49:25 -07:00
bsalomon	dcabb05113	Make GrCacheable implement its own ref counting. ... R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/392333008	2014-07-21 14:24:01 -07:00
epoger	66ed8dc4bf	combine base_unittest.py modules from gm and tools ... general cleanup, which will also help with http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"') R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/397103003	2014-07-17 12:54:16 -07:00
epoger	a8f774549e	create copy_config.py and rename_config.py for skbug 2752 ... BUG=skia:2752 NOTRY=True (SkipBuildbotRuns) R=bsalomon@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/397293002	2014-07-17 08:22:12 -07:00
epoger	03f3db02c1	roll common DEPS, now using recursedeps ... BUG=skia:2618 R=borenet@google.com, cmp@chromium.org Author: epoger@google.com Review URL: https://codereview.chromium.org/392353003	2014-07-16 14:45:48 -07:00
Mike Klein	9d7321c9d0	Skip tiling on bitmapscroll: ... - off by exactly one pixel when using DirectWrite - also at least one pixel off on ChromeOS BUG=skia: R=bungeman@google.com Review URL: https://codereview.chromium.org/394243002	2014-07-16 14:19:54 -04:00
epoger	33ac9506fb	make gm self-tests launch python unittests automatically ... (not just within the rebaseline_server subdirectory) Generally useful, but needed asap for my work on http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"') BUG=skia:677 NOTREECHECKS=True NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/398043002	2014-07-16 08:28:23 -07:00
senorblanco	837f5321a4	Fix for saveLayer() with filters vs. the BBox Hierarchy. ... When building acceleration structures for SkPicture, we must transform the primitive's bounds not only by its own SkPaint, but by the paints of any saveLayer()s currently active above it. We do this by pushing the SkPaint onto a stack on saveLayer(), and popping them on restore(). We also push a NULL paint in save(), so that the pushes and pops are balanced. BUG=skia:2734 R=mtklein@google.com, reed@google.com, robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/6ca0b6a46cbe9bef3e2b9b9db813ec864efd62de Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/380373003	2014-07-14 10:19:55 -07:00
senorblanco	c07e2811dd	Revert "Fix for saveLayer() with filters vs. the BBox Hierarchy." and ... "resizeimagefiler is ok with a BBH now". This reverts commits 6ca0b6a46c and 8fa73202ea. Apparently causing problems in SKP playback. R=mtklein@google.com, robertphillips@google.com TBR=mtklein, robertphillips BUG=skia: Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/381353005	2014-07-14 08:25:34 -07:00
mtklein	8fa73202ea	resizeimagefiler is ok with a BBH now ... BUG=skia: R=senorblanco@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/387933002	2014-07-11 11:27:01 -07:00
epoger	133931f4ab	roll "common" DEPS, and replace tools/pyutils with it ... BUG=skia:2682 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/385783002	2014-07-11 08:52:35 -07:00
mtklein	e4636aa173	Merge Replay and Quilt tasks, adding in all BBH implementations. ... Replay isn't that helpful of a test any more now that we have the more stringent Quilt tests. Quilt was missing bounding box hierarchies, though, while Replay was sort of testing RTree (pointlessly, as it was drawing without any clip). Now Quilt does everything, testing RTree, QuadTree, and TileGrid. Quilt mode now falls back to drawing all at once (i.e. Replay) for GMs that don't tile perfectly. Still a TODO to make this check more flexible than exact pixel matches. Two GMs fail when using a BBH: - imageresizetiled - resizeimagefilter We think we're not adjusting the bounds of save layers by their paint. This is probably a bug, but one to be fixed separately from adding new tests. BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/377373003	2014-07-09 13:10:58 -07:00
epoger	6132b436d8	rebaseline_server: cache results in long-running ImageDiffDB instance ... Rather than rebuilding the ImageDiffDB from scratch every time we update expected/actual results, keep the same ImageDiffDB instance around and add image pairs to it. This makes updating results within a long-running server.py *much* faster, and tests out an idea I'm ruminating in https://goto.google.com/LongRunningImageDiffDBServer : we could run an ImageDiffDB server that developers could connect to from their locally running rebaseline_server instances, for much faster launch times. BUG=skia:2414 NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/379563005	2014-07-09 07:59:06 -07:00
epoger	b4edbffd7c	rebaseline_server: allow JSON to control column filtering ... Makes the rebaseline_server client more generic, allowing the server to tweak display properties by writing directives into the JSON file. Adds two new fields to the rebaseline_server JSON file (and thus increments VALUE__HEADER__SCHEMA_VERSION): 1. KEY__ROOT__EXTRACOLUMNORDER: order in which the client should display columns 2. KEY__EXTRACOLUMNHEADERS__USE_FREEFORM_FILTER: whether a column should be filtered using a freeform text field or checkboxes BUG=skia:2230 NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/376623002	2014-07-09 06:19:20 -07:00
bsalomon	83d081ae1d	Goodbye GrEffectRef. ... Also, reworked some var names and comments around SkShader::asNewEffect. R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/374923002	2014-07-08 09:56:11 -07:00
senorblanco	9ea3d57fde	Clean up SkImageFilter constructors. ... Now that all creation of SkImageFilters goes through factory Create() methods, there's no real reason for the convenience constructors. Some SkImageFilter subclasses which actually have zero DAG-able inputs were passing NULL to the superclass constructor. This actually means 1 input, with a NULL value, not zero inputs. This becomes more relevant for the upcoming cache infrastructure, where this indicates that the filter will use its src input, where in fact some of these filters do not (they are image generators only). Limiting SkImageFilter to a single constructor resolves this ambiguity. Along the way, I removed all of the default parameters to the constructors, since the Create methods always call them with the full argument list. BUG=skia: R=reed@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/376953003	2014-07-08 09:16:22 -07:00
sugoi	24dcac2140	YUV to RGB converter ... This is a first piece of the GPU YUV decoder, which is the actual effect that performs the conversion. For now, it simply applies the conversion matrix, since it is all I need. I may add modes if different matrices need to be applied or if I add color profile support here. I'll try to keep these cls short and easy to review, but there should be a few of them coming once this one is in. BUG=skia: R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, bsalomon@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/378503006	2014-07-07 15:09:49 -07:00
bsalomon	69456186f7	gpu and cpu flags for gm and bench. ... BUG=skia:2074 R=borenet@google.com, mtklein@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/376643002	2014-07-07 10:46:59 -07:00
mtklein	7cdc1ee115	Add always-threaded SkRecord quilt tests. ... Now that we're drawing tiles threaded like implside painting, remove the checks that those lock counts are balanced. They're just not right for anyone anymore. SkBitmaps themselves are not threadsafe (even const ones), so shallow copy them on playback of an SkRecord. (The underlying SkPixelRefs are threadsafe.) Simplify quilt drawing by using SkBitmap::extractSubset. No need for locking. Bump up to 256x256 tiles. 16x16 tiles just murders performance (way too much contention). This has the nice side effect of letting us enable a bunch more GMs for quilt mode; they drew wrong with small tiles but exactly right with large. BUG=171776 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/371023005	2014-07-07 10:41:04 -07:00
epoger	df55f0632a	rebaseline_server: handle column filtering more generically ... This is a step towards making rebaseline_server more flexible, and useful for displaying output of the cluster telemetry server as well as actuals-on-configA-vs-actuals-on-configB. BUG=skia:2230 R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/369133004	2014-07-07 08:49:14 -07:00
epoger	46e51e10ae	rebaseline_server: if urlSchemaVersion is not specified, assume current ... Modification to https://codereview.chromium.org/368933002/ ('rebaseline_server: add urlSchemaVersion parameter') Means we don't need https://codereview.chromium.org/367173002/ ('add urlSchemaVersion to rebaseline_server link on buildbot console page') NOTREECHECKS=True NOTRY=True R=borenet@google.com TBR=borenet Author: epoger@google.com Review URL: https://codereview.chromium.org/364253003	2014-07-03 10:50:30 -07:00
epoger	e5481eca7e	rebaseline_server: add urlSchemaVersion parameter ... In https://codereview.chromium.org/369473005 ('rebaseline_server: handle category filtering more generically'), I am changing the meaning of some URL parameters. If a user pastes an old URL into an updated rebaseline_server instance, they may get unexpected results. Adding a urlSchemaVersion parameter allows us to automatically convert the URL, or at least warn the user. BUG=skia:2230 NOTRY=True R=jcgregorio@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/368933002	2014-07-02 13:51:47 -07:00
epoger	54f1ad8bb5	rebaseline_server: use just skpdiff, not Python Image Library ... BUG=skia:2414 R=djsollen@google.com, borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/325413003	2014-07-02 07:43:04 -07:00
tfarina	c846f4a96b	Cleanup usage of GetResourcePath() after commit bcbc1788b4. ... There was a clean up opportunity left over after https://skia.googlesource.com/skia/+/bcbc1788b478b1e54079318ad073e8490aa66fae, that could make use of the default parameter of GetResourcePath() function to make some call sites cleaner. We decided to make it in a separate CL to make reviewer's and author's life easier, so we could catch errors and/or mistakes easily. BUG=None TEST=make all && out/Debug/dm && out/Debug/SampleApp R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/351133003	2014-07-01 12:35:49 -07:00
reed	52d9ac6c92	stop calling SkCanvas::getDevice ... BUG=skia: R=bsalomon@google.com, robertphillips@google.com, junov@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/355193006	2014-06-30 09:05:34 -07:00
Florin Malita	5f6102d079	SaveFlags be-gone ... Remove the deprecated save(SaveFlags), willSave(SaveFlags) and all traces of kMatrix_SaveFlags/kClip_SaveFlag. BUG=skia:2297 R=mtklein@google.com, reed@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/340403003	2014-06-30 10:13:28 -04:00
kkinnunen	80549fcdd5	Support using OpenGL ES context on desktop ... Support using OpenGL ES context on desktop for unix and Android platforms. This is mainly useful in development. Add --gpuAPI flag to gm, dm, bench, bench_pictures and render_pictures. The possible parameters for the flag are "gl" and "gles". R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/319043005	2014-06-30 06:36:31 -07:00
Mike Klein	a40239ca1e	Drop --clone from commands in skia repo. ... --clone, and SkPicture::clone(), are no longer. CQ_EXTRA_TRYBOTS=tryserver.skia:Housekeeper-PerCommit-Trybot BUG=skia: R=rmistry@google.com Review URL: https://codereview.chromium.org/343813006	2014-06-27 17:09:39 -04:00
senorblanco	7bf1068473	Remove SkBicubicImageFilter, and all related tests. ... Now that we have SkResizeImageFilter, and the bicubic resizing is part of skia proper, there's no need for a specialized image filter. BUG=skia: R=bsalomon@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/357793002	2014-06-25 14:39:06 -07:00
caryclark	5fb6bd4b7e	use platform-independent font for gm ... Create a custom typeface and scaler to render simple paths the same on all platforms. GM tests are modified to explicitly select the custom typeface. R=reed@google.com, mtklein@google.com, bungeman@google.com TBR=reed Author: caryclark@google.com Review URL: https://codereview.chromium.org/348323003	2014-06-23 11:25:00 -07:00
rmistry	c4b84aef1a	Revert of Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/354433002/) ... Reason for revert: Rebaseline CL is ready to be submitted Original issue's description: > Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/335603003/) > > Reason for revert: > Caused many shadertext GM failures > > Original issue's description: > > Fix SkPaint::measureText for stroked hairline text > > > > SkPaint::measureText and text drawing used different criteria for > > determining whether text should be drawn as paths or not. > > > > Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph > > positioning in the rendering. Mainly added in order to define what is the > > expected text rendering when hairline stroke is used with various transform > > options. > > > > The testcase also tries to note or highlight the fact that SkPaint::measureText > > is not expected to produce intuitively matching results when compared to a > > rendering, if the rendering is done so that the device ends up having a device > > transform. > > > > This fixes the glyph_pos_h_s (hairline, stroked) test-case. > > > > Ignore shadertext2_pdf-poppler.png gm on > > Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails. > > > > Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793 > > TBR=jvanverth@google.com,reed@google.com,kkinnunen@nvidia.com > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/abc9bb55ddfeb4b1a7acc335a34841fddcd22d27 R=jvanverth@google.com, reed@google.com, kkinnunen@nvidia.com TBR=jvanverth@google.com, kkinnunen@nvidia.com, reed@google.com NOTREECHECKS=true NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/349153005	2014-06-23 06:59:15 -07:00
rmistry	05ead8afe5	Revert of Support using OpenGL ES context on desktop (https://codereview.chromium.org/319043005/) ... Reason for revert: Caused segmentation fault on many builders. Please see reverted CL's msg #21 for details. Original issue's description: > Support using OpenGL ES context on desktop > > Support using OpenGL ES context on desktop for unix and Android platforms. This > is mainly useful in development. > > Add --gpuAPI flag to gm, dm, bench, bench_pictures and render_pictures. The > possible parameters for the flag are "gl" and "gles". > > Committed: https://skia.googlesource.com/skia/+/74fc727dc88ee24d89f88cb1709f963e9073aeb3 R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com, kkinnunen@nvidia.com TBR=bsalomon@google.com, kkinnunen@nvidia.com NOTREECHECKS=true NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/351583002	2014-06-23 06:13:46 -07:00
rmistry	abc9bb55dd	Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/335603003/) ... Reason for revert: Caused many shadertext GM failures Original issue's description: > Fix SkPaint::measureText for stroked hairline text > > SkPaint::measureText and text drawing used different criteria for > determining whether text should be drawn as paths or not. > > Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph > positioning in the rendering. Mainly added in order to define what is the > expected text rendering when hairline stroke is used with various transform > options. > > The testcase also tries to note or highlight the fact that SkPaint::measureText > is not expected to produce intuitively matching results when compared to a > rendering, if the rendering is done so that the device ends up having a device > transform. > > This fixes the glyph_pos_h_s (hairline, stroked) test-case. > > Ignore shadertext2_pdf-poppler.png gm on > Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails. > > Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793 R=jvanverth@google.com, reed@google.com, kkinnunen@nvidia.com TBR=jvanverth@google.com, kkinnunen@nvidia.com, reed@google.com NOTREECHECKS=true NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/354433002	2014-06-23 05:39:26 -07:00
kkinnunen	74fc727dc8	Support using OpenGL ES context on desktop ... Support using OpenGL ES context on desktop for unix and Android platforms. This is mainly useful in development. Add --gpuAPI flag to gm, dm, bench, bench_pictures and render_pictures. The possible parameters for the flag are "gl" and "gles". R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/319043005	2014-06-22 22:56:54 -07:00
kkinnunen	196af73802	Fix SkPaint::measureText for stroked hairline text ... SkPaint::measureText and text drawing used different criteria for determining whether text should be drawn as paths or not. Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph positioning in the rendering. Mainly added in order to define what is the expected text rendering when hairline stroke is used with various transform options. The testcase also tries to note or highlight the fact that SkPaint::measureText is not expected to produce intuitively matching results when compared to a rendering, if the rendering is done so that the device ends up having a device transform. This fixes the glyph_pos_h_s (hairline, stroked) test-case. Ignore shadertext2_pdf-poppler.png gm on Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails. R=jvanverth@google.com, reed@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/335603003	2014-06-22 22:18:14 -07:00
reed	bbf3e8982d	optimize circularclips to act as a bench, fix null-check bug in etcbench ... BUG=skia: R=krajcevski@google.com, rmistry@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/345183003	2014-06-20 11:33:59 -07:00
tfarina	bcbc1788b4	Refactor how we handle resources path in Tests. ... This idea emerged while doing https://codereview.chromium.org/321723002/ (commit 880914c35c). BUG=None TEST=make tests && out/Debug/tests R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/346453002	2014-06-18 14:32:49 -07:00
mtklein	30e6e2af14	Add basic stacktrace handler using libunwind. ... This means we will all have to apt-get install libunwind8-dev on Linux. Mac comes with everything we need already. BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/343583005	2014-06-18 11:44:18 -07:00
scroggo	f01a6c3663	In Android framework, make tools depend on jsoncpp ... Always build the tools with JSON, but either build our own or use the system's. Rename skia_build_json_writer to skia_use_system_jsoncpp, since we now always build with JSON. Remove SK_BUILD_JSON_WRITER, which was only there so we could build without JSON it in the framework. BUG=skia:2448 R=djsollen@google.com, reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/303913002	2014-06-18 10:31:40 -07:00
reed	c3b3266b7d	hide SkBitmap::Config entirely (behind a flag) ... patch from issue 339463002 TBR= I think the NoGPU failure is unrelated, so ignoring NOTRY=True Author: reed@google.com Review URL: https://codereview.chromium.org/340533002	2014-06-17 08:38:31 -07:00
reed	bfefc7c95f	hide Config in SkImageDecoder -- use SkColorType instead ... patch from issue 334613003 TBR=scroggo Author: reed@chromium.org Review URL: https://codereview.chromium.org/334793002	2014-06-12 17:40:00 -07:00
senorblanco	ce6a354e12	Fix tiled perlin noise. ... It turns out that the perlin implementation we inherited from WebKit does not actually generate tileable noise (see Chromium bug http://crbug.com/383495). The main problem is that when generating coordinates for gradient interpolation, it was attempting to wrap both x and (x + 1) simultaneously at the tile boundary (that is, either both or neither are wrapped). This obviously won't work, since along the tile seams, (x + 1) should be wrapped, but x should not. The same is true in y. This patch fixes both the CPU and GPU paths, renames some variables to more closely match the spec, and modifies the perlin noise GM to actually test tiling. (Note that the clipping the GM was doing was removed, since it's superfluous: it used to be necessary for image filters, but isn't anymore, and this isn't an image filter GM anyway.) R=sugoi@google.com, sugoi TBR=senorblanco Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/332523006	2014-06-12 11:24:20 -07:00
egdaniel	e61c411c12	Use vertex attributes for dash effect in gpu ... This will allow us to batch dashed lines together when drawing. Also, this removes the need for a coord transform matrix in the shader, thus we save the cost of uploading a new matrix uniform everytime we do a simple transform to the dashed line we are drawing. BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/326103002	2014-06-12 10:24:21 -07:00
epoger	984b97c496	rebaseline_server: delete no-longer-used weightedDiffMeasure ... (replaced by perceptual diff) NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/334533003	2014-06-11 20:35:59 -07:00
epoger	cbbc7bf971	rebaseline_server: change 2 image expectations within unittests ... NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/329933002	2014-06-11 20:02:26 -07:00
epoger	6b28120e4c	rebaseline_server: merge identical results (across multiple builders/configs) into a single row ... BUG=skia:2534 R=jcgregorio@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/326013002	2014-06-11 14:01:35 -07:00
tfarina	f539318f0d	Cleanup: Get rid of make_isize() function from gm.h. ... This helper function is not necessary. The same thing can be achieved by using SkISize::Make() provided by SkTSize API. BUG=skia:2645 TEST=make dm && out/Debug/dm R=robertphillips@google.com, reed@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/326523002	2014-06-09 23:59:03 -07:00
reed	6c22573edb	hide SkBitmap::setConfig ... patch from issue 325733002 TBR=scroggo Author: reed@chromium.org Review URL: https://codereview.chromium.org/322963002	2014-06-09 19:52:07 -07:00
bsalomon	7c5c9da436	GM/bench for text draws with various parameters and clip rects. ... R=jvanverth@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/319053002	2014-06-09 15:11:30 -07:00
tfarina	880914c35c	Reland "Clean up Test's resourcePath code." ... This relands commit 91359bed48 (Clean up Test's resourcePath code." BUG=None TEST=make dm && out/Debug/dm R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/321723002	2014-06-09 12:05:34 -07:00
egdaniel	8405ef9854	Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds. ... BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/311373003	2014-06-09 11:57:28 -07:00
epoger	89e8842821	remove GM result-grooming tools that use skia-autogen ... BUG=skia:553 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/320443002	2014-06-09 06:49:13 -07:00
robertphillips	9f1c241e0d	Remove SkPicture::kUsePathBoundsForClip_RecordingFlag ... The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer? R=reed@google.com, mtklein@google.com, djsollen@google.com, scroggo@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/316143003	2014-06-09 06:25:34 -07:00
mtklein	91359bed48	Revert of Clean up Test's resourcePath code. (https://codereview.chromium.org/319473003/) ... Reason for revert: Some benchmarks are written in a way that makes this change unsafe (e.g. const char* resPath = GetResourcePath().c_str(); in SkipZeroesBench) and Valgrind and ASAN caught that. We can try again after a more careful cleanup of GetResourcePath(). Original issue's description: > Clean up resourcePath code. > > 1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test. > 2) Make gResourcePath a static pointer to const char and move it inside the classes. > > BUG=None > TEST=make tests && out/Debug/tests > make gm && out/Debug/gm > make bench && out/Debug/bench > R=mtklein@google.com > > Committed: https://skia.googlesource.com/skia/+/52e4f413ffe2d281f9e90ff2147db08083ffcba7 R=tfarina@chromium.org TBR=tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Author: mtklein@google.com Review URL: https://codereview.chromium.org/320733002	2014-06-08 07:02:47 -07:00
tfarina	52e4f413ff	Clean up resourcePath code. ... 1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test. 2) Make gResourcePath a static pointer to const char and move it inside the classes. BUG=None TEST=make tests && out/Debug/tests make gm && out/Debug/gm make bench && out/Debug/bench R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/319473003	2014-06-07 20:50:44 -07:00
epoger	b144271179	reland "rebaseline_server: download actual-results.json files from GCS instead of SVN" ... relands https://codereview.chromium.org/310093003 with modifications. BUG=skia:2641 R=jcgregorio@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/313343003	2014-06-05 10:30:37 -07:00
reed	ddd014e652	remove SkBitmap::allocConfigPixels and update dox ... I see no callers in android R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/310283004	2014-06-05 08:51:20 -07:00
epoger	77f68b623e	Revert "rebaseline_server: download actual-results.json files from GCS instead of SVN" ... This reverts commit f4666045f3. BUG=skia:2641 NOTREECHECKS=True NOTRY=True R=jcgregorio@google.com TBR=jcgregorio Author: epoger@google.com Review URL: https://codereview.chromium.org/317783004	2014-06-04 15:09:18 -07:00
epoger	f4666045f3	rebaseline_server: download actual-results.json files from GCS instead of SVN ... BUG=skia:553 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/310093003	2014-06-04 10:02:58 -07:00
krajcevski	2dc337c3ae	Add non power of two gm for ETC1 bitmap ... R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/316813005	2014-06-04 09:57:48 -07:00
robertphillips	9b14f26d0f	Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) ... R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/313613004	2014-06-04 05:40:44 -07:00
krajcevski	99ffe24200	Initial KTX file decoder ... R=bsalomon@google.com, robertphillips@google.com, halcanary@google.com, reed@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/302333002	2014-06-03 13:04:35 -07:00
epoger	55ada0630e	download_actuals.py: download JSON files from Google Storage instead of skia-autogen ... uses google-api-python-client instead of gsutil binary to interact with Google Storage BUG=skia:553 R=rmistry@google.com, bensong@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/309653005	2014-06-03 10:35:28 -07:00
mtklein	04cd368cb4	Fix memory leak in etc1bitmap GM. ... We never drop our first ref on fileData. (All our ref counts start at one). SkAutoTUnref<T> is almost always the right thing to use for refcounted types. BUG=skia:2635 R=krajcevski@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/310793003	2014-06-03 09:04:34 -07:00
scroggo	ef470f185f	Remove brackets from gm names. ... BUG=skia:2634 R=epoger@google.com, borenet@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/307373003	2014-06-03 06:50:26 -07:00
krajcevski	9c0e629c64	Initial work to get ETC1 data up to the GPU ... Committed: http://code.google.com/p/skia/source/detail?r=15001 R=bsalomon@google.com, robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/302783002	2014-06-02 07:38:15 -07:00
commit-bot@chromium.org	999cfd1076	Revert of Initial work to get ETC1 data up to the GPU (https://codereview.chromium.org/302783002/) ... Reason for revert: ETC1 linking problems with chrome. Original issue's description: > Initial work to get ETC1 data up to the GPU > > Committed: http://code.google.com/p/skia/source/detail?r=15001 R=bsalomon@google.com, robertphillips@google.com TBR=bsalomon@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: krajcevski@google.com Review URL: https://codereview.chromium.org/303273008 git-svn-id: http://skia.googlecode.com/svn/trunk@15004 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-30 20:36:21 +00:00
commit-bot@chromium.org	af091a176d	Initial work to get ETC1 data up to the GPU ... R=bsalomon@google.com, robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/302783002 git-svn-id: http://skia.googlecode.com/svn/trunk@15001 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-30 18:41:39 +00:00
commit-bot@chromium.org	9a558d495d	using real tiles when simulating tiling ... BUG=skia: R=mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/303403003 git-svn-id: http://skia.googlecode.com/svn/trunk@14993 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-30 15:06:24 +00:00
commit-bot@chromium.org	a3264e53ee	Revert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)" ... This reverts commit eecaea4148805834f223681f70b6488ceba12d09. R=robertphillips@google.com, scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/301283003 git-svn-id: http://skia.googlecode.com/svn/trunk@14989 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-30 13:26:10 +00:00
commit-bot@chromium.org	d0f824cfbd	Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/) ... Reason for revert: broke all Windows bots Original issue's description: > setConfig -> setInfo > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14978 R=robertphillips@google.com, reed@google.com TBR=reed@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: epoger@google.com Review URL: https://codereview.chromium.org/302053002 git-svn-id: http://skia.googlecode.com/svn/trunk@14979 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-29 21:10:32 +00:00
commit-bot@chromium.org	986d681f3e	setConfig -> setInfo ... BUG=skia: R=robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/308683005 git-svn-id: http://skia.googlecode.com/svn/trunk@14978 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-29 20:47:53 +00:00
commit-bot@chromium.org	cba73780bb	replace config() with colorType() ... BUG=skia: R=robertphillips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/303543009 git-svn-id: http://skia.googlecode.com/svn/trunk@14959 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-29 15:57:47 +00:00
commit-bot@chromium.org	00f8d6c75d	Revert "Revert of add colortable support to imagegenerator (https://codereview.chromium.org/304443003/)" ... Fix is to add colortable param to installPixels() This reverts commit 924205aaf2. BUG=skia: R=scroggo@google.com, reed@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/300263005 git-svn-id: http://skia.googlecode.com/svn/trunk@14958 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-29 15:57:20 +00:00
commit-bot@chromium.org	793ddd994a	Shut up windows build errors on new GM ... BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/300973005 git-svn-id: http://skia.googlecode.com/svn/trunk@14941 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-28 22:42:31 +00:00
commit-bot@chromium.org	3c1594aacb	make new blurrect GM and replace the dozens of existing ones ... BUG= NOTRY=True R=reed@google.com, epoger@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/306583007 git-svn-id: http://skia.googlecode.com/svn/trunk@14940 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-28 21:52:12 +00:00
commit-bot@chromium.org	f449156bd0	Make image scaling have floating point scales. Third attempt to land this ... due to some struggles with the CQ. Original CL here: https://codereview.chromium.org/298243003/ BUG= R=bsalomon@google.com, epoger@google.com TBR=bsalomon, epoger Author: humper@google.com Review URL: https://codereview.chromium.org/300113008 git-svn-id: http://skia.googlecode.com/svn/trunk@14920 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-28 17:30:02 +00:00
commit-bot@chromium.org	466f5f3e44	remove SkBitmap::asImageInfo ... BUG=skia: R=scroggo@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/305483005 git-svn-id: http://skia.googlecode.com/svn/trunk@14909 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-27 21:30:37 +00:00
epoger@google.com	f3b1eb4ea2	Manual SVN revert of https://code.google.com/p/skia/source/detail?r=14905 ... git-svn-id: http://skia.googlecode.com/svn/trunk@14907 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-27 21:12:42 +00:00
commit-bot@chromium.org	44f41293ac	floating point scale factors for images ... New version of https://codereview.chromium.org/298243003/ made to deal with binary file being lost. BUG= TBR=bsalomon NOTRY=true Author: humper@google.com Review URL: https://codereview.chromium.org/307553005 git-svn-id: http://skia.googlecode.com/svn/trunk@14905 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-27 20:54:04 +00:00
commit-bot@chromium.org	60c8d24f84	Remove some unnecessary uses of SkOnce. ... - gm/imagefiltersgraph.cpp can just use a global registrar - SkScaledImageCache always accesses its global under a lock BUG=skia: R=bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/297273006 git-svn-id: http://skia.googlecode.com/svn/trunk@14897 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-27 16:28:43 +00:00
commit-bot@chromium.org	2d970b5128	hide discardable factory from public imagegenerator api ... BUG=skia: R=halcanary@google.com, scroggo@google.com, djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/295243006 git-svn-id: http://skia.googlecode.com/svn/trunk@14889 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-27 14:14:22 +00:00
skia.committer@gmail.com	7693dbf46e	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@14862 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-23 03:03:34 +00:00
robertphillips@google.com	8cf81e0f4f	Simple PKM image decoder. ... https://codereview.chromium.org/292663011/ git-svn-id: http://skia.googlecode.com/svn/trunk@14852 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-22 18:40:29 +00:00
reed@google.com	7cb5e4797e	tweak stroketext GM to actually test dashing ... git-svn-id: http://skia.googlecode.com/svn/trunk@14850 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-22 17:59:51 +00:00
commit-bot@chromium.org	74266814a0	update stroketext gm ... TBR=bungeman Author: reed@google.com Review URL: https://codereview.chromium.org/293983016 git-svn-id: http://skia.googlecode.com/svn/trunk@14848 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-22 17:41:41 +00:00
commit-bot@chromium.org	83f23d87f1	Remove unused (by clients) SkUnitMapper ... This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98. TBR=scroggo Author: reed@google.com Review URL: https://codereview.chromium.org/288313009 git-svn-id: http://skia.googlecode.com/svn/trunk@14842 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-22 12:27:41 +00:00
commit-bot@chromium.org	3339ac54a5	Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (https://codereview.chromium.org/288343009/) ... Reason for revert: required blink change failed to land Original issue's description: > Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) > > This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f. > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14830 R=scroggo@google.com, reed@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@chromium.org Review URL: https://codereview.chromium.org/296823008 git-svn-id: http://skia.googlecode.com/svn/trunk@14838 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-22 02:55:59 +00:00
commit-bot@chromium.org	4b8f802255	Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) ... This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f. BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/288343009 git-svn-id: http://skia.googlecode.com/svn/trunk@14830 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-21 19:56:46 +00:00
commit-bot@chromium.org	71db88225d	Real fix for Widnows build errors for GrDashingEffect ... NOTREECHECKS=True NOTRY=True R=bsalomon@google.com TBR=bsalomon@google.com BUG=skia: Author: egdaniel@google.com Review URL: https://codereview.chromium.org/291903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14777 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-19 14:59:04 +00:00
commit-bot@chromium.org	628ed0b220	Add Dashing gpu effect for simple dashed lines ... BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/274673004 git-svn-id: http://skia.googlecode.com/svn/trunk@14775 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-19 14:32:49 +00:00
commit-bot@chromium.org	25c1066e4d	Generate gm/Android.mk, minus JSON. ... When running gyp_to_android.py, generate the makefile for gm. For now, remove json functionality and do not depend on json. This allows us to build and run until solving skbug.com/2448. gm/gm_expectations.cpp: gm/gm_expectations.h: gm/gmmain.cpp: Remove all json functionality when SK_BUILD_JSON_WRITER is not defined. This flag is not defined when SK_BUILD_FOR_ANDROID is defined. gyp/gm.gyp: Depend on skia and cutils. platform_tools/android/bin/gyp_to_android.py: Generate gm/Android.mk. platform_tools/android/gyp_gen/makefile_writer.py: Build gm/Android.mk when building external/skia. Depends on https://codereview.chromium.org/282053002/ BUG=skia:2447 BUG=skia:2448 R=epoger@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/281303003 git-svn-id: http://skia.googlecode.com/svn/trunk@14767 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-16 17:56:43 +00:00
commit-bot@chromium.org	e2b193ca5c	Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) ... Reason for revert: does not address all legacy callsites in chrome. e.g. [13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’ [13:45:32.091919] gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL)); Original issue's description: > remove unused (by clients) SkUnitMapper > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14761 R=robertphillips@google.com, scroggo@google.com, george@mozilla.com TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/287063009 git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-16 13:49:08 +00:00
commit-bot@chromium.org	ee0cac336c	remove unused (by clients) SkUnitMapper ... BUG=skia: R=robertphillips@google.com, scroggo@google.com, george@mozilla.com Author: reed@google.com Review URL: https://codereview.chromium.org/283273002 git-svn-id: http://skia.googlecode.com/svn/trunk@14761 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-16 13:35:01 +00:00
commit-bot@chromium.org	4cef1be821	rebaseline_server: apply ignored-tests.txt within rebaseline_server, not just on the bots ... (SkipBuildbotRuns) BUG=skia:2514 NOTREECHECKS=True NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/287623006 git-svn-id: http://skia.googlecode.com/svn/trunk@14740 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-14 18:04:46 +00:00
skia.committer@gmail.com	e92c68f7d7	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@14705 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-13 03:06:05 +00:00
commit-bot@chromium.org	5970f625e9	re-land hide get/setLocalMatrix ... This reverts commit b1d702a43b07934f5b001b1b09db2c57ede909a1. TBR=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/279903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14702 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-12 20:42:21 +00:00
commit-bot@chromium.org	68a3815401	rename rebaseline_server JSON constants to be more consistent ... (no behavioral change, no change to JSON file format) (SkipBuildbotRuns) NOTREECHECKS=True NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/287473002 git-svn-id: http://skia.googlecode.com/svn/trunk@14701 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-12 20:40:29 +00:00
reed@google.com	a501a64827	add new perlin noise gm to test localmatrix ... BUG=skia: Review URL: https://codereview.chromium.org/283533002 git-svn-id: http://skia.googlecode.com/svn/trunk@14698 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-12 17:18:45 +00:00
commit-bot@chromium.org	261d0153e2	Clean up global gSkSuppressFontCachePurgeSpew. ... No one is using it except to flick it to true to shut up the spew, but the spew is already guarded by #ifdef SPEW_PURGE_STATUS. Let's leave it to SPEW_PURGE_STATUS. Noticed this specificially when TSAN complained about FontScalerBench modifying it in a thread-unsafe way. BUG=skia:1792 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/264333008 git-svn-id: http://skia.googlecode.com/svn/trunk@14697 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-12 15:48:38 +00:00
bungeman@google.com	5d20caea15	Allow for no pdf rasterizers in gm. ... Our poppler does not build properly with VS2013, but using gyp_skia -Dskia_enable_poppler_enabled=0 also does not build due to kPDFRasterizers being statically empty. This adds a do nothing, not run by default 'pdf rasterizer'. R=epoger@google.com Review URL: https://codereview.chromium.org/270263009 git-svn-id: http://skia.googlecode.com/svn/trunk@14676 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-09 15:22:41 +00:00
commit-bot@chromium.org	95c2003740	cleanup GrContext resource cache api ... R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/275563005 git-svn-id: http://skia.googlecode.com/svn/trunk@14669 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-09 14:29:32 +00:00
commit-bot@chromium.org	90c0fbd349	reland "extract some common code from PictureRenderer" ... re-lands https://codereview.chromium.org/273703006/ NOTRY=True R=bungeman@google.com, djsollen@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/278633002 git-svn-id: http://skia.googlecode.com/svn/trunk@14662 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-09 03:18:41 +00:00
commit-bot@chromium.org	97f0b089da	rebaseline_server JSON: pass category values as values, not keys ... BUG=skia:1758 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/270413002 git-svn-id: http://skia.googlecode.com/svn/trunk@14658 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-08 21:15:20 +00:00
commit-bot@chromium.org	de3ad9e220	Revert of extract some common code from PictureRenderer (https://codereview.chromium.org/273703006/) ... Reason for revert: breaking the android debug builds. It seems to be the result of android using shared libs and not lumping everything into one big static lib or executable. So we have more than one copy of SkString which is the root of the issue. Original issue's description: > extract some common code from PictureRenderer > > Committed: http://code.google.com/p/skia/source/detail?r=14638 R=borenet@google.com, epoger@google.com TBR=borenet@google.com, epoger@google.com NOTREECHECKS=true NOTRY=true Author: djsollen@google.com Review URL: https://codereview.chromium.org/274463004 git-svn-id: http://skia.googlecode.com/svn/trunk@14649 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-08 16:23:56 +00:00
commit-bot@chromium.org	0ecbfffa82	rebaseline_server: add link to other result sets from main UI ... BUG=skia:2529 NOTREECHECKS=True NOTRY=True (SkipBuildbotRuns) R=caryclark@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/267363010 git-svn-id: http://skia.googlecode.com/svn/trunk@14648 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-08 15:40:06 +00:00
commit-bot@chromium.org	ee18f2a3c9	extract some common code from PictureRenderer ... R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/273703006 git-svn-id: http://skia.googlecode.com/svn/trunk@14638 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-08 14:48:44 +00:00
commit-bot@chromium.org	a60d0370b1	make compare_rendered_pictures_test.py run end-to-end test ... 1. generate test SKPs using skpmaker 2. render those SKPs using render_pictures 3. compare results using compare_rendered_pictures.py BUG=skia:1942,skia:2230 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/274623002 git-svn-id: http://skia.googlecode.com/svn/trunk@14624 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-07 19:29:03 +00:00
commit-bot@chromium.org	d53b22754d	New GM for testing circle blur optimization ... BUG=skia: R=bsalomon@google.com, mtklein@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/276453002 git-svn-id: http://skia.googlecode.com/svn/trunk@14621 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-07 17:50:03 +00:00
commit-bot@chromium.org	eaca36b657	remove dead mipmap code from SkBitmap ... BUG=skia: R=fmalita@google.com, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/271693002 git-svn-id: http://skia.googlecode.com/svn/trunk@14611 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-07 15:05:34 +00:00
commit-bot@chromium.org	7418bd8cad	make compare_rendered_pictures process render_pictures's new JSON output format ... BUG=skia:1942,skia:2230 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/265793013 git-svn-id: http://skia.googlecode.com/svn/trunk@14591 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-06 15:31:31 +00:00
skia.committer@gmail.com	edda70e020	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@14584 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-06 03:06:53 +00:00
reed@google.com	60da8f3952	new vertices gm to test alpha ... git-svn-id: http://skia.googlecode.com/svn/trunk@14580 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-05 20:41:21 +00:00
reed@google.com	775bf661bb	suppress new composeshader gm for quilt testing ... git-svn-id: http://skia.googlecode.com/svn/trunk@14579 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-05 19:37:22 +00:00
commit-bot@chromium.org	58e428729b	change composeshader_alpha to exercise srcover as well ... BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/263083011 git-svn-id: http://skia.googlecode.com/svn/trunk@14572 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-05 18:23:54 +00:00
commit-bot@chromium.org	ec7d673999	new gm for composeshader, exercising alpha ... BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/262193004 git-svn-id: http://skia.googlecode.com/svn/trunk@14567 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-05 16:19:08 +00:00
commit-bot@chromium.org	5aacfe9ffc	Remove setLocalMatrix calls from picture shader GM. ... This makes all --skr tests pass for me. Enabling it by default in DM. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14549 R=reed@google.com, mtklein@google.com, fmalita@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/260863007 git-svn-id: http://skia.googlecode.com/svn/trunk@14551 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-02 21:23:52 +00:00
commit-bot@chromium.org	c09abe66c1	Revert of Remove setLocalMatrix calls from picture shader GM. (https://codereview.chromium.org/260863007/) ... Reason for revert: changed GM unexpectedly. will sort out and try again Original issue's description: > Remove setLocalMatrix calls from picture shader GM. > > This makes all --skr tests pass for me. Enabling it by default in DM. > > BUG=skia:2378 > > Committed: http://code.google.com/p/skia/source/detail?r=14549 R=reed@google.com, fmalita@google.com, mtklein@chromium.org TBR=fmalita@google.com, mtklein@chromium.org, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2378 Author: mtklein@google.com Review URL: https://codereview.chromium.org/265013003 git-svn-id: http://skia.googlecode.com/svn/trunk@14550 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-02 20:51:13 +00:00
commit-bot@chromium.org	74b8cb15e4	Remove setLocalMatrix calls from picture shader GM. ... This makes all --skr tests pass for me. Enabling it by default in DM. BUG=skia:2378 R=reed@google.com, mtklein@google.com, fmalita@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/260863007 git-svn-id: http://skia.googlecode.com/svn/trunk@14549 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-02 20:30:11 +00:00
commit-bot@chromium.org	5d415079fc	Mark drawbitmaprect's large bitmaps as immutable. ... This reduces the peak memory usage of out/Debug/dm --skr --match drawbitmaprect from ~1.6G to ~200M. I'm not sure how the numbers got so huge to begin with from a 2K x 2K 8888 bitmap (16MB). BUG=skia:2378 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/265813007 git-svn-id: http://skia.googlecode.com/svn/trunk@14529 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-02 14:22:38 +00:00
commit-bot@chromium.org	658e59507d	tweaks to tab CSS for rebaseline server page; moar pretty ... BUG=skia: R=epoger@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/264853004 git-svn-id: http://skia.googlecode.com/svn/trunk@14512 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-05-01 19:29:53 +00:00
commit-bot@chromium.org	6323844cb3	rebaseline_server: ignore builders we don't have any expectations for ... (SkipBuildbotRuns) BUG=skia:2486 NOTREECHECKS=True NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/269543002 git-svn-id: http://skia.googlecode.com/svn/trunk@14488 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-30 21:32:37 +00:00
commit-bot@chromium.org	1a98a0604b	one valgrind.supp to rule them all. ... R=mtklein@google.com, robertphillips@google.com, borenet@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/268473004 git-svn-id: http://skia.googlecode.com/svn/trunk@14487 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-30 21:10:13 +00:00
commit-bot@chromium.org	a90c680386	Turn on quilt mode in DM. ... - Rename TileGrid -> Quilt to avoid the name overload. - Tag all failing GMs with kSkipTiled_Flag. You may be wondering, do any GMs pass? Yes, some do! And that trends towards all of them as we increase --quiltTile. Two GMs only fail in --quilt mode in 565. Otherwise all GMs which fail are skipped, and those which don't fail aren't. (The 8888 variants of those two GMs are skipped even though they pass.) BUG=skia:2477 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/256373002 git-svn-id: http://skia.googlecode.com/svn/trunk@14457 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-30 13:20:45 +00:00
commit-bot@chromium.org	bd09045253	fix bitmap shader leak in gm ... this was introduced in https://codereview.chromium.org/245963010 this was detected by caryclark@ by examining the result of valgrind on the skia buildbots BUG=skia:1976 R=caryclark@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/255253002 git-svn-id: http://skia.googlecode.com/svn/trunk@14450 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-29 21:46:59 +00:00
senorblanco@chromium.org	0a5c233e3b	Implement bounds traversals for tile and matrix convolution filters. ... Add a new GM that exercises tiled drawing all pixel-moving filters (and some non-pixel-moving ones) and compares it against non-tiled drawing of the same filters. Fixing this test revealed that tile and matrix convolution filters had no onFilterBounds() traversals (test-driven development FTW). Tile requires (conservatively) the bounds to include the whole source rect, since it may end up in the result. Matrix convolution requires the bounds to be offset by the kernel size and target. R=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/258243005 git-svn-id: http://skia.googlecode.com/svn/trunk@14432 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-29 15:20:39 +00:00
commit-bot@chromium.org	3d8bf232bd	Fast path for blurred round rects -- blur a small 9patch rect on the CPU ... And nonlinearly stretch the resulting texture across proxy geometry. BUG= Committed: http://code.google.com/p/skia/source/detail?r=14392 Committed: http://code.google.com/p/skia/source/detail?r=14404 R=bsalomon@google.com, reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/248613004 git-svn-id: http://skia.googlecode.com/svn/trunk@14420 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-28 19:49:24 +00:00
commit-bot@chromium.org	55aec08681	revert humper changes ... https://skia.googlesource.com/skia.git/+/24e91ba3029a3a1fb60cab3ae4e68c3c44776f25 https://skia.googlesource.com/skia.git/+/a36c78240e14aeb130a97c43f3992ea19696b929 NOTREECHECKS=true BUG=skia: R=caryclark@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/256803011 git-svn-id: http://skia.googlecode.com/svn/trunk@14414 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-28 18:21:24 +00:00
commit-bot@chromium.org	e396455d2d	move common blur types into central header ... BUG=skia: R=scroggo@google.com, djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/253833002 git-svn-id: http://skia.googlecode.com/svn/trunk@14411 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-28 16:25:35 +00:00
commit-bot@chromium.org	24e91ba302	Fast path for blurred round rects -- blur a small 9patch rect on the CPU ... And nonlinearly stretch the resulting texture across proxy geometry. BUG= Committed: http://code.google.com/p/skia/source/detail?r=14392 R=bsalomon@google.com, reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/248613004 git-svn-id: http://skia.googlecode.com/svn/trunk@14404 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-28 15:09:14 +00:00
commit-bot@chromium.org	9c9005a347	Move SkShader::fLocalMatrix into SkShader constructor. ... As a first step towards removing SkShader::setLocalMatrix, which will make SkShader thread-safe, remove calls to setLocalMatrix that happen immediately after the shader is being created. Instead, pass the matrix into the constructor or factory method. BUG=skia:1976 R=scroggo@google.com, reed@google.com, skyostil@google.com, mtklein@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/245963010 git-svn-id: http://skia.googlecode.com/svn/trunk@14401 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-28 14:55:39 +00:00
commit-bot@chromium.org	c76a4b2a81	Revert of Fast path for blurred round rects -- blur a small 9patch rect on the CPU (https://codereview.chromium.org/248613004/) ... Reason for revert: Looks like this causes unit tests to fail with a zero constructor like this one: http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Release/builds/2326/steps/RunTests/logs/stdio Original issue's description: > Fast path for blurred round rects -- blur a small 9patch rect on the CPU > And nonlinearly stretch the resulting texture across proxy geometry. > > BUG= > > Committed: http://code.google.com/p/skia/source/detail?r=14392 R=bsalomon@google.com, reed@google.com, humper@google.com TBR=bsalomon@google.com, humper@google.com, reed@google.com NOTREECHECKS=true NOTRY=true BUG= Author: caryclark@google.com Review URL: https://codereview.chromium.org/258893010 git-svn-id: http://skia.googlecode.com/svn/trunk@14400 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-28 14:44:54 +00:00
commit-bot@chromium.org	5729387fe0	Fast path for blurred round rects -- blur a small 9patch rect on the CPU ... And nonlinearly stretch the resulting texture across proxy geometry. BUG= R=bsalomon@google.com, reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/248613004 git-svn-id: http://skia.googlecode.com/svn/trunk@14392 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-28 13:19:23 +00:00
commit-bot@chromium.org	9d3fdbeb7b	rebaseline_server unittests: output tkdiff lines when actuals don't match expectations ... (SkipBuildbotRuns) NOTREECHECKS=True NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/252583005 git-svn-id: http://skia.googlecode.com/svn/trunk@14385 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-25 19:59:44 +00:00
bsalomon@google.com	0b27f2ec0f	Fix int->scalar warning on windows ... Review URL: https://codereview.chromium.org/257693002 git-svn-id: http://skia.googlecode.com/svn/trunk@14366 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-24 21:23:37 +00:00
commit-bot@chromium.org	04f03d1fad	Add GM that exercises SkCanvas::discard() ... R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/252443007 git-svn-id: http://skia.googlecode.com/svn/trunk@14365 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-24 21:03:00 +00:00
bsalomon@google.com	2a9e3ad71b	Disable cgimage GM ... TBR=reed@google.com Review URL: https://codereview.chromium.org/249873002 git-svn-id: http://skia.googlecode.com/svn/trunk@14327 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-23 18:05:36 +00:00
skia.committer@gmail.com	ede0c5c778	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@14320 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-23 03:04:11 +00:00
commit-bot@chromium.org	80894678ca	Fix double to SkScalar issues in SkTwoPointConicalGradient_gpu.cpp ... NOTREECHECKS=True NOTRY=True TBR=bsalomon@google.com BUG=skia: Author: egdaniel@google.com Review URL: https://codereview.chromium.org/247833003 git-svn-id: http://skia.googlecode.com/svn/trunk@14318 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-22 21:24:22 +00:00
commit-bot@chromium.org	c8379d7f1b	Add gpu fast path for two point conical gradients. ... Also shader changes should help numerical issues on certain android gpus BUG=179264 R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/238443006 git-svn-id: http://skia.googlecode.com/svn/trunk@14316 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-22 20:56:37 +00:00
commit-bot@chromium.org	60b5dce199	expose CGImage -> SkBitmap ... BUG=skia: R=scroggo@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/243463005 git-svn-id: http://skia.googlecode.com/svn/trunk@14315 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-22 20:24:33 +00:00
bsalomon@google.com	c25cec5f9a	SkDELETE() -> SkDELETE_ARRAY() in gradients_many test ... Attempt to fix valgrind failure: http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/builds/489/steps/GenerateGMs/logs/stdio TBR=reed@google.com Review URL: https://codereview.chromium.org/245273002 git-svn-id: http://skia.googlecode.com/svn/trunk@14280 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-21 15:30:45 +00:00
skia.committer@gmail.com	8a777a5e6a	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@14264 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-19 03:04:56 +00:00
robertphillips@google.com	770963f23f	Staging for cleanup of SkPicture-related headers ... https://codereview.chromium.org/243173002 git-svn-id: http://skia.googlecode.com/svn/trunk@14258 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-18 18:04:41 +00:00
reed@google.com	7b8999b504	gradient_many gm to test banding and precision ... BUG=skia: Review URL: https://codereview.chromium.org/243133005 git-svn-id: http://skia.googlecode.com/svn/trunk@14257 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-18 17:55:37 +00:00
commit-bot@chromium.org	091a594dbc	Reduce internal explicit SaveFlags usage. ... Most of these are either redundant/defaults or (hopefully) unnecessarily specific. R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/241453003 git-svn-id: http://skia.googlecode.com/svn/trunk@14253 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-18 14:19:31 +00:00
commit-bot@chromium.org	5fb2ce38b3	Staged removal of SkPicture-derived classes ... This CL removes the SkPicture-derived classes (with a flag to keeps clients working). In the process it also lightens the recording factory function so it is no longer ref counted). The only interesting bits are in SkPicture* and Sk*Picture.* R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/238273012 git-svn-id: http://skia.googlecode.com/svn/trunk@14251 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-17 23:35:06 +00:00
commit-bot@chromium.org	d393b17cf3	Retract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API ... This CL sets the stage for retracting the SkPicture::kOptimizeForClippedPlayback_RecordingFlag flag from the public API (more work needs to be done in Blink & Chrome). In the new world the only way to set this flag (and thus instantiate an SkPicture-derived class) is by passing a factory to the SkPictureRecorder class. This is to get all clients always using factories so that we can then change the factory call used (i.e., so the factory just creates a BBH) and do away with the SkPicture-derived classes. BUG=skia:2315 R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/239703006 git-svn-id: http://skia.googlecode.com/svn/trunk@14221 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-16 16:02:10 +00:00
commit-bot@chromium.org	c9b511f0e6	Revert of rebaseline_server: multithreaded loading/diffing of images (https://codereview.chromium.org/235923002/) ... Reason for revert: Caused https://code.google.com/p/skia/issues/detail?id=2423 ('"Deadline exceeded" error when connecting to live rebaseline_server'). Reverting until I can figure it out. Original issue's description: > rebaseline_server: multithreaded loading/diffing of images > > BUG=skia:2414 > NOTRY=True > > Committed: http://code.google.com/p/skia/source/detail?r=14184 R=rmistry@google.com TBR=rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2414 Author: epoger@google.com Review URL: https://codereview.chromium.org/239623002 git-svn-id: http://skia.googlecode.com/svn/trunk@14207 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-15 18:50:12 +00:00
commit-bot@chromium.org	73cb15351f	Make sure SkDrawLooper objects can only be allocated on the heap. ... Make constructors of SkLayerDrawLooper and SkBlurDrawLooper non-public. Remove addLayer* methods from SkLayerDrawLooper. SkLayerDrawLooper::Builder is used to create new objects. Provide factory method for creating SkBlurDrawLooper. BUG=2141 R=scroggo@google.com, reed@google.com, djsollen@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/232913003 git-svn-id: http://skia.googlecode.com/svn/trunk@14200 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-15 15:48:36 +00:00
commit-bot@chromium.org	280ea8296f	rebaseline_server: multithreaded loading/diffing of images ... BUG=skia:2414 NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/235923002 git-svn-id: http://skia.googlecode.com/svn/trunk@14184 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-14 18:15:29 +00:00
commit-bot@chromium.org	5d0b150257	resize canvas for GM + typo ... This change resized the canvas for some GM cases. It is better to show the visual difference in viewer.html for these cases after the CL applied. BUG=skia:2375 R=reed@google.com, djsollen@google.com Author: yunchao.he@intel.com Review URL: https://codereview.chromium.org/221953002 git-svn-id: http://skia.googlecode.com/svn/trunk@14177 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-14 15:02:19 +00:00
robertphillips@google.com	84b18c7e3e	split SkPictureRecorder out of SkPicture ... https://codereview.chromium.org/214953003/ git-svn-id: http://skia.googlecode.com/svn/trunk@14171 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-13 19:09:42 +00:00
commit-bot@chromium.org	e93a4c0fea	rebaseline_server: fix sorting by perceptual diff column ... (SkipBuildbotRuns) BUG=skia:2410 NOTREECHECKS=True NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/235993002 git-svn-id: http://skia.googlecode.com/svn/trunk@14167 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-11 21:45:41 +00:00
commit-bot@chromium.org	f7efa502d6	Implement intra-frame cacheing in image filters. ... When image filters are processed within Skia, they simply do a blind recursion. This has the side-effect of turning the DAG into a tree. I.e., nodes visited more than once during the traversal will be processed more than once. This change implements a very simple cacheing scheme: a cache is created before traversing the DAG, and handed into the processing traversal. Before recursing into a child in SkImageFilter::filterImage(), the cache is checked for a hit, and early-out is performed. Otherwise, the node is processed, and its result bitmap and location (offset) are cached, but only if it contains two or more children and thus will be visited again during the traversal. Currently, the child count is approximated with the refcount. This is good enough in most cases (and exactly correct for the Chrome use case). We could add an exact child count to the image filter, but this will require violating the immutability of image filters slightly in order to bump the child count as nodes are connected. I leave it up to the reviewer to decide which is better. R=reed@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/230653005 git-svn-id: http://skia.googlecode.com/svn/trunk@14160 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-11 18:57:00 +00:00
commit-bot@chromium.org	cae54f1f21	remove picture-backed surfaces ... BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/233943002 git-svn-id: http://skia.googlecode.com/svn/trunk@14159 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-11 18:34:35 +00:00
commit-bot@chromium.org	28fcae2ec7	Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/) ... Reason for revert: Want to reland the original CL. Original issue's description: > Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) > > Reason for revert: > breaking the Chrome deps roll. > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio > > Original issue's description: > > Rename kPMColor_SkColorType to kN32_SkColorType. > > > > The new name better represents what this flag means. > > > > BUG=skia:2384 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14117 > > TBR=reed@google.com,scroggo@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14144 R=reed@google.com, bensong@google.com TBR=bensong@google.com, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: scroggo@google.com Review URL: https://codereview.chromium.org/235523003 git-svn-id: http://skia.googlecode.com/svn/trunk@14156 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-11 17:15:40 +00:00
commit-bot@chromium.org	1f75ab9c66	add some .gitignores related to gm and tools ... NOTREECHECKS=True NOTRY=True R=scroggo@google.com TBR=scroggo Author: epoger@google.com Review URL: https://codereview.chromium.org/234603004 git-svn-id: http://skia.googlecode.com/svn/trunk@14150 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-11 14:49:50 +00:00
commit-bot@chromium.org	96edc24598	Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) ... Reason for revert: Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now. Original issue's description: > Rename kPMColor_SkColorType to kN32_SkColorType. > > The new name better represents what this flag means. > > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14117 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/234833003 git-svn-id: http://skia.googlecode.com/svn/trunk@14149 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-11 13:47:30 +00:00
commit-bot@chromium.org	d923288e50	Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/) ... Reason for revert: fixes on the chrome side are landing (brettw), keep fingers crossed. Original issue's description: > Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) > > Reason for revert: > breaking the Chrome deps roll. > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio > > Original issue's description: > > Rename kPMColor_SkColorType to kN32_SkColorType. > > > > The new name better represents what this flag means. > > > > BUG=skia:2384 > > > > Committed: http://code.google.com/p/skia/source/detail?r=14117 > > TBR=reed@google.com,scroggo@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14144 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/233813004 git-svn-id: http://skia.googlecode.com/svn/trunk@14145 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-10 22:49:20 +00:00
commit-bot@chromium.org	757ebd20ef	Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) ... Reason for revert: breaking the Chrome deps roll. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio Original issue's description: > Rename kPMColor_SkColorType to kN32_SkColorType. > > The new name better represents what this flag means. > > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14117 R=reed@google.com, scroggo@google.com TBR=reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Author: bensong@google.com Review URL: https://codereview.chromium.org/234243002 git-svn-id: http://skia.googlecode.com/svn/trunk@14144 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-10 22:36:34 +00:00
reed@google.com	76b12b74ed	when getClipBounds returns false, the out-param is uninitialized ... BUG=skia: Review URL: https://codereview.chromium.org/233933002 git-svn-id: http://skia.googlecode.com/svn/trunk@14141 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-10 21:15:30 +00:00
commit-bot@chromium.org	d0b8904521	rebaseline_server: eliminate meaningless 404 errors while waiting for content to load ... (SkipBuildbotRuns) NOTREECHECKS=True NOTRY=True R=jcgregorio@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/231513004 git-svn-id: http://skia.googlecode.com/svn/trunk@14138 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-10 20:41:13 +00:00
commit-bot@chromium.org	defe6fdbc8	rebaseline_server: allow user to specify which builders to process ... BUG=skia:1543,skia:1915 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/232103002 git-svn-id: http://skia.googlecode.com/svn/trunk@14131 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-10 15:05:24 +00:00
commit-bot@chromium.org	149e9a107c	Rename kPMColor_SkColorType to kN32_SkColorType. ... The new name better represents what this flag means. BUG=skia:2384 R=reed@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/227433009 git-svn-id: http://skia.googlecode.com/svn/trunk@14117 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-09 20:45:29 +00:00
commit-bot@chromium.org	c5d9bb0f67	Initial picture shader implementation ... This CL adds an SkPictureShader class to support SkPicture-based patterns. The implementation renders the picture into an SkBitmap tile and then delegates to SkBitmapProcShader for the actual operation. R=bsalomon@google.com, reed@google.com, robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=14085 Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/221923007 git-svn-id: http://skia.googlecode.com/svn/trunk@14092 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-08 15:19:34 +00:00
commit-bot@chromium.org	8865d09cf8	Revert of Initial picture shader implementation (https://codereview.chromium.org/221923007/) ... Reason for revert: breaking the buildbots. Subsequent CL only addressed CompareGMs but GenerateGMs are also failing. Original issue's description: > Initial picture shader implementation > > This CL adds an SkPictureShader class to support SkPicture-based > patterns. > > The implementation renders the picture into an SkBitmap tile and then > delegates to SkBitmapProcShader for the actual operation. > > R=reed@google.com,robertphillips@google.com,bsalomon@google.com > > Committed: http://code.google.com/p/skia/source/detail?r=14085 R=bsalomon@google.com, reed@google.com, robertphillips@google.com, fmalita@chromium.org TBR=bsalomon@google.com, fmalita@chromium.org, reed@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: bensong@google.com Review URL: https://codereview.chromium.org/227553010 git-svn-id: http://skia.googlecode.com/svn/trunk@14087 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-07 23:45:31 +00:00
commit-bot@chromium.org	592b2d13c9	Initial picture shader implementation ... This CL adds an SkPictureShader class to support SkPicture-based patterns. The implementation renders the picture into an SkBitmap tile and then delegates to SkBitmapProcShader for the actual operation. R=bsalomon@google.com, reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/221923007 git-svn-id: http://skia.googlecode.com/svn/trunk@14085 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-07 23:11:45 +00:00
commit-bot@chromium.org	c5713e484a	clear bitmap in texture domain gm ... R=robertphillips@google.com TBR=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/227563007 git-svn-id: http://skia.googlecode.com/svn/trunk@14082 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-07 21:18:46 +00:00
commit-bot@chromium.org	cf2f00872c	SkDiscardableMemoryPool to abstract class ... Motivation - we want to keep our public headers small. R=scroggo@google.com, reed@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/223403012 git-svn-id: http://skia.googlecode.com/svn/trunk@14063 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-04 16:43:38 +00:00
commit-bot@chromium.org	3eb77e4d5a	teach rebaseline_server how to compare results of multiple render_pictures runs ... BUG=skia:2230,skia:1942 NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/216103004 git-svn-id: http://skia.googlecode.com/svn/trunk@14062 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-04 16:40:25 +00:00
commit-bot@chromium.org	6844958fff	rebaseline_server: display as much info as possible if expected/actual image is missing ... BUG=skia:2368 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/221423003 git-svn-id: http://skia.googlecode.com/svn/trunk@14019 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-01 22:16:33 +00:00
commit-bot@chromium.org	58af0c895f	Add show_gm_changes script: show change revisions and hashes for a GM ... BUG=skia:1920 R=epoger@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/213833017 git-svn-id: http://skia.googlecode.com/svn/trunk@14015 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-01 19:03:19 +00:00
commit-bot@chromium.org	9fbbcca1c9	SkPerlinNoiseShader::CreateTubulenceNoise() is misspelled ... Add missing 'r'. BUG=skia:2329 R=bsalomon@google.com, hcm@google.com, sugoi@chromium.org Author: siglesias@igalia.com Review URL: https://codereview.chromium.org/207543008 git-svn-id: http://skia.googlecode.com/svn/trunk@14008 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-04-01 16:09:37 +00:00
bungeman@google.com	6eddc77f6a	Pass the IDWriteFactory instead of relying on a global creator. ... There are different variations or implementations of IDWriteFactory with different behaviors. Allow the user to specify the factory to use. R=scottmg@chromium.org Review URL: https://codereview.chromium.org/218833005 git-svn-id: http://skia.googlecode.com/svn/trunk@14000 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-31 19:18:07 +00:00
commit-bot@chromium.org	35c03fbf10	Remove scaleToFit from DashPathEffect ... BUG=skia: R=reed@google.com, bsalomon@google.com, scroggo@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/216493005 git-svn-id: http://skia.googlecode.com/svn/trunk@13999 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-31 18:52:51 +00:00
commit-bot@chromium.org	31d0b3d806	rebaseline_server: add --compare-configs option ... This allows us to compare GMs between configs across all builders, so we can see the largest deviations between raster and GPU renderings. BUG=skia:1919 NOTREECHECKS=True NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/215503002 git-svn-id: http://skia.googlecode.com/svn/trunk@13991 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-31 15:17:52 +00:00
commit-bot@chromium.org	972f9cd7a0	SK_SUPPORT_LEGACY_GRTYPES to hide duplicate types from SkTypes.h ... BUG=skia: R=bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/216503004 git-svn-id: http://skia.googlecode.com/svn/trunk@13982 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-28 17:58:28 +00:00
commit-bot@chromium.org	c0df2fb5d0	rebaseline_server: add option to read actuals from local disk ... (SkipBuildbotRuns) BUG=skia:1908 NOTREECHECKS=True NOTRY=True R=halcanary@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/212673013 git-svn-id: http://skia.googlecode.com/svn/trunk@13971 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-28 14:28:04 +00:00
commit-bot@chromium.org	a54abdccbd	Remove static bmp from shadertext3 ... R=mtklein@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/212843004 git-svn-id: http://skia.googlecode.com/svn/trunk@13959 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-26 21:21:40 +00:00
commit-bot@chromium.org	da0ceb2299	rebaseline_server: delete invalid image files from local disk cache ... BUG=skia:2247 NOTREECHECKS=True NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/211733004 git-svn-id: http://skia.googlecode.com/svn/trunk@13951 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-26 13:38:29 +00:00
senorblanco@chromium.org	6aeabb1694	Speculative Mac 10.6 fix: disable medium & high filter quality tests. ... BUG=skia: TBR=mtklein@google.com Review URL: https://codereview.chromium.org/211693003 git-svn-id: http://skia.googlecode.com/svn/trunk@13947 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-25 21:12:18 +00:00
senorblanco@chromium.org	afb26eef13	Speculative Mac 10.6 fix: remove useless code from matriximagefilter GM. ... TBR=mtklein@google.com BUG=skia: Review URL: https://codereview.chromium.org/211703002 git-svn-id: http://skia.googlecode.com/svn/trunk@13944 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-25 20:47:29 +00:00
senorblanco@chromium.org	fd0ec2c76a	Implement a generic matrix transform image filter. ... This will be used in Blink to accommodate matrices that contain rotation or shearing. This is a generalization of SkResizeImageFilter, so I've replaced all uses of SkResizeImageFilter in Skia. (It might be easier to review by diffing it with SkResizeImageFilter, too.) R=reed@google.com Review URL: https://codereview.chromium.org/211103006 git-svn-id: http://skia.googlecode.com/svn/trunk@13941 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-25 17:35:10 +00:00
commit-bot@chromium.org	26632630fd	Add GM that tests GrTextureDomain and fix bug where kDecal_Mode gets incorrectly ignored. ... R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/208313017 git-svn-id: http://skia.googlecode.com/svn/trunk@13933 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-25 15:13:18 +00:00
commit-bot@chromium.org	7b78981b4c	gather GM tests which are disabled on Android ... BUG=skia:2326 R=borenet@google.com, djsollen@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/208313014 git-svn-id: http://skia.googlecode.com/svn/trunk@13922 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-24 20:07:44 +00:00
commit-bot@chromium.org	41056232e4	fix compare_to_expectations command line launch ... (SkipBuildbotRuns) NOTREECHECKS=True NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/210093003 git-svn-id: http://skia.googlecode.com/svn/trunk@13921 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-24 19:51:57 +00:00
commit-bot@chromium.org	a723feec39	Fix 10.6 build: double -> float. ... BUG=skia: R=robertphillips@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/209893004 git-svn-id: http://skia.googlecode.com/svn/trunk@13906 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-24 14:54:04 +00:00
commit-bot@chromium.org	04eff72bf0	Add test cases for small radii to rrect GMs. ... BUG=skia:2181 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/203963010 git-svn-id: http://skia.googlecode.com/svn/trunk@13905 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-24 14:53:09 +00:00
commit-bot@chromium.org	08f6d86f8e	update bitmapshader to avoid potential rendering error for kA8_Config ... A local matrix is set to the shader, which will show the potential error for SkCanvas::drawBitmap when the bitmap is kA8_Config, as well as the potential error for drawing a geometry with a bitmapshader who's bitmap is kA8_Config. A simple case is also added for SkCanvas::drawBitmap when the bitmap is kA8_Config, but there is not shader. Then the drawing area will be colorized by the solid color set in SkPaint. BUG=skia:2278 BUG=skia:2293 R=reed@google.com, bsalomon@google.com Author: yunchao.he@intel.com Review URL: https://codereview.chromium.org/204143004 git-svn-id: http://skia.googlecode.com/svn/trunk@13904 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-24 02:49:48 +00:00
commit-bot@chromium.org	b463d5668a	rebaseline_server: rename results.py to compare_to_expectations.py ... BUG=skia:1919 NOTREECHECKS=True NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/208243003 git-svn-id: http://skia.googlecode.com/svn/trunk@13894 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-21 17:54:14 +00:00
commit-bot@chromium.org	a25c4e4fef	rebaseline_server: fix --editable mode ... complete revert of https://skia.googlesource.com/skia/+/736be3527214ddbd3dd7e42a89a374c62d98f370 partial revert of https://skia.googlesource.com/skia/+/579942387bed9259b03419c593503022e1399931 and glue made necessary by the above. (SkipBuildbotRuns) BUG=skia:2319 NOTREECHECKS=True NOTRY=True R=senorblanco@google.com, senorblanco@chromium.org Author: epoger@google.com Review URL: https://codereview.chromium.org/208473004 git-svn-id: http://skia.googlecode.com/svn/trunk@13893 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-21 17:30:12 +00:00
commit-bot@chromium.org	b659333bf6	Fixed double offset in resize filter ... The fix is trivial, simply remove the extra offset I added another case to the resizeimagefilter gm and made it so that it looks exactly like the one next to it, so that failure is easy to detect visually. BUG=skia: R=senorblanco@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/208303002 git-svn-id: http://skia.googlecode.com/svn/trunk@13892 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-21 16:19:28 +00:00
commit-bot@chromium.org	736be35272	rebaseline_server: when first started, tell client results are still being generated ... (SkipBuildbotRuns) NOTREECHECKS=True NOTRY=True R=senorblanco@google.com, senorblanco@chromium.org Author: epoger@google.com Review URL: https://codereview.chromium.org/206723002 git-svn-id: http://skia.googlecode.com/svn/trunk@13879 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-20 18:31:00 +00:00
commit-bot@chromium.org	579942387b	rebaseline_server: serve JSON from static file, rather than generating it live ... BUG=skia:1455, skia:2230 NOTREECHECKS=True NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/197213033 git-svn-id: http://skia.googlecode.com/svn/trunk@13876 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-20 17:27:46 +00:00
commit-bot@chromium.org	b42105a4a2	rebaseline_server: image URLs are relative to JSON file's location ... BUG=skia:1455, skia:2230 NOTREECHECKS=True NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/205273002 git-svn-id: http://skia.googlecode.com/svn/trunk@13874 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-20 15:27:34 +00:00
commit-bot@chromium.org	e5957f67d0	update comment on setShader to clarify alpha-bitmap behavior in bitmapshaders ... BUG=skia:2293 R=bsalomon@google.com, yunchao.he@intel.com Author: reed@google.com Review URL: https://codereview.chromium.org/203203005 git-svn-id: http://skia.googlecode.com/svn/trunk@13851 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-18 16:28:12 +00:00
commit-bot@chromium.org	2077427227	Put SimpleOffsetFilter on heap. ... Effects want to live on the heap! BUG=skia: R=senorblanco@chromium.org, dominikg@chromium.org, scroggo@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/203273002 git-svn-id: http://skia.googlecode.com/svn/trunk@13848 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-18 10:28:27 +00:00
commit-bot@chromium.org	d1c85d2920	rebaseline_server: make intermediate JSON specify base urls for diff images ... BUG=skia:1919,skia:2230 NOTREECHECKS=True NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/196533021 git-svn-id: http://skia.googlecode.com/svn/trunk@13830 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-17 14:22:02 +00:00
skia.committer@gmail.com	f0f9f5f904	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@13820 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-15 03:02:32 +00:00
senorblanco@chromium.org	118252962f	Implement support for expanding crop rects in image filters ... NOTE: this patch set is based on https://codereview.chromium.org/189913021/, and needs that patch to land first. Until now, crop rects in Skia have only been able to reduce the size of the destination bounds, but not expand them. SVG semantics require the latter as well. The heart of the change is in applyCropRect(), which now assigns each edge, instead of doing an intersection with the crop rect. In order to support this (and still work well with tiled drawing) we need to clip the resulting crop rect to the clipping region of the filters. This uses the Context struct previously landed from https://codereview.chromium.org/189913021/. Many of the pixel loops are not yet ready to handle a destination rect larger than the source rect. So we provide a convenience version of applyCropRect() which creates an offscreen and pads it out with transparent black. Once the pixel loops and shaders have been fixed to support larger destination bounds, they should be switched back to the non-drawing version of applyCropRect(). BUG=skia: R=bsalomon@google.com, reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=13805 Review URL: https://codereview.chromium.org/198003008 git-svn-id: http://skia.googlecode.com/svn/trunk@13809 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-14 17:44:41 +00:00
senorblanco@chromium.org	29089179a6	Revert "Implement support for expanding crop rects in image filters" ... Breaking ImageFilterTests unit test. TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/196353021 git-svn-id: http://skia.googlecode.com/svn/trunk@13806 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-14 16:48:39 +00:00
senorblanco@chromium.org	0ef0501baf	Implement support for expanding crop rects in image filters ... NOTE: this patch set is based on https://codereview.chromium.org/189913021/, and needs that patch to land first. Until now, crop rects in Skia have only been able to reduce the size of the destination bounds, but not expand them. SVG semantics require the latter as well. The heart of the change is in applyCropRect(), which now assigns each edge, instead of doing an intersection with the crop rect. In order to support this (and still work well with tiled drawing) we need to clip the resulting crop rect to the clipping region of the filters. This uses the Context struct previously landed from https://codereview.chromium.org/189913021/. Many of the pixel loops are not yet ready to handle a destination rect larger than the source rect. So we provide a convenience version of applyCropRect() which creates an offscreen and pads it out with transparent black. Once the pixel loops and shaders have been fixed to support larger destination bounds, they should be switched back to the non-drawing version of applyCropRect(). BUG=skia: R=bsalomon@google.com, reed@google.com Review URL: https://codereview.chromium.org/198003008 git-svn-id: http://skia.googlecode.com/svn/trunk@13805 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-14 16:35:08 +00:00
senorblanco@chromium.org	4cb543d605	Implement support for a Context parameter in image filters ... Some upcoming work (support for expanding crop rects) requires the clip bounds to be available during filter traversal. This change replaces the SkMatrix parameter in the onFilterImage() traversals with a Context parameter. It contains the CTM, as well as the clip bounds. BUG=skia: R=reed@google.com Review URL: https://codereview.chromium.org/189913021 git-svn-id: http://skia.googlecode.com/svn/trunk@13803 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-14 15:44:01 +00:00
reed@google.com	0d30c51c6c	check for null-device pixels in onWritePixels, so we don't crash ... https://code.google.com/p/chromium/issues/detail?id=352616 Review URL: https://codereview.chromium.org/196223013 git-svn-id: http://skia.googlecode.com/svn/trunk@13802 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-14 14:02:58 +00:00
commit-bot@chromium.org	1037d92bbc	Added Z scale when X and Y scale to spot lights and point lights ... Z scale is set as the average of X scale and Y scale. BUG=skia: R=senorblanco@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/198013002 git-svn-id: http://skia.googlecode.com/svn/trunk@13798 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-13 19:45:41 +00:00
commit-bot@chromium.org	fa5edbe575	Add effect-based clip for nine-patch SkRRects. ... BUG=skia:2181 R=jvanverth@google.com, robertphillips@google.com, rmistry@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/194703011 git-svn-id: http://skia.googlecode.com/svn/trunk@13794 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-13 18:01:05 +00:00
commit-bot@chromium.org	addcddeda6	make rebaseline_server client check schema version number ... (SkipBuildbotRuns) NOTREECHECKS=True NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/195763013 git-svn-id: http://skia.googlecode.com/svn/trunk@13792 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-13 17:44:01 +00:00
commit-bot@chromium.org	ea770f155e	add schema version to rebaseline_server intermediate JSON ... NOTREECHECKS=True NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/196343009 git-svn-id: http://skia.googlecode.com/svn/trunk@13790 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-13 16:33:36 +00:00
commit-bot@chromium.org	b17ccc992d	--dryRun flag for gm ... Causes gm to not actually run any tests / create any directories, just print its normal output. Useful for showing what tests would be run without actually taking the time to run them. BUG=skia:2294 R=reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/199093002 git-svn-id: http://skia.googlecode.com/svn/trunk@13785 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-13 16:16:36 +00:00
commit-bot@chromium.org	7498d95bde	rebaseline_server: generate JSON that can be viewed without a live server ... BUG=skia:1919 NOTREECHECKS=True NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/195943004 git-svn-id: http://skia.googlecode.com/svn/trunk@13783 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-13 14:56:29 +00:00
skia.committer@gmail.com	affa77db64	Sanitizing source files in Housekeeper-Nightly ... git-svn-id: http://skia.googlecode.com/svn/trunk@13782 2bbb7eff-a529-9590-31e7-b0007b416f81	2014-03-13 03:02:23 +00:00