AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
32,259 Commits 1 Branch 0 Tags 544 MiB
3d628fe00a
Commit Graph

935 Commits

Author SHA1 Message Date
Greg Humphreys
c9df8ce821 fix display of fiddles that DON'T have compile errors 
BUG=skia:

Review URL: https://codereview.chromium.org/644253003
 2014-10-16 14:23:02 -04:00
humper
ae8ab62966 Properly parse compiler errors for fiddles and mark them in the editor. 
You can also click on the errors in the parsed output to jump directly to the offending location in the editor.

BUG=skia:
NOTRY=true

Review URL: https://codereview.chromium.org/660573003
 2014-10-16 09:18:16 -07:00
tfarina
8c0d2aab62 webtry: Do not forget the close the rows. 
This should prevent further enumeration according to the docs.

http://golang.org/pkg/database/sql/#Rows.Close

BUG=None
TEST=None
R=humper@google.com

Review URL: https://codereview.chromium.org/638373003
 2014-10-16 05:57:39 -07:00
Thiago Farina
498bc5f036 webtry: Forgot onr log.Fatal. 
Update it to use glog variant.

BUG=skia:2980
TEST=go build webtry.go
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/659813003
 2014-10-15 19:20:27 -03:00
tfarina
ae6d6222b2 webtry: Switch from Go's log package to golang/glog. 
BUG=skia:2980
TEST=go get -d && go build webtry.go
R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/655323002
 2014-10-15 14:59:33 -07:00
tfarina
ebd90ee211 webtry: Check the result of os.Chdir(). 
As mentioned in http://golang.org/doc/effective_go.html#blank_assign,
errors are provided for a reason, so always check them.

The documentation for this function is available at
http://golang.org/pkg/os/#Chdir.

BUG=None
TEST=None
R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/651343002
 2014-10-15 13:48:47 -07:00
tfarina
585a5fc243 webtry: Simplify template construction. 
text/template and html/template both have a helper function called
"Must" that according to the docs in http://golang.org/pkg/text/template/#Must
and http://golang.org/pkg/html/template/#Must, wraps a call to a function
returning (*Template, error) and panics if the error is non-nil.

So we don't need to that ourselves. Which is a good thing and makes code
cleaner.

BUG=None
TEST=None
R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/642243004
 2014-10-14 09:39:02 -07:00
Greg Humphreys
54142261de Re-land ganesh checkbox. I needed to increase the size of the address 
space available to a fiddle because linking against libGL causes the
amount of memory used by a process to bloat to over 100M.  Yikes.

BUG=skia:

Review URL: https://codereview.chromium.org/638003008
 2014-10-13 21:52:05 -04:00
humper
67f2d3c514 Revert of add ganesh checkbox to skfiddle interface (patchset #6 id:270001 of https://codereview.chromium.org/649313002/) 
Reason for revert:
adding -Dskia_mesa=1 broke production; don't yet know why and don't want to leave things in a broken state.

Original issue's description:
> add ganesh checkbox to skfiddle interface
>
> BUG=skia:
> R=mtklein@google.com, tfarina@chromium.org
>
> Committed: https://skia.googlesource.com/skia/+/ccb54895c614632fd01d22b64ab614921f980eb1

TBR=tfarina@chromium.org,jcgregorio@google.com,mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/655633003
 2014-10-13 16:05:05 -07:00
Greg Humphreys
ccb54895c6 add ganesh checkbox to skfiddle interface 
BUG=skia:
R=mtklein@google.com, tfarina@chromium.org

Review URL: https://codereview.chromium.org/649313002
 2014-10-13 18:12:33 -04:00
tfarina
5d0706ffd3 Fix webtry setup once instructions in README doc. 
BUG=None
TEST=NOne
R=humper@google.com
TBR=humper@google.com

Review URL: https://codereview.chromium.org/648563003
 2014-10-13 12:37:52 -07:00
Greg Humphreys
6c07907eaa add support for skfiddle width/height options 
BUG=skia:
R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/656463002
 2014-10-13 13:58:09 -04:00
tfarina
ac15bb901c webtry: Simply move sys/ directory into setup/. 
That seems to make things more tied and that seems to be where we have
the same scripts/configs in the perf directory:
https://skia.googlesource.com/buildbot/+/master/perf/setup/sys/

That way we keep all files used/related to setting up a new webtry server in one place.

BUG=None
TEST=None
R=humper@google.com

Review URL: https://codereview.chromium.org/644513003
 2014-10-08 20:05:13 -07:00
Greg Humphreys
4f6ffde95f pre-build the resources library for the fiddle jail 
BUG=skia:
TBR=jcgregorio

Review URL: https://codereview.chromium.org/637353003
 2014-10-08 12:36:42 -04:00
Greg Humphreys
117ff1c1d1 repair the webtry setup process 
The previous version of the script didn't properly update the code for the webtry
user, so only changes to skia would really be pulled, not changes to the actual
webtry server itself.

This version of the setup script is 100% automated and brings everything up to date.

It's also a little more verbose about what it's doing, so it's easier to debug.

BUG=skia:
R=tfarina@chromium.org
TBR=jcgregorio, mtklein, tfarina

Review URL: https://codereview.chromium.org/636173003
 2014-10-08 12:33:31 -04:00
Greg Humphreys
25ec1b3c8c allow fiddles to use the futex system call; fixes fonts finally 
BUG=skia:

Review URL: https://codereview.chromium.org/639013002
 2014-10-08 12:21:41 -04:00
Greg Humphreys
e97d82b6e5 In the generated fiddle, set the portable fonts flag first. 
BUG=skia:
TBR=jcgregorio

Review URL: https://codereview.chromium.org/635373002
 2014-10-08 12:04:20 -04:00
Greg Humphreys
ebca225b48 preliminary support for fiddle font use 
BUG=skia:2998
TBR=jcgregorio, tfarina

Review URL: https://codereview.chromium.org/639833003
 2014-10-08 11:09:21 -04:00
robertphillips
a624e87e8e Implement C path functions 
Mainly just to familiarize myself with this code.

Review URL: https://codereview.chromium.org/633183002
 2014-10-08 06:04:35 -07:00
Greg Humphreys
345379dd3c fix missing webtry output capture display 
BUG=skia:

Review URL: https://codereview.chromium.org/628353002
 2014-10-06 15:40:06 -04:00
Greg Humphreys
261f7a62d2 rework webtry css with compass and bootstrap 
BUG=skia:

Review URL: https://codereview.chromium.org/623173004
 2014-10-06 15:34:28 -04:00
reed
8e47478333 implement some so we can test it 
NOTRY=True
TBR=

Review URL: https://codereview.chromium.org/629903004
 2014-10-06 11:00:51 -07:00
humper
8d56e27ef5 a few more tweaks to the webtry setup doc 
BUG=skia:
TBR=tfarina

Review URL: https://codereview.chromium.org/626623002
 2014-10-06 09:56:14 -07:00
Greg Humphreys
bc3dbbd8fd add environment variable to webtry local run documentation 
BUG=skia:

Review URL: https://codereview.chromium.org/631693003
 2014-10-06 12:33:32 -04:00
Greg Humphreys
de9bec4f04 Automatically resize the webtry text editor to fit the content 
BUG=skia:

Review URL: https://codereview.chromium.org/626033004
 2014-10-06 12:31:42 -04:00
Greg Humphreys
d3b7ef6c2b fix webtry local run documentation 
BUG=skia:

Review URL: https://codereview.chromium.org/630093002
 2014-10-06 12:04:40 -04:00
reed
938dfba51d experimental c api 
BUG=skia:

Review URL: https://codereview.chromium.org/624973004
 2014-10-06 06:08:16 -07:00
tfarina
f16cd28a04 Restart webtry to pick up changes. 
Also add webtry.db to gitignore so it does not polute `git status`.

BUG=None
TEST=None
R=humper@google.com

Review URL: https://codereview.chromium.org/626703002
 2014-10-03 21:05:00 -07:00
humper
f0e2154b45 Update webtry setup docs to reflect new installation procedure 
BUG=skia:

Review URL: https://codereview.chromium.org/626443004
 2014-10-02 10:37:14 -07:00
humper
149366e884 fix sudo redirection in setup script 
BUG=skia:

Review URL: https://codereview.chromium.org/618013004
 2014-10-02 10:36:59 -07:00
humper
b77955e1b1 complete overhaul of webtry work partition between jail and host 
BUG=skia:

Review URL: https://codereview.chromium.org/619943002
 2014-10-01 14:27:31 -07:00
tfarina
b1dfb03685 webtry: More README doc cleanups. 
Puts it much more in sync with the README in perf/.

BUG=None
TEST=None
R=jcgregorio@google.com

Review URL: https://codereview.chromium.org/615313002
 2014-10-01 09:18:58 -07:00
tfarina
fffa16cc27 webtry: Only create sqlite3 tables if they don't exist yet. 
Otherwise it will through an error like the following:

2014/09/28 21:22:24 Info: status creating sqlite table for sources:
"table source_images already exists"
2014/09/28 21:22:24 Info: status creating sqlite table for webtry:
"table webtry already exists"
2014/09/28 21:22:24 Info: status creating sqlite table for workspace:
"table workspace already exists"
2014/09/28 21:22:24 Info: status creating sqlite table for workspace
try: "table workspacetry already exists"

To test locally the following was done:

$ ./gyp_skia gyp/webtry.gyp gyp/most.gyp -Dskia_gpu=0
$ ninja -C out/Debug webtry
$ cd experimental/webtry
$ go get -d
$ go build webtry.go
$ ./webtry
$ google-chrome http://localhost:8000

Expected: see no more the above messages.

BUG=None
TEST=see above
R=stephana@google.com, jcgregorio@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/613593002
 2014-09-30 08:17:11 -07:00
tfarina
320a4e658b Fix some references to non-existant polyfill directory. 
Looks like the name of the directory is "poly" rather than "polyfill".

BUG=None
TEST=None
R=humper@google.com, jcgregorio@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/610003003
 2014-09-29 10:50:59 -07:00
tfarina
c425ae3a12 Mention 'go get' command in the README file. 
This is necessary to build webtry.go as it imports packages from
github.com

BUG=None
TEST=follow the README instructions
R=humper@google.com, jcgregorio@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/601033004
 2014-09-29 10:50:29 -07:00
tfarina
4ceb039301 webtry database has more than one table. 
Fix the wording in the DESIGN doc. Currently it says "the only table" as
implying the database has just a single table.

That is not true, the webtry database has four tables: webtry,
workspace, workspacetry and source_images.

BUG=None
TEST=None
R=jcgregorio@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/611763002
 2014-09-29 08:16:12 -07:00
humper
9f58dd047c run the webtry build script instead of using go build 
BUG=skia:
R=jcgregorio@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/601203002
 2014-09-29 07:40:41 -07:00
fmalita
05c4a4322e Revert of Revert of Fix SkTextBlob offset semantics. (patchset #1 id:1 of https://codereview.chromium.org/609223003/) 
Reason for revert:
Re-landing: Chromium-side fix to be landed with the roll (https://codereview.chromium.org/607853003/)

Original issue's description:
> Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/605533002/)
>
> Reason for revert:
> Breaking the Chrome builds with the error:
>
> [14:54:14.317833] ../../skia/ext/pixel_ref_utils.cc:221:16: error: 'drawPosText' marked 'override' but does not override any member functions
> [14:54:14.318022]   virtual void drawPosText(const SkDraw& draw,
> [14:54:14.318082]                ^
>
> Original issue's description:
> > Fix SkTextBlob offset semantics.
> >
> > Implement proper x/y drawTextBlob() handling by plumbing a
> > drawPosText() offset parameter (to act as an additional glyph pos
> > translation) throughout the device layer.
> >
> > The new offset superceeds the existing constY, with a minor semantic
> > tweak: whereas previous implementations were ignoring constY in 2D
> > positioning mode (scalarsPerGlyph == 2), now the offset is always
> > observed, in all positioning modes. We can do this because existing
> > drawPosText() clients always pass constY == 0 for full positioning mode.
> >
> > R=reed@google.com, jvanverth@google.com, robertphillips@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/c13bc571d3e61a43b87eb97f0719abd304cafaf2
>
> TBR=jvanverth@google.com,reed@google.com,bsalomon@google.com,fmalita@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/d46b8d2bab7cfba8458432248e1568ac377429e9

R=jvanverth@google.com, reed@google.com, bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com, jvanverth@google.com, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/607413003
 2014-09-29 06:29:53 -07:00
robertphillips
d46b8d2bab Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/605533002/) 
Reason for revert:
Breaking the Chrome builds with the error:

[14:54:14.317833] ../../skia/ext/pixel_ref_utils.cc:221:16: error: 'drawPosText' marked 'override' but does not override any member functions
[14:54:14.318022]   virtual void drawPosText(const SkDraw& draw,
[14:54:14.318082]                ^

Original issue's description:
> Fix SkTextBlob offset semantics.
>
> Implement proper x/y drawTextBlob() handling by plumbing a
> drawPosText() offset parameter (to act as an additional glyph pos
> translation) throughout the device layer.
>
> The new offset superceeds the existing constY, with a minor semantic
> tweak: whereas previous implementations were ignoring constY in 2D
> positioning mode (scalarsPerGlyph == 2), now the offset is always
> observed, in all positioning modes. We can do this because existing
> drawPosText() clients always pass constY == 0 for full positioning mode.
>
> R=reed@google.com, jvanverth@google.com, robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/c13bc571d3e61a43b87eb97f0719abd304cafaf2

R=jvanverth@google.com, reed@google.com, bsalomon@google.com, fmalita@chromium.org
TBR=bsalomon@google.com, fmalita@chromium.org, jvanverth@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/609223003
 2014-09-29 04:48:52 -07:00
Florin Malita
c13bc571d3 Fix SkTextBlob offset semantics. 
Implement proper x/y drawTextBlob() handling by plumbing a
drawPosText() offset parameter (to act as an additional glyph pos
translation) throughout the device layer.

The new offset superceeds the existing constY, with a minor semantic
tweak: whereas previous implementations were ignoring constY in 2D
positioning mode (scalarsPerGlyph == 2), now the offset is always
observed, in all positioning modes. We can do this because existing
drawPosText() clients always pass constY == 0 for full positioning mode.

R=reed@google.com, jvanverth@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/605533002
 2014-09-26 10:33:37 -04:00
tfarina
fbe8d890ce Reinitialize monit to changes take effect. 
Otherwise changes made to the configuration won't take effect when they
are synced.

BUG=None
TEST=None
R=jcgregorio@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/602293002
 2014-09-26 06:10:00 -07:00
jcgregorio
c0a77553f7 Fix typo in experimental/webtry/DESIGN.md. 
R=tfarina@chromium.org

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/593723003
 2014-09-22 10:33:00 -07:00
humper
95b7144adf fixes to linux build for webtry 
BUG=skia:
R=jcgregorio@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/578013003
 2014-09-18 10:58:33 -07:00
reed
e010f1c2a0 hide deviceproperties, prepare the way for surfaceprops 
BUG=skia:
NOTRY=True
R=bungeman@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/577023002
 2014-09-17 10:49:38 -07:00
humper
9a0267fa9a gyp build of skfiddle apps, take 2 
BUG=skia:
R=jcgregorio@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/553333004
 2014-09-17 08:42:46 -07:00
bsalomon
3850971d54 Revert "Revert "Move SkGpuDevice.h to src/gpu"" 
This reverts commit b0a35f7c5d.

R=borenet@google.com
TBR=borenet@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/575783003
 2014-09-17 07:44:25 -07:00
borenet
b0a35f7c5d Revert "Move SkGpuDevice.h to src/gpu" 
This reverts commit d99bbb61e5.

Causing Chrome canary failures as well as failures of Chrome trybots due to
not cleaning up properly after failed DEPS roll attempts.

BUG=skia:
R=bsalomon@google.com, reed@google.com
TBR=bsalomon, reed

Author: borenet@google.com

Review URL: https://codereview.chromium.org/579733003
 2014-09-17 06:14:35 -07:00
bsalomon
d99bbb61e5 Move SkGpuDevice.h to src/gpu 
R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/545193006
 2014-09-16 14:09:13 -07:00
humper
d3b6eb246d disable webtry seccmp on non-linux build 
BUG=skia:
R=jcgregorio@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/555993002
 2014-09-09 15:57:33 -07:00
humper
d85ad50b0e simple build script for webtry that re-generates the code template 
before compilation

BUG=skia:
R=jcgregorio@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/552343003
 2014-09-09 15:57:26 -07:00
robertphillips
c5ba71d2e5 Change SkPicture::draw to playback 
R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/540963002
 2014-09-04 08:42:50 -07:00
reed
e5ea500d47 Hide fields in SkImageInfo 
R=rmistry@google.com
TBR=bsalomon

Author: reed@google.com

Review URL: https://codereview.chromium.org/536003002
 2014-09-03 11:54:58 -07:00
robertphillips
a8d7f0b13c Try out scalar picture sizes 
This paves the way for removing the 'fTile' parameter from SkPictureShader (although that should be a different CL). If we like this we could also move to providing an entire cull SkRect.

R=reed@google.com, mtklein@google.com, fmalita@google.com, fmalita@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/513983002
 2014-08-29 08:03:56 -07:00
reed
8bf3df68c5 remove code for (dead) SK_SUPPORT_LEGACY_GETCLIPTYPE 
BUG=skia:
R=djsollen@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/489103003
 2014-08-21 05:51:22 -07:00
epoger
d9f18a35d5 add headers to experimental SKP expectations 
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
(SkipBuildbotRuns)

Author: epoger@google.com

Review URL: https://codereview.chromium.org/491023003
 2014-08-20 11:51:39 -07:00
epoger
5fc8edc81d update experimental SKP expectations using the new tool 
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana

Author: epoger@google.com

Review URL: https://codereview.chromium.org/488203002
 2014-08-20 11:10:30 -07:00
epoger
a38acc74bb add 2 missing SKP expectations files within experimental dir 
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
(SkipBuildbotRuns)

Author: epoger@google.com

Review URL: https://codereview.chromium.org/470193006
 2014-08-20 08:22:26 -07:00
epoger
802aa8c15b start maintaining some experimental SKP expectations 
BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana

Author: epoger@google.com

Review URL: https://codereview.chromium.org/491003002
 2014-08-20 07:52:29 -07:00
mtklein
753b870c62 Define NDEBUG instead of SK_DEBUG/SK_RELEASE. 
This makes our builds more like Chrome's, and will make our builds fail
if we accidentally use if SK_DEBUG instead of ifdef SK_DEBUG.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/481513004
 2014-08-20 07:38:46 -07:00
halcanary
97d2c0a216 Move SkReadBuffer.h and SkReader32.h out of include. 
Committed: https://skia.googlesource.com/skia/+/2a51d7c74cec217195f861677de8998b382b39e4

R=mtklein@google.com, reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/481053002
 2014-08-19 06:27:53 -07:00
halcanary
f128f53a5b Revert "Move SkReadBuffer.h and SkReader32.h out of include." 
This reverts commit 2a51d7c74c.

Breaking Blink

NOTRY=true
R=bungeman@google.com
TBR=bungeman@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/472303006
 2014-08-18 13:48:13 -07:00
halcanary
2a51d7c74c Move SkReadBuffer.h and SkReader32.h out of include. 
R=mtklein@google.com, reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/481053002
 2014-08-18 13:04:59 -07:00
reed
5b1b2dbe76 remove SkStippleMaskFilter - no external clients 
TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/462013002
 2014-08-12 05:50:10 -07:00
reed
d5fa1a455a add drawPicture variant that takes a matrix and paint 
will need some staging strategy, since chrome and blink have overrides of onDrawPicture

R=robertphillips@google.com, fmalita@google.com, bsalomon@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/448793004
 2014-08-09 11:08:05 -07:00
tfarina
a8e2e1504b Cleanup: Rename SkOSPath functions. 
Mostly for brevity and matches better with Python:

Python           | Old C++                 | New C++
os.path.join     | SkOSPath::SkPathJoin    | SkOSPath::Join
os.path.basename | SkOSPath::SkBasename    | SkOSPath::Basename

BUG=None
TEST=make all
R=mtklein@google.com, bsalomon@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/428443002
 2014-07-28 19:26:58 -07:00
caryclark
17f0b6df72 share dm and command flags 
Share command flags between dm and unit tests.
Also, allow dm's core to be included by itself and iOSShell.

Command line flags that are the same (or nearly the same) in DM
and in skia_tests have been moved to common_flags. Authors,
please check to see that the shared common flag is correct for
the tool.

For iOS, the 'tool_main' entry point has a wrapper to allow multiple
tools to be statically linked in the iOSShell.
Since SkCommandLineFlags::Parse can only be called once, these calls
are disabled in the IOS build.

Since the iOS app directory is dynamically assigned a name, use '@' to
select it. (This is the same convention chosen by the Mobile Harness
iOS file system utilities.)

Move the heart of dm.gyp into dm.gypi so that it can be included by
itself and iOSShell.gyp.

Add tools/flags/SkCommonFlags.* to define and declare common
command line flags.

Add support for dm to iOSShell.

BUG=skia:
R=scroggo@google.com, mtklein@google.com, jvanverth@google.com, bsalomon@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/389653004
 2014-07-22 10:15:35 -07:00
kozyatinskiy
c09e8c2ec9 https://chromiumcodereview.appspot.com/331133004/ 
patch from issue 331133004
 2014-07-15 11:11:25 -04:00
caryclark
93de7a27e0 fix ios break 
R=reed@android.com
TBR=reed
NOTREECHECKS=TRUE
NOTRY=TRUE

BUG=skia:

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/388933003
 2014-07-11 13:21:17 -07:00
caryclark
936b73424f ios fixes 
skia_ios.mm
Get the app's Documents directory and pass use it to set the resource path.
This is a quick hack which will be replaced by a new application that is
a tiny shim around a command line tool.

SkImageEncoder.h
SkForceLinking.cpp
SkImageDecoder_CG.cpp
Add support for FORCE_LINKING so iOS sees the PNG encoder and others.

SkFloatBits.cpp
SkPoint.cpp
Handle denormalized numbers that are floored by the iOS ARM processor.

SkImageDecoder_iOS.mm
Remove empty encoder factory.

SkTouchGesture.cpp
Return early on empty state on touch rather than aborting (crashing)

JpegTest.cpp
Hal via stackoverflow.com says partial jpegs can be gray as well.

skia_test.cpp
Remove crash handler call for now to avoid link failure.

OverwriteLine.h
Remove fancy line overwrite for iOS.

Resources.cpp
Add interface to set resource directory based on runtime query.

BUG=skia:2736 skia:2737 skia:2738
R=reed@google.com, halcanary@google.com, mtklein@google.com, tfarina@chromium.org

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/373383003
 2014-07-11 12:14:51 -07:00
bensong
c15ba1d544 bench rebase tool: add ability to specify a second CL for fluctuating data adjustment. 
R=borenet@google.com
TBR=borenet@google.com
BUG=skia:2657
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/370413002
 2014-07-08 14:36:56 -07:00
jcgregorio
3ef0453299 Fix history handling for workspaces, issue with M36 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/363003004
 2014-07-07 06:56:44 -07:00
kkinnunen
80549fcdd5 Support using OpenGL ES context on desktop 
Support using OpenGL ES context on desktop for unix and Android platforms. This
is mainly useful in development.

Add --gpuAPI flag to gm, dm, bench, bench_pictures and render_pictures. The
possible parameters for the flag are "gl" and "gles".

R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/319043005
 2014-06-30 06:36:31 -07:00
senorblanco
7bf1068473 Remove SkBicubicImageFilter, and all related tests. 
Now that we have SkResizeImageFilter, and the bicubic
resizing is part of skia proper, there's no need for a
specialized image filter.

BUG=skia:
R=bsalomon@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/357793002
 2014-06-25 14:39:06 -07:00
rmistry
05ead8afe5 Revert of Support using OpenGL ES context on desktop (https://codereview.chromium.org/319043005/) 
Reason for revert:
Caused segmentation fault on many builders. Please see reverted CL's msg #21 for details.

Original issue's description:
> Support using OpenGL ES context on desktop
>
> Support using OpenGL ES context on desktop for unix and Android platforms. This
> is mainly useful in development.
>
> Add --gpuAPI flag to gm, dm, bench, bench_pictures and render_pictures. The
> possible parameters for the flag are "gl" and "gles".
>
> Committed: https://skia.googlesource.com/skia/+/74fc727dc88ee24d89f88cb1709f963e9073aeb3

R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com, kkinnunen@nvidia.com
TBR=bsalomon@google.com, kkinnunen@nvidia.com
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/351583002
 2014-06-23 06:13:46 -07:00
kkinnunen
74fc727dc8 Support using OpenGL ES context on desktop 
Support using OpenGL ES context on desktop for unix and Android platforms. This
is mainly useful in development.

Add --gpuAPI flag to gm, dm, bench, bench_pictures and render_pictures. The
possible parameters for the flag are "gl" and "gles".

R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/319043005
 2014-06-22 22:56:54 -07:00
jcgregorio
d0eecd461d Use DNS and not hard coded IP address of the monitoring server. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/338873003
 2014-06-18 07:13:09 -07:00
mtklein
d6043b20b6 Add nanomsg to third_party, with some demos. 
This isn't something I want to make part of Skia, but just a substrate to build cross-process demos on top of.  If I client were to use Skia cross-process, they'd drop their own IPC system in here.

If you're not familiar, nanomsg (nanomsg.org) is the next-gen zeromq (zeromq.org), from the same author, righting all his design wrongs from zeromq.

It's a lot like the lower half of mojo, dealing with making the connections and getting messages reliably from A to B.  Think, better sockets, and it spans nicely across in-process (with zero-copy), inter-process, and TCP.

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/294873004
 2014-06-16 20:21:06 -07:00
reed
bfefc7c95f hide Config in SkImageDecoder -- use SkColorType instead 
patch from issue 334613003

TBR=scroggo

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/334793002
 2014-06-12 17:40:00 -07:00
bensong
06cc564823 removes deprecated -q flag for gsutil. 
BUG=skia:
NOTRY=true
R=kelvinly@google.com
TBR=kelvinly@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/333643005
 2014-06-12 08:25:04 -07:00
jvanverth
66c9582d1b Fix a number of issues with iOS build. 
Set pointer to root view in window (for SampleApp)
Set up the correct function pointer for GL multisampling
Remove use of SkBitmap::setConfig()
Remove incomplete iOS implementation of SkFILE (use SkOSFile for now)

R=caryclark@google.com, reed@google.com, bsalomon@google.com, tfarina@chromium.org

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/322403007
 2014-06-11 13:59:22 -07:00
reed
6c22573edb hide SkBitmap::setConfig 
patch from issue 325733002

TBR=scroggo

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/322963002
 2014-06-09 19:52:07 -07:00
jcgregorio
659988168a Add metrics reporting to SkFiddle. 
Also update the headers for template.cpp while we're here.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/312373002
 2014-06-06 06:30:31 -07:00
robertphillips
9b14f26d0f Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) 
R=reed@google.com, bsalomon@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/313613004
 2014-06-04 05:40:44 -07:00
reed
868074b50b remove SkBounder -- unused and unloved 
BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/312553006
 2014-06-03 10:54:00 -07:00
jcgregorio
92bfb09ac8 Fix etc1 support for SkFiddle. 
Also update design doc to fix MySQL notation for auto incrementing columns.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/315643002
 2014-06-03 09:04:44 -07:00
jcgregorio
d0f18b1f2b Update link to Doxygen. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/302543007
 2014-06-03 07:38:35 -07:00
commit-bot@chromium.org
0a7e5b7554 Add the ability to select a source image to use in the code. 
A much farther ranging change than I suspected.

Basically add a 'source' integer to every Try, store that in the database with every Try, add the source to the computation of the hash, and load and use the 'source' value when navigating history.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/294903017

git-svn-id: http://skia.googlecode.com/svn/trunk@14960 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-29 15:58:00 +00:00
commit-bot@chromium.org
41e2ff2bff fix bench rebase tool to cope with wider range of bots. 
BUG=skia:2373
R=kelvinly@google.com
TBR=kelvinly@google.com
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/292623005

git-svn-id: http://skia.googlecode.com/svn/trunk@14869 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-23 15:31:02 +00:00
commit-bot@chromium.org
83f23d87f1 Remove unused (by clients) SkUnitMapper 
This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98.

TBR=scroggo

Author: reed@google.com

Review URL: https://codereview.chromium.org/288313009

git-svn-id: http://skia.googlecode.com/svn/trunk@14842 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-22 12:27:41 +00:00
commit-bot@chromium.org
77767358a3 bench rebase tools: format commit message and title. 
BUG=skia:
R=kelvinly@google.com
TBR=kelvinly@google.com
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/296943004

git-svn-id: http://skia.googlecode.com/svn/trunk@14841 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-22 12:00:55 +00:00
commit-bot@chromium.org
3339ac54a5 Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (https://codereview.chromium.org/288343009/) 
Reason for revert:
required blink change failed to land

Original issue's description:
> Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
>
> This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14830

R=scroggo@google.com, reed@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/296823008

git-svn-id: http://skia.googlecode.com/svn/trunk@14838 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-22 02:55:59 +00:00
commit-bot@chromium.org
336df8fd34 fix some bench rebase tool problems. 
BUG=skia:2373
NOTRY=true
TBR=kelvinly@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/298683004

git-svn-id: http://skia.googlecode.com/svn/trunk@14836 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-21 22:57:44 +00:00
commit-bot@chromium.org
5ddea761a9 Adds bench rebase tools to experimental for version control and self update. 
BUG=skia:
NOTRY=true
R=kelvinly@google.com
TBR=kelvinly@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/296453016

git-svn-id: http://skia.googlecode.com/svn/trunk@14833 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-21 21:12:11 +00:00
commit-bot@chromium.org
4b8f802255 Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) 
This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.

BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/288343009

git-svn-id: http://skia.googlecode.com/svn/trunk@14830 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-21 19:56:46 +00:00
commit-bot@chromium.org
a4c367737b Add gzip encoding responses. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/298433002

git-svn-id: http://skia.googlecode.com/svn/trunk@14786 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-19 17:38:52 +00:00
commit-bot@chromium.org
015c08e5ca Move zooming into its own component, imported via HTML Imports. 
Also, start building our own polyfill library (polyfill.js) using Grunt and Bower.

Finally, refactor all the web pages so that the common header and footer material comes from templates.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/292433002

git-svn-id: http://skia.googlecode.com/svn/trunk@14783 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-19 16:40:08 +00:00
commit-bot@chromium.org
e2b193ca5c Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) 
Reason for revert:
does not address all legacy callsites in chrome.

e.g.

[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919]            gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));


Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761

R=robertphillips@google.com, scroggo@google.com, george@mozilla.com
TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/287063009

git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-16 13:49:08 +00:00
commit-bot@chromium.org
ee0cac336c remove unused (by clients) SkUnitMapper 
BUG=skia:
R=robertphillips@google.com, scroggo@google.com, george@mozilla.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/283273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14761 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-16 13:35:01 +00:00
commit-bot@chromium.org
8265fe61f0 Add polyfill for pointer events, change code to handle both mouse and pointer events equalls. 
Mobile first!

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/286913005

git-svn-id: http://skia.googlecode.com/svn/trunk@14756 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-15 21:14:34 +00:00
commit-bot@chromium.org
9f3b925e76 Ping MySQL every minute in an attempt to keep the connection alive. 
I've tried various MySQL server settings, and some TCP settings on the webtry server, none seem to keep the connection from hanging, so this is a brute-force solution.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/286543003

git-svn-id: http://skia.googlecode.com/svn/trunk@14720 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-14 12:55:34 +00:00
commit-bot@chromium.org
e003aecb30 remove unused Kernel33MaskFilter 
R=robertphillips@google.com
TBR=robertphilips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/280233002

git-svn-id: http://skia.googlecode.com/svn/trunk@14691 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-12 13:35:55 +00:00
commit-bot@chromium.org
3824bcdc66 Square pixels on zoom. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/270073004

git-svn-id: http://skia.googlecode.com/svn/trunk@14587 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-06 13:04:35 +00:00
commit-bot@chromium.org
7e9fb8ddd6 Fix an issue with FireFox where it blurs when copying from a smaller to a 
larger canvas. Work around that by drawing a rect for each pixel.

Also, add a drop shadow to the hex display so you can see it on a dark background color.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/261303002

git-svn-id: http://skia.googlecode.com/svn/trunk@14575 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-05 18:43:16 +00:00
commit-bot@chromium.org
166b7e4ad4 Add Doxygen link to titlebar. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/268773002

git-svn-id: http://skia.googlecode.com/svn/trunk@14527 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-02 14:13:08 +00:00
commit-bot@chromium.org
d4ec0f1baa Need checkerboard on history images too. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/267723010

git-svn-id: http://skia.googlecode.com/svn/trunk@14526 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-02 12:56:43 +00:00
commit-bot@chromium.org
d9efd241bf Add checkerboard under the image. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/263853004

git-svn-id: http://skia.googlecode.com/svn/trunk@14519 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-01 20:52:12 +00:00
commit-bot@chromium.org
1e2a0cba37 Fix history on workspaces, where you couldn't click on old tries. 
Also allow editing the first and last line because you might need
to do that to fix "old" tries that are already stored in the database.
By "old" I mean yesterday.

BUG=skia:
R=fmalita@google.com, fmalita@chromium.org

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/264833004

git-svn-id: http://skia.googlecode.com/svn/trunk@14516 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-01 20:17:18 +00:00
commit-bot@chromium.org
70222fadf0 Run Squid as a reverse caching proxy on port 80 and proxy the requests 
to the server running on port 8000.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/261023002

git-svn-id: http://skia.googlecode.com/svn/trunk@14515 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-01 20:10:03 +00:00
commit-bot@chromium.org
a60538e954 Move to a theme that more closely matches what was there before. 
Also, since it's a variation of "default" we can drop a whole file.

BUG=skia:
R=mtklein@google.com, fmalita@chromium.org

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/265703005

git-svn-id: http://skia.googlecode.com/svn/trunk@14507 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-01 19:21:33 +00:00
fmalita@google.com
950306ccf1 Use CodeMirror for WebTry snippets. 
CodeMirror (http://codemirror.net) is a rich code editor. This CL
adds the needed library and wires it with some minimal features, to
update the editor appearance to something like this:
http://codemirror.net/demo/theme.html?ambiance

We can later add Skia-customized features (custom keyword highlighting,
code completion, etc.).

(only tested locally)

R=jcgregorio@google.com, mtklein@google.com

Review URL: https://codereview.chromium.org/261693003

git-svn-id: http://skia.googlecode.com/svn/trunk@14499 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-01 15:14:56 +00:00
commit-bot@chromium.org
3dbcb10e75 Display the color at a point. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/261533006

git-svn-id: http://skia.googlecode.com/svn/trunk@14494 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-05-01 12:54:25 +00:00
commit-bot@chromium.org
89126a6eda Set ulimits for the compile stage. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/265453010

git-svn-id: http://skia.googlecode.com/svn/trunk@14483 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-30 19:38:51 +00:00
commit-bot@chromium.org
715d88a4e9 Fix bug with starting at the home page. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/260773002

git-svn-id: http://skia.googlecode.com/svn/trunk@14480 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-30 16:54:00 +00:00
commit-bot@chromium.org
2a8abc4552 Turn off warnings as errors, also allow c++11 extensions. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/262603005

git-svn-id: http://skia.googlecode.com/svn/trunk@14478 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-30 16:49:34 +00:00
commit-bot@chromium.org
ea80046f79 Set TCP keepalive for MySQL connections. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/268473002

git-svn-id: http://skia.googlecode.com/svn/trunk@14474 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-30 16:14:10 +00:00
commit-bot@chromium.org
51e3960e49 Add a magnifier lens to the image. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/252993003

git-svn-id: http://skia.googlecode.com/svn/trunk@14424 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-28 21:03:34 +00:00
commit-bot@chromium.org
472f830351 Add git revision info to the titlebar 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/258033006

git-svn-id: http://skia.googlecode.com/svn/trunk@14407 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-28 15:33:31 +00:00
commit-bot@chromium.org
15b29811ca Add pathops and capture stderr so we can get SkDebugf output. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/252863002

git-svn-id: http://skia.googlecode.com/svn/trunk@14402 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-28 14:56:32 +00:00
commit-bot@chromium.org
edbd6ae92e Use textContent instead of innerText. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/249113004

git-svn-id: http://skia.googlecode.com/svn/trunk@14331 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-23 19:18:15 +00:00
reed@google.com
e0d9ce890e Make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/)" 
associated chrome change (to be committed with DEPS roll)
https://codereview.chromium.org/248693002/

This reverts commit bfaceb53f58c9625b5471fcff35b5ca9ca3ae29c.

TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/248083002

git-svn-id: http://skia.googlecode.com/svn/trunk@14321 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-23 04:00:17 +00:00
commit-bot@chromium.org
9004192101 Factor out common template code. Send stdout back to web page. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/246823004

git-svn-id: http://skia.googlecode.com/svn/trunk@14317 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-22 21:13:45 +00:00
commit-bot@chromium.org
35ffc446b7 Adding the ability to click on the images in the history and have that load the code and image back into the editor space. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/246393002

git-svn-id: http://skia.googlecode.com/svn/trunk@14310 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-22 19:32:06 +00:00
commit-bot@chromium.org
c3b738af50 Move to using HTML templates when filling out the workspace history. 
This is a pre-step to having a history list that you can click on
and having the code moved back into the textarea, which will come
as a follow-up CL.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/244313007

git-svn-id: http://skia.googlecode.com/svn/trunk@14283 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-21 17:36:44 +00:00
commit-bot@chromium.org
fcbf1a1594 Update DESIGN, forgot to add new perms for the new tables. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/243013005

git-svn-id: http://skia.googlecode.com/svn/trunk@14278 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-21 15:10:56 +00:00
commit-bot@chromium.org
1bc6ecc470 Picking from the wrong end of the workspace history list. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/244133002

git-svn-id: http://skia.googlecode.com/svn/trunk@14275 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-21 14:57:50 +00:00
commit-bot@chromium.org
2dceedaa1e Add support for serving up a view that can be iframed. 
Also add support for creating the <iframe /> code needed for embedding.

This CL must land after https://codereview.chromium.org/240773003/

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/242613005

git-svn-id: http://skia.googlecode.com/svn/trunk@14266 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-19 14:50:23 +00:00
commit-bot@chromium.org
d04e1dd9e1 First pass at workspaces. 
Ability to create new workspaces. Run tries in a workspace, each try is added to a history of a workspace.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/240773003

git-svn-id: http://skia.googlecode.com/svn/trunk@14265 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-19 13:55:50 +00:00
commit-bot@chromium.org
4bd8fdc04c More sanitizing input. 
Also fix issue with parsing time on MySQL.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/235953008

git-svn-id: http://skia.googlecode.com/svn/trunk@14195 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-15 00:43:51 +00:00
commit-bot@chromium.org
06aca01c23 Add /recent, a page that displays the last 20 tries. 
Also broke out CSS as a separate file and added a title bar across both pages to easily navigate between Home and Recent.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/236193011

git-svn-id: http://skia.googlecode.com/svn/trunk@14190 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-14 20:12:08 +00:00
commit-bot@chromium.org
c81d1c40de Now with permalinks. 
Once we get a response from our XHR request update the URL to a permalink to that code.

This CL comes after https://codereview.chromium.org/235373002/

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/235323006

git-svn-id: http://skia.googlecode.com/svn/trunk@14187 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-14 18:53:10 +00:00
commit-bot@chromium.org
282333ffa2 Add design for sql storage, implementation of db that stores the data, not retrieving yet. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/235373002

git-svn-id: http://skia.googlecode.com/svn/trunk@14175 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-14 14:54:07 +00:00
commit-bot@chromium.org
28fcae2ec7 Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/) 
Reason for revert:
Want to reland the original CL.

Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/)
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144

R=reed@google.com, bensong@google.com
TBR=bensong@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/235523003

git-svn-id: http://skia.googlecode.com/svn/trunk@14156 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-11 17:15:40 +00:00
commit-bot@chromium.org
96edc24598 Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) 
Reason for revert:
Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now.

Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117

R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: bensong@google.com

Review URL: https://codereview.chromium.org/234833003

git-svn-id: http://skia.googlecode.com/svn/trunk@14149 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-11 13:47:30 +00:00
commit-bot@chromium.org
d923288e50 Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/) 
Reason for revert:
fixes on the chrome side are landing (brettw), keep fingers crossed.

Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/)
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144

R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: bensong@google.com

Review URL: https://codereview.chromium.org/233813004

git-svn-id: http://skia.googlecode.com/svn/trunk@14145 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-10 22:49:20 +00:00
commit-bot@chromium.org
757ebd20ef Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) 
Reason for revert:
breaking the Chrome deps roll.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio

Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117

R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: bensong@google.com

Review URL: https://codereview.chromium.org/234243002

git-svn-id: http://skia.googlecode.com/svn/trunk@14144 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-10 22:36:34 +00:00
commit-bot@chromium.org
4f3452d62e Flesh out the list of includes, also fix up README markdown 
Currently only pulls in 'core' and 'effects'. Will add in gpu once we add an option to render via Mesa.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/232883004

git-svn-id: http://skia.googlecode.com/svn/trunk@14137 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-10 20:24:14 +00:00
commit-bot@chromium.org
c5367ec15d Rename README and DESIGN so their markdown gets picked up my GitHub. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/231883008

git-svn-id: http://skia.googlecode.com/svn/trunk@14130 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-10 14:13:23 +00:00
skia.committer@gmail.com
6b43f50761 Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@14127 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-10 03:05:44 +00:00
commit-bot@chromium.org
0132a86876 Cleaned up the start page, added wait cursor, disabled Run button while waiting for results. 
BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/231853002

git-svn-id: http://skia.googlecode.com/svn/trunk@14121 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-09 22:54:02 +00:00
commit-bot@chromium.org
d6cab4a6af I got too aggressive on the seccomp cleanup, turns out backports-debian doesn't have the linux/seccomp.h header. 
Also forgot one last place that referenced syscall_reporter.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/231663002

git-svn-id: http://skia.googlecode.com/svn/trunk@14119 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-09 21:35:18 +00:00
commit-bot@chromium.org
149e9a107c Rename kPMColor_SkColorType to kN32_SkColorType. 
The new name better represents what this flag means.

BUG=skia:2384
R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/227433009

git-svn-id: http://skia.googlecode.com/svn/trunk@14117 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-09 20:45:29 +00:00
commit-bot@chromium.org
6d036c2e47 Initial code for webtry, a web application for allowing users to try out Skia. 
Currently running at http://108.170.220.126:8000/

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/228693002

git-svn-id: http://skia.googlecode.com/svn/trunk@14114 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-09 18:59:44 +00:00
commit-bot@chromium.org
fc94829337 remove SK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG 
remove SK_SUPPORT_LEGACY_GETDEVICECAPABILITIES

BUG=skia:
R=robertphillips@google.com, bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/227643005

git-svn-id: http://skia.googlecode.com/svn/trunk@14083 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-07 21:33:06 +00:00
commit-bot@chromium.org
e3beb6bd7d SkNonCopyable should be used with private inheritance. 
This is mostly s/public SkNoncopyable/SkNoncopyable/g.

Two classes (SkDrawLooper::Context and SkPicture::OperationList) don't actually work with SkNoncopyable because they introduce a virtual destructor.  I added SkNoncopyableVirtual to make them work as intended.  Sort of questionable whether they really need to be noncopyable in the first place, but I guess it doesn't hurt to keep the behavior the same.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/226183018

git-svn-id: http://skia.googlecode.com/svn/trunk@14081 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-04-07 19:34:38 +00:00
commit-bot@chromium.org
933e65d914 replace old SK_TRACE_EVENT macros with new TRACE_EVENT ones, and then remove them entirely! 
BUG=skia:353
R=tomhudson@google.com, epoger@google.com, reed@google.com, egdaniel@google.com, bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/196133033

git-svn-id: http://skia.googlecode.com/svn/trunk@13884 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-20 20:00:24 +00:00
commit-bot@chromium.org
44c48d062f De-virtualize SkCanvas matrix ops. 
This moves the matrix management logic into non-virtual SkCanvas
methods, and turns the virtuals into protected notifiers.

R=reed@google.com, robertphillips@google.com, bsalomon@google.com
BUG=skia:2297

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/195793012

git-svn-id: http://skia.googlecode.com/svn/trunk@13799 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-13 20:03:58 +00:00
commit-bot@chromium.org
e54a23fcfa De-virtualize SkCanvas save/restore. 
This moves the state management logic into non-virtual SkCanvas methods,
and turns the virtuals into protected notifiers.

R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/194713008

git-svn-id: http://skia.googlecode.com/svn/trunk@13776 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-12 20:21:48 +00:00
commit-bot@chromium.org
069a55a7fe Revert of Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/196323003/) 
Reason for revert:
Pulling out to rename the virtuals.

Original issue's description:
> Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/194923008/)
>
> Reason for revert:
> Re-landing after roll fix.
>
> Original issue's description:
> > Revert "De-virtualize SkCanvas save/restore."
> >
> > (To allow a roll fix into the tree).
> >
> > This reverts commit edf702204be42c945254191f9f9cd6585b3d189b.
> >
> > R=halcanary@google.com
> >
> > Committed: https://code.google.com/p/skia/source/detail?r=13748
>
> TBR=halcanary@google.com,fmalita@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=13754

R=halcanary@google.com, fmalita@chromium.org
TBR=fmalita@chromium.org, halcanary@google.com
NOTREECHECKS=true
NOTRY=true

Author: fmalita@google.com

Review URL: https://codereview.chromium.org/197553002

git-svn-id: http://skia.googlecode.com/svn/trunk@13765 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-12 15:08:22 +00:00
commit-bot@chromium.org
4fcd92d0bf Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/194923008/) 
Reason for revert:
Re-landing after roll fix.

Original issue's description:
> Revert "De-virtualize SkCanvas save/restore."
>
> (To allow a roll fix into the tree).
>
> This reverts commit edf702204be42c945254191f9f9cd6585b3d189b.
>
> R=halcanary@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=13748

R=halcanary@google.com, fmalita@chromium.org
TBR=fmalita@chromium.org, halcanary@google.com
NOTREECHECKS=true
NOTRY=true

Author: fmalita@google.com

Review URL: https://codereview.chromium.org/196323003

git-svn-id: http://skia.googlecode.com/svn/trunk@13754 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-11 23:47:35 +00:00
commit-bot@chromium.org
6f458fc221 First pass at a web app that lets you run Skia code and see the results. 
BUG=skia:
R=reed@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/195143004

git-svn-id: http://skia.googlecode.com/svn/trunk@13751 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-11 22:57:50 +00:00
fmalita@google.com
f1292bc01f Revert "De-virtualize SkCanvas save/restore." 
(To allow a roll fix into the tree).

This reverts commit edf702204be42c945254191f9f9cd6585b3d189b.

R=halcanary@google.com

Review URL: https://codereview.chromium.org/194923008

git-svn-id: http://skia.googlecode.com/svn/trunk@13748 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-11 21:46:56 +00:00
fmalita@google.com
80b10518a2 De-virtualize SkCanvas save/restore. 
This moves the state management logic into non-virtual SkCanvas methods,
and turns the virtuals into protected notifiers.

R=robertphillips@google.com, reed@google.com

Review URL: https://codereview.chromium.org/194713008

git-svn-id: http://skia.googlecode.com/svn/trunk@13747 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-11 21:04:41 +00:00
commit-bot@chromium.org
5c70cdca5e hide getTotalClip, so we can eventually remove it 
hide getClipType, so we can eventually remove it

patch from issue 189443007

TBR=robertphilips@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/189883010

git-svn-id: http://skia.googlecode.com/svn/trunk@13715 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-08 03:57:19 +00:00
commit-bot@chromium.org
32a7195310 fix the build error of SkiaExample -- use setColorType, not setConfig 
BUG=skia:
R=reed@google.com, scroggo@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/190303002

git-svn-id: http://skia.googlecode.com/svn/trunk@13700 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-07 13:24:52 +00:00
commit-bot@chromium.org
24e0496e8d Factor out a BaseContext from JsContext. 
BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/186783004

git-svn-id: http://skia.googlecode.com/svn/trunk@13660 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-04 20:44:32 +00:00
commit-bot@chromium.org
cb336874e4 Start prototyping what DisplayList support will look like. 
None of the new codepaths get executed yet since DisplayList doesn't exist, but that will happening in the new few CLs.

BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/183883017

git-svn-id: http://skia.googlecode.com/svn/trunk@13657 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-04 19:05:50 +00:00
skia.committer@gmail.com
370a89980b Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@13634 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-03-01 03:02:09 +00:00
robertphillips@google.com
8f90a892c5 add new onClip* methods to SkCanvas 
https://codereview.chromium.org/183453002/



git-svn-id: http://skia.googlecode.com/svn/trunk@13627 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-28 18:19:39 +00:00
robertphillips@google.com
03fc3b4f67 Revert of r13620 (add new onClip* methods to SkCanvas - https://codereview.chromium.org/183453002/) due to broken Chrome Canary and failing tests. 
git-svn-id: http://skia.googlecode.com/svn/trunk@13622 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-28 15:28:02 +00:00
robertphillips@google.com
392c9be344 add new onClip* methods to SkCanvas 
https://codereview.chromium.org/183453002/



git-svn-id: http://skia.googlecode.com/svn/trunk@13620 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-28 14:35:45 +00:00
commit-bot@chromium.org
f679d1bf38 Rename Path to Path2D 
BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/177963005

git-svn-id: http://skia.googlecode.com/svn/trunk@13615 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-27 20:20:21 +00:00
commit-bot@chromium.org
939560b87a Move SkV8Example to SkSurface 
BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/148523019

git-svn-id: http://skia.googlecode.com/svn/trunk@13609 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-27 17:39:40 +00:00
commit-bot@chromium.org
0a2bf90dcc Factory methods for heap-allocated SkPathEffect and SkXfermode objects. 
This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.

This patch makes the constructors of SkPathEffect, SkXfermode and
their subclasses non-public and instead provides factory methods for
creating these objects on the heap. We temporarily keep the constructors
of the following classes public to not break Chrome/Blink:

SkXfermode
SkCornerPathEffect
SkDashPathEffect

BUG=skia:2187
R=scroggo@google.com, reed@google.com, mtklein@google.com, bungeman@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/166583002

git-svn-id: http://skia.googlecode.com/svn/trunk@13519 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-20 20:40:19 +00:00
commit-bot@chromium.org
b45c56e4b7 fix iOS build -- pass colortype, not config 
BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/170743002

git-svn-id: http://skia.googlecode.com/svn/trunk@13494 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-18 23:32:05 +00:00
commit-bot@chromium.org
15a1405999 Change device factories to take SkImageInfo instead of SkBitmap::Config 
patch from issue 167033002

BUG=skia:
R=reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/168653002

git-svn-id: http://skia.googlecode.com/svn/trunk@13463 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-16 00:59:25 +00:00
commit-bot@chromium.org
e1df56579f Add conicTo(). 
BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/161223002

git-svn-id: http://skia.googlecode.com/svn/trunk@13431 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-13 16:00:58 +00:00
commit-bot@chromium.org
310ec8e32c Update directions and lib paths for ninja. 
BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/161163003

git-svn-id: http://skia.googlecode.com/svn/trunk@13429 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-02-13 15:30:06 +00:00
commit-bot@chromium.org
c896f4de12 Both gears and snow should detect if Path is available, and also report on the console if present. 
BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/143743004

git-svn-id: http://skia.googlecode.com/svn/trunk@13147 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-23 13:53:12 +00:00
tfarina@chromium.org
5a064e3af8 Remove more unnamed namespace usages. 
Skia prefers 'static' over 'unnamed' namespaces.

BUG=None
TEST=skgpu and tools
R=robertphillips@google.com, bsalomon@google.com

Review URL: https://codereview.chromium.org/139743010

git-svn-id: http://skia.googlecode.com/svn/trunk@13146 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-23 02:02:57 +00:00
commit-bot@chromium.org
58c0fa37ba Clear the canvas before drawing the gears. 
BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/141113002

git-svn-id: http://skia.googlecode.com/svn/trunk@13114 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-16 19:48:33 +00:00
commit-bot@chromium.org
2055454a4e Add handling alpha values in RRGGBBAA formatted styles. 
BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/136553006

git-svn-id: http://skia.googlecode.com/svn/trunk@13052 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-13 18:28:21 +00:00
commit-bot@chromium.org
cd11018625 Just use one version of the scripts in both the browser and in SkV8 by using feature detection to determine if we are running in a browser, and if the platform supports the Path() object. Also add oval, console.log, and the snow example code. 
BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/132413002

git-svn-id: http://skia.googlecode.com/svn/trunk@13031 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-10 21:33:01 +00:00
commit-bot@chromium.org
d08d23b385 Small tweaks to be able to build everything target: 
- fParsed is unused.
 - Quiet down a bogus -Wuninitialized warning in QWeakPointer.
Tested Clang and GCC on Linux.



BUG=
R=bungeman@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/128573002

git-svn-id: http://skia.googlecode.com/svn/trunk@12970 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-08 21:16:14 +00:00
commit-bot@chromium.org
b163984ae7 Move v8 into third_party. 
BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/116693004

git-svn-id: http://skia.googlecode.com/svn/trunk@12954 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-08 15:14:09 +00:00
commit-bot@chromium.org
d7841047e2 Add the gears.js demo and all the code changes needed to get it working, including implementing both fill and stroke style. Also add the HTML and JS files to compare with browser performance. 
BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/122373003

git-svn-id: http://skia.googlecode.com/svn/trunk@12946 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-07 19:00:27 +00:00
skia.committer@gmail.com
179f6c5e62 Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@12936 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-07 07:01:50 +00:00
commit-bot@chromium.org
9ee0e32886 Turn on GL drawing, allow switching via --gpu flag. 
This CL comes after https://codereview.chromium.org/121303004/.

BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/122453003

git-svn-id: http://skia.googlecode.com/svn/trunk@12923 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-06 20:03:55 +00:00
commit-bot@chromium.org
c8d732800e Renamed JsCanvas to JsContext and moved into it's own file. 
Fleshed out a lot of the Path interface.

BUG=
R=robertphillips@google.com, tfarina@chromium.org, reed@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/121303004

git-svn-id: http://skia.googlecode.com/svn/trunk@12913 2bbb7eff-a529-9590-31e7-b0007b416f81
 2014-01-06 18:17:24 +00:00
commit-bot@chromium.org
872796bb8e Allow multiple concurrent timers. 
BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/118473006

git-svn-id: http://skia.googlecode.com/svn/trunk@12802 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-20 15:56:52 +00:00
reed@google.com
1915fd09f3 remove unused SkFixed and SkFract functions 
BUG=
R=caryclark@google.com

Review URL: https://codereview.chromium.org/113873008

git-svn-id: http://skia.googlecode.com/svn/trunk@12767 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-19 14:22:03 +00:00
commit-bot@chromium.org
0fc0dea333 Add a setTimer() function. 
Seemed simple, but required adding a Global class that contains all the global state (instance and context) for our running V8 instance. Also moved canvas.inval to be just inval() at the global level.

BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/103143009

git-svn-id: http://skia.googlecode.com/svn/trunk@12730 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-18 04:45:37 +00:00
commit-bot@chromium.org
b09bfcb7b1 add virtual destructor for SkExample to fix build error. 
The original SkExample have virtual function draw(), but have no virtual destructor. This may lead to memory leak when free the instance of derived class of SkExample. The latest skia code show error when build SkiaExamples by "ninja -C out/Release SkiaExamples":
error: ‘class SkExample’ has virtual functions and accessible non-virtual destructor.

R=caryclark@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/98463013

git-svn-id: http://skia.googlecode.com/svn/trunk@12728 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-17 23:37:38 +00:00
reed@google.com
26deb23e15 change SkScalarRound to SkScalarRoundToInt 
BUG=

Review URL: https://codereview.chromium.org/105073006

git-svn-id: http://skia.googlecode.com/svn/trunk@12720 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-17 19:50:57 +00:00
reed@google.com
e1ca705cac deprecate SkScalarRound (and its ilk), use SkScalarRound[ToInt,ToScalar]. #define SK_SUPPORT_DEPRECATED_SCALARROUND for legacy clients 
BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/111353003

git-svn-id: http://skia.googlecode.com/svn/trunk@12719 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-17 19:22:07 +00:00
reed@google.com
8f4d2306fa remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats 
To keep the CL (slightly) managable, this does not make any changes to
existing macros (e.g. SkScalarMul). Just tackling #ifdef constructs this
time around.

BUG=
R=bsalomon@google.com, caryclark@google.com

Review URL: https://codereview.chromium.org/117053002

git-svn-id: http://skia.googlecode.com/svn/trunk@12712 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-17 16:44:46 +00:00
commit-bot@chromium.org
4ad1e97b85 Add a print function in the global JS scope for debugging. 
BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/100583005

git-svn-id: http://skia.googlecode.com/svn/trunk@12695 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-16 19:55:01 +00:00
commit-bot@chromium.org
48d94b8ce5 Add command line flag for optionally loading JS from external files. 
BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/111853008

git-svn-id: http://skia.googlecode.com/svn/trunk@12692 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-16 18:24:51 +00:00
commit-bot@chromium.org
3a6143d91f Added canvas.fillStyle with support for just the "#RRGGBB" style of colors. 
Also renamed drawRect to fillRect, which now take x,y,w,h parameters.

BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/108813004

git-svn-id: http://skia.googlecode.com/svn/trunk@12621 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-11 17:34:58 +00:00
skia.committer@gmail.com
63ba319483 Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@12617 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-11 07:02:06 +00:00
robertphillips@google.com
befb499da5 Fix error in r12597 (can't forget that newline at the end of a file) 
git-svn-id: http://skia.googlecode.com/svn/trunk@12598 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-10 15:51:43 +00:00
robertphillips@google.com
42cc237caf New Composite CSS border object 
https://codereview.chromium.org/86263003/



git-svn-id: http://skia.googlecode.com/svn/trunk@12597 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-10 15:19:32 +00:00
commit-bot@chromium.org
9bde13c1b2 Add a canvas object with drawRect() and inval(). 
BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/110693002

git-svn-id: http://skia.googlecode.com/svn/trunk@12595 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-10 14:13:03 +00:00
commit-bot@chromium.org
80bd0c995d A simple draw() function in Javascript. 
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/102803003

git-svn-id: http://skia.googlecode.com/svn/trunk@12527 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-06 15:24:52 +00:00
commit-bot@chromium.org
44a3877442 V8 and Skia 
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/93933005

git-svn-id: http://skia.googlecode.com/svn/trunk@12503 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-05 13:45:19 +00:00
scroggo@google.com
8272d87d30 Remove SkPdfNativeDoc::tokenizerOfStream. 
Instead, initialize an SkPdfNativeTokenizer directly on the stack.

Fixes a memory leak in SkPdfFont.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/100323003

git-svn-id: http://skia.googlecode.com/svn/trunk@12462 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-03 16:15:31 +00:00
bungeman@google.com
0d9e3da8bb Use lowercase windows.h in includes to fix Windows cross compilation using mingw. 
While it doesn't matter on Windows, mingw on case-sensitive OSes uses all lower case filenames for platform include files. I found the problem in SkCondVar.h from Mozilla checkout of skia sources, but the patch contains a fix for the whole skia tree.

R=bungeman@google.com

Review URL: https://codereview.chromium.org/99173003

git-svn-id: http://skia.googlecode.com/svn/trunk@12461 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-03 15:23:37 +00:00
skia.committer@gmail.com
f242a484e3 Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@12453 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-03 07:02:11 +00:00
scroggo@google.com
36026de644 Simplify SkPdfTokenLooper behavior. 
Instead of passing a pointer to a pointer to a NULL looper, which can
then be set to point to a new looper (which then must be looped and
deleted), pass a pointer to the current looper. Each function can then
create a looper based on the parent (on the stack) and call loop()
itself.

Remove setUp(). Now that there is a pointer to the parent at creation
time, there is no need for this function.

Modify the constructors to only provide ones that are needed.

Add documentation.

Remove PdfInlineImageLooper::done(), which is never used.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/83183004

git-svn-id: http://skia.googlecode.com/svn/trunk@12447 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-02 22:34:45 +00:00
scroggo@google.com
5f008652f6 Remove some PdfViewer warnings. 
Fix build.

git-svn-id: http://skia.googlecode.com/svn/trunk@12438 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-02 20:58:12 +00:00
scroggo@google.com
5092adc546 Separate and update PDF_DIFF_TRACE_IN_PNG 
Move its functionality out of readToken() and into its own class.
Callers of the previous readToken() now call
SkPdfNativeTokenizer::readToken(), which in turn calls a function
for writing the diff to a file, if the caller requests it and
PDF_TRACE_DIFF_IN_PNG is defined.

Do not attempt to draw a diff for compatibility sections, which we
do not draw.

Use SkString to handle string manipulation.

Hide globals only used by PDF_TRACE_DIFF_IN_PNG behind that flag.

Remove hasVisualEffects, which always returns true.

Rename gLastOpKeyword to gOpCounter for clarity.

In SkPdfNativeTokenizer, set fEmpty to true when the entire stream
has been read.

Use SkBitmap::copyTo instead of manually copying an SkBitmap.

Builds on https://codereview.chromium.org/79933003/

R=mtklein@google.com

Review URL: https://codereview.chromium.org/80463005

git-svn-id: http://skia.googlecode.com/svn/trunk@12436 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-02 20:22:31 +00:00
scroggo@google.com
248647cebb Restructuring of PdfViewer code. 
The only change in behavior is that SkPdfAllocator on SkPdfContext is
no longer allocated on the heap.

In general, I have just moved code.

SkPdfContext:
Inherit from SkNoncopyable.
Make SkPdfContext directly own fTmpPageAllocator. fTmpPageAllocator is
created when SkPdfContext is, and destroyed at the same time as well,
so there is no reason for the extra allocation.
Add the function parseStream. This eliminates code duplication, and
allows making fTmpPageAllocator private.
Move PdfMainLooper into the implementation file, since it is now only
used by parseStream.
Move SkTDictWithDefaultConstructor and render stats info here, in
support of PdfMainLooper.

SkPdfTokenLooper:
Rename PdfTokenLooper to SkPdfTokenLooper.
Move readToken here, unchanged.
Remove tokenizer(), which is unused.

SkPdfNativeDoc:
Remove tokenizerOfPage and tokenizerOfBuffer, which are unused.

SkPdfOps:
Move gPdfOps and PdfOperatorRenderer into a header file (hidden for
now), so they can be accessed by both SkPdfRenderer.cpp and
SkPdfContext.cpp.

SkPdfRenderer:
Harvest things into other files:
PdfMainLooper (and the code that calls it) -> SkPdfContext.
readToken -> SkPdfTokenLooper.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/79933003

git-svn-id: http://skia.googlecode.com/svn/trunk@12435 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-12-02 20:18:09 +00:00
commit-bot@chromium.org
4b413c8bb1 remove SkFloatToScalar macro 
BUG=
R=reed@google.com, djsollen@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/85463005

git-svn-id: http://skia.googlecode.com/svn/trunk@12385 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-25 19:44:07 +00:00
scroggo@google.com
bf6426120a Move PdfTokenLooper into its own file. 
Otherwise, leave the class unchanged.

Review URL: https://codereview.chromium.org/79773002

git-svn-id: http://skia.googlecode.com/svn/trunk@12333 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-20 23:12:25 +00:00
scroggo@google.com
d1cf7696f5 Ifdef guard for SkPdfContext. 
Review URL: https://codereview.chromium.org/79723002

git-svn-id: http://skia.googlecode.com/svn/trunk@12332 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-20 22:50:40 +00:00
scroggo@google.com
d906702f78 Move SkPdfContext into its own files. 
Otherwise, the class is unchanged.

Review URL: https://codereview.chromium.org/77763007

git-svn-id: http://skia.googlecode.com/svn/trunk@12330 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-20 22:33:39 +00:00
scroggo@google.com
b1de123336 Make changes based on talks with Edison. 
Mostly FIXMEs, to go back and look at in more detail.

Fix a bug where ET did not set fTextBlock back to false.

Corresponds to notes in https://code.google.com/p/skia/source/detail?r=12270

git-svn-id: http://skia.googlecode.com/svn/trunk@12329 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-20 22:02:32 +00:00
scroggo@google.com
7d8013f306 Changes to SkTDStackNester. 
SkTDStackNester is a class used by PdfViewer to assist in saving
and restoring the PDF state. Clean up and test this class.

Add some documentation.

Add FIXME's where I have questions to resolve.

Fix a bug where fNestingLevel was not initialized.

Remove a commented out line of code copied over from
SkTDStack.

Rename SkTDStackNester::nests() to nestingLevel() and make it const.

Remove unnecessary predeclaration and friend declaration.

Remove index() (both const and non-const versions). They were
unused, return something that may not be expected (index from
the top, rather than from the bottom), and don't work to get any
elements in earlier Recs once the first one is full.

Report a warning if the nesting level goes above the maximum level,
or if we attempt to bring it below zero.

Prevent fNestingLevel from dropping below zero.

Add kUnusedObject_SkPdfIssue, and use it where appropriate.

Depends on https://codereview.chromium.org/64093009/

R=mtklein@google.com

Review URL: https://codereview.chromium.org/68843006

git-svn-id: http://skia.googlecode.com/svn/trunk@12328 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-20 21:40:57 +00:00
scroggo@google.com
0daf00ccd7 Move SkTDStackNester into its own private file. 
Also remove depth(), which is unused.

Otherwise the class is unchanged.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/64093009

git-svn-id: http://skia.googlecode.com/svn/trunk@12324 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-20 20:47:21 +00:00
mtklein@google.com
0724e1fc2d Hide unused gFormats. 
Presumably this is WIP code?  Otherwise, we delete it?

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/78503003

git-svn-id: http://skia.googlecode.com/svn/trunk@12321 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-20 18:02:00 +00:00
mtklein@google.com
9615f8dbf1 Add missing (trivial) virtual destructors. 
BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/78543002

git-svn-id: http://skia.googlecode.com/svn/trunk@12312 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-20 14:29:51 +00:00
scroggo@google.com
909228992c Pdfviewer refactoring. 
Mostly superficial changes, to help me make sure I understand the
code while making modifications.

SkPdfRenderer:
First class I'm modifying. Move it into include/ and src/ directories.
Inherit from SkNoncopyable.
Replace load() with factory function which returns NULL if the load
fails.
Remove unload() and loaded(), which no longer make sense, since the
factory will return NULL on a failure to load, and unload() happens
on destruction.
Use a const char* for loading a PDF, following the convention of
SkStream::NewFromFile.
Remove unnecessary call to sqrt in SkPDFNativeRenderToBitmap.
Also in SkPDFNativeRenderToBitmap, use an appropriate SkScalar macro
to convert to an integer.
Use this-> when calling member functions.

pdf_viewer_main.cpp:
Call the new interface for SkPdfRenderer.

gyp files:
Refer to the new location of SkPdfRenderer.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/59493011

git-svn-id: http://skia.googlecode.com/svn/trunk@12296 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-14 19:09:27 +00:00
scroggo@google.com
c6e1e9a9cc Fix warnings and Win only error in pdf_viewer. 
git-svn-id: http://skia.googlecode.com/svn/trunk@12292 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-14 17:05:05 +00:00
scroggo@google.com
221253861d Include SkBitmapDevice for pdf_viewer. 
git-svn-id: http://skia.googlecode.com/svn/trunk@12289 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-14 16:01:23 +00:00
edisonn@google.com
608c35e5c4 pdfviewer: readobject can return null, and catalog can be null 
Review URL: https://codereview.chromium.org/72053002

git-svn-id: http://skia.googlecode.com/svn/trunk@12276 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-13 20:23:40 +00:00
reed@google.com
5308c83a36 drawPosTextOnPath is now deprecated, removing all overrides and impls 
BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/61743017

git-svn-id: http://skia.googlecode.com/svn/trunk@12270 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-13 15:22:15 +00:00
edisonn@google.com
04068b13e5 pdfviewer: remove sqrt from the formula computing the scale (DPI is dots per inch, not dots per square inch) 
Review URL: https://codereview.chromium.org/70793003

git-svn-id: http://skia.googlecode.com/svn/trunk@12258 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-12 21:56:39 +00:00
scroggo@google.com
940ccc819b Add a script for running pdfviewer and comparing to existing results. 
For quick, local checking to see how changes to pdfviewer have changed
PDF files.

Scripts were originally written by edisonn, and updated here for checkin.

R=epoger@google.com

Review URL: https://codereview.chromium.org/62103008

git-svn-id: http://skia.googlecode.com/svn/trunk@12241 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-12 14:52:47 +00:00
scroggo@google.com
5c7be9584c Use SkPathJoin and SkBasename in Pdfviewer. 
Remove redundant code.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/68263003

git-svn-id: http://skia.googlecode.com/svn/trunk@12240 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-12 14:43:44 +00:00
edisonn@google.com
247ac53c29 pdfviewer: fix build break in windows (wrong return type on function) 
Review URL: https://codereview.chromium.org/68973002

git-svn-id: http://skia.googlecode.com/svn/trunk@12216 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-11 15:36:44 +00:00
edisonn@google.com
b9731e7dd5 pdfviewr: include what you use (stdio) 
Review URL: https://codereview.chromium.org/64913003

git-svn-id: http://skia.googlecode.com/svn/trunk@12179 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-07 22:07:34 +00:00
edisonn@google.com
5e4d9819db pdfviewer: fix typos (|| instead of |) 
Review URL: https://codereview.chromium.org/65263002

git-svn-id: http://skia.googlecode.com/svn/trunk@12176 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-07 20:33:17 +00:00
scroggo@google.com
a7a946a617 Fix Mac warning in PdfViewer. 
Move a function only used by code guarded by #ifdef PDF_REPORT inside
guard.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/60763003

git-svn-id: http://skia.googlecode.com/svn/trunk@12170 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-11-07 18:22:18 +00:00
bsalomon@google.com
7ce564cccb Revert "If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance." 
This reverts commit r11904

Review URL: https://codereview.chromium.org/35543002

git-svn-id: http://skia.googlecode.com/svn/trunk@11909 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-22 16:54:15 +00:00
bsalomon@google.com
ad254fee73 If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance. 
Committed: http://code.google.com/p/skia/source/detail?r=11842

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23484007

git-svn-id: http://skia.googlecode.com/svn/trunk@11904 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-22 13:19:12 +00:00
robertphillips@google.com
c2cc1dbe81 Revert r11842 (call drawRect to try GrAARectRenderer if the path is a rect - https://codereview.chromium.org/23484007) due to changes to the following GM images: 
inverse_paths
pathopsinverse




git-svn-id: http://skia.googlecode.com/svn/trunk@11845 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-17 17:34:20 +00:00
commit-bot@chromium.org
521a46750d If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance. 
R=bsalomon@google.com, robertphillips@google.com, reed@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/23484007

git-svn-id: http://skia.googlecode.com/svn/trunk@11842 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-17 16:29:21 +00:00
edisonn@google.com
d03c2c732e pdfviewer: more code comments + concat the pdf matrix with the existing matrix in canvas, instead of reseting it. 
Review URL: https://codereview.chromium.org/27057003

git-svn-id: http://skia.googlecode.com/svn/trunk@11735 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-11 18:26:45 +00:00
edisonn@google.com
2af2ad9cc0 pdfviewer: (more code cleanup): class documentation and comments 
Review URL: https://codereview.chromium.org/27043002

git-svn-id: http://skia.googlecode.com/svn/trunk@11730 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-11 16:17:44 +00:00
edisonn@google.com
e50d9a1fcd mode code cleanup (100c / l, comments) 
Review URL: https://codereview.chromium.org/26912005

git-svn-id: http://skia.googlecode.com/svn/trunk@11716 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-10 20:58:22 +00:00
commit-bot@chromium.org
ab9d30cb01 basically a typo 
R=caryclark@google.com, bsalomon@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/23619063

git-svn-id: http://skia.googlecode.com/svn/trunk@11689 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-10 02:53:30 +00:00
edisonn@google.com
c8fda9d96b code cleanup 
Review URL: https://codereview.chromium.org/26613006

git-svn-id: http://skia.googlecode.com/svn/trunk@11687 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-09 20:23:12 +00:00
edisonn@google.com
598cf5d3cf remove tracking code, as it polutes the code readability. Should be added back, in a less eficient way, by registering streams instead, so we don't have to pass arround the streams, and the code will be cleaner. 
Review URL: https://codereview.chromium.org/26700002

git-svn-id: http://skia.googlecode.com/svn/trunk@11671 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-09 15:13:19 +00:00
edisonn@google.com
67d7fb4e89 pdf report files 
Review URL: https://codereview.chromium.org/26271002

git-svn-id: http://skia.googlecode.com/svn/trunk@11629 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-10-07 15:40:21 +00:00
edisonn@google.com
af54a513a5 pdfviewer: do not submit, uploaded for backup, and will be done actually after I refactor the params for functions, to put the char* params in a structure: report errors and warnings in pdf, infrastructure 
Review URL: https://codereview.chromium.org/23902018

git-svn-id: http://skia.googlecode.com/svn/trunk@11262 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-09-13 19:33:42 +00:00
edisonn@google.com
bca421b468 pdfviewer: (part 1) store the offset of the location of object in file/stream. In order to use the feature, enable the macro defined in SkPdfConfig.h 
Review URL: https://codereview.chromium.org/23456022

git-svn-id: http://skia.googlecode.com/svn/trunk@11117 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-09-05 20:00:21 +00:00
edisonn@google.com
0fd25d8b22 pdfviewer: track what objects have been used during rendering. It will be the base of reporting unused objects to warn about ineficiencies in pdf generations, tests, and what features are not implemented fully. 
Review URL: https://codereview.chromium.org/23601017

git-svn-id: http://skia.googlecode.com/svn/trunk@11100 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-09-05 16:40:34 +00:00
edisonn@google.com
e91260c3e7 pdfviewer: fix break, include the right header. 
Review URL: https://codereview.chromium.org/23493018

git-svn-id: http://skia.googlecode.com/svn/trunk@11083 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-09-04 17:29:06 +00:00
mtklein@google.com
bd6343b1d6 Rewrite SkTRegistry to take any trivially-copyable type. 
Obviously these are all currently function pointers of type T(*)(P) for various
T and P.  In bench refactoring, I'm trying to register a function pointer of
type T(*)(), which can't be done as is (passing P=void doesn't work).  This
also lets us register things like primitives, which is conceivable useful.

BUG=
R=reed@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/23453031

git-svn-id: http://skia.googlecode.com/svn/trunk@11082 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-09-04 17:20:18 +00:00
commit-bot@chromium.org
a6f37e77c1 Add ShouldSkip variant that can read a --match flag directly. 
Just seemed like we were going through lots of hoops for this common case.

BUG=
R=scroggo@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/23708009

git-svn-id: http://skia.googlecode.com/svn/trunk@11034 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-30 15:52:46 +00:00
commit-bot@chromium.org
e029440758 Replace SkTScopedPtr with SkAutoTDelete in Skia. 
BUG=
R=djsollen@google.com, reed@google.com, vandebo@chromium.org

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/23621005

git-svn-id: http://skia.googlecode.com/svn/trunk@11016 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-29 22:14:04 +00:00
robertphillips@google.com
1f2f338e23 Split SkDevice into SkBaseDevice and SkBitmapDevice 
https://codereview.chromium.org/22978012/



git-svn-id: http://skia.googlecode.com/svn/trunk@10995 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-29 11:54:56 +00:00
epoger@google.com
1c9518b09d Remove experimental/json-expectations , no longer needed. 
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23498007

git-svn-id: http://skia.googlecode.com/svn/trunk@10941 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-27 16:48:04 +00:00
edisonn@google.com
73613c16e1 pdfviewer: if the resources are missing, exit (right now inheritance is not implemented) 
Review URL: https://codereview.chromium.org/23125015

git-svn-id: http://skia.googlecode.com/svn/trunk@10875 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-22 15:48:35 +00:00
mtklein@google.com
330313a8a8 My clang now doesn't complain about !"foo". 
BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22875037

git-svn-id: http://skia.googlecode.com/svn/trunk@10874 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-22 15:37:26 +00:00
edisonn@google.com
f68aed3381 pdfviewer: when q start, and an operator is called, it should not be able to see operands before q. nest/unnest are similar with pop/push - simulates a stack of stacks, in a single stack 
Review URL: https://codereview.chromium.org/23033022

git-svn-id: http://skia.googlecode.com/svn/trunk@10873 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-22 15:37:21 +00:00
edisonn@google.com
bd2f30132e pdfviewer: add macros to automatically check number and type of parameters 
Review URL: https://codereview.chromium.org/23038021

git-svn-id: http://skia.googlecode.com/svn/trunk@10872 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-22 14:18:04 +00:00
skia.committer@gmail.com
37c18e4e38 Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@10871 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-22 07:01:59 +00:00
edisonn@google.com
cf2cfa174c pdfviewer: code cleanup - add licence on files, make replace __DEFINE__foo with foo_DEFINED to match skia project 
Review URL: https://codereview.chromium.org/23361009

git-svn-id: http://skia.googlecode.com/svn/trunk@10854 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-21 16:31:37 +00:00
skia.committer@gmail.com
b74bdf0249 Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@10842 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-21 07:01:29 +00:00
robertphillips@google.com
9b051a375b Revert r10830 (Split SkDevice out of SkRasterDevice) until we can get Chromium ready. 
git-svn-id: http://skia.googlecode.com/svn/trunk@10835 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-20 20:06:40 +00:00
edisonn@google.com
8cee797901 pdfviewer: check in pdfapi classes 
Review URL: https://codereview.chromium.org/22900010

git-svn-id: http://skia.googlecode.com/svn/trunk@10834 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-20 18:56:49 +00:00
robertphillips@google.com
3055b70018 Split SkDevice out of SkBitmapDevice 
https://codereview.chromium.org/22978012/



git-svn-id: http://skia.googlecode.com/svn/trunk@10830 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-20 17:49:04 +00:00
tfarina@chromium.org
f6de475e5c Replace uses of GrAssert by SkASSERT. 
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/22850006

git-svn-id: http://skia.googlecode.com/svn/trunk@10789 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-17 00:02:59 +00:00
edisonn@google.com
5c34491b94 pdfviewer: remove one #include to STL, that is not needed 
Review URL: https://codereview.chromium.org/23082004

git-svn-id: http://skia.googlecode.com/svn/trunk@10783 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-16 17:37:31 +00:00
edisonn@google.com
2c8177767a pdfviewer: update interface of derived canvas and device, to reflect lastest changes in the interfaces. 
Review URL: https://codereview.chromium.org/23048006

git-svn-id: http://skia.googlecode.com/svn/trunk@10780 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-16 16:30:02 +00:00
edisonn@google.com
063d7072ef pdfviewer: code cleanup - remove STL usage 
Review URL: https://codereview.chromium.org/23258004

git-svn-id: http://skia.googlecode.com/svn/trunk@10772 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-16 15:05:08 +00:00
edisonn@google.com
fb7b1bf534 pdfviewer: workaround gyp issue with multiple files, not being translated into an array in linux (works in mac, as per spec) 
Review URL: https://codereview.chromium.org/23157003

git-svn-id: http://skia.googlecode.com/svn/trunk@10726 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-14 22:05:06 +00:00
edisonn@google.com
33f11b6fcd pdfviewer: make pdfviewer compile on mac 
Review URL: https://codereview.chromium.org/23163007

git-svn-id: http://skia.googlecode.com/svn/trunk@10721 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-14 21:35:27 +00:00
edisonn@google.com
3aa355527a pdfviewer: 1) debug code for drawText (show magenta background for text, to show text even when we fail to load/show it), 2) some cleanup: refactor and rename classes and files 
Review URL: https://codereview.chromium.org/23020003

git-svn-id: http://skia.googlecode.com/svn/trunk@10716 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-14 18:26:20 +00:00
edisonn@google.com
53766103b5 pdfviewer: remove text save/restore (not needed) and verify that colorspace dictionary exists before using it 
Review URL: https://codereview.chromium.org/22436003

git-svn-id: http://skia.googlecode.com/svn/trunk@10639 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-08 12:54:01 +00:00
edisonn@google.com
768bc6a920 pdfviewer: add ability to run on gpu 
Review URL: https://codereview.chromium.org/22684002

git-svn-id: http://skia.googlecode.com/svn/trunk@10638 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-08 12:42:13 +00:00
edisonn@google.com
16291e51d5 pdfviewer: remove save/restore used with q/Q operators (we already do there save and restore) 
Review URL: https://codereview.chromium.org/22678003

git-svn-id: http://skia.googlecode.com/svn/trunk@10636 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-08 11:40:26 +00:00
edisonn@google.com
4f898b78bb pdfviewer: absolute minimal; to al least render (even if poorly) ICC based color spaces, based on RGB 
Review URL: https://codereview.chromium.org/22624002

git-svn-id: http://skia.googlecode.com/svn/trunk@10630 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-07 21:11:57 +00:00
edisonn@google.com
e57c62d039 pdfviewer: fix font rotation issues 
Review URL: https://codereview.chromium.org/22407005

git-svn-id: http://skia.googlecode.com/svn/trunk@10617 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-07 18:04:15 +00:00
edisonn@google.com
0f90190084 pdfviewer: /Pattern color space, uses the matrix of the last content stream, not the global matrix. 
Review URL: https://codereview.chromium.org/22460004

git-svn-id: http://skia.googlecode.com/svn/trunk@10595 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-07 11:56:16 +00:00
edisonn@google.com
2273f9b45f pdfviewer: load image pain settings (like transparency), pass the page number, report failure if at least one render fails, and check that xref section starts with xref keyword. 
Review URL: https://codereview.chromium.org/22465006

git-svn-id: http://skia.googlecode.com/svn/trunk@10588 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-06 21:48:44 +00:00
edisonn@google.com
7e27bcd64a pdfviewer: remove debug traces 
Review URL: https://codereview.chromium.org/22284004

git-svn-id: http://skia.googlecode.com/svn/trunk@10551 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-05 22:08:50 +00:00
edisonn@google.com
91ce698cf2 pdfviewer: debug code for crash 
Review URL: https://codereview.chromium.org/22269002

git-svn-id: http://skia.googlecode.com/svn/trunk@10548 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-05 20:45:40 +00:00
edisonn@google.com
7ee12ca99f pdfviewer: add virtual destructor for SkPdfFont 
Review URL: https://codereview.chromium.org/22239002

git-svn-id: http://skia.googlecode.com/svn/trunk@10541 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-05 18:18:06 +00:00
edisonn@google.com
45be4eb904 pdfviewer: fix typo 
Review URL: https://codereview.chromium.org/22076007

git-svn-id: http://skia.googlecode.com/svn/trunk@10540 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-05 17:59:11 +00:00
edisonn@google.com
5149bd954b pdfviewer: set backdround to transparent, and add an app to chop transparent content in png files. 
Review URL: https://codereview.chromium.org/21981008

git-svn-id: http://skia.googlecode.com/svn/trunk@10538 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-05 17:26:11 +00:00
edisonn@google.com
b0145ce60e pdfviewer: add indexed rbg image support, enhanche caching(setData) for SkPdfObject 
Review URL: https://codereview.chromium.org/21738005

git-svn-id: http://skia.googlecode.com/svn/trunk@10534 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-05 16:23:23 +00:00
edisonn@google.com
e2e01ffb94 pdfviewer: implementation of one type of pattern - simple tile patern, colored, with xstep and ystep positive. 
Review URL: https://codereview.chromium.org/21919003

git-svn-id: http://skia.googlecode.com/svn/trunk@10523 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-02 20:24:48 +00:00
edisonn@google.com
276fed9e0a pdfviewer: debug the parameters for snc, and for resolveReference 
Review URL: https://codereview.chromium.org/21604003

git-svn-id: http://skia.googlecode.com/svn/trunk@10498 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-01 21:20:47 +00:00
edisonn@google.com
9a43c18740 pdfviewer: finish implementation of SkPdfObject.toString(), and include in debugging traces we leave when rendering. 
Review URL: https://codereview.chromium.org/20628008

git-svn-id: http://skia.googlecode.com/svn/trunk@10494 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-01 20:06:42 +00:00
edisonn@google.com
251176ebe9 pdfviewer: remove simple implementation for non-isolated groups. will be implemented in skia most probably. also it is not generated by SkPDFDevice 
Review URL: https://codereview.chromium.org/21537003

git-svn-id: http://skia.googlecode.com/svn/trunk@10479 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-08-01 13:24:00 +00:00
edisonn@google.com
f111a4b685 pdfviewer: transparency groups - implementation of non-isolated and non-knockout flags 
Review URL: https://codereview.chromium.org/21288002

git-svn-id: http://skia.googlecode.com/svn/trunk@10467 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-31 18:22:36 +00:00
edisonn@google.com
24cdf13b31 pdfviewer: more prerequired work to have examples working for transparency work items. 
Review URL: https://codereview.chromium.org/21252003

git-svn-id: http://skia.googlecode.com/svn/trunk@10438 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-30 16:06:12 +00:00
edisonn@google.com
88fc03dd1f pdfviewer: add doPage function, cet stream from Contents 
Review URL: https://codereview.chromium.org/21049009

git-svn-id: http://skia.googlecode.com/svn/trunk@10433 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-30 13:34:10 +00:00
edisonn@google.com
641cce90c9 pdfviewer: fix condition for element in array, reset back the default color to white, and verify type before value in PDF API mapper 
Review URL: https://codereview.chromium.org/21017004

git-svn-id: http://skia.googlecode.com/svn/trunk@10427 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-30 12:09:14 +00:00
edisonn@google.com
4ef4bed00e pdfviewer: load files with missing xref (we need in order to help with testing, as most good pdfx in the whild miss the xref). add period as a valid character to start a real value. 
Review URL: https://codereview.chromium.org/21096006

git-svn-id: http://skia.googlecode.com/svn/trunk@10423 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-29 22:14:45 +00:00
edisonn@google.com
e878e726bd pdfviewer: more plumming for soft masks, blend modes and transparency groups 
Review URL: https://codereview.chromium.org/21125002

git-svn-id: http://skia.googlecode.com/svn/trunk@10419 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-29 19:10:58 +00:00
edisonn@google.com
96ba3aa2fa pdfviewer: fix a few warnings 
Review URL: https://codereview.chromium.org/20662003

git-svn-id: http://skia.googlecode.com/svn/trunk@10404 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-28 20:04:35 +00:00
edisonn@google.com
a0cefa18fc pdfviewer: gs operator implementation: dashing and font 
Review URL: https://codereview.chromium.org/20810002

git-svn-id: http://skia.googlecode.com/svn/trunk@10403 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-28 18:34:14 +00:00
edisonn@google.com
1acab362fd pdfviewer: limit the characters we support in ToUnicode, to 0xffff 
Review URL: https://codereview.chromium.org/20538002

git-svn-id: http://skia.googlecode.com/svn/trunk@10377 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-25 22:03:22 +00:00
edisonn@google.com
ac4bedcb10 pdfviewer: set the default background to transparent (to match render_picture default), and fix a bug a with corrupt diffs 
Review URL: https://codereview.chromium.org/20526002

git-svn-id: http://skia.googlecode.com/svn/trunk@10376 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-25 21:40:23 +00:00
edisonn@google.com
50bbdb4f3e pdfviewer: update drawBitmap, and fic a gyp issue: gyp does not run in a consistent way on various palt forms, and it generates some files in ../../../foo instead of ../foo - Solution: use the (inconvenient) Shared intermediary directory that should work on all platforms. 
Review URL: https://codereview.chromium.org/20328002

git-svn-id: http://skia.googlecode.com/svn/trunk@10359 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-25 15:33:13 +00:00
skia.committer@gmail.com
5c561cb8d8 Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@10340 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-25 07:01:00 +00:00
edisonn@google.com
2c88fe87bd pdfviewer: fix path shortcuts in python script, use os.path.join() 
Review URL: https://codereview.chromium.org/19623007

git-svn-id: http://skia.googlecode.com/svn/trunk@10334 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-24 19:42:11 +00:00
edisonn@google.com
d6c276f1fe pdfviewer: sets module is deprecated. use set 
Review URL: https://codereview.chromium.org/20101002

git-svn-id: http://skia.googlecode.com/svn/trunk@10332 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-24 19:31:30 +00:00
edisonn@google.com
0449a569b9 pdfviewer: explicitely use set, instead of dictionary, fails to compile in some versions of python. 
Review URL: https://codereview.chromium.org/19804010

git-svn-id: http://skia.googlecode.com/svn/trunk@10320 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-24 17:51:27 +00:00
sglez@google.com
43f2b2c833 SkiaExamples improvements. 
Make it possible for a client to write a Hello World in less than 50 lines.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/18574002

git-svn-id: http://skia.googlecode.com/svn/trunk@10319 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-24 17:48:03 +00:00
edisonn@google.com
147adb10f7 pdfviewer: remove dependency on picture_utils. add utility function to render SkStream into bitmap. 
Review URL: https://codereview.chromium.org/20087003

git-svn-id: http://skia.googlecode.com/svn/trunk@10314 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-24 15:56:19 +00:00
robertphillips@google.com
58c856a54a Reverting r10251 (Implement crop rect for SkImageFilter) due to Chromium-side unit test failures 
git-svn-id: http://skia.googlecode.com/svn/trunk@10304 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-24 13:18:06 +00:00
skia.committer@gmail.com
7f1af501f2 Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@10299 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-24 07:01:12 +00:00
edisonn@google.com
1f080163ac pdfviewer: more simple fixed to prevent crashes 
Review URL: https://codereview.chromium.org/19625008

git-svn-id: http://skia.googlecode.com/svn/trunk@10294 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-23 21:05:49 +00:00
edisonn@google.com
b44334c1c0 pdfviewer: don't crash if the xref is corrupted. 
Review URL: https://codereview.chromium.org/20004007

git-svn-id: http://skia.googlecode.com/svn/trunk@10293 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-23 20:47:05 +00:00
edisonn@google.com
2fd5d36ea6 pdfviewer: fix type3 font, make SkPdfObject::get parameter const 
Review URL: https://codereview.chromium.org/19670019

git-svn-id: http://skia.googlecode.com/svn/trunk@10289 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-23 19:43:48 +00:00
edisonn@google.com
2ccc3afa47 pdfviewer: improve memory usage, improve parse time (by 30-50%) and don't allocate extra buffers (more to do, but low priority now), and put the page specific memory in an allocator. 
Review URL: https://codereview.chromium.org/19793011

git-svn-id: http://skia.googlecode.com/svn/trunk@10282 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-23 17:43:18 +00:00
skia.committer@gmail.com
6ae6383f56 Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@10254 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-23 07:01:05 +00:00
zachr@google.com
5b3e2b9622 move skpdiff into tools 
R=djsollen@google.com

Review URL: https://codereview.chromium.org/19608005

git-svn-id: http://skia.googlecode.com/svn/trunk@10249 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-22 18:46:45 +00:00
edisonn@google.com
d761e3295c pdfviewer: SkTDict, does accept to pass the length of the key also. We will use it, as this is a prerequirment for optimizing memory usage for pdf parser. 
Review URL: https://codereview.chromium.org/19964003

git-svn-id: http://skia.googlecode.com/svn/trunk@10242 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-22 17:29:43 +00:00
zachr@google.com
35f02fb9c9 ports for mac, ios, android, linux, windows 
R=djsollen@google.com

Review URL: https://codereview.chromium.org/19787006

git-svn-id: http://skia.googlecode.com/svn/trunk@10239 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-22 17:05:24 +00:00
edisonn@google.com
ac03d91ee0 pdfviewer: All NulCanvas (does not draw operations), TrackDevice (trackes what pixels have been changed) 
Review URL: https://codereview.chromium.org/19793006

git-svn-id: http://skia.googlecode.com/svn/trunk@10236 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-22 15:36:39 +00:00
edisonn@google.com
3fc482620e pdfviewer: fix typo (false != NULL) 
Review URL: https://codereview.chromium.org/19543016

git-svn-id: http://skia.googlecode.com/svn/trunk@10235 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-22 15:29:55 +00:00
edisonn@google.com
c93c8ac625 Add --csv parameter to skpdiff to dump all scores in a csv file. We can run it with all skps, and have scores available to look at worst offenders progarmatically. 
R=djsollen@google.com, zachr@google.com

Review URL: https://codereview.chromium.org/19826002

git-svn-id: http://skia.googlecode.com/svn/trunk@10234 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-22 15:24:26 +00:00
zachr@google.com
904f86e6aa Revert "migrate skpdiff to tools" 
This reverts commit 58a7ec70ce6b4548793a2ddc37c63d3d44edbc36.

git-svn-id: http://skia.googlecode.com/svn/trunk@10226 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-22 13:29:20 +00:00
zachr@google.com
a54aaf7fba migrate skpdiff to tools 
R=djsollen@google.com

Review URL: https://codereview.chromium.org/19671002

git-svn-id: http://skia.googlecode.com/svn/trunk@10225 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-22 13:14:04 +00:00
edisonn@google.com
05b7bef01d revert unreviewed 10194, will send to review 
Review URL: https://codereview.chromium.org/19693010

git-svn-id: http://skia.googlecode.com/svn/trunk@10196 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-19 17:47:39 +00:00
edisonn@google.com
9345d94db6 skpdiff: add ability to write the diff scores in a csv file (one line per pair of diff images, with the result of each diff engine) 
Review URL: https://codereview.chromium.org/19786004

git-svn-id: http://skia.googlecode.com/svn/trunk@10194 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-19 17:19:47 +00:00
edisonn@google.com
620edc5039 pdfviewer: fix warning in release 
Review URL: https://codereview.chromium.org/19773002

git-svn-id: http://skia.googlecode.com/svn/trunk@10137 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-18 13:03:03 +00:00
zachr@google.com
d658568a82 make OpenCL optional for skpdiff 
- add CPU based different pixels metric

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19374006

git-svn-id: http://skia.googlecode.com/svn/trunk@10127 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-17 19:29:19 +00:00
epoger@google.com
2aa5757542 in experimental/ : roll back a few expected GM image checksums, for testing 
git-svn-id: http://skia.googlecode.com/svn/trunk@10120 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-16 23:49:46 +00:00
epoger@google.com
1ddb8abb7b experimental/json-expectations: reformat to match output of rebaseline.py 
Created using reformat-json.py script from https://codereview.chromium.org/19289011

Review URL: https://codereview.chromium.org/19289012

git-svn-id: http://skia.googlecode.com/svn/trunk@10116 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-16 20:43:08 +00:00
epoger@google.com
9506226ca7 commit updated JSON expectations to experimental (based on gm-expectations at r10113) 
Review URL: https://codereview.chromium.org/19399003

git-svn-id: http://skia.googlecode.com/svn/trunk@10115 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-16 20:20:04 +00:00
zachr@google.com
92fe073efb add table pregeneration script for pmetric 
R=djsollen@google.com

Review URL: https://codereview.chromium.org/19256002

git-svn-id: http://skia.googlecode.com/svn/trunk@10106 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-16 15:47:07 +00:00
zachr@google.com
a79d40e5ae improve convolve speed of skpdiff using direct pointers 
R=djsollen@google.com

Review URL: https://codereview.chromium.org/19107002

git-svn-id: http://skia.googlecode.com/svn/trunk@10099 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-16 12:57:29 +00:00
edisonn@google.com
78b38b130d pdfviewer: native inline images support 
Review URL: https://codereview.chromium.org/19243003

git-svn-id: http://skia.googlecode.com/svn/trunk@10087 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-15 18:20:58 +00:00
zachr@google.com
1bc995e68c modularize the display of diffs for skpdiff 
R=djsollen@google.com

Review URL: https://codereview.chromium.org/18925004

git-svn-id: http://skia.googlecode.com/svn/trunk@10044 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-12 13:39:53 +00:00
epoger@google.com
c28732b4d0 check JSON-format expectations into experimental/ for manual testing 
Review URL: https://codereview.chromium.org/19052006

git-svn-id: http://skia.googlecode.com/svn/trunk@10016 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-11 17:51:26 +00:00
edisonn@google.com
6a9d436260 pdfviewer: add option to run the load or render multiple times, --benchLoad, --benchRender 
Review URL: https://codereview.chromium.org/18093008

git-svn-id: http://skia.googlecode.com/svn/trunk@10013 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-11 16:25:51 +00:00
edisonn@google.com
444e25a66b add ability to specify the DPI at which to render the page 
Review URL: https://codereview.chromium.org/19000004

git-svn-id: http://skia.googlecode.com/svn/trunk@10009 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-11 15:20:50 +00:00
edisonn@google.com
1310238d82 pdfviewer: render in the same way regadless if we write the result to a file or not. 
Review URL: https://codereview.chromium.org/18503013

git-svn-id: http://skia.googlecode.com/svn/trunk@10008 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-11 14:50:12 +00:00
edisonn@google.com
15b1118203 pdfviewer: some code cleanup in renderer 
Review URL: https://codereview.chromium.org/18093005

git-svn-id: http://skia.googlecode.com/svn/trunk@10006 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-11 14:43:15 +00:00
edisonn@google.com
7b328fddf9 pdfviewer: add --pages arg: render a certain page (all, all in desceding order, firsl, last and by page number) 
Review URL: https://codereview.chromium.org/18584010

git-svn-id: http://skia.googlecode.com/svn/trunk@9999 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-11 12:53:06 +00:00
edisonn@google.com
a5aaa7998f pdfviewer: measure mem usage, command line flags library. 
Review URL: https://codereview.chromium.org/18562010

git-svn-id: http://skia.googlecode.com/svn/trunk@9996 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-11 12:27:21 +00:00
skia.committer@gmail.com
de2e4e8a64 Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@9992 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-11 07:01:01 +00:00
edisonn@google.com
8bad7375d7 pdfviewer: ignore more bad stauff in pdfs 
Review URL: https://codereview.chromium.org/18112023

git-svn-id: http://skia.googlecode.com/svn/trunk@9990 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 23:36:56 +00:00
edisonn@google.com
c8b3037eeb pdfviewer: don't delete variables, they are managed by the doc now 
Review URL: https://codereview.chromium.org/18435010

git-svn-id: http://skia.googlecode.com/svn/trunk@9989 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 23:26:54 +00:00
edisonn@google.com
951d6532de pdfviewer: more load references dinamically plumming 
Review URL: https://codereview.chromium.org/18536014

git-svn-id: http://skia.googlecode.com/svn/trunk@9988 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 23:17:31 +00:00
edisonn@google.com
432640ae0b pdfviewer: don't crash when trailer is missing 
Review URL: https://codereview.chromium.org/19027003

git-svn-id: http://skia.googlecode.com/svn/trunk@9987 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 22:53:40 +00:00
edisonn@google.com
cdad30b35a pdfviewer: fix bug, page -1 means render page 0 with no page extension 
Review URL: https://codereview.chromium.org/18660009

git-svn-id: http://skia.googlecode.com/svn/trunk@9985 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 22:37:38 +00:00
edisonn@google.com
222382b30a pdf viewer: refactor, add -w parameter to pdfviewer, add -n to remove extenassion page when there is a single page (so skdiff can be run easily) and fix a bug (SkPdfobject should not reset on destruct) 
Review URL: https://codereview.chromium.org/18435007

git-svn-id: http://skia.googlecode.com/svn/trunk@9983 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 22:33:10 +00:00
edisonn@google.com
e4dbe21bd9 pdfviewer: remove assert 
Review URL: https://codereview.chromium.org/18518006

git-svn-id: http://skia.googlecode.com/svn/trunk@9971 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 18:38:02 +00:00
edisonn@google.com
a3356fce90 pdfviewer: fix warnings on mac 
Review URL: https://codereview.chromium.org/18293014

git-svn-id: http://skia.googlecode.com/svn/trunk@9970 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 18:20:06 +00:00
edisonn@google.com
596d2e26cd pdf viewer: fix a few warnings, and enable warning as errors 
Review URL: https://codereview.chromium.org/18293012

git-svn-id: http://skia.googlecode.com/svn/trunk@9966 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 17:44:55 +00:00
edisonn@google.com
dfa1ebcf0c RIP podofo 
Review URL: https://codereview.chromium.org/18518005

git-svn-id: http://skia.googlecode.com/svn/trunk@9964 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 17:14:56 +00:00
edisonn@google.com
571c70b95f Native PDF parser implementation - don't try it on pdfs that are not generated by skia, Crome Print Preview or Chrome Save As Pdf - it will crash as mising xref, pdfs with updates, and other features are not supported yer. 
Review URL: https://codereview.chromium.org/18323019

git-svn-id: http://skia.googlecode.com/svn/trunk@9962 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-10 17:09:50 +00:00
zachr@google.com
9432c0c284 add diff viewer website 
- adjust PMetric output to be percentage

R=borenet@google.com, bsalomon@google.com

Review URL: https://codereview.chromium.org/18132007

git-svn-id: http://skia.googlecode.com/svn/trunk@9942 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-09 21:08:28 +00:00
zachr@google.com
a95959c3fb add JSONP option to output of skpdiff 
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18648002

git-svn-id: http://skia.googlecode.com/svn/trunk@9907 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-08 15:04:45 +00:00
skia.committer@gmail.com
98a196770c Sanitizing source files in Housekeeper-Nightly 
git-svn-id: http://skia.googlecode.com/svn/trunk@9882 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-03 07:00:57 +00:00
edisonn@google.com
c631b792c4 pdf viewer: remove const for int scalar types 
Review URL: https://codereview.chromium.org/18103009

git-svn-id: http://skia.googlecode.com/svn/trunk@9881 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-02 23:17:27 +00:00
edisonn@google.com
2e498f105a remove now all the files fro depot for PDF API since we generate them at build time 
Review URL: https://codereview.chromium.org/18404006

git-svn-id: http://skia.googlecode.com/svn/trunk@9880 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-02 23:10:04 +00:00
edisonn@google.com
3aac1f9f30 isolate podofo to prepare for native parser, autogenerate PDF API during build 
Review URL: https://codereview.chromium.org/18042005

git-svn-id: http://skia.googlecode.com/svn/trunk@9879 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-02 22:42:53 +00:00
zachr@google.com
945708ad94 add diff recording and output code 
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18348011

git-svn-id: http://skia.googlecode.com/svn/trunk@9875 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-07-02 19:55:32 +00:00
edisonn@google.com
5d41b36dd5 refactor folders to make prepare for native pdf parser 
Review URL: https://codereview.chromium.org/18179007

git-svn-id: http://skia.googlecode.com/svn/trunk@9825 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-06-28 22:01:06 +00:00
edisonn@google.com
ab03e6816b more work on pdf fonts, more to come 
Review URL: https://codereview.chromium.org/18117005

git-svn-id: http://skia.googlecode.com/svn/trunk@9813 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-06-28 18:51:20 +00:00
zachr@google.com
572b54dd7a add point of interest API 
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18176005

git-svn-id: http://skia.googlecode.com/svn/trunk@9806 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-06-28 16:27:33 +00:00
zachr@google.com
5eef11b293 fix OpenCL memory leak 
R=djsollen@google.com

Review URL: https://codereview.chromium.org/18051004

git-svn-id: http://skia.googlecode.com/svn/trunk@9804 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-06-28 15:37:15 +00:00
zachr@google.com
c0a75a879a add yee's perceptual metric 
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18066004

git-svn-id: http://skia.googlecode.com/svn/trunk@9803 2bbb7eff-a529-9590-31e7-b0007b416f81
 2013-06-28 15:34:56 +00:00