AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
15,431 Commits 1 Branch 0 Tags 544 MiB
7e38d99d03
Commit Graph

1162 Commits

Author SHA1 Message Date
senorblanco
fa4689d563 Re-add suppressions for magnifier and dropshadow GMs. 
Brian's change has invalidated the new baselines, so they'll need
to be rebaselined again once his changed has worked its way through.

TBR=bsalomon
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/686573002
 2014-10-27 14:26:26 -07:00
senorblanco
0fc71ea432 Rebaseline imagemagnifier and dropshadowimagefilter tests. 
BUG=skia:
TBR=hcm@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/685523002
 2014-10-27 14:12:58 -07:00
bsalomon
50a140563c Use approximate scratch textures for image filters. 
Committed: https://skia.googlesource.com/skia/+/96c60686eef6fc514feba6136f1b475f71dbf3ec

Review URL: https://codereview.chromium.org/679113004
 2014-10-27 13:56:20 -07:00
senorblanco
ba036cc82b Fix bounds computation of all 0-input filters. 
The SkRectShaderImageFilter had the same bug as previously fixed for
SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
the implementation, this change makes all filters with 0 inputs return
their source bounds, instead of returning false.

BUG=427251

Review URL: https://codereview.chromium.org/681643003
 2014-10-27 13:38:13 -07:00
jvanverth
d482d297c5 Update perspective GM expectations after disabling some DF paths 
BUG=skia:3066
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/680913003
 2014-10-27 07:58:30 -07:00
jvanverth
87ab518627 Update GM expectations for https://codereview.chromium.org/677463002/ 
BUG=skia:2935
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/677123002
 2014-10-24 12:53:01 -07:00
jvanverth
00c83ddfcb Ignore simpleaaclip_path on Win7-gpu for now. 
BUG=skia:3066
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/646523005
 2014-10-24 09:40:43 -07:00
mtklein
da0de7ed90 rebaseline for new shaderproc 
BUG=skia:

Review URL: https://codereview.chromium.org/674123003
 2014-10-24 08:05:59 -07:00
bsalomon
8dae0f364b Rebaseline lots of images, associate some with bug 3063. 
TBR=
NOTRY=true

Review URL: https://codereview.chromium.org/661323003
 2014-10-24 07:26:01 -07:00
jvanverth
b3eb687f8a Set temporary paths volatile so we don't cache them. 
Any path that is generated frame-to-frame should not be rendered by using the
DistanceFieldPathRenderer, because generating the initial distance field,
uploading it and rendering it takes longer than the SoftwarePathRenderer.

BUG=skia:2935

Review URL: https://codereview.chromium.org/677463002
 2014-10-24 07:12:51 -07:00
mtklein
afc9b6ec95 squelch filterindiabox too 
TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/677463003
 2014-10-23 15:24:11 -07:00
senorblanco
cbf6b6ecd5 Fix imagemagnifier GM quality and speed. 
The imagemagnifier GM was applying the filter both to a saveLayer()
restore() around the whole scene, as well as to each individual
text draw.

Applying the filter only in the saveLayer() makes it run ~20x faster
on my Linux box, and the quality is improved as well (since the
primitives are not double-filtered).

BUG=skia:

Review URL: https://codereview.chromium.org/637283009
 2014-10-23 15:00:12 -07:00
mtklein
14e4d392d4 Revert "Revert of create shaderproc for nofilter-opaque-dx (patchset #7 id:120001 of https://codereview.chromium.org/664783004/)" 
This reverts commit 430b795cc8 and adds suppressions.

BUG=skia:

Review URL: https://codereview.chromium.org/673023002
 2014-10-23 14:35:01 -07:00
bsalomon
efd7d45fc0 Don't use MIP filter mode on compressed textures 
Add compressed texture image downsample GMs

BUG=chromium:426331

Review URL: https://codereview.chromium.org/672863003
 2014-10-23 14:17:46 -07:00
senorblanco
c4d619e145 Remove test expectations from ignored-tests.txt. 
TBR=mtklein@google.com
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/659393006
 2014-10-23 14:01:38 -07:00
sugoi
234f036b3e Adding an option to render only the shadow in SkDropShadowImageFilter 
This is basically how blink uses the filter. Currently, I can't use it for "ShadowOnly" mode with the filter at all, but instead of copying the code and risking to have the codepaths diverge, I'm simply going to add the option here.

BUG=skia:

Review URL: https://codereview.chromium.org/646213004
 2014-10-23 13:59:52 -07:00
senorblanco
d0777fd2cf Rebaselines for tests affected by image filter PDF change. 
(aka https://codereview.chromium.org/644323006/)

TBR=mtklein@google.com
NOTRY=true

BUG=skia:

Review URL: https://codereview.chromium.org/671303003
 2014-10-23 13:50:54 -07:00
joshualitt
70649c174b updating k1 expectations 
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/642543003
 2014-10-23 11:34:08 -07:00
borenet
4f93f3c441 Rename Nexus9 expectations 
BUG=skia:3047
TBR=djsollen

Review URL: https://codereview.chromium.org/652003003
 2014-10-23 08:08:23 -07:00
joshualitt
99db3b1308 some more expectations, update ignores 
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/668393002
 2014-10-22 20:23:08 -07:00
joshualitt
4a38fbd7f2 New baselines 
TBR=

BUG=skia:

Review URL: https://codereview.chromium.org/668823006
 2014-10-22 19:47:37 -07:00
joshualitt
9292fafd4a one more test to ignore 
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/674713002
 2014-10-22 17:52:31 -07:00
joshualitt
5ead6da4ab Oval and stroke AA rect now batch 
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d

Committed: https://skia.googlesource.com/skia/+/18055afb838a278b5a8436cd51dbfbb688e1e0a0

Review URL: https://codereview.chromium.org/664193002
 2014-10-22 16:00:30 -07:00
joshualitt
67f7f74fb2 Revert of Oval and stroke AA rect now batch (patchset #7 id:110001 of https://codereview.chromium.org/664193002/) 
Reason for revert:
whoops, accidental commit

Original issue's description:
> Oval and stroke AA rect now batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d
>
> Committed: https://skia.googlesource.com/skia/+/18055afb838a278b5a8436cd51dbfbb688e1e0a0

TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/675623002
 2014-10-22 15:51:52 -07:00
joshualitt
18055afb83 Oval and stroke AA rect now batch 
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d

Review URL: https://codereview.chromium.org/664193002
 2014-10-22 15:48:48 -07:00
mtklein
9deb696f58 Revert of Oval and stroke AA rect now batch (patchset #7 id:110001 of https://codereview.chromium.org/664193002/) 
Reason for revert:
Many GMs failing, e.g. http://build.chromium.org/p/client.skia.android/builders/Test-Android-Nexus5-Adreno330-Arm7-Release/builds/95/steps/Compare%20GMs/logs/stdio

Original issue's description:
> Oval and stroke AA rect now batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d

TBR=robertphillips@google.com,joshualitt@google.com,bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/671993003
 2014-10-22 15:23:29 -07:00
joshualitt
bc54fab1a4 Oval and stroke AA rect now batch 
BUG=skia:

Review URL: https://codereview.chromium.org/664193002
 2014-10-22 14:41:45 -07:00
joshualitt
02b4725cb8 Ignore failure on internal bot 
BUG=skia:3023
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/640063004
 2014-10-22 07:29:21 -07:00
jvanverth
bf5473b218 Rebaseline dftext GM for new color emoji test. 
BUG=skia:3033
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/671513007
 2014-10-21 07:39:51 -07:00
senorblanco
b0e89dcc1d Fix image filters for PDF backend. 
Currently, the PDF backend does not support image filters (since PDF
does not have that functionality), so it simply removes them. This is
causing Chrome print preview to render incorrectly (see bug). The fix
here is to fall back to a raster device for image filters, as we used
to do in Blink. The resulting bitmap will be drawn to the destination
device as a normal main-memory-backed bitmap.

Note: this change invalidates the PDF results of all GMs containing
image filters (since they'll actually be rendered).

BUG=422144

Review URL: https://codereview.chromium.org/644323006
 2014-10-20 14:03:13 -07:00
bungeman
a4c4a2d8cd Replace SkTypeface::Style with SkFontStyle. 
Committed: https://skia.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20

Review URL: https://codereview.chromium.org/488143002
 2014-10-20 13:33:19 -07:00
jvanverth
fca302ccf4 Add color emoji fallback for distance field text. 
BUG=skia:3033

Review URL: https://codereview.chromium.org/670533002
 2014-10-20 13:12:55 -07:00
Florin Malita
4ce01d606d Rebaseline textblob GM 
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/654303006
 2014-10-16 20:45:49 -04:00
fmalita
19653d1d00 Implicit SkTextBlob bounds 
Compute blob bounds when the client doesn't pass explicit run rects to
the builder. This allows us to remove a couple of internal workarounds.

R=reed@google.com,mtklein@google.com,bungeman@google.com

Review URL: https://codereview.chromium.org/654873003
 2014-10-16 11:53:30 -07:00
jvanverth
aab626c367 Revert of Change drawText() to generate positions and send to drawPosText() (patchset #4 id:60001 of https://codereview.chromium.org/653133004/) 
Reason for revert:
A large number of GMs on Ubuntu12 are failing. The text layout on GPU is visibly different than that for 8888.

Original issue's description:
> Change drawText() to generate positions and send to drawPosText()
>
> The idea here is to have a central place that does layout for drawText(), and
> then always feed text through drawPosText(). This both makes all of the
> GrTextContexts consistent in drawText() output, and does a better job of
> stressing drawPosText().
>
> Because of the effect of matrices on hinting and approximation error, the
> generated text is not 100% identical to that produced by the raster pipeline.
>
> BUG=skia:2778
>
> Committed: https://skia.googlesource.com/skia/+/7851a56895c9c076f73a835a7dd51d3c6180c16f

TBR=cdalton.nvidia@gmail.com,bungeman@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2778

Review URL: https://codereview.chromium.org/659993003
 2014-10-16 08:04:39 -07:00
jvanverth
7851a56895 Change drawText() to generate positions and send to drawPosText() 
The idea here is to have a central place that does layout for drawText(), and
then always feed text through drawPosText(). This both makes all of the
GrTextContexts consistent in drawText() output, and does a better job of
stressing drawPosText().

Because of the effect of matrices on hinting and approximation error, the
generated text is not 100% identical to that produced by the raster pipeline.

BUG=skia:2778

Review URL: https://codereview.chromium.org/653133004
 2014-10-16 06:20:35 -07:00
Brian Salomon
5b9cb06761 Ignore ubuntu nvprmsaa4/mixed_xfermodes GM result. 
BUG=skia:2443

Review URL: https://codereview.chromium.org/653153003
 2014-10-14 16:12:23 -04:00
Brian Salomon
d5da96a814 Rebaseline mixedxfermodes on ubuntu/nvprmsaa4 
TBR=

Review URL: https://codereview.chromium.org/657603005
 2014-10-14 15:52:46 -04:00
borenet
af44e701a5 Fix links to skia-buildbot code in preparation for deletion 
BUG=skia:761

Review URL: https://codereview.chromium.org/655643002
 2014-10-14 04:44:44 -07:00
jvanverth
0880686d95 Enable color emoji GM on Android 
BUG=skia:2887

Review URL: https://codereview.chromium.org/656433002
 2014-10-13 12:48:10 -07:00
jvanverth
75e926a1b1 Update coloremoji expectations 
TBR=reed@google.com
BUG=skia:2887

Review URL: https://codereview.chromium.org/649753003
 2014-10-10 12:58:46 -07:00
jvanverth
294c32612d Fix color emoji. 
Removes the GrMaskFormat and single atlas in GrTextStrike.
Replaces it by storing the GrMaskFormat in each GrGlyph, and
doing a lookup for the correct atlas based on that.

Disables color glyph rendering in GrDistanceFieldTextContext
for now.

BUG=skia:2887

Committed: https://skia.googlesource.com/skia/+/bc92163ddfe957ad6ffbb02ac40e0ba75ff82216

Review URL: https://codereview.chromium.org/636183005
 2014-10-10 11:36:12 -07:00
jvanverth
e817dbb889 Revert of Fix color emoji. (patchset #11 id:320001 of https://codereview.chromium.org/636183005/) 
Reason for revert:
Crashing the Windows bots.

Original issue's description:
> Fix color emoji.
>
> Removes the GrMaskFormat and single atlas in GrTextStrike.
> Replaces it by storing the GrMaskFormat in each GrGlyph, and
> doing a lookup for the correct atlas based on that.
>
> Disables color glyph rendering in GrDistanceFieldTextContext
> for now.
>
> BUG=skia:2887
>
> Committed: https://skia.googlesource.com/skia/+/bc92163ddfe957ad6ffbb02ac40e0ba75ff82216

TBR=robertphillips@google.com,bungeman@google.com,reed@google.com,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2887

Review URL: https://codereview.chromium.org/640413004
 2014-10-10 08:52:03 -07:00
jvanverth
bc92163ddf Fix color emoji. 
Removes the GrMaskFormat and single atlas in GrTextStrike.
Replaces it by storing the GrMaskFormat in each GrGlyph, and
doing a lookup for the correct atlas based on that.

Disables color glyph rendering in GrDistanceFieldTextContext
for now.

BUG=skia:2887

Review URL: https://codereview.chromium.org/636183005
 2014-10-10 08:21:29 -07:00
jvanverth
6cb35fa467 Ignore complexclip_path_aa on Win7-HD2000 for the moment. 
TBR=reed@google.com
BUG=skia:3006

Review URL: https://codereview.chromium.org/643103002
 2014-10-10 07:14:55 -07:00
joshualitt
d8088f846f updating expectations 
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/646963002
 2014-10-10 06:48:48 -07:00
jvanverth
e01844540a Update expectations for distance field path rendering. 
TBR=reed@google.com

Review URL: https://codereview.chromium.org/641203002
 2014-10-09 12:37:36 -07:00
egdaniel
691d6730e0 Rebase Nexus 10 gm failure 
TBR=robertphillips@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/638043002
 2014-10-08 09:38:30 -07:00
bsalomon
b82b9d577e Make GM default to reseting gpu contexts on android. 
TBR=mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/8dd35ce178e4319685a870faf544a0b1d7aef5bb

Review URL: https://codereview.chromium.org/635293003
 2014-10-08 08:17:11 -07:00
derekf
e6efd39a33 Only use msaa target for blur mask when doAA is true 
BUG=skia:2995

Review URL: https://codereview.chromium.org/639523002
 2014-10-07 14:44:34 -07:00
jvanverth
d99741cbbe Update perspective GMs for dfpaths 
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/632363004
 2014-10-07 10:55:43 -07:00
jvanverth
c7c2716a5b Add baselines for dftext GM. 
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/638683002
 2014-10-07 10:23:34 -07:00
robertphillips
c1188aacd5 Added more msaa blurring rebaselines & a suppression 
These are rebaselines for: Create MSAA render target for blur mask texture - https://codereview.chromium.org/616923004

BUG=skia:2995
TBR=bsalomon@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/628813003
 2014-10-07 05:56:24 -07:00
robertphillips
b1b2085569 Rebaseline multipicturedraw_biglayer_* 
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/635813003
 2014-10-07 05:08:12 -07:00
robertphillips
40e01c499e Remove suppressions in ignored-tests.txt 
This should be safe after: Update suppressed baseline images - https://codereview.chromium.org/605973003/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/628013003
 2014-10-07 04:52:16 -07:00
bsalomon
4e8955b772 Rebaseline after msaa blur change 
TBR=robertphillips@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/631993002
 2014-10-06 13:29:22 -07:00
robertphillips
e71d8841ce Update suppressed baseline images 
This updates the non-multipicturedraw GM images suppressed in:
Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/605973003
 2014-10-06 12:54:15 -07:00
robertphillips
3342d1b5a0 Add suppression for multipicturedraw_biglayer GM 
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/631973002
 2014-10-06 12:27:53 -07:00
robertphillips
0cb34b5ab6 Update baseline GM images 
This updates the multipicturedraw_* GM images for:

Reduce overdraw in MultiPictureDraw Sierpinski GM - https://codereview.chromium.org/582633003/
Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/

TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/632703003
 2014-10-06 11:41:04 -07:00
robertphillips
2e5a986bc7 New baselines 
New baseline images for multipicturedraw_biglayer* GMs added in (Add a MultiPictureDraw GM to exercise layer clipping - https://codereview.chromium.org/617723004/).

NOTRY=true
TBR=reed@google.com

Review URL: https://codereview.chromium.org/629293002
 2014-10-06 10:57:14 -07:00
jvanverth
5d271f1581 Update fontcache expectations 
TBR=reed@google.com

Review URL: https://codereview.chromium.org/634623002
 2014-10-06 10:47:59 -07:00
jvanverth
fa38a30897 Add GrAASmallPathRenderer. 
Uses cached signed distance fields to render scaled and rotated versions
of small paths.

BUG=skia:2935

Review URL: https://codereview.chromium.org/589103004
 2014-10-06 05:59:05 -07:00
robertphillips
4611e7f479 Don't turn on dither for saveLayers which have no paint 
Only the gpu, 565 and msaa configs of GMs in ignored-tests.txt need rebaselining.

NOTRY=true

Review URL: https://codereview.chromium.org/619363002
 2014-10-03 06:53:04 -07:00
fmalita
08bd03bc17 Add blobshader GM baselines. 
TBR=robertphillips@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/616853003
 2014-10-02 05:00:29 -07:00
reed
5817f21e0b remove suppression for gm 
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/617193003
 2014-10-01 12:53:53 -07:00
reed
8324a6a27e add baseline for clip_strokerect 
BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/618373002
 2014-10-01 12:41:13 -07:00
reed
39f31c6ed0 baseline new GMs 
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/623443004
 2014-10-01 12:18:40 -07:00
robertphillips
6589dec11e Rebaseline Unknown-Arm64 GM flakes 
These inconsequential changes appeared after (GrResourceCache2 manages scratch texture - https://codereview.chromium.org/608883003) but persisted even after that CL was reverted.

TBR=bsalomon@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/617103005
 2014-10-01 09:47:11 -07:00
fmalita
dbcb5ff125 Add pdf-native textblobshader GM baseline 
BUG=skia:2983
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/615853004
 2014-10-01 09:19:05 -07:00
robertphillips
92656eaaa8 Add buggy GPU baselines for MultiPictureDraw Sierpinski GM (with bug label) 
I am checking in these baseline images even though they are afflicted by a bug (skia:2979).

NOTRY=true
NOTREECHECKS=true
BUG=skia:2979
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/619873003
 2014-10-01 08:04:29 -07:00
Justin Novosad
e946f7115c New baselines for image=surface gm 
TBR=robertphillips@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/623473002
 2014-10-01 10:29:16 -04:00
robertphillips
24e430ff32 Add 8888 & 565 baselines for multipicturedraw Sierpinski GM 
TBR=jvanverth@google.com
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/614353002
 2014-10-01 05:33:25 -07:00
robertphillips
dbe6074a06 Revert of GrResourceCache2 manages scratch texture. (patchset #14 id:260001 of https://codereview.chromium.org/608883003/) 
Reason for revert:
Turning bots red:
Nanobench seems to be uniformly failing on Android
(http://108.170.220.21:10117/builders/Perf-Android-Venue8-PowerVR-x86-Release/builds/99/steps/RunNanobench/logs/stdio)

Ubuntu GTX660 32bit is failing in both Debug and Release on GM generation (it appears to be out of memory) (http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/builds/2457/steps/GenerateGMs/logs/stdio)

Original issue's description:
> GrResourceCache2 manages scratch texture.
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3d398c876440deaab39bbf2a9b881c337e6dc8d4

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/611383003
 2014-09-30 06:54:17 -07:00
bsalomon
3d398c8764 GrResourceCache2 manages scratch texture. 
BUG=skia:
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/608883003
 2014-09-30 06:02:23 -07:00
robertphillips
92f7fc4868 Rebaselining Win7 image failures (textblob, verttext2) 
Rebaselining these for now and see if they recur.

R=borenet@google.com
TBR=borenet@google.com

BUG=skia:2956

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/600533003
 2014-09-29 11:17:58 -07:00
Justin Novosad
cce6bbf494 Adding test suppression for image-surface GM 
Test needs to be rebaselined on gpu

TBR=bsalomon

Review URL: https://codereview.chromium.org/602203006
 2014-09-26 17:41:28 -04:00
cdalton
9959c21dc7 Rebaseline gm expectations after nvpr text change 
BUG=skia:2951
BUG=skia:2954
R=bsalomon@google.com, borenet@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/580943003
 2014-09-22 12:26:41 -07:00
jvanverth
f782639a7c Add ignored expectation for https://codereview.chromium.org/563283004. 
BUG=skia:2951
R=bsalomon@google.com
TBR=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/585943002
 2014-09-19 06:46:09 -07:00
cdalton
855d83ff79 Uses a single pre-baked set of paths for drawing nvpr text of a given 
typeface. Loads the paths using the driver's glyph loading routines.

Refactors GrPathRange to accept a PathGenerator class that it uses to
lazily initialize its paths. The client code is no longer expected to
initialize the paths in a GrPathRange; instead it must provide a
PathGenerator* instance to createPathRange().

Adds a new createGlyphs() method to GrPathRendering that creates a
range of glyph paths, indexed by glyph id. GrPathRendering implements
createGlyphs() with a PathGenerator that loads glyph paths using the
skia frameworks. GrGLPathRendering uses glMemoryGlyphIndexArrayNV()
instead, when possible, to load the glyph paths.

Removes all GlyphPathRange logic from GrStencilAndCoverTextContext.
It instead uses createGlyphs().

BUG=skia:2939
R=bsalomon@google.com, jvanverth@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/563283004
 2014-09-18 13:51:53 -07:00
Florin Malita
8bb9e1e412 Rebaseline textblob GM after acb882c 
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/575893003
 2014-09-17 10:21:48 -04:00
fmalita
acb882c239 Ensure blob typeface information survives SkGPipe serialization. 
When flattening text blobs to the temp buffer, we need to collect
typeface info and ship it across the pipe explicitly.

R=mtklein@google.com, reed@google.com, robertphillips@google.com, bungeman@google.com
BUG=412445

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/563783003
 2014-09-16 17:58:34 -07:00
Mike Klein
a63d5df455 Rebaseline hittestpath and ignore flaky failure on TARUAD 
BUG=skia:2937

Review URL: https://codereview.chromium.org/571963002
 2014-09-15 10:56:59 -04:00
rileya
abaef86f2b Add support for the Rec601 YUV color space to GrYUVtoRGBEffect. 
R=bsalomon@google.com, senorblanco@chromium.org, sugoi@chromium.org, reed@google.com

Author: rileya@chromium.org

Review URL: https://codereview.chromium.org/516463005
 2014-09-12 17:45:58 -07:00
Mike Klein
d0af38793e Expectation file update for bot changes. 
BUG=skia:

Review URL: https://codereview.chromium.org/560873002
 2014-09-10 11:10:48 -04:00
reed
9728a2bf56 correct prev suppression 
TBR=
NOTRY=True

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/543903005
 2014-09-09 19:22:37 -07:00
reed
9a6300a2b0 suppress multipicturedraw_pathclip_tiled_nvprmsaa4 after the conservative-rasterclip cl 
TBR=
NOTRY=True

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/555403002
 2014-09-09 19:08:28 -07:00
bungeman
87a79236f5 Rebaselines for 6bc2c94de3 (fontmgr_iter). 
Rebaselines for "Add font fallback support to SkFontMgr_fontconfig."
 2014-09-09 21:38:04 -04:00
Mike Klein
be20c5a118 rebase a couple oddballs 
BUG=skia:

Review URL: https://codereview.chromium.org/555193004
 2014-09-09 17:52:40 -04:00
Mike Klein
ef53f158de Rebase intel rhb gpu GMs. 
Looks like I accidentally re-enabled GPU mode in GM for Intel RHB.
Rebaseline it so it's green today before we turn it off tomorrow.

BUG=skia:

Review URL: https://codereview.chromium.org/552413002
 2014-09-09 16:00:58 -04:00
bungeman
6bc2c94de3 Add font fallback support to SkFontMgr_fontconfig. 
R=mtklein@google.com, djsollen@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/489733005
 2014-09-09 12:50:36 -07:00
joshualitt
52354b6df7 Updating expectations 
TBR=
BUG=skia:

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/543813003
 2014-09-04 13:52:34 -07:00
joshualitt
bd769d0f1c Initial change to create GeometryProcessor 
BUG=skia:
R=bsalomon@google.com, robertphillips@google.com, egdaniel@google.com, jvanverth@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/509153002
 2014-09-04 08:56:46 -07:00
Mike Klein
227c54e3d4 Finish off some lingering rebaselines. 
BUG=skia:

Review URL: https://codereview.chromium.org/538023002
 2014-09-04 11:08:07 -04:00
Mike Klein
d204a1b039 rebaseline downsamplebitmaps 
BUG=skia:

Review URL: https://codereview.chromium.org/537913003
 2014-09-04 11:03:30 -04:00
Mike Klein
f8b4563e15 remove unused n4 expectations 
BUG=skia:

Review URL: https://codereview.chromium.org/537163002
 2014-09-03 17:39:25 -04:00
Mike Klein
ab799fe66c fix up GM suppressions 
BUG=skia:2911

Review URL: https://codereview.chromium.org/538723002
 2014-09-03 17:02:04 -04:00
mtklein
6a2f5fe867 Turn downsamplebitmap GMs vertical to fit in 2048x2048. 
BUG=skia:2911
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/536103002
 2014-09-03 13:40:52 -07:00
jvanverth
3f5417590a Update fontcache GM to stress the font atlas. 
Pulled out of https://codereview.chromium.org/466363009/.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/534253003
 2014-09-03 08:44:59 -07:00
Derek Sollenberger
2e9176c348 Update failing testimagefilter GM with new baseline and bug number 
Review URL: https://codereview.chromium.org/535843003
 2014-09-03 09:10:20 -04:00
Derek Sollenberger
afbfc2212e Rebase NEON image procs based on C++ implementation. 
BUG=skia:2845

Review URL: https://codereview.chromium.org/532193003
 2014-09-03 09:01:29 -04:00
Derek Sollenberger
c56653cdd2 Update GM baselines for Arm64 bot. 
Review URL: https://codereview.chromium.org/530423003
 2014-09-03 08:31:02 -04:00
egdaniel
7f91c3359f Rebaseline bezier cubics 
TBR=bsalomon@google.com
NOTRY=True

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/528033002
 2014-09-02 12:53:12 -07:00
djsollen
871dca8ea9 Disable NEON procs for box blur as it produces invalid results 
R=reed@google.com, mtklein@google.com, senorblanco@google.com
TBR=reed@google.com
BUG=skia:2845

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/527973002
 2014-09-02 08:57:39 -07:00
djsollen
4d6484e764 Revert of Disable NEON procs for box blur as it produces invalid results (patchset #1 id:1 of https://codereview.chromium.org/520963002/) 
Reason for revert:
failing more GMs than expected.

Original issue's description:
> Disable NEON procs for box blur as it produces invalid results
>
> BUG=skia:2845
>
> Committed: https://skia.googlesource.com/skia/+/4a1764688c990fb926aaeab538497dad52768d99

R=senorblanco@google.com, mtklein@google.com
TBR=mtklein@google.com, senorblanco@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2845

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/531023002
 2014-09-02 06:32:26 -07:00
djsollen
4a1764688c Disable NEON procs for box blur as it produces invalid results 
BUG=skia:2845
R=senorblanco@google.com, mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/520963002
 2014-09-02 05:32:23 -07:00
Mike Klein
6d134201a9 Rebaseline one N4 GM we must have missed. 
BUG=skia:

Review URL: https://codereview.chromium.org/524103002
 2014-08-30 10:33:22 -04:00
Derek Sollenberger
566a22c543 Add baselines for all GMs that are currently labeled "no comparison". 
R=mtklein@google.com

Review URL: https://codereview.chromium.org/519063004
 2014-08-29 15:46:28 -04:00
Greg Humphreys
f2b5f2c2e9 rebaseline and re-enable all perspective tests 
BUG=skia:

Review URL: https://codereview.chromium.org/518253002
 2014-08-29 15:39:03 -04:00
Greg Humphreys
a8cf3bee44 fix names of suppresssed tests on win7 
BUG=skia:

Review URL: https://codereview.chromium.org/524643003
 2014-08-29 15:35:49 -04:00
Greg Humphreys
7ad2f08ba1 partial rebaseline for image scaling 
BUG=skia:

Review URL: https://codereview.chromium.org/520863002
 2014-08-29 15:29:38 -04:00
egdaniel
b2f94d1f4a Use highp for gpu bezier effects 
BUG=skia:2860
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/519473003
 2014-08-29 10:08:36 -07:00
borenet
2269bce9be Rebaseline N10 Recipes bot 
BUG=skia:
R=djsollen@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/522803002
 2014-08-29 09:43:06 -07:00
Derek Sollenberger
2953238dd2 Add Nexus 5 baselines to Android. 
Review URL: https://codereview.chromium.org/519813002
 2014-08-29 12:29:28 -04:00
Derek Sollenberger
e92707916d Massive rebase of Nexus 4 bots. 
Review URL: https://codereview.chromium.org/517183003
 2014-08-29 12:00:09 -04:00
humper
76273bb9ec suppress one more filterbitmap GM 
BUG=skia:
TBR=djsollen

Author: humper@google.com

Review URL: https://codereview.chromium.org/522703002
 2014-08-29 07:45:23 -07:00
humper
7af7a48ed2 more suppressions to handle differences on Win7 bot 
BUG=skia:
TBR=djsollen

Author: humper@google.com

Review URL: https://codereview.chromium.org/518833002
 2014-08-29 07:45:01 -07:00
humper
d73c169637 Second attempt to land the integral image scaling change. 
Scale all images to the nearest rounded integer, and if there's still
any scaling factor left over, pass it on to the subsequent bilerp code.
Should avoid artifacts when tiling scaled images.

Original CL received an LGTM from reed; new version disabled tiling
in the downsamplebitmap GM; I verified that this fixes the issue
we were seeing there on non-neon androids.

BUG=skia:2888
R=reed@android.com
TBR=reed

Author: humper@google.com

Review URL: https://codereview.chromium.org/514383003
 2014-08-28 14:27:42 -07:00
jvanverth
d21a686324 Rebaseline N10 GPU hairmodes. 
This bug appears to be gone.

BUG=skia:1655
TBR=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/515303004
 2014-08-28 12:18:41 -07:00
Derek Sollenberger
4f7c78ef11 Update FontMgr expectations now the Win7 ANGLE bot is back online. 
BUG=skia:2829

Review URL: https://codereview.chromium.org/510383004
 2014-08-28 14:53:43 -04:00
jvanverth
63b9dc8247 Restore text vertex buffer alloc and other optimizations. 
Modifies the fontcache GM to ensure that the font cache is forced to flush.

Committed: https://skia.googlesource.com/skia/+/9c3d24b9d1ba3d955094ff0cb1ba2d11e1c1adca

R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/466363009
 2014-08-28 10:39:40 -07:00
humper
60cc7d353b manual revert of bitmap scale change while I investigate failures 
on chromeos

TBR=reed
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/516923003
 2014-08-28 09:54:41 -07:00
bungeman
7e7136f47d Update baselines for the fontMgr GMs. 
BUG=skia:2829
 2014-08-28 12:34:28 -04:00
Derek Sollenberger
da0b7a6a52 Update expectations for FontMgr that were missed in previous runs 
BUG=skia:2829

Review URL: https://codereview.chromium.org/516533003
 2014-08-27 17:02:18 -04:00
djsollen
2e1a82675c Revert of Restore text alloc optimizations. (patchset #4 of https://codereview.chromium.org/466363009/) 
Reason for revert:
GM failures on http://108.170.220.120:10115/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/1867/

Original issue's description:
> Restore text vertex buffer alloc and other optimizations.
>
> Modifies the fontcache GM to ensure that the font cache is forced to flush.
>
> Committed: https://skia.googlesource.com/skia/+/9c3d24b9d1ba3d955094ff0cb1ba2d11e1c1adca

R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com
TBR=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/510103003
 2014-08-27 13:12:25 -07:00
Derek Sollenberger
9694d63cf0 Update fontMgr expectations for Mac/Linux/Windows 
BUG=skia:2829

Review URL: https://codereview.chromium.org/514913002
 2014-08-27 15:50:03 -04:00
jvanverth
9c3d24b9d1 Restore text vertex buffer alloc and other optimizations. 
Modifies the fontcache GM to ensure that the font cache is forced to flush.

R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/466363009
 2014-08-27 11:53:17 -07:00
Derek Sollenberger
31067ddfdd Update GPU baselines for the fontMgr GMs. 
BUG=skia:2829

Review URL: https://codereview.chromium.org/511973002
 2014-08-27 14:48:09 -04:00
Derek Sollenberger
f0393f035b Update non-GPU baselines for the fontMgr GMs. 
BUG=skia:2829

Review URL: https://codereview.chromium.org/515473003
 2014-08-27 14:38:45 -04:00
humper
ce7b1d5fad always scale to an integer; compensate for fractional image sizes by leaving the fractional scale in the matrix 
BUG=skia:
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/470233002
 2014-08-27 07:56:49 -07:00
Derek Sollenberger
390f62479a Ignore font_mgr gms until we can rebase them 
BUG=skia:2829
R=mtklein@google.com

Review URL: https://codereview.chromium.org/513813002
 2014-08-27 10:45:37 -04:00
Florin Malita
0b14aa80dd Add text blob gm baselines. 
Review URL: https://codereview.chromium.org/504203002
 2014-08-26 11:17:02 -04:00
bungeman
bc818f513b Rebaselines for a6785ccb54 (Add a working SkFontMgr_fontconfig.) 2014-08-25 17:18:53 -04:00
bungeman
a8b53b547f Rebaselines for a6785ccb54 (Add a working SkFontMgr_fontconfig.) 2014-08-25 15:47:55 -04:00
Mike Klein
b2a16919d9 gradtext also needed rebaselining from the gamma change 
BUG=skia:

Review URL: https://codereview.chromium.org/501113002
 2014-08-25 13:50:29 -04:00
Mike Klein
708f154d7e Rebaseline 565 precision changes and matrixconvolution. 
BUG=skia:2797

Review URL: https://codereview.chromium.org/504873002
 2014-08-25 13:14:16 -04:00
Mike Klein
3e42a46385 suppress matrixconvolution 
BUG=skia:

Review URL: https://codereview.chromium.org/476283003
 2014-08-22 13:09:02 -04:00
fmalita
37ecbaffd1 [SkTextBlob] Merge run font data at draw time. 
R=bungeman@google.com, reed@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/496773002
 2014-08-22 09:01:20 -07:00
Mike Klein
4d88bf547f Some early 565 rebaselines. 
BUG=skia:2797

Review URL: https://codereview.chromium.org/488453003
 2014-08-22 11:23:18 -04:00
Mike Klein
6f1cd27536 Ignore GMs that will need 565 rebaselines. 
BUG=skia:

Review URL: https://codereview.chromium.org/483883004
 2014-08-22 10:16:03 -04:00
caryclark
fe9384910d add tool generated whitespace 
the rebaseline tool adds whitespace at the end of lines in the json file.
While harmless, git flags this as something worth fixing. Fixing it causes
the rebaseline tool to generate a new difference with the whitespace.

Checking the whitespace back in to avoid future back-and-forth.

TBR=
NOTRY=true
NOTREECHECKS=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/494363002
 2014-08-22 04:55:14 -07:00
caryclark
accce6ed75 fix remaining arm64 expectations 
R=halcanary@google.com
TBR=halcanary@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:2845

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/496253004
 2014-08-22 04:48:13 -07:00
caryclark
78fc1dbed0 update expectations for Nexus 10 Debug 
NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2860

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/492303003
 2014-08-21 12:37:55 -07:00
halcanary
c2d04e1bb8 temporary rebaseline on arm64 
Affects all blur tests.

BUG=skia:2845
NOTRY=true
R=caryclark@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/495093002
 2014-08-21 09:03:50 -07:00
caryclark
5d74806b47 update gm expectations for Nexus 10 
the Android version was updated, introducing a new GPU driver

NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2860

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/496733002
 2014-08-21 07:43:43 -07:00
caryclark
74206bc489 ignore flaky failure on android 
this failed to commit the first time

NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/488273002
 2014-08-20 14:01:28 -07:00
caryclark
367d03fb5a ignore release as well 
This GM is flaky as Brian expected on both Release and Debug,
so suppress the Release expectation as well.

NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2826

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/489083002
 2014-08-20 06:34:15 -07:00
caryclark
de218041b9 add patch grid update for 64 bit arm 
TBR=
NOTREECHECKS=true
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/463353003
 2014-08-19 05:28:23 -07:00
borenet
81d92659cf Copy N10 GM expectations for recipe bot 
BUG=skia:761
R=epoger@google.com, rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/481963002
 2014-08-18 08:50:43 -07:00
borenet
de512d9a6c Rebaseline astcbitmap and etc1bitmap on Recipes bot 
BUG=skia:761
NOTREECHECKS=true
R=robertphillips@google.com, bsalomon@google.com, krajcevski@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/481883003
 2014-08-18 06:50:33 -07:00
Brian Salomon
f878e3cb3c Rebaseline and remove tests from ignored-tests.txt 
BUG=skia:

Review URL: https://codereview.chromium.org/475013002
 2014-08-14 13:51:16 -04:00
krajcevski
e1c78ae553 Rebaseline R11 and ASTC bitmap GMs 
TBR=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/471723002
 2014-08-14 07:24:53 -07:00
Brian Salomon
81ecaa2e4c Fix typo in ignored-tests.txt 
BUG=skia:

Review URL: https://codereview.chromium.org/475583002
 2014-08-13 18:31:03 -04:00
mtklein
3140576f2f Baseline Android-Reference-Unknown-Arm64 
BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/474563002
 2014-08-13 11:59:53 -07:00
Brian Salomon
f411ee7178 git cl land# Enter a description of the change. 
Even more tests to ignored-tests for gpu rect changes

BUG=skia:

Review URL: https://codereview.chromium.org/468223003
 2014-08-13 13:37:45 -04:00
joshualitt
97a0d43771 Updating expectations for matrix convolution 
R=bsalomon@chromium.org
BUG=skia:

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/464913003
 2014-08-13 10:31:04 -07:00
epoger
785246ee38 add expectations for Test-Android-Reference-Unknown-Arm64-{Debug,Release} 
BUG=skia:2828
NOTREECHECKS=true
NOTRY=true
R=mtklein@google.com
TBR=mtklein

Author: epoger@google.com

Review URL: https://codereview.chromium.org/468243002
 2014-08-13 09:36:46 -07:00
Brian Salomon
a9424995ac Add additional tests to ignored-tests 
BUG=skia:

Review URL: https://codereview.chromium.org/463993003
 2014-08-13 12:08:01 -04:00
bsalomon
c30aaa0e40 Use combined color/coverage attribute when possible in aa rect renderer. 
Also restore the is_irect test to detect AA rects that are integer aligned.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/466873002
 2014-08-13 07:15:30 -07:00
Brian Salomon
b0c855146d Mark degeneratesegments GM as flakly on nvpr/ubuntu/debug 
BUG=skia:2826

Review URL: https://codereview.chromium.org/456653005
 2014-08-12 11:19:54 -04:00
Brian Salomon
0a82f5be21 Rebaseline current failures and those ignored for GPU rect change. 
BUG=skia:

Review URL: https://codereview.chromium.org/460343003
 2014-08-12 11:10:35 -04:00
joshualitt
5acfea789d 2D kernel initial wiring for Guassian 
BUG=skia:
R=senorblanco@chromium.org, bsalomon@chromium.org, bsalomon@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/418223009
 2014-08-11 13:55:34 -07:00
Brian Salomon
4596c98908 Mark convex_poly_clip as flaky on msaa16/win8 bots. Add more tests to ignored_tests.txt after GPU rect change. 
BUG=skia:

Review URL: https://codereview.chromium.org/460023002
 2014-08-11 15:36:43 -04:00
bsalomon
9c0822a415 Always use both a color and coverage attribute in GrAARectRenderer. 
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/435743002
 2014-08-11 11:07:48 -07:00
Brian Salomon
6dff71f44b Remove bleed test from ignored-tests.txt 
BUG=skia:

Review URL: https://codereview.chromium.org/463503004
 2014-08-11 11:21:25 -04:00
Brian Salomon
136aa8fb7e Rebase convex_poly_clip test on Win8 msaa16 
BUG=skia:

Review URL: https://codereview.chromium.org/458243002
 2014-08-11 10:22:10 -04:00
borenet
0898e2b420 Empty the Recipes bot's GM expectations 
BUG=skia:761
NOTRY=true
R=epoger@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/455433002
 2014-08-07 13:02:43 -07:00
borenet
c3cbc1dc0e Duplicate NoGPU expectations for new recipes bot 
BUG=skia:761
R=epoger@google.com
TBR=epoger
NOTRY=true

Author: borenet@google.com

Review URL: https://codereview.chromium.org/447323003
 2014-08-07 11:28:21 -07:00
bsalomon
0673676854 Don't compare coord change matrices to determine effect compatibility when using explicit local coords. 
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/438053002
 2014-08-04 10:56:40 -07:00
bungeman
c6f5784047 No longer ignore and rebaseline fontmgr gms. 2014-08-01 15:02:36 -04:00
joshualitt
0e67808da7 Enabling texture_domain_effect 
BUG=skia:
REVIEW=tbr
R=rmistry@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/425253003
 2014-07-30 10:31:10 -07:00
Brian Salomon
00683c7b9a Mark bleed GM images on GPU configs as baselined but associated with bug 2762 
BUG=skia:2762

Review URL: https://codereview.chromium.org/431453006
 2014-07-30 10:08:09 -04:00
Brian Salomon
5520e3be26 Rebaseline some images from ignored-tests.txt 
BUG=skia:

Review URL: https://codereview.chromium.org/431583004
 2014-07-30 09:40:56 -04:00
Brian Salomon
b174f2b3cc Rebaseline currently failing images. All look better or insignificantly different 
Review URL: https://codereview.chromium.org/423283005
 2014-07-30 09:27:19 -04:00
joshualitt
5ae5fc59b2 Adding repeat mode to texture domain 
BUG=skia:
R=bsalomon@chromium.org, senorblanco@chromium.org, bsalomon@google.com, junov@chromium.org

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/422123003
 2014-07-29 12:59:27 -07:00
cdalton
15ab26d942 Rebaseline needed nvpr gms after text change 
Updates a few nvpr expectations for slight pixel diffs after a change
in the math that positions glyphs.

BUG=skia:
R=jvanverth@google.com, bungeman@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/421423002
 2014-07-28 15:39:06 -07:00
cdalton
b2808cd041 Send less transform data when drawing text with nvpr 
Before this change, GrStencilAndCoverTextContext would send 6-float
affine transforms to drawPaths for every glyph. This updates it to
concat the text scale onto the context matrix, and then only send
2-float translates (or 1-float x-translates when possible).

Also adds a glyph_pos_align test to gm that exercises the newly added
codepaths, and starts ignoring a few gm tests with benign pixel diffs
until we can rebaseline.

BUG=skia:
R=bsalomon@google.com, kkinnunen@nvidia.com, jvanverth@google.com, bungeman@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/406523003
 2014-07-25 14:13:57 -07:00
Brian Salomon
0925a5784c Add initial baselines for varied_text* GMs 
Review URL: https://codereview.chromium.org/416983002
 2014-07-24 17:23:44 -04:00
robertphillips
a2c79fb412 Suppress Win8 raster verylargebitmap GM flakes 
BUG=skia:2775

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
NOTREECHECKS=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/418863003
 2014-07-24 05:30:39 -07:00
robertphillips
ba0055b290 Revert "Update fontmgr expectations." 
This reverts commit ff4b56b2d5.

R=bungeman@gmail.com
TBR=bungeman@gmail.com
NOTRY=true
NOTREECHECKS=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/406323004
 2014-07-22 16:34:38 -07:00
bungeman
ff4b56b2d5 Update fontmgr expectations. 2014-07-22 18:21:24 -04:00
bungeman
33d134656e Suppress fontmgr gm changes while Android catches up. 2014-07-22 16:02:58 -04:00
egdaniel
f7caacdbb7 Rebaseline from recent gpu optimization changes 
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/408203002
 2014-07-22 06:46:45 -07:00
egdaniel
02cafcc1bf Remove gpu shader optimatization for solid white or trans black colors 
Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths.

With optimization in (ms):
         White       Blue        Checkered
Linux    ~80         ~80         ~160
N7       ~800        ~1100       ~1500
Moto-e   ~830        ~1100       ~2500

Without optimization in (ms):
         White       Blue        Checkered
Linux    ~80         ~80         ~80
N7       ~1100       ~1100       ~1100
Moto-e   ~1100       ~1100       ~1500

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5f78d2251a440443c9eaa321dad058d7a32bfef7

R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/375823005
 2014-07-21 11:37:28 -07:00
Mike Klein
dddf564ee7 rebaseline most dw changes 
BUG=skia:

Review URL: https://codereview.chromium.org/402443002
 2014-07-16 16:20:12 -04:00
senorblanco
b02ab4b47b New Mac 10.6 x86_64 Debug baselines for perlin noise tests. 
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/384043002
 2014-07-11 10:09:02 -07:00
senorblanco
3031a2f1df Yet more perlin noise rebaselines. 
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/385733003
 2014-07-10 13:02:30 -07:00
senorblanco
bb02bb5ab1 You guessed it -- more perlin noise rebaselines. 
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/386693002
 2014-07-10 12:42:01 -07:00
senorblanco
250b59dd49 Ibid. 
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/381223002
 2014-07-10 12:01:29 -07:00
senorblanco
0c4a70d6e9 Yet more perlin noise rebaselines. 
(Apparently my rebaseline_server skills leave something to be desired.)

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/384863002
 2014-07-10 11:57:26 -07:00
senorblanco
626650f62f Some more perlinnoise rebaselines. 
R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/381973002
 2014-07-10 11:29:20 -07:00
senorblanco
3a3eef4a63 New baselines for perlin noise changes. 
Pixel results affected by ca6a7c2945

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/385643003
 2014-07-10 10:52:21 -07:00
robertphillips
e6b28cf25b Remove shadows suppression 
The 'shadows' GM isn't appearing on the "Recent GM Failures" page. It might have been a blip.

R=jcgregorio@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/387533002
 2014-07-10 07:57:16 -07:00
robertphillips
5fe23b357a Add suppression for shadows test 
R=jvanverth@google.com
TBR=jcgregorio@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/377403004
 2014-07-09 14:24:00 -07:00
jvanverth
2d9d9c9ded Update one last expectation from gamma change. 
R=bungeman@google.com
TBR=bungeman@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/380823002
 2014-07-09 11:12:06 -07:00
jvanverth
085f334c47 Update remaining expectations for https://codereview.chromium.org/337603008. 
TBR=bungeman@chromium.org

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/371003004
 2014-07-07 08:44:46 -07:00
egdaniel
705a1535a3 Rebaseline Angle gms for recent dashing4 rebaseline 
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/378513004
 2014-07-07 07:27:37 -07:00
egdaniel
8119e6a85d Rebaseline for gpu dashing4 now doing circle dashes 
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/374623003
 2014-07-07 06:28:44 -07:00
jvanverth
c6bbd82210 Ignore some GM images for https://codereview.chromium.org/337603008. 
R=bungeman@google.com
TBR=bungeman@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/361333002
 2014-07-02 15:54:24 -07:00
jvanverth
23ff2a5d46 More expectation updates for https://codereview.chromium.org/337603008. 
R=bungeman@google.com
TBR=bungeman@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/368073002
 2014-07-02 14:15:37 -07:00
mtklein
217daa7ec5 Revert of Remove the AA requirement for selecting GrEffect-based clipping. (https://codereview.chromium.org/367013003/) 
Reason for revert:
We think this is breaking the roll.

Original issue's description:
> Remove the AA requirement for selecting GrEffect-based clipping.
>
> Also, optionally use the scissor for a bw clip rect element instead of an effect.
>
> Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11
>
> Committed: https://skia.googlesource.com/skia/+/e9a729cb4d3f05b9c750dc1f63a9cc65b5659f04

R=robertphillips@google.com, bsalomon@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/361313002
 2014-07-02 12:55:21 -07:00
bsalomon
e9a729cb4d Remove the AA requirement for selecting GrEffect-based clipping. 
Also, optionally use the scissor for a bw clip rect element instead of an effect.

Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/367013003
 2014-07-02 11:42:29 -07:00
jvanverth
5c76a0f1d1 Update some expectations for https://codereview.chromium.org/337603008. 
R=bungeman@google.com
TBR=bungeman@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/362373002
 2014-07-02 11:33:07 -07:00
bsalomon
e1593862fe Revert of Remove the AA requirement for selecting GrEffect-based clipping. (https://codereview.chromium.org/367013003/) 
Reason for revert:
Assertion failing.

Original issue's description:
> Remove the AA requirement for selecting GrEffect-based clipping.
>
> Also, optionally use the scissor for a bw clip rect element instead of an effect.
>
> Committed: https://skia.googlesource.com/skia/+/a73218bbbdcbe458651d10815e8d3b73d71b8e11

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/369613002
 2014-07-02 11:11:30 -07:00
bsalomon
a73218bbbd Remove the AA requirement for selecting GrEffect-based clipping. 
Also, optionally use the scissor for a bw clip rect element instead of an effect.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/367013003
 2014-07-02 10:40:52 -07:00
egdaniel
f767e792b9 Add the ability for gpu to render dotted lines (dashed line, 0 on interval, round caps) 
BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/345113003
 2014-07-02 06:21:34 -07:00
jvanverth
dc1cf66483 Remove A8_LCD luminance hack. 
It no longer appears to be necessary, and the powf function is slowing down
Android text rendering.

R=bungeman@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/337603008
 2014-07-01 13:43:00 -07:00
Ben Wagner
529b7f6d62 Expectations updates for DirectWrite change 761b25. 2014-06-30 16:18:24 -04:00
reed
4eec156659 rebaseline srcmode for gpus -- now pass samplecount 
TBR=
NOTRY=True
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/357393002
 2014-06-30 10:59:48 -07:00
senorblanco
d4fa483504 Some straggler rebaselines for imagefiltersclipped. 
NOTRY=true
NOTREECHECKS=true
R=rmistry@google.com
TBR=rmistry
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/348313006
 2014-06-27 16:20:03 -07:00
senorblanco
d297d0f2c2 New baselines for imagefiltersclipped GM after perlin noise change. 
R=rmistry@google.com
TBR=rmistry
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/361523003
 2014-06-27 14:45:30 -07:00
senorblanco
ca6a7c2945 Make perlin noise do CTM-correct scaling. 
When drawing perlin noise, generate noise at the resolution determined
by CTM, not by the resolution at construction time. This required moving
the generation of PaintingData to getContext() and asNewEffect() for the
raster and GPU paths, respectively.

It also required adjusting the matrices used during rendering
to be translate-only.

R=sugoi@chromium.org, bsalomon@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/358903002
 2014-06-27 13:35:52 -07:00
rmistry
8ba8d923da Rebaseline Test-Android-Logan-Nvidia-Arm7-* 
Reviewed both by mtklein and bsalomon in skia:2695.

TBR=
BUG=skia:2695
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/352353004
 2014-06-26 11:35:33 -07:00
senorblanco
7bf1068473 Remove SkBicubicImageFilter, and all related tests. 
Now that we have SkResizeImageFilter, and the bicubic
resizing is part of skia proper, there's no need for a
specialized image filter.

BUG=skia:
R=bsalomon@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/357793002
 2014-06-25 14:39:06 -07:00
Mike Klein
85a08789c0 Rebase Test-Ubuntu12-ShuttleA-GTX660-x86-Release. 
BUG=skia:2575

Review URL: https://codereview.chromium.org/353883002
 2014-06-25 13:21:56 -04:00
kkinnunen
55106da359 Ignore degeneratesegments for nvprmsaa4 to unbreak the build 
Ignore degeneratesegments for nvprmsaa4 to unbreak the build. The result image
seems to be inconsistent with different Linux GTX660 builds. Ignore the test for
Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release.

BUG=skia:2689
R=rmistry@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/345423006
 2014-06-25 04:30:38 -07:00
Brian Salomon
20fa0c3238 rebase GMs 
BUG=skia:

Review URL: https://codereview.chromium.org/351973003
 2014-06-24 18:08:09 -04:00
kkinnunen
68dd81bde9 Rebaseline gm results after "Implement text rendering with NVPR" 
Rebaseline gm results after "Implement text rendering with NVPR".  The text is
rasterized by NV_path_rendering extension, so pixels are expected to be a bit
different.

NOTRY=true
R=rmistry@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/346413002
 2014-06-24 04:45:58 -07:00
rmistry
798496c66f Rebaseline shadertext2_{gpu,8888} after SkPaint::measureText changes 
These two GMs were missing from https://codereview.chromium.org/347393002/.

This CL is to fix http://108.170.220.121:10117/static/view.html#/view.html?resultsToLoad=%2Fresults%2Ffailures&displayLimitPending=50&showThumbnailsPending&mergeIdenticalRowsPending&imageSizePending=100&sortColumnSubdict=differenceData&sortColumnKey=perceptualDifference&hiddenResultTypes=failure-ignored,no-comparison,succeeded&hiddenConfigs=&builder=Test-Win7-ShuttleA-HD2000-x86-Release&test=

BUG=skia:
R=kkinnunen@nvidia.com, jvanverth@google.com, mtklein@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/333193003
 2014-06-23 10:32:29 -07:00
robertphillips
c8fd7b58c5 Remove suppression of distantclip image differences 
R=rmistry@google.com, rmistry@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/349233004
 2014-06-23 09:01:52 -07:00
kkinnunen
0156c7646c Rebaseline shadertext2 after SkPaint::measureText changes 
Rebaseline shadertext2 after commit "Fix SkPaint::measureText for stroked
hairline text".

Unignore ignored shadertext2 for Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug
pdf-poppler.

The label "Filled" in the test moves to the left due to the changes in the
measurement. The SkPaint::measureText will use the "use paths" code path,
similar to the drawing code. This results in different length for the string
"Filled".

As a side-note, the test probably measures either wrong text or uses wrong
paint. This can be fixed separately.

NOTREECHECKS=true
NOTRY=true
R=jvanverth@google.com, mtklein@google.com, rmistry@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/347393002
 2014-06-23 06:59:46 -07:00
rmistry
c4b84aef1a Revert of Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/354433002/) 
Reason for revert:
Rebaseline CL is ready to be submitted

Original issue's description:
> Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/335603003/)
>
> Reason for revert:
> Caused many shadertext GM failures
>
> Original issue's description:
> > Fix SkPaint::measureText for stroked hairline text
> >
> > SkPaint::measureText and text drawing used different criteria for
> > determining whether text should be drawn as paths or not.
> >
> > Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
> > positioning in the rendering. Mainly added in order to define what is the
> > expected text rendering when hairline stroke is used with various transform
> > options.
> >
> > The testcase also tries to note or highlight the fact that SkPaint::measureText
> > is not expected to produce intuitively matching results when compared to a
> > rendering, if the rendering is done so that the device ends up having a device
> > transform.
> >
> > This fixes the glyph_pos_h_s (hairline, stroked) test-case.
> >
> > Ignore shadertext2_pdf-poppler.png gm on
> > Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
> >
> > Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793
>
> TBR=jvanverth@google.com,reed@google.com,kkinnunen@nvidia.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/abc9bb55ddfeb4b1a7acc335a34841fddcd22d27

R=jvanverth@google.com, reed@google.com, kkinnunen@nvidia.com
TBR=jvanverth@google.com, kkinnunen@nvidia.com, reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/349153005
 2014-06-23 06:59:15 -07:00
rmistry
abc9bb55dd Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/335603003/) 
Reason for revert:
Caused many shadertext GM failures

Original issue's description:
> Fix SkPaint::measureText for stroked hairline text
>
> SkPaint::measureText and text drawing used different criteria for
> determining whether text should be drawn as paths or not.
>
> Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
> positioning in the rendering. Mainly added in order to define what is the
> expected text rendering when hairline stroke is used with various transform
> options.
>
> The testcase also tries to note or highlight the fact that SkPaint::measureText
> is not expected to produce intuitively matching results when compared to a
> rendering, if the rendering is done so that the device ends up having a device
> transform.
>
> This fixes the glyph_pos_h_s (hairline, stroked) test-case.
>
> Ignore shadertext2_pdf-poppler.png gm on
> Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
>
> Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793

R=jvanverth@google.com, reed@google.com, kkinnunen@nvidia.com
TBR=jvanverth@google.com, kkinnunen@nvidia.com, reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/354433002
 2014-06-23 05:39:26 -07:00
kkinnunen
196af73802 Fix SkPaint::measureText for stroked hairline text 
SkPaint::measureText and text drawing used different criteria for
determining whether text should be drawn as paths or not.

Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
positioning in the rendering. Mainly added in order to define what is the
expected text rendering when hairline stroke is used with various transform
options.

The testcase also tries to note or highlight the fact that SkPaint::measureText
is not expected to produce intuitively matching results when compared to a
rendering, if the rendering is done so that the device ends up having a device
transform.

This fixes the glyph_pos_h_s (hairline, stroked) test-case.

Ignore shadertext2_pdf-poppler.png gm on
Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.

R=jvanverth@google.com, reed@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/335603003
 2014-06-22 22:18:14 -07:00
krajcevski
61843107f6 Rebaseline clip on Win7 ShuttleA HD2000 
BUG=skia:
R=bsalomon@google.com
TBR=bsalomon@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/342403002
 2014-06-20 13:07:15 -07:00
Ben Wagner
909f91dc4c Rebaselines for DirectWrite non-rounding. 
Review URL: https://codereview.chromium.org/337923004
 2014-06-20 14:41:35 -04:00
krajcevski
bbf93efdd0 Restore bug numbers 
BUG=skia:
R=bsalomon@google.com
TBR=bsalomon@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/341313002
 2014-06-20 11:39:27 -07:00
krajcevski
912d809a85 Rebaseline after dithering change 
TBR=bsalomon@google.com
BUG=skia:

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/347103003
 2014-06-20 09:02:16 -07:00
egdaniel
6b8f1ba1ef Rebaseline win7-HD2000 for flaky dashing4 gm 
R=bsalomon@google.com
TBR=bsalomon@google.com

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/344853005
 2014-06-20 06:33:05 -07:00
krajcevski
f461a8fdf6 Simple GPU based dithering: 
If dithering is turned on, apply an effect that filters the pixel through
the following pipeline:

for each channel c:
  1. Compute quantized colors [low, high] that c is between
  2. Pick high by flipping a coin weighted by (c - low)

R=bsalomon@google.com, egdaniel@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/321253002
 2014-06-19 14:14:06 -07:00
senorblanco
373dd9b52f New Nexus4 baselines for imagefiltersclipped, GPU path. 
R=reed@google.com
TBR=reed@google.com
NOTRY=True
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/347693002
 2014-06-18 16:26:39 -07:00
egdaniel
de10fdeee5 Add additional dashing rebaselines 
NOTRY=True
NOTREECHECK=True
R=bsalomon@google.com
TBR=bsalomon@google.com

BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/347543003
 2014-06-18 07:31:08 -07:00
egdaniel
00fb42704a Rebaslines from recent dashing changes 
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/339203003
 2014-06-18 06:56:19 -07:00
reed
1777f233bd unignore canvas-layer-state 
TBR=
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/336273005
 2014-06-18 05:47:45 -07:00
Ben Wagner
60741912fd Rebaseline ANGLE bots. 2014-06-17 18:39:09 -04:00
humper
4a24cd8ff4 Fifth attempt to land faster rect blur. Remove unnecessary conditionals from the shader. 
approved over in https://codereview.chromium.org/331863006/; reuploading
because it had the wrong base url

BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon

Author: humper@google.com

Review URL: https://codereview.chromium.org/341543005
 2014-06-17 13:39:31 -07:00
Ben Wagner
9323b01e90 Update Windows baselines due to VS2013 update. 
Floating point operations now differ in the low bits from before.
 2014-06-17 16:28:20 -04:00
reed
0992d0764b rebaseline after changing labels in bitmapfilters 
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/340583004
 2014-06-17 12:31:49 -07:00
dandov
baa860c297 * Removed bitmapshaders from expectations/gm/ignored-tests.txt. 
* Rebaseline bitmapshaders, gpu didn't produce the same images when using only alpha bitmaps
	because it didn't consider the skpaint's color.

BUG=skia:2293
R=jvanverth@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/339923004
 2014-06-17 11:21:46 -07:00
reed
057ef35280 rebaseline after GM change to bitmapfilters 
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/341593003
 2014-06-17 10:32:31 -07:00
reed
12d4aa69b5 ignore bitmapfilters failures until we can rebaseline 
TBR=
NOTRY=True
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/339153004
 2014-06-17 10:28:08 -07:00
kevin.petit
cf2187267b Armv8/64bit doesn't (apparently) need rebaselining 
BUG=skia:
R=reed@google.com
NOTRY=True

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/334743009
 2014-06-16 10:05:41 -07:00
senorblanco
9a8699f45c New baselines for perlin noise tests affected by ce6a35. 
New baselines for perlinnoise, imagefiltersclipped and
imagefiltersscaled GMs.

R=scroggo@google.com
TBR=scroggo
NOTRY=true

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/336703002
 2014-06-12 14:31:57 -07:00
reed
2526f0e5fd rebaselines for removal of unitmapper 
TBR=
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/330513005
 2014-06-12 12:53:01 -07:00
Stephen White
1b5e04ec5f Add more tests to ignore-tests.txt. 
Add imagefiltersclipped and imagefiltersscaled to ignored-tests.txt
until they can be rebaselined, since they're failing on Android after
https://codereview.chromium.org/332523006/.

TBR=scroggo
BUG=skia:

Review URL: https://codereview.chromium.org/336663002
 2014-06-12 15:51:46 -04:00
scroggo
e07c1ab408 Revert of third try at landing improved blur rect; this time with more correctness (https://codereview.chromium.org/331443003/) 
Reason for revert:
Failing layout test: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/32762/layout-test-results/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-pretty-diff.html

Original issue's description:
> third try at landing improved blur rect; this time with more correctness
>
> BUG=skia:2095
> R=bsalomon@google.com
> TBR=bsalomon
>
> Committed: https://skia.googlesource.com/skia/+/72abfc2b4e7caead660f6b6a05e60d05eaf1a66f

R=bsalomon@google.com, reed@google.com, humper@google.com
TBR=bsalomon@google.com, humper@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2095

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/333763002
 2014-06-12 12:10:24 -07:00
egdaniel
8b6fee1eb9 Add another fail-ignore for flaky dashing4 gm 
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/329223007
 2014-06-12 11:58:16 -07:00
senorblanco
ce6a354e12 Fix tiled perlin noise. 
It turns out that the perlin implementation we inherited from WebKit
does not actually generate tileable noise (see Chromium bug
http://crbug.com/383495).

The main problem is that when generating coordinates for gradient
interpolation, it was attempting to wrap both x and (x + 1)
simultaneously at the tile boundary (that is, either both or neither
are wrapped). This obviously won't work, since along the tile seams,
(x + 1) should be wrapped, but x should not. The same is true in y.

This patch fixes both the CPU and GPU paths, renames some variables to
more closely match the spec, and modifies the perlin noise GM to
actually test tiling. (Note that the clipping the GM was doing was
removed, since it's superfluous: it used to be necessary for image
filters, but isn't anymore, and this isn't an image filter GM anyway.)

R=sugoi@google.com, sugoi
TBR=senorblanco

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/332523006
 2014-06-12 11:24:20 -07:00
egdaniel
e61c411c12 Use vertex attributes for dash effect in gpu 
This will allow us to batch dashed lines together when drawing. Also, this removes the need for
a coord transform matrix in the shader, thus we save the cost of uploading a new matrix uniform
everytime we do a simple transform to the dashed line we are drawing.

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/326103002
 2014-06-12 10:24:21 -07:00
egdaniel
b5dcdf1e7e Rebase flakey windows dash4 gm 
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:2667

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/335443003
 2014-06-12 08:02:43 -07:00
egdaniel
aea9cfbe8a Add expectations for dashing gm 
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/330033002
 2014-06-12 06:26:16 -07:00